Hi Laurent & co.,
I'd like to look at what the maximum possible frame rates are for a
sensor connected to the OMAP3 ISP CCDC via the parallel interface,
writing frames directly to memory. I understand that there is some
minimum amount of time required between frames to pass on the finished
f
Hi Laurent,
I am looking at a case where the sensor may stop delivering data, at
which point I want to do a STREAMOFF. In this case, the STREAMOFF takes
2s because of the wait_event_timeout() in ccdc_disable(). This wait
waits for ccdc->stopping to be CCDC_STOP_FINISHED, which happens in two
On 08/14/2012 05:21 PM, Laurent Pinchart wrote:
Hi Mauro,
On Tuesday 14 August 2012 11:28:05 Mauro Carvalho Chehab wrote:
Em 14-08-2012 10:46, Hans Verkuil escreveu:
That would work if the others would be doing the same. Unfortunately, other
usual developers don't do that: they send all patches
Hi Laurent,
On 07/27/2012 11:35 AM, Laurent Pinchart wrote:
On Friday 27 July 2012 11:07:50 Michael Jones wrote:
Hi Laurent,
On 07/27/2012 01:32 AM, Laurent Pinchart wrote:
Hi Michael,
[snip]
OK, so this sounds like the same behavior I'd like to add before
CREATE_BUFS and PREPARE
Hi Laurent,
On 07/27/2012 01:32 AM, Laurent Pinchart wrote:
Hi Michael,
On Thursday 26 July 2012 16:22:17 Michael Jones wrote:
On 07/26/2012 04:05 PM, Laurent Pinchart wrote:
On Thursday 26 July 2012 13:59:54 Michael Jones wrote:
Hello,
I would like to (re)submit a couple of patches to
include/linux/omap3isp.h uses BASE_VIDIOC_PRIVATE from include/linux/videodev2.h
but didn't include this file.
Signed-off-by: Michael Jones
---
include/linux/omap3isp.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/omap3isp.h b/include/linux/omap3
Signed-off-by: Michael Jones
---
Documentation/video4linux/v4l2-framework.txt |2 +-
drivers/media/video/omap3isp/ispqueue.c |2 +-
drivers/media/video/omap3isp/ispresizer.c|6 +++---
drivers/media/video/v4l2-common.c|2 +-
include/media/v4l2-common.h
Hi Laurent,
Thanks for the reply.
On 07/26/2012 04:05 PM, Laurent Pinchart wrote:
Hi Michael,
On Thursday 26 July 2012 13:59:54 Michael Jones wrote:
Hello,
I would like to (re)submit a couple of patches to support V4L2 behavior at
the V4L2 device nodes of the omap3-isp driver, but I&#
This allows a V4L2 application which has no knowledge of the media
controller to open a video device node of the already-configured ISP
and query what it will deliver. Previously, G_FMT only worked after a
S_FMT had already been done.
Signed-off-by: Michael Jones
---
drivers/media/video
ENUM_FMT will not enumerate all formats that the ISP is capable of,
it will only return the format which has been previously configured
using the media controller, because this is the only format available
to a V4L2 application which is unaware of the media controller.
Signed-off-by: Michael
hes on v3.4, but I have rebased them to v3.5 here.
I would remove the pr_debug() calls before submitting upstream, but they're
useful for testing.
[1] http://www.mail-archive.com/linux-media@vger.kernel.org/msg29640.html
[2] http://www.mail-archive.com/linux-media@vger.kernel.org/msg40618.ht
Hi Laurent,
I've used "behavior" when copying sections from the existing documentation.
I'll unify that. Does kernel documentation favour one of the spellings ?
Looking at v3.5, the American spelling is more common, but looking at
how you spell favour, I think I know which one you favor :)
Hi Laurent,
At a quick glance I noticed a couple of things:
On 07/13/2012 02:00 AM, Laurent Pinchart wrote:
[snip]
+
+ The drm_driver structure contains static
+ information that describe the driver and features it supports, and
s/describe/describes/
+ pointers to metho
Hi Laurent & co.,
I'm looking at the memory limitations in the omap3isp driver. 'struct
isp_video' contains member 'capture_mem', which is set separately for
each of our v4l2 video device nodes. The CCDC, for example, has
capture_mem = 4096 * 4096 * 3 = 48MB, while the previewer and resizer
Signed-off-by: Michael Jones
---
drivers/media/video/omap3isp/ispqueue.c |9 ++---
1 files changed, 2 insertions(+), 7 deletions(-)
This comment looks like it was a copy-paste from the description of qbuf.
diff --git a/drivers/media/video/omap3isp/ispqueue.c
b/drivers/media/video
Hi Laurent,
On 03/20/2012 12:22 AM, Laurent Pinchart wrote:
Hi Michael,
On Friday 16 March 2012 15:06:15 Michael Jones wrote:
[snip]
Adding a R/W bit to the flag argument should indeed work. However, I'm
wondering what your use case for reading parameters back is.
The simplest use ca
Hi all,
I am playing around with some parameters in the previewer on the ISP.
With ioctl VIDIOC_OMAP3ISP_PRV_CFG I am able to write the various
parameters but what I'm missing is a way to read them. For example, I
have no way to adjust only coef2 in 'struct omap3isp_prev_wbal' while
leaving
Hi Laurent,
On 03/09/2012 11:42 AM, Laurent Pinchart wrote:
Hi Jean-Philippe,
[snip]
From my experience, the ISP doesn't handle free-running sensors very well.
There are other things it doesn't handle well, such as sensors stopping in the
middle of the frame. I would consider this as limitat
Hi Sakari,
Hopefully it's not too late to make a few minor suggestions.
On 03/06/2012 05:32 PM, Sakari Ailus wrote:
Add documentation for V4L2 subdev selection API. This changes also
experimental V4L2 subdev API so that scaling now works through selection API
only.
Signed-off-by: Sakari Ailus
Hi James,
On 12/15/2011 10:49 AM, James wrote:
Hi Michael,
On Thu, Dec 15, 2011 at 3:58 PM, Michael Jones
wrote:
Hi James,
On 12/15/2011 08:14 AM, James wrote:
Hi all,
I'm using an OMAP3530 board and a monochrome 12-bit grey sensor.
Can anyone enlighten me why is the 12-bit
Hi James,
On 12/15/2011 08:14 AM, James wrote:
Hi all,
I'm using an OMAP3530 board and a monochrome 12-bit grey sensor.
Can anyone enlighten me why is the 12-bit grey formats at the CCDC
input (Y12) is truncated to Y10 at the CCDC output?
There are 2 CCDC outputs: CCDC_PAD_SOURCE_OF and CCDC
Hi Adam,
On 12/07/2011 11:34 AM, Laurent Pinchart wrote:
Hi Adam,
On Wednesday 07 December 2011 09:02:42 Adam Pledger wrote:
Hi Laurent,
Firstly, please accept my apologies, for what is very probably a naive
question. I'm new to V4L2 and am just getting to grips with how things
work.
No wor
Hi Chris,
On 08/22/2011 11:41 AM, Laurent Pinchart wrote:
>
> Hi Chris,
>
> On Monday 22 August 2011 06:12:41 CJ wrote:
>> On 19/08/11 22:12, Laurent Pinchart wrote:
I am trying to get the mt9p031 working from nand with a ubifs file
system and I am having a few problems.
/dev
Hi Laurent,
If I understood your discussion with Russell [1] correctly, user pointer
buffers are required to be page-aligned because of the IOMMU API, and
it's desirable to keep the IOMMU driver that way for other subsystems
which may use it. So we're stuck with user buffers needing to be
page-ali
Add buffer length check to sanity checks for USERPTR QBUF
Signed-off-by: Michael Jones
---
Changes for v2:
- only check when V4L2_MEMORY_USERPTR
drivers/media/video/omap3isp/ispqueue.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/omap3isp
Hi Laurent,
On 08/08/2011 12:08 PM, Laurent Pinchart wrote:
>
> Hi Michael,
>
> On Friday 05 August 2011 13:41:54 Michael Jones wrote:
>> On 08/05/2011 10:59 AM, Laurent Pinchart wrote:
>>> Hi Michael,
>>>
>>> Thanks for the patch.
>>>
>&
Hi Laurent,
On 08/05/2011 10:59 AM, Laurent Pinchart wrote:
>
> Hi Michael,
>
> Thanks for the patch.
>
> On Thursday 04 August 2011 17:40:37 Michael Jones wrote:
>> Add buffer length to sanity checks for QBUF.
>>
>> Signed-off-by: Michael Jones
>
Hi Laurent,
On 07/20/2011 10:47 AM, Laurent Pinchart wrote:
>
> Hi Michael,
>
> Sorry for the late reply.
Likewise :)
>
> On Thursday 30 June 2011 10:31:52 Michael Jones wrote:
>> Hi Laurent,
>>
>> I'm observing a system freeze-up with the ISP when wr
Add buffer length to sanity checks for QBUF.
Signed-off-by: Michael Jones
---
drivers/media/video/omap3isp/ispqueue.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/omap3isp/ispqueue.c
b/drivers/media/video/omap3isp/ispqueue.c
index 9c31714
have been fixed.
Signed-off-by: Michael Jones
---
contrib/test/capture-example.c |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/contrib/test/capture-example.c b/contrib/test/capture-example.c
index 2f77cbf..417615a 100644
--- a/contrib/test/capture-example.c
+++
Hi Mauro,
On 07/14/2011 12:35 AM, Mauro Carvalho Chehab wrote:
> Em 28-06-2011 11:23, Michael Jones escreveu:
>> There is an assumption that the format coming from the device
>> needs 2 bytes per pixel, which is not the case when the device
>> delivers e.g. V4L2_PIX_F
On 04/11/2011 04:26 PM, Laurent Pinchart wrote:
> Subdevs already have their own entity, don't register as second one when
> registering the subdev device node.
>
> Signed-off-by: Laurent Pinchart
> ---
> drivers/media/video/v4l2-dev.c | 15 ++-
> 1 files changed, 10 insertions(+),
---
yavta.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/yavta.c b/yavta.c
index 2a166c6..95976b4 100644
--- a/yavta.c
+++ b/yavta.c
@@ -485,7 +485,9 @@ static int video_enable(struct device *dev, int enable)
int type = dev->type;
int ret;
+
any other format
directly from the CCDC.
I'll postpone further discussion until you confirm that you can reproduce the
behavior. As the patch illustrates, it looks like it is hanging up in STREAMON.
-Michael
Michael Jones (1):
prompt ISP CCDC freeze-up on STREAMON
yavta.c |8 +
I am trying to get omap3-isp.ko to be loaded upon bootup. The problem
is that iommu2.ko needs to be loaded first, which can't just be compiled
into the kernel. Udev will see '/sys/devices/platform/omap3isp' and
load omap3-isp.ko, which fails because iommu2.ko hasn't been loaded yet.
iommu2 doesn
ned-off-by: Michael Jones
---
This same issue would apply to other formats which have 1 byte per pixel,
this patch only fixes it for GREY. Is this OK for now, or does somebody
have a better suggestion for supporting other formats as well?
contrib/test/capture-example.c |4 +++-
1 files
Autoconf v2.61 seems to work just fine. Allow it.
Signed-off-by: Michael Jones
---
configure.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure.in b/configure.in
index 3f4f35b..fd4c70c 100644
--- a/configure.in
+++ b/configure.in
@@ -1,4 +1,4 @@
-AC_PREREQ
Signed-off-by: Michael Jones
---
I added these when playing around with the shifter.
src/main.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/main.c b/src/main.c
index 35c34a2..b9b9150 100644
--- a/src/main.c
+++ b/src/main.c
@@ -50,6 +50,8 @@ static struct
Hi Laurent,
These are a couple of commits that I have locally on top of your media-ctl head
which I would like to see in your rep.
Michael Jones (2):
add Y10, Y12 formats
try using autoconf 2.61
configure.in |2 +-
src/main.c |2 ++
2 files changed, 3 insertions(+), 1 deletions
In the V4L2 spec, the description for v4l2_buffer.index says "This field
is only used for memory mapping I/O..."
However, in v4l-utils/contrib/capture-example.c, even user-pointer
buffers are indeed given a buf.index before being passed to VIDIOC_QBUF.
And at least in the OMAP ISP driver, this in
On 05/20/2011 09:29 AM, Laurent Pinchart wrote:
[snip]
>> I had an issue when tried to call request_module, to register subdev of
>> platform device type, in probe() of other platform device. Driver's
>> probe() for devices belonging same bus type cannot be nested as the bus
>> lock is taken by t
On 05/19/2011 03:56 PM, Laurent Pinchart wrote:
> Hi Michael,
>
> On Thursday 19 May 2011 15:44:18 Michael Jones wrote:
>> On 05/19/2011 03:02 PM, Laurent Pinchart wrote:
>>> On Thursday 19 May 2011 14:51:16 Alex Gershgorin wrote:
>>>> Thanks Laurent,
>&g
On 05/19/2011 03:02 PM, Laurent Pinchart wrote:
> Hi Alex,
>
> On Thursday 19 May 2011 14:51:16 Alex Gershgorin wrote:
>> Thanks Laurent,
>>
>> My video source is not the video camera and performs many other functions.
>> For this purpose I have RS232 port.
>> As for the video, it runs continuousl
Hi Laurent,
I can't find where the locking is handled for ISP subdev standard ioctls
like ccdc_v4l2_pad_ops.set_fmt(). Using the CCDC as an example, it
looks to me like the following sequence happens when e.g. format is set
on CCDC pad 0:
1. # media-ctl --set-format '"OMAP3 ISP CCDC":0 [Y8 640x4
Hi Laurent,
On 03/29/2011 09:40 PM, Laurent Pinchart wrote:
> Hi Michael,
>
> Thanks for the patches. I've applied them to my tree
> (http://git.linuxtv.org/pinchartl/media.git?a=shortlog;h=refs/heads/media-
> next-0001-omap3isp) with modified commit messages.
thanks.
> Could you please check
To use the lane shifter, set different pixel formats at each end of
the link at the CCDC input.
Signed-off-by: Michael Jones
---
drivers/media/video/omap3isp/isp.c |7 ++-
drivers/media/video/omap3isp/isp.h |5 +-
drivers/media/video/omap3isp/ispccdc.c | 27
Signed-off-by: Michael Jones
---
Documentation/DocBook/v4l/subdev-formats.xml | 59 ++
include/linux/v4l2-mediabus.h|7 ++-
2 files changed, 64 insertions(+), 2 deletions(-)
diff --git a/Documentation/DocBook/v4l/subdev-formats.xml
b/Documentation
Signed-off-by: Michael Jones
Acked-by: Laurent Pinchart
---
drivers/media/video/omap3isp/ispccdc.c |6 ++
drivers/media/video/omap3isp/ispvideo.c | 12
2 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/omap3isp/ispccdc.c
b/drivers/media
Signed-off-by: Michael Jones
---
Documentation/DocBook/media-entities.tmpl |1 +
Documentation/DocBook/v4l/pixfmt-y12.xml | 79 +
Documentation/DocBook/v4l/pixfmt.xml |1 +
include/linux/videodev2.h |1 +
4 files changed, 82
x27;shift' arg to omap3isp_configure_bridge()
-misc minor changes according to feedback (removed unnecessary tests, etc.)
Michael Jones (4):
v4l: add V4L2_PIX_FMT_Y12 format
media: add 8-bit bayer formats and Y12
omap3isp: ccdc: support Y10/12, 8-bit bayer fmts
omap3isp: lane shifter
Hi Laurent,
On 03/24/2011 11:36 AM, Laurent Pinchart wrote:
> Hi,
>
[snip]
>
> Padding at end of line can be configured through S_FMT. Other than that, all
> other options (width, height, pixelcode) are fixed for a given mbus format
> *for the ISP driver*. Other drivers might support different
Hi Sakari,
On 03/24/2011 09:04 AM, Sakari Ailus wrote:
> Michael Jones wrote:
>> Hi Sakari,
>
> Hi Michael,
>
>> On 03/23/2011 10:52 AM, Sakari Ailus wrote:
>>> Hi Michael,
>>>
>>> Thanks for the patch.
>>>
>>> Michael Jones
It only contains generated files
Signed-off-by: Michael Jones
Acked-by: Laurent Pinchart
---
Re-sending this because patchwork didn't catch it the first time.
Documentation/DocBook/.gitignore |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Documentation/Do
On 03/16/2011 03:22 PM, Michael Jones wrote:
>>From 81a09633855b88d19f013d7e559e0c4f602ba711 Mon Sep 17 00:00:00 2001
> From: Michael Jones
> Date: Thu, 10 Mar 2011 16:16:38 +0100
> Subject: [PATCH] ignore Documentation/DocBook/media/
>
> It is created and popula
Hi Laurent,
On 03/23/2011 01:16 PM, Laurent Pinchart wrote:
> Hi Michael,
>
[snip]
>>
>> Is there a policy decision that in the future, apps will be required to
>> use libv4l to get images from the ISP? Are we not intending to support
>> using e.g. media-ctl + some v4l2 app, as I'm currently doi
Hi Sakari,
On 03/23/2011 10:52 AM, Sakari Ailus wrote:
> Hi Michael,
>
> Thanks for the patch.
>
> Michael Jones wrote:
>> From dccbd4a0a717ee72a3271075b1e3456a9c67ca0e Mon Sep 17 00:00:00 2001
>> From: Michael Jones
>> Date: Tue, 22 Mar 2011 11:47:22 +
>From dccbd4a0a717ee72a3271075b1e3456a9c67ca0e Mon Sep 17 00:00:00 2001
From: Michael Jones
Date: Tue, 22 Mar 2011 11:47:22 +0100
Subject: [PATCH] omap3isp: implement ENUM_FMT
Whatever format is currently being delivered will be declared as the only
possible format
Signed-off-by: Michael Jo
On 03/21/2011 06:43 PM, Laurent Pinchart wrote:
> Hi Loïc,
>
> On Friday 18 March 2011 16:43:40 Loïc Akue wrote:
>> Hi,
>>
>> Do you know if Gstreamer or Mplayer are able to capture some vidéo from the
>> CCDC output?
>> I've been trying with the v4l2src plugin but Gstreamer "can negociate
>> form
On 03/17/2011 04:40 PM, Sakari Ailus wrote:
> Hi Laurent and Michael,
>
> Laurent Pinchart wrote:
>> On Thursday 17 March 2011 11:07:40 Michael Jones wrote:
>>> On 03/16/2011 06:46 PM, Laurent Pinchart wrote:
>>>> On Wednesday 16 March 2011 18:08:04 Sakari
Hi Sakari,
Thanks for the review.
On 03/16/2011 06:46 PM, Laurent Pinchart wrote:
> Hi Sakari,
>
> On Wednesday 16 March 2011 18:08:04 Sakari Ailus wrote:
>> Laurent Pinchart wrote:
>>> Hi Sakari,
> + return in_info->bpp - out_info->bpp + additional_shift <= 6;
Currently there are
>From 81a09633855b88d19f013d7e559e0c4f602ba711 Mon Sep 17 00:00:00 2001
From: Michael Jones
Date: Thu, 10 Mar 2011 16:16:38 +0100
Subject: [PATCH] ignore Documentation/DocBook/media/
It is created and populated by 'make htmldocs'
Signed-off-by: Michael Jones
---
Document
Hi Bastian,
On 03/16/2011 11:01 AM, Bastian Hecht wrote:
> Hello dear omap-isp developers,
>
> I'm working with a OV5642 sensor with an 8-bit parallel bus.
>
> I'm referring to this patch:
> http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/29876/match=sgrbg8
>
> Michael,
On 03/11/2011 10:21 AM, Antonio Ospite wrote:
> Hi Michael,
>
> are you going to release also Y12 conversion routines for libv4lconvert?
>
> Regards,
>Antonio
>
Hi Antonio,
As I am neither a user nor developer of libv4lconvert, I am not planning
on adding Y12 conversion routines there. Ho
To use the lane shifter, set different pixel formats at each end of
the link at the CCDC input.
Signed-off-by: Michael Jones
---
drivers/media/video/omap3-isp/isp.c |7 ++-
drivers/media/video/omap3-isp/isp.h |5 +-
drivers/media/video/omap3-isp/ispccdc.c | 27
Signed-off-by: Michael Jones
Acked-by: Laurent Pinchart
---
drivers/media/video/omap3-isp/ispccdc.c |6 ++
drivers/media/video/omap3-isp/ispvideo.c | 12
2 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/omap3-isp/ispccdc.c
b/drivers
Signed-off-by: Michael Jones
---
Documentation/DocBook/v4l/subdev-formats.xml | 59 ++
include/linux/v4l2-mediabus.h|7 ++-
2 files changed, 64 insertions(+), 2 deletions(-)
diff --git a/Documentation/DocBook/v4l/subdev-formats.xml
b/Documentation
Signed-off-by: Michael Jones
---
Documentation/DocBook/v4l/pixfmt-y12.xml | 79 ++
include/linux/videodev2.h|1 +
2 files changed, 80 insertions(+), 0 deletions(-)
create mode 100644 Documentation/DocBook/v4l/pixfmt-y12.xml
diff --git a
() to ccdc_configure()
-added 'shift' arg to omap3isp_configure_bridge()
-misc minor changes according to feedback (removed unnecessary tests, etc.)
Michael Jones (4):
v4l: add V4L2_PIX_FMT_Y12 format
media: add 8-bit bayer formats and Y12
omap3isp: ccdc: support Y10/12, 8-bit baye
Hi Laurent,
On 03/10/2011 11:21 AM, Laurent Pinchart wrote:
> Hi Michael,
>
[snip]
> I've had a closer look at the boards I have here, and it turns out one of
> them
> connects a 10-bit sensor to DATA[11:2] :-/ data_lane_shift is thus needed for
> it.
>
> I'm fine with leaving data_lane_shift
Hi Laurent,
Thanks for the review. Most of your suggestions didn't warrant
discussion and I will incorporate those changes. The others are below.
On 03/10/2011 01:13 AM, Laurent Pinchart wrote:
> Hi Michael,
>
> Thanks for the patch.
>
> On Wednesday 09 March 2011 17
To use the lane shifter, set different pixel formats at each end of
the link at the CCDC input.
Signed-off-by: Michael Jones
---
drivers/media/video/omap3-isp/isp.c |6 +-
drivers/media/video/omap3-isp/isp.h |5 +-
drivers/media/video/omap3-isp/ispccdc.c | 26
Signed-off-by: Michael Jones
---
drivers/media/video/omap3-isp/ispccdc.c |6 ++
drivers/media/video/omap3-isp/ispvideo.c | 12
2 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/omap3-isp/ispccdc.c
b/drivers/media/video/omap3-isp
Signed-off-by: Michael Jones
Acked-by: Laurent Pinchart
---
include/linux/v4l2-mediabus.h |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/include/linux/v4l2-mediabus.h b/include/linux/v4l2-mediabus.h
index 7054a7a..46caecd 100644
--- a/include/linux/v4l2
Signed-off-by: Michael Jones
Acked-by: Laurent Pinchart
---
include/linux/videodev2.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
index 02da9e7..6fac463 100644
--- a/include/linux/videodev2.h
+++ b/include/linux
nd return bool
-moved 'shift' calculation from omap3isp_configure_bridge() to ccdc_configure()
-added 'shift' arg to omap3isp_configure_bridge()
-misc minor changes according to feedback (removed unnecessary tests, etc.)
Michael Jones (4):
v4l: add V4L2_PIX_FMT_Y12 format
medi
On 03/08/2011 09:31 PM, Guzman Lugo, Fernando wrote:
> On Tue, Mar 8, 2011 at 2:15 PM, David Cohen wrote:
>> From: Michael Jones
>>
>> commit c7f4ab26e3bcdaeb3e19ec658e3ad9092f1a6ceb allowed mapping the NULL
>> address if da_start==0, which would then not get unmapped
>From e7dbe4c4b64eb114f9b0804d6af3a3ca0e78acc8 Mon Sep 17 00:00:00 2001
From: Michael Jones
Date: Mon, 7 Mar 2011 13:36:15 +0100
Subject: [PATCH] omap: iommu: disallow mapping NULL address
commit c7f4ab26e3bcdaeb3e19ec658e3ad9092f1a6ceb allowed mapping
the NULL address if da_start==0. Fo
Hi Laurent,
Thanks for the review.
On 03/04/2011 05:33 PM, Laurent Pinchart wrote:
> Hi Michael,
>
> Thanks for the patch.
>
> On Friday 04 March 2011 09:58:04 Michael Jones wrote:
>> Signed-off-by: Michael Jones
>> ---
>> drivers/media/
fix, so hopefully
>> some new recipients on this can make suggestions/comments.
>>
>> The patch below solves the problem, which modifies a commit by Fernando
>> Guzman Lugo from December.
>>
>> -Michael
>>
>> From db35fb8edca2a4f8fd37197d77fd58676cb1dca
Signed-off-by: Michael Jones
---
drivers/media/video/omap3-isp/isp.c | 82 +-
drivers/media/video/omap3-isp/isp.h |4 +-
drivers/media/video/omap3-isp/ispccdc.c |2 +-
drivers/media/video/omap3-isp/ispvideo.c | 65
Signed-off-by: Michael Jones
---
drivers/media/video/omap3-isp/ispccdc.c |4
drivers/media/video/omap3-isp/ispvideo.c |8
2 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/omap3-isp/ispccdc.c
b/drivers/media/video/omap3-isp/ispccdc.c
Signed-off-by: Michael Jones
---
include/linux/v4l2-mediabus.h |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/include/linux/v4l2-mediabus.h b/include/linux/v4l2-mediabus.h
index 7054a7a..46caecd 100644
--- a/include/linux/v4l2-mediabus.h
+++ b/include/linux/v4l2
Signed-off-by: Michael Jones
---
include/linux/videodev2.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
index 02da9e7..6fac463 100644
--- a/include/linux/videodev2.h
+++ b/include/linux/videodev2.h
@@ -288,6
tency
check is first done when activating the pipeline.
These patches apply to Laurent's media-0005-omap3isp branch, based on 2.6.38-rc5
Michael Jones (4):
v4l: add V4L2_PIX_FMT_Y12 format
media: add 8-bit bayer formats and Y12
omap3isp: ccdc: support Y10, Y12, SGRBG8, SBGGR8
omap
On 03/02/2011 08:18 PM, Laurent Pinchart wrote:
> Hi Michael,
>
> On Tuesday 01 March 2011 17:41:01 Michael Jones wrote:
>> Hi all,
>>
>> I get a warning about a cache error with the following steps:
>>
>> 0. load omap3-isp
>> 1. set up media broken m
Hi all,
I get a warning about a cache error with the following steps:
0. load omap3-isp
1. set up media broken media pipeline. (e.g. set different formats on
opposite ends of a link, as will be the case for using the lane shifter)
2. try to capture images. isp_video_streamon() returns -EPIPE fro
is a sensible approach, I will go ahead and
submit my patch soon.
thanks,
Michael
On 02/11/2011 02:06 PM, Laurent Pinchart wrote:
> Hi Michael,
>
> On Friday 11 February 2011 13:07:33 Michael Jones wrote:
>> On 01/27/2011 12:46 AM, Guennadi Liakhovetski wrote:
>>> Looking at
isp as a module? How are you guys
getting around this?
-Michael
On 01/19/2011 12:30 AM, Laurent Pinchart wrote:
> Hi Michael,
>
> On Tuesday 18 January 2011 17:14:37 Michael Jones wrote:
>> Hi Laurent & Sakari,
>>
>> On Laurent's media-0006-sensors branch, whe
Hi Laurent,
On 01/27/2011 12:46 AM, Guennadi Liakhovetski wrote:
> Looking at the "Data-Lane Shifter" table (12.27 in my datasheet, in the
> "Bridge-Lane Shifter" chapter), I think, the first two columns are fixed
> by the board design, right? So, our freedom lies only in one line there
> and
Hi Guennadi, Laurent,
On 01/27/2011 12:46 AM, Guennadi Liakhovetski wrote:
>>
>>> I didn't realize the video port can further shift the data. Where can I
>>> find this in the TRM?
>>
>> VPIN field of the CCDC_FMTCFG register.
>
> This only plays a role, if cam_d is set to 10 bits raw in
> CC
Hi Laurent,
On 01/24/2011 08:45 PM, Laurent Pinchart wrote:
> Hi Michael,
>
> On Monday 24 January 2011 15:16:28 Michael Jones wrote:
>> On 01/24/2011 02:57 PM, Laurent Pinchart wrote:
>>
>>
>>>>> As the lane shifter is located at the CCDC input, it
Hi Laurent,
On 01/24/2011 02:57 PM, Laurent Pinchart wrote:
>>>
>>> As the lane shifter is located at the CCDC input, it might be easier to
>>> implement support for this using the CCDC input format. ispvideo.c would
>>> need to validate the pipeline when the output of the entity connected to
>>>
Hi Laurent,
Thanks for the feedback.
On 01/24/2011 01:10 AM, Laurent Pinchart wrote:
> Hi Michael,
>
> On Friday 21 January 2011 09:40:21 Michael Jones wrote:
>> Hi all,
>>
>> In the OMAP ISP driver, I'm interested in being able to choose between
>> 8-bit a
Hi all,
In the OMAP ISP driver, I'm interested in being able to choose between
8-bit and 12-bit formats when I have a 12-bit sensor attached. At the
moment it looks like it's only possible to define this statically with
data_lane_shift in the board definition. But with the ISP's lane
shifter, it
Hi Laurent,
On 01/19/2011 05:38 PM, Laurent Pinchart wrote:
> Hi Michael,
>
@@ -1144,10 +1148,15 @@ static void ccdc_configure(struct
isp_ccdc_device *ccdc) else
syn_mode &= ~ISPCCDC_SYN_MODE_SDR2RSZ;
- isp_reg_writel(isp, syn_mode, OMAP3_ISP_IOMEM_CCDC,
Hi Martin,
a couple of comments inline below.
On 01/19/2011 12:27 AM, Laurent Pinchart wrote:
> Hi Martin,
>
> Thanks for the patch. One comment below.
>
> On Tuesday 18 January 2011 22:27:42 Martin Hostettler wrote:
>> Adds support for V4L2_MBUS_FMT_Y8_1X8 format and 8bit data width in
>> sync
Hi Laurent & Sakari,
On Laurent's media-0006-sensors branch, when compiling with
CONFIG_VIDEO_OMAP3=m, I got the following linking error:
ERROR: "omap_pm_set_min_bus_tput" [drivers/media/video/isp/omap3-isp.ko]
undefined!
I can get rid of the error with the patch below. But as always, I
wonder:
27;m correct about the problem, it's not about the parallel sensor,
it's about writing the data from the CCDC to memory. I expect the
problem to occur with a serial sensor too if the CCDC writes to memory.
--
Michael Jones
MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registerge
rising edge? This is defined for CCP2 and
> this is what the driver was originally written for. If it's different
> (rising??), you should apply the attached wildly opportunistic patch,
> which I do not expect to fix this problem, however.
>
> But I might be just pointing you to wro
ock_irqsave(&ccdc->lsc.req_lock, flags);
/* We are about to stop CCDC and/without LSC */
- if ((ccdc->output & CCDC_OUTPUT_MEMORY) ||
+ if ((ccdc->output & CCDC_OUTPUT_MEMORY) &&
(ccdc->state == ISP_PIPELINE_STREAM_SINGLESHOT))
1 - 100 of 107 matches
Mail list logo
