Re: rc: ene_ir: few fixes

2013-07-15 Thread Maxim Levitsky
On Thu, Jul 11, 2013 at 3:29 AM, Maxim Levitsky wrote: > Any update? > > Best regards, > Maxim Levitsky > > > On Mon, 2013-07-08 at 03:22 +0300, Maxim Levitsky wrote: >> Hi, >> >> Could you consider merging few fixes to my driver: >> >> 1. Fix a

Re: rc: ene_ir: few fixes

2013-07-10 Thread Maxim Levitsky
Any update? Best regards, Maxim Levitsky On Mon, 2013-07-08 at 03:22 +0300, Maxim Levitsky wrote: > Hi, > > Could you consider merging few fixes to my driver: > > 1. Fix accidently introduced error, that is the hardware is a bit unusual > in the way that it needs the int

[PATCH 3/3] ene_ir: don't use pr_debug after all

2013-07-07 Thread Maxim Levitsky
This way to only way to get debug info is to use dynamic debug, but I left debugging prints to debug hardware issues, and so I want this to be enabled by module param Signed-off-by: Maxim Levitsky --- drivers/media/rc/ene_ir.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 1/3] ene_ir: Fix interrupt line passthrough to hardware

2013-07-07 Thread Maxim Levitsky
While we can delay IRQ intialization, we need the interrupt number right away because unusually hardware have programable interrupt number, and thus we give it the number that was allocated by BIOS Signed-off-by: Maxim Levitsky --- drivers/media/rc/ene_ir.c |3 ++- 1 file changed, 2

rc: ene_ir: few fixes

2013-07-07 Thread Maxim Levitsky
n too restructive in enabling it. If you allow, I want to use pr_info instead. patch #1 should go to stable as well, as it outright breaks my driver. PS: I am very short on time, and I will be free in about month, after I pass another round of exams. Best regards, Maxim Levitsky -- To unsubs

[PATCH 2/3] ene_ir: disable the device if wake is disabled It doesn't hurt and on my notebook despite clearing the wake flag the remote still wakes up the system. This way it doesn't

2013-07-07 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- drivers/media/rc/ene_ir.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/media/rc/ene_ir.c b/drivers/media/rc/ene_ir.c index a9cf3a4..61865ba 100644 --- a/drivers/media/rc/ene_ir.c +++ b/drivers/media

Re: How to help with RTL2832U based TV?

2011-01-17 Thread Maxim Levitsky
t). > > I would appreciate that this be in the kernel tree proper I am doing a driver rewrite. Don't know when I finish it though. Could you tell me what tuner you have, and does your card also support DVB-C? (some Realtek cards also support Chinese DTMB, but even if yours does, you prob

Re: [PATCH 3/4] rc: conversion is to microseconds, not nanoseconds

2010-12-16 Thread Maxim Levitsky
well. Nope, at least ENE gets 'us' samples, that is 10^-6 seconds, and I multiply that by 1000, and that gives nanoseconds (10^-9). I have nothing against moving MS_TO_NS to common code of course. Best regards, Maxim Levitsky > > Reported-by: David Härdeman > CC:

Re: rtl2832u support

2010-12-06 Thread Maxim Levitsky
ure like I said, I can manage without them. But if I had datasheets in addition to working code, it would be better. Best regards, Maxim Levitsky > > Alex > > > > > Maxim Levitsky wrote: > >> > >> On Mon, 2010-12-06 at 16:45 +0100, Jan Hoogenraad wrote:

Re: rtl2832u support

2010-12-06 Thread Maxim Levitsky
their 'windows' driver v1.4 doesn't work here. Only 2.0 driver works. And you said that you couldn't seperate demod from bridge? Is that nessesary? I have seen few drivers that don't separate it in v4l source. Tuners are of course another story. Best regards, Maxi

New developer for RTL2832U DVB device

2010-12-04 Thread Maxim Levitsky
t way. In this mail, I tried to CC few developers that have shown an interest in this driver. I also CCed few realtek employees whose addresses I could find in mail archive. I really do hope for an answer (don't mind if it is private). Best regards, Maxim Levitsky -- To unsubscribe

Re: rtl2832u support

2010-11-26 Thread Maxim Levitsky
On Sun, 2010-11-21 at 00:37 +0200, Maxim Levitsky wrote: > On Fri, 2010-11-19 at 09:36 +0200, Maxim Levitsky wrote: > > On Wed, 2010-11-17 at 12:15 +0100, Damjan Marion wrote: > > > On Oct 19, 2010, at 10:27 PM, Hans Verkuil wrote: > > > > On Tuesday, October 19, 2

Re: rtl2832u support

2010-11-20 Thread Maxim Levitsky
On Fri, 2010-11-19 at 09:36 +0200, Maxim Levitsky wrote: > On Wed, 2010-11-17 at 12:15 +0100, Damjan Marion wrote: > > On Oct 19, 2010, at 10:27 PM, Hans Verkuil wrote: > > > On Tuesday, October 19, 2010 21:26:13 Devin Heitmueller wrote: > > >> On Tue, Oct 19,

Re: rtl2832u support

2010-11-18 Thread Maxim Levitsky
not* linuxtv as such, and secondly you can upstream such > > drivers in the staging tree. If you want to move it out of staging, then > > it will take indeed more work since the quality requirements are higher > > there. > > > Do we have a common agreement th

[PATCH] IR: initialize ir_raw_event in few more drivers

2010-10-24 Thread Maxim Levitsky
Few drivers still have assumption that ir_raw_event consists of duration and pulse flag. Fix that. Signed-off-by: Maxim Levitsky --- drivers/media/dvb/siano/smsir.c |2 +- drivers/media/video/cx23885/cx23888-ir.c |1 + drivers/media/video/cx25840/cx25840-ir.c |1 + 3 files

Re: [PATCH RFC] ir-rc5-decoder: don't wait for the end space to produce a code

2010-10-22 Thread Maxim Levitsky
On Fri, 2010-10-22 at 23:39 -0200, Mauro Carvalho Chehab wrote: > Em 22-10-2010 23:25, Maxim Levitsky escreveu: > > On Thu, 2010-10-21 at 11:56 -0200, Mauro Carvalho Chehab wrote: > >> Em 21-10-2010 11:46, Jarod Wilson escreveu: > >>> On Oct 20, 2010, at 1:18 P

Re: [PATCH RFC] ir-rc5-decoder: don't wait for the end space to produce a code

2010-10-22 Thread Maxim Levitsky
patch resolves the issue genericly by making the driver send the timeout message at the end of the data among the current length of the space (which will continue to grow). Just make mceusb send the timeout sample. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] Remaining patches in my queue for IR

2010-10-21 Thread Maxim Levitsky
On Wed, 2010-10-20 at 14:40 -0400, Jarod Wilson wrote: > On Sun, Oct 17, 2010 at 12:56:27AM +0200, Maxim Levitsky wrote: > > Hi, > > > > This series is rebased on top of media_tree/staging/v2.6.37 only. > > Really this time, sorry for cheating, last time :-) >

Re: [PATCH 0/3] Remaining patches in my queue for IR

2010-10-16 Thread Maxim Levitsky
On Sat, 2010-10-16 at 20:36 -0400, Andy Walls wrote: > On Sun, 2010-10-17 at 00:56 +0200, Maxim Levitsky wrote: > > Hi, > > > > This series is rebased on top of media_tree/staging/v2.6.37 only. > > Really this time, sorry for cheating, last time :-) > > > >

[PATCH 1/3] IR: extend ir_raw_event and do refactoring

2010-10-16 Thread Maxim Levitsky
hould be initialized like that: DEFINE_IR_RAW_EVENT(ev); To clean an existing event, use init_ir_raw_event(&ev); Signed-off-by: Maxim Levitsky Acked-by: Jarod Wilson --- drivers/media/IR/ene_ir.c|4 +- drivers/media/IR/ir-core-priv.h | 13 +++- drivers/media/IR/ir-j

[PATCH 0/3] Remaining patches in my queue for IR

2010-10-16 Thread Maxim Levitsky
thing else. Please test other drivers. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] IR: ene_ir: don't upload all settings on each TX packet.

2010-10-16 Thread Maxim Levitsky
This is just unnessesary, and now more logical Also a lot of refactoring Signed-off-by: Maxim Levitsky --- drivers/media/IR/ene_ir.c | 474 +++- drivers/media/IR/ene_ir.h |6 +- 2 files changed, 251 insertions(+), 229 deletions(-) diff --git a

[PATCH 2/3] IR: ene_ir: add support for carrier reports

2010-10-16 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- drivers/media/IR/ene_ir.c | 37 + 1 files changed, 29 insertions(+), 8 deletions(-) diff --git a/drivers/media/IR/ene_ir.c b/drivers/media/IR/ene_ir.c index 8639621..1962652 100644 --- a/drivers/media/IR/ene_ir.c +++ b

[PATCH 5/5] IR: ene_ir: don't upload all settings on each TX packet.

2010-10-16 Thread Maxim Levitsky
This is just unnessesary, and now more logical Also lot of refactoring Signed-off-by: Maxim Levitsky --- drivers/media/IR/ene_ir.c | 474 +++- drivers/media/IR/ene_ir.h |6 +- 2 files changed, 251 insertions(+), 229 deletions(-) diff --git a

Re: [PATCH 2/5] IR: extend ir_raw_event and do refactoring

2010-10-15 Thread Maxim Levitsky
On Sat, 2010-10-16 at 00:29 -0300, Mauro Carvalho Chehab wrote: > Em 15-10-2010 13:06, Maxim Levitsky escreveu: > > Add new event types for timeout & carrier report > > Move timeout handling from ir_raw_event_store_with_filter to > > ir-lirc-codec, where it is really ne

Re: [PATCH 3/5] IR: ene_ir: few bugfixes

2010-10-15 Thread Maxim Levitsky
On Fri, 2010-10-15 at 16:02 -0400, Jarod Wilson wrote: > On Fri, Oct 15, 2010 at 06:06:37PM +0200, Maxim Levitsky wrote: > > This is a result of last round of debug with > > Sami R . > > > > Thank you Sami very much! > > > > The biggest bug I fixed i

[PATCH 2/5] IR: extend ir_raw_event and do refactoring

2010-10-15 Thread Maxim Levitsky
hould be initialized like that: DEFINE_IR_RAW_EVENT(ev); To clean an existing event, use init_ir_raw_event(&ev); Signed-off-by: Maxim Levitsky Acked-by: Jarod Wilson --- drivers/media/IR/ene_ir.c |4 +- drivers/media/IR/ir-core-priv.h| 13 - drivers/media/IR/ir-j

[PATCH 2/7] IR: make sure we register the input device when it is safe to do so.

2010-10-15 Thread Maxim Levitsky
ems where hardware decides to send an interrupt right at the moment it is enabled. Signed-off-by: Maxim Levitsky Acked-by: Jarod Wilson --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-keytable.c |2 ++ drivers/media/IR/ir-sysfs.c | 27 +-- 3 fi

[PATCH 1/5] IR: extend and sort the MCE keymap

2010-10-15 Thread Maxim Levitsky
Add new keys, found on: Toshiba Qosmio F50-10q. Toshiba Qosmio X300 Toshiba A500-141 Also sort the keytable by scancode number as that makes sense and alows easily to add new keycodes. Thanks to: Sami R Alexander Skiba Jordi Pelegrin For reports and testing. Signed-off-by: Maxim Levitsky

[PATCH 4/5] IR: ene_ir: add support for carrier reports

2010-10-15 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- drivers/media/IR/ene_ir.c | 37 + 1 files changed, 29 insertions(+), 8 deletions(-) diff --git a/drivers/media/IR/ene_ir.c b/drivers/media/IR/ene_ir.c index 8639621..1962652 100644 --- a/drivers/media/IR/ene_ir.c +++ b

[PATCH 3/5] IR: ene_ir: few bugfixes

2010-10-15 Thread Maxim Levitsky
This is a result of last round of debug with Sami R . Thank you Sami very much! The biggest bug I fixed is that, I was clobbering the CIRCFG register after it is setup That wasn't a good idea really And some small refactoring, etc. Signed-off-by: Maxim Levitsky --- drivers/media/IR/ene

[PATCH 0/8 V7] Many fixes for in-kernel decoding and for the ENE driver

2010-10-15 Thread Maxim Levitsky
Hi, This is a rebased version against the media_tree staging/v2.6.37 Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

[PATCH 5/7] IR: extend ir_raw_event and do refactoring

2010-10-15 Thread Maxim Levitsky
hould be initialized like that: DEFINE_IR_RAW_EVENT(ev); To clean an existing event, use init_ir_raw_event(&ev); Signed-off-by: Maxim Levitsky Acked-by: Jarod Wilson --- drivers/media/IR/ene_ir.c |4 +- drivers/media/IR/ir-core-priv.h| 13 - drivers/media/IR/ir-j

[PATCH 6/7] IR: ene_ir: add support for carrier reports

2010-10-15 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- drivers/media/IR/ene_ir.c | 37 + 1 files changed, 29 insertions(+), 8 deletions(-) diff --git a/drivers/media/IR/ene_ir.c b/drivers/media/IR/ene_ir.c index 8639621..1962652 100644 --- a/drivers/media/IR/ene_ir.c +++ b

[PATCH 1/7] IR: plug races in IR raw thread.

2010-10-15 Thread Maxim Levitsky
Unfortunelly (my fault) the kernel thread that now handles IR processing has classical races in regard to wakeup and stop. This patch hopefully closes them all. Tested with module reload running in a loop, while receiver is blasted with IR data for 10 minutes. Signed-off-by: Maxim Levitsky Acked

[PATCH 7/7] IR: ene_ir: don't upload all settings on each TX packet.

2010-10-15 Thread Maxim Levitsky
This is just unnessesary, and now more logical Also lot of refactoring Signed-off-by: Maxim Levitsky --- drivers/media/IR/ene_ir.c | 474 +++- drivers/media/IR/ene_ir.h |6 +- 2 files changed, 251 insertions(+), 229 deletions(-) diff --git a

[PATCH 3/7] IR: extend an sort the MCE keymap

2010-10-15 Thread Maxim Levitsky
Add new keys, found on: Toshiba Qosmio F50-10q. Toshiba Qosmio X300 Toshiba A500-141 Also sort the keytable by scancode number as that makes sense and alows easily to add new keycodes. Thanks to: Sami R Alexander Skiba Jordi Pelegrin For reports and testing. Signed-off-by: Maxim Levitsky

Re: [PATCH 0/8 V5] Many fixes for in-kernel decoding and for the ENE driver

2010-10-13 Thread Maxim Levitsky
On Tue, 2010-09-07 at 00:26 +0300, Maxim Levitsky wrote: > Hi, > > Here is full overview of my patches: > > Patch #1 fixes races in ir thread. > It fixes the case when ktherad_stop waits forever for the thread. > This happens on module unload and therefore it never

Re: [PATCH 5/8] IR: extend MCE keymap.

2010-09-10 Thread Maxim Levitsky
On Thu, 2010-09-09 at 21:37 -0400, Jarod Wilson wrote: > On Thu, Sep 9, 2010 at 8:40 PM, Maxim Levitsky > wrote: > > On Wed, 2010-09-08 at 10:47 -0400, Jarod Wilson wrote: > >> On Mon, Sep 6, 2010 at 5:26 PM, Maxim Levitsky > >> wrote: > >> > T

Re: [PATCH 0/8 V5] Many fixes for in-kernel decoding and for the ENE driver

2010-09-10 Thread Maxim Levitsky
reserve the memory automatically, and (this is the reason I still don't use it) is only called by kernel to save oopses/panicks. It should be enough though too, but my patch actually places the printk buffer itself in the fixed area in the ram. Best regards, Maxim Levitsky commit 8f1c423046c22

Re: [PATCH 5/8] IR: extend MCE keymap.

2010-09-09 Thread Maxim Levitsky
On Wed, 2010-09-08 at 10:47 -0400, Jarod Wilson wrote: > On Mon, Sep 6, 2010 at 5:26 PM, Maxim Levitsky > wrote: > > These keys are found on remote bundled with > > Toshiba Qosmio F50-10q. > > > > Found and tested by, Sami R > > > > Signed-off-by: Max

Re: [PATCH 1/5] rc-code: merge and rename ir-core

2010-09-09 Thread Maxim Levitsky
I personally don't care much about this. I use Kscope all the time :-) However I do care and like very much this patchset because I also would like to have a per remote input device, and this is first step towards it. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line

Re: [PATCH 0/8 V5] Many fixes for in-kernel decoding and for the ENE driver

2010-09-06 Thread Maxim Levitsky
On Mon, 2010-09-06 at 23:56 +0200, David Härdeman wrote: > On Tue, Sep 07, 2010 at 12:26:05AM +0300, Maxim Levitsky wrote: > > Hi, > > > > Here is full overview of my patches: > > What changed from V4? Nothing other that 2 build fixes that I forgot to include. I also

[PATCH 7/8] IR: extend ir_raw_event and do refactoring

2010-09-06 Thread Maxim Levitsky
hould be initialized like that: DEFINE_IR_RAW_EVENT(ev); To clean an existing event, use init_ir_raw_event(&ev); Signed-off-by: Maxim Levitsky --- drivers/media/IR/ene_ir.c |4 +- drivers/media/IR/ir-core-priv.h| 13 ++- drivers/media/IR/ir-jvc-decoder.c |5 +- d

[PATCH 8/8] IR: ene_ir: add support for carrier reports

2010-09-06 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- drivers/media/IR/ene_ir.c | 37 + 1 files changed, 29 insertions(+), 8 deletions(-) diff --git a/drivers/media/IR/ene_ir.c b/drivers/media/IR/ene_ir.c index dc32509..f1ee153 100644 --- a/drivers/media/IR/ene_ir.c +++ b

[PATCH 5/8] IR: extend MCE keymap.

2010-09-06 Thread Maxim Levitsky
These keys are found on remote bundled with Toshiba Qosmio F50-10q. Found and tested by, Sami R Signed-off-by: Maxim Levitsky --- drivers/media/IR/keymaps/rc-rc6-mce.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/media/IR/keymaps/rc-rc6-mce.c b/drivers

[PATCH 2/8] IR: make sure we register the input device when it is safe to do so.

2010-09-06 Thread Maxim Levitsky
ems where hardware decides to send an interrupt right at the moment it is enabled. Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-keytable.c |2 ++ drivers/media/IR/ir-sysfs.c | 27 +-- 3 files changed, 20 inserti

[PATCH 3/8] IR: fix duty cycle capability

2010-09-06 Thread Maxim Levitsky
Due to typo lirc bridge enabled wrong capability. Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-lirc-codec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/IR/ir-lirc-codec.c b/drivers/media/IR/ir-lirc-codec.c index 77b5946..e63f757 100644 --- a

[PATCH 4/8] IR: fix keys beeing stuck down forever.

2010-09-06 Thread Maxim Levitsky
ion we want to avoid (that the timeout is in the future) Confusing Eh? Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-keytable.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir-keytable.c index 0917535..a8fd77

[PATCH 0/8 V5] Many fixes for in-kernel decoding and for the ENE driver

2010-09-06 Thread Maxim Levitsky
ust builds on top of patch #7 and adds carrier reports to ene driver. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/8] IR: plug races in IR raw thread.

2010-09-06 Thread Maxim Levitsky
Unfortunelly (my fault) the kernel thread that now handles IR processing has classical races in regard to wakeup and stop. This patch hopefully closes them all. Tested with module reload running in a loop, while receiver is blasted with IR data for 10 minutes. Signed-off-by: Maxim Levitsky

Re: [PATCH 7/8] IR: extend ir_raw_event and do refactoring

2010-09-05 Thread Maxim Levitsky
On Sun, 2010-09-05 at 23:23 +0200, David Härdeman wrote: > Comments inline... > > On Sun, Sep 05, 2010 at 02:23:02AM +0300, Maxim Levitsky wrote: > > Add new event types for timeout & carrier report > > Move timeout handling from ir_raw_event_store_with_filter to >

Re: [PATCH 0/8 V3] Many fixes for in-kernel decoding and for the ENE driver

2010-09-05 Thread Maxim Levitsky
On Sun, 2010-09-05 at 23:06 +0200, David Härdeman wrote: > On Sun, Sep 05, 2010 at 02:22:55AM +0300, Maxim Levitsky wrote: > > Hi, > > > > This is next version of my patchset. > > I addressed the comments from David Härdeman, > > And in addit

Re: [PATCH 6/7] IR: extend ir_raw_event and do refactoring

2010-09-02 Thread Maxim Levitsky
On Thu, 2010-09-02 at 22:56 +0200, David Härdeman wrote: > On Mon, Aug 30, 2010 at 11:52:26AM +0300, Maxim Levitsky wrote: > > Add new event types for timeout & carrier report > > Move timeout handling from ir_raw_event_store_with_filter to > > ir-lirc-codec, where it i

[PATCH 7/7] ENE: add support for carrier reports

2010-08-30 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- drivers/media/IR/ene_ir.c | 47 +++- 1 files changed, 37 insertions(+), 10 deletions(-) diff --git a/drivers/media/IR/ene_ir.c b/drivers/media/IR/ene_ir.c index c7bbbca..dfb822b 100644 --- a/drivers/media/IR/ene_ir.c

[PATCH 5/7] ene_ir: updates

2010-08-30 Thread Maxim Levitsky
* Add support for newer firmware versions with different buffer format. Makes hardware work for many users * Register name updates + refactoring * Lots of fixes as a result of full testing Every feature of the driver is now well tested. Signed-off-by: Maxim Levitsky --- drivers/media/IR

[PATCH 6/7] IR: extend ir_raw_event and do refactoring

2010-08-30 Thread Maxim Levitsky
hould be initialized like that: struct ir_raw_event ev = ir_new_event; Signed-off-by: Maxim Levitsky --- drivers/media/IR/ene_ir.c |2 +- drivers/media/IR/ene_ir.h |2 +- drivers/media/IR/ir-core-priv.h| 11 +- drivers/media/IR/ir-jvc-decoder.c |5 ++-

[PATCH 4/7] IR: fix keys beeing stuck down forever.

2010-08-30 Thread Maxim Levitsky
ion we want to avoid (that the timeout is in the future) Confusing Eh? Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-keytable.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir-keytable.c index 3f0dd80..b5addb

[PATCH 1/7] IR: plug races in handling threads.

2010-08-30 Thread Maxim Levitsky
Unfortunelly (my fault) the kernel thread that now handles IR processing has classical races in regard to wakeup and stop. This patch hopefully closes them all. Tested with module reload running in a loop, while receiver is blasted with IR data for 10 minutes. Signed-off-by: Maxim Levitsky

[PATCH 2/7] IR: make sure we register input device when it safe to do so.

2010-08-30 Thread Maxim Levitsky
are decides to send and interrupt right at the moment it is enabled. Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-keytable.c |2 ++ drivers/media/IR/ir-sysfs.c | 27 +-- 3 files changed, 20 insertions(+), 10 deleti

[PATCH 3/7] IR: fix duty cycle capability

2010-08-30 Thread Maxim Levitsky
Due to typo lirc bridge enabled wrong capability. Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-lirc-codec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/IR/ir-lirc-codec.c b/drivers/media/IR/ir-lirc-codec.c index 77b5946..e63f757 100644 --- a

Many fixes for in-kernel decoding + ENE driver

2010-08-30 Thread Maxim Levitsky
Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Remote that breaks current system

2010-08-16 Thread Maxim Levitsky
coded as > 15-bit streamzap, the other 1/3 get decoded as 14-bit RC5, and don't > match anything in the keytable (and often duplicate one another). So > it looks like at least for the time being, a separate parallel decoder > is the way to go. I'm thinking that

Re: [patch] IR: ene_ir: problems in unwinding on probe

2010-08-12 Thread Maxim Levitsky
On Thu, 2010-08-12 at 18:19 +0200, Dan Carpenter wrote: > On Thu, Aug 12, 2010 at 05:35:04PM +0300, Maxim Levitsky wrote: > > On Thu, 2010-08-12 at 09:46 +0200, Dan Carpenter wrote: > > > There were a couple issues here. If the allocation failed for "dev" > &

Re: [patch] IR: ene_ir: problems in unwinding on probe

2010-08-12 Thread Maxim Levitsky
est that in error path. Best regards, Maxim Levitsky > > diff --git a/drivers/media/IR/ene_ir.c b/drivers/media/IR/ene_ir.c > index 5447750..8e5e964 100644 > --- a/drivers/media/IR/ene_ir.c > +++ b/drivers/media/IR/ene_ir.c > @@ -781,21 +781,24 @@ static int ene_probe(st

Re: [PATCH 09/13] IR: add helper function for hardware with small o/b buffer.

2010-08-02 Thread Maxim Levitsky
On Sun, 2010-08-01 at 22:11 -0400, Andy Walls wrote: > On Sat, 2010-07-31 at 17:59 +0300, Maxim Levitsky wrote: > > Some ir input devices have small buffer, and interrupt the host > > each time it is full (or half full) > > > > Add a helper that automaticly

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Maxim Levitsky
On Sat, 2010-07-31 at 17:53 -0400, Jon Smirl wrote: > On Sat, Jul 31, 2010 at 2:51 PM, Andy Walls wrote: > > On Sat, 2010-07-31 at 14:14 -0400, Jon Smirl wrote: > >> On Sat, Jul 31, 2010 at 1:47 PM, Christoph Bartelmus > >> wrote: > >> > Hi Jon, > >> > > >> > on 31 Jul 10 at 12:25, Jon Smirl wr

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Maxim Levitsky
; plugging in 32. Use #defines and do the math in the There is no reason to worry about rounding here. hw_sample is maximum of 127 * 50, so when I muliply by 100 I get exact result. Then I do one divide. Best regards, Maxim Levitsky -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Maxim Levitsky
device is microprocessor. I don't read the samples 'directly' from hardware, but rather from ram of that microprocessor. I don't know how it samples the input. A expiration of sample period might just cause a IRQ inside that microprocessor, and it can't process it instantly

[PATCH 08/13] IR: Allow not to compile keymaps in.

2010-07-31 Thread Maxim Levitsky
Currently, ir device registration fails if keymap requested by driver is not found. Fix that by always compiling in the empty keymap, and using it as a failback. Signed-off-by: Maxim Levitsky Acked-by: Jarod Wilson --- drivers/media/IR/ir-core-priv.h |3 +- drivers/media/IR/ir-sysfs.c

[PATCH 09/13] IR: add helper function for hardware with small o/b buffer.

2010-07-31 Thread Maxim Levitsky
(a byte for example). Also remove constness from ir_dev_props, because it now contains timeout settings that driver might want to change Signed-off-by: Maxim Levitsky Acked-by: Jarod Wilson --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-keytable.c |2 +- drivers/media

[PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- MAINTAINERS |6 + drivers/media/IR/Kconfig | 14 + drivers/media/IR/Makefile |1 + drivers/media/IR/ene_ir.c | 595 + drivers/media/IR/ene_ir.h | 51 ++--- 5 files changed, 265 insertions

[PATCH 10/13] IR: extend interfaces to support more device settings

2010-07-31 Thread Maxim Levitsky
LIRC: add new IOCTL that enables learning mode (wide band receiver) Still missing features: carrier report & timeout reports. Will need to pack these into ir_raw_event Signed-off-by: Maxim Levitsky --- .../DocBook/v4l/lirc_device_interface.xml | 16 +++ drivers/media/IR/ir-

[PATCH 11/13] IR: report unknown scancodes the in-kernel decoders found.

2010-07-31 Thread Maxim Levitsky
This way it is possible to use evtest to create keymap for unknown remote. Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-keytable.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir-keytable.c index

[PATCH 07/13] IR: NECX: support repeat

2010-07-31 Thread Maxim Levitsky
This adds support for repeat detecting for NECX variant Tested with uneversal remote Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-core-priv.h |2 ++ drivers/media/IR/ir-nec-decoder.c | 23 +-- 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a

[PATCH 06/13] IR: nec decoder: fix repeat.

2010-07-31 Thread Maxim Levitsky
Repeat space is 4 units, not 8. Current code would never trigger a repeat. However that isn't true for NECX, so repeat there must be handled differently. Signed-off-by: Maxim Levitsky Reviewed-by: Andy Walls --- drivers/media/IR/ir-nec-decoder.c |2 +- 1 files changed, 1 insertions(

[PATCH 05/13] IR: JVC: make repeat work

2010-07-31 Thread Maxim Levitsky
Currently, jvc decoder will attempt misdetect next press as a repeat of last keypress, therefore second keypress isn't detected. Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-jvc-decoder.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/dr

[PATCH 03/13] IR: replace spinlock with mutex.

2010-07-31 Thread Maxim Levitsky
Some handlers (lirc for example) allocates memory on initialization, doing so in atomic context is cumbersome. Fixes warning about sleeping function in atomic context. Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-raw-event.c | 28 ++-- 1 files changed, 14

[PATCH 04/13] IR: replace workqueue with kthread

2010-07-31 Thread Maxim Levitsky
uited for a workqueue, so use a kernel thread. Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-core-priv.h |2 +- drivers/media/IR/ir-raw-event.c | 42 -- 2 files changed, 32 insertions(+), 12 deletions(-) diff --git a/drivers/media/IR/ir-core-pri

[PATCH 02/13] IR: minor fixes:

2010-07-31 Thread Maxim Levitsky
* lirc: Don't propagate reset event to userspace * lirc: Remove strange logic from lirc that would make first sample always be pulse * Make TO_US macro actualy print what it should. Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-core-priv.h |4 +--- drivers/media/IR/ir-lirc-co

[PATCH 01/13] IR: Kconfig fixes

2010-07-31 Thread Maxim Levitsky
Move IR drives below separate menu. This allows to disable them. Also correct a typo. Signed-off-by: Maxim Levitsky --- drivers/media/IR/Kconfig | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/media/IR/Kconfig b/drivers/media/IR/Kconfig index e557ae0

[PATCH 0/9 v4] IR: few fixes, additions and ENE driver

2010-07-31 Thread Maxim Levitsky
Hi, 4th revision of my patches below: Changes: * more carefull repeat support in NECX protocol * added documentation for wide band mode ioctl * fix for 64 bit divide * updated summary of patches, and preserved few * Acked/Reviewed by tags you gave me. Best regards, Maxim Levitsky

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Maxim Levitsky
On Sat, 2010-07-31 at 10:37 -0400, Jon Smirl wrote: > On Sat, Jul 31, 2010 at 10:28 AM, Maxim Levitsky > wrote: > > On Sat, 2010-07-31 at 09:55 -0400, Andy Walls wrote: > >> On Fri, 2010-07-30 at 15:45 +0300, Maxim Levitsky wrote: > >> > On Fri, 2010-07-3

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-31 Thread Maxim Levitsky
On Sat, 2010-07-31 at 09:55 -0400, Andy Walls wrote: > On Fri, 2010-07-30 at 15:45 +0300, Maxim Levitsky wrote: > > On Fri, 2010-07-30 at 08:07 -0400, Jon Smirl wrote: > > > On Fri, Jul 30, 2010 at 8:02 AM, Jon Smirl wrote: > > > > On Fri, Jul 30, 2010 at 7:54 AM,

Re: [PATCH 10/13] IR: extend interfaces to support more device settings LIRC: add new IOCTL that enables learning mode (wide band receiver)

2010-07-31 Thread Maxim Levitsky
On Sat, 2010-07-31 at 10:10 +0200, Christoph Bartelmus wrote: > Hi Maxim, > > on 31 Jul 10 at 01:01, Maxim Levitsky wrote: > > On Fri, 2010-07-30 at 23:22 +0200, Christoph Bartelmus wrote: > [...] > >>> +#define LIRC_SET_WIDEBAND_RECEIVER _IOW('i', 0x

Re: [PATCH 10/13] IR: extend interfaces to support more device settings LIRC: add new IOCTL that enables learning mode (wide band receiver)

2010-07-30 Thread Maxim Levitsky
On Fri, 2010-07-30 at 23:22 +0200, Christoph Bartelmus wrote: > Hi! > > Maxim Levitsky "maximlevit...@gmail.com" wrote: > > > Still missing features: carrier report & timeout reports. > > Will need to pack these into ir_raw_event > > > Hm, this p

Re: [PATCH 0/9 v3] IR: few fixes, additions and ENE driver

2010-07-30 Thread Maxim Levitsky
On Fri, 2010-07-30 at 16:33 -0300, Mauro Carvalho Chehab wrote: > Em 30-07-2010 08:38, Maxim Levitsky escreveu: > > Hi, > > > > This is mostly same patchset. > > > > I addressed the comments of Andy Walls. > > > > Now IR decoding is done by a sepa

Re: [PATCH 06/13] IR: nec decoder: fix repeat.

2010-07-30 Thread Maxim Levitsky
On Fri, 2010-07-30 at 16:36 -0300, Mauro Carvalho Chehab wrote: > Em 30-07-2010 08:38, Maxim Levitsky escreveu: > > Repeat space is 4 units, not 8. > > Current code would never trigger a repeat. > > Yes, this fixed the issue: > > Jul 30 16:53:52 agua kernel: [

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-30 Thread Maxim Levitsky
On Fri, 2010-07-30 at 08:07 -0400, Jon Smirl wrote: > On Fri, Jul 30, 2010 at 8:02 AM, Jon Smirl wrote: > > On Fri, Jul 30, 2010 at 7:54 AM, Maxim Levitsky > > wrote: > >> On Fri, 2010-07-30 at 07:51 -0400, Jon Smirl wrote: > >>> On Fri, Jul 30, 2010 at 7

Re: [PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-30 Thread Maxim Levitsky
On Fri, 2010-07-30 at 07:51 -0400, Jon Smirl wrote: > On Fri, Jul 30, 2010 at 7:36 AM, Maxim Levitsky > wrote: > > On Thu, 2010-07-29 at 23:46 -0400, Andy Walls wrote: > >> On Thu, 2010-07-29 at 22:39 -0400, Jon Smirl wrote: > >> > On Thu, Jul 29, 2010 at 10:17

[PATCH 13/13] IR: Port ene driver to new IR subsystem and enable it.

2010-07-30 Thread Maxim Levitsky
Signed-off-by: Maxim Levitsky --- MAINTAINERS |6 + drivers/media/IR/Kconfig | 14 + drivers/media/IR/Makefile |1 + drivers/media/IR/ene_ir.c | 595 + drivers/media/IR/ene_ir.h | 51 ++--- 5 files changed, 265 insertions

[PATCH 10/13] IR: extend interfaces to support more device settings LIRC: add new IOCTL that enables learning mode (wide band receiver)

2010-07-30 Thread Maxim Levitsky
Still missing features: carrier report & timeout reports. Will need to pack these into ir_raw_event Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-lirc-codec.c | 112 +++--- include/media/ir-co

[PATCH 11/13] IR: report unknown scancodes the in-kernel decoders found.

2010-07-30 Thread Maxim Levitsky
This way it is possible to use evtest to create keymap for unknown remote. Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-keytable.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/media/IR/ir-keytable.c b/drivers/media/IR/ir-keytable.c index

[PATCH 09/13] IR: add helper function for hardware with small o/b buffer.

2010-07-30 Thread Maxim Levitsky
(a byte for example). Also remove constness from ir_dev_props, because it now contains timeout settings that driver might want to change Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-keytable.c |2 +- drivers/media/IR/ir-raw-event.c | 84

[PATCH 07/13] IR: NECX: support repeat

2010-07-30 Thread Maxim Levitsky
This adds support for repeat detecting for NECX variant Tested with uneversal remote Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-core-priv.h |1 + drivers/media/IR/ir-nec-decoder.c | 16 ++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 08/13] IR: Allow not to compile keymaps in.

2010-07-30 Thread Maxim Levitsky
Currently, ir device registration fails if keymap requested by driver is not found. Fix that by always compiling in the empty keymap, and using it as a failback. Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-core-priv.h |3 +- drivers/media/IR/ir-sysfs.c |2

[PATCH 06/13] IR: nec decoder: fix repeat.

2010-07-30 Thread Maxim Levitsky
Repeat space is 4 units, not 8. Current code would never trigger a repeat. However that isn't true for NECX, so repeat there must be handled differently. Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-nec-decoder.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

[PATCH 04/13] IR: fix locking in ir_raw_event_work

2010-07-30 Thread Maxim Levitsky
It is prefectly possible to have ir_raw_event_work running concurently on two cpus, thus we must protect it from that situation. Just switch to a thread that we wake up as soon as we have data. This also ensures that this thread doesn't run unnessesarly. Signed-off-by: Maxim Lev

[PATCH 05/13] IR: JVC: make repeat work

2010-07-30 Thread Maxim Levitsky
Currently, jvc decoder will attempt misdetect next press as a repeat of last keypress, therefore second keypress isn't detected. Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-jvc-decoder.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/dr

[PATCH 03/13] IR: replace spinlock with mutex.

2010-07-30 Thread Maxim Levitsky
Some handlers (lirc for example) allocates memory on initialization, doing so in atomic context is cumbersome. Fixes warning about sleeping function in atomic context. Signed-off-by: Maxim Levitsky --- drivers/media/IR/ir-raw-event.c | 28 ++-- 1 files changed, 14

  1   2   >