[PATCH v4 3/3] stk1160: Wait for completion of transfers to and from AC97 codec.

sults of a read operation or setting a new write command. Signed-off-by: Marcel Hasler --- drivers/media/usb/stk1160/stk1160-ac97.c | 39 +--- drivers/media/usb/stk1160/stk1160-reg.h | 2 ++ drivers/media/usb/stk1160/stk1160.h | 2 ++ 3 files changed, 35 inser

Re: [PATCH v4 1/3] stk1160: Remove stk1160-mixer and setup internal AC97 codec

Sorry, somehow the email header got messed up. Ignore this one. 2016-12-15 23:13 GMT+01:00 Marcel Hasler : > automatically. > Reply-To: > In-Reply-To: <20161215221146.GA9398@arch-desktop> > > Exposing all the channels of the device's internal AC97 codec to users

[PATCH v4 1/3] stk1160: Remove stk1160-mixer and setup internal AC97 codec automatically.

This also makes the device work out-of-the-box, without the need for the user to reconfigure the device every time it's plugged in. Signed-off-by: Marcel Hasler --- drivers/media/usb/stk1160/Kconfig| 10 +-- drivers/media/usb/stk1160/Makefile | 4 +- drivers/media/usb/stk11

[PATCH v4 2/3] stk1160: Check whether to use AC97 codec.

AC97 codec. Signed-off-by: Marcel Hasler --- drivers/media/usb/stk1160/stk1160-ac97.c | 26 ++ drivers/media/usb/stk1160/stk1160-core.c | 3 +-- drivers/media/usb/stk1160/stk1160-reg.h | 8 3 files changed, 35 insertions(+), 2 deletions(-) diff --git a/drivers/media/u

[PATCH v4 1/3] stk1160: Remove stk1160-mixer and setup internal AC97 codec

p the codec using optimal values, i.e. the same values set by the Windows driver. This also makes the device work out-of-the-box, without the need for the user to reconfigure the device every time it's plugged in. Signed-off-by: Marcel Hasler --- drivers/media/usb/stk1160/Kconfig|

[PATCH v4 0/3] stk1160: Let the driver setup the device's internal AC97 codec

s from version 3: * Removed module param * Implemented polling read/write bits Marcel Hasler (3): stk1160: Remove stk1160-mixer and setup internal AC97 codec automatically. stk1160: Check whether to use AC97 codec. stk1160: Wait for completion of transfers to and from AC97 codec. drivers/media/usb/

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

0x504 >> +#define STK1160_AC97CTL_0_CR BIT(1) >> +#define STK1160_AC97CTL_0_CW BIT(2) >> >> /* Use [0:6] bits of register 0x504 to set codec command address */ >> #define STK1160_AC97_ADDR 0x504 >> diff --git a/drivers/

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

Hello 2016-12-06 13:56 GMT+01:00 Mauro Carvalho Chehab : > Em Mon, 5 Dec 2016 22:06:59 +0100 > Marcel Hasler escreveu: > >> Hello >> >> 2016-12-05 16:38 GMT+01:00 Ezequiel Garcia : >> > On 5 December 2016 at 09:12, Mauro Carvalho Chehab >> > w

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

2016-12-05 22:06 GMT+01:00 Marcel Hasler : > Hello > > 2016-12-05 16:38 GMT+01:00 Ezequiel Garcia : >> On 5 December 2016 at 09:12, Mauro Carvalho Chehab >> wrote: >>> Em Sun, 4 Dec 2016 15:25:25 -0300 >>> Ezequiel Garcia escreveu: >>> >&g

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

Hello 2016-12-05 16:38 GMT+01:00 Ezequiel Garcia : > On 5 December 2016 at 09:12, Mauro Carvalho Chehab > wrote: >> Em Sun, 4 Dec 2016 15:25:25 -0300 >> Ezequiel Garcia escreveu: >> >>> On 4 December 2016 at 10:01, Marcel Hasler wrote: >>> >

Re: [PATCH v3 3/4] stk1160: Add module param for setting the record gain.

Hello 2016-12-03 21:46 GMT+01:00 Ezequiel Garcia : > On 2 December 2016 at 08:05, Mauro Carvalho Chehab > wrote: >> Em Sun, 27 Nov 2016 12:11:48 +0100 >> Marcel Hasler escreveu: >> >>> Allow setting a custom record gain for the internal AC97 codec (if >&g

[PATCH v3 4/4] stk1160: Give the chip some time to retrieve data from AC97 codec.

command bit has been cleared, but this may not be worth the hassle. Signed-off-by: Marcel Hasler --- drivers/media/usb/stk1160/stk1160-ac97.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/media/usb/stk1160/stk1160-ac97.c b/drivers/media/usb/stk1160/stk1160-ac97.c index 6

[PATCH v3 3/4] stk1160: Add module param for setting the record gain.

Allow setting a custom record gain for the internal AC97 codec (if available). This can be a value between 0 and 15, 8 is the default and should be suitable for most users. The Windows driver also sets this to 8 without any possibility for changing it. Signed-off-by: Marcel Hasler --- drivers

[PATCH v3 2/4] stk1160: Check whether to use AC97 codec.

AC97 codec. Signed-off-by: Marcel Hasler --- drivers/media/usb/stk1160/stk1160-ac97.c | 26 ++ drivers/media/usb/stk1160/stk1160-core.c | 3 +-- drivers/media/usb/stk1160/stk1160-reg.h | 8 3 files changed, 35 insertions(+), 2 deletions(-) diff --git a/drivers/media/u

[PATCH v3 1/4] stk1160: Remove stk1160-mixer and setup internal AC97 codec automatically.

This also makes the device work out-of-the-box, without the need for the user to reconfigure the device every time it's plugged in. Signed-off-by: Marcel Hasler --- drivers/media/usb/stk1160/Kconfig| 10 +-- drivers/media/usb/stk1160/Makefile | 4 +- drivers/media/usb/stk11

[PATCH v3 0/4] stk1160: Let the driver setup the device's internal AC97 codec

ed copyright notice * Added defines for POSVA bytes and bits * Added check for ACDOUT bit to determine whether audio is disabled completely * Removed info output for gain setting * Added fourth patch which had been submitted independently before * Expanded comment on AC97 read delay Marcel Hasler (

Re: [PATCH] stk1160: Give the chip some time to retrieve data from AC97 codec.

2016-11-20 18:37 GMT+01:00 Ezequiel Garcia : > On 28 October 2016 at 05:52, Marcel Hasler wrote: >> The STK1160 needs some time to transfer data from the AC97 registers into >> its own. On some >> systems reading the chip's own registers to soon will return wrong value

Re: [PATCH] stk1160: Give the chip some time to retrieve data from AC97 codec.

2016-11-20 18:37 GMT+01:00 Ezequiel Garcia : > On 28 October 2016 at 05:52, Marcel Hasler wrote: >> The STK1160 needs some time to transfer data from the AC97 registers into >> its own. On some >> systems reading the chip's own registers to soon will return wrong value

Re: [PATCH v2 3/3] stk1160: Add module param for setting the record gain.

2016-11-20 18:36 GMT+01:00 Ezequiel Garcia : > On 27 October 2016 at 17:35, Marcel Hasler wrote: >> Allow setting a custom record gain for the internal AC97 codec (if >> available). This can be >> a value between 0 and 15, 8 is the default and should be suitable for most

Re: [PATCH v2 2/3] stk1160: Check whether to use AC97 codec or internal ADC.

2016-11-20 18:36 GMT+01:00 Ezequiel Garcia : > On 27 October 2016 at 17:34, Marcel Hasler wrote: >> Some STK1160-based devices use the chip's internal 8-bit ADC. This is >> configured through a strap >> pin. The value of this and other pins can be read through the

Re: [PATCH v2 1/3] stk1160: Remove stk1160-mixer and setup internal AC97 codec automatically.

Hello, and thanks for your feedback. 2016-11-20 18:36 GMT+01:00 Ezequiel Garcia : > Marcel, > > On 27 October 2016 at 17:34, Marcel Hasler wrote: >> Exposing all the channels of the device's internal AC97 codec to userspace >> is unnecessary and >> confusing. Ins

Fwd: [PATCH] stk1160: Give the chip some time to retrieve data from AC97 codec.

) and most likely use the same host controller. My desktop motherboard on the other hand is a bit older. So I wonder, have you experienced this problem on your own systems? Best regards Marcel 2016-10-28 10:52 GMT+02:00 Marcel Hasler : > The STK1160 needs some time to transfer data from

[PATCH] stk1160: Give the chip some time to retrieve data from AC97 codec.

command bit has been cleared, but this may not be worth the hassle. Signed-off-by: Marcel Hasler --- drivers/media/usb/stk1160/stk1160-ac97.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/usb/stk1160/stk1160-ac97.c b/drivers/media/usb/stk1160/stk1160-ac97.c index 31bdd60d.

[PATCH v2 3/3] stk1160: Add module param for setting the record gain.

Allow setting a custom record gain for the internal AC97 codec (if available). This can be a value between 0 and 15, 8 is the default and should be suitable for most users. The Windows driver also sets this to 8 without any possibility for changing it. Signed-off-by: Marcel Hasler --- drivers

[PATCH v2 2/3] stk1160: Check whether to use AC97 codec or internal ADC.

Some STK1160-based devices use the chip's internal 8-bit ADC. This is configured through a strap pin. The value of this and other pins can be read through the POSVA register. If the internal ADC is used, there's no point trying to setup the unavailable AC97 codec. Signed-off-by: Mar

[PATCH v2 1/3] stk1160: Remove stk1160-mixer and setup internal AC97 codec automatically.

This also makes the device work out-of-the-box, without the need for the user to reconfigure the device every time it's plugged in. Signed-off-by: Marcel Hasler --- drivers/media/usb/stk1160/Kconfig| 10 +-- drivers/media/usb/stk1160/Makefile | 4 +- drivers/media/usb/stk11

[PATCH v2 0/3] stk1160: Let the driver setup the device's internal AC97 codec

y since the AC97 chip is no longer exposed to userspace. The Windows driver doesn't allow this value to be changed but instead always sets it to 8 (of 15). While this should be fine for most users, some may prefer something higher. Marcel Hasler (3): stk1160: Remove stk1160-mixer and

[PATCH 3/3] stk1160: Remove VIDEO_STK1160_AC97 and SND_AC97_CODEC from Kconfig and Makefile.

The VIDEO_STK1160_AC97 option is no longer needed after the removal of stk1160-mixer. For the same reason SND and SND_AC97_CODEC are no longer required. Signed-off-by: Marcel Hasler --- drivers/media/usb/stk1160/Kconfig | 3 +-- drivers/media/usb/stk1160/Makefile | 4 +--- 2 files changed, 2

[PATCH 1/2] stk1160: Remove stk1160-mixer and setup AC97 codec automatically.

work out-of-the-box, without the need for the user to reconfigure the device every time it's plugged in. Signed-off-by: Marcel Hasler --- drivers/media/usb/stk1160/Kconfig| 7 -- drivers/media/usb/stk1160/stk1160-ac97.c | 121 +++ drivers/media/usb/stk11

Re: [PATCH 3/3] stk1160: Remove VIDEO_STK1160_AC97 and SND_AC97_CODEC from Kconfig and Makefile.

ything else you want to mention. > > (And don't forget to Cc the media mailing list) > > Thanks again! > Ezequiel > > On 27 October 2016 at 06:10, Marcel Hasler wrote: > > The VIDEO_STK1160_AC97 option is no longer needed after the removal of > > stk1160-mixer

[PATCH 2/2] stk1160: Check whether to use AC97 codec or internal ADC.

Some STK1160-based devices use the chip's internal 8-bit ADC. This is configured through a strap pin. The value of this and other pins can be read through the POSVA register. If the internal ADC is used, there's no point trying to setup the unavailable AC97 codec. Signed-off-by: Mar