Re: [PATCH] cx23885/vb2 regression: please test this patch

Hans, There is another guy having issues with TBS8820 card (uses cx88 and cx24116) His syslog: http://paste.ubuntu.com/9284564/ The stackdump makes me believe that the issue also appeared since "[media] cx88: convert to vb2" (still to confirm) Regards, Luis On Fri, Jan 16, 2015 at 4:20 PM, Ra

Re: [PATCH] si2168: Add ts_mode config.

ller must keep stuct, but it does not, and I really don't even > like idea to leave it responsibility of caller. Due to that you will need > copy all config values to driver state before return from probe(). > > regards > Antti > > > > On 07/22/2014 06:54 PM, Luis Alves

Re: [PATCH] si2157: Fix DVB-C bandwidth.

Chehab wrote: > Em Tue, 22 Jul 2014 12:09:48 +0100 > Luis Alves escreveu: > >> This patch fixes DVB-C reception. >> Without setting the bandwidth to 8MHz the received stream gets corrupted. >> >> Regards, >> Luis >> >> Signed-off-by: Luis Alve

[PATCH] si2168: Add ts_mode config.

This patch adds the TS mode as a config option: - ts_mode added to config struct. - Possible (interesting) values are * Parallel mode = 0x06 * Serial mode = 0x03 Currently the modules using this demod only use parallel mode. Regards, Luis Signed-off-by: Luis Alves --- drivers/media/dvb

[PATCH] si2157: Fix DVB-C bandwidth.

This patch fixes DVB-C reception. Without setting the bandwidth to 8MHz the received stream gets corrupted. Regards, Luis Signed-off-by: Luis Alves --- drivers/media/tuners/si2157.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157

Re: [PATCH] si2157: Use name si2157_ops instead of si2157_tuner_ops (harmonize with si2168)

This actually fixes a bug. The struct prototype is defined at the beginning of the code as "si2157_ops" but the real struct is called "si2157_tuner_ops". This is causing the name to be empty on this info msg: si2157 16-0060: si2157: found a '' in cold state Luis On Fri, Jul 18, 2014 at 6:41 AM,

Re: [PATCH 1/1 v2] si2168: Support Si2168-A20 firmware downloading.

I think so... at least the known ones. On Thu, Jul 17, 2014 at 11:56 PM, Antti Palosaari wrote: > Thank for the patch! I will apply that sure too. > Driver supports now all Si2168 versions? > > regards > Antti > > > On 07/18/2014 01:43 AM, Luis Alves wrote: >> >&

[PATCH 1/1 v2] si2168: Support Si2168-A20 firmware downloading.

-demod-si2168-a20-01.fw count=28656 bs=1 skip=1625088 md5sum: 32e06713b33915f674bfb2c209beaea5 /lib/firmware/dvb-demod-si2168-a20-01.fw Regards, Luis Signed-off-by: Luis Alves --- drivers/media/dvb-frontends/si2168.c | 5 + drivers/media/dvb-frontends/si2168_priv.h | 1 + 2 files changed

[PATCH 1/1] si2168: Support Si2168-A20 firmware downloading.

=1625088 md5sum: 32e06713b33915f674bfb2c209beaea5 /lib/firmware/dvb-demod-si2168-a20-01.fw Regards, Luis Signed-off-by: Luis Alves --- drivers/media/dvb-frontends/si2168.c | 4 drivers/media/dvb-frontends/si2168_priv.h | 1 + 2 files changed, 5 insertions(+) diff --git a/drivers/media

[PATCH 1/1] si2168: Remove testing for demod presence on probe. If the demod is in sleep mode it will fail.

Signed-off-by: Luis Alves --- drivers/media/dvb-frontends/si2168.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c index 3fed522..7e45eeab 100644 --- a/drivers/media/dvb-frontends/si2168.c +++ b/drivers/media

[PATCH 1/1] si2168: Fix i2c_add_mux_adapter return value in probe function. In case it failed the return value was always 0.

Signed-off-by: Luis Alves --- drivers/media/dvb-frontends/si2168.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c index 7980741..3fed522 100644 --- a/drivers/media/dvb-frontends/si2168.c +++ b

Re: [PATCH] si2168: improve scanning performance by setting property 0301 with a value from Windows driver.

This would be best done during init and not every time on set_frontend. Regards, Luis On Thu, Jul 17, 2014 at 7:43 PM, Olli Salonen wrote: > Signed-off-by: Olli Salonen > --- > drivers/media/dvb-frontends/si2168.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/media/dv

[PATCH 1/1] si2168: Set symbol_rate in set_frontend for DVB-C delivery system.

This patch adds symbol rate setting to the driver. Signed-off-by: Luis Alves --- drivers/media/dvb-frontends/si2168.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c index 0422925..7980741 100644

Re: Upstreaming SAA716x driver to the media_tree

Hi Manu, How's the progress going? Looking forward to finally see this driver in the tree :D Regards, Luis On Tue, Feb 11, 2014 at 7:47 PM, Manu Abraham wrote: > On Tue, Feb 11, 2014 at 7:14 PM, Luis Alves wrote: >> Hi, >> >> Any update on this? > > I need to

Re: Upstreaming SAA716x driver to the media_tree

Hi, Any update on this? Thanks, Luis On Wed, Jan 22, 2014 at 3:26 PM, Manu Abraham wrote: > On Wed, Jan 22, 2014 at 3:29 AM, Steven Toth wrote: >> On Mon, Jan 13, 2014 at 10:35 PM, Manu Abraham >> wrote: >>> On Tue, Jan 14, 2014 at 12:20 AM, Steven Toth wrote: >> Manu, do you see any in

RE: [PATCH 3/8] rtl2832: Fix deadlock on i2c mux select function.

From: Luis Alves Signed-off-by: Luis Alves Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/rtl2832.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/rtl2832.c b/drivers/media/dvb-frontends/rtl2832.c index c0366a8..cfc5438

Re: Upstreaming SAA716x driver to the media_tree

n > courtesy in open-source community when you didn't make them to not > submit them as "your" patches. > > i also think with your actions you're actually hurting the community, > because people like me, that do actually have the technical > understanding and ca

Re: Upstreaming SAA716x driver to the media_tree

e, Jan 7, 2014 at 4:12 PM, Andreas Regel wrote: > Hi Luis, > > Am 07.01.2014 12:58, schrieb Luis Alves: >> Hi, >> >> I'm finishing a new frontend driver for one of my dvb cards, but the >> pcie bridge uses the (cursed) saa716x. >> As far as I know th

Re: Upstreaming SAA716x driver to the media_tree

Hi Manu, That would be great. Let me know if you need a hand! Regards, Luis On Tue, Jan 7, 2014 at 1:10 PM, Manu Abraham wrote: > Hi Luis, > > > On Tue, Jan 7, 2014 at 5:28 PM, Luis Alves wrote: >> Hi, >> >> I'm finishing a new frontend driver for one of m

Upstreaming SAA716x driver to the media_tree

rting a few dvb cards. It would be good if we could gather everything in one place and send a few patchs to get this upstreamed for once... Manu, do you see any inconvenience in sending your driver to the linux_media tree? I'm available to place some effort on this task. Regards, Luis Alves --

[PATCH 2/2] cx24117: Fix LNB set_voltage function.

Hi, This patch should fix/enhance the set_voltage function for the cx24117 demod. Regards, Luis Signed-off-by: Luis Alves --- drivers/media/dvb-frontends/cx24117.c | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/media/dvb

[PATCH 1/2] cx24117: Add complete demod command list.

Hi, This patch adds the complete list of all the commands known for the cx24117 demod. Regards, Luis Signed-off-by: Luis Alves --- drivers/media/dvb-frontends/cx24117.c | 98 +-- 1 file changed, 58 insertions(+), 40 deletions(-) diff --git a/drivers/media

[PATCH] cx24117: Fix/enhance set_voltage function.

Hi, On this patch: Added a few defines to describe what every constant in the set_voltage function. Added the description to the CX24117 GPIO control commands. Moved the GPIODIR setup to the initfe function. Regards, Luis Signed-off-by: Luis Alves --- drivers/media/dvb-frontends/cx24117.c

[PATCH] cx24117: Prevent mutex to be stuck on locked state if FE init fails.

Hi, This patch will fix the situation where the mutex was left in a locked state if for some reason the FE init failed. Regards, Luis Signed-off-by: Luis Alves --- drivers/media/dvb-frontends/cx24117.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers

Re: [PATCH 1/2] cx24117: Changed the way common data struct was being passed to the demod.

nted out, this series of patches are to be used against your >> cx24117 branch. >> >> Regards, >> Luis >> >> Signed-off-by: Luis Alves > > > I am not very familiar how that hybrid tuner request works, but it seems to > be based of driver global lis

[PATCH 1/2] cx24117: Changed the way common data struct was being passed to the demod.

Regards, Luis Signed-off-by: Luis Alves --- drivers/media/dvb-frontends/cx24117.c | 72 +++-- drivers/media/dvb-frontends/cx24117.h |4 +- 2 files changed, 53 insertions(+), 23 deletions(-) diff --git a/drivers/media/dvb-frontends/cx24117.c b/drivers/media/dvb-fron

[PATCH 2/2] cx24117: Removed from cx23885 the no longer needed frontend pointer from the dvb_attach function.

cx23885 changes: to be used against mkrufky/cx24117 branch Signed-off-by: Luis Alves --- drivers/media/pci/cx23885/cx23885-dvb.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/media/pci/cx23885/cx23885-dvb.c b/drivers/media/pci/cx23885/cx23885-dvb.c

[PATCH 2/2] cx24117[v4]: Add new dvb-frontend: add supported cards to cx23885. Currently tested with TBS6980 and TBS6981.

v4: Patch order fixed. Changed some msleep's to clear checkpatch warnings. Signed-off-by: Luis Alves --- drivers/media/pci/cx23885/Kconfig |1 + drivers/media/pci/cx23885/cx23885-cards.c | 67 + drivers/media/pci/cx23885/cx23885-dvb.c |

[PATCH 1/2] cx24117[v4]: Add new dvb-frontend.

v4: Patch order fixed. Changed some msleep's to clear checkpatch warning. Signed-off-by: Luis Alves --- drivers/media/dvb-frontends/Kconfig |7 + drivers/media/dvb-frontends/Makefile |1 + drivers/media/dvb-frontends/cx24117.c | 1621 + drivers/

[PATCH] cx23885[v4]: Fix interrupt storm when enabling IR receiver.

. Regards, Luis Signed-off-by: Luis Alves --- drivers/media/pci/cx23885/cx23885-av.c| 13 + drivers/media/pci/cx23885/cx23885-video.c |4 ++-- drivers/media/pci/cx23885/cx23885-video.h | 26 ++ 3 files changed, 41 insertions(+), 2 deletions(-) create

[PATCH] cx23885[v3]: Fix interrupt storm when enabling IR receiver.

Hi, New patch for this issue. Changes: - Added flatiron readreg and writereg functions prototypes (new header file). - Modified the av work handler to preserve all other register bits when dealing with the interrupt flag. Regards, Luis Signed-off-by: Luis Alves --- drivers/media/pci

Re: [PATCH] cx23885[v2]: Fix IR interrupt storm.

all the i2c_transfer directly. >> >>Tested in the TBS6981 Dual DVB-S2 card. >> >>PS: I've found this i2c_transfers in TBS media tree, more precisely >>in the cx23885-i2c.c file. >> >>Regards, >>Luis >> >> >>Signed-off-by: L

[PATCH] cx23885[v2]: Fix IR interrupt storm.

read/write functions but are not exported so Antti just suggested to call the i2c_transfer directly. Tested in the TBS6981 Dual DVB-S2 card. PS: I've found this i2c_transfers in TBS media tree, more precisely in the cx23885-i2c.c file. Regards, Luis Signed-off-by: Luis Alves --- dr

Re: [PATCH] cx23885: Fix interrupt storm that happens in some cards when IR is enabled.

Hi Konstantin, It was not my intention to send this piece of code as a patch to be upstreamed. My apologies for that misunderstanding. My intention was just to send something for people to try and see if it solves the interrupt spam in their cards. I should have sent it just as a normal email to t

Re: [PATCH] cx23885: Fix interrupt storm that happens in some cards when IR is enabled.

Sorry if I wasn't clear, but this patch is not intended to be merged in the main tree (as it is). I've sent it so that people facing this interrupt storm when IR is enabled can test it in their cards (I only have the TBS6981 to test and it works). Probably I should have just sent a mail with a code

[PATCH] cx23885: Fix interrupt storm that happens in some cards when IR is enabled.

n the same case statment). Other cards but these that suffer the same issue should also be tested. Give feedback! Regards, Luis Signed-off-by: Luis Alves --- drivers/media/pci/cx23885/cx23885-cards.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/medi

[PATCH 1/2] cx24117[v3]: Add new dvb-frontend driver (cx23885 changes)

v3: Fixed issues reported by checkpatch script (thanks Antti). Changed/fixed some stuff as sugested by Mauro Chehab. Splited cx23885 changes to a separated patch. Signed-off-by: Luis Alves --- drivers/media/pci/cx23885/Kconfig |1 + drivers/media/pci/cx23885/cx23885-cards.c | 68

[PATCH 2/2] cx24117[v3]: Add new dvb-frontend driver (tested cards: TBS6980 and TBS6981 Dual tuner DVB-S/S2)

v3: Fixed issues reported by checkpatch script (thanks Antti). Changed/fixed some stuff as sugested by Mauro Chehab. Splited cx23885 changes to a separated patch. Signed-off-by: Luis Alves --- drivers/media/dvb-frontends/Kconfig |7 + drivers/media/dvb-frontends/Makefile |1

[PATCH] cx24117[v2]: Add new dvb-frontend driver (tested cards: TBS6980 and TBS6981 Dual tuner DVB-S/S2)

[v2] Fixed/changed according to first review. Regards, Luis Signed-off-by: Luis Alves --- drivers/media/dvb-frontends/Kconfig |7 + drivers/media/dvb-frontends/Makefile |1 + drivers/media/dvb-frontends/cx24117.c | 1645 + drivers/media/dvb

[PATCH] cx24117: Add new dvb-frontend driver (tested cards: TBS6980 and TBS6981 Dual tuner DVB-S/S2)

Hi all, This patch adds support for the following CX24117 demod based cards: TBS6980, TBS6981 (Dual tuner DVB-S/S2). (tested with both cards) Regards, Luis Signed-off-by: Luis Alves --- drivers/media/dvb-frontends/Kconfig |7 + drivers/media/dvb-frontends/Makefile |1

[PATCH] Fixed misleading error when handling IR interrupts.

Hi, Handling the AV Core/IR interrupts schedules its workqueue but the schedule_work function returns false if @work was already on the kernel-global workqueue and true otherwise. Printing an error message if @work wasn't in the queue is wrong. Regards, Luis Signed-off-by: Luis