Re: [PATCH 0/2] media: ov7670: fix regressions caused by "hook s_power onto v4l2 core"

2019-03-12 Thread Lubomir Rintel
ed off > > drivers/media/i2c/ov7670.c | 32 +++- > 1 file changed, 27 insertions(+), 5 deletions(-) > > Cc: Lubomir Rintel > Cc: Jonathan Corbet > Cc: Sakari Ailus > Cc: Mauro Carvalho Chehab For the both patches in the set: Reviewed-b

Re: [PATCH v4 0/5] ov7670 fixes

2019-01-15 Thread Lubomir Rintel
On Tue, 2019-01-15 at 12:40 +0200, Sakari Ailus wrote: > On Tue, Jan 15, 2019 at 09:54:43AM +0100, Lubomir Rintel wrote: > > Hi, > > > > here are the ov7670 patches originally from the "media: make Marvell camera > > work on DT-based OLPC XO-1.75" updated to a

[PATCH v4 1/5] ov7670: Remove useless use of a ret variable

2019-01-15 Thread Lubomir Rintel
From: Sakari Ailus Instead of assigning the return value to ret and then checking and returning it, just return the value to the caller directly. The success value is always 0. Signed-off-by: Sakari Ailus Acked-by: Lubomir Rintel --- drivers/media/i2c/ov7670.c | 6 +- 1 file changed, 1

[PATCH v4 4/5] media: ov7670: split register setting from set_fmt() logic

2019-01-15 Thread Lubomir Rintel
This will allow us to restore the last set format after the device returns from a power off. Signed-off-by: Lubomir Rintel --- drivers/media/i2c/ov7670.c | 80 ++ 1 file changed, 46 insertions(+), 34 deletions(-) diff --git a/drivers/media/i2c/ov7670.c b

[PATCH v4 2/5] media: ov7670: hook s_power onto v4l2 core

2019-01-15 Thread Lubomir Rintel
tual power callback. Signed-off-by: Lubomir Rintel Signed-off-by: Sakari Ailus --- drivers/media/i2c/ov7670.c | 50 +- 1 file changed, 44 insertions(+), 6 deletions(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index 61c47c61c693..4679aa9dc

[PATCH v4 0/5] ov7670 fixes

2019-01-15 Thread Lubomir Rintel
Hi, here are the ov7670 patches originally from the "media: make Marvell camera work on DT-based OLPC XO-1.75" updated to apply cleanly on top of master as requested. I've also added "ov7670: Remove useless use of a ret variable" with my Ack slapped on it. Lubo

[PATCH v4 5/5] media: ov7670: split register setting from set_framerate() logic

2019-01-15 Thread Lubomir Rintel
This will allow us to restore the last set frame rate after the device returns from a power off. Signed-off-by: Lubomir Rintel --- drivers/media/i2c/ov7670.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers

[PATCH v4 3/5] media: ov7670: control clock along with power

2019-01-15 Thread Lubomir Rintel
r the sensor is clocked up. Signed-off-by: Lubomir Rintel Signed-off-by: Sakari Ailus --- drivers/media/i2c/ov7670.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index 4679aa9

Re: [PATCH v3 02/14] media: ov7670: split register setting from set_framerate() logic

2019-01-15 Thread Lubomir Rintel
On Tue, 2019-01-15 at 01:03 +0200, Sakari Ailus wrote: > On Tue, Nov 20, 2018 at 11:03:07AM +0100, Lubomir Rintel wrote: > > This will allow us to restore the last set frame rate after the device > > returns from a power off. > > > > Signed-off-by: Lubomir Rintel >

Re: [PATCH v3 03/14] media: ov7670: hook s_power onto v4l2 core

2019-01-13 Thread Lubomir Rintel
On Thu, 2019-01-10 at 18:59 +0200, Sakari Ailus wrote: > Hi Lubomir, > > On Wed, Nov 28, 2018 at 12:29:33PM +0100, Lubomir Rintel wrote: > > On Thu, 2018-11-22 at 14:21 +0200, Sakari Ailus wrote: > > > Hi Lubomir, > > > > > > On Tue, Nov 20, 2018

Re: [PATCH V2] mm: Replace all open encodings for NUMA_NO_NODE

2018-12-05 Thread Lubomir Rintel
On Wed, 2018-12-05 at 17:01 +0530, Anshuman Khandual wrote: > > On 12/05/2018 02:56 AM, Lubomir Rintel wrote: > > On Mon, 2018-11-26 at 17:56 +0530, Anshuman Khandual wrote: > > > At present there are multiple places where invalid node number is encoded > > >

Re: [PATCH V2] mm: Replace all open encodings for NUMA_NO_NODE

2018-12-04 Thread Lubomir Rintel
On Mon, 2018-11-26 at 17:56 +0530, Anshuman Khandual wrote: > At present there are multiple places where invalid node number is encoded > as -1. Even though implicitly understood it is always better to have macros > in there. Replace these open encodings for an invalid node number with the > global

Re: [PATCH 1/6] media: v4l2-subdev: stub v4l2_subdev_get_try_format() 

2018-12-04 Thread Lubomir Rintel
On Mon, 2018-12-03 at 14:48 +0100, jacopo mondi wrote: > Hi Lubomir, > > thanks for the patches > > On Wed, Nov 28, 2018 at 06:19:13PM +0100, Lubomir Rintel wrote: > > Provide a dummy implementation when configured without > > CONFIG_VIDEO_V4L2_SUBDEV_API to avoid

[PATCH] [media] marvell-ccic: trivial fix to the datasheet URL

2018-12-03 Thread Lubomir Rintel
Signed-off-by: Lubomir Rintel --- drivers/media/platform/marvell-ccic/cafe-driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/marvell-ccic/cafe-driver.c b/drivers/media/platform/marvell-ccic/cafe-driver.c index 2986cb4b88d0..8d00d9d8adff 100644

[PATCH 1/6] media: v4l2-subdev: stub v4l2_subdev_get_try_format()

2018-11-28 Thread Lubomir Rintel
Provide a dummy implementation when configured without CONFIG_VIDEO_V4L2_SUBDEV_API to avoid ifdef dance in the drivers that can be built either with or without the option. Suggested-by: Jacopo Mondi Signed-off-by: Lubomir Rintel --- include/media/v4l2-subdev.h | 11 +++ 1 file changed

[PATCH 2/6] media: ov7740: get rid of extra ifdefs

2018-11-28 Thread Lubomir Rintel
Stubbed v4l2_subdev_get_try_format() will return a correct error when configured without CONFIG_VIDEO_V4L2_SUBDEV_API. Signed-off-by: Lubomir Rintel --- drivers/media/i2c/ov7740.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/drivers/media/i2c

[PATCH 4/6] media: ov2680: get rid of extra ifdefs

2018-11-28 Thread Lubomir Rintel
Stubbed v4l2_subdev_get_try_format() will return a correct error when configured without CONFIG_VIDEO_V4L2_SUBDEV_API. Signed-off-by: Lubomir Rintel --- drivers/media/i2c/ov2680.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/media/i2c/ov2680.c b

[PATCH 3/6] media: ov2659: get rid of extra ifdefs

2018-11-28 Thread Lubomir Rintel
Stubbed v4l2_subdev_get_try_format() will return a correct error when configured without CONFIG_VIDEO_V4L2_SUBDEV_API. Signed-off-by: Lubomir Rintel --- drivers/media/i2c/ov2659.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/ov2659.c b

[PATCH 6/6] media: ov7670: get rid of extra ifdefs

2018-11-28 Thread Lubomir Rintel
Stubbed v4l2_subdev_get_try_format() will return a correct error when configured without CONFIG_VIDEO_V4L2_SUBDEV_API. Signed-off-by: Lubomir Rintel --- drivers/media/i2c/ov7670.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/media/i2c/ov7670.c b

[PATCH 5/6] media: ov5695: get rid of extra ifdefs

2018-11-28 Thread Lubomir Rintel
Stubbed v4l2_subdev_get_try_format() will return a correct error when configured without CONFIG_VIDEO_V4L2_SUBDEV_API. Signed-off-by: Lubomir Rintel --- drivers/media/i2c/ov5695.c | 38 -- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a

[PATCH 0/6] media: don't ifdef v4l2_subdev_get_try_format() any more

2018-11-28 Thread Lubomir Rintel
Hi, this patch set does a minor cleanup as suggested by Jacopo. All driver patches (2-6) depend on the first one. I've just compile-tested most of these as the only actual sensor I have is the ov7670. Cheers, Lubo In-Reply-To:

Re: [PATCH v3 01/14] media: ov7670: split register setting from set_fmt() logic

2018-11-28 Thread Lubomir Rintel
On Thu, 2018-11-22 at 19:37 +0100, jacopo mondi wrote: > Hi Lubomir, > > On Tue, Nov 20, 2018 at 11:03:06AM +0100, Lubomir Rintel wrote: > > This will allow us to restore the last set format after the device > > returns > > from a power off. > >

Re: [PATCH v3 03/14] media: ov7670: hook s_power onto v4l2 core

2018-11-28 Thread Lubomir Rintel
On Thu, 2018-11-22 at 14:21 +0200, Sakari Ailus wrote: > Hi Lubomir, > > On Tue, Nov 20, 2018 at 11:03:08AM +0100, Lubomir Rintel wrote: > > The commit 71862f63f351 ("media: ov7670: Add the ov7670_s_power function") > > added a power control routing. However, i

[PATCH v3 01/14] media: ov7670: split register setting from set_fmt() logic

2018-11-20 Thread Lubomir Rintel
This will allow us to restore the last set format after the device returns from a power off. Signed-off-by: Lubomir Rintel --- Changes since v2: - This patch was added to the series drivers/media/i2c/ov7670.c | 80 ++ 1 file changed, 46 insertions(+), 34

[PATCH v3 04/14] media: ov7670: control clock along with power

2018-11-20 Thread Lubomir Rintel
r the sensor is clocked up. Signed-off-by: Lubomir Rintel --- drivers/media/i2c/ov7670.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index cbaab60c..d7635fb2d713 100644 --- a/dr

[PATCH v3 05/14] media: dt-bindings: marvell,mmp2-ccic: Add Marvell MMP2 camera

2018-11-20 Thread Lubomir Rintel
Add Marvell MMP2 camera host interface. Signed-off-by: Lubomir Rintel --- Changes since v2: - Added #clock-cells, clock-names, port .../bindings/media/marvell,mmp2-ccic.txt | 37 +++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v3 03/14] media: ov7670: hook s_power onto v4l2 core

2018-11-20 Thread Lubomir Rintel
tual power callback. Signed-off-by: Lubomir Rintel --- Changes since v2: - Restore the controls, format and frame rate on power on drivers/media/i2c/ov7670.c | 50 +- 1 file changed, 44 insertions(+), 6 deletions(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers

[PATCH v3 07/14] [media] marvell-ccic: don't generate EOF on parallel bus

2018-11-20 Thread Lubomir Rintel
that chunk. Tested on an OLPC XO-1.75. Fixes: 05fed81625bf755cc67c5864cdfd18b69ea828d1 Signed-off-by: Lubomir Rintel --- drivers/media/platform/marvell-ccic/mcam-core.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c b/drivers/media/platform/ma

[PATCH v3 06/14] [media] marvell-ccic: fix DMA s/g desc number calculation

2018-11-20 Thread Lubomir Rintel
_desc_nent altogether. Tested on OLPC XO-1.75 machine. Doesn't affect the OLPC XO-1's Cafe driver, since that one doesn't do DMA. Fixes: d790b7eda953df474f470169ebdf111c02fa7a2d Signed-off-by: Lubomir Rintel --- drivers/media/platform/marvell-ccic/mcam-core.c | 5 +++-- 1 file ch

[PATCH v3 09/14] [media] marvell-ccic: drop unused stuff

2018-11-20 Thread Lubomir Rintel
Remove structure members and headers that are not actually used. Saves us from some noise in subsequent cleanup commits. Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek --- drivers/media/platform/marvell-ccic/mcam-core.c | 1 - drivers/media/platform/marvell-ccic/mcam-core.h | 2

[PATCH v3 11/14] [media] marvell-ccic: rename the clocks

2018-11-20 Thread Lubomir Rintel
Use the names more suitable for devicetree bindings. There are no board files utilizing this, thus we seem to be at liberty at renaming this without consequences. Signed-off-by: Lubomir Rintel --- Changes since v2: - This patch was added to the series drivers/media/platform/marvell-ccic/mmp

[PATCH v3 08/14] Revert "[media] marvell-ccic: reset ccic phy when stop streaming for stability"

2018-11-20 Thread Lubomir Rintel
This accesses the clock registers directly and thus is going to stay in the way of making the driver devicetree friendly. No boards seems to actually use this. If it's somehow actually needed it needs to be done differently. This reverts commit 7c269f454e7a51b151d94f99344120efa1cd0acb. --- .../m

[PATCH v3 10/14] [media] marvell-ccic/mmp: enable clock before accessing registers

2018-11-20 Thread Lubomir Rintel
The access to REG_CLKCTRL or REG_CTRL1 without the clock enabled hangs the machine. Enable the clock first. Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek --- drivers/media/platform/marvell-ccic/mmp-driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers

[PATCH v3 14/14] [media] marvell-ccic: provide a clock for the sensor

2018-11-20 Thread Lubomir Rintel
nstance so that the sensor can ask us to enable the clock. Note that this is pretty dumb at the moment: the clock is hardwired to a particular frequency and parent. It was always the case. Signed-off-by: Lubomir Rintel --- Changes since v1: - [kbuild/ia64] depend on COMMON_CLK. - [smatch] fi

[PATCH v3 13/14] [media] marvell-ccic: use async notifier to get the sensor

2018-11-20 Thread Lubomir Rintel
-1.75). Signed-off-by: Lubomir Rintel --- Changes since v2: - Moved a typo fix hunk that was accidentally in the following patch here, to unbreak build. .../media/platform/marvell-ccic/cafe-driver.c | 49 -- .../media/platform/marvell-ccic/mcam-core.c | 157 -- .../media/pla

[PATCH v3 12/14] [media] marvell-ccic/mmp: add devicetree support

2018-11-20 Thread Lubomir Rintel
The platform data is actually not used anywhere (along with the CSI support) and should be safe to remove. Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek --- Changes since v1: - s/This are/These are/ in a comment .../media/platform/marvell-ccic/mmp-driver.c | 36 ++- 1

[PATCH v3 02/14] media: ov7670: split register setting from set_framerate() logic

2018-11-20 Thread Lubomir Rintel
This will allow us to restore the last set frame rate after the device returns from a power off. Signed-off-by: Lubomir Rintel --- Changes since v2: - This patch was added to the series drivers/media/i2c/ov7670.c | 30 ++ 1 file changed, 14 insertions(+), 16

[PATCH v3 0/14] media: make Marvell camera work on DT-based OLPC XO-1.75

2018-11-20 Thread Lubomir Rintel
Hi, this is the third spin of a patchset that modernizes the Marvel MMP2 CCIC driver. Notably, it ports it from the platform data (which seems unused as the board support code never made it) to devicetree. At the core of the rework is the move to asynchronous sensor discovery and clock management

[PATCH v2 0/11] media: make Marvell camera work on DT-based OLPC XO-1.75

2018-11-11 Thread Lubomir Rintel
Hello, this patch set somewhat modernizes the Marvel MMP2 CCIC driver. Notably, it ports it from the platform data (which seems unused as the board support code never made it) to devicetree. At the core of the rework is the move to asynchronous sensor discovery and clock management with the stand

[PATCH v2 05/11] [media] marvell-ccic: don't generate EOF on parallel bus

2018-11-11 Thread Lubomir Rintel
that chunk. Tested on an OLPC XO-1.75. Fixes: 05fed81625bf755cc67c5864cdfd18b69ea828d1 Signed-off-by: Lubomir Rintel --- drivers/media/platform/marvell-ccic/mcam-core.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c b/drivers/media/platform/ma

[PATCH v2 02/11] media: ov7670: control clock along with power

2018-11-11 Thread Lubomir Rintel
r the sensor is clocked up. Signed-off-by: Lubomir Rintel --- drivers/media/i2c/ov7670.c | 37 + 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index d87f2362bf40..a3e72c62382c 100644

[PATCH v2 08/11] [media] marvell-ccic/mmp: enable clock before accessing registers

2018-11-11 Thread Lubomir Rintel
The access to REG_CLKCTRL or REG_CTRL1 without the clock enabled hangs the machine. Enable the clock first. Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek --- drivers/media/platform/marvell-ccic/mmp-driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers

[PATCH v2 06/11] Revert "[media] marvell-ccic: reset ccic phy when stop streaming for stability"

2018-11-11 Thread Lubomir Rintel
This accesses the clock registers directly and thus is going to stay in the way of making the driver devicetree friendly. No boards seems to actually use this. If it's somehow actually needed it needs to be done differently. This reverts commit 7c269f454e7a51b151d94f99344120efa1cd0acb. --- .../m

[PATCH v2 11/11] [media] marvell-ccic: provide a clock for the sensor

2018-11-11 Thread Lubomir Rintel
nstance so that the sensor can ask us to enable the clock. Note that this is pretty dumb at the moment: the clock is hardwired to a particular frequency and parent. It was always the case. Signed-off-by: Lubomir Rintel --- Changes since v1: - [kbuild/ia64] depend on COMMON_CLK. - [smatch] fi

[PATCH v2 10/11] [media] marvell-ccic: use async notifier to get the sensor

2018-11-11 Thread Lubomir Rintel
-1.75). Signed-off-by: Lubomir Rintel --- .../media/platform/marvell-ccic/cafe-driver.c | 49 -- .../media/platform/marvell-ccic/mcam-core.c | 157 -- .../media/platform/marvell-ccic/mcam-core.h | 5 +- .../media/platform/marvell-ccic/mmp-driver.c | 27 +-- .../linux/platform

[PATCH v2 04/11] [media] marvell-ccic: fix DMA s/g desc number calculation

2018-11-11 Thread Lubomir Rintel
_desc_nent altogether. Tested on OLPC XO-1.75 machine. Doesn't affect the OLPC XO-1's Cafe driver, since that one doesn't do DMA. Fixes: d790b7eda953df474f470169ebdf111c02fa7a2d Signed-off-by: Lubomir Rintel --- drivers/media/platform/marvell-ccic/mcam-core.c | 5 +++-- 1 file ch

[PATCH v2 09/11] [media] marvell-ccic/mmp: add devicetree support

2018-11-11 Thread Lubomir Rintel
The platform data is actually not used anywhere (along with the CSI support) and should be safe to remove. Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek --- Changes since v1: - s/This are/These are/ in a comment .../media/platform/marvell-ccic/mmp-driver.c | 36 ++- 1

[PATCH v2 07/11] [media] marvell-ccic: drop unused stuff

2018-11-11 Thread Lubomir Rintel
Remove structure members and headers that are not actually used. Saves us from some noise in subsequent cleanup commits. Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek --- drivers/media/platform/marvell-ccic/mcam-core.c | 1 - drivers/media/platform/marvell-ccic/mcam-core.h | 2

[PATCH v2 03/11] media: dt-bindings: marvell,mmp2-ccic: Add Marvell MMP2 camera

2018-11-11 Thread Lubomir Rintel
Add Marvell MMP2 camera host interface. Signed-off-by: Lubomir Rintel --- .../bindings/media/marvell,mmp2-ccic.txt | 30 +++ 1 file changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt diff --git a/Documentation

[PATCH v2 01/11] media: ov7670: hook s_power onto v4l2 core

2018-11-11 Thread Lubomir Rintel
The commit 71862f63f351 ("media: ov7670: Add the ov7670_s_power function") added a s_power function. For some reason it didn't register it with v4l2, only uses it internally. Fix this now. Signed-off-by: Lubomir Rintel --- drivers/media/i2c/ov7670.c | 1 + 1 file changed, 1 ins

Re: [PATCH] [media] ov7670: make "xclk" clock optional

2018-11-05 Thread Lubomir Rintel
On Mon, 2018-11-05 at 18:15 +0100, jacopo mondi wrote: > Hi Lubo, > > On Mon, Nov 05, 2018 at 04:22:15PM +0100, Lubomir Rintel wrote: > > On Mon, 2018-11-05 at 15:22 +0100, jacopo mondi wrote: > > > Hi Lubo, > > > > > > On Mon, Nov 05, 2018

Re: [PATCH] [media] ov7670: make "xclk" clock optional

2018-11-05 Thread Lubomir Rintel
On Mon, 2018-11-05 at 15:22 +0100, jacopo mondi wrote: > Hi Lubo, > > On Mon, Nov 05, 2018 at 02:12:18PM +0100, Lubomir Rintel wrote: > > Hello, > > > > On Mon, 2018-11-05 at 11:58 +0100, jacopo mondi wrote: > > > Hi Lubomir, > > >+Sakari in Cc &g

Re: [PATCH] [media] ov7670: make "xclk" clock optional

2018-11-05 Thread Lubomir Rintel
Hello, On Mon, 2018-11-05 at 11:58 +0100, jacopo mondi wrote: > Hi Lubomir, >+Sakari in Cc > > I just noticed this, and the patch is now in v4.20, but let me comment > anyway on this. > > On Thu, Oct 04, 2018 at 11:29:03PM +0200, Lubomir Rintel wrote: > > When the

[PATCH 03/11] media: dt-bindings: marvell,mmp2-ccic: Add Marvell MMP2 camera

2018-11-04 Thread Lubomir Rintel
Add Marvell MMP2 camera host interface. Signed-off-by: Lubomir Rintel --- .../bindings/media/marvell,mmp2-ccic.txt | 30 +++ 1 file changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt diff --git a/Documentation

[PATCH 08/11] [media] marvell-ccic/mmp: enable clock before accessing registers

2018-11-04 Thread Lubomir Rintel
The access to REG_CLKCTRL or REG_CTRL1 without the clock enabled hangs the machine. Enable the clock first. Signed-off-by: Lubomir Rintel --- drivers/media/platform/marvell-ccic/mmp-driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/platform/marvell

[PATCH 05/11] [media] marvell-ccic: don't generate EOF on parallel bus

2018-11-04 Thread Lubomir Rintel
that chunk. Tested on an OLPC XO-1.75. Fixes: 05fed81625bf755cc67c5864cdfd18b69ea828d1 Signed-off-by: Lubomir Rintel --- drivers/media/platform/marvell-ccic/mcam-core.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c b/drivers/media/platform/ma

[PATCH 06/11] [media] marvell-ccic: drop ctlr_reset()

2018-11-04 Thread Lubomir Rintel
This accesses the clock registers directly and thus is not too devicetree friendly. If it's actually needed it needs to be done differently. Signed-off-by: Lubomir Rintel --- .../media/platform/marvell-ccic/mcam-core.c | 6 - .../media/platform/marvell-ccic/mcam-core.h

[PATCH 01/11] media: ov7670: hook s_power onto v4l2 core

2018-11-04 Thread Lubomir Rintel
The commit 71862f63f351 ("media: ov7670: Add the ov7670_s_power function") added a s_power function. For some reason it didn't register it with v4l2, only uses it internally. Fix this now. Signed-off-by: Lubomir Rintel --- drivers/media/i2c/ov7670.c | 1 + 1 file changed, 1 ins

[PATCH 0/11] media: make Marvell camera work on DT-based OLPC XO-1.75

2018-11-04 Thread Lubomir Rintel
Hi, this patch set somewhat modernizes the Marvel MMP2 CCIC driver. Notably, it ports it from the platform data (which seems unused as the board support code never made it) to devicetree. At the core of the rework is the move to asynchronous sensor discovery and clock management with the standard

[PATCH 02/11] media: ov7670: control clock along with power

2018-11-04 Thread Lubomir Rintel
r the sensor is clocked up. Signed-off-by: Lubomir Rintel --- drivers/media/i2c/ov7670.c | 37 + 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index d87f2362bf40..a3e72c62382c 100644

[PATCH 09/11] [media] marvell-ccic/mmp: add devicetree support

2018-11-04 Thread Lubomir Rintel
The platform data is actually not used anywhere (along with the CSI support) and should be safe to remove. Signed-off-by: Lubomir Rintel --- .../media/platform/marvell-ccic/mmp-driver.c | 36 ++- 1 file changed, 27 insertions(+), 9 deletions(-) diff --git a/drivers/media

[PATCH 07/11] [media] marvell-ccic: drop unused stuff

2018-11-04 Thread Lubomir Rintel
Remove structure members and headers that are not actually used. Saves us from some noise in subsequent cleanup commits. Signed-off-by: Lubomir Rintel --- drivers/media/platform/marvell-ccic/mcam-core.c | 1 - drivers/media/platform/marvell-ccic/mcam-core.h | 3 --- drivers/media/platform

[PATCH 10/11] [media] marvell-ccic: use async notifier to get the sensor

2018-11-04 Thread Lubomir Rintel
-1.75). Signed-off-by: Lubomir Rintel --- .../media/platform/marvell-ccic/cafe-driver.c | 49 -- .../media/platform/marvell-ccic/mcam-core.c | 157 -- .../media/platform/marvell-ccic/mcam-core.h | 5 +- .../media/platform/marvell-ccic/mmp-driver.c | 27 +-- .../linux/platform

[PATCH 04/11] [media] marvell-ccic: fix DMA s/g desc number calculation

2018-11-04 Thread Lubomir Rintel
_desc_nent altogether. Tested on OLPC XO-1.75 machine. Doesn't affect the OLPC XO-1's Cafe driver, since that one doesn't do DMA. Fixes: d790b7eda953df474f470169ebdf111c02fa7a2d Signed-off-by: Lubomir Rintel --- drivers/media/platform/marvell-ccic/mcam-core.c | 5 +++-- 1 file ch

[PATCH 11/11] [media] marvell-ccic: provide a clock for the sensor

2018-11-04 Thread Lubomir Rintel
nstance so that the sensor can ask us to enable the clock. Note that this is pretty dumb at the moment: the clock is hardwired to a particular frequency and parent. It was always the case. Signed-off-by: Lubomir Rintel --- .../media/platform/marvell-ccic/cafe-driver.c | 11 +- .../media/platfo

Re: [PATCH] media: usbtv: fix brightness and contrast controls

2017-10-24 Thread Lubomir Rintel
7;s video output. > > Tested with an "EasyDAY" UTV007 device. > > Fixes: c53a846c48f2 ("usbtv: add video controls") > Signed-off-by: Adam Sampson Thank you! Reviewed-By: Lubomir Rintel > --- > drivers/media/usb/usbtv/usbtv-video.c | 4 ++-- > 1 fil

A patch slipped through the cracks?

2017-09-20 Thread Lubomir Rintel
Hi, we're trying to get this reasonably trivial patch [1] applied for more than a year and four attempts now. (I'm not including it in this message so that this message won't be ignored for the same reason the submissions were, whatever they are.) [1] https://patchwork.linuxtv.org/patch/40862/ I

Re: [PATCH 3/3] media: add V4L2_CAP_VDEV_CENTERED flag on vdev-centric drivers

2017-08-25 Thread Lubomir Rintel
On Fri, 2017-08-25 at 06:40 -0300, Mauro Carvalho Chehab wrote: > From: Mauro Carvalho Chehab > > Those devices are controlled via their V4L2 device. Add a > flag to indicate them as such. > > Signed-off-by: Mauro Carvalho Chehab > Signed-off-by: Mauro Carvalho Cheha

[PATCH] usbtv: add a new usbid

2017-02-23 Thread Lubomir Rintel
From: Icenowy Zheng A new usbid of UTV007 is found in a newly bought device. The usbid is 1f71:3301. The ID on the chip is: UTV007 A89029.1 1520L18K1 Both video and audio is tested with the modified usbtv driver. Reviewed-by: Lubomir Rintel Signed-off-by: Icenowy Zheng Signed-off-by

Re: [PATCH RESEND] [media] usbtv: add a new usbid

2017-02-07 Thread Lubomir Rintel
btv driver. > > Signed-off-by: Icenowy Zheng Acked-by: Lubomir Rintel Thanks for resending this. I can't seem to find the original posting in the patchwork and don't see how could it have slipped through the cracks. But then my understanding of how does the media tree maintenance mig

[PATCH] [media] usbtv: add sharpness control

2017-02-05 Thread Lubomir Rintel
Signed-off-by: Lubomir Rintel --- drivers/media/usb/usbtv/usbtv-video.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/media/usb/usbtv/usbtv-video.c b/drivers/media/usb/usbtv/usbtv-video.c index d3b6d3d..8135614 100644 --- a/drivers/media/usb/usbtv/usbtv-video.c +++ b

Re: [PATCH] [media] usbtv: add a new usbid

2016-12-05 Thread Lubomir Rintel
On Mon, 2016-12-05 at 23:47 +0800, Icenowy Zheng wrote: > 2016年12月5日 19:49于 Lubomir Rintel 写道: > > > > On Sun, 2016-12-04 at 22:59 +0800, Icenowy Zheng wrote:  > > > > > > 04.12.2016, 22:00, "Icenowy Zheng" :  > > > > A new usbid of UTV007 i

Re: [PATCH] [media] usbtv: add a new usbid

2016-12-05 Thread Lubomir Rintel
driver. Thank you. Acked-by: Lubomir Rintel Also, it may make sense to add Tested-by: Icenowy Zheng > > Signed-off-by: Icenowy Zheng > --- >  drivers/media/usb/usbtv/usbtv-core.c | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/drivers/media/usb/usbtv/usbtv-core

Re: [PATCH] [media] usbtv: add a new usbid

2016-12-05 Thread Lubomir Rintel
On Sun, 2016-12-04 at 22:59 +0800, Icenowy Zheng wrote: > > 04.12.2016, 22:00, "Icenowy Zheng" : > > A new usbid of UTV007 is found in a newly bought device. > > > > The usbid is 1f71:3301. > > > > The ID on the chip is: > > UTV007 > > A89029.1 > > 1520L18K1 > > > > Seems that my device come w

Re: [PATCH] [media] usbtv: don't do DMA on stack

2016-11-16 Thread Lubomir Rintel
> USB_RECIP_DEVICE, >   0, index, (void *)data, size, 0); > - if (ret < 0) { > + > +error: > + if (ret < 0) >   dev_warn(usbtv->dev, "Failed to submit a control > request.\n"); > - return ret; > -

[PATCH] [media] usbtv: add video controls

2016-10-16 Thread Lubomir Rintel
Brightness, Contrast, Hue and Color Saturation are supported. Signed-off-by: Lubomir Rintel --- drivers/media/usb/usbtv/usbtv-video.c | 97 ++- drivers/media/usb/usbtv/usbtv.h | 3 ++ 2 files changed, 99 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH] [media] usbtv: improve a comment

2016-06-01 Thread Lubomir Rintel
Patrick Keshishian improved the explanation of the protocol when porting the driver to OpenBSD. Given it's a reverse engineering one and there's no documetnation it might be helpful to whoever hacks on the driver. Signed-off-by: Patrick Keshishian Signed-off-by: Lubomir Rintel --

[PATCH] [media] usbtv: clarify the licensing

2016-06-01 Thread Lubomir Rintel
egally required, nevertheless the clause 1. of the rights grant refest to it. Signed-off-by: Lubomir Rintel Acked-by: Federico Simoncelli --- drivers/media/usb/usbtv/usbtv-audio.c | 28 ++-- drivers/media/usb/usbtv/usbtv-core.c | 40 +++ drivers/

Re: [PATCH] usbtv: discard redundant video fields

2015-12-21 Thread Lubomir Rintel
n the buffer, causing video artifacts. > > Do not push a new frame after processing every odd field, but do it > only after those which come after an even field. > > Signed-off-by: Nikola Forró Acked-by: Lubomir Rintel Thanks, Lubo -- To unsubscribe from this list: send the li

[RESEND PATCH] saa7146: Create a device name before it's used

2014-10-02 Thread Lubomir Rintel
request_irq() uses it, tries to create a procfs file with an empty name otherwise. Link: https://bugzilla.kernel.org/show_bug.cgi?id=83771 Signed-off-by: Lubomir Rintel --- drivers/media/common/saa7146/saa7146_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH] saa7146: Create a device name before it's used

2014-09-24 Thread Lubomir Rintel
request_irq() uses it, tries to create a procfs file with an empty name otherwise. Link: https://bugzilla.kernel.org/show_bug.cgi?id=83771 Signed-off-by: Lubomir Rintel --- drivers/media/common/saa7146/saa7146_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

Re: [PATCH 2/2] usbtv: add audio support

2014-08-05 Thread Lubomir Rintel
Hi, On Tue, 2014-02-04 at 06:22 -0200, Mauro Carvalho Chehab wrote: > Em Tue, 7 Jan 2014 23:13:22 +0100 > Federico Simoncelli escreveu: > > > From: Federico Simoncelli > > > > Signed-off-by: Federico Simoncelli > > Tested-by: Lubomir Rintel > > --

Re: [PATCH] [media] usbtv: fix leak at failure path in usbtv_probe()

2014-05-26 Thread Lubomir Rintel
On Sat, 2014-05-24 at 00:47 +0400, Alexey Khoroshilov wrote: > Error handling code in usbtv_probe() misses usb_put_dev(). > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Acked-by: Lubomir Rintel Thank you! Lubo > --

[PATCH] [media] usbtv: Add support for PAL video source.

2013-10-21 Thread Lubomir Rintel
From: Georg Kaindl Signed-off-by: Georg Kaindl Tested-by: Lubomir Rintel --- Hi, this is a patch sent to me by Georg Kaindl, who uses it with ambi-tv [1]. It looks fine to me and works well, please review and eventually pull it into the media tree. [1] https://github.com/gkaindl/ambi-tv

Re: [PATCH -next] [media] usbtv: remove unused including

2013-07-17 Thread Lubomir Rintel
On Wed, 2013-07-17 at 10:01 +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Remove including that don't need it. > > Signed-off-by: Wei Yongjun Acked-by: Lubomir Rintel -- To unsubscribe from this list: send the line "unsubscribe linux-media" in t

[PATCH] [media] usbtv: Add S-Video input support

2013-07-12 Thread Lubomir Rintel
Alongside already existing Composite input. Signed-off-by: Lubomir Rintel Cc: Hans Verkuil Cc: Mauro Carvalho Chehab Cc: linux-ker...@vger.kernel.org Cc: linux-media@vger.kernel.org --- drivers/media/usb/usbtv/usbtv.c | 99 --- 1 files changed, 82

[PATCH 1/2] [media] usbtv: Fix deinterlacing

2013-07-02 Thread Lubomir Rintel
igned-off-by: Lubomir Rintel Cc: Hans Verkuil Cc: Mauro Carvalho Chehab Cc: linux-ker...@vger.kernel.org Cc: linux-media@vger.kernel.org --- drivers/media/usb/usbtv/usbtv.c | 36 +--- 1 files changed, 25 insertions(+), 11 deletions(-) diff --git a/drivers/medi

[PATCH 2/2] [media] usbtv: Throw corrupted frames away

2013-07-02 Thread Lubomir Rintel
Ignore out of order data and mark incomplete buffers as errored. This gets rid of annoying flicker due to occassional garbage from hardware. Signed-off-by: Lubomir Rintel Cc: Hans Verkuil Cc: Mauro Carvalho Chehab Cc: linux-ker...@vger.kernel.org Cc: linux-media@vger.kernel.org --- drivers

[PATCH v4] [media] usbtv: Add driver for Fushicai USBTV007 video frame grabber

2013-06-17 Thread Lubomir Rintel
Reverse-engineered driver for cheapo video digitizer, made from observations of Windows XP driver. The protocol is not yet completely understood, so far we don't provide any controls, only support a single format out of three and don't support the audio device. Signed-off-by: Lubo

Re: [PATCH] [media] usbtv: Add driver for Fushicai USBTV007 video frame grabber

2013-06-17 Thread Lubomir Rintel
hat do not > have any controls) and as such I really don't like seeing a workaround like > this in a driver, especially since this seems like it should be working fine > with the latest gstreamer. I was using GStreamer from RHEL6. I retried with Fedora 17 and it worked fine. Regar

[PATCH v3] [media] usbtv: Add driver for Fushicai USBTV007 video frame grabber

2013-06-17 Thread Lubomir Rintel
Reverse-engineered driver for cheapo video digitizer, made from observations of Windows XP driver. The protocol is not yet completely understood, so far we don't provide any controls, only support a single format out of three and don't support the audio device. Signed-off-by: Lubomir

[PATCH] [media] usbtv: Add driver for Fushicai USBTV007 video frame grabber

2013-06-10 Thread Lubomir Rintel
Reverse-engineered driver for cheapo video digitizer, made from observations of Windows XP driver. The protocol is not yet completely understood, so far we don't provide any controls, only support a single format out of three and don't support the audio device. Signed-off-by: Lubomir

Re: [PATCH] [media] usbtv: Add driver for Fushicai USBTV007 video frame grabber

2013-06-10 Thread Lubomir Rintel
test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) Buffer ioctls: test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK Total: 36, Succeeded: 36, Failed: 0, Warnings: 0 -- Lubomir Rintel -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] [media] usbtv: Add driver for Fushicai USBTV007 video frame grabber

2013-06-10 Thread Lubomir Rintel
Reverse-engineered driver for cheapo video digitizer, made from observations of Windows XP driver. The protocol is not yet completely understood, so far we don't provide any controls, only support a single format out of three and don't support the audio device. Signed-off-by: Lubomir