On Thu, Dec 27, 2012 at 12:55:11PM +0100, Hans Verkuil wrote:
> On Wed December 26 2012 16:29:43 Kirill Smelkov wrote:
> > Most of *_ops and other structures in vivi.c were already declared const
> > but some have not. Constify and code/data will take less space:
> >
> &g
/media/platform/vivi.o
after: 12308 20 8 123363030 drivers/media/platform/vivi.o
i.e. vivi.o is now ~500 bytes less.
Signed-off-by: Kirill Smelkov
---
drivers/media/platform/vivi.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff
On Fri, Nov 30, 2012 at 12:10:59PM +0100, Hans Verkuil wrote:
> On Fri November 30 2012 12:02:14 Kirill Smelkov wrote:
[...]
> > P.S. Hans, if this is ok for you, would you please add your ack?
> >
>
> Looks good to me!
>
> Acked-by: Hans Verkuil
Thanks!
--
To
On Mon, Nov 19, 2012 at 09:52:36AM +0400, Kirill Smelkov wrote:
> On Sun, Nov 18, 2012 at 07:25:38AM -0200, Mauro Carvalho Chehab wrote:
> > Em 18-11-2012 07:24, Mauro Carvalho Chehab escreveu:
> > >Em 17-11-2012 08:45, Kirill Smelkov escreveu:
> > >>On Fri, Nov 16, 2
On Sun, Nov 18, 2012 at 07:25:38AM -0200, Mauro Carvalho Chehab wrote:
> Em 18-11-2012 07:24, Mauro Carvalho Chehab escreveu:
> >Em 17-11-2012 08:45, Kirill Smelkov escreveu:
> >>On Fri, Nov 16, 2012 at 01:46:58PM -0200, Mauro Carvalho Chehab wrote:
> >>>Em 16-11-201
On Fri, Nov 16, 2012 at 01:46:58PM -0200, Mauro Carvalho Chehab wrote:
> Em 16-11-2012 11:38, Hans Verkuil escreveu:
> >On Wed November 7 2012 12:30:01 Kirill Smelkov wrote:
[...]
> >>diff --git a/drivers/media/platform/vivi.c b/drivers/media/platform/vivi.c
> >>in
On Fri, Nov 16, 2012 at 03:51:23PM +0100, Hans Verkuil wrote:
> On Fri November 16 2012 15:48:41 Kirill Smelkov wrote:
> > On Fri, Nov 16, 2012 at 02:38:09PM +0100, Hans Verkuil wrote:
> > > On Wed November 7 2012 12:30:01 Kirill Smelkov wrote:
> > [...]
> >
>
On Fri, Nov 16, 2012 at 02:38:09PM +0100, Hans Verkuil wrote:
> On Wed November 7 2012 12:30:01 Kirill Smelkov wrote:
[...]
> > diff --git a/drivers/media/platform/vivi.c b/drivers/media/platform/vivi.c
> > index 37d0af8..5d1b374 100644
> > --- a/drivers/media/platform/viv
On Mon, Nov 12, 2012 at 10:46:26AM +0100, Hans Verkuil wrote:
> On Mon 12 November 2012 09:12:58 Kirill Smelkov wrote:
>
> > Ping. Is maybe something stupid on my side?
> >
>
> No, I've been abroad and haven't had time to look at it. I want to do that
> th
On Wed, Nov 07, 2012 at 03:30:01PM +0400, Kirill Smelkov wrote:
> On Fri, Nov 02, 2012 at 03:42:21PM +0100, Hans Verkuil wrote:
> > Thanks for the ping, I forgot about this patch...
>
> Thanks for feedback and for waiting. I'm here again...
>
>
> > On Tue October
On Fri, Nov 02, 2012 at 03:42:21PM +0100, Hans Verkuil wrote:
> Thanks for the ping, I forgot about this patch...
Thanks for feedback and for waiting. I'm here again...
> On Tue October 23 2012 15:35:21 Kirill Smelkov wrote:
> > On Tue, Oct 23, 2012 at 08:40:04AM +0200, H
On Fri, Nov 02, 2012 at 03:42:21PM +0100, Hans Verkuil wrote:
> Thanks for the ping, I forgot about this patch...
Thanks for the reply. Have to run now - will try to rework it in several
days.
Thanks again,
Kirill
> On Tue October 23 2012 15:35:21 Kirill Smelkov wrote:
> > On Tue,
On Fri, Nov 02, 2012 at 02:48:43PM +0100, Hans Verkuil wrote:
> On Fri November 2 2012 14:10:29 Kirill Smelkov wrote:
> > Hello up there. I was trying to use vivi to generate multiple video streams
> > for
> > my test-lab environment on atom system and noticed i
On Tue, Oct 23, 2012 at 05:35:21PM +0400, Kirill Smelkov wrote:
> On Tue, Oct 23, 2012 at 08:40:04AM +0200, Hans Verkuil wrote:
> > On Mon October 22 2012 19:01:40 Kirill Smelkov wrote:
> > > On Mon, Oct 22, 2012 at 04:16:14PM +0200, Hans Verkuil wrote:
> > > > O
[k] precalculate_line
...
0.14% rawv [vivi][k] gen_twopix
(i.e. gen_twopix and precalculate_line overheads are almost gone)
Signed-off-by: Kirill Smelkov
---
drivers/media/platform/vivi.c | 22 --
1 file changed, 16 insertions(+), 6 d
0.31% vivi-* [vivi][k] vivi_fillbuff
(i.e. vivi_fillbuff own overhead is almost gone)
Signed-off-by: Kirill Smelkov
---
drivers/media/platform/vivi.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/vivi.c b/drivers/media/pla
.36% vivi-* [vivi] [k] vivi_fillbuff
2.42% rawv [vivi] [k] precalculate_line
1.33% swapper [kernel.kallsyms] [k] read_hpet
Signed-off-by: Kirill Smelkov
---
drivers/media/platform/vivi.c | 2 +-
1 file cha
GB24 rendering I've introduced x24, which could be thought as
synthetic u24 for simplifying the code. That's done because for
memcpy used for conditional assignment, gcc generates suboptimal code
with more indirections.
Fortunately, in C struct assignment is builtin and
Hello up there. I was trying to use vivi to generate multiple video streams for
my test-lab environment on atom system and noticed it wastes a lot of cpu.
Please apply some optimization patches.
Thanks,
Kirill
Kirill Smelkov (4):
[media] vivi: Optimize gen_text()
[media] vivi: vivi_dev
Usage of TSTAMP_* macros has gone in 2010 in 730947bc (V4L/DVB: vivi:
clean up and a major overhaul) but the macros remain. Say goodbye to
them.
Cc: Hans Verkuil
Signed-off-by: Kirill Smelkov
---
drivers/media/platform/vivi.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers
On Tue, Oct 23, 2012 at 08:40:04AM +0200, Hans Verkuil wrote:
> On Mon October 22 2012 19:01:40 Kirill Smelkov wrote:
> > On Mon, Oct 22, 2012 at 04:16:14PM +0200, Hans Verkuil wrote:
> > > On Mon October 22 2012 15:54:44 Kirill Smelkov wrote:
> > > > I was testing my
On Mon, Oct 22, 2012 at 09:01:39PM +0400, Kirill Smelkov wrote:
> On Mon, Oct 22, 2012 at 04:16:14PM +0200, Hans Verkuil wrote:
> > On Mon October 22 2012 15:54:44 Kirill Smelkov wrote:
> > > I was testing my video-over-ethernet subsystem today, and vivi seemed to
> > >
On Mon, Oct 22, 2012 at 04:16:14PM +0200, Hans Verkuil wrote:
> On Mon October 22 2012 15:54:44 Kirill Smelkov wrote:
> > I was testing my video-over-ethernet subsystem today, and vivi seemed to
> > be perfect video source for testing when one don't have lots of capture
&g
e patch.
Thanks.
Signed-off-by: Kirill Smelkov
---
drivers/media/platform/vivi.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/vivi.c b/drivers/media/platform/vivi.c
index 3e6902a..48325f4 100644
--- a/drivers/media/platform/vivi.c
+++
Usage of BUFFER_TIMEOUT has gone in 2008 in 78718e5d (V4L/DVB (7492):
vivi: Simplify the vivi driver and avoid deadlocks), but the macro
remains. Say goodbye to it.
Signed-off-by: Kirill Smelkov
---
drivers/media/platform/vivi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media
On Thu, Jul 28, 2011 at 11:55:04AM -0300, Mauro Carvalho Chehab wrote:
> Em 28-07-2011 10:54, Kirill Smelkov escreveu:
> > Mauro, thanks for answering,
> >
> > On Thu, Jul 28, 2011 at 10:45:29AM -0300, Mauro Carvalho Chehab wrote:
> >> Em 28-07-2011 08:42, Kirill
Mauro, thanks for answering,
On Thu, Jul 28, 2011 at 10:45:29AM -0300, Mauro Carvalho Chehab wrote:
> Em 28-07-2011 08:42, Kirill Smelkov escreveu:
> > On Wed, Jul 27, 2011 at 09:42:08PM +0200, Mauro Carvalho Chehab wrote:
> >> This is an automatic generated email to let
HP Webcam on HP Mini
> 5103 netbook
> Author: Kirill Smelkov
> Date:Fri Jul 22 11:47:22 2011 -0300
Thanks
> The camera there identifies itself as being manufactured by Cheng Uei
> Precision Industry Co., Ltd (Foxlink), and product is titled as "HP
> Webcam [2 MP Fixed]&
Hi Laurent, All,
On Sat, Jul 23, 2011 at 01:12:11AM +0200, Laurent Pinchart wrote:
> Hi Kirill,
>
> On Saturday 23 July 2011 00:25:20 Kirill Smelkov wrote:
> > On Sat, Jul 23, 2011 at 12:03:57AM +0200, Laurent Pinchart wrote:
> > > On Friday 22 July 2011 16:47
Hi Laurent, All,
On Sat, Jul 23, 2011 at 12:03:57AM +0200, Laurent Pinchart wrote:
> Hi Kirill,
>
> On Friday 22 July 2011 16:47:22 Kirill Smelkov wrote:
> > [ Cc'ing Andrew Morton -- Andrew, could you please pick this patch, in
> >case there is no response from
x periodic bandwidth) will be entering the mainline via
Greg's usb tree.
8<
From: Kirill Smelkov
Subject: [PATCH] uvcvideo: Add FIX_BANDWIDTH quirk to HP Webcam found on HP
Mini 5103 netbook
The camera there identifies itself as being manufactured by Cheng Uei
Precision Industry
On Tue, Jun 21, 2011 at 10:07:43PM +0400, Kirill Smelkov wrote:
> The camera there identifeis itself as being manufactured by Cheng Uei
> Precision Industry Co., Ltd (Foxlink), and product is titled as "HP
> Webcam [2 MP Fixed]".
>
> I was trying to get 2 USB vide
cumentation in Documentation/ABI/ thoroughly, but
only "TBD" was put into Documentation/usb/ehci.txt -- the text there seems
to be outdated and much needing refreshing, before it could be amended.
Cc: Sarah Sharp
Signed-off-by: Kirill Smelkov
Acked-by: Alan Stern
---
Documentation/ABI
was written by Alan
Stern (in 57e06c11 "EHCI: force high-speed devices to run at full
speed"; Jan 16 2007), that's why I'm putting
Copyright (C) 2007 by Alan Stern
there after explicit request from the author.
Signed-off-by: Kirill Smelkov
Acked-by: Alan Stern
-
ription saying that set in stone 80% max periodic is
specified by USB 2.0;
Kirill Smelkov (2):
USB: EHCI: Move sysfs related bits into ehci-sysfs.c
USB: EHCI: Allow users to override 80% max periodic bandwidth
Documentation/ABI/testing/sysfs-module | 23
Documentation/usb/ehci.txt
On Fri, Jul 01, 2011 at 02:24:27PM -0700, Greg KH wrote:
> On Fri, Jul 01, 2011 at 03:47:11PM +0400, Kirill Smelkov wrote:
> > drivers/usb/host/ehci-sysfs.c | 104
> > +++--
>
> As you are adding new sysfs files, it is required that you a
was written by Alan
Stern (in 57e06c11 "EHCI: force high-speed devices to run at full
speed"; Jan 16 2007), that's why I'm putting
Copyright (C) 2007 by Alan Stern
there after explicit request from the author.
Signed-off-by: Kirill Smelkov
Acked-off-by: Alan Stern
-
riodic bandwidth is set to
100us/uframe by default exactly as it was before the patch. So only those of us
who need the extreme settings are taking the risk - normal users who do not
alter uframe_periodic_max sysfs attribute should not see any change at all.
Cc: Sarah Sharp
Signed-off-by: Kirill Sme
specified by USB 2.0;
Kirill Smelkov (2):
USB: EHCI: Move sysfs related bits into ehci-sysfs.c
USB: EHCI: Allow users to override 80% max periodic bandwidth
drivers/usb/host/ehci-hcd.c | 11 ++-
drivers/usb/host/ehci-hub.c | 75
drivers/usb/host/ehci-sched.c |
On Thu, Jun 30, 2011 at 11:01:01AM -0700, Sarah Sharp wrote:
> On Fri, Jun 24, 2011 at 08:48:06PM +0400, Kirill Smelkov wrote:
> >
> > Changes since v1:
> >
> >
> > - dropped RFC status as "this seems like the sort of feature somebody might
> >re
On Thu, Jun 23, 2011 at 01:14:04PM -0400, Alan Stern wrote:
> On Thu, 23 Jun 2011, Kirill Smelkov wrote:
>
> > > At 480 Mb/s, each microframe holds 7500 bytes (less if you count
> > > bit-stuffing). 4% of that is 300 bytes, which is not enough for a
> > > 512
lematic (less than 300*8 bittimes left per microframe), but
I think that is still enough for control traffic.
Signed-off-by: Kirill Smelkov
---
drivers/usb/host/ehci-hcd.c |6 +++
drivers/usb/host/ehci-sched.c | 17 +++
drivers/usb/host/ehci-sysfs.c | 98 ++
The only sysfs attr implemented so far is "companion" from ehci-hub.c,
but in the next patch we are going to add another sysfs file, so prior
to that let's structure things and move already-in-there sysfs code to
separate file.
Signed-off-by: Kirill Smelkov
---
drivers/usb/
max periodic is
specified by USB 2.0;
Kirill Smelkov (2):
USB: EHCI: Move sysfs related bits into ehci-sysfs.c
USB: EHCI: Allow users to override 80% max periodic bandwidth
drivers/usb/host/ehci-hcd.c | 11 ++-
drivers/usb/host/ehci-hub.c | 75 -
drivers/usb/host/ehci
On Wed, Jun 22, 2011 at 10:35:44AM -0700, matt mooney wrote:
> On 10:30 Wed 22 Jun , matt mooney wrote:
> > On 20:02 Wed 22 Jun , Kirill Smelkov wrote:
> > > There are cases, when 80% max isochronous bandwidth is too limiting.
> > >
> > > For exampl
On Wed, Jun 22, 2011 at 03:22:28PM -0400, Alan Stern wrote:
> On Wed, 22 Jun 2011, Kirill Smelkov wrote:
>
> > There are cases, when 80% max isochronous bandwidth is too limiting.
> >
> > For example I have two USB video capture cards which stream uncompressed
> >
me, just
to serve as a reasonable default.
NOTE: for two streams with max_pkt_size=3072 (worst case) both time
allocation would be 60us+60us=120us which is 96% periodic bandwidth
leaving 4% for bulk and control. I think this should work too.
Signed-off-by: Kirill Smelkov
Cc: Alan Stern
---
dri
480 YUV422 @30fps simultaneously. Hooray!
Signed-off-by: Kirill Smelkov
---
drivers/media/video/uvc/uvc_driver.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/uvc/uvc_driver.c
b/drivers/media/video/uvc/uvc_driver.c
index b6eae48..f633700 10
I have 3 IVC-200 cards (with 4 video channels on each).
2 of the cards identify theirselves as 000[0-3]:a155 (ids already in
cardlist) and another one identifies itself as 080[0-3]:a155, which ids
were unknown so far.
Note - it's IVC-200, not IVC-200G.
Signed-off-by: Kirill Sm
49 matches
Mail list logo