Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2012-01-01 Thread Kim, Heungjun
On 2011년 12월 30일 19:30, Sylwester Nawrocki wrote: Hi HeungJun, On 12/29/2011 06:08 AM, HeungJun, Kim wrote: -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Laurent Pinchart Sent: Wednesday, December 28, 2011 10:52 PM To

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-29 Thread Kim, Heungjun
Hi, On 2011년 12월 30일 08:58, Laurent Pinchart wrote: Hi, On Thursday 29 December 2011 06:08:07 HeungJun, Kim wrote: On Wednesday, December 28, 2011 10:52 PM Laurent Pinchart wrote: On Wednesday 28 December 2011 14:35:00 Sylwester Nawrocki wrote: On 12/28/2011 07:23 AM, HeungJun, Kim wrote: I

Re: [RFCv2 PATCH 08/11] v4l2-ctrls: simplify event subscription.

2011-06-08 Thread Kim, HeungJun
2011-06-06 오후 7:05, Sakari Ailus 쓴 글: > On Sat, Jun 04, 2011 at 12:28:04PM +0200, Hans Verkuil wrote: >> On Friday, June 03, 2011 21:55:10 Laurent Pinchart wrote: > [clip] +{ + int ret = 0; + + if (!fh->events) + ret = v4l2_event_init(fh); + if (!ret)

Re: [PATCH v2 3/4] m5mols: remove union in the m5mols_get_version(), and VERSION_SIZE

2011-06-06 Thread Kim HeungJun
2011. 6. 5., 오후 9:11, Sakari Ailus 작성: > On Sun, Jun 05, 2011 at 03:03:47PM +0300, Sakari Ailus wrote: > [clip] >>> - /* store version information swapped for being readable */ >>> - info->ver = version.ver; >>> info->ver.fw= be16_to_cpu(info->ver.fw); >>> info->ver.hw=

Re: [PATCH v9] Add support for M-5MOLS 8 Mega Pixel camera ISP

2011-06-06 Thread Kim HeungJun
Hi Sakari, 2011. 6. 5., 오후 8:55, Sakari Ailus 작성: > On Thu, May 26, 2011 at 04:12:47PM +0900, Kim, HeungJun wrote: >> Hi Sakari, > > Hi HeungJun, > >> 2011-05-25 ?? 10:54, Sakari Ailus ??? ???: >>> Hi HeungJun, >>> >>> Thanks for the patc

Re: v4l2 device property framework in userspace

2011-05-30 Thread Kim, HeungJun
Hi Martin, I'm not an expert of V4L2 and this camera sensor, too. But, if you don't mind, I want to leave some comments about the registers, and I hope that it helps you. 2011-05-30 오후 9:07, Martin Strubel 쓴 글: > Hi Hans, > >> >> Can you give examples of the sort of things that are in those regi

Re: I just wondering how to set shutter or aperture value in uvc driver.

2011-05-25 Thread Kim, HeungJun
Hi Laurent, 2011-05-25 오후 8:17, Laurent Pinchart 쓴 글: > Hi Heungjun, > > On Wednesday 25 May 2011 08:49:31 Kim, HeungJun wrote: >> Hi Laurent, >> >> I try to add the more exposure methods of the M-5MOLS driver. Currently, >> the only 2 exposure type ar

Re: I just wondering how to set shutter or aperture value in uvc driver.

2011-05-24 Thread Kim, HeungJun
missing. sorry :) 2011-05-25 오후 3:49, Kim, HeungJun 쓴 글: > Hi Laurent, > > I try to add the more exposure methods of the M-5MOLS driver. Currently, > the only 2 exposure type are available in the M-5MOLS driver - > V4L2_EXPOSURE_AUTO, V4L2_EXPOSURE_MANUAL. But, the HW is capable

I just wondering how to set shutter or aperture value in uvc driver.

2011-05-24 Thread Kim, HeungJun
Hi Laurent, I try to add the more exposure methods of the M-5MOLS driver. Currently, the only 2 exposure type are available in the M-5MOLS driver - V4L2_EXPOSURE_AUTO, V4L2_EXPOSURE_MANUAL. But, the HW is capable to So, I found the only UVC driver looks like using extra enumerations V4L2_EXPOSU

Re: [PATCH] Add support for M-5MOLS 8 Mega Pixel camera

2011-04-04 Thread Kim, HeungJun
2011-04-05 오후 2:36, Kim, HeungJun 쓴 글: > Hi Sungchun, > > The below comments and issues looks the firmware issues. > I add another comments, so you can check this out. > > The first plan of this driver I have, is to merge the basic driver code > of M-5MOLS. Because,

Re: [PATCH] Add support for M-5MOLS 8 Mega Pixel camera

2011-04-04 Thread Kim, HeungJun
be merged, also respond when the problem issued. The version considered with version, probably will be the next version. 2011-04-04 오후 9:20, Sungchun Kang 쓴 글: > Hi heungjun, > I have tested this version for a few days. > > On 03/16/2011 10:30 PM, Kim, Heungjun wrote: >> ---

Re: [RFC] API for controlling Scenemode Preset

2011-03-31 Thread Kim HeungJun
Hi Laurent, 2011. 3. 31., 오후 11:12, Laurent Pinchart 작성: > Hi HeungJun, > > On Thursday 31 March 2011 07:39:09 Kim, HeungJun wrote: >> Hello everyone, >> >> This is a suggestion about the preset for the scenemode of camera. It's >> just one API, and its r

[RFC] API for controlling Scenemode Preset

2011-03-30 Thread Kim, HeungJun
Hello everyone, This is a suggestion about the preset for the scenemode of camera. It's just one API, and its role determines which current scenemode preset of camera is. The kinds of scenemode are various at each camera. But, as you look around camera, the each scenemode has common name and the

Re: [RFC] V4L2 API for flash devices

2011-03-30 Thread Kim HeungJun
Hi Sakari, 2011. 3. 30., 오후 8:37, Sakari Ailus 작성: > Kim, HeungJun wrote: >> Hi Sakari, > > Hi HeungJun, > >> 2011-03-29 오후 11:41, Sakari Ailus 쓴 글: >>> Kim, HeungJun wrote: >> [snip] >>>> I think it's not different method to turn on/

Re: [RFC] V4L2 API for flash devices

2011-03-29 Thread Kim, HeungJun
Hi Sakari, 2011-03-29 오후 11:41, Sakari Ailus 쓴 글: > Kim, HeungJun wrote: [snip] >> I think it's not different method to turn on/off, whatever the mode name is. >> But, the mode name DEDICATED is look more reasonable, because the reason >> which is devided FLASH and TORC

Re: [RFC] V4L2 API for flash devices

2011-03-29 Thread Kim, HeungJun
Hi Sakari, Here's my humble opinions about this RFC. Almost, this control may be also applied immediately in our case. But, I have some opinions about that. So, read comments plz and I wish this might be help to it. 2011-03-28 오후 9:55, Sakari Ailus 쓴 글: > Hi, > > This is a proposal for an interf

[RFC PATCH v3 2/2] v4l2-ctrls: update auto focus mode documentation

2011-03-22 Thread Kim, Heungjun
Document about the mode of auto focus and new controls about rectangle auto focus Signed-off-by: Heungjun Kim Signed-off-by: Kyungmin Park --- Documentation/DocBook/v4l/controls.xml| 67 + Documentation/DocBook/v4l/videodev2.h.xml |8 +++ 2 files changed,

[RFC PATCH v3 1/2] v4l2-ctrls: support various modes and 4 coordinates of rectangle auto focus

2011-03-22 Thread Kim, Heungjun
V4L2_CID_FOCUS_AUTO_RECTANGLE_HEIGHT Signed-off-by: Kim, Heungjun Signed-off-by: Kyungmin Park --- drivers/media/video/v4l2-ctrls.c | 16 include/linux/videodev2.h| 13 + 2 files changed, 29 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-ctrls.c

[RFC PATCH v3 1/2] v4l2-ctrls: support various modes and 4 coordinates of rectangle auto focus

2011-03-22 Thread Kim, Heungjun
V4L2_CID_FOCUS_AUTO_RECTANGLE_HEIGHT Signed-off-by: Kim, Heungjun Signed-off-by: Kyungmin Park --- drivers/media/video/v4l2-ctrls.c | 16 include/linux/videodev2.h| 13 + 2 files changed, 29 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-ctrls.c

[RFC PATCH v3 0/2] v4l2-ctrls: add auto focus mode and controls

2011-03-22 Thread Kim, HeungJun
Hello, This is third version of RFC patch series about adding auto focus mode and controls. The patch of the previous version bring about the issue to be able to execute only once, not repeatedly. Because the each modes are defined by menu type. To solve this, we add the new control of choosing fo

Re: [RFC PATCH v3 0/2] v4l2-ctrls: add auto focus mode and controls

2011-03-22 Thread Kim, HeungJun
The comments of 2/2 patch are wrong. It's my fault. Please ignore this. And I'll send again. Sorry to confuse. 2011-03-22 오후 5:34, Kim, HeungJun 쓴 글: > Hello, > > This is third version of RFC patch series about adding auto focus mode > and controls. The patch of the previo

[RFC PATCH v3 2/2] v4l2-ctrls: update auto focus mode documentation

2011-03-22 Thread Kim, Heungjun
As following to change the boolean type of V4L2_CID_FOCUS_AUTO to menu type, this uvc is modified the usage of V4L2_CID_FOCUS_AUTO. Signed-off-by: Heungjun Kim Signed-off-by: Kyungmin Park --- Documentation/DocBook/v4l/controls.xml| 67 + Documentation/DocBook/

[RFC PATCH v3 1/2] v4l2-ctrls: support various modes and 4 coordinates of rectangle auto focus

2011-03-22 Thread Kim, Heungjun
V4L2_CID_FOCUS_AUTO_RECTANGLE_HEIGHT Signed-off-by: Kim, Heungjun Signed-off-by: Kyungmin Park --- drivers/media/video/v4l2-ctrls.c | 16 include/linux/videodev2.h| 13 + 2 files changed, 29 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-ctrls.c

[RFC PATCH v3 0/2] v4l2-ctrls: add auto focus mode and controls

2011-03-22 Thread Kim, HeungJun
Hello, This is third version of RFC patch series about adding auto focus mode and controls. The patch of the previous version bring about the issue to be able to execute only once, not repeatedly. Because the each modes are defined by menu type. To solve this, we add the new control of choosing fo

referencing other control values in the clustered control

2011-03-21 Thread Kim, HeungJun
Hi Hans, I have a question about referencing control values. For example: 1) "A" control and "B" control is clustered, and each is defined v4l2_ctrl a, b. 2) These two control is relevant, and start to make one process by real control "A". 3) The b->val is should be referenced for process in th

Re: [PATCH] Add support for M-5MOLS 8 Mega Pixel camera

2011-03-20 Thread Kim, HeungJun
Hi Sylwester, 2011-03-20 오전 4:28, Sylwester Nawrocki 쓴 글: > On 03/19/2011 04:11 PM, Kim HeungJun wrote: >> Hi Sylwester, >> >> Thanks for the reviews. :) >> >> 2011. 3. 19., 오후 10:37, Sylwester Nawrocki 작성: >> >>> Hi HeungJun, >>> >>&

Re: [PATCH] Add support for M-5MOLS 8 Mega Pixel camera

2011-03-19 Thread Kim HeungJun
Hi Sylwester, Thanks for the reviews. :) 2011. 3. 19., 오후 10:37, Sylwester Nawrocki 작성: > Hi HeungJun, > > On 03/16/2011 02:38 PM, Kim, Heungjun wrote: >> Add I2C/V4L2 subdev driver for M-5MOLS camera sensor with integrated >> image signal processor. >> >

Re: the focus terms or sequences

2011-03-16 Thread Kim HeungJun
Hi, 2011. 3. 17., 오전 12:27, Laurent Pinchart 작성: > On Wednesday 16 March 2011 16:17:30 Kim HeungJun wrote: >> 2011. 3. 16., 오후 11:15, Laurent Pinchart 작성: >>> On Wednesday 16 March 2011 05:50:11 Kim, HeungJun wrote: >>>> 2011-03-16 오전 9:14, Laurent Pinchart 쓴 글

Re: the focus terms or sequences

2011-03-16 Thread Kim HeungJun
2011. 3. 16., 오후 11:15, Laurent Pinchart 작성: > Hi, > > On Wednesday 16 March 2011 05:50:11 Kim, HeungJun wrote: >> 2011-03-16 오전 9:14, Laurent Pinchart 쓴 글: > > [snip] > >>> What bothers me with your auto-focus implementation is that the user >>> migh

[PATCH] Add support for M-5MOLS 8 Mega Pixel camera

2011-03-16 Thread Kim, Heungjun
Add I2C/V4L2 subdev driver for M-5MOLS camera sensor with integrated image signal processor. Signed-off-by: Heungjun Kim Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Hi Hans and everyone, This is sixth version of M-5MOLS 8 Mega Pixel camera sensor. And, if you see previo

Re: the focus terms or sequences

2011-03-15 Thread Kim, HeungJun
Hi Laurent, First, I hope to be good at the warsaw meeting. :) 2011-03-16 오전 9:14, Laurent Pinchart 쓴 글: > Hi HeungJun, > > On Monday 14 March 2011 08:02:01 Kim, HeungJun wrote: >> Hi Laurent, >> >> I heard of that there was a chance between you and Sylwester tellin

the focus terms or sequences

2011-03-14 Thread Kim, HeungJun
Hi Laurent, I heard of that there was a chance between you and Sylwester telling about the menu entries focus, and so after that, probably this menu style of the patch I sent, need to be more upgraded. So, can you tell me the kind or sequence of the UVC device breifly? I guess the word *AUTO* a

Re: [RFC PATCH RESEND v2 3/3] v4l2-ctrls: document the changes about auto focus mode

2011-03-08 Thread Kim, HeungJun
Hi Sylwester, 2011-03-09 오전 8:08, Sylwester Nawrocki 쓴 글: > Hi HeungJun, > > On 03/03/2011 04:22 PM, Laurent Pinchart wrote: >> Hi, >> >> On Thursday 03 March 2011 15:34:36 Kim HeungJun wrote: >>> 2011. 3. 3., 오후 10:24, Laurent Pinchart 작성: >>>>

Re: [RFC PATCH RESEND v2 3/3] v4l2-ctrls: document the changes about auto focus mode

2011-03-03 Thread Kim HeungJun
2011. 3. 4., 오전 12:22, Laurent Pinchart 작성: > Hi, > > On Thursday 03 March 2011 15:34:36 Kim HeungJun wrote: >> 2011. 3. 3., 오후 10:24, Laurent Pinchart 작성: >>> On Thursday 03 March 2011 14:17:10 Kim HeungJun wrote: >>>> 2011. 3. 3., 오후 7:08, Laurent Pinchart

Re: using V4L2_CID_BRIGHTNESS or V4L2_CID_EXPOSURE in the camera

2011-03-03 Thread Kim HeungJun
Hi Laurent, 2011. 3. 4., 오전 12:05, Laurent Pinchart 작성: > Hi Kim, probably it's difficult to call my name. Just call me riverful. > > On Thursday 03 March 2011 16:01:24 Kim HeungJun wrote: >> Hello everyone, >> >> I have a question about realization t

using V4L2_CID_BRIGHTNESS or V4L2_CID_EXPOSURE in the camera

2011-03-03 Thread Kim HeungJun
Hello everyone, I have a question about realization the camera brightness control (or exposure, because it's similar effect). I'm confused this similar two control - V4L2_CID_BRIGHTNESS and V4L2_CID_EXPOSURE. These control both express the brightness consequently. The CID can express the brigh

Re: [RFC PATCH RESEND v2 3/3] v4l2-ctrls: document the changes about auto focus mode

2011-03-03 Thread Kim HeungJun
Hi, 2011. 3. 3., 오후 10:24, Laurent Pinchart 작성: > Hi, > > On Thursday 03 March 2011 14:17:10 Kim HeungJun wrote: >> 2011. 3. 3., 오후 7:08, Laurent Pinchart 작성: >>> On Thursday 03 March 2011 03:16:34 Kim, HeungJun wrote: >>>> Document about the type changes a

Re: [RFC PATCH RESEND v2 3/3] v4l2-ctrls: document the changes about auto focus mode

2011-03-03 Thread Kim HeungJun
Hi, 2011. 3. 3., 오후 7:08, Laurent Pinchart 작성: > Hi, > > On Thursday 03 March 2011 03:16:34 Kim, HeungJun wrote: >> Document about the type changes and the enumeration of the auto focus >> control. >> >> Signed-off-by: Heungjun Kim >> Signed-off-by:

Re: [RFC] snapshot mode, flash capabilities and control

2011-03-02 Thread Kim, HeungJun
Hi Guennadi, I have another question about capture, not related with exact this topic. Dose the sensor which you use make EXIF information in itself while capturing?? If it is right, how to deliver EXIF information from v4l2(subdev or media driver) to userapplication? Regards, Heungjun Kim

[RFC PATCH RESEND v2 1/3] v4l2-ctrls: change the boolean type of V4L2_CID_FOCUS_AUTO to menu type

2011-03-02 Thread Kim, HeungJun
Support more modes of autofocus, it changes the type of V4L2_CID_FOCUS_AUTO from boolean to menu. And it includes 4 kinds of enumeration types: V4L2_FOCUS_AUTO, V4L2_FOCUS_MANUAL, V4L2_FOCUS_MACRO, V4L2_FOCUS_CONTINUOUS Signed-off-by: Heungjun Kim Signed-off-by: Kyungmin Park --- drivers/media

[RFC PATCH RESEND v2 0/3] v4l2-ctrls: add new focus mode

2011-03-02 Thread Kim, HeungJun
Hello, Agenda == I faced to the absence of the mode of v4l2 focus for a couple of years. While dealing with some few mobile camera sensors, the focus modes are needed more than the current v4l2 focus mode, e.g. a Macro & Continuou

[RFC PATCH RESEND v2 3/3] v4l2-ctrls: document the changes about auto focus mode

2011-03-02 Thread Kim, HeungJun
Document about the type changes and the enumeration of the auto focus control. Signed-off-by: Heungjun Kim Signed-off-by: Kyungmin Park --- Documentation/DocBook/v4l/controls.xml| 31 +--- Documentation/DocBook/v4l/videodev2.h.xml |6 + 2 files changed, 33

[RFC PATCH RESEND v2 2/3] v4l2-ctrls: modify uvc driver to use new menu type of V4L2_CID_FOCUS_AUTO

2011-03-02 Thread Kim, HeungJun
As following to change the boolean type of V4L2_CID_FOCUS_AUTO to menu type, this uvc is modified the usage of V4L2_CID_FOCUS_AUTO, maintaining v4l2 menu index. Signed-off-by: Heungjun Kim Signed-off-by: Kyungmin Park --- drivers/media/video/uvc/uvc_ctrl.c |9 - 1 files changed, 8 i

Re: [RFC PATCH RESEND v2 2/3] v4l2-ctrls: modify uvc driver to use new menu type of V4L2_CID_FOCUS_AUTO

2011-02-27 Thread Kim, HeungJun
Hi Laurent, 2011-02-25 오후 9:58, Laurent Pinchart 쓴 글: > Hi, > > On Friday 25 February 2011 13:46:01 Kim, HeungJun wrote: >> As following to change the boolean type of V4L2_CID_FOCUS_AUTO to menu >> type, this uvc is modified the usage of V4L2_CID_FOCUS_AUTO. >> >

[RFC PATCH RESEND v2 3/3] v4l2-ctrls: document the changes about auto focus mode

2011-02-25 Thread Kim, HeungJun
Document about the type changes and the enumeration of the auto focus control. Signed-off-by: Heungjun Kim Signed-off-by: Kyungmin Park --- Documentation/DocBook/v4l/controls.xml| 31 +--- Documentation/DocBook/v4l/videodev2.h.xml |6 + 2 files changed, 33

[RFC PATCH RESEND v2 2/3] v4l2-ctrls: modify uvc driver to use new menu type of V4L2_CID_FOCUS_AUTO

2011-02-25 Thread Kim, HeungJun
As following to change the boolean type of V4L2_CID_FOCUS_AUTO to menu type, this uvc is modified the usage of V4L2_CID_FOCUS_AUTO. Signed-off-by: Heungjun Kim Signed-off-by: Kyungmin Park --- drivers/media/video/uvc/uvc_ctrl.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-)

[RFC PATCH RESEND v2 1/3] v4l2-ctrls: change the boolean type of V4L2_CID_FOCUS_AUTO to menu type

2011-02-25 Thread Kim, HeungJun
Support more modes of autofocus, it changes the type of V4L2_CID_FOCUS_AUTO from boolean to menu. And it includes 4 kinds of enumeration types: V4L2_FOCUS_AUTO, V4L2_FOCUS_MANUAL, V4L2_FOCUS_MACRO, V4L2_FOCUS_CONTINUOUS Signed-off-by: Heungjun Kim Signed-off-by: Kyungmin Park --- drivers/media

[RFC PATCH RESEND v2 0/3] v4l2-ctrls: add new focus mode

2011-02-25 Thread Kim, HeungJun
Hello, Agenda == I faced to the absence of the mode of v4l2 focus for a couple of years. While dealing with some few morebile camera sensors, the focus modes are needed more than the current v4l2 focus mode, like a Macro & Continu

Re: [RFC PATCH v2 2/3] v4l2-ctrls: modify uvc driver to use new menu type of V4L2_CID_FOCUS_AUTO

2011-02-25 Thread Kim, HeungJun
2011-02-25 오후 7:25, Laurent Pinchart 쓴 글: > Hi, > > On Friday 25 February 2011 11:18:43 Kim, HeungJun wrote: >> 2011-02-25 오후 6:20, Laurent Pinchart 쓴 글: >>> On Friday 25 February 2011 07:21:32 Kim, HeungJun wrote: >>>> As following to change the boolean

Re: [RFC PATCH v2 1/3] v4l2-ctrls: change the boolean type of V4L2_CID_FOCUS_AUTO to menu type

2011-02-25 Thread Kim, HeungJun
2011-02-25 오후 7:28, Laurent Pinchart 쓴 글: > On Friday 25 February 2011 10:54:02 Hans Verkuil wrote: >> On Friday, February 25, 2011 10:21:59 Laurent Pinchart wrote: >>> On Friday 25 February 2011 07:21:27 Kim, HeungJun wrote: >>>> Support more modes of aut

Re: [RFC PATCH v2 1/3] v4l2-ctrls: change the boolean type of V4L2_CID_FOCUS_AUTO to menu type

2011-02-25 Thread Kim, HeungJun
Hans, and Laurent, 2011-02-25 오후 6:54, Hans Verkuil 쓴 글: > On Friday, February 25, 2011 10:21:59 Laurent Pinchart wrote: >> On Friday 25 February 2011 07:21:27 Kim, HeungJun wrote: >>> Support more modes of autofocus, it changes the type of V4L2_CID_FOCUS_AUTO >>> f

Re: [RFC PATCH v2 2/3] v4l2-ctrls: modify uvc driver to use new menu type of V4L2_CID_FOCUS_AUTO

2011-02-25 Thread Kim, HeungJun
Hi Laurent, 2011-02-25 오후 6:20, Laurent Pinchart 쓴 글: > On Friday 25 February 2011 07:21:32 Kim, HeungJun wrote: >> As following to change the boolean type of V4L2_CID_FOCUS_AUTO to menu >> type, this uvc is modified the usage of V4L2_CID_FOCUS_AUTO. >> >> Signed-off-

[RFC PATCH v2 2/3] v4l2-ctrls: modify uvc driver to use new menu type of V4L2_CID_FOCUS_AUTO

2011-02-24 Thread Kim, HeungJun
As following to change the boolean type of V4L2_CID_FOCUS_AUTO to menu type, this uvc is modified the usage of V4L2_CID_FOCUS_AUTO. Signed-off-by: Heungjun Kim Signed-off-by: Kyungmin Park --- drivers/media/video/uvc/uvc_ctrl.c | 13 ++--- 1 files changed, 10 insertions(+), 3 deletion

[RFC PATCH v2 1/3] v4l2-ctrls: change the boolean type of V4L2_CID_FOCUS_AUTO to menu type

2011-02-24 Thread Kim, HeungJun
Support more modes of autofocus, it changes the type of V4L2_CID_FOCUS_AUTO from boolean to menu. And it includes 4 kinds of enumeration types: V4L2_FOCUS_AUTO, V4L2_FOCUS_MANUAL, V4L2_FOCUS_MACRO, V4L2_FOCUS_CONTINUOUS Signed-off-by: Heungjun Kim Signed-off-by: Kyungmin Park --- drivers/media

[RFC PATCH v2 3/3] v4l2-crls: document the changes about auto focus mode

2011-02-24 Thread Kim, HeungJun
Document about the type changes and the enumeration of the auto focus control. Signed-off-by: Heungjun Kim Signed-off-by: Kyungmin Park --- Documentation/DocBook/v4l/controls.xml| 31 +--- Documentation/DocBook/v4l/videodev2.h.xml |6 + 2 files changed, 33

[RFC PATCH v2 0/3] v4l2-ctrls: add new focus mode

2011-02-24 Thread Kim, HeungJun
Hello, Agenda == I faced to the absence of the mode of v4l2 focus for a couple of years. While dealing with some few morebile camera sensors, the focus modes are needed more than the current v4l2 focus mode, like a Macro & Continu

Re: [RFC] snapshot mode, flash capabilities and control

2011-02-24 Thread Kim HeungJun
Hi Guennadi, I think, it's maybe a good suggestion for current trend! ( I'm not sure this express *trend* is right :)) But, the flash or strobe control connected with sensor can be controlled by user application directly, not in the sensor subdev device. For example, let's think that there is

Re: [RFC PATCH 0/2] v4l2-ctrls: add new focus mode

2011-02-24 Thread Kim, HeungJun
Hi Laurent, First, Thanks to reply. I commented below. 2011-02-24 오후 7:49, Laurent Pinchart 쓴 글: > Hi, > > On Thursday 24 February 2011 11:45:13 Kim, HeungJun wrote: >> Hello, >> >> I faced to the absence of the mode of v4l2 focus for a couple of years. >> Whi

Re: [RFC PATCH 1/2] v4l2-ctrls: change the boolean type of V4L2_CID_FOCUS_AUTO to menu type

2011-02-24 Thread Kim, HeungJun
Hi Hans, Thanks for reviewing, and I'll send another version including Docbook documents. Regards, Heungjun Kim 2011-02-24 오후 7:59, Hans Verkuil 쓴 글: > On Thursday, February 24, 2011 11:45:22 Kim, HeungJun wrote: >> For support more modes of autofocus, it chang

[RFC PATCH 2/2] v4l2-ctrls: modify uvc driver to use new menu type of V4L2_CID_FOCUS_AUTO

2011-02-24 Thread Kim, HeungJun
As following to change the boolean type of V4L2_CID_FOCUS_AUTO to menu type, this uvc is modified the usage of V4L2_CID_FOCUS_AUTO. Signed-off-by: Heungjun Kim Signed-off-by: Kyungmin Park --- The place using V4L2_CID_FOCUS_AUTO is one, in only this uvc driver here. So, only this driver affects

[RFC PATCH 2/2] v4l2-ctrls: modify uvc driver to use new menu type of V4L2_CID_FOCUS_AUTO

2011-02-24 Thread Kim, HeungJun
As following to change the boolean type of V4L2_CID_FOCUS_AUTO to menu type, this uvc is modified the usage of V4L2_CID_FOCUS_AUTO. Signed-off-by: Heungjun Kim Signed-off-by: Kyungmin Park --- The place using V4L2_CID_FOCUS_AUTO is one, in only this uvc driver here. So, only this driver affects

[RFC PATCH 1/2] v4l2-ctrls: change the boolean type of V4L2_CID_FOCUS_AUTO to menu type

2011-02-24 Thread Kim, HeungJun
For support more modes of autofocus, it changes the type of V4L2_CID_FOCUS_AUTO from boolean to menu. And it includes 4 kinds of enumeration types: V4L2_FOCUS_AUTO, V4L2_FOCUS_MANUAL, V4L2_FOCUS_MACRO, V4L2_FOCUS_CONTINUOUS Signed-off-by: Heungjun Kim Signed-off-by: Kyungmin Park --- drivers/m

[RFC PATCH 0/2] v4l2-ctrls: add new focus mode

2011-02-24 Thread Kim, HeungJun
Hello, I faced to the absence of the mode of v4l2 focus for a couple of years. While dealing with some few morebile camera sensors, the focus modes are needed more than the current v4l2 focus mode, like a Macro & Continuous mode. The M-5MOLS camera sensor I dealt with, also support these 2 modes.

Re: [PATCH v5] Add support for M5MO-LS 8 Mega Pixel camera

2011-02-23 Thread Kim, HeungJun
Hello, I hope this patch. I missed 1 file, sorry. I would submit another patch as the same name and same version. Thanks, Heungjun Kim 2011-02-23 오후 9:08, Kim, HeungJun 쓴 글: > Add I2C/V4L2 subdev driver for M-5MOLS camera sensor with integrated > image signal processor. > > S

[PATCH v5] Add support for M-5MOLS 8 Mega Pixel camera

2011-02-23 Thread Kim, HeungJun
Add I2C/V4L2 subdev driver for M-5MOLS camera sensor with integrated image signal processor. Signed-off-by: Heungjun Kim Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Hello, This is fifth version of M-5MOLS 8 Mega Pixel camera sensor. I missed one file at the just previo

[PATCH v5] Add support for M5MO-LS 8 Mega Pixel camera

2011-02-23 Thread Kim, HeungJun
Add I2C/V4L2 subdev driver for M-5MOLS camera sensor with integrated image signal processor. Signed-off-by: Heungjun Kim Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Hello, This is fifth version of M-5MOLS 8 Mega Pixel camera sensor. The fifth version changes are below

Re: [PATCH v4] Add support for M5MO-LS 8 Mega Pixel camera

2011-02-07 Thread Kim, HeungJun
I've checked runnig checkpatch.pl, but I've not seen this message before. And I re-check the patch sent now, but it's not. Probably, It's issue between git send-email and our mail server setting. I'll check once again, and resend. Thanks let me know. Regards Heungjun Kim 2011-02-08 오전 6:45, S

Re: [PATCH v3] Add support for M5MO-LS 8 Mega Pixel camera

2011-02-03 Thread Kim HeungJun
I would fix this things and resend as soon as possible. As I say once again, thanks to review it :) Regards, HeungJun Kim 2011. 2. 3., 오후 4:49, Hans Verkuil 작성: > Just some small points... > > On Tuesday, January 25, 2011 07:33:58 Heungjun Kim wrote: >> Add I2C/V4L2 subdev driver for M5MO-LS ca

Re: [PATCH v2] Add support for M5MO-LS 8 Mega Pixel camera

2011-01-23 Thread Kim HeungJun
let me now add some further comments. > > On 01/22/2011 11:12 AM, Kim, HeungJun wrote: >> Hello, >> >> This is second patch of I2C/V4L2 subdev driver for M5MOLS 8 Mega Pixel camera >> sensor using MIPI interface. >> >> The first version patch is here: >

Re: [RFC PATCH 3/3] v4l2-ctrls: update control framework documentation

2011-01-23 Thread Kim HeungJun
Hi Sylwester, It's my humble opinions. Just read plz :) 2011. 1. 23., 오후 8:08, Sylwester Nawrocki 작성: [snip] >> +Handling autogain/gain-type Controls with Auto Clusters >> +=== >> + >> +A common type of control cluster is one that handles 'au

Re: [RFC PATCH 03/12] mt9m001: convert to the control framework.

2011-01-22 Thread Kim HeungJun
Hello, I'm reading threads about the new v4l2_ctrl framework and If you don't mind I gotta tell you my humble opinion about testing result the new v4l2_ctrl framework subdev. I have actually similar curcumstance, with I2C subdev M5MOLS Fujitsu device which is just send the patch and S5PC210 board

[PATCH v2] Add support for M5MO-LS 8 Mega Pixel camera

2011-01-22 Thread Kim, HeungJun
Hello, This is second patch of I2C/V4L2 subdev driver for M5MOLS 8 Mega Pixel camera sensor using MIPI interface. The first version patch is here: http://www.spinics.net/lists/linux-media/msg26246.html And the first verion's issues was corrected referencing with quick reviews of Hans Verkuil and

Re: [PATCH] V4L/DVB: Add support for M5MOLS Mega Pixel camera

2010-12-16 Thread Kim, HeungJun
Hi Sylwester, Thanks for some comments. I'll reflects this comments for the next version patch. It's clear that there is a few things I missed. It's better to let's talk about this rest things, as Mr. Park said. But, I wanna remind one thing, and know your exact thiking. about MACROs. I re-comme

Re: [PATCH] V4L/DVB: Add support for M5MOLS Mega Pixel camera

2010-12-16 Thread Kim, HeungJun
Hi Hans, 2010-12-16 오후 4:27, Hans Verkuil 쓴 글: > Thanks for the reminder, I missed this patch. > > Review comments are below. > >> + >> +/* MACRO */ >> +#define e_check_w(fn, cat, byte, val, bitwidth) do {\ >> +int ret;\ >>

Re: [PATCH] V4L/DVB: Add support for M5MOLS Mega Pixel camera

2010-12-15 Thread Kim, HeungJun
Hi Hans, Any comments? Just ping. Thanks. Regards, HeungJun Kim 2010-12-10 오후 4:40, Kim, HeungJun 쓴 글: > This patch adds support for M5MOLS Mega Pixel Fujitsu camera sensor. > > -- > > Hello, > > This is an initial version of I2C/V4L2 subdev driver for M5MOLS camer

Re: What if add enumerations at the V4L2_FOCUS_MODE_AUTO?

2010-12-15 Thread Kim, HeungJun
2010-12-15 오후 4:57, Hans Verkuil 쓴 글: > On Wednesday, December 15, 2010 01:19:43 Laurent Pinchart wrote: >> Hi, >> >> (CC'ing linux-media this time, please discard the previous mail) >> >> On Tuesday 14 December 2010 12:27:32 Kim, HeungJun wrote: >>&g

Re: What if add enumerations at the V4L2_FOCUS_MODE_AUTO?

2010-12-14 Thread Kim, HeungJun
Hi Laurent, 2010-12-15 오전 9:19, Laurent Pinchart 쓴 글: > Hi, > > (CC'ing linux-media this time, please discard the previous mail) > > On Tuesday 14 December 2010 12:27:32 Kim, HeungJun wrote: >> Hi Laurent and Hans, >> >> I am working on V4L2 subdev for M5

Fwd: What if add enumerations at the V4L2_FOCUS_MODE_AUTO?

2010-12-14 Thread Kim, HeungJun
I miss linux-media email addres. So, I added it. Thanks. - Hi Laurent and Hans, I am working on V4L2 subdev for M5MOLS by Fujitsu. and I wanna listen your comments about Auto Focus mode of my ideas. the details is in the following link discussed at the

Re: I wonder the difference with mbus_pixelcode and v4l2_colorspace.

2010-12-10 Thread Kim, HeungJun
Thanks Guennadi, Actually, I have been confused between MC & MB. Including this, the link of Laurent is very helpful for me to make M5MOLS subdev driver. Regard, HeungJun Kim 2010-12-08 오후 4:23, Guennadi Liakhovetski 쓴 글: > Hi > > On Wed, 8 Dec 2010, Kim, HeungJun wrote: >

[PATCH] V4L/DVB: Add support for M5MOLS Mega Pixel camera

2010-12-09 Thread Kim, HeungJun
This patch adds support for M5MOLS Mega Pixel Fujitsu camera sensor. -- Hello, This is an initial version of I2C/V4L2 subdev driver for M5MOLS camera sensor using MIPI interface from Fujitsu. This sensor supports various resolution at various fps on Monitoring(as we know preview), Preview(camcor

I wonder the difference with mbus_pixelcode and v4l2_colorspace.

2010-12-07 Thread Kim, HeungJun
Hi Guennadi, I wonder the difference with pixelcode mediabus and v4l2_colorspace. In mt9m001.c subdev driver, the "format" seems be determined using the combination pixelcode & colorspace. In the previous kernel version(before using Media Controller), somtimes the pixelformat is used for definin

dose the subdev driver need pm features??

2010-12-07 Thread Kim, HeungJun
Hi Hans and everyone, I wonder if the subdev driver need pm features, like a power-off when suspend and power-on when resume. Commonly, It seems alright that the platform driver using this subdev driver must do such process. But, thinking deeply, irrelevantly at this dependency of the platform

When do I use v4l2_i2c_data structure or regular I2C driver method??

2010-11-30 Thread Kim, HeungJun
Hello Hans and everyone, The I2C V4L2 driver(sensor or lens motor controll chip or whatever) can be registerd with 2 method, I know. 1) using v4l2_i2c_data structure defined in the v4l2-i2c-drv.h 2) not using v4l2_i2c_data, just use i2c_add_driver() like registering method regular i2c driver.

RE: how can deal with the stream in only on-the-fly-output available HW block??

2010-09-15 Thread Kim, HeungJun
| DMA Link >+---+ using Interrupt | > recognized in H/W Block A | > | > > +--

RE: how can deal with the stream in only on-the-fly-output available HW block??

2010-09-14 Thread Kim, HeungJun
s and opinions. Regards, HeungJun, Kim > -Original Message- > From: Kim, HeungJun [mailto:riverful@samsung.com] > Sent: Tuesday, September 14, 2010 2:11 PM > To: 'linux-media@vger.kernel.org'; 'laurent.pinch...@ideasonboard.com'; > 'hverk...@xs4

RE: Linux V4L2 support dual stream video capture device

2010-09-14 Thread Kim, HeungJun
Hi Laurent, and Hans, I checked media frameworks, it was helpful for me, but It's not usable on my case. Because, before defining the device for using media frameworks, the device must be defined by some other device like FB, ALSA, DVB, etc. But, this H/W Block is no way to define using any other

how can deal with the stream in only on-the-fly-output available HW block??

2010-09-13 Thread Kim, HeungJun
-Original Message- From: Kim, HeungJun [mailto:riverful@samsung.com] Sent: Tuesday, September 14, 2010 2:02 PM To: 'laurent.pinch...@ideasonboard.com'; 'hverk...@xs4all.nl' Subject: RE: how can deal with the stream in only on-the-fly-output available HW

how can deal with the stream in only on-the-fly-output available HW block??

2010-09-13 Thread Kim, HeungJun
Hi all, What if some SoC's specific HW block supports only on-the-fly mode for stream output?? In this case, what is the suitable buf_type?? I'm faced with such problem. As explanation for my situation briefly, the processor I deal with now has 3 Multimedia H/W blocks, and the problem-one in th