if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA))
return -ENODEV;
- dec = kmalloc(sizeof(struct wis_tw2804), GFP_KERNEL);
+ dec = kzalloc(sizeof(struct wis_tw2804), GFP_KERNEL);
+
if (dec == NULL)
return -ENOMEM;
-
+ sd =&dec->sd;
+ dec->update = 1;
dec->channel = -1;
dec->norm = V4L2_STD_NTSC;
dec->brightness = 128;
dec->contrast = 128;
dec->saturation = 128;
dec->hue = 128;
- i2c_set_clientdata(client, dec);
+ dec->gain = 128;
+ dec->cr_gain = 128;
+ dec->b_balance = 122;
+ dec->r_balance = 122;
+ v4l2_i2c_subdev_init(sd, client,&tw2804_ops);
printk(KERN_DEBUG "wis-tw2804: creating TW2804 at address %d on %s\n",
client->addr, adapter->name);
@@ -319,9 +534,10 @@ static int wis_tw2804_probe(struct i2c_client *client,
static int wis_tw2804_remove(struct i2c_client *client)
{
- struct wis_tw2804 *dec = i2c_get_clientdata(client);
+ struct v4l2_subdev *sd = i2c_get_clientdata(client);
- kfree(dec);
+ v4l2_device_unregister_subdev(sd);
+ kfree(to_state(sd));
return 0;
}
Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/16/2012 09:06 AM, Justin P. Mattock wrote:
On 03/16/2012 08:58 AM, Greg KH wrote:
On Fri, Mar 16, 2012 at 04:45:03PM +0100, Jiri Kosina wrote:
On Fri, 16 Mar 2012, Justin P. Mattock wrote:
before I forget about this patch, what was the status of this one?
As previously announced
On 03/16/2012 08:58 AM, Greg KH wrote:
On Fri, Mar 16, 2012 at 04:45:03PM +0100, Jiri Kosina wrote:
On Fri, 16 Mar 2012, Justin P. Mattock wrote:
before I forget about this patch, what was the status of this one?
As previously announced multiple times, I am ignoring patches that go to
On 03/16/2012 08:45 AM, Jiri Kosina wrote:
On Fri, 16 Mar 2012, Justin P. Mattock wrote:
before I forget about this patch, what was the status of this one?
As previously announced multiple times, I am ignoring patches that go to
drivers/staging and letting Greg pick them up if he wants to
before I forget about this patch, what was the status of this one?
On 03/06/2012 06:55 AM, Justin P. Mattock wrote:
From: "Justin P. Mattock"
linux-next:
I like to spend some time reading code, in doing so I have found some typos in
some of the comments.
The patch below fixes w
From: "Justin P. Mattock"
linux-next:
I like to spend some time reading code, in doing so I have found some typos in
some of the comments.
The patch below fixes what I have found.
Signed-off-by: Justin P. Mattock
---
drivers/staging/media/Kconfig |2 +-
drive
On 03/05/2012 09:28 AM, David Santinoli wrote:
On Mon, Mar 05, 2012 at 07:49:26AM -0800, Justin P. Mattock wrote:
- The two functions bellow implements the newer ioctls
+ The two functions bellow implement the newer ioctls
There's still some room for improvement here. :-)
Cheers,
From: "Justin P. Mattock"
linux-next:
I like to spend some time reading code, in doing so I have found some typos in
some of the comments.
The patch below fixes what I have found.
Signed-off-by: Justin P. Mattock
---
drivers/staging/media/Kconfig |2 +-
drive
From: "Justin P. Mattock"
The below patch, changes clock_settting to clock_setting.
Note: This could be intentionally set this way from the beginning and/or is a
typo.
Signed-off-by: Justin P. Mattock
---
drivers/media/dvb/frontends/s5h1420.c | 12 ++--
1 files
The patch below removes an extra "l" in the word.
Signed-off-by: Justin P. Mattock
---
drivers/media/video/cx18/cx23418.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/cx18/cx23418.h
b/drivers/media/video/cx18/cx23418.h
index 7e4003
The patch below removes an extra "l" in the word.
Signed-off-by: Justin P. Mattock
---
drivers/media/video/cx231xx/cx231xx.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/cx231xx/cx231xx.h
b/drivers/media/video/cx231xx/cx231xx.h
ind
On 01/03/2011 07:01 AM, Jiri Kosina wrote:
On Fri, 31 Dec 2010, Mauro Carvalho Chehab wrote:
Em 30-12-2010 21:08, Justin P. Mattock escreveu:
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Matt
On 01/01/2011 01:09 AM, Dan Carpenter wrote:
On Fri, Dec 31, 2010 at 11:43:30PM -0800, Justin P. Mattock wrote:
On 12/31/2010 10:48 PM, Finn Thain wrote:
-/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE
means enable, other values are diable
On 12/31/2010 10:48 PM, Finn Thain wrote:
On Thu, 30 Dec 2010, Justin P. Mattock wrote:
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock
---
drivers/staging/rtl8187se/r8180_hw.h |2
On 12/31/2010 01:15 PM, Andy Walls wrote:
On Thu, 2010-12-30 at 15:08 -0800, Justin P. Mattock wrote:
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
^^
What, else could it be? The "diablo&qu
On 12/31/2010 09:41 AM, Dan Carpenter wrote:
On Fri, Dec 31, 2010 at 06:17:58AM -0800, Justin P. Mattock wrote:
Wrong: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.
Right: [PATCH 02/15] spi/dw_spi: Typo change diable to disable
regards,
dan carpenter
alright.. so
On 12/31/2010 01:11 AM, Dan Carpenter wrote:
On Thu, Dec 30, 2010 at 10:52:30PM -0800, Justin P. Mattock wrote:
On 12/30/2010 10:45 PM, Grant Likely wrote:
On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote:
The below patch fixes a typo "diable" to "disable"
On 12/31/2010 02:27 AM, Mauro Carvalho Chehab wrote:
Em 30-12-2010 21:08, Justin P. Mattock escreveu:
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock
Acked-by: Mauro Carvalho Chehab
PS.: N
On 12/30/2010 10:34 PM, Dan Carpenter wrote:
On Thu, Dec 30, 2010 at 03:08:04PM -0800, Justin P. Mattock wrote:
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock
---
drivers/spi/dw_spi.c
On 12/30/2010 10:45 PM, Grant Likely wrote:
On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote:
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock
applied, thanks.
g.
ahh.. t
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock
---
drivers/staging/rtl8187se/r8180_hw.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/rtl8187se/r
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock
---
arch/m68k/ifpsp060/src/fpsp.S |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/m68k/ifpsp060/src/fpsp.S b/ar
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock
---
drivers/spi/dw_spi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock
---
drivers/isdn/mISDN/dsp_cmx.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/mISDN/dsp_cmx.c
The below patch fixes a typo "diable" to "disable" and also fixes another typo
in a comment.
Please let me know if this is correct or not.
Signed-off-by: Justin P. Mattock
---
drivers/usb/host/fhci-hcd.c |4 ++--
drivers/usb/host/fhci-tds.c |4 ++--
2 files c
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock
---
drivers/net/wireless/iwlwifi/iwl-agn-ict.c |2 +-
drivers/net/wireless/iwlwifi/iwl-agn.c |4 ++--
drivers/net/wireles
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock
---
drivers/media/video/tvp7002.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/tvp7002.c b
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock
---
include/media/davinci/vpss.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/media/davinci/vpss.h b/i
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock
---
drivers/spi/dw_spi.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock
---
drivers/scsi/lpfc/lpfc_init.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_init.c
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock
---
drivers/usb/gadget/langwell_udc.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/langw
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock
---
drivers/media/video/cx18/cx23418.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/cx18/
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock
---
drivers/staging/comedi/drivers/das800.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/comedi
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock
---
drivers/staging/xgifb/vb_setmode.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/xgifb/vb_
The below patch fixes a typo "diable" to "disable". Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock
---
drivers/staging/vt6655/rf.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6655/rf.c b/dr
On 07/07/2010 11:40 PM, Jean-Francois Moine wrote:
On Wed, 7 Jul 2010 21:46:18 -0700
"Justin P. Mattock" wrote:
This fixes a warning I'm seeing when building:
CC [M] drivers/media/video/gspca/gspca.o
drivers/media/video/gspca/gspca.c: In function 'vidioc_reqbufs&#
This fixes a warning I'm seeing when building:
CC [M] drivers/media/video/gspca/gspca.o
drivers/media/video/gspca/gspca.c: In function 'vidioc_reqbufs':
drivers/media/video/gspca/gspca.c:1508:2: warning: case value '7' not in
enumerated type 'enum v4l2_memory'
On 06/21/2010 05:34 AM, Mauro Carvalho Chehab wrote:
Em Mon, 14 Jun 2010 22:48:34 -0700
"Justin P. Mattock" escreveu:
Resend due to a whitespace issue I created by mistake.
The below patch fixes a warning message create by gcc 4.6.0
It seems OK for me, but you shouldn't be s
e.c:548:20: warning: variable 'tun' set
but not used
Signed-off-by: Justin P. Mattock
Reviewed-By: Mauro Carvalho Chehab
---
drivers/media/common/tuners/tuner-simple.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/media/common/tuners/tuner-simpl
On 06/15/2010 11:53 AM, Sergey V. wrote:
On Tuesday 15 of June 2010 00:26:44 Justin P. Mattock wrote:
Im getting this warning when compiling:
CC drivers/char/tpm/tpm.o
drivers/char/tpm/tpm.c: In function 'tpm_gen_interrupt':
drivers/char/tpm/tpm.c:508:10: warning: variable &#
On 06/15/2010 04:38 AM, Jean Delvare wrote:
On Mon, 14 Jun 2010 13:26:47 -0700, Justin P. Mattock wrote:
Temporary fix until something is resolved
This is wrong by design, sorry. Warnings aren't blocking, and thus need
no "temporary fix". Such temporary fixes would be only hid
On 06/15/2010 04:43 AM, Jean Delvare wrote:
Hi Justin,
On Mon, 14 Jun 2010 14:06:12 -0700, Justin P. Mattock wrote:
On 06/14/2010 01:53 PM, Jean Delvare wrote:
Hi Justin,
On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote:
could be a right solution, could be wrong
here is the
On 06/15/2010 02:19 AM, Jean Delvare wrote:
On Tue, 15 Jun 2010 07:29:44 +0200, Peter Stuge wrote:
Justin P. Mattock wrote:
*baffled* Why did you think that would work? transmit_cmd()s signature
has 4 parameters.
I have no manual in front of me. Did a quick google, but came up with
(no hits
On 06/14/2010 10:29 PM, Peter Stuge wrote:
Justin P. Mattock wrote:
*baffled* Why did you think that would work? transmit_cmd()s signature
has 4 parameters.
I have no manual in front of me. Did a quick google, but came up with
(no hits) info on what that function does. grep showed too many
On 06/14/2010 10:16 PM, Mauro Carvalho Chehab wrote:
Em 14-06-2010 23:26, Justin P. Mattock escreveu:
not sure if this is correct or not for
fixing this warning:
CC [M] drivers/media/common/tuners/tuner-simple.o
drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv
On 06/14/2010 10:16 PM, Mauro Carvalho Chehab wrote:
Em 14-06-2010 23:26, Justin P. Mattock escreveu:
not sure if this is correct or not for
fixing this warning:
CC [M] drivers/media/common/tuners/tuner-simple.o
drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv
On 06/14/2010 08:49 PM, valdis.kletni...@vt.edu wrote:
On Mon, 14 Jun 2010 19:12:31 PDT, "Justin P. Mattock" said:
what I tried was this:
if (!rc)
printk("test"\n")
and everything looked good,
but as a soon as I changed
rc = t
On 06/14/2010 05:13 PM, valdis.kletni...@vt.edu wrote:
On Mon, 14 Jun 2010 13:26:44 PDT, "Justin P. Mattock" said:
Im getting this warning when compiling:
CC drivers/char/tpm/tpm.o
drivers/char/tpm/tpm.c: In function 'tpm_gen_interrupt':
drivers/char/tpm/tpm.c:508:1
On 06/14/2010 04:07 PM, Stefan Richter wrote:
On 14 Jun, Justin P. Mattock wrote:
On 06/14/2010 02:47 PM, Edward Shishkin wrote:
Whitespaces should be removed.
I recommend quilt package for managing patches:
"quilt refresh --strip-trailing-whitespace" is your friend..
o.k. I r
On 06/14/2010 02:47 PM, Edward Shishkin wrote:
Justin P. Mattock wrote:
On 06/14/2010 02:05 PM, Edward Shishkin wrote:
Justin P. Mattock wrote:
Not sure if this is correct or not.
the below patch gets rid of this warning message
produced by gcc 4.6.0
fs/reiserfs/stree.c: In function
On 06/14/2010 02:05 PM, Edward Shishkin wrote:
Justin P. Mattock wrote:
Not sure if this is correct or not.
the below patch gets rid of this warning message
produced by gcc 4.6.0
fs/reiserfs/stree.c: In function 'search_by_key':
fs/reiserfs/stree.c:602:6: warning
On 06/14/2010 01:48 PM, Nick Bowler wrote:
On 13:26 Mon 14 Jun , Justin P. Mattock wrote:
@@ -617,8 +616,7 @@ int search_by_key(struct super_block *sb, const struct
cpu_key *key,/* Key to s
pathrelse(search_path);
- right_neighbor_of_leaf_node = 0;
-
+
This
On 06/14/2010 01:53 PM, Jean Delvare wrote:
Hi Justin,
On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote:
could be a right solution, could be wrong
here is the warning:
CC drivers/i2c/i2c-core.o
drivers/i2c/i2c-core.c: In function 'i2c_register_adapter':
drive
correct.
Signed-off-by: Justin P. Mattock
---
drivers/bluetooth/hci_ldisc.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c
index 76a1abb..f693dfe 100644
--- a/drivers/bluetooth/hci_ldisc.c
+++ b/driv
he best solution.
Signed-off-by: Justin P. Mattock
---
drivers/char/tpm/tpm.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm.c
index 05ad4a1..3d685dc 100644
--- a/drivers/char/tpm/tpm.c
+++ b/drivers/char/tpm/
could be a right solution, could be wrong
here is the warning:
CC drivers/i2c/i2c-core.o
drivers/i2c/i2c-core.c: In function 'i2c_register_adapter':
drivers/i2c/i2c-core.c:757:15: warning: variable 'dummy' set but not used
Signed-off-by: Justin P. Mattock
---
dr
The below fixes this warning:
drivers/char/hpet.c: In function 'hpet_ioctl_common':
drivers/char/hpet.c:559:23: warning: variable 'hpet' set but not used
please have a look.
Signed-off-by: Justin P. Mattock
---
drivers/char/hpet.c |2 --
1 files changed, 0 insert
Not sure if this is correct or not.
the below patch gets rid of this warning message
produced by gcc 4.6.0
fs/reiserfs/stree.c: In function 'search_by_key':
fs/reiserfs/stree.c:602:6: warning: variable 'right_neighbor_of_leaf_node' set
but not used
Signed-off-by: Justin
Temporary fix until something is resolved
to fix the below warning:
CC [M] drivers/ieee1394/sbp2.o
drivers/ieee1394/sbp2.c: In function 'sbp2_parse_unit_directory':
drivers/ieee1394/sbp2.c:1353:6: warning: variable 'unit_characteristics' set
but not used
Signed-off-b
Probably not even a fix for this warning:
CC [M] drivers/gpu/drm/drm_gem.o
drivers/gpu/drm/drm_gem.c: In function 'drm_gem_handle_delete':
drivers/gpu/drm/drm_gem.c:188:21: warning: variable 'dev' set but not used
Signed-off-by: Justin P. Mattock
---
drivers/gpu/drm/dr
ot used
Signed-off-by: Justin P. Mattock
---
drivers/media/common/tuners/tuner-simple.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/media/common/tuners/tuner-simple.c
b/drivers/media/common/tuners/tuner-simple.c
index 8abbcc5..4465b99 100644
--- a/drivers
time.
In any case Thanks for taking the time,
and hopefully we can get fixes for all of
this mess generated by gcc..
Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordom
: 32595559--0010-8000-00389b71
Signed-off-by: Daniel Ritz
--
Regards,
Laurent Pinchart
I get weiredness whenever
I shutdown the machine and then boot.
If I boot, then reboot things work.
Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-med
63 matches
Mail list logo
