On line 259, bit it unsigned, so it can't be less than 0.
julia
-- Forwarded message --
Date: Sat, 4 May 2019 19:44:30 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH v5 5/5] [media] allegro: add SPS/PPS nal unit writer
CC: kbuild-.
The video_device structure is only copied into another structure, so
it can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/platform/rockchip/rga/rga.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform
The vb2_ops structures can be const as they are only stored in the ops
field of a vb2_queue structure and this field is const.
Done with the help of Coccinelle.
---
drivers/media/i2c/video-i2c.c |2 +-
drivers/usb/gadget/function/uvc_queue.c |2 +-
2 files changed, 2 insertion
The vb2_ops structure can be const as it is only stored in the ops
field of a vb2_queue structure and this field is const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/i2c/video-i2c.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
The fields of a v4l2_subdev_ops structure are all const, so the
structures that are stored there and are not used elsewhere can be
const as well.
Done with the help of Coccinelle.
---
drivers/media/i2c/ov7740.c|4 ++--
drivers/media/platform/vimc/vimc-sensor.c |2 +-
2 f
The fields of a v4l2_subdev_ops structure are all const, so the
structures that are stored there and are not used elsewhere can be
const as well.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/i2c/ov7740.c |4 ++--
1 file changed, 2 insertions(+), 2
The fields of a v4l2_subdev_ops structure are all const, so the
structures that are stored there and are not used elsewhere can be
const as well.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/platform/vimc/vimc-sensor.c |2 +-
1 file changed, 1 insertion
The v4l2_m2m_ops structure can be const as it is only passed to
v4l2_m2m_init whose parameter is const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/platform/rockchip/rga/rga.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
The v4l2_ctrl_ops structure is only passed as the second argument to
functions such as v4l2_ctrl_new_std for which the corresponding
parameter is const, so make the v4l2_ctrl_ops structure const as well.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/i2c
Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/platform/vicodec/vicodec-core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -p a/drivers/media/platform/vicodec/vicodec-core.c
b/drivers/media/platform/vicodec/vicodec-core.c
--- a/drivers/media/platform/vicodec
Make const v4l2_ctrl_ops structures that are only stored in a
const field or passed to a function having a const parameter.
Done with the help of Coccinelle.
---
drivers/media/i2c/ov5645.c|2 +-
drivers/media/platform/vicodec/vicodec-core.c |2 +-
2 files changed, 2
The dvb_frontend_ops structure is only copied into the ops field
of a dvb_frontend structure, so it can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/dvb-frontends/mxl5xx.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
From: kbuild test robot
drivers/dma-buf/udmabuf.c:167:6-12: inconsistent IS_ERR and PTR_ERR on line 168.
PTR_ERR should access the value just tested by IS_ERR
Semantic patch information:
There can be false positives in the patch case, where it is the call to
IS_ERR that is wrong.
Generated
On Fri, 11 May 2018, Christophe JAILLET wrote:
> The use of 'fail1' and 'fail2' is not correct. Reorder these calls to
> branch at the right place of the error handling path.
Maybe it would be good to improve the names at the same time?
julia
>
> S
pvrusb2-video-v4l.h only declares pvr2_saa7115_subdev_update and
includes pvrusb2-hdw-internal.h. pvrusb2-cx2584x-v4l.c does not
use pvr2_saa7115_subdev_update and it explicitly includes
pvrusb2-hdw-internal.h.
Signed-off-by: Julia Lawall
---
v2: Make the subject line a bit less generic
pvrusb2-video-v4l.h only declares pvr2_saa7115_subdev_update and
includes pvrusb2-hdw-internal.h. pvrusb2-cx2584x-v4l.c does not
use pvr2_saa7115_subdev_update and it explicitly includes
pvrusb2-hdw-internal.h.
Signed-off-by: Julia Lawall
---
drivers/media/usb/pvrusb2/pvrusb2-cx2584x-v4l.c
before any function.
I don't think that Coccinelle could figure out how to split one loop
into
two as done here, unless that specific pattern is very common. I guess
that the split is to add the flush_workqueue, and is not the main goal?
julia
-Kees
When working on the UVC driver -
On Sun, 4 Mar 2018, Arushi Singhal wrote:
> Spellcheck the comments.
> Remove the repeated, consecutive words with single word.
For the series:
Acked-by: Julia Lawall
But please look out for things to change in the code, not just in the
comments.
julia
>
> Arushi Singhal (3):
On Sun, 4 Mar 2018, Arushi Singhal wrote:
> Remove unnecessary semicolon found using semicolon.cocci Coccinelle
> script.
>
> Signed-off-by: Arushi Singhal
Acked-by: Julia Lawall
> ---
> .../media/atomisp/pci/atomisp2/css2400/runtime/frame/src/frame.c| 2
> +-
;ve got rules to protect against reporting
it at the moment. It may end up with false positives.
> drivers/usb/gadget/udc/goku_udc.h:#define INT_EPnNAK(n) (0x00100 < (n))
> /* 0 < n < 4 */
This is indeed harder, because one has to look at the usage site.
julia
On Tue, 6 Feb 2018, Wolfram Sang wrote:
> Hi Julia,
>
> > and got the results below. I can make a version for the kernel shortly.
>
> It should probably take care of right-shifting, too?
I did that too but got no results. Perhaps right shifting constants is
pretty uncommo
On Tue, 6 Feb 2018, Dan Carpenter wrote:
> On Tue, Feb 06, 2018 at 02:15:51PM +0100, Julia Lawall wrote:
> >
> >
> > On Tue, 6 Feb 2018, Dan Carpenter wrote:
> >
> > > On Mon, Feb 05, 2018 at 09:09:57PM +0100, Wolfram Sang wrote:
> > > > In on
sue with a low prio.
> >
>
> Most of these are inside macros so it makes it complicated for Smatch
> to warn about them. It might be easier in Coccinelle. Julia the bugs
> look like this:
>
> - reissue_mask |= 0x < 4;
> + reissue_ma
On Tue, 2 Jan 2018, Bart Van Assche wrote:
> On Tue, 2018-01-02 at 15:00 +0100, Julia Lawall wrote:
> > On Tue, 2 Jan 2018, Bob Peterson wrote:
> > > - Original Message -
> > > > - Original Message -
> > > >
> > > Still, the G
On Tue, 2 Jan 2018, Bob Peterson wrote:
> - Original Message -
> | - Original Message -
> | | Drop newline at the end of a message string when the printing function
> adds
> | | a newline.
> |
> | Hi Julia,
> |
> | NACK.
> |
> | As much as it&#
On Tue, 2 Jan 2018, Bob Peterson wrote:
> - Original Message -
> | Drop newline at the end of a message string when the printing function adds
> | a newline.
>
> Hi Julia,
>
> NACK.
>
> As much as it's a pain when searching the source code for outpu
On Tue, 2 Jan 2018, Dan Carpenter wrote:
> On Wed, Dec 20, 2017 at 11:30:01AM +0100, Julia Lawall wrote:
> >
> >
> > On Wed, 20 Dec 2017, Dan Carpenter wrote:
> >
> > > On Tue, Dec 19, 2017 at 10:59:52PM +0200, Andy Shevchenko wrote:
> > > > @@
Drop newline at the end of a message string when the printing function adds
a newline.
The complete semantic patch that detects this issue is as shown below
(http://coccinelle.lip6.fr/). It works in two phases - the first phase
counts how many uses of a function involve a newline and how many don
pvr2_trace prints a newline at the end of the message string, so the
message string does not need to include a newline explicitly. Done
using Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/usb/pvrusb2/pvrusb2-hdw.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
r is it a particular function that is of concern? Or
would it be that every function call that has error handling somewhere
should have error handling everywhere? Or is it related to what seems to
be the problem in the above code that err is initialized but nothing
happens to it?
julia
ree to repost, but only if you organize the patch as either fixing
> > the same type of
> > issue for a whole subdirectory (media/usb, media/pci, etc)
Just for the record, while this may work for media, it won't work for all
subsystems. One will quickly get a complaint that the big
int bdisp_g_fmt(struct file *file, void *fh,
> struct v4l2_format *f)
> return PTR_ERR(frame);
> }
>
> - pix = &f->fmt.pix;
Why not keep this one and drop the first one? Maybe it would be nice to
keep all the initializations related to pix together?
julia
> p
e_alloc_node\|kmalloc_node\|kzalloc_node\|devm_kzalloc\)(...)
> ...when != p
>
> if (
> - p == NULL
> + !p
> ) s
> else s1
>
> Signed-off-by: Aishwarya Pant
Acked-by: Julia Lawall
>
> --
> Changes in atomisp2/css2400/sh_css.c were done by hand, the above script
> wa
gt; ...
> }
> - T
> ;
>
> @r3@
> type r1.T;
> identifier p.T1;
> @@
>
> - T
> + struct T1
>
> Signed-off-by: Srishti Sharma
Acked-by: Julia Lawall
> ---
> .../media/atomisp/pci/atomisp2/css2400/runtime/spctrl/src/spctrl.c | 6
> +++---
> 1 f
Hello,
It seems that an unlock is missing on line 764.
julia
-- Forwarded message --
Date: Wed, 4 Oct 2017 05:59:09 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH] [media] ov5645: I2C address change
CC: kbuild-...@01.org
In-Reply-To
e the label name?
>
> I find the suggested variant a bi better.
>
>
> > They are both equally uninformative.
>
> Which identifier would you find appropriate there?
error was fine.
julia
> + goto report_failure;
> +
> return 0;
> -error:
> +
> +report_failure:
> + PERR("Set packet size: set interface error");
> return -EBUSY;
> }
Why change the label name? They are both equally uninformative.
julia
e;
> -return ret;
>
> Signed-off-by: Srishti Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm
e;
> -return ret;
>
> Signed-off-by: Srishti Sharma
Acked-by: Julia Lawall
> ---
> drivers/staging/media/atomisp/i2c/ov5693/ov5693.c | 11 ++-
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/i2c/ov5693/ov5693
turn;
>
> mutex_lock(&iss->iss_mutex);
> - BUG_ON(iss->ref_count == 0);
> + WARN_ON(iss->ref_count == 0);
> if (--iss->ref_count == 0) {
Won't this then infinite loop?
julia
> iss_disable_interrupts(iss);
> /*
These structures are only copied into other structures, so
they can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
v2: fix typo in the commit message
drivers/media/pci/ddbridge/ddbridge-core.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
These structures are only copied into other stuructures, so
they can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/pci/ddbridge/ddbridge-core.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/pci/ddbridge
This v4l2_clk_ops structure is only passed as the first argument of
v4l2_clk_register, which is const, so the v4l2_clk_ops structure can
also be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/platform/pxa_camera.c |2 +-
1 file changed, 1 insertion
This v4l2_audio structure is only copied into other structures,
so it can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/pci/ttpci/av7110_v4l.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/ttpci
On Tue, 8 Aug 2017, Laurent Pinchart wrote:
> Hi Julia,
>
> Thank you for the patch.
>
> On Tuesday 08 Aug 2017 12:58:32 Julia Lawall wrote:
> > uvc_subdev_ops is only passed as the second argument of
> > v4l2_subdev_init, which is const, so uvc_subdev_ops can be
>
be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/i2c/mt9t001.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/mt9t001.c b/drivers/media/i2c/mt9t001.c
index 842017f..9d981d9 100644
--- a/drivers/media/i2c
uvc_subdev_ops is only passed as the second argument of
v4l2_subdev_init, which is const, so uvc_subdev_ops can be
const as well.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/usb/uvc/uvc_entity.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
These structures are both stored in fields of v4l2_subdev_ops
structures, all of which are const, so these structures can be
const as well.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/staging/media/atomisp/i2c/ap1302.c |2 +-
drivers/staging/media/atomisp
The structures of type v4l2_subdev_ops are only passed as the second
argument of v4l2_subdev_init or as the third argument of
v4l2_i2c_subdev_init, both of which are const. The structures of type
v4l2_subdev_core_ops, v4l2_subdev_pad_ops, v4l2_subdev_sensor_ops,
v4l2_subdev_video_ops are only stor
These structures are all only stored in fields of v4l2_subdev_ops
structures, all of which are const, so these structures can be const
as well.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/platform/vimc/vimc-debayer.c |2 +-
drivers/media/platform/vimc
The v4l2_subdev_ops structures are only passed as the second
argument of v4l2_subdev_init, which is const, so the
v4l2_subdev_ops structures can be const as well.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/platform/exynos4-is/fimc-isp.c |2 +-
drivers
be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/i2c/mt9m111.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c
index 72e71b7..99b992e 100644
--- a/drivers/media/i2c
The structure vs6624_default_fmt is only copied into another
structure field, so it can be const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/i2c/vs6624.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/vs6624.c b
@p = { ... };
@ok1@
identifier r.i;
position p;
@@
v4l2_m2m_init(&i@p)
@bad@
position p != {r.p,ok1.p};
identifier r.i;
struct v4l2_m2m_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct v4l2_m2m_ops i = { ... };
//
Signed-off-by: Julia La
@p = { ... };
@ok1@
identifier r.i;
position p;
@@
v4l2_m2m_init(&i@p)
@bad@
position p != {r.p,ok1.p};
identifier r.i;
struct v4l2_m2m_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct v4l2_m2m_ops i = { ... };
//
Signed-off-by: Julia La
@p = { ... };
@ok1@
identifier r.i;
position p;
@@
v4l2_m2m_init(&i@p)
@bad@
position p != {r.p,ok1.p};
identifier r.i;
struct v4l2_m2m_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct v4l2_m2m_ops i = { ... };
//
Signed-off-by: Julia La
@p = { ... };
@ok1@
identifier r.i;
position p;
@@
v4l2_m2m_init(&i@p)
@bad@
position p != {r.p,ok1.p};
identifier r.i;
struct v4l2_m2m_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct v4l2_m2m_ops i = { ... };
//
Signed-off-by: Julia La
@p = { ... };
@ok1@
identifier r.i;
position p;
@@
v4l2_m2m_init(&i@p)
@bad@
position p != {r.p,ok1.p};
identifier r.i;
struct v4l2_m2m_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct v4l2_m2m_ops i = { ... };
//
Signed-off-by: Julia La
The v4l2_m2m_ops structures are only passed as the only
argument to v4l2_m2m_init, which is declared as const.
Thus the v4l2_m2m_ops structures themselves can be const.
Done with the help of Coccinelle.
---
drivers/media/platform/exynos-gsc/gsc-m2m.c |2 +-
drivers/media/platform/exynos
@p = { ... };
@ok1@
identifier r.i;
position p;
@@
v4l2_m2m_init(&i@p)
@bad@
position p != {r.p,ok1.p};
identifier r.i;
struct v4l2_m2m_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct v4l2_m2m_ops i = { ... };
//
Signed-off-by: Julia La
@p = { ... };
@ok1@
identifier r.i;
position p;
@@
v4l2_m2m_init(&i@p)
@bad@
position p != {r.p,ok1.p};
identifier r.i;
struct v4l2_m2m_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct v4l2_m2m_ops i = { ... };
//
Signed-off-by: Julia La
@p = { ... };
@ok1@
identifier r.i;
position p;
@@
v4l2_m2m_init(&i@p)
@bad@
position p != {r.p,ok1.p};
identifier r.i;
struct v4l2_m2m_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct v4l2_m2m_ops i = { ... };
//
Signed-off-by: Julia La
@p = { ... };
@ok1@
identifier r.i;
position p;
@@
v4l2_m2m_init(&i@p)
@bad@
position p != {r.p,ok1.p};
identifier r.i;
struct v4l2_m2m_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct v4l2_m2m_ops i = { ... };
//
Signed-off-by: Julia La
@p = { ... };
@ok1@
identifier r.i;
position p;
@@
v4l2_m2m_init(&i@p)
@bad@
position p != {r.p,ok1.p};
identifier r.i;
struct v4l2_m2m_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct v4l2_m2m_ops i = { ... };
//
Signed-off-by: Julia La
@p = { ... };
@ok1@
identifier r.i;
position p;
@@
v4l2_m2m_init(&i@p)
@bad@
position p != {r.p,ok1.p};
identifier r.i;
struct v4l2_m2m_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct v4l2_m2m_ops i = { ... };
//
Signed-off-by: Julia La
@p = { ... };
@ok1@
identifier r.i;
position p;
@@
v4l2_m2m_init(&i@p)
@bad@
position p != {r.p,ok1.p};
identifier r.i;
struct v4l2_m2m_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct v4l2_m2m_ops i = { ... };
//
Signed-off-by: Julia La
= { ... };
@ok@
identifier r.i;
struct vb2_queue e;
position p;
@@
e.ops = &i@p;
@bad@
position p != {r.p,ok.p};
identifier r.i;
struct vb2_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct vb2_ops i = { ... };
//
Signed-off-by: Julia La
These vb2_ops structures are only stored in the ops field of a
vb2_queue structure, which is declared as const. Thus the vb2_ops
structures themselves can be const.
Done with the help of Coccinelle.
---
drivers/media/platform/blackfin/bfin_capture.c|2 +-
drivers/media/plat
= { ... };
@ok@
identifier r.i;
struct vb2_queue e;
position p;
@@
e.ops = &i@p;
@bad@
position p != {r.p,ok.p};
identifier r.i;
struct vb2_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct vb2_ops i = { ... };
//
Signed-off-by: Julia La
= { ... };
@ok@
identifier r.i;
struct vb2_queue e;
position p;
@@
e.ops = &i@p;
@bad@
position p != {r.p,ok.p};
identifier r.i;
struct vb2_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct vb2_ops i = { ... };
//
Signed-off-by: Julia La
= { ... };
@ok@
identifier r.i;
struct vb2_queue e;
position p;
@@
e.ops = &i@p;
@bad@
position p != {r.p,ok.p};
identifier r.i;
struct vb2_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct vb2_ops i = { ... };
//
Signed-off-by: Julia La
= { ... };
@ok@
identifier r.i;
struct vb2_queue e;
position p;
@@
e.ops = &i@p;
@bad@
position p != {r.p,ok.p};
identifier r.i;
struct vb2_ops e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct vb2_ops i = { ... };
//
Signed-off-by: Julia La
r.i;
@@
static
+const
struct videobuf_queue_ops i = { ... };
//
Signed-off-by: Julia Lawall
---
drivers/media/pci/cx18/cx18-streams.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/cx18/cx18-streams.c
b/drivers/media/pci/cx18/cx18-streams.c
index 3c45
r.i;
@@
static
+const
struct videobuf_queue_ops i = { ... };
//
Signed-off-by: Julia Lawall
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_fops.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_fops.c
b/drivers/sta
These videobuf_queue_ops structures are only passed as the second
argument to videobuf_queue_vmalloc_init, which is declared as const.
Thus the videobuf_queue_ops structures themselves can be const.
Done with the help of Coccinelle.
---
drivers/media/pci/cx18/cx18-streams.c
also const.
Signed-off-by: Julia Lawall
---
drivers/media/usb/cx231xx/cx231xx-417.c |2 +-
drivers/media/usb/cx231xx/cx231xx-video.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/usb/cx231xx/cx231xx-417.c
b/drivers/media/usb/cx231xx/cx231xx-417.c
i
r.i;
@@
static
+const
struct videobuf_queue_ops i = { ... };
//
Signed-off-by: Julia Lawall
---
drivers/media/usb/tm6000/tm6000-video.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/tm6000/tm6000-video.c
b/drivers/media/usb/tm6000/tm6000-video.c
index cec
r.i;
@@
static
+const
struct videobuf_queue_ops i = { ... };
//
Signed-off-by: Julia Lawall
---
drivers/media/usb/zr364xx/zr364xx.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/zr364xx/zr364xx.c
b/drivers/media/usb/zr364xx/zr364xx.c
index efdcd5b..24d
The data protected is video_out2 and the lock that is released is
&video_out2->dma_queue_lock, so it seems that that lock should be
taken as well.
Signed-off-by: Julia Lawall
---
drivers/staging/media/davinci_vpfe/dm365_resizer.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-
vpbe_dev_ops is only copied into the ops field at the end of a vpbe_device
structure, so it can be const.
Signed-off-by: Julia Lawall
---
Does the ops field need to be inlined into the vpbe_device structure?
drivers/media/platform/davinci/vpbe.c |2 +-
1 file changed, 1 insertion(+), 1
Is a lock release needed before line 1185? Is the !enable in line 1189
correct? If the code is correct as is, perhaps it could be good to add
some comments.
julia
-- Forwarded message --
Date: Mon, 24 Jul 2017 12:55:30 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia
There is a double free on data if the goto is taken on line 1815.
julia
-- Forwarded message --
Date: Sat, 15 Jul 2017 21:07:03 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH 1/3] [media] uvcvideo: variable size controls
CC: kbuild-...@01
Please check on this (line 199).
julia
-- Forwarded message --
Date: Thu, 6 Jul 2017 13:58:29 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver
Hi Maxime,
[auto build test WARNING on linuxtv
Braces are probably missing aroud lines 1618-1620.
julia
-- Forwarded message --
Date: Sun, 25 Jun 2017 23:06:03 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH v1 5/6] [media] ov9650: add multiple variant support
Hi Hugues,
[auto build
It seems that some of the constants on lines 3127 and on are the same as
the ones on lines 3134 and on.
julia
-- Forwarded message --
Date: Wed, 21 Jun 2017 18:20:03 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [ragnatech:media-tree 1869/1907
BRDNOGEN is duplicate in the #defined on line 46.
julia
-- Forwarded message --
Date: Mon, 29 May 2017 19:16:10 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH v4 2/2] cec: add STM32 cec driver
CC: kbuild-...@01.org
In-Reply-To: <1496046
It looks like &udev->cmdr_lock should be released at line 512 if it has
not been released otherwise. The lock was taken at line 438.
julia
-- Forwarded message --
Date: Fri, 14 Apr 2017 22:21:44 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subj
On Tue, 11 Apr 2017, Sylwester Nawrocki wrote:
> Hi,
>
> On 04/03/2017 08:17 AM, Smitha T Murthy wrote:
> > On Mon, 2017-04-03 at 08:00 +0200, Julia Lawall wrote:
> > > See line 2101
> > >
> > > julia
> > >
> > Thank you for bringing i
See line 2101
julia
- Forwarded message --
Date: Mon, 3 Apr 2017 05:04:39 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [Patch v3 10/11] [media] s5p-mfc: Add support for HEVC encoder
Hi Smitha,
[auto build test WARNING on linuxtv-media/master
There should be a spac after every colon in the subject. Please pay
attention to these small details, so you don't have to send the same patch
over and over.
julia
On Fri, 24 Mar 2017, Arushi Singhal wrote:
> This patch replaces bit shifting on 1 with the BIT(x) macro.
> This wa
Greg I have cc'd all the developers which script get_maintainer.pl showed:
>
> $ git show HEAD | perl scripts/get_maintainer.pl --separator ,
> --nokeywords --nogit --nogit-fallback --norolestats
Sometimes people do a lot of work on something without being the
maintaine
et;
> >
> > - ret = mt9m114_write_reg_array(client, mt9m114_common, PRE_POLLING);
> > - if (ret)
> > - return ret;
> > - return ret;
> > + return mt9m114_write_reg_array(client, mt9m114_common, PRE_POLLING);
> > }
>
>
> any use for "client" ?
I guess the code would be on two lines in any case. It looks like a nice
decomposition as is.
julia
;
> >> WARNING: Unnecessary typecast of c90 int constant
> >>
> >> Signed-off-by: simran singhal
> >
> > Which tree are these patches based on?
> Can you please explain what's the problem with this patch. And
> please elaborate your question.
It i
On Fri, 3 Mar 2017, simran singhal wrote:
> The sematic patch used for this is:
> @@
> identifier i;
> constant c;
> @@
> return
> - (
> \(i\|-i\|i(...)\|c\)
> - )
> ;
>
> Signed-off-by: simran singhal
Acked-by: Julia Lawall
> ---
> .../m
To put it another way, tools can figure out what is missing if they have
access to good exmples of what should be there.
To be clear, I can see both points of view.
julia
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message
d fast rule, but I think it is something to take
into account.
julia
>
> regards,
> dan carpenter
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info a
does the return value of
PTR_ERR(esram), which will be 0 on a NULL result. But I wondered if it
was intended to have a call to devm_ioremap_resource between the
platform_get_resource and the IS_ERR_OR_NULL test (which should be just
IS_ERR; likewise for the call just above)?
thanks,
julia
--
To un
needed, then a memset 0
would need to replace the calls to kzfree.
There are some other minor issues with the patch. In the subject line,
there is normally a space after each :. There is a spelling mistake in
the commit message. In the commit message there should be on
t; > + dev->isoc_ctl.urb =
> > + kcalloc(num_bufs, sizeof(*dev->isoc_ctl.urb), GFP_KERNEL);
>
>
> That's worse :)
>
> The usual Kernel style is:
>
> var = foo(bar1,
> bar2,
> bar3
On Tue, 11 Oct 2016, Mauro Carvalho Chehab wrote:
> Em Tue, 11 Oct 2016 15:16:24 +0200 (CEST)
> Julia Lawall escreveu:
>
> > On Tue, 11 Oct 2016, Julia Lawall wrote:
> >
> > > It looks like a lock may be needed before line 174.
> >
> > Sorry, an
1 - 100 of 334 matches
Mail list logo
