On Mon, 4 Dec 2017 22:05:41 +
Mark Brown wrote:
> On Sun, Dec 03, 2017 at 08:43:47PM +0100, Wolfram Sang wrote:
>
> > > It's a bit different in that it's much more likely that a SPI controller
> > > will actually do DMA than an I2C one since the speeds are higher and
> > > there's frequent a
ons to paths where the i2c
master can't take advantage. Not ideal, but perhaps not worth the hassle
of working around it?
It's only for the block calls I guess so not that major an issue.
Reviewed-by: Jonathan Cameron
> ---
> drive
On Sat, 4 Nov 2017 21:20:05 +0100
Wolfram Sang wrote:
> Use the new helper to create variants of i2c_master_{send|recv} which
> mark their buffers as DMA safe.
>
> Signed-off-by: Wolfram Sang
Can't really argue with such a simple patch ;)
Acked-by: Jonathan Cameron
>
way.
>
> Signed-off-by: Wolfram Sang
Reviewed-by: Jonathan Cameron
> ---
> drivers/i2c/i2c-core-base.c | 64
> +
> include/linux/i2c.h | 34 +---
> 2 files changed, 48 insertions(+), 50 deletions(-)
>
On Thu, 21 Sep 2017 16:15:28 +0200
Wolfram Sang wrote:
> > > > +/**
> > > > + * i2c_release_dma_safe_msg_buf - release DMA safe buffer and sync
> > > > with i2c_msg
> > > > + * @msg: the message to be synced with
> > > > + * @buf: the buffer obtained from i2c_get_dma_safe_msg_buf(). May be
> >
On Wed, 20 Sep 2017 20:59:56 +0200
Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang
Makes sense as do the other drivers.
Feel free to add
Reviewed-by: Jonathan Cameron
to all of them (though they hardly took a lot of reviewing given how simple
the patches were :)
> ---
> driver
suggestion inline. I don't really care either way as
what you had is perfectly comprehensible.
Reviewed-by: Jonathan Cameron
>
> > ---
> > Documentation/i2c/DMA-considerations | 58
> >
> > 1 file changed, 58 insertions(+)
&
On Thu, 21 Sep 2017 14:59:22 +0100
Jonathan Cameron wrote:
> On Wed, 20 Sep 2017 20:59:52 +0200
> Wolfram Sang wrote:
>
> > One helper checks if DMA is suitable and optionally creates a bounce
> > buffer, if not. The other function returns the bounce buffer and makes
fram Sang
One minor suggestion for wording. Otherwise looks good to me.
Reviewed-by: Jonathan Cameron
> ---
> drivers/i2c/i2c-core-base.c | 45
> +
> include/linux/i2c.h | 3 +++
> 2 files changed, 48 insertions(+)
>
&g
On Thu, 17 Aug 2017 16:14:43 +0200
Wolfram Sang wrote:
> So, after revisiting old mail threads, taking part in a similar discussion on
> the USB list, and implementing a not-convincing solution before, here is what
> I
> cooked up to document and ease DMA handling for I2C within Linux. Please ha
On Tue, 18 Jul 2017 12:23:37 +0200
Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang
Is this material not perhaps better placed in the sphinx docs?
Up to you of course as your subsystem ;)
Text is good though.
Acked-by: Jonathan Cameron
> ---
> Changes since v2:
>
> * docume
On Tue, 18 Jul 2017 12:23:36 +0200
Wolfram Sang wrote:
> One helper checks if DMA is suitable and optionally creates a bounce
> buffer, if not. The other function returns the bounce buffer and makes
> sure the data is properly copied back to the message.
>
> Signed-off-by: Wolfram Sang
My knowl
On Fri, 14 Jul 2017 11:31:03 +0200
Arnd Bergmann wrote:
> gcc-7 points out an older regression:
>
> drivers/staging/iio/resolver/ad2s1210.c: In function 'ad2s1210_read_raw':
> drivers/staging/iio/resolver/ad2s1210.c:515:42: error: '<<' in boolean
> context, did you mean '<' ? [-Werror=int-in-bo
On 03/04/17 18:56, Linus Walleij wrote:
> On Mon, Apr 3, 2017 at 10:38 AM, Peter Rosin wrote:
>
>> i2c_mux_add_adapter already logs a message on failure.
>>
>> Signed-off-by: Peter Rosin
>
> Reviewed-by: Linus Walleij
Applied to the togreg branch of iio.git.
Can't see any reason not to split
On 11/11/16 19:49, Arnd Bergmann wrote:
> On Friday, November 11, 2016 9:13:00 AM CET Linus Torvalds wrote:
>> On Thu, Nov 10, 2016 at 8:44 AM, Arnd Bergmann wrote:
>>>
>>> Please merge these directly if you are happy with the result.
>>
>> I will take this.
>
> Thanks a lot!
>
>> I do see two
On 03/04/16 12:51, Peter Rosin wrote:
> On 2016-04-03 12:51, Jonathan Cameron wrote:
>> On 03/04/16 09:52, Peter Rosin wrote:
>>> From: Peter Rosin
>>>
>>> Allocate an explicit i2c mux core to handle parent and child adapters
>>> etc. Update the sele
On 03/04/16 09:52, Peter Rosin wrote:
> From: Peter Rosin
>
> Signed-off-by: Peter Rosin
Very nice, one typo that I could see.
> ---
> Documentation/i2c/i2c-topology | 370
> +
> MAINTAINERS| 1 +
> 2 files changed, 371 insertions(
fangled i2c mux
> lock where it previously grabbed the i2c adapter lock).
>
> Signed-off-by: Peter Rosin
This one obviously wants a ack from Adriana or Daniel in addition to mine.
I'm more than happy for these to go through the i2c tree btw.
Acked-by: Jonathan Cameron
> ---
&
hange so
if no one is currently setup to test it, then don't let it hold up the
series too long!
Acked-by: Jonathan Cameron
Jonathan
> ---
> drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c | 2 +-
> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 1 -
>
On 02/03/16 17:29, Wolfram Sang wrote:
> On Fri, Jan 08, 2016 at 04:04:48PM +0100, Peter Rosin wrote:
>> From: Peter Rosin
>>
>> Hi!
>>
>> [doing a v3 even if there is no "big picture" feedback yet, but
>> previous versions has bugs that make them harder to test than
>> needed, and testing is ve
On 26 October 2015 08:21:07 GMT+00:00, Jean-Michel Hautbois
wrote:
>Hi Lucas,
>
>2015-10-26 8:53 GMT+01:00 Daniel Baluta :
>> Hi Lucas,
>>
>> Adding linux-iio and linux-media, I hope you don't mind.
>>
>> On 10/23/2015 06:58 PM, Lucas Magasweran wrote:
>>>
>>> Hi Daniel,
>>>
>>> My colleague, R
On 10/07/15 07:34, Krzysztof Kozlowski wrote:
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
>
> Signed-off-by: Krzysztof Kozlowski
Applied to the togreg branch of iio.git
Thanks,
Jonathan
>
> ---
>
> The coccinelle script which generated the patch was
o,
>>
>> On Vi, 2014-12-05 at 02:15 +, Jonathan Cameron wrote:
>>> On 04/12/14 13:00, Teodora Baluta wrote:
>>>> This patchset adds support for fingerprint sensors through the IIO
>>>> interface.
>>>> This way userspace applications c
On 10/22/11 09:57, Laurent Pinchart wrote:
> The MT9P031 and MT9T001 sensors transfer 16-bit data on the I2C bus in
> swapped order. Let the I2C core handle byte order by using the
> i2c_smbus_{read|write}_word_swapped() functions.
>
> Signed-off-by: Laurent Pinchart
Acked-by: J
Function ensures that error codes don't get mangled.
Dependant on:
i2c: boilerplate function for byte swapped smbus_write/read_word_data
which is working it's way through the i2c tree.
Signed-off-by: Jonathan Cameron
Acked-by: Jean Delvare
---
V2: Stray line removed as per Jean
Function ensures that error codes don't get mangled.
Dependant on:
i2c: boilerplate function for byte swapped smbus_write/read_word_data
which is working it's way through the i2c tree.
Signed-off-by: Jonathan Cameron
---
In some cases the now largely pointless boiler plate function
On 07/11/11 11:57, Laurent Pinchart wrote:
> On Monday 11 July 2011 12:54:42 Laurent Pinchart wrote:
>> On Monday 11 July 2011 12:41:49 Jonathan Cameron wrote:
>
> [snip]
>
>> I think we should try to fix it in ispvideo.c instead. You could add a
>> check to isp_vid
o
the rest of the tree may be fine.
[PATCH] omap3isp: check if there is actually a source for ispccdc when
setting up the link.
Without this if no source actually exists and the ccdc is configured
to output to memory, a read from userspace will cause a null pointer
exception.
Signed-off-by:
Hi Daniel,
Thanks for the driver. Couple of quick queries. What do I need
for streaming mode (and does this work well for you?)
If I can get this working, I'm happy to pick up the job of patch
cleanup for you as a thank you.
Jonathan
> Hello again,
>
>> Hi Daniel,
>>
>> On Wednesday 01 June 20
On 07/05/11 17:35, Jonathan Cameron wrote:
> On 07/05/11 16:22, Jonathan Cameron wrote:
>> On 07/05/11 16:02, Laurent Pinchart wrote:
>>> On Tuesday 05 July 2011 16:38:07 Sakari Ailus wrote:
>>>> On Tue, Jul 05, 2011 at 02:48:57PM +0100, Jonathan Cameron wrote:
&
On 07/05/11 16:22, Jonathan Cameron wrote:
> On 07/05/11 16:02, Laurent Pinchart wrote:
>> On Tuesday 05 July 2011 16:38:07 Sakari Ailus wrote:
>>> On Tue, Jul 05, 2011 at 02:48:57PM +0100, Jonathan Cameron wrote:
>>>> On 07/05/11 13:19, Sakari Ailus wrote:
>>&g
On 07/05/11 16:02, Laurent Pinchart wrote:
> On Tuesday 05 July 2011 16:38:07 Sakari Ailus wrote:
>> On Tue, Jul 05, 2011 at 02:48:57PM +0100, Jonathan Cameron wrote:
>>> On 07/05/11 13:19, Sakari Ailus wrote:
>>>> On Tue, Jul 05, 2011 at 12:22:06PM +0100, Jonathan C
On 07/05/11 13:19, Sakari Ailus wrote:
> On Tue, Jul 05, 2011 at 12:22:06PM +0100, Jonathan Cameron wrote:
>> Hi Laurent,
>>
>> I'm just trying to get an mt9v034 sensor working on a beagle xm.
>> Everything more or less works, except that after a random number
&g
Hi Laurent,
I'm just trying to get an mt9v034 sensor working on a beagle xm.
Everything more or less works, except that after a random number
of frames of capture, I tend to get won't become idle messages
and the vd0 and vd1 interrupts tend to turn up at same time.
I was just wondering if there a
On 04/21/10 11:06, Antonio Ospite wrote:
> On Tue, 20 Apr 2010 19:36:13 +0200
> Robert Jarzmik wrote:
>
>> Guennadi Liakhovetski writes:
>>
>>> Robert, what do you think? Are you still working with PXA camera?
>> Hi Guennadi,
>>
>> Yes, I'm still working with pxa_camera :)
>>
>> About the patch,
On 04/16/10 09:25, Stefan Herbrechtsmeier wrote:
> Hi,
>
> I have updated my ov9655 driver to kernel 2.6.33 and
> did some test regarding the image shift problem on pxa.
> (http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/10773/focus=11810)
>
>
> - The image was shifted 32
On 04/06/10 15:41, Mike Isely wrote:
> On Tue, 6 Apr 2010, Hans Verkuil wrote:
>
>[...]
>
>>
>> One thing that might be useful is to prefix the name with the control class
>> name. E.g. hue becomes user_hue and audio_crc becomes mpeg_audio_crc. It
>> would
>> groups them better. Or one could
On 04/06/10 15:32, Mauro Carvalho Chehab wrote:
> Hans Verkuil wrote:
>>> Hans Verkuil wrote:
$ ls /sys/class/video4linux/video1/controls
balance mpeg_insert_navigation_packets
mpeg_video_aspect
brightnessmpeg_median_chroma_filte
On 02/22/10 16:16, Guennadi Liakhovetski wrote:
> On Mon, 22 Feb 2010, Rodolfo Giometti wrote:
>
>> On Fri, Feb 19, 2010 at 08:36:38PM +0100, Guennadi Liakhovetski wrote:
>>> On Fri, 19 Feb 2010, Rodolfo Giometti wrote:
>>>
Hello,
on my pxa27x based board I have a adv7180 connected
Hi All,
>> 3) it would be interesting to patch the other sensor drivers to be compatible
>>with soc_camera (mt9v011/ov7670);
>
> Well, this could be done, yes, but does it make sense to do this blindly
> without any hardware to test? I would rather add such conversions on a
> one-by-one bas
ably in a queue
for next merge window? - it's certainly in the tree Guennadi is using and has
been
posted to linux-media)
Google did however give me this hit, which mentions an ov9650 driver
http://marex-hnd.blogspot.com/2009/08/omnivision-ov9640-hacking-part-iv.html
Perhaps Guennadi has mor
linux/sched.h include was removed form linux/poll.h by
commmit a99bbaf5ee6bad1aca0c88ea65ec6e5373e86184
Required for wakeup call.
Signed-off-by: Jonathan Cameron
---
drivers/media/video/pxa_camera.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video
Jonathan Cameron wrote:
> Error was
>
> drivers/media/video/pxa_camera.c: In function 'pxa_camera_wakeup':
> drivers/media/video/pxa_camera.c:683: error: 'TASK_NORMAL' undeclared (first
> use in this function)
> drivers/media/video/pxa_camera.c:683:
Error was
drivers/media/video/pxa_camera.c: In function 'pxa_camera_wakeup':
drivers/media/video/pxa_camera.c:683: error: 'TASK_NORMAL' undeclared (first
use in this function)
drivers/media/video/pxa_camera.c:683: error: (Each undeclared identifier is
reported only once
drivers/media/video/pxa
Guennadi Liakhovetski wrote:
> On Tue, 1 Sep 2009, Jonathan Cameron wrote:
>
>> Dear all,
>>
>> With an ov7670 I have been using soc_camera_link.reset to pass in board
>> specific
>> hardware reset of the sensor. (Is this a correct usage? The reset m
Dear all,
With an ov7670 I have been using soc_camera_link.reset to pass in board specific
hardware reset of the sensor. (Is this a correct usage? The reset must occur
before the chip is used.)
Unfortunately this function is called on every initialization of the camera
(so on probe and before tak
Guennadi Liakhovetski wrote:
> On Wed, 10 Jun 2009, Guennadi Liakhovetski wrote:
>
>> 2. The above means, I'll have to maintain and update my patches for a
>> whole 2.6.31 development cycle. In this time I'll try to update and upload
>> them as a quilt patch series and announce it on the list a
Hi All,
Turns out that, in addition the below, one more soc-camera ops
function is still needed.
Init is required in my case to make a call to the subdev->ops->core_ops->init
function in order to put the register contents back after the reset callback
in soc_camera_open.
I'm guessing down the li
Updated temporary patch to get ov7670 working with soc camera.
---
Basically this is the original patch with the changes Guennadi
suggested. Again this is only for info, not a formal patch submission.
diff --git a/drivers/media/video/ov7670.c b/drivers/media/video/ov7670.c
index 0e2184e..9bea804
Guennadi Liakhovetski wrote:
> On Wed, 17 Jun 2009, Jonathan Cameron wrote:
>
>> This is purely for info of anyone else wanting to use the ov7670
>> with Guennadi's recent work on converted soc-camera to v4l2-subdevs.
>>
>> It may not be completely minimal
de 100644
index 000..2f264b2
--- /dev/null
+++ b/include/media/ov7670_soc.h
@@ -0,0 +1,21 @@
+/* ov7670_soc Camera
+ *
+ * Copyright (C) 2009 Jonathan Cameron
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2
Just came across a build error with pxa_camera with Mauro's linux-next tree.
pxa-camera calls v4l2_bound_align_image whereas the function is called
v4l_bound_align_image.
Cheers,
---
Jonathan Cameron
--
To unsubscribe from this list: send the line "unsubscribe linux-media" i
Hans Verkuil wrote:
> On Tuesday 16 June 2009 16:45:04 Jonathan Cameron wrote:
>> Guennadi Liakhovetski wrote:
>>> On Mon, 15 Jun 2009, Jonathan Cameron wrote:
>>>> From: Jonathan Cameron
>>>>
>>>> OV7670 soc-camera driver. Merge of drivers
Darius Augulis wrote:
> On 06/16/2009 05:45 PM, Jonathan Cameron wrote:
>> Guennadi Liakhovetski wrote:
>>> On Mon, 15 Jun 2009, Jonathan Cameron wrote:
>>>
>>>> From: Jonathan Cameron
>>>>
>>>> OV7670 soc-camera driver. Merge of
Guennadi Liakhovetski wrote:
> On Mon, 15 Jun 2009, Jonathan Cameron wrote:
>
>> From: Jonathan Cameron
>>
>> OV7670 soc-camera driver. Merge of drivers from Jonathan Corbet,
>> Darius Augulis and Jonathan Cameron
>
> Could you please, describe in more d
From: Jonathan Cameron
OV7670 soc-camera driver. Merge of drivers from Jonathan Corbet,
Darius Augulis and Jonathan Cameron
Signed-off-by: Jonathan Cameron
---
This is my first cut at a merge of the various ov7670 drivers to work
with Guennadi Liakhovetski's work on moving soc-camera ov
Hi All,
Whilst working on merging the various ov7670 drivers posted
recently, I came across the following in soc-camera:
static int soc_camera_g_ctrl(struct file *file, void *priv,
struct v4l2_control *ctrl)
{
struct soc_camera_file *icf = file->private_data;
ets at the
moment and ideally we want to support everything the individual
drivers do.
Is anyone else doing or aiming to do the same?
Thanks,
---
Jonathan Cameron
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kerne
Jonathan Corbet wrote:
> On Sun, 15 Mar 2009 17:10:01 +
> Jonathan Cameron wrote:
>
>> The primary control on this chip related to shutter rate is actualy
>> the frame rate. There are rather complex (and largerly undocumented)
>> interactions between this sett
Guennadi Liakhovetski wrote:
> On Sun, 15 Mar 2009, Hans Verkuil wrote:
>
>> On Sunday 15 March 2009 19:50:39 Guennadi Liakhovetski wrote:
>>> On Sun, 15 Mar 2009, Jonathan Cameron wrote:
>>>> From: Jonathan Cameron
>>>>
>>>> OV7670 drive
From: Jonathan Cameron
OV7670 driver for soc-camera interfaces.
---
There is already an ov7670 driver in tree, but it is very interface
specific (olpc) and hence not much use for the crossbow IMB400 board
which is plugged into an imote 2 pxa271 main board.
Thanks go to Crossbow (www.xbow.com
61 matches
Mail list logo
