On Thu, 2019-09-26 at 08:53 -0700, Kees Cook wrote:
> On Thu, Sep 26, 2019 at 08:14:03AM -0700, Joe Perches wrote:
> > On Wed, 2019-09-25 at 11:40 -0700, Kees Cook wrote:
> > > Is "6" a safe lower bound here? I thought 12 was the way to go?
> > []
> > &
On Wed, 2019-09-25 at 11:40 -0700, Kees Cook wrote:
> On Wed, Sep 25, 2019 at 10:13:37AM -0700, Joe Perches wrote:
> > On Thu, 2019-09-19 at 09:56 +0300, Dan Carpenter wrote:
> > > When I sent a patch, I use get_maintainer.pl then I add whoever the
> > > wrote the commi
On Thu, 2019-09-19 at 09:56 +0300, Dan Carpenter wrote:
> When I sent a patch, I use get_maintainer.pl then I add whoever the
> wrote the commit from the Fixes tag. Then I remove Colin King and Kees
> Cook from the CC list because they worked all over the tree and I know
> them. I also normally r
On Thu, 2019-09-19 at 10:08 +0300, Dan Carpenter wrote:
> On Wed, Sep 18, 2019 at 03:48:31PM -0300, Mauro Carvalho Chehab wrote:
> > Em Wed, 18 Sep 2019 20:27:05 +0300
> > Laurent Pinchart escreveu:
> >
> > > > Anyway, not sure if the other sub-maintainers see the same way. From my
> > > > side,
On Thu, 2019-03-07 at 18:03 +0800, Randy Li wrote:
> It is based on the vendor driver sent to mail list before.
trivial notes:
> diff --git a/drivers/staging/rockchip-mpp/mpp_debug.h
> b/drivers/staging/rockchip-mpp/mpp_debug.h
[]
> +#define mpp_debug_func(type, fmt, args...) \
> > b/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.h
[]
> > + // Videobuf2
>
> Doesn't checkpatch.pl --strict complain about the use of '//'?
No, not since
commit dadf680de3c2eb4cba9840619991eda0cfe98778
Author: Joe Perches
Date: Tue Aug 2 14:04:33 2
On Wed, 2018-10-17 at 11:49 +0300, Stanimir Varbanov wrote:
> On 10/08/2018 04:32 PM, Vikash Garodia wrote:
> > Add routine to reset the ARM9 and brings it out of reset. Also
> > abstract the Venus CPU state handling with a new function. This
> > is in preparation to add PIL functionality in venus
t;
> > Fixes: 40a78f36fc92 ("[media] v4l: atmel-isi: Remove support for platform
> > data")
> > Reported-by: Joe Perches
> > Signed-off-by: Laurent Pinchart
> > ---
> > MAINTAINERS | 1 -
> > 1 file changed, 1 deletion(-)
> >
> >
>
Some functions definitions have either the initial open brace and/or
the closing brace outside of column 1.
Move those braces to column 1.
This allows various function analyzers like gnu complexity to work
properly for these modified functions.
Signed-off-by: Joe Perches
Acked-by: Andy
On Fri, 2018-03-16 at 16:27 +0100, Rasmus Villemoes wrote:
> On 2018-03-15 11:00, Kieran Bingham wrote:
> > Simplify array iteration with a helper to iterate each entry in an array.
> > Utilise the existing ARRAY_SIZE macro to identify the length of the array
> > and pointer arithmetic to process e
On Thu, 2018-03-01 at 20:02 +0100, jacopo mondi wrote:
> Hi Joe,
Hello Jacopo
> On Thu, Mar 01, 2018 at 03:50:22AM -0800, Joe Perches wrote:
> > Update multiline statements to open parenthesis.
> > Update a ?: to a single line.
>
> Thanks for the cleanup.
> You ma
Yet more whitespace and style neatening
o Add blank lines before returns
o Reverse a logic test and return early on error
o Move formats to same line as dev_ calls
o Remove an unnecessary period from a logging message
Signed-off-by: Joe Perches
---
drivers/media/i2c/tw9910.c | 27
Update multiline statements to open parenthesis.
Update a ?: to a single line.
Signed-off-by: Joe Perches
---
drivers/media/i2c/tw9910.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/media/i2c/tw9910.c b/drivers/media/i2c/tw9910.c
index
scheduling can generally be better when these values are
not identical. Perhaps these ranges should be expanded.
$ git grep -P -n "usleep_range\s*\(\s*([\w\.\>\-]+)\s*,\s*\1\s*\)"
drivers/clk/ux500/clk-sysctrl.c:45:
usleep_range(clk->enable_delay_us, clk->enable_delay_us);
drivers/cp
On Tue, 2018-01-09 at 21:39 +0100, Christoph Hellwig wrote:
> Switch to a plain kzalloc instea of pci_zalloc_coherent to allocate
> memory for the USB DMA.
[]
> diff --git a/drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c
> b/drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c
[]
> @@ -792,21 +791
Joe Perches (4):
sysfs.h: Use octal permissions
treewide: Use DEVICE_ATTR_RW
treewide: Use DEVICE_ATTR_RO
treewide: Use DEVICE_ATTR_WO
arch/arm/mach-pxa/sharpsl_pm.c | 4 +-
arch/s390/kernel/smp.c | 2 +-
arch/s390/kernel/topology.c
)/g;
print;}'
Signed-off-by: Joe Perches
---
arch/arm/mach-pxa/sharpsl_pm.c | 4 ++--
arch/sh/drivers/push-switch.c| 2 +-
arch/tile/kernel/sysfs.c | 10 +-
drivers/acpi/device_sysfs.c
line from xfs_agf_verify
Signed-off-by: Joe Perches
---
git diff -w shows no difference other than the above 'Miscellanea'
(this is against -next, but it applies against Linus' tree
with a couple offsets)
arch/x86/include/asm/atomic64_32.h | 2 +
On Thu, 2017-12-14 at 20:37 +0200, Laurent Pinchart wrote:
> Hi Joe,
Hi Laurent.
> On Thursday, 14 December 2017 20:32:20 EET Joe Perches wrote:
> > Adding a comment line that describes an implicit or
> > explicit license is different than removing the license
> > te
On Thu, 2017-12-14 at 20:28 +0200, Laurent Pinchart wrote:
> Hi Mauro,
>
> On Thursday, 14 December 2017 19:05:27 EET Mauro Carvalho Chehab wrote:
> > Em Fri, 8 Dec 2017 18:05:37 +0530 Dhaval Shah escreveu:
> > > SPDX-License-Identifier is used for the Xilinx Video IP and
> > > related drivers.
>
On Thu, 2017-12-14 at 15:05 -0200, Mauro Carvalho Chehab wrote:
> Em Fri, 8 Dec 2017 18:05:37 +0530
> Dhaval Shah escreveu:
>
> > SPDX-License-Identifier is used for the Xilinx Video IP and
> > related drivers.
> >
> > Signed-off-by: Dhaval Shah
>
> Hi Dhaval,
>
> You're not listed as one of
On Tue, 2017-12-12 at 15:21 +0100, Arnd Bergmann wrote:
> On Tue, Dec 12, 2017 at 1:45 PM, Mauro Carvalho Chehab
> wrote:
> > Em Tue, 12 Dec 2017 03:42:32 -0800
> > Joe Perches escreveu:
> >
> > > > I actually thought about marking them 'const' her
On Tue, 2017-12-12 at 11:24 +0100, Arnd Bergmann wrote:
> On Mon, Dec 11, 2017 at 10:17 PM, Michael Ira Krufky
> wrote:
> > On Mon, Dec 11, 2017 at 2:34 PM, Joe Perches wrote:
> > > On Mon, 2017-12-11 at 13:06 +0100, Arnd Bergmann wrote:
> > > > With CONFIG_K
On Mon, 2017-12-11 at 13:06 +0100, Arnd Bergmann wrote:
> With CONFIG_KASAN enabled, we get a relatively large stack frame in one
> function
>
> drivers/media/tuners/tda8290.c: In function 'tda8290_set_params':
> drivers/media/tuners/tda8290.c:310:1: warning: the frame size of 1520 bytes
> is la
On Thu, 2017-11-16 at 12:11 -0500, Mimi Zohar wrote:
> On Thu, 2017-11-16 at 07:27 -0800, Joe Perches wrote:
> > Avoid using line continations in formats as that causes unexpected
> > output.
>
> Is having lines greater than 80 characters the preferred method?
yes.
&g
Line continuations with excess spacing causes unexpected output.
Signed-off-by: Joe Perches
---
drivers/media/dvb-frontends/dibx000_common.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/dvb-frontends/dibx000_common.c
b/drivers/media/dvb-frontends
Avoid using line continations in formats as that causes unexpected
output.
Joe Perches (4):
rk3399_dmc: Fix line continuation format
drm: amd: Fix line continuation formats
[media] dibx000_common: Fix line continuation format
ima: Fix line continuation format
drivers/devfreq
Move some data to text
$ size drivers/media/usb/uvc/uvc_ctrl.o*
textdata bss dec hex filename
343232364 0 366878f4f drivers/media/usb/uvc/uvc_ctrl.o.new
286598028 0 366878f4f drivers/media/usb/uvc/uvc_ctrl.o.old
Signed-off-by: Joe Perches
MAINTAINERS is not supposed to have duplicated sections.
Can you both please resolve this?
AS3645A LED FLASH CONTROLLER DRIVER
M: Sakari Ailus
L: linux-l...@vger.kernel.org
S: Maintained
F: drivers/leds/leds-as3645a.c
AS3645A LED FLASH CONTROLLER DRIVER
M: Laurent Pincha
On Sun, 2017-09-24 at 12:22 +0200, SF Markus Elfring wrote:
> Omit an extra message for a memory allocation failure in this function.
[]
> diff --git a/drivers/media/platform/omap/omap_vout.c
> b/drivers/media/platform/omap/omap_vout.c
[]
> @@ -1948,7 +1948,5 @@ static int __init omap_vout_create_
On Fri, 2017-09-22 at 19:46 +0200, SF Markus Elfring wrote:
> > > > They are both equally uninformative.
> > >
> > > Which identifier would you find appropriate there?
> >
> > error was fine.
>
> How do the different views fit together?
Markus, please respect what others tell you because
your c
Use a more typical kernel logging style.
The current macro hides the gspca_dev argument so add it to the
macro uses instead.
Miscellanea:
o Add missing '\n' terminations to formats
o Realign arguments to open parenthesis
Signed-off-by: Joe Perches
---
drivers/media/usb/gs
On Fri, 2017-09-15 at 19:29 +0200, SF Markus Elfring wrote:
> diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
> b/drivers/media/platform/stm32/stm32-dcmi.c
[]
> @@ -1372,9 +1372,8 @@ static int dcmi_formats_init(struct stm32_dcmi *dcmi)
> dcmi->sd_formats = devm_kcalloc(dcmi->dev,
> -
On Tue, 2017-08-29 at 07:35 +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Mon, 28 Aug 2017 22:46:30 +0200
>
> Fix a word in this description.
>
> Signed-off-by: Markus Elfring
> ---
> drivers/media/usb/zr364xx/zr364xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
On Wed, 2017-08-02 at 18:00 +1000, Sergei A. Trusov wrote:
> The calloc function returns either a null pointer or a pointer to the
> allocated space. Add the second case that is missed.
gads.
Bug added by commit da22013f7df4 ("atomisp: remove indirection from
sh_css_malloc")
These wrappers shoul
On Sun, 2017-07-16 at 16:38 -0700, Shy More wrote:
> Below was the trival error flagged by checkpatch.pl:
> ERROR: space prohibited after that open parenthesis '('
[]
> diff --git
> a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
>
> b/drivers/staging/media
On Fri, 2017-07-14 at 11:25 +0200, Arnd Bergmann wrote:
> We test whether a bit is set in a mask here, which is correct
> but gcc warns about it as it thinks it might be confusing:
>
> drivers/isdn/isdnloop/isdnloop.c:412:37: error: ?: using integer constants in
> boolean context, the expression
On Fri, 2017-07-14 at 11:31 +0200, Arnd Bergmann wrote:
> When we pass the result of a multiplication as the timeout, we
> can get a warning:
>
> drivers/mmc/host/bcm2835.c:596:149: error: '*' in boolean context, suggest
> '&&' instead [-Werror=int-in-bool-context]
> drivers/mfd/arizona-core.c:24
On Sun, 2017-07-09 at 19:39 +0200, Philipp Guendisch wrote:
> This patch fixed alignment, comment style and one appearance of
> misordered constant in an if comparison.
> Semantic should not be affected by this patch.
Your email subject is wrong. This is not a checkpatch patch.
Your subject line
On Fri, 2017-07-07 at 20:40 -0400, Amitoj Kaur Chawla wrote:
> Conditionally calling kfree()/vfree() can be replaced by a call to
> kvfree() which handles both kmalloced memory and vmalloced memory.
[]
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c
> b/drivers/staging/
On Thu, 2017-06-29 at 16:59 +0530, Pushkar Jambhlekar wrote:
> Function name is hardcoded. replacing with __func__
Please run your proposed patches through checkpatch
before you send them.
> diff --git a/drivers/staging/media/cxd2099/cxd2099.c
> b/drivers/staging/media/cxd2099/cxd2099.c
[]
> @@
Commit 680d87c0a9e3 ("[media] tuner-core: use pr_foo, instead of
internal printk macros") removed the use of PREFIX, remove the #define
Signed-off-by: Joe Perches
---
drivers/media/v4l2-core/tuner-core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/v4l2-core/tu
Convert STK_ to pr_ to use the typical kernel logging.
Add a define for pr_fmt. No change in logging output.
Miscellanea:
o Remove now unused PREFIX and STK_ macros
o Realign arguments
o Use pr__ratelimited
o Add a few missing newlines to formats
Signed-off-by: Joe Perches
---
drivers/media
On Thu, 2017-06-08 at 14:24 +0900, Tomasz Figa wrote:
> On Thu, Jun 8, 2017 at 2:16 PM, Joe Perches wrote:
[]
> > If there automated systems that rely on specific levels, then
> > changing the levels of individual messages could also cause
> > those automated systems to
On Thu, 2017-06-08 at 13:39 +0900, Tomasz Figa wrote:
> On Thu, Jun 8, 2017 at 12:24 PM, Hirokazu Honda wrote:
> > Hi,
> >
> > I completely understand bitmask method now.
> > I agree to the idea, but it is necessary to change the specification of
> > a debug parameter.
> > (We probably need to c
On Wed, 2017-05-31 at 12:28 +0900, Hirokazu Honda wrote:
> If I understand a bitmap correctly, it is necessary to change the log level
> for each message.
> I didn't mean a bitmap will take a long CPU time.
> I mean the work to change so takes a long time.
No, none of the messages or levels need c
On Wed, 2017-05-31 at 11:05 +0900, Hirokazu Honda wrote:
> Although bitmap is useful, there is need to change the log level for each
> log.
> Because it will take a longer time, it should be done in another patch.
I have no idea what you mean.
A bit & comparison is typically an identical instruct
On Tue, 2017-05-30 at 18:49 +0900, Hirokazu Honda wrote:
> Some debug output whose log level is set 1 flooded the log.
> Their log level is lowered to find the important log easily.
Maybe use pr_debug instead?
Perhaps it would be better to change the level to a bitmap
so these can be more individ
__printf validation adds format and argument validation.
Fix the various broken format/argument mismatches.
Signed-off-by: Joe Perches
---
v2: bah, now without unrelated changes to other staging files...
I'm not at all sure all the modifications are appropriate.
Some maybe should us
__printf validation adds format and argument validation.
Fix the various broken format/argument mismatches.
Signed-off-by: Joe Perches
---
I'm not at all sure all the modifications are appropriate.
Some maybe should use the original format types like
%x instead of %p with *pointer inste
Add these misspellings to scripts/spelling.txt too
Signed-off-by: Joe Perches
---
drivers/media/dvb-frontends/drx39xyj/drx_dap_fasi.h | 2 +-
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 2 +-
drivers/net/ethernet/hisilicon/hns/hns_enet.c | 2 +-
drivers/net/ethernet/qlogic/qed
On Sun, 2017-03-05 at 10:14 -0800, Alison Schofield wrote:
> On Sun, Mar 05, 2017 at 12:17:21PM +0530, simran singhal wrote:
> > The function atomisp_set_stop_timeout on being called, simply returns
> > back. The function hasn't been mentioned in the TODO and doesn't have
> > FIXME code around. Hen
On Thu, 2017-03-02 at 23:59 +0100, Arnd Bergmann wrote:
> KASAN decides that passing a pointer to _m into an extern function
> (_mlog_printk) is potentially dangerous, as that function might
> keep a reference to that pointer after it goes out of scope,
> or it might not know the correct length of
On Thu, 2017-03-02 at 23:22 +0100, Arnd Bergmann wrote:
> On Thu, Mar 2, 2017 at 6:46 PM, Joe Perches wrote:
> > On Thu, 2017-03-02 at 17:38 +0100, Arnd Bergmann wrote:
> > > The internal logging infrastructure in ocfs2 causes special warning code
> > > to be
&
itectures,
> I'm guessing that the resulting code is comparable to what it was before.
>
> The current version was introduced by Joe Perches as an optimization, maybe
> he can see if my change regresses compared to his.
I don't see it.
> Cc: Joe Perches
> Fixes: 7c2bd2
On Thu, 2017-02-23 at 17:41 +, Emil Velikov wrote:
> On 23 February 2017 at 17:18, Joe Perches wrote:
> > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote:
> > > On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote:
> > > > There are ~4300 uses of pr_w
On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote:
> On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote:
> > There are ~4300 uses of pr_warn and ~250 uses of the older
> > pr_warning in the kernel source tree.
> >
> > Make the use of pr_warn consistent across all
with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing.
Miscellanea:
o Coalesce formats and realign arguments
Some files not compiled - no cross-compilers
Joe Perches (35):
alpha: Convert remaining uses of pr_warning to pr_warn
ARM: ep93xx: Convert remaining uses of pr_warning
To enable eventual removal of pr_warning
This makes pr_warn use consistent for drivers/media
Prior to this patch, there was 1 use of pr_warning and
310 uses of pr_warn in drivers/media
Signed-off-by: Joe Perches
---
drivers/media/platform/sh_vou.c | 4 ++--
1 file changed, 2 insertions(+), 2
On Fri, 2017-02-10 at 08:40 -0700, Shuah Khan wrote:
> Fix s5p_mfc_set_dec_frame_buffer_v6() to print buffer pointer in hex to be
> consistent with the rest of the messages in the routine.
More curiously, why is buf_addr a size_t and not
a dma_addr_t?
> Signed-off-by: Shuah Khan
> ---
>
> Fixed
On Tue, 2017-01-31 at 10:30 -0800, Eric Anholt wrote:
> Joe Perches writes:
>
> > On Mon, 2017-01-30 at 12:05 -0800, Eric Anholt wrote:
> > > Joe Perches writes:
> > >
> > > > On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote:
> > > > &g
On Mon, 2017-01-30 at 12:05 -0800, Eric Anholt wrote:
> Joe Perches writes:
>
> > On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote:
> > > Generated with checkpatch.pl --fix-inplace and git add -p out of the
> > > results.
> >
> > Maybe another.
>
On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote:
> Generated with checkpatch.pl --fix-inplace and git add -p out of the
> results.
Maybe another.
> diff --git a/drivers/staging/media/platform/bcm2835/mmal-vchiq.c
> b/drivers/staging/media/platform/bcm2835/mmal-vchiq.c
[]
> @@ -239,7 +239,7
On Thu, 2016-10-13 at 18:18 +0200, SF Markus Elfring wrote:
> diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c
[]
> @@ -549,7 +549,7 @@ static void redrat3_get_firmware_rev(struct redrat3_dev
> *rr3)
> int rc = 0;
> char *buffer;
>
> - buffer = kzalloc(sizeof(
On Sat, 2016-10-01 at 21:46 +0200, Julia Lawall wrote:
> These patches fix cases where the documentation above a function definition
> is not consistent with the function header. Issues are detected using the
> semantic patch below (http://coccinelle.lip6.fr/). Basically, the semantic
> patch par
On Sun, 2016-09-11 at 15:05 +0200, Julia Lawall wrote:
> Constify local structures.
Thanks Julia.
A few suggestions & questions:
Perhaps the script should go into scripts/coccinelle/
so that future cases could be caught by the robot
and commit message referenced by the patch instances.
Can you
On Sat, 2016-08-06 at 07:35 -0300, Mauro Carvalho Chehab wrote:
> Hi Linus,
>
> Please pull from my tree for a small fixup on my entry and Shuah's entry at
> .mailcap.
>
> Basically, those entries were with a syntax that makes get_maintainer.pl to
> do the wrong thing.
>
> Thanks!
> Mauro
.mail
On Tue, 2016-07-12 at 10:08 -0600, Shuah Khan wrote:
> On 07/12/2016 09:51 AM, Joe Perches wrote:
> > On Tue, 2016-07-12 at 08:42 -0600, Shuah Khan wrote:
> > > On 07/12/2016 08:06 AM, Joe Perches wrote:
> > > > On Mon, 2016-07-11 at 16:39 -0600, Shuah Khan w
On Tue, 2016-07-12 at 08:42 -0600, Shuah Khan wrote:
> On 07/12/2016 08:06 AM, Joe Perches wrote:
> > On Mon, 2016-07-11 at 16:39 -0600, Shuah Khan wrote:
> > > Fix misspelled error message and existing checkpatch errors in the
> > > error message conditional.
> &
On Mon, 2016-07-11 at 16:39 -0600, Shuah Khan wrote:
> Fix misspelled error message and existing checkpatch errors in the
> error message conditional.
[]
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
> b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
[]
> @@ -775,11 +775,11 @@ static i
On Mon, 2016-07-11 at 18:17 +0300, Andrey Utkin wrote:
[]
> diff --git a/drivers/media/pci/tw5864/tw5864-core.c
> b/drivers/media/pci/tw5864/tw5864-core.c
[]
> +static const char * const artifacts_warning =
> +"BEWARE OF KNOWN ISSUES WITH VIDEO QUALITY\n"
> +"\n"
> +"This driver was developed by B
On Wed, 2016-06-29 at 22:20 +0900, Andi Shyti wrote:
> This patch mutes also all the checkpatch warnings related to
> printk.
>
> Reword all the printouts so that the string doesn't need to be
> split, which fixes the following checkpatch warning:
Adding
#define pr_fmt(fmt) KBUILD_MODNAME ": " f
On Sun, 2016-06-12 at 00:22 +0200, Henrik Austad wrote:
> From: Henrik Austad
>
> In short summary:
>
> * tsn_core.c is the main driver of tsn, all new links go through
> here and all data to/form the shims are handled here
> core also manages the shim-interface.
[]
> diff --git a/net/tsn/ts
On Fri, 2016-03-25 at 22:38 -0600, Shuah Khan wrote:
> Add Media Device Allocator API to manage Media Device life time problems.
> There are known problems with media device life time management. When media
> device is released while an media ioctl is in progress, ioctls fail with
> use-after-free
On Mon, 2016-03-14 at 03:59 +0200, Andrey Utkin wrote:
> Support for boards based on Techwell TW5864 chip which provides
> multichannel video & audio grabbing and encoding (H.264, MJPEG,
> ADPCM G.726).
trivia:
Perhaps all the __used arrays could be const
--
To unsubscribe from this list: send t
Since commit 3cab1e711297 ("lib/vsprintf: refactor duplicate code
to special_hex_number()") %pa uses have been ouput with a 0x prefix.
These 0x prefixes in the formats are unnecessary.
Signed-off-by: Joe Perches
---
drivers/dma/at_hdmac_regs.h | 2 +-
drivers/media/platf
On Sun, 2016-01-03 at 03:41 +0200, Andrey Utkin wrote:
> (Disclaimer up to scissors mark)
>
> Please be so kind to take a look at a new driver.
trivial comments only:
> diff --git a/drivers/staging/media/tw5864/tw5864-bs.h
> b/drivers/staging/media/tw5864/tw5864-bs.h
[]
> +static inline int bs_p
On Thu, 2015-08-27 at 00:51 +0600, Alexander Kuleshov wrote:
> printk() supports %*ph format specifier for printing a small buffers,
> let's use it intead of %02x %02x...
Having just suffered this myself...
> diff --git a/drivers/media/pci/cobalt/cobalt-cpld.c
> b/drivers/media/pci/cobalt/cobalt
On Sat, 2015-08-08 at 08:42 -0700, Greg KH wrote:
> Greg does not accept drivers/staging/media/* patches,
You could change
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 111a6b2..089c458 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9742,6 +97
On Mon, 2015-08-03 at 19:06 +0200, Jean Delvare wrote:
> Hi Bartlomiej,
>
> Le Monday 03 August 2015 à 17:33 +0200, Bartlomiej Zolnierkiewicz a
> écrit :
> > Hi,
> >
> > On Sunday, August 02, 2015 01:40:40 PM Joe Perches wrote:
> > > On Sun, 2015-08-02 at
On Sun, 2015-08-02 at 20:31 +, Mail Delivery System wrote:
> : host mailin.samsung.com[203.254.224.12]
> said: 550 5.1.1
> Recipient address rejected: User unknown (in reply to RCPT TO
> command)
His email address bounces.
Should MAINTAINERS be updated?
---
MAINTAINERS | 8 ++--
1
Correct misuse of 0x%d in logging message.
Signed-off-by: Joe Perches
---
drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c
index
On Thu, 2015-07-30 at 10:47 +0100, Peter Griffin wrote:
> Hi Mauro / Joe,
>
> On Wed, 22 Jul 2015, Mauro Carvalho Chehab wrote:
>
> > Em Wed, 24 Jun 2015 18:17:37 -0700
> > Joe Perches escreveu:
> >
> > > On Wed, 2015-06-24 at 16:11 +0100, Peter
On Wed, 2015-06-24 at 16:11 +0100, Peter Griffin wrote:
> This is used in conjunction with the STV0367 demodulator on
> the STV0367-NIM-V1.0 NIM card which can be used with the STi
> STB SoC's.
Barely associated to this specific patch, but for
dvb-pll.c, another thing that seems possible is to
con
Format mac addresses with the normal kernel extension.
Signed-off-by: Joe Perches
---
drivers/media/pci/ttpci/ttpci-eeprom.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/pci/ttpci/ttpci-eeprom.c
b/drivers/media/pci/ttpci/ttpci-eeprom.c
index 32d4315
On Tue, 2015-06-09 at 19:07 -0300, Mauro Carvalho Chehab wrote:
> Hi Joe,
Marhaba Mauro.
> Em Mon, 25 May 2015 01:29:07 -0700
> Joe Perches escreveu:
>
> > Use a more current logging style.
> >
> > o Use pr_fmt
> > o Add missing newlines to formats
&g
On Mon, 2015-06-08 at 16:54 -0300, Mauro Carvalho Chehab wrote:
> The DVB API was originally defined using typedefs. This is against
> Kernel CodingStyle, and there's no good usage here. While we can't
> remove its usage on userspace, we can avoid its usage in Kernelspace.
>
> So, let's do it.
>
On Thu, 2015-05-28 at 23:02 +0200, Julia Lawall wrote:
> From: Julia Lawall
>
> Delete jump to a label on the next line, when that label is not
> used elsewhere.
Seems sensible but:
> diff --git a/drivers/media/usb/airspy/airspy.c
> b/drivers/media/usb/airspy/airspy.c
[]
> @@ -937,9 +937,6 @@
spelling of snippet
o Use %phN extension
Signed-off-by: Joe Perches
---
drivers/media/usb/dvb-usb-v2/lmedm04.c | 105 +++--
1 file changed, 49 insertions(+), 56 deletions(-)
diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c
b/drivers/media/usb/dvb-usb-v2/lmedm04.c
On Sun, 2015-05-17 at 19:18 +0200, Alex Dowad wrote:
> This fixes a checkpatch style error in vpfe_buffer_queue_setup.
There is no checkpatch message for this style.
Nor should there be.
> diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c
> b/drivers/staging/media/davinci_vpfe/vpfe_v
On Tue, 2015-02-24 at 16:41 -0700, Shuah Khan wrote:
> On 02/24/2015 03:03 PM, Mauro Carvalho Chehab wrote:
> > Em Tue, 24 Feb 2015 11:53:47 -0700 Shuah Khan
> > escreveu:
> >> Replace printk macro in dprintk macros in em28xx audio, dvb,
> >> and input files with pr_* equivalent routines.
[]
> >>
On Tue, 2015-02-24 at 10:17 +0530, Tapasweni Pathak wrote:
> Replace dev_err statement with pr_err to fix null dereference.
>
> Found by Coccinelle.
>
> Signed-off-by: Tapasweni Pathak
> ---
> drivers/media/i2c/s5c73m3/s5c73m3-spi.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Convert dprintk to netdev_dbg where appropriate.
Remove dvb_net_debug module_param.
Remove __func__ from output as that can be added by dynamic_debug.
Signed-off-by: Joe Perches
---
drivers/media/dvb-core/dvb_net.c | 57 +---
1 file changed, 24 insertions
Use the generic facility instead of a home-grown one.
Signed-off-by: Joe Perches
---
drivers/media/dvb-core/dvb_net.c | 28 ++--
1 file changed, 2 insertions(+), 26 deletions(-)
diff --git a/drivers/media/dvb-core/dvb_net.c b/drivers/media/dvb-core/dvb_net.c
index
No need for more macros, so remove them and use the kernel extension.
Signed-off-by: Joe Perches
---
drivers/media/dvb-core/dvb_net.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/media/dvb-core/dvb_net.c b/drivers/media/dvb-core/dvb_net.c
index e4041f0
Use more common kernel mechanisms
Joe Perches (3):
dvb_net: Use vsprintf %pM extension to print Ethernet addresses
dvb_net: Use standard debugging facilities
dvb_net: Convert local hex dump to print_hex_dump_debug
drivers/media/dvb-core/dvb_net.c | 88
On Sat, 2015-01-03 at 18:09 -0200, Mauro Carvalho Chehab wrote:
> Instead of keeping the media controller entity not initialized,
> fill it and create the pads for cx25840.
Won't you get an unused variable for ret
without CONFIG_MEDIA_CONTROLLER?
> diff --git a/drivers/media/i2c/cx25840/cx25840-c
On Wed, 2014-12-10 at 23:57 +, Luis de Bethencourt wrote:
> On Wed, Dec 10, 2014 at 03:39:09PM -0800, Joe Perches wrote:
> > On Wed, 2014-12-10 at 22:33 +, Luis de Bethencourt wrote:
> > > diff --git a/drivers/staging/media/lirc/lirc_zilog.c
> > > b/drivers/stag
On Wed, 2014-12-10 at 22:33 +, Luis de Bethencourt wrote:
> checkpatch makes an exception to the 80-colum rule for quotes strings, and
> Documentation/CodingStyle recommends not splitting quotes strings across lines
> because it breaks the ability to grep for the string. Fixing these.
[]
> diff
On Wed, 2014-11-26 at 15:42 +, Luis de Bethencourt wrote:
> On 26 November 2014 at 01:49, Joe Perches wrote:
[]
> > There is a script I posted a while back that
> > groups various checkpatch "types" together and
> > makes it a bit easier to do cleanup s
1 - 100 of 232 matches
Mail list logo
