Re: [PATCH RFC 1/1] uio: Add dma-buf import ioctls

Hi Daniel, On Thu, 2019-02-28 at 02:01:46 -0800, Daniel Vetter wrote: > On Wed, Feb 27, 2019 at 04:36:06PM -0800, Hyun Kwon wrote: > > Hi Daniel, > > > > On Wed, 2019-02-27 at 06:13:45 -0800, Daniel Vetter wrote: > > > On Tue, Feb 26, 2019 at 11:20 PM Hyun Kwon wr

Re: [PATCH RFC 1/1] uio: Add dma-buf import ioctls

Hi Daniel, On Wed, 2019-02-27 at 06:13:45 -0800, Daniel Vetter wrote: > On Tue, Feb 26, 2019 at 11:20 PM Hyun Kwon wrote: > > > > Hi Daniel, > > > > Thanks for the comment. > > > > On Tue, 2019-02-26 at 04:06:13 -0800, Daniel Vetter wrote: > >

Re: [PATCH RFC 1/1] uio: Add dma-buf import ioctls

Hi Daniel, Thanks for the comment. On Tue, 2019-02-26 at 04:06:13 -0800, Daniel Vetter wrote: > On Tue, Feb 26, 2019 at 12:53 PM Greg Kroah-Hartman > wrote: > > > > On Sat, Feb 23, 2019 at 12:28:17PM -0800, Hyun Kwon wrote: > > > Add the dmabuf map / unmap inter

Re: [PATCH RFC 1/1] uio: Add dma-buf import ioctls

Hi Greg, Thanks for the comments. On Tue, 2019-02-26 at 03:53:11 -0800, Greg Kroah-Hartman wrote: > On Sat, Feb 23, 2019 at 12:28:17PM -0800, Hyun Kwon wrote: > > Add the dmabuf map / unmap interfaces. This allows the user driver > > to be able to import the external dmabuf and u

[PATCH RFC 1/1] uio: Add dma-buf import ioctls

Add the dmabuf map / unmap interfaces. This allows the user driver to be able to import the external dmabuf and use it from user space. Signed-off-by: Hyun Kwon --- drivers/uio/Makefile | 2 +- drivers/uio/uio.c| 43 + drivers/uio/uio_dmabuf.c | 210

[PATCH RFC 0/1] uio: Add dmabuf import ioctl

may not be available for all such devices on all platforms. So any feedback to move forward would be appreciated. Thanks, -hyun [1] https://patchwork.kernel.org/patch/10774761/ Hyun Kwon (1): uio: Add dma-buf import ioctls drivers/uio/Makefile | 2 +- drivers/uio/ui

Re: [v3,2/2] media: v4l: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem

->dev, "Err = %d Interrupt handler reg failed!\n", > + ret); > + return ret; > + } > + > + return 0; > +} > + > +static int xcsi2rxss_probe(struct platform_device *pdev) > +{ > + struct v4l2_subdev *subdev; > + struct xcsi2rxss_state *xcsi2rxss; > + struct xcsi2rxss_core *core; > + struct resource *res; > + int ret, num_ctrls, i; > + > + xcsi2rxss = devm_kzalloc(&pdev->dev, sizeof(*xcsi2rxss), GFP_KERNEL); > + if (!xcsi2rxss) > + return -ENOMEM; > + > + core = &xcsi2rxss->core; > + core->dev = &pdev->dev; > + > + mutex_init(&xcsi2rxss->lock); > + > + ret = xcsi2rxss_parse_of(xcsi2rxss); > + if (ret < 0) > + return ret; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + core->iomem = devm_ioremap_resource(core->dev, res); > + if (IS_ERR(core->iomem)) > + return PTR_ERR(core->iomem); > + > + ret = xcsi2rxss_clk_get(core); > + if (ret < 0) > + return ret; > + > + ret = xcsi2rxss_clk_enable(core); > + if (ret < 0) > + return ret; Not sure if I mentioned, please consider having these with stream on / off later. I only have minor comments, and it looks fine to me. Please take a look at those comments, then Reviewed-by: Hyun Kwon Thanks, -hyun

Re: [PATCH v2 2/2] media: v4l: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem driver

Hi Vishal, On Mon, 2019-01-28 at 03:16:49 -0800, Vishal Sagar wrote: > Hi Hyun, > > Thanks for the review. > > > -Original Message----- > > From: Hyun Kwon [mailto:hyun.k...@xilinx.com] > > Sent: Saturday, January 26, 2019 7:45 AM > > To: Vishal Saga

Re: [PATCH v2 1/2] media: dt-bindings: media: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem

Hi Vishal, Thanks for the patch. On Fri, 2019-01-25 at 09:52:56 -0800, Vishal Sagar wrote: > Add bindings documentation for Xilinx MIPI CSI-2 Rx Subsystem. > > The Xilinx MIPI CSI-2 Rx Subsystem consists of a CSI-2 Rx controller, a > DPHY in Rx mode, an optional I2C controller and a Video Format

Re: [PATCH v2 2/2] media: v4l: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem driver

Hi Vishal, Thanks for the patch. On Fri, 2019-01-25 at 09:52:57 -0800, Vishal Sagar wrote: > The Xilinx MIPI CSI-2 Rx Subsystem soft IP is used to capture images > from MIPI CSI-2 camera sensors and output AXI4-Stream video data ready > for image processing. Please refer to PG232 for details. >

Re: [PATCH] media: xilinx-video: fix bad of_node_put() on endpoint error

46 ("media: platform: Switch to > v4l2_async_notifier_add_subdev") > Cc: Steve Longerbeam > Cc: Hyun Kwon > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Signed-off-by: Akinobu Mita This looks good to me, Reviewed-by: Hyun Kwon Thanks, -hyun > --- &

Re: [PATCH v5 0/8] Add support for multi-planar formats and 10 bit formats

Hi Hans, On Tue, 2018-05-08 at 00:57:25 -0700, Hans Verkuil wrote: > On 05/07/2018 07:45 PM, Hyun Kwon wrote: > > Hi Hans, > > > > Thanks for the comment. > > > > On Mon, 2018-05-07 at 05:59:39 -0700, Hans Verkuil wrote: > >> Hi Satish, > >> &

Re: [PATCH v5 0/8] Add support for multi-planar formats and 10 bit formats

Hi Hans, Thanks for the comment. On Mon, 2018-05-07 at 05:59:39 -0700, Hans Verkuil wrote: > Hi Satish, > > On 03/05/18 04:42, Satish Kumar Nagireddy wrote: > > The patches are for xilinx v4l. The patcheset enable support to handle > > multiplanar > > formats and 10 bit formats. Single planar

Re: [PATCH v4 10/10] v4l: xilinx: dma: Add support for 10 bit formats

Hi Satish, Thanks for that patch. On Mon, 2018-04-30 at 18:35:13 -0700, Satish Kumar Nagireddy wrote: > This patch adds xvip_format_plane_width_bytes function to > calculate number of bytes for a macropixel formats and also > adds new 10 bit pixel formats to video descriptor table. > > Signed-of

Re: [PATCH v4 09/10] v4l: xilinx: dma: Add multi-planar support

On Mon, 2018-04-30 at 18:35:12 -0700, Satish Kumar Nagireddy wrote: > The current v4l driver supports single plane formats. This patch > adds support to handle multi-planar formats. Driver can handle > both single and multi-planar formats. > > Signed-off-by: Satish Kumar Nagireddy > --- > driver

Re: [PATCH v4 08/10] v4l: xilinx: dma: Update video format descriptor

Hi Satish, Thanks for the patch. On Mon, 2018-04-30 at 18:35:11 -0700, Satish Kumar Nagireddy wrote: > This patch updates video format descriptor to help information > viz., number of planes per color format and chroma sub sampling > factors. > > Signed-off-by: Satish Kumar Nagireddy > --- > d

Re: [PATCH v4 07/10] media: Add new dt-bindings/vf_codes for supported formats

On Mon, 2018-04-30 at 18:35:10 -0700, Satish Kumar Nagireddy wrote: > From: Rohit Athavale > > This commit adds new entries to the exisiting vf_codes that are used > to describe the media bus formats in the DT bindings. The newly added > 8-bit and 10-bit color depth related formats will need thes

Re: [PATCH v4 05/10] uapi: media: New fourcc codes needed by Xilinx Video IP

Hi Satish, Thanks for the patch. On Mon, 2018-04-30 at 18:35:08 -0700, Satish Kumar Nagireddy wrote: > From: Jeffrey Mouroux > > The Xilinx Video Framebuffer DMA IP supports video memory formats > that are not represented in the current V4L2 fourcc library. This > patch adds those missing fourc

Re: [PATCH v4 02/10] xilinx: v4l: dma: Use the dmaengine_terminate_all() wrapper

Hi Satish, Thanks for the patch. On Mon, 2018-04-30 at 18:35:05 -0700, Satish Kumar Nagireddy wrote: > From: Laurent Pinchart > > Calling dmaengine_device_control() to terminate transfers is an internal > API that will disappear, use the stable API wrapper instead. > > Signed-off-by: Laurent P

Re: [PATCH v3 9/9] v4l: xilinx: dma: Get scaling and padding factor to calculate DMA params

Hi Satish, Thanks for that patch. On Wed, 2018-02-14 at 22:43:00 -0800, Satish Kumar Nagireddy wrote: > Get multiplying factor to calculate bpp especially > in case of 10 bit formats. > Get multiplying factor to calculate padding width > > Signed-off-by: Satish Kumar Nagireddy > --- > drivers/

Re: [PATCH v3 8/9] v4l: xilinx: dma: Add scaling and padding factor functions

Hi Satish, Thanks for the patch. On Wed, 2018-02-14 at 22:42:50 -0800, Satish Kumar Nagireddy wrote: > scaling_factor function returns multiplying factor to calculate > bytes per component based on color format. > For eg. scaling factor of YUV420 8 bit format is 1 > so multiplying factor is 1 (8/

Re: [PATCH v3 7/9] v4l: xilinx: dma: Add multi-planar support

Hi Satish, Thanks for the patch. On Wed, 2018-02-14 at 22:42:43 -0800, Satish Kumar Nagireddy wrote: > The current v4l driver supports single plane formats. This patch > will add support to handle multi-planar formats. Updated driver > capabilities to multi-planar, where it can handle both single

Re: [PATCH v3 6/9] v4l: xilinx: dma: Update video format descriptor

On Wed, 2018-02-14 at 22:42:36 -0800, Satish Kumar Nagireddy wrote: > This patch updates video format descriptor to help information > viz., number of planes per color format and chroma sub sampling > factors. > > This commit adds the various 8-bit and 10-bit that are supported > to the table quer

Re: [PATCH v3 5/9] [media] Add documentation for YUV420 bus format

Hi Satish, Thanks for the patch. On Wed, 2018-02-14 at 22:42:28 -0800, Satish Kumar Nagireddy wrote: > The code is MEDIA_BUS_FMT_VYYUYY8_1X24 > > Signed-off-by: Satish Kumar Nagireddy > --- > Documentation/media/uapi/v4l/subdev-formats.rst | 34 > + > 1 file changed, 3

Re: [PATCH v3 3/9] uapi: media: New fourcc codes needed by Xilinx Video IP

Hi Satish, Thanks for the patch. On Wed, 2018-02-14 at 22:42:11 -0800, Satish Kumar Nagireddy wrote: > From: Jeffrey Mouroux > > The Xilinx Video Framebuffer DMA IP supports video memory formats > that are not represented in the current V4L2 fourcc library. This > patch adds those missing fourc

RE: [PATCH v2 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

aram ; > Guennadi Liakhovetski ; Maxime Coquelin > ; Alexandre Torgue > ; Benoit Parrot ; Hyun Kwon > ; Laurent Pinchart > ; Michal Simek > ; Steve Longerbeam ; > Philipp Zabel ; Greg Kroah-Hartman > ; Hans Verkuil ; Petr > Cvek ; Sakari Ailus ; Julia Lawall > ; Arnd Bergmann

RE: [patch] [media] v4l: xilinx: missing error code

Hi Dan, Thanks for the patch. > -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Wednesday, June 24, 2015 7:29 AM > To: Hyun Kwon > Cc: Laurent Pinchart; Mauro Carvalho Chehab; Michal Simek; Soren Brinkmann; > linux-media@vger.kernel