Re: [RFC PATCH 03/12] staging: android: ion: Duplicate sg_table

2017-03-03 Thread Hillf Danton
On March 03, 2017 5:45 AM Laura Abbott wrote: > > +static struct sg_table *dup_sg_table(struct sg_table *table) > +{ > + struct sg_table *new_table; > + int ret, i; > + struct scatterlist *sg, *new_sg; > + > + new_table = kzalloc(sizeof(*new_table), GFP_KERNEL); > + if (!new_

Re: [RFC 6/6] drivers: staging: ion: add ION_IOC_TAG ioctl

2016-10-11 Thread Hillf Danton
On Wednesday, October 12, 2016 7:50 AM Ruchi Kandoi wrote: > +/** > + * struct ion_fd_data - metadata passed from userspace for a handle s/fd/tag/ ? > + * @handle: a handle > + * @tag: a string describing the buffer > + * > + * For ION_IOC_TAG userspace populates the handle field with > + * the

Re: [PATCH 12/15] drivers: add Contiguous Memory Allocator

2012-02-06 Thread Hillf Danton
2012/2/5 Michal Nazarewicz : > On Sun, 05 Feb 2012 05:25:40 +0100, Hillf Danton wrote: >> >> Without boot mem reservation, what is the successful rate of CMA to >> serve requests of 1MiB, 2MiB, 4MiB and 8MiB chunks? > > > CMA will work as long as you manage to

Re: [PATCH 05/15] mm: compaction: export some of the functions

2012-02-06 Thread Hillf Danton
not ask for, part of the compaction.c >>> is now wrapped in on #ifdef. > > > On Sun, 05 Feb 2012 08:40:08 +0100, Hillf Danton wrote: >> >> What if both compaction and CMA are not enabled? > > > What about it?  If both are enabled, both will be compiled and us

Re: [PATCH 05/15] mm: compaction: export some of the functions

2012-02-04 Thread Hillf Danton
On Fri, Feb 3, 2012 at 8:18 PM, Marek Szyprowski wrote: > From: Michal Nazarewicz > > This commit exports some of the functions from compaction.c file > outside of it adding their declaration into internal.h header > file so that other mm related code can use them. > > This forced compaction.c to

Re: [PATCH 12/15] drivers: add Contiguous Memory Allocator

2012-02-04 Thread Hillf Danton
On Fri, Feb 3, 2012 at 8:18 PM, Marek Szyprowski wrote: > The Contiguous Memory Allocator is a set of helper functions for DMA > mapping framework that improves allocations of contiguous memory chunks. > > CMA grabs memory on system boot, marks it with CMA_MIGRATE_TYPE and > gives back to the syst

Re: [PATCH 08/15] mm: mmzone: MIGRATE_CMA migration type added

2012-02-04 Thread Hillf Danton
2012/2/3 Michal Nazarewicz : >>> +static inline bool migrate_async_suitable(int migratetype) > > On Fri, 03 Feb 2012 15:19:54 +0100, Hillf Danton wrote: >> >> Just nitpick, since the helper is not directly related to what async >> means, >> how about migra

Re: [PATCH 08/15] mm: mmzone: MIGRATE_CMA migration type added

2012-02-03 Thread Hillf Danton
Hello Marek On Fri, Feb 3, 2012 at 8:18 PM, Marek Szyprowski wrote: > From: Michal Nazarewicz > > The MIGRATE_CMA migration type has two main characteristics: > (i) only movable pages can be allocated from MIGRATE_CMA > pageblocks and (ii) page allocator will never change migration > type of MIG