Re: [PATCH 4.19 178/273] media: dvb: symbol fixup for dvb_attach()

2023-10-07 Thread Greg Kroah-Hartman
On Thu, Sep 28, 2023 at 01:36:06AM +0200, Ben Hutchings wrote: > On Wed, 2023-09-20 at 13:30 +0200, Greg Kroah-Hartman wrote: > > 4.19-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Gr

[PATCH 5.4 218/367] media: dvb: symbol fixup for dvb_attach()

2023-09-20 Thread Greg Kroah-Hartman
5.4-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman commit 86495af1171e1feec79faa9b64c05c89f46e41d1 upstream. In commit 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules") the use of sym

[PATCH 4.19 178/273] media: dvb: symbol fixup for dvb_attach()

2023-09-20 Thread Greg Kroah-Hartman
4.19-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman commit 86495af1171e1feec79faa9b64c05c89f46e41d1 upstream. In commit 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules") the use of sym

[PATCH 4.14 108/186] media: dvb: symbol fixup for dvb_attach()

2023-09-20 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman commit 86495af1171e1feec79faa9b64c05c89f46e41d1 upstream. In commit 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules") the use of sym

[PATCH 5.15 338/511] media: dvb: symbol fixup for dvb_attach()

2023-09-17 Thread Greg Kroah-Hartman
5.15-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman commit 86495af1171e1feec79faa9b64c05c89f46e41d1 upstream. In commit 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules") the use of sym

[PATCH 5.10 285/406] media: dvb: symbol fixup for dvb_attach()

2023-09-17 Thread Greg Kroah-Hartman
5.10-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman commit 86495af1171e1feec79faa9b64c05c89f46e41d1 upstream. In commit 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules") the use of sym

[PATCH 6.1 547/600] media: dvb: symbol fixup for dvb_attach()

2023-09-11 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman commit 86495af1171e1feec79faa9b64c05c89f46e41d1 upstream. In commit 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules") the use of sym

[PATCH 6.4 674/737] media: dvb: symbol fixup for dvb_attach()

2023-09-11 Thread Greg Kroah-Hartman
6.4-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman commit 86495af1171e1feec79faa9b64c05c89f46e41d1 upstream. In commit 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules") the use of sym

[PATCH 6.5 679/739] media: dvb: symbol fixup for dvb_attach()

2023-09-11 Thread Greg Kroah-Hartman
6.5-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman commit 86495af1171e1feec79faa9b64c05c89f46e41d1 upstream. In commit 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules") the use of sym

Re: [PATCH] staging: media: sunxi: make use of devm_platform_ioremap_resource

2019-10-08 Thread Greg Kroah-Hartman
On Tue, Oct 08, 2019 at 12:29:34PM +0530, haripra...@osuosl.org wrote: > From: Hariprasad Kelam > > fix below issue reported by coccicheck > drivers/staging//media/sunxi/cedrus/cedrus_hw.c:229:1-10: WARNING: Use > devm_platform_ioremap_resource for dev -> base > > Signed-off-by: Hariprasad Kelam

Re: [PATCH] staging/most/video: set device_caps in struct video_device

2019-06-26 Thread Greg Kroah-Hartman
On Wed, Jun 26, 2019 at 09:52:49AM +0200, Hans Verkuil wrote: > Instead of filling in the struct v4l2_capability device_caps > field, fill in the struct video_device device_caps field. > > That way the V4L2 core knows what the capabilities of the > video device are. > > Signed-off-by: Hans Verkui

Re: [PATCH 6/7] vc04_services/bcm2835-camera: set device_caps in struct video_device

2019-06-04 Thread Greg Kroah-Hartman
But this only really works if all drivers use this, so convert > this driver accordingly. > > Signed-off-by: Hans Verkuil > Cc: Greg Kroah-Hartman > Cc: Eric Anholt > --- > .../staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 6 ++ > 1 file changed, 2 inserti

Re: [PATCH RFC 1/1] uio: Add dma-buf import ioctls

2019-02-26 Thread Greg Kroah-Hartman
On Sat, Feb 23, 2019 at 12:28:17PM -0800, Hyun Kwon wrote: > Add the dmabuf map / unmap interfaces. This allows the user driver > to be able to import the external dmabuf and use it from user space. > > Signed-off-by: Hyun Kwon > --- > drivers/uio/Makefile | 2 +- > drivers/uio/uio.c

Re: [PATCH v4.4 1/1] v4l: event: Add subscription to list before calling "add" operation

2018-11-25 Thread Greg Kroah-Hartman
On Thu, Nov 08, 2018 at 01:46:32PM +0200, Sakari Ailus wrote: > [ upstream commit 92539d3eda2c090b382699bbb896d4b54e9bdece ] > > Patch ad608fbcf166 changed how events were subscribed to address an issue > elsewhere. As a side effect of that change, the "add" callback was called > before the event

Re: [PATCH v2 for v4.9 1/1] v4l: event: Add subscription to list before calling "add" operation

2018-11-25 Thread Greg Kroah-Hartman
On Wed, Nov 14, 2018 at 11:37:53AM +0200, Sakari Ailus wrote: > [ upstream commit 92539d3eda2c090b382699bbb896d4b54e9bdece ] > > Patch ad608fbcf166 changed how events were subscribed to address an issue > elsewhere. As a side effect of that change, the "add" callback was called > before the event

Re: [PATCH v2 for v4.4 1/1] v4l: event: Add subscription to list before calling "add" operation

2018-11-25 Thread Greg Kroah-Hartman
On Mon, Nov 26, 2018 at 08:27:59AM +0100, Greg Kroah-Hartman wrote: > On Thu, Nov 22, 2018 at 01:33:33PM +0200, Sakari Ailus wrote: > > On Tue, Nov 20, 2018 at 09:21:50AM -0200, Mauro Carvalho Chehab wrote: > > > Em Tue, 20 Nov 2018 12:49:46 +0200 > > > Sakari Ailus

Re: [PATCH v2 for v4.4 1/1] v4l: event: Add subscription to list before calling "add" operation

2018-11-25 Thread Greg Kroah-Hartman
On Thu, Nov 22, 2018 at 01:33:33PM +0200, Sakari Ailus wrote: > On Tue, Nov 20, 2018 at 09:21:50AM -0200, Mauro Carvalho Chehab wrote: > > Em Tue, 20 Nov 2018 12:49:46 +0200 > > Sakari Ailus escreveu: > > > > > Hi Greg, > > > > > > On Mon, Nov

Re: [PATCH v2 for v4.4 1/1] v4l: event: Add subscription to list before calling "add" operation

2018-11-19 Thread Greg Kroah-Hartman
On Mon, Nov 19, 2018 at 07:03:54PM +0200, Sakari Ailus wrote: > Hi Greg, > > On Mon, Nov 19, 2018 at 04:14:00PM +0100, Greg Kroah-Hartman wrote: > > On Wed, Nov 14, 2018 at 11:37:46AM +0200, Sakari Ailus wrote: > > > [ upstream commit 92539d3eda2c090b382699bbb896d4b54e9b

Re: [PATCH v2 for v4.4 1/1] v4l: event: Add subscription to list before calling "add" operation

2018-11-19 Thread Greg Kroah-Hartman
On Wed, Nov 14, 2018 at 11:37:46AM +0200, Sakari Ailus wrote: > [ upstream commit 92539d3eda2c090b382699bbb896d4b54e9bdece ] There is no such git commit id in Linus's tree :(

Re: [PATCH] media: staging: tegra-vde: print long unsigned using %lu format specifier

2018-11-08 Thread Greg Kroah-Hartman
On Thu, Nov 08, 2018 at 11:02:24AM +, Colin King wrote: > From: Colin Ian King > > The frame.flags & FLAG_B_FRAME is promoted to a long unsigned because > of the use of the BIT() macro when defining FLAG_B_FRAME and causing a > build warning. Fix this by using the %lu format specifer. > > Cl

Re: [PATCH 09/15] net: irda: pxaficp_ir: remove the dmaengine compat need

2018-04-23 Thread Greg Kroah-Hartman
On Mon, Apr 02, 2018 at 04:26:50PM +0200, Robert Jarzmik wrote: > As the pxa architecture switched towards the dmaengine slave map, the > old compatibility mechanism to acquire the dma requestor line number and > priority are not needed anymore. > > This patch simplifies the dma resource acquisiti

Re: [PATCH] media: staging/imx: fill vb2_v4l2_buffer sequence entry

2018-03-14 Thread Greg Kroah-Hartman
On Tue, Mar 13, 2018 at 09:00:54PM +0100, Peter Seiderer wrote: > Signed-off-by: Peter Seiderer > --- > drivers/staging/media/imx/imx-media-csi.c | 5 + > 1 file changed, 5 insertions(+) I know I don't take patches with an empty changelog description, but other maintainers might be much more

Re: [PATCH] staging: media: remove unused VIDEO_ATOMISP_OV8858 kconfig

2018-01-23 Thread Greg Kroah-Hartman
On Tue, Jan 23, 2018 at 07:31:27PM +0200, Andy Shevchenko wrote: > On Tue, Jan 23, 2018 at 4:37 PM, Corentin Labbe wrote: > > Nothing in kernel use VIDEO_ATOMISP_OV8858 since commit 3a81c7660f80 > > ("media: staging: atomisp: Remove IMX sensor support") > > Lets remove this kconfig option. > > F

Re: [PATCH/RFC 1/2] v4l: v4l2-dev: Add infrastructure to protect device unplug race

2017-11-23 Thread Greg Kroah-Hartman
On Thu, Nov 23, 2017 at 11:07:51AM -0200, Mauro Carvalho Chehab wrote: > Hi Laurent, > > Em Thu, 16 Nov 2017 02:33:48 +0200 > Laurent Pinchart escreveu: > > > Device unplug being asynchronous, it naturally races with operations > > performed by userspace through ioctls or other file operations o

Re: [PATCH] media: usbvision: remove unneeded DRIVER_LICENSE #define

2017-11-18 Thread Greg Kroah-Hartman
lho Chehab > >> wrote: > >> > Em Fri, 17 Nov 2017 15:18:26 +0100 > >> > Greg Kroah-Hartman escreveu: > >> > > >> > Its license is actually GPL 2.0+ > >> > > >> > So, I would actually change it to: > >> >

Re: [PATCH] media: usbvision: remove unneeded DRIVER_LICENSE #define

2017-11-17 Thread Greg Kroah-Hartman
On Fri, Nov 17, 2017 at 03:01:02PM -0200, Mauro Carvalho Chehab wrote: > Em Fri, 17 Nov 2017 16:01:41 +0100 > Philippe Ombredanne escreveu: > > > On Fri, Nov 17, 2017 at 3:58 PM, Mauro Carvalho Chehab > > wrote: > > > Em Fri, 17 Nov 2017 15:18:26 +0100 >

Re: [PATCH] media: usbvision: remove unneeded DRIVER_LICENSE #define

2017-11-17 Thread Greg Kroah-Hartman
On Fri, Nov 17, 2017 at 12:58:47PM -0200, Mauro Carvalho Chehab wrote: > Em Fri, 17 Nov 2017 15:18:26 +0100 > Greg Kroah-Hartman escreveu: > > > There is no need to #define the license of the driver, just put it in > > the MODULE_LICENSE() line directly as a text string.

[PATCH] media: usbvision: remove unneeded DRIVER_LICENSE #define

2017-11-17 Thread Greg Kroah-Hartman
Verkuil Cc: Mauro Carvalho Chehab Cc: Johan Hovold Cc: Davidlohr Bueso Cc: Sakari Ailus Reported-by: Philippe Ombredanne Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/usbvision/usbvision-video.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/usb

Re: [PATCH v3 1/3] staging: greybus: light: fix memory leak in v4l2 register

2017-08-17 Thread Greg Kroah-Hartman
On Thu, Aug 10, 2017 at 06:49:45PM +0300, Sakari Ailus wrote: > From: Rui Miguel Silva > > We are allocating memory for the v4l2 flash configuration structure and > leak it in the normal path. Just use the stack for this as we do not > use it outside of this function. > > Also use IS_ERR() inste

Re: [PATCH v3.2 2/3] v4l2-flash-led-class: Create separate sub-devices for indicators

2017-08-17 Thread Greg Kroah-Hartman
On Tue, Aug 15, 2017 at 02:28:11PM +0300, Sakari Ailus wrote: > The V4L2 flash interface allows controlling multiple LEDs through a single > sub-devices if, and only if, these LEDs are of different types. This > approach scales badly for flash controllers that drive multiple flash LEDs > or for LED

Re: [PATCH 00/14] gcc-7 warnings

2017-07-14 Thread Greg Kroah-Hartman
On Fri, Jul 14, 2017 at 11:25:12AM +0200, Arnd Bergmann wrote: > This series should shut up all warnings introduced by gcc-6 or gcc-7 on > today's linux-next, as observed in "allmodconfig" builds on x86, > arm and arm64. > > I have sent some of these before, but some others are new, as I had > at

Re: Lots of new warnings with gcc-7.1.1

2017-07-12 Thread Greg Kroah-Hartman
On Tue, Jul 11, 2017 at 03:35:15PM -0700, Linus Torvalds wrote: > [ Very random list of maintainers and mailing lists, at least > partially by number of warnings generated by gcc-7.1.1 that is then > correlated with the get_maintainers script ] > > So I upgraded one of my boxes to F26, which upgra

Re: [PATCH] staging: fbtft: make const array gamma_par_mask static

2017-07-11 Thread Greg Kroah-Hartman
On Tue, Jul 11, 2017 at 06:39:59PM +0100, Colin Ian King wrote: > On 11/07/17 18:30, Greg Kroah-Hartman wrote: > > On Tue, Jul 11, 2017 at 06:20:02PM +0100, Colin King wrote: > >> From: Colin Ian King > >> > >> Don't populate array gamma_par_mask on

Re: [PATCH] staging: fbtft: make const array gamma_par_mask static

2017-07-11 Thread Greg Kroah-Hartman
On Tue, Jul 11, 2017 at 06:20:02PM +0100, Colin King wrote: > From: Colin Ian King > > Don't populate array gamma_par_mask on the stack but instead make it > static. Makes the object code smaller by 148 bytes: > > Before: >text data bss dec hex filename >2993

Re: [PATCH v2 24/27] usb: gadget: u_uac1: Kill set_fs() usage

2017-06-01 Thread Greg Kroah-Hartman
On Thu, Jun 01, 2017 at 10:58:47PM +0200, Takashi Iwai wrote: > With the new API to perform the in-kernel buffer copy, we can get rid > of set_fs() usage in this driver, finally. > > Signed-off-by: Takashi Iwai > --- Acked-by: Greg Kroah-Hartman

[PATCH 08/13] staging: media: atomisp: Make undeclared symbols static

2017-05-18 Thread Greg Kroah-Hartman
From: Guru Das Srinagesh Fix sparse warnings: "symbol not declared; should it be static?" Signed-off-by: Guru Das Srinagesh Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_fops.c | 14 +++--- 1 file changed, 7 insertions(+), 7

[PATCH 10/13] staging: media: atomisp: one char read beyond end of string

2017-05-18 Thread Greg Kroah-Hartman
From: Dan Carpenter We should verify that "ix < max_len" before we test whether we have reached the NUL terminator. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Reported-by: David Binderman Signed-off-by: Dan Carpenter Signed-off

[PATCH 13/13] staging: media: atomisp: don't treat warnings as errors

2017-05-18 Thread Greg Kroah-Hartman
lho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/atomisp/i2c/Makefile | 2 -- drivers/staging/media/atomisp/i2c/imx/Makefile | 2 -- drivers/staging/media/atomisp/i2c/ov5693/Makefile | 2 -- drivers/staging/media/atomisp/pci/atomisp2/Makefile | 2 +- 4 files

[PATCH 11/13] staging: media: atomisp: putting NULs in the wrong place

2017-05-18 Thread Greg Kroah-Hartman
("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman --- .../pci/atomisp2/css2400/hive_isp_css_include/string_support.h| 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/

[PATCH 12/13] staging: media: atomisp: fix missing blank line coding style issue in atomisp_tpg.c

2017-05-18 Thread Greg Kroah-Hartman
From: Manny Vindiola This is a patch to the atomisp_tpg.c file that fixes up a missing blank line warning found by the checkpatch.pl tool Signed-off-by: Manny Vindiola Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c | 1 + 1 file changed, 1

[PATCH 09/13] staging: media: atomisp: Fix -Werror=int-in-bool-context compile errors

2017-05-18 Thread Greg Kroah-Hartman
ers this error, note we cannot do as the error suggests since b is evaluated multiple times. This commit fixes these compile errors. Signed-off-by: Hans de Goede Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c | 1 - .../pci/atomisp2

[PATCH 02/13] staging: media: atomisp: use logical AND, not bitwise

2017-05-18 Thread Greg Kroah-Hartman
From: Guru Das Srinagesh Fixes sparse warning "dubious: x & !y" in logical expression. Signed-off-by: Guru Das Srinagesh Signed-off-by: Greg Kroah-Hartman --- .../media/atomisp/pci/atomisp2/css2400/runtime/binary/src/binary.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH 06/13] staging: media: atomisp: fixed coding style errors

2017-05-18 Thread Greg Kroah-Hartman
way. Signed-off-by: Avraham Shukron Signed-off-by: Greg Kroah-Hartman --- .../platform/intel-mid/atomisp_gmin_platform.c | 156 ++--- .../platform/intel-mid/intel_mid_pcihelpers.c | 2 +- 2 files changed, 79 insertions(+), 79 deletions(-) diff --git a/drivers/staging/me

[PATCH 07/13] staging: media: atomisp: fix coding style warnings

2017-05-18 Thread Greg Kroah-Hartman
From: Avraham Shukron Fix for warnings reported by checkpatch.pl: - Multiline comment style - Bare "unsigned" - Missing blank line after declarations - Un-needed braces around single-statement branch Signed-off-by: Avraham Shukron Signed-off-by: Greg Kroah-Hartman --- .../plat

[PATCH 04/13] staging: media: atomisp: fixed sparse warnings

2017-05-18 Thread Greg Kroah-Hartman
From: Avraham Shukron Added "static" storage class to 4 not-declared functions Signed-off-by: Avraham Shukron Signed-off-by: Greg Kroah-Hartman --- .../media/atomisp/platform/intel-mid/atomisp_gmin_platform.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) dif

[PATCH 01/13] staging: media: atomisp: Add __printf validation and fix fallout

2017-05-18 Thread Greg Kroah-Hartman
From: Joe Perches __printf validation adds format and argument validation. Fix the various broken format/argument mismatches. Signed-off-by: Joe Perches Signed-off-by: Greg Kroah-Hartman --- .../isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c | 6 +++--- .../isp/kernels/sdis/sdis_2

[PATCH 00/13] staging: media: atomisp queued up patches

2017-05-18 Thread Greg Kroah-Hartman
Hi Mauro, Here's the set of accumulated atomisp staging patches that I had in my to-review mailbox. After this, my queue is empty, the driver is all yours! Good Luck! :) thanks, greg k-h Avraham Shukron (3): staging: media: atomisp: fixed sparse warnings staging: media: atomisp: fixed cod

[PATCH 05/13] staging: media: atomisp: drop unused qos variable

2017-05-18 Thread Greg Kroah-Hartman
From: Valentin Vidic Fixes a sparse warning: drivers/staging/media/atomisp/platform/intel-mid/intel_mid_pcihelpers.c:35:5: warning: symbol 'qos' was not declared. Should it be static? Signed-off-by: Valentin Vidic Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/atomis

[PATCH 03/13] staging: media: atomisp: Fix unnecessary initialization of static

2017-05-18 Thread Greg Kroah-Hartman
From: Fabrizio Perria Fix checkpatch warning: removed unnecessary initialization of static variable "skip_fwload" to 0 in source atomisp_v4l2.c Signed-off-by: Fabrizio Perria Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c | 2

Re: [PATCH] media: fix one code style problem

2017-05-12 Thread Greg Kroah-Hartman
On Fri, May 05, 2017 at 01:18:24PM -0700, Remco wrote: > From: Remco Verhoef > > this patch will fix one code style problem (ctx:WxE), space > prohibited before that Your subject needs work :) And why just one issue, is that the only place this type of problem is needed in this file? thanks,

Re: [PATCHv3 13/22] staging: android: ion: Use CMA APIs directly

2017-04-18 Thread Greg Kroah-Hartman
On Mon, Apr 03, 2017 at 11:57:55AM -0700, Laura Abbott wrote: > When CMA was first introduced, its primary use was for DMA allocation > and the only way to get CMA memory was to call dma_alloc_coherent. This > put Ion in an awkward position since there was no device structure > readily available an

Re: [PATCH] staging/media: make atomisp vlv2_plat_clock explicitly non-modular

2017-04-14 Thread Greg Kroah-Hartman
dy contained at the top of the file in the comments. > > Cc: Mauro Carvalho Chehab > Cc: Greg Kroah-Hartman > Cc: Alan Cox > Cc: linux-media@vger.kernel.org > Cc: de...@driverdev.osuosl.org > Signed-off-by: Paul Gortmaker I'm pretty sure we want this code to be built as a mo

Re: [PATCH v2 00/21] Convert USB documentation to ReST format

2017-04-11 Thread Greg Kroah-Hartman
On Tue, Apr 11, 2017 at 03:36:39PM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 11 Apr 2017 16:58:40 +0200 > Greg Kroah-Hartman escreveu: > > > On Sat, Apr 08, 2017 at 10:04:33PM +0200, Greg Kroah-Hartman wrote: > > > On Sat, Apr 08, 2017 at 11:23:28AM -0600, Jonathan Co

Re: [PATCH v2 00/21] Convert USB documentation to ReST format

2017-04-11 Thread Greg Kroah-Hartman
On Sat, Apr 08, 2017 at 10:04:33PM +0200, Greg Kroah-Hartman wrote: > On Sat, Apr 08, 2017 at 11:23:28AM -0600, Jonathan Corbet wrote: > > On Wed, 5 Apr 2017 10:22:54 -0300 > > Mauro Carvalho Chehab wrote: > > > > > Currently, there are several USB cor

Re: [PATCHv3 00/22] Ion clean up in preparation in moving out of staging

2017-04-10 Thread Greg Kroah-Hartman
On Mon, Apr 10, 2017 at 09:20:27AM -0700, Laura Abbott wrote: > On 04/08/2017 03:38 AM, Greg Kroah-Hartman wrote: > > On Mon, Apr 03, 2017 at 11:57:42AM -0700, Laura Abbott wrote: > >> Hi, > >> > >> This is v3 of the series to do some serious Ion cleanup i

Re: [PATCH v2 00/21] Convert USB documentation to ReST format

2017-04-08 Thread Greg Kroah-Hartman
On Sat, Apr 08, 2017 at 11:23:28AM -0600, Jonathan Corbet wrote: > On Wed, 5 Apr 2017 10:22:54 -0300 > Mauro Carvalho Chehab wrote: > > > Currently, there are several USB core documents that are at either > > written in plain text or in DocBook format. Convert them to ReST > > and add to the dri

Re: [PATCH] staging: media/platform/bcm2835: remove gstreamer workaround

2017-04-08 Thread Greg Kroah-Hartman
On Sun, Apr 02, 2017 at 12:48:15AM -0400, Kevin Wern wrote: > Gstreamer's v4l2src reacted poorly to certain outputs from the bcm2835 > video driver's ioctl ops function vidioc_enum_framesizes, so a > workaround was created that could be activated by user input. This > workaround would replace the d

Re: [PATCH] add blank line after declarations

2017-04-08 Thread Greg Kroah-Hartman
On Fri, Apr 07, 2017 at 08:41:11AM -0400, Manny Vindiola wrote: > Add blank line after variable declarations as part of checkpatch.pl style > fixup. > > Signed-off-by: Manny Vindiola > --- > drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c | 1 + > 1 file changed, 1 insertion(+) Your s

Re: [PATCHv3 00/22] Ion clean up in preparation in moving out of staging

2017-04-08 Thread Greg Kroah-Hartman
On Mon, Apr 03, 2017 at 11:57:42AM -0700, Laura Abbott wrote: > Hi, > > This is v3 of the series to do some serious Ion cleanup in preparation for > moving out of staging. I didn't hear much on v2 so I'm going to assume > people are okay with the series as is. I know there were still some open > q

Re: [PATCH v3] Revert "staging: radio-bcm2048: fixed bare use of unsigned int"

2017-03-29 Thread Greg Kroah-Hartman
On Mon, Mar 27, 2017 at 05:20:29PM +1100, Eddie Youseph wrote: > This reverts previous changes to checkpatch warning: > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > --- > Changes in v2: > - Added changelog > > Changes in v3: > - Revert changes to using bare unsigned I do

Re: [PATCH] staging: media: atomisp: remove ifdef around HMM_BO_ION

2017-03-24 Thread Greg Kroah-Hartman
On Fri, Mar 24, 2017 at 02:20:24PM +0100, Arnd Bergmann wrote: > The revert reintroduced a build failure without CONFIG_ION: > > media/atomisp/pci/atomisp2/hmm/hmm.c:52:2: error: excess elements in array > initializer [-Werror] > media/atomisp/pci/atomisp2/hmm/hmm.c:52:2: note: (near initializati

Re: [PATCH] staging: media: atomisp: use kvmalloc and kvfree

2017-03-23 Thread Greg Kroah-Hartman
On Thu, Mar 23, 2017 at 09:12:39PM +0800, Geliang Tang wrote: > Use kvmalloc() and kvfree() instead of open-coding. These functions are not in Linus's tree, so I can't apply this patch without breaking things :( thanks, greg k-h

Re: [PATCH v2] staging: radio-bcm2048: fixed bare use of unsigned int

2017-03-23 Thread Greg Kroah-Hartman
On Wed, Mar 22, 2017 at 01:33:39PM +1100, Eddie Youseph wrote: > Fixed checkpatch WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > > Signed-off-by: Eddie Youseph > --- > Changes in v2: > - Added changelog Did you actually build this change? Please do so... thanks, greg k-h

Re: [PATCH] bcm2048: Fix checkpatch checks

2017-02-27 Thread Greg Kroah-Hartman
On Sat, Feb 18, 2017 at 11:52:37AM +0800, Man Choy wrote: > Fix following checks: > > CHECK: Avoid crashing the kernel - try using WARN_ON & recovery code rather > than BUG() or BUG_ON() > + BUG_ON((index+2) >= BCM2048_MAX_RDS_RT); > > CHECK: spaces preferred around that '+' (ctx:VxV) > +

Re: [PATCH] Staging: media: bcm2048: Fixed an error

2017-02-12 Thread Greg Kroah-Hartman
On Sun, Feb 12, 2017 at 11:12:42PM +0200, Ran Algawi wrote: > Hello Greg, > First, I appreciate you taking the time to educate me. I used the checkpatch > script on the file I fixed and he reported the line as an error. Do you > consider all checkpatch warnings/error/checks as coding style fixes?

Re: [PATCH] staging: davinci_vpfe: fix multiline comment style

2017-02-08 Thread Greg Kroah-Hartman
On Wed, Feb 08, 2017 at 01:52:05PM +0200, Avraham Shukron wrote: > Signed-off-by: Avraham Shukron I can't take patches without a changelog text, and neither should any other maintainer... -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord

Re: [PATCH 1/6] staging: Import the BCM2835 MMAL-based V4L2 camera driver.

2017-02-06 Thread Greg Kroah-Hartman
On Sun, Feb 05, 2017 at 10:15:21PM +, Dave Stevenson wrote: > Newbie question: if this has already been merged to staging, where am I > looking for the relevant tree to add patches on top of? > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git branch > staging-next? Yes, that is

Re: [PATCH] [media] staging: bcm2835: mark all symbols as 'static'

2017-02-02 Thread Greg Kroah-Hartman
On Thu, Feb 02, 2017 at 01:11:36PM +0100, Arnd Bergmann wrote: > On Thu, Feb 2, 2017 at 1:04 PM, Arnd Bergmann wrote: > > On Thu, Feb 2, 2017 at 12:34 PM, Arnd Bergmann wrote: > >> I got a link error in allyesconfig: > >> Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera >

Re: [PATCH 2/3] Staging: media: radio-bcm2048: Fix alignment issues

2016-10-19 Thread Greg Kroah-Hartman
On Wed, Oct 19, 2016 at 08:10:25PM +0200, Jean-Baptiste Abbadie wrote: > On 19/10/16 19:51, Greg Kroah-Hartman wrote: > > I can't take a patch with no changelog text, sorry. > Hello, > > Should I add the changelog in the same thread or start a new thread ? Whole

Re: [PATCH 2/3] Staging: media: radio-bcm2048: Fix alignment issues

2016-10-19 Thread Greg Kroah-Hartman
On Wed, Oct 19, 2016 at 07:17:12PM +0200, Jean-Baptiste Abbadie wrote: > Signed-off-by: Jean-Baptiste Abbadie I can't take a patch with no changelog text, sorry. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More ma

Re: [PATCH -next] staging: media: stih-cec: remove unused including

2016-10-02 Thread Greg Kroah-Hartman
On Wed, Sep 28, 2016 at 03:13:13PM +, Wei Yongjun wrote: > From: Wei Yongjun > > Remove including that don't need it. > > Signed-off-by: Wei Yongjun > Acked-by: Benjamin Gaignard > --- > drivers/staging/media/st-cec/stih-cec.c | 1 - This file isn't in my tree, maybe it needs to go throu

Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static

2016-09-21 Thread Greg Kroah-Hartman
On Tue, Sep 20, 2016 at 06:23:33PM +0530, Sumit Semwal wrote: > Hi Baoyou, > > On 20 September 2016 at 16:43, Gustavo Padovan wrote: > > 2016-09-18 Baoyou Xie : > > > >> We get 1 warning when building kernel with W=1: > >> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for > >>

Re: [PATCH for 4.6] davinci_vpfe: Revert "staging: media: davinci_vpfe: remove,unnecessary ret variable"

2016-04-15 Thread Greg Kroah-Hartman
On Fri, Apr 15, 2016 at 01:58:10PM +0200, Hans Verkuil wrote: > This reverts commit afa5d19a2b5fbf0bbcce34f3613bce2bc9479bb7. > > This patch is completely bogus and messed up the code big time. > > I'm not sure what was intended, but this isn't it. > > Cc:

Re: [PATCH] Add tw5864 driver

2016-03-13 Thread Greg Kroah-Hartman
On Mon, Mar 14, 2016 at 03:55:14AM +0200, Andrey Utkin wrote: > From: Andrey Utkin > > Support for boards based on Techwell TW5864 chip which provides > multichannel video & audio grabbing and encoding (H.264, MJPEG, > ADPCM G.726). > > Signed-off-by: Andrey Utkin > Tested-by: Andrey Utkin Me

Re: [PATCH] Add tw5864 driver

2016-03-13 Thread Greg Kroah-Hartman
On Mon, Mar 14, 2016 at 03:55:14AM +0200, Andrey Utkin wrote: > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2333,6 +2333,7 @@ > #define PCI_VENDOR_ID_CAVIUM 0x177d > > #define PCI_VENDOR_ID_TECHWELL 0x1797 > +#define PCI_DEVICE_ID_TECHWELL_5864 0x5

Re: Failed to build on 4.2.6

2015-12-08 Thread Greg Kroah-Hartman
On Mon, Dec 07, 2015 at 10:25:19AM -0500, Steven Rostedt wrote: > Hi, > > The attached config doesn't build on 4.2.6, but changing it to the > following: > > VIDEO_V4L2_SUBDEV_API n -> y > +V4L2_FLASH_LED_CLASS n > > does build. Did this work on older kernels (4.2.5? .4? older?) thanks, gr

Re: [PATCH 03/13] serial: 8250_dma: Support for deferred probing when requesting DMA channels

2015-05-26 Thread Greg Kroah-Hartman
On Tue, May 26, 2015 at 04:25:58PM +0300, Peter Ujfalusi wrote: > Switch to use ma_request_slave_channel_compat_reason() to request the DMA > channels. In case of error, return the error code we received including > -EPROBE_DEFER I think you typed the function name wrong here :( -- To unsubscribe

Re: [PATCH] staging: media: omap4iss: Reformat overly long lines

2015-05-26 Thread Greg Kroah-Hartman
On Tue, May 26, 2015 at 10:54:18AM +0200, Piotr S. Staszewski wrote: > This reformats lines that were previously above 80 characters long, > improving readability and making checkpatch.pl happy. > > Signed-off-by: Piotr S. Staszewski > --- > drivers/staging/media/omap4iss/iss_csi2.c| 21

Re: [PATCH] radio-bcm2048: Fix region selection

2015-05-15 Thread Greg Kroah-Hartman
On Fri, May 15, 2015 at 11:32:51PM +0200, Pali Rohár wrote: > From: maxx I need a real name here, sorry. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordo

Re: [PATCH] radio-bcm2048: Enable access to automute and ctrl registers

2015-05-15 Thread Greg Kroah-Hartman
On Fri, May 15, 2015 at 11:31:51PM +0200, Pali Rohár wrote: > From: maxx Same here, real name please. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-

Re: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers()

2014-12-09 Thread &#x27;Greg Kroah-Hartman'
On Tue, Dec 09, 2014 at 05:01:35PM +0100, Sebastian Andrzej Siewior wrote: > On 12/09/2014 04:24 PM, 'Greg Kroah-Hartman' wrote: > > On Mon, Dec 08, 2014 at 09:44:05AM +, David Laight wrote: > >> From: Greg Kroah-Hartman > >>> On Fri, Dec 05, 2014 at 09:

Re: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers()

2014-12-09 Thread &#x27;Greg Kroah-Hartman'
On Mon, Dec 08, 2014 at 09:44:05AM +, David Laight wrote: > From: Greg Kroah-Hartman > > On Fri, Dec 05, 2014 at 09:03:57PM +0100, Sebastian Andrzej Siewior wrote: > > > Consider the following scenario: > > > - plugin a webcam > > > - play the stream via

Re: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers()

2014-12-05 Thread Greg Kroah-Hartman
On Sat, Dec 06, 2014 at 12:13:13AM +0100, Sebastian Andrzej Siewior wrote: > * Greg Kroah-Hartman | 2014-12-05 13:19:32 [-0800]: > > >On Fri, Dec 05, 2014 at 09:03:57PM +0100, Sebastian Andrzej Siewior wrote: > >> Consider the following scenario: > >> - plugin a web

Re: [PATCH] usb: hcd: get/put device and hcd for hcd_buffers()

2014-12-05 Thread Greg Kroah-Hartman
On Fri, Dec 05, 2014 at 09:03:57PM +0100, Sebastian Andrzej Siewior wrote: > Consider the following scenario: > - plugin a webcam > - play the stream via gst-launch-0.10 v4l2src device=/dev/video0… > - remove the USB-HCD during playback via "rmmod $HCD" > > and now wait for the crash Which you de

Re: [PATCH] staging: media: lirc: modify print calls

2014-11-05 Thread Greg Kroah-Hartman
On Wed, Nov 05, 2014 at 03:43:44PM +0200, Aya Mahfouz wrote: > On Wed, Nov 05, 2014 at 08:17:11AM -0200, Mauro Carvalho Chehab wrote: > > Em Tue, 4 Nov 2014 23:43:07 +0200 > > Aya Mahfouz escreveu: > > > > > This patches replaces one pr_debug call by dev_dbg and > > > changes the device used by o

Re: [RFC 2/4] cenalloc: Constraint-Enabled Allocation helpers for dma-buf

2014-10-10 Thread Greg Kroah-Hartman
T** > This mechanism of delayed allocation based on constraint-enablement will work > *ONLY IF* the first map_attachment() call is made AFTER all attach() calls are > done. > > Signed-off-by: Sumit Semwal > Cc: linux-ker...@vger.kernel.org > Cc: Greg Kro

Re: [PATCH v5 1/6] of: Decrement refcount of previous endpoint in of_graph_get_next_endpoint

2014-09-29 Thread Greg Kroah-Hartman
oc_camera.c | 3 ++- > drivers/of/base.c | 9 + > drivers/staging/imx-drm/imx-drm-core.c | 12 ++-- > 3 files changed, 5 insertions(+), 19 deletions(-) No objection from me for this, but Grant is in "charge" of drivers/of/base.c, so I

Re: [PATCH v4 1/8] [media] soc_camera: Do not decrement endpoint node refcount in the loop

2014-09-29 Thread Greg Kroah-Hartman
On Mon, Sep 29, 2014 at 11:45:23AM +0200, Philipp Zabel wrote: > Am Montag, den 29.09.2014, 12:13 +0300 schrieb Dan Carpenter: > > On Mon, Sep 29, 2014 at 10:15:44AM +0200, Philipp Zabel wrote: > > > In preparation for a following patch, stop decrementing the endpoint node > > > refcount in the loo

Re: [PATCH 1/1] drivers/base/dma-buf.c: replace dma_buf_uninit_debugfs by debugfs_remove_recursive

2014-07-09 Thread Greg Kroah-Hartman
On Fri, Jun 27, 2014 at 10:32:10PM +0200, Fabian Frederick wrote: > null test before debugfs_remove_recursive is not needed so one line function > dma_buf_uninit_debugfs can be removed. > > This patch calls debugfs_remove_recursive under CONFIG_DEBUG_FS > > Cc: Sumit Semwal

Re: [RFC PATCH 0/4] drivers/base: Generic framework for tracking internal interfaces

2014-04-30 Thread Greg Kroah-Hartman
On Wed, Apr 30, 2014 at 04:02:50PM +0200, Andrzej Hajda wrote: > Generic framework for tracking internal interfaces > == > > Summary > --- > > interface_tracker is a generic framework which allows to track appearance > and disappearance of diffe

Re: [PATCH] [media] Prefer gspca_sonixb over sn9c102 for all devices

2014-04-11 Thread Greg Kroah-Hartman
ehab > Cc: Luca Risolia > Cc: Greg Kroah-Hartman > --- > I consider this a bug fix, I believe it should go upstream ASAP. > Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@v

Re: [PATCH] staging: rtl2832_sdr: fixup checkpatch/style issues

2014-04-09 Thread Greg Kroah-Hartman
On Wed, Apr 09, 2014 at 08:07:28PM -0400, Anthony DeStefano wrote: > rtl2832_sdr.c: fixup checkpatch issues about long lines > > Signed-off-by: Anthony DeStefano > --- > drivers/staging/media/rtl2832u_sdr/rtl2832_sdr.c | 23 --- > 1 file changed, 16 insertions(+), 7 deletions

Re: [PATCH] staging: media: omap24xx: fix up some checkpatch.pl issues

2014-04-09 Thread Greg Kroah-Hartman
On Wed, Apr 09, 2014 at 11:25:18PM +1000, Vitaly Osipov wrote: > Fixes the following issues: > > tcm825x.c: > > ERROR: Macros with complex values should be enclosed in parenthesis > WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then > dev_info(dev, ... then pr_info(... to prin

Re: [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag

2014-03-05 Thread Greg Kroah-Hartman
On Thu, Mar 06, 2014 at 01:48:29AM +0100, Laurent Pinchart wrote: > Hi Joe, > > On Wednesday 05 March 2014 16:28:03 Joe Perches wrote: > > On Thu, 2014-03-06 at 00:50 +0100, Laurent Pinchart wrote: > > > Please note that -DDEBUG is equivalent to '#define DEBUG', not to '#define > > > CONFIG_DEBUG'

Re: [PATCH] dma-buf: avoid using IS_ERR_OR_NULL

2014-02-07 Thread Greg Kroah-Hartman
On Fri, Feb 07, 2014 at 09:22:37AM -0800, Colin Cross wrote: > On Fri, Feb 7, 2014 at 8:43 AM, Greg Kroah-Hartman > wrote: > > On Sat, Dec 21, 2013 at 07:42:17AM -0500, Rob Clark wrote: > >> On Fri, Dec 20, 2013 at 7:43 PM, Colin Cross wrote: > >> > dma_buf_ma

Re: [PATCH v3 0/2] *** SUBJECT HERE ***

2014-02-07 Thread Greg Kroah-Hartman
On Fri, Feb 07, 2014 at 06:09:46PM +0100, Jean-Francois Moine wrote: > *** BLURB HERE *** Subject and BLURB forgotten? -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/maj

Re: [PATCH] dma-buf: avoid using IS_ERR_OR_NULL

2014-02-07 Thread Greg Kroah-Hartman
On Sat, Dec 21, 2013 at 07:42:17AM -0500, Rob Clark wrote: > On Fri, Dec 20, 2013 at 7:43 PM, Colin Cross wrote: > > dma_buf_map_attachment and dma_buf_vmap can return NULL or > > ERR_PTR on a error. This encourages a common buggy pattern in > > callers: > > sgt = dma_buf_map_attachment(a

Re: Fw: [PATCH 34/52] devices.txt: add video4linux device for Software Defined Radio

2014-02-04 Thread Greg Kroah-Hartman
llocated dynamically > nowadays, but there is still configuration option for old fixed style. > Add note to mention that configuration option too. > > Cc: Hans Verkuil > Signed-off-by: Antti Palosaari > Acked-by: Hans Verkuil Acked-by: Greg Kroah-Hartman -- To unsu

Re: [PATCHv2] staging: go7007: fix use of uninitialised pointer

2013-11-25 Thread Greg Kroah-Hartman
On Mon, Nov 11, 2013 at 12:46:24PM +0100, Michal Nazarewicz wrote: > go variable is initialised only after the switch case so it cannot be > dereferenced prior to that happening. > > Signed-off-by: Michal Nazarewicz > --- > drivers/staging/media/go7007/go7007-usb.c | 8 > 1 file changed

Re: staging: media: Use dev_err() instead of pr_err()

2013-11-18 Thread Greg Kroah-Hartman
On Sun, Nov 17, 2013 at 10:03:21AM -0200, Mauro Carvalho Chehab wrote: > Em Fri, 15 Nov 2013 15:29:39 +0900 > Greg Kroah-Hartman escreveu: > > > On Thu, Nov 14, 2013 at 11:08:14AM -0200, Mauro Carvalho Chehab wrote: > > > Hi, > > > > > > I'

  1   2   >