Re: Kernel docs: muddying the waters a bit

2016-04-27 Thread Grant Likely
On Tue, Apr 12, 2016 at 4:46 PM, Jonathan Corbet wrote: > On Fri, 8 Apr 2016 17:12:27 +0200 > Markus Heiser wrote: > >> motivated by this MT, I implemented a toolchain to migrate the kernel’s >> DocBook XML documentation to reST markup. >> >> It converts 99% of the docs well ... to gain an impres

Re: [PATCH 1/1] of: Add a function to read 64-bit arrays

2014-11-04 Thread Grant Likely
On Fri, 3 Oct 2014 00:59:23 +0300 , Sakari Ailus wrote: > Implement of_property_read_u64_array() for reading 64-bit arrays. > > This is needed for e.g. reading the valid link frequencies in the smiapp > driver. > > Signed-off-by: Sakari Ailus A patch that adds this function is alread part of

Re: [PATCH/RFC v4 07/21] of: add of_node_ncmp wrapper

2014-07-28 Thread Grant Likely
On Fri, 11 Jul 2014 16:04:10 +0200, Jacek Anaszewski wrote: > The wrapper for strnicmp is required for checking whether a node has > expected prefix. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Grant Likely > Cc: Benjamin Herrenschmid

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-21 Thread Grant Likely
On Fri, 21 Mar 2014 14:16:20 +0200, Tomi Valkeinen wrote: > On 21/03/14 13:47, Grant Likely wrote: > > > I'm firm on the opinion that the checking must also happen at runtime. > > The biggest part of my objection has been how easy it would be to get a > > linkag

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-21 Thread Grant Likely
On Fri, Mar 21, 2014 at 12:44 PM, Laurent Pinchart wrote: > Hi Grant, > > On Friday 21 March 2014 08:15:34 Grant Likely wrote: >> Why don't we instead try a Google Hangout or a phone call today. >> Anywhere between 11:30 and 14:00 GMT would work for me. I'd off

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-21 Thread Grant Likely
On Fri, 21 Mar 2014 11:44:24 +0100, Andrzej Hajda wrote: > On 03/20/2014 06:23 PM, Grant Likely wrote: > > On Tue, 11 Mar 2014 14:16:37 +0100, Laurent Pinchart > > wrote: > >> On Tuesday 11 March 2014 14:59:20 Tomi Valkeinen wrote: > >>> So depending on the

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-21 Thread Grant Likely
On Fri, 21 Mar 2014 00:26:12 +0100, Laurent Pinchart wrote: > On Thursday 20 March 2014 23:12:50 Grant Likely wrote: > > On Thu, 20 Mar 2014 19:52:53 +0100, Laurent Pinchart wrote: > > > Then we might not be talking about the same thing. I'm talking about DT > >

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Thu, 20 Mar 2014 19:52:53 +0100, Laurent Pinchart wrote: > On Thursday 20 March 2014 18:48:16 Grant Likely wrote: > > On Thu, 20 Mar 2014 15:38:04 -0300, Mauro Carvalho Chehab wrote: > > > Em Thu, 20 Mar 2014 17:54:31 + Grant Likely escreveu: > > > > On W

Re: [PATCH v4 1/3] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Sat, 8 Mar 2014 13:07:23 +0100, Philipp Zabel wrote: > Hi Grant, > > On Fri, Mar 7, 2014 at 6:18 PM, Grant Likely wrote: > > On Wed, 26 Feb 2014 16:24:57 +0100, Philipp Zabel > > wrote: > >> The 'ports' node is optional. It is only needed if the par

Re: [PATCH v4 1/3] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Mon, 10 Mar 2014 08:34:54 +0200, Tomi Valkeinen wrote: > On 08/03/14 14:23, Grant Likely wrote: > > >>> That's fine. In that case the driver would specifically require the > >>> endpoint to be that one node although the above looks a little weird >

Re: [PATCH v4 1/3] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Sat, 08 Mar 2014 16:50:33 +0100, Laurent Pinchart wrote: > Hi Grant, > > On Saturday 08 March 2014 12:23:21 Grant Likely wrote: > > On Sat, 8 Mar 2014 12:46:05 +0200, Tomi Valkeinen wrote: > > > On 07/03/14 19:18, Grant Likely wrote: > > > > From a patter

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Thu, 20 Mar 2014 15:38:04 -0300, Mauro Carvalho Chehab wrote: > Em Thu, 20 Mar 2014 17:54:31 + > Grant Likely escreveu: > > > On Wed, 12 Mar 2014 10:25:56 +, Russell King - ARM Linux > > wrote: > > > On Mon, Mar 10, 2014 at 02:52:53PM +0100, Laur

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Wed, 12 Mar 2014 10:25:56 +, Russell King - ARM Linux wrote: > On Mon, Mar 10, 2014 at 02:52:53PM +0100, Laurent Pinchart wrote: > > In theory unidirectional links in DT are indeed enough. However, let's not > > forget the following. > > > > - There's no such thing as single start points

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Tue, 11 Mar 2014 16:21:49 +0100, Laurent Pinchart wrote: > Hi Philipp, > > On Tuesday 11 March 2014 16:07:00 Philipp Zabel wrote: > > Am Montag, den 10.03.2014, 14:58 +0000 schrieb Grant Likely: > > > On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: &

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Tue, 11 Mar 2014 16:07:00 +0100, Philipp Zabel wrote: > Hi Grant, > > Am Montag, den 10.03.2014, 14:58 + schrieb Grant Likely: > > On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart > > wrote: > > > On Monday 10 March 2014 12:18:20 Tomi Valkeinen wr

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Tue, 11 Mar 2014 14:04:34 +0100, Andrzej Hajda wrote: > On 03/10/2014 04:15 PM, Laurent Pinchart wrote: > > Hi Grant, > > > > On Monday 10 March 2014 14:58:15 Grant Likely wrote: > >> On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: > >>

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Tue, 11 Mar 2014 14:16:37 +0100, Laurent Pinchart wrote: > On Tuesday 11 March 2014 14:59:20 Tomi Valkeinen wrote: > > So depending on the use case, the endpoints would point to opposite > > direction from the encoder's point of view. > > > > And if I gathered Grant's opinion correctly (corre

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Tue, 11 Mar 2014 12:43:44 +0100, Laurent Pinchart wrote: > Hi Philipp, > > On Monday 10 March 2014 16:40:30 Philipp Zabel wrote: > > Am Montag, den 10.03.2014, 16:15 +0100 schrieb Laurent Pinchart: > > > On Monday 10 March 2014 14:58:15 Grant Likely wrote: > >

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-20 Thread Grant Likely
On Mon, 10 Mar 2014 16:15:37 +0100, Laurent Pinchart wrote: > Hi Grant, > > On Monday 10 March 2014 14:58:15 Grant Likely wrote: > > On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: > > > On Monday 10 March 2014 12:18:20 Tomi Valkeinen wrote: > > >

Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

2014-03-20 Thread Grant Likely
On Thu, 13 Mar 2014 11:35:28 +, Russell King - ARM Linux wrote: > On Thu, Mar 13, 2014 at 12:08:16PM +0100, Philipp Zabel wrote: > > I'm not sure if maybe I misunderstood or missed a mail, but I haven't > > seen a proposal to resolve the situation without rewinds. Given that > > Mauro already

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-10 Thread Grant Likely
On Mon, 10 Mar 2014 14:52:53 +0100, Laurent Pinchart wrote: > On Monday 10 March 2014 12:18:20 Tomi Valkeinen wrote: > > On 08/03/14 13:41, Grant Likely wrote: > > >> Ok. If we go for single directional link, the question is then: which > > >> way? And is the di

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-10 Thread Grant Likely
On Mon, 10 Mar 2014 12:18:20 +0200, Tomi Valkeinen wrote: > On 08/03/14 13:41, Grant Likely wrote: > > >> Ok. If we go for single directional link, the question is then: which > >> way? And is the direction different for display and camera, which are > >>

Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

2014-03-10 Thread Grant Likely
On Mon, 10 Mar 2014 10:26:30 -0300, Mauro Carvalho Chehab wrote: > Em Fri, 07 Mar 2014 18:23:30 + > Grant Likely escreveu: > > > On Thu, 06 Mar 2014 18:13:20 +0100, Philipp Zabel > > wrote: > > > Hi Mauro, Russell, > > > > > > I hav

Re: [PATCH v4 3/3] Documentation: of: Document graph bindings

2014-03-08 Thread Grant Likely
On Sat, 8 Mar 2014 11:35:38 +0200, Tomi Valkeinen wrote: > On 07/03/14 20:11, Grant Likely wrote: > > >>> Any board not using that port can just leave the endpoint disconnected. > >> > >> Hmm I see. I'm against that. > >> > >> I think

Re: [PATCH v4 1/3] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-08 Thread Grant Likely
On Sat, 8 Mar 2014 12:46:05 +0200, Tomi Valkeinen wrote: > On 07/03/14 19:18, Grant Likely wrote: > > > From a pattern perspective I have no problem with that From an > > individual driver binding perspective that is just dumb! It's fine for > > the port

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-08 Thread Grant Likely
On Sat, 8 Mar 2014 12:33:12 +0200, Tomi Valkeinen wrote: > On 07/03/14 19:05, Grant Likely wrote: > > On Wed, 26 Feb 2014 15:48:49 +0100, Philipp Zabel > > wrote: > >> Hi Grant, > >> > >> thank you for the comments. > > > > Hi Philipp,

Re: [PATCH v4 3/3] Documentation: of: Document graph bindings

2014-03-07 Thread Grant Likely
On Wed, 26 Feb 2014 16:50:52 +0200, Tomi Valkeinen wrote: > On 26/02/14 16:57, Philipp Zabel wrote: > > Hi Tomi, > > > > Am Mittwoch, den 26.02.2014, 15:14 +0200 schrieb Tomi Valkeinen: > >> On 25/02/14 16:58, Philipp Zabel wrote: > >> > >>> +Optional endpoint properties > >>> +-

Re: [PATCH v6 6/8] of: Implement simplified graph binding for single port devices

2014-03-07 Thread Grant Likely
On Wed, 5 Mar 2014 10:20:40 +0100, Philipp Zabel wrote: > For simple devices with only one port, it can be made implicit. > The endpoint node can be a direct child of the device node. > > Signed-off-by: Philipp Zabel Ergh... I think this is too loosely defined. The caller really should be exp

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-07 Thread Grant Likely
On Thu, 27 Feb 2014 10:36:36 +0200, Tomi Valkeinen wrote: > On 26/02/14 16:48, Philipp Zabel wrote: > > >> I would like the document to acknowledge the difference from the > >> phandle+args pattern used elsewhere and a description of when it would > >> be appropriate to use this instead of a sim

Re: [PATCH v6 2/8] Documentation: of: Document graph bindings

2014-03-07 Thread Grant Likely
On Wed, 5 Mar 2014 10:20:36 +0100, Philipp Zabel wrote: > The device tree graph bindings as used by V4L2 and documented in > Documentation/device-tree/bindings/media/video-interfaces.txt contain > generic parts that are not media specific but could be useful for any > subsystem with data flow be

Re: [PATCH v4 3/3] Documentation: of: Document graph bindings

2014-03-07 Thread Grant Likely
On Wed, 26 Feb 2014 15:14:17 +0200, Tomi Valkeinen wrote: > On 25/02/14 16:58, Philipp Zabel wrote: > > > +Optional endpoint properties > > + > > + > > +- remote-endpoint: phandle to an 'endpoint' subnode of a remote device > > node. > > Why is that optional? What u

Re: [PATCH v6 4/8] of: Reduce indentation in of_graph_get_next_endpoint

2014-03-07 Thread Grant Likely
On Wed, 5 Mar 2014 10:20:38 +0100, Philipp Zabel wrote: > A 'return endpoint;' at the end of the (!prev) case allows to > reduce the indentation level of the (prev) case. > > Signed-off-by: Philipp Zabel Acked-by: Grant Likely > ---

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-07 Thread Grant Likely
+ schrieb Grant Likely: > > On Mon, 24 Feb 2014 18:36:29 +0100, Philipp Zabel > > wrote: > > > Am Dienstag, den 18.02.2014, 16:26 + schrieb Grant Likely: > > > > > > > > > > You can find it under > > > > > Documentation/

Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of

2014-03-07 Thread Grant Likely
On Thu, 06 Mar 2014 12:17:21 -0300, Mauro Carvalho Chehab wrote: > Em Thu, 06 Mar 2014 14:16:57 + > Russell King - ARM Linux escreveu: > > > On Wed, Mar 05, 2014 at 03:42:34PM +0100, Philipp Zabel wrote: > > > Am Mittwoch, den 05.03.2014, 13:35 +0200 schrieb Tomi Valkeinen: > > > > Hi, > >

Re: [PATCH v6 5/8] [media] of: move common endpoint parsing to drivers/of

2014-03-07 Thread Grant Likely
gt; node and remote endpoint phandle. of_graph_parse_endpoint parses those > properties and is used by v4l2_of_parse_endpoint, which just adds the > V4L2 MBUS information to the containing v4l2_of_endpoint structure. > > Signed-off-by: Philipp Zabel Seems okay. Acked-by: Grant Likely

Re: [PATCH v4 1/3] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-07 Thread Grant Likely
On Wed, 26 Feb 2014 16:24:57 +0100, Philipp Zabel wrote: > Hi Grant, > > Am Mittwoch, den 26.02.2014, 11:37 + schrieb Grant Likely: > [...] > > > drivers/media/v4l2-core/v4l2-of.c | 117 > > > -- > > > drivers/of/M

Re: [PATCH v6 3/8] of: Warn if of_graph_get_next_endpoint is called with the root node

2014-03-07 Thread Grant Likely
On Wed, 5 Mar 2014 10:20:37 +0100, Philipp Zabel wrote: > If of_graph_get_next_endpoint is given a parentless node instead of an > endpoint node, it is clearly a bug. > > Signed-off-by: Philipp Zabel Acked-by: Grant Likely > --- > Changes since v5: > - Added parentles

Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of

2014-03-07 Thread Grant Likely
On Thu, 6 Mar 2014 15:50:18 +, Russell King - ARM Linux wrote: > On Thu, Mar 06, 2014 at 04:39:39PM +0100, Philipp Zabel wrote: > > Am Donnerstag, den 06.03.2014, 15:24 + schrieb Russell King - ARM > > Linux: > > > On Wed, Mar 05, 2014 at 10:20:34AM +0100, Philipp Zabel wrote: > > > > thi

Re: [GIT PULL] Move device tree graph parsing helpers to drivers/of

2014-03-07 Thread Grant Likely
On Thu, 06 Mar 2014 18:13:20 +0100, Philipp Zabel wrote: > Hi Mauro, Russell, > > I have temporarily removed the simplified bindings at Sylwester's > request and updated the branch with the acks. The following changes > since commit 0414855fdc4a40da05221fc6062cccbc0c30f169: > > Linux 3.14-rc5

Re: [PATCH v6 1/8] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-03-07 Thread Grant Likely
On Wed, 5 Mar 2014 10:20:35 +0100, Philipp Zabel wrote: > This patch moves the parsing helpers used to parse connected graphs > in the device tree, like the video interface bindings documented in > Documentation/devicetree/bindings/media/video-interfaces.txt, from > drivers/media/v4l2-core/v4l2-

Re: [PATCH v4 1/3] [media] of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-26 Thread Grant Likely
On Tue, 25 Feb 2014 15:58:22 +0100, Philipp Zabel wrote: > From: Philipp Zabel > > This patch moves the parsing helpers used to parse connected graphs > in the device tree, like the video interface bindings documented in > Documentation/devicetree/bindings/media/video-interfaces.txt, from > dri

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-26 Thread Grant Likely
On Mon, 24 Feb 2014 18:36:29 +0100, Philipp Zabel wrote: > Am Dienstag, den 18.02.2014, 16:26 + schrieb Grant Likely: > > > > > > You can find it under > > > Documentation/devicetree/bindings/media/video-interfaces.txt > > > > Okay, I think I&

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-18 Thread Grant Likely
On Tue, 18 Feb 2014 08:06:24 +0100, Sascha Hauer wrote: > Hi Grant, > > On Mon, Feb 17, 2014 at 06:14:51PM +0000, Grant Likely wrote: > > On Tue, 11 Feb 2014 07:56:33 -0600, Rob Herring > > wrote: > > > On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel > >

Re: [RFC PATCH] [media]: of: move graph helpers from drivers/media/v4l2-core to drivers/of

2014-02-17 Thread Grant Likely
On Tue, 11 Feb 2014 07:56:33 -0600, Rob Herring wrote: > On Tue, Feb 11, 2014 at 5:45 AM, Philipp Zabel wrote: > > From: Philipp Zabel > > > > This patch moves the parsing helpers used to parse connected graphs > > in the device tree, like the video interface bindings documented in > > Documenta

Re: [PATCH 22/51] DMA-API: amba: get rid of separate dma_mask

2013-09-22 Thread Grant Likely
On Thu, 19 Sep 2013 22:47:01 +0100, Russell King wrote: > AMBA Primecell devices always treat streaming and coherent DMA exactly > the same, so there's no point in having the masks separated. > > Signed-off-by: Russell King for the drivers/of/platform.c portion: Acked-by:

Re: [PATCH V3] i2c: move of helpers into the core

2013-08-28 Thread Grant Likely
gister child nodes in the core instead of doing this manually > in each driver. So, fix the drivers and documentation, too. > > Acked-by: Rob Herring > Reviewed-by: Felipe Balbi > Acked-by: Rafael J. Wysocki > Tested-by: Sylwester Nawrocki > Signed-off-by: Wolf

Re: Compilation breakage on drivers/media due to OF patches - was: Re: [PATCH] DT: export of_get_next_parent() for use by modules: fix modular V4L2

2013-04-17 Thread Grant Likely
ying before > the media tree. The fix needs to be applied to your tree then. Go ahead and apply it with my ack: Acked-by: Grant Likely It is no good to apply it to the devicetree -next branch because that will still leave your branch broken, even if device tree gets merged first. g. -- To

Re: [PATCH RFC v6] [media] Add common video interfaces OF bindings documentation

2013-04-13 Thread Grant Likely
gned-off-by: Sylwester Nawrocki > > --- > > > > Changes since v5: > > - added 'ports' node documentation > > Hi Rob, Grant, > > there was no more comments on this patch for a relatively long time > now. Would you apply it to your tree or cou

Re: [PATCH RFC 01/12] s5p-csis: Add device tree support

2012-12-11 Thread Grant Likely
On Tue, 11 Dec 2012 12:24:23 +0100, Sylwester Nawrocki wrote: > Hello Grant, > > On 12/11/2012 09:36 AM, Grant Likely wrote: > > On Mon, 10 Dec 2012 20:45:55 +0100, Sylwester Nawrocki > > wrote: > >> s5p-csis is platform device driver for MIPI-CSI frontend

Re: [PATCH RFC 06/13] of: Add empty of_find_device_by_node() function definition

2012-12-11 Thread Grant Likely
*np) > +{ > + return NULL; > +} > + > #endif /* CONFIG_OF_DEVICE */ > > #if !defined(CONFIG_OF_ADDRESS) > -- > 1.7.9.5 > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-me

Re: [PATCH RFC 05/13] of: Add empty for_each_available_child_of_node() macro definition

2012-12-11 Thread Grant Likely
hild_by_name( > const struct device_node *node, > const char *name) > -- > 1.7.9.5 > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH RFC 04/13] OF: make a function pointer argument const

2012-12-11 Thread Grant Likely
_match_string(struct > device_node *np, > return -ENOSYS; > } > > -static inline struct device_node *of_parse_phandle(struct device_node *np, > +static inline struct device_node *of_parse_phandle(const struct device_node > *np, >

Re: [PATCH RFC 03/13] OF: define of_*_cmp() macros also if CONFIG_OF isn't set

2012-12-11 Thread Grant Likely
/* flag descriptions */ > #define OF_DYNAMIC 1 /* node and properties were allocated via kmalloc */ > #define OF_DETACHED 2 /* node has been detached from the device tree */ > -- > 1.7.9.5 > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. -- To unsubscribe from

Re: [PATCH RFC 02/13] of: add a dummy inline function for when CONFIG_OF is not defined

2012-12-11 Thread Grant Likely
On Mon, 10 Dec 2012 20:41:28 +0100, Sylwester Nawrocki wrote: > From: Guennadi Liakhovetski > > If CONFIG_OF isn't defined, no declaration of of_get_parent will be found > and compilation can fail. This patch adds a dummy inline function > definition to fix the problem. Where is this function

Re: [PATCH RFC 01/13] i2c: add dummy inline functions for when CONFIG_OF_I2C(_MODULE) isn't defined

2012-12-11 Thread Grant Likely
On Mon, 10 Dec 2012 20:41:27 +0100, Sylwester Nawrocki wrote: > From: Guennadi Liakhovetski > > If CONFIG_OF_I2C and CONFIG_OF_I2C_MODULE are undefined no declaration of > of_find_i2c_device_by_node and of_find_i2c_adapter_by_node will be > available. Add dummy inline functions to avoid compila

Re: [PATCH RFC 01/12] s5p-csis: Add device tree support

2012-12-11 Thread Grant Likely
On Mon, 10 Dec 2012 20:45:55 +0100, Sylwester Nawrocki wrote: > s5p-csis is platform device driver for MIPI-CSI frontend to the FIMC > (camera host interface DMA engine and image processor). This patch > adds support for instantiating the MIPI-CSIS devices from DT and > parsing all SoC and board

Re: [PATCHv15 2/7] video: add display_timing and videomode

2012-12-06 Thread Grant Likely
On Mon, 26 Nov 2012 16:39:58 +0100, Steffen Trumtrar wrote: > On Mon, Nov 26, 2012 at 02:37:26PM +0200, Tomi Valkeinen wrote: > > On 2012-11-26 11:07, Steffen Trumtrar wrote: > > > > > +/* > > > + * Subsystem independent description of a videomode. > > > + * Can be generated from struct display_

Re: [PATCH v10 1/6] video: add display_timing and videomode

2012-11-15 Thread Grant Likely
On Thu, 15 Nov 2012 17:00:57 +0100, Laurent Pinchart wrote: > Hi Grant, > > On Thursday 15 November 2012 15:47:53 Grant Likely wrote: > > On Thu, 15 Nov 2012 10:23:52 +0100, Steffen Trumtrar wrote: > > > Add display_timing structure and the according helper function

Re: [PATCH v10 1/6] video: add display_timing and videomode

2012-11-15 Thread Grant Likely
wait... struct videomode is also a new structure. So it looks like this series creates two new intermediary data structures; display_timings and videomode. And at least as far as I can see in this series struct fb_videomode is the only user. g. -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies,

Re: [PATCH] mfd: Combine MFD_SUPPORT and MFD_CORE

2011-09-15 Thread Grant Likely
On Mon, Aug 29, 2011 at 09:41:47PM +0300, Luciano Coelho wrote: > --- > @@ -417,7 +417,6 @@ config GPIO_TIMBERDALE > config GPIO_RDC321X > tristate "RDC R-321x GPIO support" > depends on PCI > - select MFD_SUPPORT > select MFD_CORE > select MFD_RDC321X > help > di

Re: [ANN] Meeting minutes of the Cambourne meeting

2011-08-30 Thread Grant Likely
On Tue, Aug 30, 2011 at 8:03 AM, Guennadi Liakhovetski wrote: > Hi Grant > > On Tue, 30 Aug 2011, Grant Likely wrote: > >> On Tue, Aug 30, 2011 at 02:41:48PM +0100, Mark Brown wrote: >> > On Tue, Aug 30, 2011 at 12:20:09AM +0200, Guennadi Liakhovetski wrote: >>

Re: [ANN] Meeting minutes of the Cambourne meeting

2011-08-30 Thread Grant Likely
On Tue, Aug 30, 2011 at 02:41:48PM +0100, Mark Brown wrote: > On Tue, Aug 30, 2011 at 12:20:09AM +0200, Guennadi Liakhovetski wrote: > > On Mon, 29 Aug 2011, Laurent Pinchart wrote: > > > > My idea was to let the kernel register all devices based on the DT or > > > board > > > code. When the V4L

Re: [PATCH] mfd: Combine MFD_SUPPORT and MFD_CORE

2011-08-29 Thread Grant Likely
Jean Delvare > Cc: Tony Lindgren > Cc: Grant Likely > Signed-off-by: Luciano Coelho okay by me. g. > --- > > I guess this should fix the problem.  I've simple forward-ported > Randy's patch to the latest mainline kernel.  I don't know via which > tree

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-07 Thread Grant Likely
On Thu, Apr 07, 2011 at 05:03:23PM +0200, Samuel Ortiz wrote: > On Thu, Apr 07, 2011 at 07:35:15AM -0700, Grant Likely wrote: > > > Below is a patch for the Xilinx SPI example. Although this would fix the > > > issue, we'd still have to do that on device per device bas

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-07 Thread Grant Likely
On Mon, Apr 4, 2011 at 8:04 PM, Grant Likely wrote: > On Mon, Apr 04, 2011 at 12:03:15PM +0200, Samuel Ortiz wrote: >> diff --git a/include/linux/platform_device.h >> b/include/linux/platform_device.h >> index d96db98..734d254 100644 >> --- a/include/linux/platfor

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-07 Thread Grant Likely
On Thu, Apr 07, 2011 at 03:40:23PM +0200, Samuel Ortiz wrote: > Hi Felipe, > > On Wed, Apr 06, 2011 at 09:59:02PM +0300, Felipe Balbi wrote: > > Hi, > > > > On Wed, Apr 06, 2011 at 08:47:34PM +0200, Samuel Ortiz wrote: > > > > > > What is a "MFD cell pointer" and why is it needed in struct device

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-07 Thread Grant Likely
On Wed, Apr 06, 2011 at 11:38:54AM -0700, Greg KH wrote: > On Wed, Apr 06, 2011 at 11:25:57AM -0700, Andres Salomon wrote: > > > > We've been faced with the problem of being able to pass both MFD > > > > related data and a platform_data pointer to some of those drivers. > > > > Squeezing the MFD bi

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-04 Thread Grant Likely
On Mon, Apr 04, 2011 at 12:03:15PM +0200, Samuel Ortiz wrote: > On Fri, Apr 01, 2011 at 05:58:44PM -0600, Grant Likely wrote: > > On Fri, Apr 1, 2011 at 5:52 PM, Samuel Ortiz wrote: > > > On Fri, Apr 01, 2011 at 11:56:35AM -0600, Grant Likely wrote: > > >> On Fri, A

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-01 Thread Grant Likely
On Fri, Apr 1, 2011 at 5:52 PM, Samuel Ortiz wrote: > On Fri, Apr 01, 2011 at 11:56:35AM -0600, Grant Likely wrote: >> On Fri, Apr 1, 2011 at 11:47 AM, Andres Salomon wrote: >> > On Fri, 1 Apr 2011 13:20:31 +0200 >> > Samuel Ortiz wrote: >> > >> >&g

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-01 Thread Grant Likely
On Fri, Apr 1, 2011 at 11:56 AM, Grant Likely wrote: > On Fri, Apr 1, 2011 at 11:47 AM, Andres Salomon wrote: >> On Fri, 1 Apr 2011 13:20:31 +0200 >> Samuel Ortiz wrote: >> >>> Hi Grant, >>> >>> On Thu, Mar 31, 2011 at 05:05:22PM -0600, Grant Li

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-01 Thread Grant Likely
On Fri, Apr 1, 2011 at 11:47 AM, Andres Salomon wrote: > On Fri, 1 Apr 2011 13:20:31 +0200 > Samuel Ortiz wrote: > >> Hi Grant, >> >> On Thu, Mar 31, 2011 at 05:05:22PM -0600, Grant Likely wrote: > [...] >> > Gah.  Not all devices instantiated via mfd will

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-03-31 Thread Grant Likely
On Wed, Feb 02, 2011 at 08:08:12PM -0800, Andres Salomon wrote: > > No need to explicitly set the cell's platform_data/data_size. > > In this case, move the various platform_data pointers > to driver_data. All of the clients which make use of it > are also changed. > > Signed-off-by: Andres Sal

Re: [PATCH 02/15]drivers:spi:dw_spi.c Typo change diable to disable.

2010-12-30 Thread Grant Likely
On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote: > The below patch fixes a typo "diable" to "disable". Please let me know if > this > is correct or not. > > Signed-off-by: Justin P. Mattock applied, thanks. g. > > --- > drivers/spi/dw_spi.c |2 +- > 1 files changed, 1

Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

2010-06-14 Thread Grant Likely
On Mon, Jun 14, 2010 at 12:39 AM, Alexey Dobriyan wrote: > On Sun, Jun 13, 2010 at 01:57:40PM -0600, Grant Likely wrote: >> On brief review, they look like completely different issues.  I doubt >> the second patch will fix the flexcop-pci issue. > > It will, see how name wht

Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

2010-06-13 Thread Grant Likely
in their >  name". I'm not sure if this would make the flexcop-pci.c badness go >  away too. > > Anyway, both patches are not upstream yet, but Michael mentioned that > Grant Likely or Ben might push it eventually. On brief review, they look like completely different issu