izeimage field is less than the minimum
required for the given format, then an error will be returned since
drivers will typically not allow this.
===
Should we check the image size of each plane here so that we can pass
the test?
>
> > + } else {
> > + *num_planes = 1;
> > + sizes[0] = size;
> > + }
> > +
> > + dev_dbg(dev, "%s:%s:%s: n_planes(%d), n_bufs(%d), size(%d)\n",
> > + __func__, dip_pipe->desc->name,
> > + node->desc->name, *num_planes, *num_buffers, sizes[0]);
> > +
> > + return 0;
> > +}
> > +
Sincerely,
Frederic Chen
Dear Tomasz,
I'd like to elaborate more about the tuning_data.va.
Would you like to give us some advice about our improvement proposal inline?
Thank you very much.
On Wed, 2019-05-22 at 03:14 +0800, Frederic Chen wrote:
> Dear Tomasz,
>
> I appreciate your comment. It is very
Hi Shilk,
I appreciate your comments.
On Wed, 2019-05-22 at 17:51 +0800, Shik Chen wrote:
> Hi Frederic,
>
> Most reviews are already covered by Tomasz, here are some small missing
> pieces.
> Please see my comments inline.
>
> On Wed, Apr 17, 2019 at 06:45:11PM +0800
Dear Tomasz,
Thank you for your comments.
On Wed, 2019-05-22 at 19:25 +0900, Tomasz Figa wrote:
> Hi Frederic,
>
> On Wed, May 22, 2019 at 03:14:15AM +0800, Frederic Chen wrote:
> > Dear Tomasz,
> >
> > I appreciate your comment. It is very helpful for us.
> >
Dear Rob,
I appreciate your comments.
On Mon, 2019-04-29 at 20:15 -0500, Rob Herring wrote:
> On Wed, Apr 17, 2019 at 06:45:06PM +0800, Frederic Chen wrote:
> > This patch adds the binding for describing the shared memory
> > used to exchange configuration and tuning data bet
Dear Rob,
I appreciate your comments.
On Mon, 2019-04-29 at 20:16 -0500, Rob Herring wrote:
> On Wed, Apr 17, 2019 at 06:45:08PM +0800, Frederic Chen wrote:
> > This patch adds DT binding documentation for the Digital Image
> > Processing (DIP) unit of camera ISP system on
), sensor interface driver, DIP driver and
face detection driver.
Signed-off-by: Frederic Chen
---
drivers/media/platform/mtk-isp/Makefile | 18 +
.../media/platform/mtk-isp/isp_50/Makefile| 17 +
.../platform/mtk-isp/isp_50/dip/Makefile | 32 +
.../mtk-isp/isp_50/dip/mtk_dip
This patch adds nodes for Digital Image Processing (DIP). DIP is
embedded in Mediatek SoCs and works with the co-processor to
adjust image content according to tuning input data. It also
provides image format conversion, resizing, and rotation
features.
Signed-off-by: Frederic Chen
---
arch
This patch adds DT binding documentation for the Digital Image
Processing (DIP) unit of camera ISP system on Mediatek's SoCs.
Signed-off-by: Frederic Chen
---
.../bindings/media/mediatek,mt8183-dip.txt| 35 +++
1 file changed, 35 insertions(+)
create mode 1
Hello,
This RFC patch series adding Digital Image Processing (DIP) driver on
Mediatek mt8183 SoC. It belongs to the Mediatek's ISP driver series based
on V4L2 and media controller framework. I posted the main part of the DIP
driver as RFC to discuss first and would like some review comments.
This patch adds KConfig for Mediatek Digital Image Processing
driver(DIP). DIP is embedded in Mediatek SoCs. It provides
image format conversion, resizing, and rotation function.
Signed-off-by: Frederic Chen
---
drivers/media/platform/Kconfig | 2 ++
drivers/media/platform/mtk-isp
This patch adds the binding for describing the shared memory
used to exchange configuration and tuning data between the
co-processor and Digital Image Processing (DIP) unit of the
camera ISP system on Mediatek SoCs.
Signed-off-by: Frederic Chen
---
.../mediatek,reserve-memory-dip_smem.txt
This patch adds a shared memory region used on mt8183 for
exchanging tuning data between co-processor and
Digital Image Processing(DIP) unit.
Signed-off-by: Frederic Chen
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 13 +
1 file changed, 13 insertions(+)
diff --git a/arch/arm64
Dear Brian,
I appreciate your comments.
On Wed, 2019-02-27 at 19:24 -0800, Brian Norris wrote:
> Hi Frederic,
>
> On Sat, Feb 23, 2019 at 02:18:54PM +0800, Frederic Chen wrote:
> > Dear Brian,
> >
> > I appreciate your comments. I'm really sorry for the delay i
2019-02-07 at 11:08 -0800, Brian Norris wrote:
> > Hi,
> >
> > On Fri, Feb 01, 2019 at 07:21:31PM +0800, Frederic Chen wrote:
> > > This patch adds the driver of Digital Image Processing (DIP)
> > > unit in Mediatek ISP system, providing image format
tree list, please?
> >
> > On Fri, Feb 01, 2019 at 07:21:27PM +0800, Frederic Chen wrote:
> > > This patch adds the DT binding documentation for the shared memory
> > > between DIP (Digital Image Processing) unit of the camera ISP system
> > > an
Feb 01, 2019 at 07:21:25PM +0800, Frederic Chen wrote:
> > > This patch adds the binding for describing the shared memory
> > > used to exchange configuration and tuning data between the
> > > co-processor and Digital Image Processing (DIP) unit of the
> > > cam
From: Jungo Lin
This patch adds the DT binding documentation for the shared memory
between Pass 1 unit of the camera ISP system and the co-processor
in Mediatek SoCs.
Signed-off-by: Jungo Lin
Signed-off-by: Frederic Chen
---
.../bindings/media/mediatek,cam_smem.txt | 32
This patch adds the binding for describing the shared memory
used to exchange configuration and tuning data between the
co-processor and Pass 1 (P1) unit of the camera ISP system on
Mediatek SoCs.
Signed-off-by: Frederic Chen
---
.../mediatek,reserve-memory-cam_smem.txt | 44
ry region for the co-processor and
Pass 1 unit to exchange the tuning and configuration data.
Frederic Chen (2):
[media] dt-bindings: mt8183: Add binding for ISP Pass 1 shared memory
media: platform: Add Mediatek ISP Pass 1 driver KConfig
Jungo Lin (5):
dts: arm64: mt8183: Add ISP Pass
From: Jungo Lin
Add nodes for Pass 1 unit of Mediatek's camera ISP system.
Pass 1 unit embedded in Mediatek SOCs, works with the
co-processor to process image signal from the image sensor
and output RAW data.
Signed-off-by: Jungo Lin
Signed-off-by: Frederic Chen
---
arch/arm64/boo
ff-by: Frederic Chen
---
drivers/media/platform/Kconfig | 2 ++
drivers/media/platform/mtk-isp/Kconfig | 21 +
2 files changed, 23 insertions(+)
create mode 100644 drivers/media/platform/mtk-isp/Kconfig
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kc
From: Jungo Lin
This patch adds DT binding document for the Pass 1 (P1) unit in
Mediatek's camera ISP system. The Pass 1 unit grabs the sensor data
out from the sensor interface, applies ISP effects and writes the
image data to DRAM.
Signed-off-by: Jungo Lin
Signed-off-by: Frederic
From: Jungo Lin
This patch adds a shared memory region used on mt8183 for
exchanging tuning data between co-processor and the
Pass 1 unit of the camera ISP system
Signed-off-by: Jungo Lin
Signed-off-by: Frederic Chen
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 14 ++
1 file
This patch adds the DT binding documentation for the shared memory
between DIP (Digital Image Processing) unit of the camera ISP system
and the co-processor in Mediatek SoCs.
Signed-off-by: Frederic Chen
---
.../bindings/media/mediatek,dip_smem.txt | 29 ++
1 file
This patch adds a shared memory region used on mt8183 for
exchanging tuning data between co-processor and
Digital Image Processing (DIP) unit.
Signed-off-by: Frederic Chen
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 13 +
1 file changed, 13 insertions(+)
diff --git a/arch/arm64
This patch adds DT binding documentation for the Digital Image
Processing (DIP) unit of camera ISP system on Mediatek’s SoCs.
Signed-off-by: Frederic Chen
---
.../bindings/media/mediatek,mt8183-dip.txt | 35 ++
1 file changed, 35 insertions(+)
create mode 100644
This patch adds KConfig for Mediatek Digital Image Processing
driver (DIP). DIP is embedded in Mediatek SoCs. It can provide
image format conversion, resizing, and rotation function.
Signed-off-by: Frederic Chen
---
drivers/media/platform/Kconfig | 2 ++
drivers/media/platform/mtk-isp
and DIP to exchange the
tuning and hardware configuration data.
* mtk_dip-v4l2-util.c: Implements V4L2 and vb2 ops.
Frederic Chen (7):
[media] dt-bindings: mt8183: Add binding for DIP shared memory
dts: arm64: mt8183: Add DIP shared memory node
[media] dt-bindings: mt8183: Added DIP-SMEM
This patch adds the binding for describing the shared memory
used to exchange configuration and tuning data between the
co-processor and Digital Image Processing (DIP) unit of the
camera ISP system on Mediatek SoCs.
Signed-off-by: Frederic Chen
---
.../mediatek,reserve-memory-dip_smem.txt
This patch adds nodes for Digital Image Processing (DIP). DIP is
embedded in Mediatek SoCs and works with the co-processor to
adjust image content according to tuning input data. It also provides
image format conversion, resizing, and rotation features.
Signed-off-by: Frederic Chen
---
arch
31 matches
Mail list logo
