Re: The potential uninitialized variables used in function isc_interrupt()

2019-10-04 Thread Eugen.Hristev
On 04.10.2019 06:07, Yizhuo Zhai wrote: > Hi Eugen: > > In function isc_interrupt(), variable "isc_intsr" and "isc_intmask" > (drivers/media/platform/atmel/atmel-isc-base.c) > could be uninitialized if regmap_read() fails and return -EINVAL . > However, they are used to decide the control flow l

Re: [ANN] Media sessions in Lyon in October: codecs

2019-09-27 Thread Eugen.Hristev
On 23.09.2019 17:12, Hans Verkuil wrote: > Hi all, > > Since we have three separate half-day sessions for different topics I decided > to split the announcement for this in three emails as well, so these things > can be discussed in separate threads. > > All sessions are in room Terreaux VIP Lo

Re: [ANN] Topics for a media summit in Lyon in October

2019-08-19 Thread Eugen.Hristev
On 19.08.2019 18:04, Laurent Pinchart wrote: > Hello, > > On Mon, Aug 19, 2019 at 11:43:56AM -0300, Ezequiel Garcia wrote: >> On Mon, 2019-08-19 at 09:44 +0200, Hans Verkuil wrote: >>> On 8/16/19 10:06 AM, Hans Verkuil wrote: Rather then discussing topics for a meeting under the subject 'Li

Re: Issues with ov5640 camera on i.MX6Q

2019-07-23 Thread Eugen.Hristev
On 22.07.2019 19:25, Eric Nelson wrote: > Hi Laura, > > On 7/22/19 8:50 AM, Laura Nao wrote: >> Thanks Fabio! >> >> I tried tweaking the PLL configuration in the driver and did some >> further tests on 5.2 kernel. >> >> I was finally able to capture RAW frames that match the test pattern >> fo

Re: [GIT PULL FOR v5.3] atmel-isc and coda enhancements

2019-05-02 Thread Eugen.Hristev
Hello Hans, Would be great if you could at least get this into 5.2 : media: atmel: atmel-isc: make try_fmt error less verbose I noticed several sensor drivers act in a way that makes this message appear a lot, when the sensors actually work fine. They just return errors in try_fmt if the forma

Re: [PATCH 0/2] media: ov7670: fix regressions caused by "hook s_power onto v4l2 core"

2019-03-19 Thread Eugen.Hristev
On 13.03.2019 23:05, Sakari Ailus wrote: > On Tue, Mar 12, 2019 at 06:16:08PM +0100, Lubomir Rintel wrote: >> On Tue, 2019-03-12 at 00:36 +0900, Akinobu Mita wrote: >>> This patchset fixes the problems introduced by recent change to ov7670. >>> >>> Akinobu Mita (2): >>>media: ov7670: restore

Re: Issues with ov5640 sensor

2019-02-27 Thread Eugen.Hristev
On 13.02.2019 10:51, Loic Poulain wrote: > Hi Eugen, > > On Wed, 13 Feb 2019 at 09:02, wrote: >> >> Hello Loic, >> >> I am trying to make sensor Omnivision ov5640 work with our Atmel-isc >> controller, I saw you implemented RAW mode for this sensor in the >> driver, so I was hoping I can ask yo

Re: [PATCH] media: ov7740: fix runtime pm initialization

2019-02-18 Thread Eugen.Hristev
On 17.02.2019 17:17, Akinobu Mita wrote: > The runtime PM of this device is enabled after v4l2_ctrl_handler_setup(), > and this makes this device's runtime PM usage count a negative value. > > The ov7740_set_ctrl() tries to do something only if the device's runtime > PM usage counter is nonzero.

[PATCH] media: atmel: atmel-isc: reworked driver and formats

2019-02-15 Thread Eugen.Hristev
From: Eugen Hristev This change is a redesign in the formats and the way the ISC is configured w.r.t. sensor format and the output format from the ISC. I have changed the splitting between sensor output (which is also ISC input) and ISC output. The sensor format represents the way the sensor is c

Issues with ov5640 sensor

2019-02-13 Thread Eugen.Hristev
Hello Loic, I am trying to make sensor Omnivision ov5640 work with our Atmel-isc controller, I saw you implemented RAW mode for this sensor in the driver, so I was hoping I can ask you some things: I cannot make the RAW bayer format work, BA81 / mbus MEDIA_BUS_FMT_SBGGR8_1X8 makes the photo lo

Re: [PATCH v2 2/2] media: atmel-isc: Update device tree binding documentation

2019-01-20 Thread Eugen.Hristev
On 18.01.2019 20:05, Ken Sloat wrote: >> -Original Message- >> From: eugen.hris...@microchip.com >> Sent: Friday, January 18, 2019 9:40 AM >> To: Ken Sloat >> Cc: mche...@kernel.org; nicolas.fe...@microchip.com; >> alexandre.bell...@bootlin.com; ludovic.desroc...@microchip.com; linux- >

Re: [PATCH v2 2/2] media: atmel-isc: Update device tree binding documentation

2019-01-18 Thread Eugen.Hristev
On 18.01.2019 16:28, Ken Sloat wrote: > From: Ken Sloat > > Update device tree binding documentation specifying how to > enable BT656 with CRC decoding. > > Signed-off-by: Ken Sloat > --- > Changes in v2: > -Use correct media "bus-type" dt property. > > Documentation/devicetree/bindi

Re: [V3, 3/4] Documentation: dt-bindings: media: Document bindings for DW MIPI CSI-2 Host

2019-01-11 Thread Eugen.Hristev
On 19.10.2018 15:52, Luis Oliveira wrote: > Add bindings for Synopsys DesignWare MIPI CSI-2 host. > > Signed-off-by: Luis Oliveira > --- > Changelog > v2-V3 > - removed IPI settings > > .../devicetree/bindings/media/snps,dw-csi-plat.txt | 52 > ++ > 1 file changed, 52 i

Re: [V3, 4/4] media: platform: dwc: Add MIPI CSI-2 controller driver

2019-01-11 Thread Eugen.Hristev
On 11.01.2019 10:11, Luis de Oliveira wrote: > > > On 11-Jan-19 7:25, eugen.hris...@microchip.com wrote: >> >> >> On 10.01.2019 18:18, Luis de Oliveira wrote: >>> >>> >>> On 09-Jan-19 13:07, eugen.hris...@microchip.com wrote: On 19.10.2018 15:52, Luis Oliveira wrote: > Add th

Re: [V3, 4/4] media: platform: dwc: Add MIPI CSI-2 controller driver

2019-01-10 Thread Eugen.Hristev
On 10.01.2019 18:18, Luis de Oliveira wrote: > > > On 09-Jan-19 13:07, eugen.hris...@microchip.com wrote: >> >> >> On 19.10.2018 15:52, Luis Oliveira wrote: >>> Add the Synopsys MIPI CSI-2 controller driver. This >>> controller driver is divided in platform dependent functions >>> and core func

Re: [V3, 4/4] media: platform: dwc: Add MIPI CSI-2 controller driver

2019-01-09 Thread Eugen.Hristev
On 19.10.2018 15:52, Luis Oliveira wrote: > Add the Synopsys MIPI CSI-2 controller driver. This > controller driver is divided in platform dependent functions > and core functions. It also includes a platform for future > DesignWare drivers. > > Signed-off-by: Luis Oliveira > --- > Changelog >

Re: [PATCH v1 2/2] media: atmel-isc: Update device tree binding documentation

2019-01-07 Thread Eugen.Hristev
On 28.12.2018 18:59, Ken Sloat wrote: > From: Ken Sloat > > Update device tree binding documentation specifying how to > enable BT656 with CRC decoding. > > Signed-off-by: Ken Sloat Acked-by: Eugen Hristev > --- > Documentation/devicetree/bindings/media/atmel-isc.txt | 3 +++ > 1 file ch

Re: [PATCH v1 1/2] media: atmel-isc: Add support for BT656 with CRC decoding

2019-01-07 Thread Eugen.Hristev
On 28.12.2018 18:59, Ken Sloat wrote: > From: Ken Sloat > > The ISC driver currently supports ITU-R 601 encoding which > utilizes the external hysync and vsync signals. ITU-R 656 > format removes the need for these pins by embedding the > sync pulses within the data packet. > > To support this

Re: [V3, 4/4] media: platform: dwc: Add MIPI CSI-2 controller driver

2018-12-10 Thread Eugen.Hristev
On 19.10.2018 15:52, Luis Oliveira wrote: > Add the Synopsys MIPI CSI-2 controller driver. This > controller driver is divided in platform dependent functions > and core functions. It also includes a platform for future > DesignWare drivers. > > Signed-off-by: Luis Oliveira > --- > Changelog >

Re: [PATCH v1 1/1] media: atmel-isc: Add safety checks for NULL isc->raw_fmt struct

2018-11-23 Thread Eugen.Hristev
On 21.11.2018 16:50, Ken Sloat wrote: >>> From: Ken Sloat >>> >>> In some usages isc->raw_fmt will not be initialized. If this is the >>> case, it is very possible that a NULL struct de-reference will occur, >>> as this member is referenced many times. > >> Hello Ken, > >> Do you have any con

Re: [PATCH v1 1/1] media: atmel-isc: Add safety checks for NULL isc->raw_fmt struct

2018-11-20 Thread Eugen.Hristev
On 20.11.2018 22:43, Ken Sloat wrote: > From: Ken Sloat > > In some usages isc->raw_fmt will not be initialized. If this > is the case, it is very possible that a NULL struct de-reference > will occur, as this member is referenced many times. Hello Ken, Do you have any confidence that just b

Re: MICROCHIP ISC DRIVER Bug: Possible NULL struct pointer dereference case

2018-11-19 Thread Eugen.Hristev
On 20.11.2018 01:06, Ken Sloat wrote: > Hello, > > I have discovered a bug in the Atmel/Microchip ISC driver while developing a > i2c v4l2 sub-device driver. This bug did not previously occur for me on an > older version of the driver (more details below), but I have confirmed this > bug on a