Re: [Intel-gfx] [PATCH 01/17] dma-fence: Some kerneldoc polish for dma-fence.h

2018-04-30 Thread Eric Anholt
' in between. Other than that, Reviewed-by: Eric Anholt Thanks! signature.asc Description: PGP signature

Re: [PATCH v3 2/4] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

2017-11-21 Thread Eric Anholt
Rob Herring writes: > On Tue, Nov 21, 2017 at 1:26 PM, Eric Anholt wrote: >> Dave Stevenson writes: >> >>> Hi Rob >>> >>> On 27 September 2017 at 22:51, Rob Herring wrote: >>>> On Fri, Sep 22, 2017 at 05:07:22PM +0100, Dave Stevenson wrot

Re: [PATCH v3 2/4] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

2017-11-21 Thread Eric Anholt
Dave Stevenson writes: > Hi Rob > > On 27 September 2017 at 22:51, Rob Herring wrote: >> On Fri, Sep 22, 2017 at 05:07:22PM +0100, Dave Stevenson wrote: >>> Hi Stefan >>> >>> On 22 September 2017 at 07:45, Stefan Wahren wrote: >>> > Hi Dave, >>> > >>> >> Dave Stevenson hat am 20. September >>

Re: [PATCH v3 2/4] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

2017-09-22 Thread Eric Anholt
Dave Stevenson writes: > Hi Stefan > > On 22 September 2017 at 07:45, Stefan Wahren wrote: >> Hi Dave, >> >>> Dave Stevenson hat am 20. September 2017 >>> um 18:07 geschrieben: >>> >>> >>> Document the DT bindings for the CSI2/CCP2 receiver peripheral >>> (known as Unicam) on BCM283x SoCs. >>>

Re: [PATCH v2 3/4] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-09-18 Thread Eric Anholt
Dave Stevenson writes: > diff --git a/drivers/media/platform/bcm2835/bcm2835-unicam.c > b/drivers/media/platform/bcm2835/bcm2835-unicam.c > new file mode 100644 > index 000..5b1adc3 > --- /dev/null > +++ b/drivers/media/platform/bcm2835/bcm2835-unicam.c > @@ -0,0 +1,2192 @@ > +/* > + * BCM283

Re: [PATCHv2 3/3] drm/vc4: add HDMI CEC support

2017-07-26 Thread Eric Anholt
Hans Verkuil writes: > Hi Eric, > > On 16/07/17 12:48, Hans Verkuil wrote: >> From: Hans Verkuil >> >> This patch adds support to VC4 for CEC. >> >> Thanks to Eric Anholt for providing me with the CEC register information. >> >> To prevent t

Re: [PATCH 4/4] drm/vc4: add HDMI CEC support

2017-07-18 Thread Eric Anholt
Hans Verkuil writes: > On 12/07/17 21:43, Hans Verkuil wrote: >> On 12/07/17 21:02, Eric Anholt wrote: >>>> +static int vc4_hdmi_cec_adap_transmit(struct cec_adapter *adap, u8 >>>> attempts, >>>> +u32 signal_free_time

Re: [PATCH 4/4] drm/vc4: add HDMI CEC support

2017-07-12 Thread Eric Anholt
Hans Verkuil writes: > From: Hans Verkuil > > This patch adds support to VC4 for CEC. > > To prevent the firmware from eating the CEC interrupts you need to add this to > your config.txt: > > mask_gpu_interrupt1=0x100 > > Signed-off-by: Hans Verkuil This looks pretty great. Just a couple of l

Re: [PATCH 2/4] drm/vc4: prepare for CEC support

2017-07-12 Thread Eric Anholt
Hans Verkuil writes: > From: Hans Verkuil > > In order to support CEC the hsm clock needs to be enabled in > vc4_hdmi_bind(), not in vc4_hdmi_encoder_enable(). Otherwise you wouldn't > be able to support CEC when there is no hotplug detect signal, which is > required by some monitors that turn o

Re: [PATCH 3/4] drm/vc4: Add register defines for CEC.

2017-07-12 Thread Eric Anholt
Hans Verkuil writes: > From: Eric Anholt > > Basic usage: > > poweron: HSM clock should be running. Set the bit clock divider, > set all the other _US timeouts based on bit clock rate. Bring RX/TX > reset up and then down. > > powerdown: Set RX/TX reset. > >

Re: [PATCH v2 0/2] rcar-du, vsp1: rcar-gen3: Add support for colorkey alpha blending

2017-05-08 Thread Eric Anholt
Alexandru Gheorghe writes: > Currently, rcar-du supports colorkeying only for rcar-gen2 and it uses > some hw capability of the display unit(DU) which is not available on gen3. > In order to implement colorkeying for gen3 we need to use the colorkey > capability of the VSPD, hence the need to c

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-17 Thread Eric Anholt
Mauro Carvalho Chehab writes: > Em Wed, 15 Mar 2017 18:46:24 -0700 > Michael Zoran escreveu: > >> On Wed, 2017-03-15 at 22:08 -0300, Mauro Carvalho Chehab wrote: >> >> > No, I didn't. Thanks! Applied it but, unfortunately, didn't work. >> > Perhaps I'm missing some other patch. I'm compiling it

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-15 Thread Eric Anholt
Mauro Carvalho Chehab writes: > Em Fri, 27 Jan 2017 13:54:57 -0800 > Eric Anholt escreveu: > >> Here's my first pass at importing the camera driver. There's a bunch >> of TODO left to it, most of which is documented, and the rest being >> standard checkpat

Re: [PATCH 6/6] staging: bcm2835-v4l2: Apply spelling fixes from checkpatch.

2017-01-31 Thread Eric Anholt
Joe Perches writes: > On Mon, 2017-01-30 at 12:05 -0800, Eric Anholt wrote: >> Joe Perches writes: >> >> > On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote: >> > > Generated with checkpatch.pl --fix-inplace and git add -p out of the >

Re: [PATCH 6/6] staging: bcm2835-v4l2: Apply spelling fixes from checkpatch.

2017-01-30 Thread Eric Anholt
Joe Perches writes: > On Fri, 2017-01-27 at 13:55 -0800, Eric Anholt wrote: >> Generated with checkpatch.pl --fix-inplace and git add -p out of the >> results. > > Maybe another. > >> diff --git a/drivers/staging/media/platform/bcm2835/mmal-vchiq.c >> b/dr

[PATCH 5/6] staging: bcm2835-v4l2: Apply many whitespace fixes from checkpatch.

2017-01-27 Thread Eric Anholt
: Eric Anholt --- .../media/platform/bcm2835/bcm2835-camera.c| 90 drivers/staging/media/platform/bcm2835/controls.c | 236 ++--- .../staging/media/platform/bcm2835/mmal-vchiq.c| 13 +- 3 files changed, 167 insertions(+), 172 deletions(-) diff --git a

[PATCH 6/6] staging: bcm2835-v4l2: Apply spelling fixes from checkpatch.

2017-01-27 Thread Eric Anholt
Generated with checkpatch.pl --fix-inplace and git add -p out of the results. Signed-off-by: Eric Anholt --- drivers/staging/media/platform/bcm2835/bcm2835-camera.c | 6 +++--- drivers/staging/media/platform/bcm2835/mmal-vchiq.c | 12 ++-- 2 files changed, 9 insertions(+), 9

[PATCH 4/6] staging: bcm2835-v4l2: Add a TODO file for improvements we need.

2017-01-27 Thread Eric Anholt
Signed-off-by: Eric Anholt --- drivers/staging/media/platform/bcm2835/TODO | 39 + 1 file changed, 39 insertions(+) create mode 100644 drivers/staging/media/platform/bcm2835/TODO diff --git a/drivers/staging/media/platform/bcm2835/TODO b/drivers/staging/media

[PATCH 3/6] staging: bcm2835-v4l2: Add a build system for the module.

2017-01-27 Thread Eric Anholt
This is derived from the downstream tree's build system, but with just a single Kconfig option. For now the driver only builds on 32-bit arm -- the aarch64 build breaks due to the driver using arm-specific cache flushing functions. Signed-off-by: Eric Anholt --- drivers/staging/media/Kc

[PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-01-27 Thread Eric Anholt
he driver to the current VCHI API" patch will conflict with the outstanding "Add vchi_queue_kernel_message and vchi_queue_user_message" series, but the fix should be pretty obvious when that lands. I built this against 4.10-rc1, but a merge with staging-next was clean and still built fine

[PATCH 2/6] staging: bcm2835-v4l2: Update the driver to the current VCHI API.

2017-01-27 Thread Eric Anholt
49bec49fd7f2 ("staging: vc04_services: remove vchiq_copy_from_user") removed the flags/msg_handle arguments, which were unused, and pushed the implementation of copying using memcpy vs copy_from_user to the caller. Signed-off-by: Eric Anholt --- drivers/staging/media/platform/bc

Re: [RFC PATCH 00/11] Introduce writeback connectors

2016-10-13 Thread Eric Anholt
Brian Starkey writes: > Hi Eric, > > On Tue, Oct 11, 2016 at 12:01:14PM -0700, Eric Anholt wrote: >>Brian Starkey writes: >> >>> Hi, >>> >>> This RFC series introduces a new connector type: >>> DRM_MODE_CONNECTOR_WRITEBACK >>> I

Re: [RFC PATCH 00/11] Introduce writeback connectors

2016-10-11 Thread Eric Anholt
Brian Starkey writes: > Hi, > > This RFC series introduces a new connector type: > DRM_MODE_CONNECTOR_WRITEBACK > It is a follow-on from a previous discussion: [1] > > Writeback connectors are used to expose the memory writeback engines > found in some display controllers, which can write a CRTC

Re: DRM device memory writeback (Mali-DP)

2016-07-15 Thread Eric Anholt
Ville Syrjälä writes: > On Fri, Jul 15, 2016 at 10:09:19AM +0100, Brian Starkey wrote: >> Hi Daniel, >> >> Thanks for taking a look. >> >> (+Cc Laurent) >> >> On Fri, Jul 15, 2016 at 09:33:34AM +0200, Daniel Vetter wrote: >> >On Thu, Jul 14, 2016 at 06:03:40PM +0100, Brian Starkey wrote: >> >>