[PATCH v2 2/2] uvc: Add 12-bit raw bayer linear packed formats

2019-07-07 Thread Edgar Thier
These formats are compressed 12-bit raw bayer formats with four different pixel orders. The pixel follow one another without any padding, thus are packed in a 'linear' fashion. Signed-off-by: Edgar Thier --- drivers/media/usb/uvc/uvc_driver.c | 21 - drivers/med

[PATCH v2 1/2] v4l: Add 12-bit raw bayer linear packed formats

2019-07-07 Thread Edgar Thier
These formats are compressed 12-bit raw bayer formats with four different pixel orders. The pixel follow one another without any padding, thus are packed in a 'linear' fashion. Signed-off-by: Edgar Thier --- Documentation/media/uapi/v4l/pixfmt-rgb.rst | 1 + .../media/uapi/

[PATCH 2/2] uvc: Add 12-bit raw bayer linear packed formats

2019-07-05 Thread Edgar Thier
These formats are compressed 12-bit raw bayer formats with four different pixel orders. The pixel follow one another without any padding, thus are packed in a 'linear' fashion. Signed-off-by: Edgar Thier --- drivers/media/usb/uvc/uvc_driver.c | 21 - drivers/med

[PATCH 1/2] v4l: Add 12-bit raw bayer linear packed formats

2019-07-05 Thread Edgar Thier
These formats are compressed 12-bit raw bayer formats with four different pixel orders. The pixel follow one another without any padding, thus are packed in a 'linear' fashion. Signed-off-by: Edgar Thier --- Documentation/media/uapi/v4l/pixfmt-rgb.rst | 1 + .../media/uapi/

[PATCH 2/2] uvc: Add Genicam 12-bit bayer packed formats

2019-06-28 Thread Edgar Thier
he Imaging Source`. Signed-off-by: Edgar Thier --- drivers/media/usb/uvc/uvc_driver.c | 20 drivers/media/usb/uvc/uvcvideo.h | 12 2 files changed, 32 insertions(+) diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c index 10

[PATCH 1/2] v4l: Add Genicam 12-bit bayer packed formats

2019-06-28 Thread Edgar Thier
These formats are compressed 12-bit raw bayer formats with four different pixel orders. They are similar to 10-bit bayer formats 'IPU3'. The naming and pixel structure follow the Genicam Pixel Format Naming Convention (PFNC). Signed-off-by: Edgar Thier --- .../media/uapi/v4l/p

[Patch v2] v4l: Add simple packed bayer 12-bit formats

2019-01-10 Thread Edgar Thier
These formats are compressed 12-bit raw bayer formats with four different pixel orders. They are similar to 10-bit bayer formats 'IPU3'. Signed-off-by: Edgar Thier --- Documentation/media/uapi/v4l/pixfmt-rgb.rst | 1 + .../media/uapi/v4l/pixfmt-srggb12sp.rst

[Patch v2] uvcvideo: Add simple packed bayer 12-bit formats

2019-01-09 Thread Edgar Thier
These formats are compressed 12-bit raw bayer formats with four different pixel orders. They are similar to 10-bit bayer formats 'IPU3'. Signed-off-by: Edgar Thier --- drivers/media/usb/uvc/uvcvideo.h | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git

[PATCH] v4l: Add simple packed Bayer raw12 pixel formats

2018-08-22 Thread Edgar Thier
These formats are compressed 12-bit raw bayer formats with four different pixel orders. They are similar to 10-bit bayer formats 'IPU3'. The formats added by this patch are V4L2_PIX_FMT_SBGGR12SP V4L2_PIX_FMT_SGBRG12SP V4L2_PIX_FMT_SGRBG12SP V4L2_PIX_FMT_SRGGB12SP Signed-off-by: E

Re: [PATCH] uvcvideo: Apply flags from device to actual properties

2018-01-02 Thread Edgar Thier
Hi Emmanuel, >>> + int flags = 0; >>> + >>> + data = kmalloc(2, GFP_KERNEL); > > Isn't 1 byte enough ? > To quote from Kieran further up this thread: >> kmalloc seems a bit of an overhead for 2 bytes (only one of which is used). >> Can this use local stack storage? >> >> (Laurent, looks lik

Re: [PATCH] uvcvideo: Apply flags from device to actual properties

2017-12-14 Thread Edgar Thier
Hi, Another month, another mail. Are there still issues keeping this from being merged? Regards, Edgar On 11/15/2017 12:54 PM, Kieran Bingham wrote: > Hi Edgar, > > Thanks for addressing my concerns in this updated patch. > > On 12/10/17 08:54, Edgar Thier wrote: >> &g

Re: [PATCH] uvcvideo: Apply flags from device to actual properties

2017-11-15 Thread Edgar Thier
Hi Kieran, > I think it's easier to see updated patches if they are posted as a new thread, > with an increased version number. [PATCH v2], [PATCH v3] etc... > > Not a problem now - but might help your updated patches get seen next time. I will keep that in mind for next time. :) > Looks like my

Re: [PATCH] uvcvideo: Apply flags from device to actual properties

2017-11-15 Thread Edgar Thier
Hi, I was wondering if there are any problems with my latest patch or if it simply slipped through. Regards, Edgar On 10/12/2017 09:54 AM, Edgar Thier wrote: > > Use flags the device exposes for UVC controls. > This allows the device to define which property flags are set. >

Re: [PATCH] uvcvideo: Apply flags from device to actual properties

2017-10-12 Thread Edgar Thier
driver is aware of such properties. Signed-off-by: Edgar Thier --- drivers/media/usb/uvc/uvc_ctrl.c | 64 ++-- 1 file changed, 49 insertions(+), 15 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c index 20397aba

Re: [PATCH] uvcvideo: Apply flags from device to actual properties

2017-10-11 Thread Edgar Thier
driver is aware of such properties. Signed-off-by: Edgar Thier --- drivers/media/usb/uvc/uvc_ctrl.c | 65 ++-- 1 file changed, 50 insertions(+), 15 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c index 20397ab..7fbfeef

Re: [PATCH] uvcvideo: Apply flags from device to actual properties

2017-10-06 Thread Edgar Thier
Hi Kieran, > Rather than forward declaring the function ... Could you put the function > higher > in the module please? Will do. Patch will come as a reply shortly. >>> + if (data == NULL) >>> + return -ENOMEM; >> >> This will set the callers 'flags' to -ENOMEM ? Is that desired? >

Re: [PATCH] uvcvideo: Apply flags from device to actual properties

2017-10-06 Thread Edgar Thier
driver is aware of such properties. Signed-off-by: Edgar Thier --- drivers/media/usb/uvc/uvc_ctrl.c | 56 +++- 1 file changed, 38 insertions(+), 18 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c index 20397ab..5091086

Re: [PATCH] uvcvideo: Apply flags from device to actual properties

2017-10-05 Thread Edgar Thier
Hi all, I was wondering if there are any problems with my latest patch or if it simply slipped through. Feedback would be welcome. Regards, Edgar On 08/18/2017 12:12 PM, Edgar Thier wrote: > > Use flags the device exposes for UVC controls. > This allows the device to define which

Re: UVC property auto update

2017-09-05 Thread Edgar Thier
> > Ok, looking more at the spec, the driver and your patch, here's what I > come up with: > > 1. UVC defines which standard controls should have which flags. Among > those flags it specifies, which controls should specify the Autoupdate > flag. E.g. see the first of them as it appears in my

Re: UVC property auto update

2017-09-04 Thread Edgar Thier
Hi Guennadi, > But that patch only re-reads the flags. What does that give you? Do those > > flags change? In which way? As far as I understand the UVC Autoupdate > feature, a change in GET_INFO data is only one possibility, (arguably) a > more important one is changes in GET_CUR data. My unde

Re: UVC property auto update

2017-09-04 Thread Edgar Thier
Hi Guennadi, The cameras in question are USB-3.0 industrial cameras from The Imaging Source. The ones I tested were the DFK UX250 and DFK UX264 models. I do not know if there are other devices that have the AUTO_UPDATE flag for various properties. Since I received no immediate answer I tried fix

Re: [PATCH] uvcvideo: Apply flags from device to actual properties

2017-08-18 Thread Edgar Thier
driver is aware of such properties. Signed-off-by: Edgar Thier --- drivers/media/usb/uvc/uvc_ctrl.c | 58 +++- 1 file changed, 40 insertions(+), 18 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c index c2ee6e3..6922c0cb

[PATCH] uvcvideo: Apply flags from device to actual properties

2017-08-15 Thread Edgar Thier
Use flags the device exposes for UVC controls. Signed-off-by: Edgar Thier --- drivers/media/usb/uvc/uvc_ctrl.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c index c2ee6e3

UVC property auto update

2017-08-06 Thread Edgar Thier
Hi all, I have some USB-3.0 cameras that use UVC. These cameras offer auto updates for various properties. An example of such a property would be gain, that will be adjusted when activating the auto-gain property. These property changes are not queried by the UVC driver, unless it already has th

Re: [PATCH] uvcvideo: Add bayer 16-bit format patterns

2016-11-15 Thread Edgar Thier
Hi Laurent, > Which device(s) support these formats ? As mentioned in my last mail, I took the freedom and uploaded the lsusb -v output for 3 cameras with bayer 16-bit patterns. You can find them here: dfk23up1300_16bitbayer_RG.lsusb: http://pastebin.com/PDdY7rs0 dfk23ux249_16bitbayer_GB.lsusb:

Re: [PATCH] uvcvideo: Add bayer 16-bit format patterns

2016-11-14 Thread Edgar Thier
: http://pastebin.com/gtjF3Q2k dfk33ux250_16bitbayer_GR.lsusb: http://pastebin.com/Errz5UMr Cheers, Edgar > Hi Edgar, > > On Mon, Nov 14, 2016 at 02:26:56PM +0100, Edgar Thier wrote: >> From aec97c931cb4b91f91dd0ed38f74d866d4f13347 Mon Sep 17 00:00:00 2001 >> From: Edgar Thier

[PATCH] uvcvideo: Add bayer 16-bit format patterns

2016-11-14 Thread Edgar Thier
>From 10ce06db4ab3c037758b3cb5264007f59801f1a1 Mon Sep 17 00:00:00 2001 From: Edgar Thier Date: Tue, 15 Nov 2016 06:33:10 +0100 Subject: [PATCH] uvcvideo: Add bayer 16-bit format patterns Signed-off-by: Edgar Thier --- drivers/media/usb/uvc/uvc_driver.c | 20 drivers/me

[PATCH] uvcvideo: Add bayer 16-bit format patterns

2016-11-14 Thread Edgar Thier
>From aec97c931cb4b91f91dd0ed38f74d866d4f13347 Mon Sep 17 00:00:00 2001 From: Edgar Thier Date: Mon, 14 Nov 2016 14:17:57 +0100 Subject: [PATCH] uvcvideo: Add bayer 16-bit format patterns Add bayer 16-bit GUIDs to uvcvideo and associated them with the corresponding V4L2 pixel formats. Sig

[PATCH] uvcvideo: Add bayer 8-bit patterns to uvcvideo

2014-02-19 Thread Edgar Thier
Add bayer 8-bit GUIDs to uvcvideo and associated them with the corresponding V4L2 pixel formats. Signed-off-by: Edgar Thier --- drivers/media/usb/uvc/uvc_driver.c | 22 +- drivers/media/usb/uvc/uvcvideo.h | 12 2 files changed, 33 insertions(+), 1 deletion

[PATCH] Added bayer 8-bit patterns to uvcvideo

2014-01-20 Thread Edgar Thier
Add bayer 8-bit GUIDs to uvcvideo and associate them with the corresponding V4L2 pixel formats. Signed-off-by: Edgar Thier --- drivers/media/usb/uvc/uvc_driver.c | 22 +- drivers/media/usb/uvc/uvcvideo.h | 12 2 files changed, 33 insertions(+), 1 deletion