and avoid the additional
overhead added by this patch?
Regards,
David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ere on, while the
system is suspended. This is a drastic deviation from the current
behavior and would most likely not be appreciated by users that expect
the device to go off during suspend and back on after resume. I NACK
this change due to the complete removal of suspend/resume support.
Re
se patches don't use the new core-assisted locking as they were
written back in MAY, but they DO remove the BKL from the driver.
The patches have been compile tested only, as I do not have access to
a device for this driver.
>
> Staging driver list:
>
> go7007 (Pete Eberlein)
> tm6
it was submitted back in May then it might have
made its way into the kernel by now. At the time the patch was
written, core assisted locking wasn't even implemented. Granted the
ioctl added to correct the locking might cause a cache miss, but this
is acceptable for such a simple driver. This
atch
manages to do just that while reducing the overall size of the driver
at the same time.
Regards,
David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
This driver has quite a few locking issues that would only be made
worse by your patch. A much better patch for this can be found here:
http://desource.dyndns.org/~atog/gitweb?p=linux-media.git;a=commitdiff;h=9c5d8ebb602e9af46902c5f3d4d4cc80227d3f7c
Regards,
David Ellingsworth
--
To unsubscribe
On Tue, Nov 16, 2010 at 4:42 PM, Hans Verkuil wrote:
> On Tuesday, November 16, 2010 22:32:57 David Ellingsworth wrote:
>> Hans,
>>
>> I've had some patches pending for a while now that affect the dsbr100
>> driver. The patches can be seen here:
>> http://des
e the unlocked ioctl. The
series is a bit old, so it doesn't make use of the v4l2 core assisted
locking; but that is trivial to implement after this patch.
Regards,
David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of
> Any conclusion about the locking fixes patch?
>
I don't like it, but it at least fixes the problem. You can add my ack.
Acked-by: David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kern
an be suspended.
>>>
>>> My proposal would be to rip out the whole autosuspend business from this
>>> driver. I've no idea why it is here at all.
>>>
>>> Regards,
>>>
>>> Hans
>>
>> Hans, I highly agree with th
On Mon, Oct 18, 2010 at 10:35 AM, David Ellingsworth
wrote:
> On Mon, Oct 18, 2010 at 10:18 AM, Hans Verkuil wrote:
>>
>>> On Mon, Oct 18, 2010 at 9:38 AM, Hans Verkuil wrote:
>>>>
>>>>> On Sun, Oct 17, 2010 at 8:26 AM, Hans Verkuil
>>&
sume functions using the global lock.
>>>>> - do not call usb_autopm_put_interface after a disconnect.
>>>>> - fix a race when disconnecting the device.
>>>>>
>>>>> Reported-by: David Ellingsworth
>>>>> Signed-off-by: Hans Verkui
a race when disconnecting the device.
>>>
>>> Reported-by: David Ellingsworth
>>> Signed-off-by: Hans Verkuil
>>> ---
>>> drivers/media/radio/radio-mr800.c | 17 ++---
>>> 1 files changed, 14 insertions(+), 3 deletions(-)
>
On Sun, Oct 17, 2010 at 8:26 AM, Hans Verkuil wrote:
> - serialize the suspend and resume functions using the global lock.
> - do not call usb_autopm_put_interface after a disconnect.
> - fix a race when disconnecting the device.
>
> Reported-by: David Ellingsworth
> Signed-of
r put that
code in. But like you, I'm not sure if it was ever really valid. Since
I didn't have anything to test with, I left it untouched.
Regards,
David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Oct 11, 2010 at 2:05 PM, David Ellingsworth
wrote:
> On Mon, Oct 11, 2010 at 11:40 AM, Hans Verkuil wrote:
>> On Sunday, October 10, 2010 19:33:48 David Ellingsworth wrote:
>>> Hans,
>>>
>>> On Sun, Sep 26, 2010 at 8:25 AM, Hans Verkuil wrote:
>&
usb_amradio_suspend and usb_amradio_resume must remain
to prevent races between other open/close/ioctl/read/mmap/etc and the
resume/suspend cycle. Please revert the changes you made to these two
functions.
Regards,
David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-
.org/git/hverkuil/v4l-dvb.git mr800
>
> Hans Verkuil (1):
> radio-mr800: fix locking order
>
Acked-By: David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordom
On Mon, Oct 11, 2010 at 11:40 AM, Hans Verkuil wrote:
> On Sunday, October 10, 2010 19:33:48 David Ellingsworth wrote:
>> Hans,
>>
>> On Sun, Sep 26, 2010 at 8:25 AM, Hans Verkuil wrote:
>> > Hi Mauro,
>> >
>> > These are the locking patches. It&
On Sun, Oct 10, 2010 at 1:33 PM, David Ellingsworth
wrote:
> Hans,
>
> On Sun, Sep 26, 2010 at 8:25 AM, Hans Verkuil wrote:
>> Hi Mauro,
>>
>> These are the locking patches. It's based on my previous test tree, but with
>> more testing with em28xx and radi
osted to the list, others might have
caught issues like this earlier. Posting a link to a repository is no
substitute for this process.
Mauro, you should be ashamed for accepting a series that obviously has issues.
Regards,
David Ellingsworth
--
To unsubscribe from this list: send the line "
> I will also check your patches soon. I have this old hardware at home.
>
The sooner the better. These patches have been waiting for review
since May. I'd rather not have to rebase them and resend them a third
time.
Regards,
David Ellingsworth
--
To unsubscribe from this list: se
ents is risky.
> + Don't use it at production. You've being warned.
The last line should read: "Don't use it in production. You've been warned."
> +EOF3
> + sleep 5;
> }
> --
Regards,
David Ellingsworth
--
To unsubscribe from this list: s
On Mon, Sep 13, 2010 at 2:02 PM, David Ellingsworth
wrote:
> On Sun, Sep 5, 2010 at 4:58 AM, Hans de Goede wrote:
>> Hi,
>>
>> On 08/31/2010 11:43 PM, David Ellingsworth wrote:
>>>
>>> Hans,
>>>
>>> I haven't had any success
Alexey,
Can you review/test this patch series? Patches 2/8, 3/8, and 5/8 are
bug fixes the rest are mainly cleanups. Patch 2/8 should fix a crash
in the normal case if the device is disconnected while not in use.
Regards,
David Ellingsworth
On Thu, May 27, 2010 at 12:39 PM, David Ellingsworth
On Sun, Sep 5, 2010 at 4:58 AM, Hans de Goede wrote:
> Hi,
>
> On 08/31/2010 11:43 PM, David Ellingsworth wrote:
>>
>> Hans,
>>
>> I haven't had any success with this driver as of yet. My camera is
>> shown here: http://www.amazon.com/IBM-Net-Camera
On Thu, May 27, 2010 at 12:39 PM, David Ellingsworth
wrote:
> This patch series addresses several issues in the dsbr100 driver.
> This series is based on the v4l-dvb master git branch and has been
> compile tested only. It should be tested before applying.
>
> This is the second
of the crash.
Without this information, it's hard to gauge the exact cause of the
error and thus no one will attempt to fix it.
Regards,
David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
controlling say an i2c device of some
sorts then you should implement that functionality as a subdev.
Otherwise, you should extract the shared functionality into its own
module that can be utilized by both drivers (there are many examples
of this within the kernel).
Regards,
David Ellingsworth
--
To unsubsc
This patch replaces calls to video_drvdata with
references to struct file->private_data which is
set during usb_dsbr100_open. This value is passed
by video_ioctl2 via the *priv argument and is
accessible via file->private_data otherwise.
Signed-off-by: David Ellingsworth
---
drivers/media
This patch simplifies the error paths within the
usb_dsbr100_probe routine. It also removes an unnecessary
local variable.
Signed-off-by: David Ellingsworth
---
drivers/media/radio/dsbr100.c | 39 ---
1 files changed, 20 insertions(+), 19 deletions(-)
diff
radio.
Signed-off-by: David Ellingsworth
---
drivers/media/radio/dsbr100.c | 53 +++-
1 files changed, 41 insertions(+), 12 deletions(-)
diff --git a/drivers/media/radio/dsbr100.c b/drivers/media/radio/dsbr100.c
index 0e009b7..96e6128 100644
--- a/drivers/media
Signed-off-by: David Ellingsworth
---
drivers/media/radio/dsbr100.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/radio/dsbr100.c b/drivers/media/radio/dsbr100.c
index 673eda8..2f96e13 100644
--- a/drivers/media/radio/dsbr100.c
+++ b/drivers/media/radio
Signed-off-by: David Ellingsworth
---
drivers/media/radio/dsbr100.c | 77 +---
1 files changed, 33 insertions(+), 44 deletions(-)
diff --git a/drivers/media/radio/dsbr100.c b/drivers/media/radio/dsbr100.c
index ed9cd7a..673eda8 100644
--- a/drivers/media
Signed-off-by: David Ellingsworth
---
drivers/media/radio/dsbr100.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/media/radio/dsbr100.c b/drivers/media/radio/dsbr100.c
index b62fe40..c949ace 100644
--- a/drivers/media/radio/dsbr100.c
+++ b/drivers/media
ation of calling dsbr100_start and
dsbr100_stop.
Signed-off-by: David Ellingsworth
---
drivers/media/radio/dsbr100.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/media/radio/dsbr100.c b/drivers/media/radio/dsbr100.c
index c949ace..0e009b7 100644
--- a
Signed-off-by: David Ellingsworth
---
drivers/media/radio/dsbr100.c | 11 +--
1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/media/radio/dsbr100.c b/drivers/media/radio/dsbr100.c
index 2f96e13..b62fe40 100644
--- a/drivers/media/radio/dsbr100.c
+++ b/drivers
Regards,
David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
d be better than the hard-coded value of 3 above.
> + } else {
> + deb_info("this firmware does not allow to change the USB xfer
> len\n");
> + ret = -EIO;
> + }
> +
> + return ret;
> }
>
> /*
Everything else looks good.
Regards,
David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, May 11, 2010 at 9:36 AM, Laurent Pinchart
wrote:
> The videobuf_dmabuf and videobuf_vmalloc_memory fields have a vmalloc
> field to store the kernel virtual address of vmalloc'ed buffers. Rename
> the field to vaddr.
>
> Signed-off-by: Laurent Pinchart
> ---
> drivers/media/video/cx88/cx
This patch replaces calls to video_drvdata with
references to struct file->private_data which is
set during usb_dsbr100_open. This value is passed
by video_ioctl2 via the *priv argument and is
accessible via file->private_data otherwise.
Signed-off-by: David Ellingsworth
---
drivers/media
/RFC 7/7] dsbr100: simplify access to radio device
Regards,
David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signed-off-by: David Ellingsworth
---
drivers/media/radio/dsbr100.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/media/radio/dsbr100.c b/drivers/media/radio/dsbr100.c
index b62fe40..c949ace 100644
--- a/drivers/media/radio/dsbr100.c
+++ b/drivers/media
This patch simplifies the error paths within the
usb_dsbr100_probe routine. It also removes an unnecessary
local variable.
Signed-off-by: David Ellingsworth
---
drivers/media/radio/dsbr100.c | 39 ---
1 files changed, 20 insertions(+), 19 deletions(-)
diff
Signed-off-by: David Ellingsworth
---
drivers/media/radio/dsbr100.c | 11 +--
1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/media/radio/dsbr100.c b/drivers/media/radio/dsbr100.c
index 2f96e13..b62fe40 100644
--- a/drivers/media/radio/dsbr100.c
+++ b/drivers
Signed-off-by: David Ellingsworth
---
drivers/media/radio/dsbr100.c | 77 +---
1 files changed, 33 insertions(+), 44 deletions(-)
diff --git a/drivers/media/radio/dsbr100.c b/drivers/media/radio/dsbr100.c
index ed9cd7a..673eda8 100644
--- a/drivers/media
.
Signed-off-by: David Ellingsworth
---
drivers/media/radio/dsbr100.c | 54 +++-
1 files changed, 42 insertions(+), 12 deletions(-)
diff --git a/drivers/media/radio/dsbr100.c b/drivers/media/radio/dsbr100.c
index c949ace..e2fed0b 100644
--- a/drivers/media
Signed-off-by: David Ellingsworth
---
drivers/media/radio/dsbr100.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/radio/dsbr100.c b/drivers/media/radio/dsbr100.c
index 673eda8..2f96e13 100644
--- a/drivers/media/radio/dsbr100.c
+++ b/drivers/media/radio
, 0x0004, val);
> + if (state->has_headphones)
> + msp_write_dsp(client, 0x0033, val);
> break;
>
> case V4L2_CID_AUDIO_BALANCE:
> - if (!state->has_sound_processing)
> - return -EINVAL;
> - state->balance = ctrl->value;
> + val = (u8)((val / 256) - 128);
> + msp_write_dsp(client, 0x0001, val << 8);
> + if (state->has_headphones)
> + msp_write_dsp(client, 0x0030, val << 8);
> break;
>
> default:
> return -EINVAL;
> }
> - msp_set_audio(client);
> return 0;
The return value here should reflect if the update was successful or
not. msp_write_dsp can fail and if does the error should be propagated
to the caller and the value of the control should not be updated.
Also, msp_write_dsp and msp_read_dsp should probably return -EIO in
case of failures rather than -1.
Regards,
David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
state->agc->val)
> + saa711x_write(sd, R_0F_CHROMA_GAIN_CNTL,
> state->gain->val);
> + else
> + saa711x_write(sd, R_0F_CHROMA_GAIN_CNTL,
> state->gain->val | 0x80);
> + v4l2_ctrl_activate(st
each driver will be responsible for concurrency
issues that it may or may not have. After all, wasn't this what the
removal of the BKL was about in the first place?
Regards,
David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of
to be registered.
Regards,
David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
d for each registered
video device (during probe) and then properly decremented during the
video_device release callback for each device the device driver's
structure may then be freed. This approach should lead to a much
cleaner implementation of the open, release, and disconnect callbacks.
On Fri, Mar 19, 2010 at 1:43 PM, Mauro Carvalho Chehab
wrote:
> David Ellingsworth wrote:
>> On Fri, Mar 19, 2010 at 9:47 AM, Mauro Carvalho Chehab
>> wrote:
>>> The V4L1 drivers that lasts are the ones without maintainers and probably
>>> without
>>>
collaborate with me to make a
functional v4l2 driver to replace the existing ibmcam driver, I'd be
more than willing to expend more time and energy in doing so.
Hopefully someday I'll actually be able to use the camera that I own,
considering as is it barely works under Windows.
Rega
ease give me some guidance on this?
>
> Regards,
> Mattias
You might want to take a look at possibly using gspca as a base for
your driver. It currently supports hundreds of cameras and there are
quite a few drivers that you can use as a reference. gspca doesn't use
videobuf.. but should
Version 2
From c2c100652ed74d91ade7fdfb2a22d607ff43acf2 Mon Sep 17 00:00:00 2001
From: David Ellingsworth
Date: Mon, 21 Sep 2009 22:17:05 -0400
Subject: [PATCH 08/14] mr800: fix potential use after free
Signed-off-by: David Ellingsworth
---
drivers/media/radio/radio-mr800.c |2 +-
1 files
On Mon, Sep 21, 2009 at 8:03 PM, Alexey Klimov wrote:
> Hello, David
>
> On Mon, Sep 14, 2009 at 11:09 PM, Alexey Klimov
> wrote:
>> Hello David,
>>
>> On Sun, Sep 13, 2009 at 7:22 AM, David Ellingsworth
>> wrote:
>>> What follow is a series of
eed a loop back video driver which is capable
of being fed data from a user space application. I don't know if this
patch was ever applied http://patchwork.kernel.org/patch/24370/ but it
seems like something you might be able to use to achieve what you want
to do.
Regards,
David Ellingsworth
ues and this is a new driver, it is probably
best to submit it without the code for RGB support. As is, even
without direct support from the driver, users can retrieve RGB data
from the camera using libv4l. Your argument is therefore more or less
mute. If someone were to want to add RGB sup
e if the
sensor is upside down or not and corrects the image if necessary. It
might also provide additional controls that allow you to flip the
image even if it's not a sensor that's known to be mounted upside
down. libv4l is compatible with all v4l2 applications simply by
pre-loading th
ly convert the native format supported by your
camera to the one required by your application.
Regards,
David Ellingsworth
On Mon, Sep 14, 2009 at 1:50 AM, Guilherme Longo wrote:
>
> Hi all.
>
> After 3 weeks trying to solve my problem, I am about to give up and find
> another solu
From 8c441616f67011244cb15bc1a3dda6fd8706ecd2 Mon Sep 17 00:00:00 2001
From: David Ellingsworth
Date: Sat, 12 Sep 2009 16:04:44 -0400
Subject: [PATCH 08/14] mr800: fix potential use after free
Signed-off-by: David Ellingsworth
---
drivers/media/radio/radio-mr800.c |1 -
1 files changed, 0
From 8c441616f67011244cb15bc1a3dda6fd8706ecd2 Mon Sep 17 00:00:00 2001
From: David Ellingsworth
Date: Sat, 12 Sep 2009 16:04:44 -0400
Subject: [PATCH 08/14] mr800: fix potential use after free
Signed-off-by: David Ellingsworth
---
drivers/media/radio/radio-mr800.c |1 -
1 files changed, 0
From 8c441616f67011244cb15bc1a3dda6fd8706ecd2 Mon Sep 17 00:00:00 2001
From: David Ellingsworth
Date: Sat, 12 Sep 2009 16:04:44 -0400
Subject: [PATCH 08/14] mr800: fix potential use after free
Signed-off-by: David Ellingsworth
---
drivers/media/radio/radio-mr800.c |1 -
1 files changed, 0
From 8c441616f67011244cb15bc1a3dda6fd8706ecd2 Mon Sep 17 00:00:00 2001
From: David Ellingsworth
Date: Sat, 12 Sep 2009 16:04:44 -0400
Subject: [PATCH 08/14] mr800: fix potential use after free
Signed-off-by: David Ellingsworth
---
drivers/media/radio/radio-mr800.c |1 -
1 files changed, 0
David Ellingsworth wrote:
What follow is a series of patches to clean up the radio-mr800 driver.
I do _not_ have access to this device so these patches need to be
tested. These patches should apply to Mauro's git tree and against the
2.6.31 release kernel. The patches in this series a
From 8c441616f67011244cb15bc1a3dda6fd8706ecd2 Mon Sep 17 00:00:00 2001
From: David Ellingsworth
Date: Sat, 12 Sep 2009 16:04:44 -0400
Subject: [PATCH 08/14] mr800: fix potential use after free
Signed-off-by: David Ellingsworth
---
drivers/media/radio/radio-mr800.c |1 -
1 files changed, 0
From 8c441616f67011244cb15bc1a3dda6fd8706ecd2 Mon Sep 17 00:00:00 2001
From: David Ellingsworth
Date: Sat, 12 Sep 2009 16:04:44 -0400
Subject: [PATCH 08/14] mr800: fix potential use after free
Signed-off-by: David Ellingsworth
---
drivers/media/radio/radio-mr800.c |1 -
1 files changed, 0
From 8c441616f67011244cb15bc1a3dda6fd8706ecd2 Mon Sep 17 00:00:00 2001
From: David Ellingsworth
Date: Sat, 12 Sep 2009 16:04:44 -0400
Subject: [PATCH 08/14] mr800: fix potential use after free
Signed-off-by: David Ellingsworth
---
drivers/media/radio/radio-mr800.c |1 -
1 files changed, 0
y for review.
Regards,
David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Sep 12, 2009 at 10:50 AM, David Ellingsworth
wrote:
> From 31243088bd32d5568f06f2044f8ff782641e16b5 Mon Sep 17 00:00:00 2001
> From: David Ellingsworth
> Date: Sat, 12 Sep 2009 02:05:57 -0400
> Subject: [PATCH 09/10] mr800: preserve radio state during suspend/resume
>
On Sat, Sep 12, 2009 at 10:50 AM, David Ellingsworth
wrote:
> From 46c7d395e4ed2df431b21b6c07fb02a075a15e43 Mon Sep 17 00:00:00 2001
> From: David Ellingsworth
> Date: Sat, 12 Sep 2009 01:57:36 -0400
> Subject: [PATCH 08/10] mr800: turn radio on during first open and off during
From 987d22363c7a55a5e48a2746a61a6d805fef8661 Mon Sep 17 00:00:00 2001
From: David Ellingsworth
Date: Sat, 12 Sep 2009 02:35:22 -0400
Subject: [PATCH 10/10] mr800: fix potential use after free
Signed-off-by: David Ellingsworth
---
drivers/media/radio/radio-mr800.c |1 -
1 files changed, 0
From 31243088bd32d5568f06f2044f8ff782641e16b5 Mon Sep 17 00:00:00 2001
From: David Ellingsworth
Date: Sat, 12 Sep 2009 02:05:57 -0400
Subject: [PATCH 09/10] mr800: preserve radio state during suspend/resume
Signed-off-by: David Ellingsworth
---
drivers/media/radio/radio-mr800.c | 17
From 46c7d395e4ed2df431b21b6c07fb02a075a15e43 Mon Sep 17 00:00:00 2001
From: David Ellingsworth
Date: Sat, 12 Sep 2009 01:57:36 -0400
Subject: [PATCH 08/10] mr800: turn radio on during first open and off
during last close
Signed-off-by: David Ellingsworth
---
drivers/media/radio/radio-mr800
From a9b0a308892919514efc692f2a0e28b80ea304ac Mon Sep 17 00:00:00 2001
From: David Ellingsworth
Date: Sat, 12 Sep 2009 01:22:57 -0400
Subject: [PATCH 07/10] mr800: remove device removed indicator
Signed-off-by: David Ellingsworth
---
drivers/media/radio/radio-mr800.c | 20
From c012b1ac39a225e003b190a12ae942e1dd6ea09b Mon Sep 17 00:00:00 2001
From: David Ellingsworth
Date: Sat, 12 Sep 2009 01:07:13 -0400
Subject: [PATCH 06/10] mr800: simplify locking in ioctl callbacks
Signed-off-by: David Ellingsworth
---
drivers/media/radio/radio-mr800.c | 109
From 762337020b7744f791fc02fff7eb983e3e4a2346 Mon Sep 17 00:00:00 2001
From: David Ellingsworth
Date: Sat, 12 Sep 2009 00:45:28 -0400
Subject: [PATCH 05/10] mr800: simplify access to amradio_device
Signed-off-by: David Ellingsworth
---
drivers/media/radio/radio-mr800.c | 23
From f2fdb83ce649e9e69413ab533ec4a84d96850ed4 Mon Sep 17 00:00:00 2001
From: David Ellingsworth
Date: Sat, 12 Sep 2009 00:19:48 -0400
Subject: [PATCH 04/10] mr800: remove unnecessary local variable
Signed-off-by: David Ellingsworth
---
drivers/media/radio/radio-mr800.c | 10 --
1
From 0cdbd79a6e87a8a2862a6c1309c8fdf83c80ba61 Mon Sep 17 00:00:00 2001
From: David Ellingsworth
Date: Sat, 12 Sep 2009 00:13:16 -0400
Subject: [PATCH 03/10] mr800: simplify error paths in usb probe callback
Signed-off-by: David Ellingsworth
---
drivers/media/radio/radio-mr800.c | 27
From 2839cd94e21123151c0fe6683991f5a3c88fa877 Mon Sep 17 00:00:00 2001
From: David Ellingsworth
Date: Fri, 11 Sep 2009 23:59:22 -0400
Subject: [PATCH 02/10] mr800: simplify video_device allocation
Signed-off-by: David Ellingsworth
---
drivers/media/radio/radio-mr800.c | 53
From 1773df59dc8e63ca00a27f5235c293341fd07f36 Mon Sep 17 00:00:00 2001
From: David Ellingsworth
Date: Fri, 11 Sep 2009 23:21:17 -0400
Subject: [PATCH 01/10] mr800: implement proper locking
Signed-off-by: David Ellingsworth
---
drivers/media/radio/radio-mr800.c | 181
mr800: remove device-removed indicator
8. radio-mr800: turn radio on during first open and off during last close
9. radio-mr800: preserve radio-state during suspend/resume
10. radio-mr800: fix potential use after free
Each individual patch will follow in a separate email.
Regards,
David Ellings
adio, AMRADIO_START);
> + if (retval < 0)
> + dev_warn(&radio->videodev->dev,
> + "amradio_start failed\n");
> + }
> +
> return 0;
> }
>
Regards,
David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ly after. It would be better for
the driver to just assume the device was there and allow usb functions
it calls to fail appropriately.
Since the usb_disconnect callback most likely modifies the driver's
state, it should probably take the lock along with open, close, and
any other ioct
egards, Klimov Alexey
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Regards,
David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
p properly\n");
> radio->users = 0;
> - unlock_kernel();
> return -EIO;
> }
>
> @@ -564,7 +561,6 @@
> amradio_dev_warn(&radio->videodev->dev,
> "set frequency failed\n")
dev_warn(&intf->dev, "set stereo failed\n");
> + }
> +
> + }
>
> dev_info(&intf->dev, "coming out of suspend..\n");
>
>
>
> --
> Best regards, Klimov Alexey
>
If you properly address the locking in this driver, you should be able
to remove the dependency of this driver on the lock_kernel() and
unlock_kernel() constructs.
Regards,
David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
EO_CAPTURE)
> + return -EINVAL;
> +
> memset(parm, 0, sizeof *parm);
> parm->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
^^^
This line should be deleted as it's no longer needed.
> parm->parm.capture.readbuffers = gspca_dev->nbufr
ps in case state is NULL. So you either need two goto labels for
> failures or just return in case kzalloc fails.
Patches welcomed. :-)
Regards,
David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.ke
umber of different reasons.
Some of those reasons include better hardware support, bug detection,
and stability testing. All services greatly valued by other kernel
developers.
Regards,
David Ellingsworth
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
92 matches
Mail list logo
