Hi.
On Mon, 2015-01-19 at 17:25 +0900, Daniel Jeong wrote:
This patch adds the driver for the single string flash products of TI.
Several single string flash controllers of TI have similar register map
and bit data. This driver supports four products,lm3556, lm3561, lm3642
and lm3648.
Why not
This patch adds the driver for the single string flash products of TI.
Several single string flash controllers of TI have similar register map
and bit data. This driver supports four products,lm3556, lm3561, lm3642
and lm3648.
Signed-off-by: Daniel Jeong
---
drivers/media/i2c/Kconfig
patch files.
Thank you.
Acked-by: Daniel Jeong
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
V4L2_FLASH_FAULT_UNDER_VOLTAGE description in DocBook.
Changed lm3646_get_ctrl
v6 - change log
Changed description in DocBook.
v5 - change log
Added control register caching to avoid redundant i2c access.
Removed dt to create a seperate patch.
Changed description in DocBook.
Daniel Jeong (3):
[RFC] v4l2
Descriptions for flash faluts.
V4L2_FLASH_FAULT_UNDER_VOLTAGE,
V4L2_FLASH_FAULT_INPUT_VOLTAGE,
and V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE
v7 : Changed V4L2_FLASH_FAULT_UNDER_VOLTAGE description
Signed-off-by: Daniel Jeong
---
Documentation/DocBook/media/v4l/controls.xml | 18
temperature exceed
the maximun limit
Signed-off-by: Daniel Jeong
---
include/uapi/linux/v4l2-controls.h |3 +++
1 file changed, 3 insertions(+)
diff --git a/include/uapi/linux/v4l2-controls.h
b/include/uapi/linux/v4l2-controls.h
index 2cbe605..1d662f6 100644
--- a/include/uapi/linux/v4l2
voltage monitor and thermal threshhold Faults are added.
Please refer the datasheet http://www.ti.com/lit/ds/snvs962/snvs962.pdf
Signed-off-by: Daniel Jeong
---
drivers/media/i2c/Kconfig |9 +
drivers/media/i2c/Makefile |1 +
drivers/media/i2c/lm3646.c | 414
2014년 02월 26일 21:56, Sakari Ailus 쓴 글:
Hi Daniel,
Just a few minor comments.
On Wed, Feb 26, 2014 at 04:04:11PM +0900, Daniel Jeong wrote:
This patch adds the driver for the LM3646, dual LED Flash driver.
The LM3646 has two 1.5A sync. boost converter with dual white current source.
It is
voltage monitor and thermal threshhold Faults are added.
Please refer the datasheet http://www.ti.com/lit/ds/snvs962/snvs962.pdf
Signed-off-by: Daniel Jeong
---
drivers/media/i2c/Kconfig |9 +
drivers/media/i2c/Makefile |1 +
drivers/media/i2c/lm3646.c | 419
temperature exceed
the maximun limit
Signed-off-by: Daniel Jeong
---
include/uapi/linux/v4l2-controls.h |3 +++
1 file changed, 3 insertions(+)
diff --git a/include/uapi/linux/v4l2-controls.h
b/include/uapi/linux/v4l2-controls.h
index 2cbe605..1d662f6 100644
--- a/include/uapi/linux/v4l2
Descriptions for flash faluts.
V4L2_FLASH_FAULT_UNDER_VOLTAGE,
V4L2_FLASH_FAULT_INPUT_VOLTAGE,
and V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE
Signed-off-by: Daniel Jeong
---
Documentation/DocBook/media/v4l/controls.xml | 18 ++
1 file changed, 18 insertions(+)
diff --git a
.
v5 - change log
Added control register caching to avoid redundant i2c access.
Removed dt to create a seperate patch.
Changed description in DocBook.
Daniel Jeong (3):
[RFC] v4l2-controls.h:
[RFC] DocBook:Media:v4l:controls.xml
[RFC] media: i2c: add new dual LED Flash driver, lm3646
Hi Sakari
Thank you for your comments.
Hi Daniel,
Daniel Jeong wrote:
Added more comment about Input voltage flash monitor and external
temp function.
Signed-off-by: Daniel Jeong
---
Documentation/DocBook/media/v4l/controls.xml | 18 ++
1 file changed, 18 insertions
To prevent redundant i2c access, Mode register is caching at initial time.
And it will be written with control mode.
There are many bit data in mode register so it is hard to set zero all.
DT is removed and will be created a seperated patch
Signed-off-by: Daniel Jeong
---
drivers/media/i2c
Added more comment about Input voltage flash monitor and external temp function.
Signed-off-by: Daniel Jeong
---
Documentation/DocBook/media/v4l/controls.xml | 18 ++
1 file changed, 18 insertions(+)
diff --git a/Documentation/DocBook/media/v4l/controls.xml
b/Documentation
Same with v3 and v4.
Signed-off-by: Daniel Jeong
---
include/uapi/linux/v4l2-controls.h |3 +++
1 file changed, 3 insertions(+)
diff --git a/include/uapi/linux/v4l2-controls.h
b/include/uapi/linux/v4l2-controls.h
index 2cbe605..1d662f6 100644
--- a/include/uapi/linux/v4l2-controls.h
+++ b
Hi Sakari.
Thank you for you comments.
Hi Daniel,
Thanks for the update.
Daniel Jeong wrote:
Add addtional falult bits for FLASH
V4L2_FLASH_FAULT_UNDER_VOLTAGE : UVLO
V4L2_FLASH_FAULT_INPUT_VOLTAGE : input voltage is adjusted by IVFM
V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE : NTC Trip point
harware description check priorities
platform data -> device tree -> default data
Signed-off-by: Daniel Jeong
---
drivers/media/i2c/Kconfig |9 +
drivers/media/i2c/Makefile |1 +
drivers/media/i2c/lm3646.c | 456
include/media/lm
Add new dual flash driver.
Fixed the previous issues and added device tree support.
Signed-off-by: Daniel Jeong
---
drivers/media/i2c/Kconfig |9 +
drivers/media/i2c/Makefile |1 +
drivers/media/i2c/lm3646.c | 451
include/media/lm3646.h
Add addtional falult bits for FLASH
V4L2_FLASH_FAULT_UNDER_VOLTAGE : UVLO
V4L2_FLASH_FAULT_INPUT_VOLTAGE : input voltage is adjusted by IVFM
V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE : NTC Trip point is crossed.
Signed-off-by: Daniel Jeong
---
Documentation/DocBook/media/v4l/controls.xml | 16
Add addtional falult bits for FLASH
V4L2_FLASH_FAULT_UNDER_VOLTAGE : UVLO
V4L2_FLASH_FAULT_INPUT_VOLTAGE : input voltage is adjusted by IVFM
V4L2_FLASH_FAULT_LED_OVER_TEMPERATURE : NTC Trip point is crossed.
Signed-off-by: Daniel Jeong
---
include/uapi/linux/v4l2-controls.h |3 +++
1 file
2014년 01월 28일 18:08, Sakari Ailus 쓴 글:
Hi Daniel,
On Tue, Jan 28, 2014 at 03:55:57PM +0900, Daniel Jeong wrote:
Add additional FLASH Fault bits to dectect faults from chip.
Some Flash drivers support UVLO, IVFM, NTC Trip faults.
UVLO : Under Voltage Lock Out Threshold crossed
IVFM : IVFM
brightness is set equal to or bigger than Total
brightness.
And the brightness step is very small, 1.46mA for Torch, 11.71mA for Flash.
If the step is changed to mA, maximum brightness cannot be reachable.
Signed-off-by: Daniel Jeong
---
drivers/media/i2c/Kconfig |9 +
drivers/media/i2c
. Many Flash drivers have a pin and the fault bit
to
serves as a threshold detector for negative temperature coefficient (NTC)
thermistors.
Signed-off-by: Daniel Jeong
---
include/uapi/linux/v4l2-controls.h |3 +++
1 file changed, 3 insertions(+)
diff --git a/include/uapi/linux/v4l2
threshhold Faults are added.
Please refer the datasheet http://www.ti.com/lit/ds/snvs962/snvs962.pdf
Signed-off-by: Daniel Jeong
---
drivers/media/i2c/Kconfig |9 +
drivers/media/i2c/Makefile |1 +
drivers/media/i2c/lm3646.c | 410
Sorry I should have checked below things before sending the first patch.
Correct reference of reading values. (rval -> reg_val)
Add the missing unlock before return from function lm3560_get_ctrl()
to avoid deadlock.
Thank you Dan Carpenter & Sakari.
Signed-off-by: Daniel Jeong
---
Add the missing unlock before return from function lm3560_get_ctrl()
to avoid deadlock. Thanks to Dan Carpenter.
Signed-off-by: Daniel Jeong
---
drivers/media/i2c/lm3560.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/lm3560.c b/drivers/media
can be controlled
independantly. But flash timeout and operation mode are shared.
Signed-off-by: Daniel Jeong
---
drivers/media/i2c/Kconfig |9 +
drivers/media/i2c/Makefile |1 +
drivers/media/i2c/lm3560.c | 488
include/media/lm3560.h
. But flash timeout and operation mode are shared.
Signed-off-by: Daniel Jeong
---
drivers/media/i2c/Kconfig |9 +
drivers/media/i2c/Makefile |1 +
drivers/media/i2c/lm3560.c | 716
include/media/lm3560.h | 103 +++
4 files changed, 829
29 matches
Mail list logo
