Re: [PATCH] uvcvideo: Add quirk for Quanta NL3 laptop camera

2015-04-09 Thread Daniel Drake
Hi Laurent, On Sat, Apr 4, 2015 at 3:44 PM, Laurent Pinchart wrote: > I'm not sure that adding a device-specific quirk is the bast way to handle > this problem, as it wouldn't really scale if other devices expose buggy > descriptors. A more generic way to patch or override descriptors might be >

[PATCH] uvcvideo: Add quirk for Quanta NL3 laptop camera

2015-03-12 Thread Daniel Drake
. Signed-off-by: Daniel Drake --- drivers/media/usb/uvc/uvc_driver.c | 36 drivers/media/usb/uvc/uvcvideo.h | 1 + 2 files changed, 37 insertions(+) diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c index cf27006

[PATCH resend] via-camera: pass correct format settings to sensor

2012-07-15 Thread Daniel Drake
The code attempts to maintain a "user format" and a "sensor format", but in this case it looks like a typo is passing the user format down to the sensor. This was preventing display of video at anything other than 640x480. Signed-off-by: Daniel Drake --- drivers/media/video

[PATCH] via-camera: pass correct format settings to sensor

2012-05-23 Thread Daniel Drake
The code attempts to maintain a "user format" and a "sensor format", but in this case it looks like a typo is passing the user format down to the sensor. This was preventing display of video at anything other than 640x480. Signed-off-by: Daniel Drake --- drivers/media/video

Re: [PATCH] mmp-camera: specify XO-1.75 clock speed

2012-05-16 Thread Daniel Drake
On Wed, May 16, 2012 at 3:12 PM, Jonathan Corbet wrote: > On Tue, 15 May 2012 20:43:31 +0100 (BST) > Daniel Drake wrote: > >> Jon, is it OK to assume that XO-1.75 is the only mmp-camera user? > > It's the only one I know of at the moment, certainly. > > Even so,

[PATCH] mmp-camera: specify XO-1.75 clock speed

2012-05-15 Thread Daniel Drake
this information to the ov7670 driver, to fix an issue where a framerate faster than the requested amount was being provided. Signed-off-by: Daniel Drake --- drivers/media/video/marvell-ccic/mmp-driver.c |7 +++ 1 file changed, 7 insertions(+) Jon, is it OK to assume that XO-1.75 is the

Re: [PATCH] via-camera: specify XO-1.5 camera clock speed

2012-04-30 Thread Daniel Drake
On Mon, Apr 30, 2012 at 5:27 PM, Jonathan Corbet wrote: > On Mon, 30 Apr 2012 23:06:27 +0100 (BST) > Daniel Drake wrote: > >> For the ov7670 camera to return images at the requested frame rate, >> it needs to make calculations based on the clock speed, which is >> a

[PATCH] via-camera: specify XO-1.5 camera clock speed

2012-04-30 Thread Daniel Drake
this information to the ov7670 driver, to fix an issue where a framerate of 3x the requested amount was being provided. Signed-off-by: Daniel Drake --- drivers/media/video/via-camera.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/via

[PATCH] via-camera: disable RGB mode

2011-10-26 Thread Daniel Drake
dealing with. Work around this problem by disabling RGB support. YUYV scaling works just fine. Test case: gst-launch v4l2src ! video/x-raw-rgb,bpp=16,width=320,height=240 ! \ ffmpegcolorspace ! xvimagesink Signed-off-by: Daniel Drake --- drivers/media/video/via-camera.c | 10

via-camera: scaling and RGB modes

2011-10-14 Thread Daniel Drake
Hi Jon, We're dealing with a via-camera issue from the Scratch application. The latest version of scratch uses libv4l2 and requests RGB24 images as that is what it uses internally. via-camera/ov7670 doesn't support RGB24 but libv4l2 kicks in with its format conversion and chooses RGB565, which we

[PATCH] mmp_camera: add MODULE_ALIAS

2011-09-07 Thread Daniel Drake
This enables module autoloading. Signed-off-by: Daniel Drake --- drivers/media/video/marvell-ccic/mmp-driver.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/marvell-ccic/mmp-driver.c b/drivers/media/video/marvell-ccic/mmp-driver.c index d6b7645

[PATCH] [media] via-camera: add MODULE_ALIAS

2011-04-29 Thread Daniel Drake
This fixes autoloading of the module. Signed-off-by: Daniel Drake --- drivers/media/video/via-camera.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/via-camera.c b/drivers/media/video/via-camera.c index 8c780c2..85d3048 100644 --- a/drivers/media

Re: [PATCH] via-camera: Fix OLPC serial check

2011-03-10 Thread Daniel Drake
On 10 March 2011 16:24, Jonathan Corbet wrote: > Did the check need to move for some reason?  If so, a one-of-these-days > nice feature might be to allow changing override_serial at run time. Yes. Otherwise the check would execute if that driver is loaded on XO-1. The check either had to be modif

[PATCH] via-camera: Fix OLPC serial check

2011-03-03 Thread Daniel Drake
eliminate this code when CONFIG_OLPC=n (due to machine_is_olpc() always returning false). Signed-off-by: Daniel Drake --- drivers/media/video/via-camera.c | 83 +- 1 files changed, 37 insertions(+), 46 deletions(-) diff --git a/drivers/media/video/via-camera.c

[PATCH] via-camera: Add suspend/resume support

2011-02-11 Thread Daniel Drake
Add suspend/resume support to the via-camera driver, so that the video continues streaming over a suspend-resume cycle. Originally implemented by Jon Corbet. Signed-off-by: Daniel Drake --- drivers/media/video/via-camera.c | 64 ++ 1 files changed, 64

Re: [RFCv2 PATCH 0/5] Use control framework in cafe_ccic and s_config removal

2011-01-10 Thread Daniel Drake
Hi, >> Another reason why s_config is a bad idea. Thanks a lot for working on this. I had a quick look and don't have any objections. >> This has been extensively tested on my humble OLPC laptop (and it took me 4-5 >> hours just to get the damn thing up and running with these drivers). In futur

Re: [PATCH] via-camera: fix OLPC serial port check

2010-10-28 Thread Daniel Drake
On 28 October 2010 20:08, Jonathan Corbet wrote: > This makes every user carry a bit of OLPC-specific code.  But there are > no non-OLPC users currently, the code is small, and we get rid of some > #ifdefs, which is always a good thing.  Seems good to me. I think the compiler might be smart enoug

via-camera crash on unload (but possibly a wider v4l2 issue)

2010-10-28 Thread Daniel Drake
I can reproduce a crash on via-camera module unload. Running latest linux-next. Simple modprobe then rmmod reproduces it. I guess cafe_ccic is affected too. BUG: unable to handle kernel paging request at 6b6b6b6b IP: device_del I've diagnosed it, but don't know the solution. viacam_remove() call

[PATCH] via-camera: fix OLPC serial port check

2010-10-27 Thread Daniel Drake
6 so there won't be any problems including the olpc.h header directly. Signed-off-by: Daniel Drake --- drivers/media/video/via-camera.c | 82 ++ 1 files changed, 39 insertions(+), 43 deletions(-) diff --git a/drivers/media/video/via-camera.c b/drivers/

[PATCH] cafe_ccic: fix colorspace corruption on resume

2010-10-27 Thread Daniel Drake
http://dev.laptop.org/ticket/10190 Signed-off-by: Daniel Drake --- drivers/media/video/cafe_ccic.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/cafe_ccic.c b/drivers/media/video/cafe_ccic.c index 7bc3667..d147525 100644 --- a/drivers/media/video

[PATCH] cafe_ccic: fix subdev configuration

2010-10-27 Thread Daniel Drake
For some reason, commit 1aafeb30104a is missing one change that was included in the email submission. The sensor configuration must be passed down to the ov7670 subdev. Signed-off-by: Daniel Drake --- drivers/media/video/cafe_ccic.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions

[PATCH 2/2] cafe_ccic: Configure ov7670 correctly

2010-10-19 Thread Daniel Drake
Force smbus communication, disable QCIF mode, and set the correct clock speed on the OLPC XO-1. Signed-off-by: Daniel Drake --- drivers/media/video/cafe_ccic.c | 33 +++-- 1 files changed, 31 insertions(+), 2 deletions(-) diff --git a/drivers/media/video

[PATCH 1/2] ov7670: allow configuration of image size, clock speed, and I/O method

2010-10-19 Thread Daniel Drake
probe routine had to be moved later (into s_config), because we can't do any I/O until we know which I/O method has been selected through this mechanism. Signed-off-by: Daniel Drake --- drivers/media/video/ov7670.c | 133 ++ drivers/media/video/ov767

[PATCH] ov7670: fix QVGA visible area

2010-10-18 Thread Daniel Drake
The QVGA mode has a green horizontal line on the left hand side, and a red (or sometimes blue) vertical line at the bottom. Tweak the visible area to remove them. Thanks to Mauro for explaining how to fix this. Signed-off-by: Daniel Drake --- drivers/media/video/ov7670.c |8 1

Re: [PATCH 2/3] ov7670: disable QVGA mode

2010-10-08 Thread Daniel Drake
On 8 October 2010 22:13, Jonathan Corbet wrote: > A problem like that will be at the controller level, not the sensor > level.  Given that this is an XO-1 report, I'd assume something > requires tweaking in the cafe_ccic driver.  I wasn't aware of this; I > know it worked once upon a time. I repo

Re: [PATCH 1/3] ov7670: remove QCIF mode

2010-10-08 Thread Daniel Drake
On 8 October 2010 22:11, Jonathan Corbet wrote: > I'm certainly not attached to this mode, but...does it harm anybody if > it's there? Yes. Applications like gstreamer will pick this resolution if its the closest resolution to the target file resolution. On XO-1 we always pick a low res so gstrea

Passing info from main dev to subdev

2010-10-08 Thread Daniel Drake
Hi, The cafe_ccic + ov7670 combination is currently broken in mainstream on the OLPC XO-1 laptop because of it's move to i2c (2bf7de4), in order to work on the new XO-1.5 laptop. The smbus IO code was brought back in 467142093 but this code is never triggered - CONFIG_OLPC_XO_1 doesn't exist. I w

[PATCH 3/3] ov7670: Support customization of clock speed

2010-10-08 Thread Daniel Drake
parameter wins over whatever we might have set through the DMI table. Based on earlier work by Jonathan Corbet. Signed-off-by: Daniel Drake --- drivers/media/video/ov7670.c | 71 - 1 files changed, 62 insertions(+), 9 deletions(-) diff --git a/drivers/media

[PATCH 1/3] ov7670: remove QCIF mode

2010-10-08 Thread Daniel Drake
This super-low-resolution mode only captures from a small portion of the sensor FOV, making it a bit useless. Signed-off-by: Daniel Drake --- drivers/media/video/ov7670.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/ov7670.c b/drivers/media

[PATCH 2/3] ov7670: disable QVGA mode

2010-10-08 Thread Daniel Drake
Capturing at this resolution results in an ugly green horizontal line at the left side of the image. Disable until fixed. http://dev.laptop.org/ticket/10231 Signed-off-by: Daniel Drake --- drivers/media/video/ov7670.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a

pending ov7670/cafe_ccic patches

2010-10-02 Thread Daniel Drake
Hi Mauro, Just a quick reminder about 4 pending cafe_ccic/ov7670 patches, all acked by Jon Corbet: http://www.spinics.net/lists/linux-media/msg23371.html http://www.spinics.net/lists/linux-media/msg23373.html http://www.spinics.net/lists/linux-media/msg23372.html http://www.spinics.net/lists/linu

[PATCH 1/4] cafe_ccic: Fix hang in command write processing

2010-09-24 Thread Daniel Drake
delays before reading registers). Reintroduce the 1-second CAFE_SMBUS_TIMEOUT to catch and avoid this strange hardware bug. Signed-off-by: Daniel Drake --- drivers/media/video/cafe_ccic.c | 36 +--- 1 files changed, 17 insertions(+), 19 deletions(-) diff --git

[PATCH 2/4] ov7670: implement VIDIOC_ENUM_FRAMEINTERVALS

2010-09-24 Thread Daniel Drake
From: Jonathan Corbet Inquiring minds (and gstreamer) want to know. Signed-off-by: Jonathan Corbet Signed-off-by: Daniel Drake --- drivers/media/video/ov7670.c | 21 ++--- 1 files changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/ov7670.c b/drivers

[PATCH 3/4] ov7670: implement VIDIOC_ENUM_FRAMESIZES

2010-09-24 Thread Daniel Drake
GStreamer uses this. Signed-off-by: Daniel Drake --- drivers/media/video/ov7670.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/ov7670.c b/drivers/media/video/ov7670.c index f551f63..214cebf 100644 --- a/drivers/media/video/ov7670

[PATCH 4/4] cafe_ccic: Implement VIDIOC_ENUM_FRAMEINTERVALS and ENUM_FRAMESIZES

2010-09-24 Thread Daniel Drake
This allows GStreamer to pick appropriate framerates and resolutions based on desired capture parameters. Signed-off-by: Daniel Drake --- drivers/media/video/cafe_ccic.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/drivers/media/video