Re: [PATCH] staging: davinci: drop pointless static qualifier in vpfe_resizer_init()

2019-03-11 Thread Colin Ian King
On 11/03/2019 14:07, Dan Carpenter wrote: > On Mon, Mar 11, 2019 at 10:14:05PM +0800, Mao Wenan wrote: >> There is no need to have the 'T *v' variable static >> since new value always be assigned before use it. >> >> Signed-off-by: Mao Wenan >> --- >> drivers/staging/media/davinci_vpfe/dm365_resi

Re: [PATCH][next] media: staging: intel-ipu3: fix unsigned comparison with < 0

2019-02-02 Thread Colin Ian King
ping? On 22/12/2018 11:49, Colin King wrote: > From: Colin Ian King > > The comparison css->pipes[pipe].bindex < 0 is always false because > bindex is an unsigned int. Fix this by using a signed integer for > the comparison. > > Detected by CoverityScan, CID#

Re: [PATCH][media-next] media: ddbridge: avoid out-of-bounds write on array demod_in_use

2018-05-08 Thread Colin Ian King
On 08/05/18 11:38, Daniel Scheller wrote: > Hi Colin, > > Am Tue, 8 May 2018 00:08:42 +0100 > schrieb Colin King : > >> From: Colin Ian King >> >> In function stop there is a check to see if state->demod is a stopped >> value of 0xff, however, la

Re: [PATCH] [media] include/media: fix missing | operator when setting cfg

2018-04-18 Thread Colin Ian King
On 18/04/18 16:23, Sylwester Nawrocki wrote: > On 04/18/2018 05:20 PM, Sylwester Nawrocki wrote: >> On 04/18/2018 05:06 PM, Colin King wrote: >>> From: Colin Ian King >>> >>> The value from a readl is being masked with ITE_REG_CIOCAN_MASK however >>&g

Re: [PATCH] [media] bdisp: remove redundant assignment to pix

2017-10-29 Thread Colin Ian King
On 29/10/17 13:30, Julia Lawall wrote: > > > On Sun, 29 Oct 2017, Colin King wrote: > >> From: Colin Ian King >> >> Pointer pix is being initialized to a value and a little later >> being assigned the same value again. Remove the redundant second >>

Re: [PATCH] dvb_frontend: initialize variable s with FE_NONE instead of 0

2017-07-21 Thread Colin Ian King
On 21/07/17 19:05, Shuah Khan wrote: > On 07/21/2017 10:01 AM, Colin King wrote: >> From: Colin Ian King >> >> In a previous commit, we added FE_NONE as an unknown fe_status. >> Initialize variable s to FE_NONE instead of the more opaque value 0. >> >>

Re: [PATCH] staging: fbtft: make const array gamma_par_mask static

2017-07-11 Thread Colin Ian King
On 11/07/17 18:30, Greg Kroah-Hartman wrote: > On Tue, Jul 11, 2017 at 06:20:02PM +0100, Colin King wrote: >> From: Colin Ian King >> >> Don't populate array gamma_par_mask on the stack but instead make it >> static. Makes the object code smaller by 148

NACK: [PATCH] [media] rainshadow-cec: ensure exit_loop is initialized

2017-05-19 Thread Colin Ian King
On 19/05/17 18:39, Colin King wrote: > From: Colin Ian King > > exit_loop is not being initialized, so it contains garbage. Ensure it is > initialized to false. > > Detected by CoverityScan, CID#1436409 ("Uninitialzed scalar variable") > > Fixes: ea6a69defd33

Re: [PATCH] [media] atmel-isc: fix off-by-one comparison and out of bounds read issue

2017-03-09 Thread Colin Ian King
like: > > *hist_count += i * (*hist_entry++); > > *hist_count += hist_entry[i]*i; As long as it gets fixed somehow, then I'm happy. Colin > > > re, > wh >>> >>> On 3/7/2017 22:30, Colin King wrote: >>>> From: Colin Ian King >&

Re: [PATCH] [media] gp8psk: fix spelling mistake: "firmare" -> "firmware"

2016-12-29 Thread Colin Ian King
On 29/12/16 21:23, VDR User wrote: >> - err("firmare chunk size bigger than 64 bytes."); >> + err("firmware chunk size bigger than 64 bytes."); > > Yup. > >> -"HW don't support CMAC encrypiton, use software >> CMAC encrypiton\n"

Re: [PATCH] [media] mb86a20s: remove redundant check if val is less than zero

2016-07-15 Thread Colin Ian King
On 15/07/16 16:20, Mauro Carvalho Chehab wrote: > Em Tue, 12 Jul 2016 10:30:51 +0100 > Colin King escreveu: > >> From: Colin Ian King >> >> The result of mb86a20s_readreg(state, 0x0a) & 0xf is always in the range >> 0x00 to 0x0f and can never be negative, so