Re: sparse and anonymous unions

2014-04-03 Thread Christopher Li
On Mon, Mar 31, 2014 at 10:17 AM, Linus Torvalds wrote: > Chris, mind applying this one too? It removes more lines than it adds > while fixing things, by removing the helper function that isn't good > at anoymous unions, and using another one that does this all right.. The patch is applied. I add

Re: sparse: ioctl defines and "error: bad integer constant expression"

2014-04-03 Thread Christopher Li
On Tue, Apr 1, 2014 at 10:06 AM, Hans Verkuil wrote: > > For all my test cases: > > Signed-off-by: Hans Verkuil > All 3 test cases added. Chris -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: sparse: ioctl defines and "error: bad integer constant expression"

2014-04-01 Thread Christopher Li
On Mon, Mar 31, 2014 at 10:22 AM, Linus Torvalds wrote: > On Mon, Mar 31, 2014 at 1:06 AM, Hans Verkuil wrote: > > Chris, can you please add this to the test cases since Hans did the > work to create a nice small test-case? Sure, I want to add them to the test case. Hans, May I get a signed-off

Re: sparse: ARRAY_SIZE and sparse array initialization

2014-03-30 Thread Christopher Li
On Sun, Mar 30, 2014 at 9:48 AM, Linus Torvalds wrote: > But then when we look up a symbol, we only look at the latest one, so > when we size the array, we look at that "extern" declaration, and > don't see the size that was created with the initializer. Exactly. Sparse need to handle merging of

Re: sparse: ARRAY_SIZE and sparse array initialization

2014-03-29 Thread Christopher Li
On Fri, Mar 28, 2014 at 3:50 AM, Hans Verkuil wrote: > Is there any chance that the three issues I reported will be fixed? If not, > then I'll work around it in the kernel code. > Most likely it is a sparse issue. Can you generate a minimal stand alone test case that expose this bug? I try to sim