Re: [Linux-kernel] [PATCH 03/13] media: adv7604: fix probe of ADV7611/7612

2015-07-24 Thread Ben Dooks
e comparison works as it used to. Forgot the Signed-off-by: line here. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line "unsubscribe linux-medi

Re: [PATCH v6 3/6] rcar_vin: add devicetree support

2014-07-25 Thread Ben Dooks
On 23/07/14 19:23, Guennadi Liakhovetski wrote: > Add support for devicetree probe for the rcar-vin > driver. > > Signed-off-by: Ben Dooks > [g.liakhovet...@gmx.de fix a typo, sort headers alphabetically] > Signed-off-by: Guennadi Liakhovetski > --- > > Ben, is this

Re: [Linux-kernel] [PATCH 0/4] rcar_vin: fix soc_camera WARN_ON() issues.

2014-07-07 Thread Ben Dooks
> Comments welcome! You should have probably CC:d the original authors as well as the linux-sh list and possibly Magnus and Horms. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe fro

[PATCH 6/6] [PATCH v2] ARM: lager: add vin1 node

2014-07-05 Thread Ben Dooks
Add device-tree for vin1 (composite video in) on the lager board. Signed-off-by: Ben Dooks --- Fixes since v1: - Whitespace fixes as suggested by Sergei --- arch/arm/boot/dts/r8a7790-lager.dts | 36 1 file changed, 36 insertions(+) diff --git a

[PATCH 5/6] r8a7790.dtsi: add vin[0-3] nodes

2014-07-05 Thread Ben Dooks
Add nodes for the four video input channels on the R8A7790. Signed-off-by: Ben Dooks --- arch/arm/boot/dts/r8a7790.dtsi | 36 1 file changed, 36 insertions(+) diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi index 7ff2960

[PATCH 3/6] rcar_vin: add devicetree support

2014-07-05 Thread Ben Dooks
Add support for devicetree probe for the rcar-vin driver. Signed-off-by: Ben Dooks --- .../devicetree/bindings/media/rcar_vin.txt | 86 ++ drivers/media/platform/soc_camera/rcar_vin.c | 72 -- 2 files changed, 151 insertions(+), 7 deletions

rcar-vin & soc-camera device tree updates

2014-07-05 Thread Ben Dooks
This is a new patch, with most of the issues from the previous reviews now fixed. If there is anything that I have missed then please let me know. The only issues remaining is what to do about multiple subdevices and/or multiple ports on drivers. I have yet to do either of erroring out or supporti

[PATCH 1/6] adv7180: Remove duplicate unregister call

2014-07-05 Thread Ben Dooks
From: Ian Molton This driver moved over to v4l2_async_unregister_subdev() but still retained a call to v4l2_unregister_subdev(). Remove. Signed-off-by: Ian Molton Signed-off-by: Ben Dooks --- drivers/media/i2c/adv7180.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c

[PATCH 2/6] rcar_vin: copy flags from pdata

2014-07-05 Thread Ben Dooks
The platform data is a single word, so simply copy it into the device's private data structure than keeping a copy of the pointer. This will make changing to device-tree binding easier as it is one allocation instead of two. Signed-off-by: Ben Dooks --- drivers/media/platform/soc_c

[PATCH 4/6] [V3] soc_camera: add support for dt binding soc_camera drivers

2014-07-05 Thread Ben Dooks
been tested on the Renesas Lager board. It currently only supports one input device per driver as this seems to be the standard connection for these devices. Signed-off-by: Ben Dooks --- Fixes since v1: - Fix i2c mclk name compatible with other drivers - Ensure of_node is put after

resend: device tree updates for r8a7790 vin

2014-06-23 Thread Ben Dooks
I've gone through and hopefully cleaned up Sergei's issues. Is there any chance Simon could queue these in his tree? -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/major

[PATCH 2/2] [PATCH v2] ARM: lager: add vin1 node

2014-06-23 Thread Ben Dooks
Add device-tree for vin1 (composite video in) on the lager board. Signed-off-by: Ben Dooks --- Fixes since v1: - Whitespace fixes as suggested by Sergei --- arch/arm/boot/dts/r8a7790-lager.dts | 36 1 file changed, 36 insertions(+) diff --git a

[PATCH 1/2] r8a7790.dtsi: add vin[0-3] nodes

2014-06-23 Thread Ben Dooks
Add nodes for the four video input channels on the R8A7790. Signed-off-by: Ben Dooks --- arch/arm/boot/dts/r8a7790.dtsi | 36 1 file changed, 36 insertions(+) diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi index 7ff2960

Re: [PATCH 7/9] soc_camera: add support for dt binding soc_camera drivers

2014-06-23 Thread Ben Dooks
On 19/06/14 08:28, Guennadi Liakhovetski wrote: > Hi Ben, > > Thanks for an update. > > On Sun, 15 Jun 2014, Ben Dooks wrote: > >> Add initial support for OF based soc-camera devices that may be used >> by any of the soc-camera drivers. The driver itself wil

Re: [PATCH 2/9] ARM: lager: add i2c1, i2c2 pins

2014-06-18 Thread Ben Dooks
On 16/06/14 13:33, Sergei Shtylyov wrote: > Hello. > > On 06/15/2014 11:56 PM, Ben Dooks wrote: > >> Add pinctrl definitions for i2c1 and i2c2 busses on the Lager board >> to ensure these are setup correctly at initialisation time. The i2c0 >> and i2c3 busses ar

Re: [Linux-kernel] RFC: new soc_camera/rcar_vin patch series

2014-06-15 Thread Ben Dooks
On 15/06/14 20:56, Ben Dooks wrote: > This is a new series for the rcar_vin and soc_camera layer > to support using OF. > > It should incorporate most of the feedback from the previous > series, but please let me know if there's anything missed. As > a note, we have skippe

Re: soc_camera and device-tree

2014-06-15 Thread Ben Dooks
verted mt9m111.c and pxa_camera.c, but now I need the linking >> soc_camera. And I don't have a clear idea on how it should be done. New series is on the list. Let me know if there are any issues. I am pushing the series up to git.codethink.co.uk. http://

[PATCH 9/9] ARM: lager: add vin1 node

2014-06-15 Thread Ben Dooks
Add device-tree for vin1 (composite video in) on the lager board. Signed-off-by: Ben Dooks --- arch/arm/boot/dts/r8a7790-lager.dts | 38 + 1 file changed, 38 insertions(+) diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790

[PATCH 7/9] soc_camera: add support for dt binding soc_camera drivers

2014-06-15 Thread Ben Dooks
been tested on the Renesas Lager board. It currently only supports one input device per driver as this seems to be the standard connection for these devices. Signed-off-by: Ben Dooks --- Fixes since v1: - Fix i2c mclk name compatible with other drivers - Ensure of_node is put after

[PATCH 8/9] r8a7790.dtsi: add vin[0-3] nodes

2014-06-15 Thread Ben Dooks
Add nodes for the four video input channels on the R8A7790. Signed-off-by: Ben Dooks --- arch/arm/boot/dts/r8a7790.dtsi | 36 1 file changed, 36 insertions(+) diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi index 7ff2960

[PATCH 3/9] adv7180: Remove duplicate unregister call

2014-06-15 Thread Ben Dooks
From: Ian Molton This driver moved over to v4l2_async_unregister_subdev() but still retained a call to v4l2_unregister_subdev(). Remove. Signed-off-by: Ian Molton Signed-off-by: Ben Dooks --- drivers/media/i2c/adv7180.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/i2c

[PATCH 5/9] rcar_vin: copy flags from pdata

2014-06-15 Thread Ben Dooks
The platform data is a single word, so simply copy it into the device's private data structure than keeping a copy of the pointer. This will make changing to device-tree binding easier as it is one allocation instead of two. Signed-off-by: Ben Dooks --- drivers/media/platform/soc_c

[PATCH 6/9] rcar_vin: add devicetree support

2014-06-15 Thread Ben Dooks
Add support for devicetree probe for the rcar-vin driver. Signed-off-by: Ben Dooks --- .../devicetree/bindings/media/rcar_vin.txt | 86 ++ drivers/media/platform/soc_camera/rcar_vin.c | 72 -- 2 files changed, 151 insertions(+), 7 deletions

[PATCH 4/9] adv7180: add of match table

2014-06-15 Thread Ben Dooks
Add a proper of match id for use when the device is being bound via device tree, to avoid having to use the i2c old-style binding of the device. Signed-off-by: Ben Dooks --- Since original submission: - Fixed of_match_table typo --- drivers/media/i2c/adv7180.c | 11 +++ 1 file

[PATCH 2/9] ARM: lager: add i2c1, i2c2 pins

2014-06-15 Thread Ben Dooks
Add pinctrl definitions for i2c1 and i2c2 busses on the Lager board to ensure these are setup correctly at initialisation time. The i2c0 and i2c3 busses are connected to single function pins. Signed-off-by: Ben Dooks --- arch/arm/boot/dts/r8a7790-lager.dts | 14 ++ 1 file changed

[PATCH 1/9] ARM: lager: enable i2c devices

2014-06-15 Thread Ben Dooks
Add i2c0, i2c1, i2c2 and i2c3 nodes to the Lager reference device tree as these busses all have devices on them that can be probed even if they are no drivers yet. Signed-off-by: Ben Dooks --- arch/arm/boot/dts/r8a7790-lager.dts | 16 1 file changed, 16 insertions(+) diff

RFC: new soc_camera/rcar_vin patch series

2014-06-15 Thread Ben Dooks
This is a new series for the rcar_vin and soc_camera layer to support using OF. It should incorporate most of the feedback from the previous series, but please let me know if there's anything missed. As a note, we have skipped over multiple eps for this release as there are few scenarios for the d

Re: soc_camera and device-tree

2014-06-15 Thread Ben Dooks
tree like : I will put a new series out today for review. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body

Re: [GIT PULL for 3.16-rc1] updates and DT support for adv7604

2014-06-06 Thread Ben Dooks
On 06/06/14 16:51, Lars-Peter Clausen wrote: > On 06/06/2014 05:49 PM, Ben Dooks wrote: >> On 05/06/14 13:55, Mauro Carvalho Chehab wrote: >>> Linus, >>> >>> Please pull from: >>>git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media

Re: [GIT PULL for 3.16-rc1] updates and DT support for adv7604

2014-06-06 Thread Ben Dooks
On 05/06/14 13:55, Mauro Carvalho Chehab wrote: > Linus, > > Please pull from: > git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media > topic/adv76xx > > For adv7604 driver updates, including DT support. Can we use the adv7611 for the adv7612 with

Re: [PATCH v2 48/48] adv7604: Add endpoint properties to DT bindings

2014-04-17 Thread Ben Dooks
issing in the DT bindings documentation. Doesn't the v4l2 helper code have standard parsing for the endpoint sync configurations? -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from thi

Re: [v2] media: soc-camera: OF cameras

2014-04-14 Thread Ben Dooks
ll have a look at your and Ben's soc-camera OF patches to compare them and compare them with my early code (hopefully this coming weekend), but so far it looks like only Ben's solution has a complete working stack. Am I missing something? My bad. I missed the conversation and patches f

Re: [v2] media: soc-camera: OF cameras

2014-04-11 Thread Ben Dooks
-camera OF patches to compare them and compare them with my early code (hopefully this coming weekend), but so far it looks like only Ben's solution has a complete working stack. Am I missing something? I am looking in to fix the comments from Josh to get the atmel to work and hope to h

Re: [RFCv3,3/3] soc_camera: initial of code

2014-04-01 Thread Ben Dooks
On 01/04/14 07:39, Josh Wu wrote: Hi, Ben On 3/31/2014 6:10 PM, Ben Dooks wrote: On 31/03/14 10:28, Josh Wu wrote: Hi, Ben Thanks for the patch, I just test atmel-isi with the your patch, I find the "mclk" registered in soc-camera driver cannot be find by the soc-camera sensors. S

Re: [RFCv3,3/3] soc_camera: initial of code

2014-03-31 Thread Ben Dooks
the i2c sensor can not find this registered mclk as the name is not match. Hmm, this sounds like something that really should go away and be handled by the clk system instead. [snip] -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer

[RFCv3 3/3] soc_camera: initial of code

2014-03-30 Thread Ben Dooks
been tested on the Renesas Lager board. Signed-off-by: Ben Dooks --- drivers/media/platform/soc_camera/soc_camera.c | 111 - 1 file changed, 110 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/drivers/media/platform/soc_camera

[RFCv3 2/3] rcar_vin: add devicetree support

2014-03-30 Thread Ben Dooks
Add support for devicetree probe for the rcar-vin driver. Signed-off-by: Ben Dooks --- Changes since v1: - fix pdev->id handling via usage of alias property Changes since v2: - fix documentation for v1 updates --- .../devicetree/bindings/media/rcar_vin.txt |

[RFCv3 1/3] rcar_vin: copy flags from pdata

2014-03-30 Thread Ben Dooks
The platform data is a single word, so simply copy it into the device's private data structure than keeping a copy of the pointer. This will make changing to device-tree binding easier as it is one allocation instead of two. Signed-off-by: Ben Dooks --- drivers/media/platform/soc_c

[RFCv2] rcar_vin: copy flags from pdata

2014-03-30 Thread Ben Dooks
The platform data is a single word, so simply copy it into the device's private data structure than keeping a copy of the pointer. This will make changing to device-tree binding easier as it is one allocation instead of two. Signed-off-by: Ben Dooks --- drivers/media/platform/soc_c

Re: [RFC 2/3] rcar_vin: add devicetree support

2014-03-30 Thread Ben Dooks
On 30/03/14 22:26, Ben Dooks wrote: Add support for devicetree probe for the rcar-vin driver. Sorry, this was an older branch and needed a fix for the pdev->id field. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codeth

Re: [PATCH 5/5] rcar_vin: add devicetree support

2014-03-30 Thread Ben Dooks
On 30/03/14 22:17, Guennadi Liakhovetski wrote: On Sun, 30 Mar 2014, Ben Dooks wrote: On 30/03/14 22:04, Guennadi Liakhovetski wrote: Hi Ben, Since I never received a reply to this my query, I consider this your patch series suspended. Thanks Guennadi I meant to send out a patch series

[RFC 3/3] soc_camera: initial of code

2014-03-30 Thread Ben Dooks
been tested on the Renesas Lager board. Signed-off-by: Ben Dooks --- drivers/media/platform/soc_camera/soc_camera.c | 111 - 1 file changed, 110 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/drivers/media/platform/soc_camera

[RFC 2/3] rcar_vin: add devicetree support

2014-03-30 Thread Ben Dooks
Add support for devicetree probe for the rcar-vin driver. Signed-off-by: Ben Dooks --- .../devicetree/bindings/media/rcar_vin.txt | 79 ++ drivers/media/platform/soc_camera/rcar_vin.c | 67 -- 2 files changed, 140 insertions(+), 6 deletions

[RFC 1/3] rcar_vin: copy flags from pdata

2014-03-30 Thread Ben Dooks
The platform data is a single word, so simply copy it into the device's private data structure than keeping a copy of the pointer. This will make changing to device-tree binding easier as it is one allocation instead of two. Signed-off-by: Ben Dooks --- drivers/media/platform/soc_c

Re: [PATCH 5/5] rcar_vin: add devicetree support

2014-03-30 Thread Ben Dooks
probe, it is just the soc_camera that needs sorting. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a

Re: [PATCH 2/5] ARM: lager: add vin1 node

2014-03-07 Thread Ben Dooks
On 07/03/14 16:50, Sergei Shtylyov wrote: Hello. On 03/07/2014 04:01 PM, Ben Dooks wrote: Add device-tree for vin1 (composite video in) on the lager board. Signed-off-by: Ben Dooks This patch should have been preceded by the VIN driver patch and bindings description, don't you

Re: [PATCH 1/5] r8a7790.dtsi: add vin[0-3] nodes

2014-03-07 Thread Ben Dooks
On 07/03/14 16:45, Sergei Shtylyov wrote: Hello. On 03/07/2014 04:01 PM, Ben Dooks wrote: Add nodes for the four video input channels on the R8A7790. Signed-off-by: Ben Dooks This patch should have been preceded by the VIN driver patch and bindings description, don't you

[PATCH 3/5] media: soc_camera: rcar_vin: Add support for 10-bit YUV cameras

2014-03-07 Thread Ben Dooks
From: Phil Edworthy Signed-off-by: Phil Edworthy --- drivers/media/platform/soc_camera/rcar_vin.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c index 3b1c05a..702dc47 100644 --- a/drivers

soc_camera rcar_vin support for device-tree binding

2014-03-07 Thread Ben Dooks
This is a series of patches to get towards the point the renesas rcar_vin driver can be bound via device-tree. Patches 1 and 2 add the device tree nodes, patch 3 is one which has been in my tree for a while and the last two modify the rcar_vin driver. -- To unsubscribe from this list: send the lin

[PATCH 2/5] ARM: lager: add vin1 node

2014-03-07 Thread Ben Dooks
Add device-tree for vin1 (composite video in) on the lager board. Signed-off-by: Ben Dooks --- arch/arm/boot/dts/r8a7790-lager.dts | 38 + 1 file changed, 38 insertions(+) diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790

[PATCH 4/5] rcar_vin: copy flags from pdata

2014-03-07 Thread Ben Dooks
The platform data is a single word, so simply copy it into the device's private data structure than keeping a copy of the pointer. This will make changing to device-tree binding easier as it is one allocation instead of two. Signed-off-by: Ben Dooks --- drivers/media/platform/soc_c

[PATCH 1/5] r8a7790.dtsi: add vin[0-3] nodes

2014-03-07 Thread Ben Dooks
Add nodes for the four video input channels on the R8A7790. Signed-off-by: Ben Dooks --- arch/arm/boot/dts/r8a7790.dtsi | 32 1 file changed, 32 insertions(+) diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi index a1e7c39..4c3eafb

[PATCH 5/5] rcar_vin: add devicetree support

2014-03-07 Thread Ben Dooks
Add support for devicetree probe for the rcar-vin driver. Signed-off-by: Ben Dooks --- .../devicetree/bindings/media/rcar_vin.txt | 79 ++ drivers/media/platform/soc_camera/rcar_vin.c | 67 -- 2 files changed, 140 insertions(+), 6 deletions

Re: [PATCH v2] media: soc-camera: OF cameras

2014-03-07 Thread Ben Dooks
struct soc_camera_of_client, node); + /* Don't dead-lock: remove the device here under the lock */ + clear_bit(sofc->sasc.pdev->id, device_map); + list_del(&icd->list); + if (sofc->link_node) + of_n

Re: How to efficiently handle DMA and cache on ARMv7 ? (was "Is get_user_pages() enough to prevent pages from being swapped out ?")

2009-08-06 Thread Ben Dooks
On Thu, Aug 06, 2009 at 12:08:21PM +0200, Laurent Pinchart wrote: > [Resent with an updated subject, this time CC'ing linux-arm-kernel] > > I've spent the last few days "playing" with get_user_pages() and mlock() and > got some interesting results. It turned out that cache coherency comes into >