Re: [PATCH v3 04/26] media: lirc_zilog: remove receiver

2017-10-11 Thread Andy Walls
Hi Sean and Devin: On Wed, 2017-10-11 at 20:25 -0400, Devin Heitmueller wrote: > > There's an ir_lock mutex in the driver to prevent simultaneous > > access to the Rx and Tx functions of the z8. Accessing Rx and Tx > > functions of the chip together can cause it to do the wrong thing > > (sometim

Re: [PATCH v3 04/26] media: lirc_zilog: remove receiver

2017-10-11 Thread Andy Walls
On October 11, 2017 5:02:37 PM EDT, Sean Young wrote: >On Wed, Oct 11, 2017 at 03:43:16PM -0400, Andy Walls wrote: >> On Tue, 2017-10-10 at 08:17 +0100, Sean Young wrote: >> > The ir-kbd-i2c module already handles this very well. >> >> Hi Sean: >> >> It

Re: [PATCH v3 04/26] media: lirc_zilog: remove receiver

2017-10-11 Thread Andy Walls
On Tue, 2017-10-10 at 08:17 +0100, Sean Young wrote: > The ir-kbd-i2c module already handles this very well. Hi Sean: It's been years, but my recollection is that although ir-kdb-i2c might handle receive well, but since the 4 i2c addresses (1 Rx, 1 Tx, 1 IR Tx code learning, 1 custom Tx code) are

PVR-250 Composite 3 unavailable [Re: ivtv driver]

2015-10-26 Thread Andy Walls
On October 26, 2015 7:13:52 PM EDT, Warren Sturm wrote: >Hi Andy. > >I don't know whether this was intended but the pvr250 lost the >composite 3 input when going from kernel version 4.1.10 to 4.2.3. > >This is on a Fedora 22 x86_64 system. > > >Thanks for any insight. Unintentional. I'm guessing

Re: [PATCH v2 2/2] x86/mm/pat, drivers/media/ivtv: move pat warn and replace WARN() with pr_warn()

2015-06-26 Thread Andy Walls
On Fri, 2015-06-26 at 10:45 +0200, Ingo Molnar wrote: > * Luis R. Rodriguez wrote: > > > On Thu, Jun 25, 2015 at 08:51:47AM +0200, Ingo Molnar wrote: > > > > > > * Luis R. Rodriguez wrote: > > > > > > > From: "Luis R. Rodriguez" > > > > > > > > On built-in kernels this warning will always sp

Re: [PATCH 08/14] avoid going past input/audio array

2015-04-28 Thread Andy Walls
S - 1; i++) > if (itv->card->audio_inputs[i].audio_type == 0) > break; > itv->nof_audio_inputs = i; Acked-by: Andy Walls -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 02/14] cx18: avoid going past input/audio array

2015-04-28 Thread Andy Walls
UTS - 1; i++) > if (cx->card->audio_inputs[i].audio_type == 0) > break; > cx->nof_audio_inputs = i; Acked-by: Andy Walls -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] ivtv: use arch_phys_wc_add() and require PAT disabled

2015-04-27 Thread Andy Walls
ice driver requires systems to > boot with PAT disabled, with the nopat kernel parameter. > > This is a worthy comprmise given that the hardware is > really rare these days, and perhaps only some lost souls > in some third world country are expected to be using this > feature

Re: [PATCH] [media] ivtv: use arch_phys_wc_add() and require PAT disabled

2015-04-25 Thread Andy Walls
omise solution. It makes sense. > and perhaps only some lost souls > in some third world country are expected to be using this > feature of the device driver. > > Cc: Mauro Carvalho Chehab > Cc: Andy Lutomirski > Cc: Andy Walls > Cc: Suresh Siddha > Cc: Ingo Molnar

Re: [PATCH] cx18: add missing caps for the PCM video device

2015-04-24 Thread Andy Walls
0,7 @@ static struct { > "encoder PCM audio", > VFL_TYPE_GRABBER, CX18_V4L2_ENC_PCM_OFFSET, > PCI_DMA_FROMDEVICE, >+ V4L2_CAP_TUNER | V4L2_CAP_AUDIO | V4L2_CAP_READWRITE, > }, > { /* CX18_ENC_STREAM_T

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-15 Thread Andy Walls
On Thu, 2015-04-16 at 01:58 +0200, Luis R. Rodriguez wrote: > Hey Andy, thanks for your review, adding Hyong-Youb Kim for review of the > full range ioremap_wc() idea below. > > On Wed, Apr 15, 2015 at 06:38:51PM -0400, Andy Walls wrote: > > Hi All, > > > > On

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-15 Thread Andy Walls
On Wed, 2015-04-15 at 17:58 -0700, Andy Lutomirski wrote: > On Wed, Apr 15, 2015 at 4:59 PM, Andy Walls wrote: > > On Wed, 2015-04-15 at 16:42 -0700, Andy Lutomirski wrote: > >> On Wed, Apr 15, 2015 at 3:38 PM, Andy Walls > >> wrote: > > > >> > >

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-15 Thread Andy Walls
On Wed, 2015-04-15 at 16:52 -0700, Andy Lutomirski wrote: > On Wed, Apr 15, 2015 at 3:50 PM, Andy Walls wrote: > > On Wed, 2015-04-15 at 13:42 -0700, Andy Lutomirski wrote: > >> On Mon, Apr 13, 2015 at 10:49 AM, Luis R. Rodriguez > >> wrote: > >> > >>

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-15 Thread Andy Walls
On Wed, 2015-04-15 at 16:42 -0700, Andy Lutomirski wrote: > On Wed, Apr 15, 2015 at 3:38 PM, Andy Walls wrote: > > > > IMO the right solution would be to avoid ioremapping the whole bar at > startup. Instead ioremap pieces once the driver learns what they are. > This would

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-15 Thread Andy Walls
Hi All, On Mon, 2015-04-13 at 19:49 +0200, Luis R. Rodriguez wrote: [snip] > I only saw a few drivers using overlapping ioremap*() > calls though on my MTRR review and they are all old devices so likely mostly > used on non-PAT systems, but there might be other corner cases elsewhere. > > Lets r

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-15 Thread Andy Walls
On Wed, 2015-04-15 at 13:42 -0700, Andy Lutomirski wrote: > On Mon, Apr 13, 2015 at 10:49 AM, Luis R. Rodriguez wrote: > > > c) ivtv: the driver does not have the PCI space mapped out separately, and > > in fact it actually does not do the math for the framebuffer, instead it > > lets > > the de

Re: [PATCH] staging: media: lirc: lirc_zilog: Fix for possible null pointer dereference

2015-01-30 Thread Andy Walls
On Fri, 2015-01-30 at 08:09 -0500, valdis.kletni...@vt.edu wrote: > On Fri, 30 Jan 2015 16:00:02 +0300, Dan Carpenter said: > > > > > - if (ir == NULL) { > > > > - dev_err(ir->l.dev, "close: no private_data attached to > > > > the file > !\n"); > > > commit be4aa8157c981a8bb9

Re: [PATCH] media: pci: cx18: cx18-alsa-mixer.c: Remove some unused functions

2014-12-20 Thread Andy Walls
On December 20, 2014 8:17:05 PM EST, Rickard Strandqvist wrote: >2014-12-21 1:06 GMT+01:00 Andy Walls : >> On December 20, 2014 5:35:17 PM EST, Rickard Strandqvist > wrote: >>>Removes some functions that are not used anywhere: >>>snd_cx18_mixer_tv_vol_ge

Re: [PATCH] media: pci: cx18: cx18-alsa-mixer.c: Remove some unused functions

2014-12-20 Thread Andy Walls
On December 20, 2014 5:35:17 PM EST, Rickard Strandqvist wrote: >Removes some functions that are not used anywhere: >snd_cx18_mixer_tv_vol_get() snd_cx18_mixer_tv_vol_info() >snd_cx18_mixer_tv_vol_put() > >This was partially found by using a static code analysis program called >cppcheck. > >Signe

Re: [PATCH 05/11] cx25840/cx18: Use standard ordering of mask and shift

2014-11-08 Thread Andy Walls
ift before the mask to match nearly all the other > uses in kernel. > > Signed-off-by: Joe Perches The patch is technically correct. Reviewed-by: Andy Walls > --- > drivers/media/i2c/cx25840/cx25840-core.c | 12 ++-- > drivers/media/pci/cx18/cx18-av-core.c

Re: staging: media: lirc: lirc_zilog.c: replace custom print macros with dev_* and pr_*

2014-11-06 Thread Andy Walls
On November 6, 2014 8:54:28 AM EST, Andy Walls wrote: >On November 6, 2014 8:21:13 AM EST, Sean Young wrote: >>On Thu, Nov 06, 2014 at 11:05:49AM -0200, Mauro Carvalho Chehab wrote: >>> Hi Sean, >>> >>> Em Thu, 06 Nov 2014 12:46:29 + >>> Sean You

Re: VBI on PVR-500 stopped working between kernels 3.6 and 3.13

2014-10-26 Thread Andy Walls
On October 26, 2014 5:35:30 PM EDT, Christopher Neufeld wrote: >Andy, > >On Sun, 26 Oct 2014 13:41:14 -0400, Andy Walls > said: > >> Can you verify that > >> v4l2-ctl -d --get-fmt-sliced-vbi --get-ctrl=stream_vbi_format > >> also fails, and that >

Re: VBI on PVR-500 stopped working between kernels 3.6 and 3.13

2014-10-26 Thread Andy Walls
On Sun, 2014-10-26 at 13:41 -0400, Andy Walls wrote: > Hi Chris, > > On Sun, 2014-10-26 at 08:10 -0400, Christopher Neufeld wrote: > > Hello Hans, > > > > On Sun, 26 Oct 2014 06:50:36 +0100, Hans Verkuil said: > > > > >> The script that

Re: VBI on PVR-500 stopped working between kernels 3.6 and 3.13

2014-10-26 Thread Andy Walls
Hi Chris, On Sun, 2014-10-26 at 08:10 -0400, Christopher Neufeld wrote: > Hello Hans, > > On Sun, 26 Oct 2014 06:50:36 +0100, Hans Verkuil said: > > >> The script that I use to set up captions invokes this command: > >> v4l2-ctl -d --set-fmt-sliced-vbi=cc --set-ctrl=stream_vbi_format=1 > >> >

Re: VBI on PVR-500 stopped working between kernels 3.6 and 3.13

2014-10-26 Thread Andy Walls
On October 26, 2014 1:50:36 AM EDT, Hans Verkuil wrote: >Hi Christopher, > >On 10/26/2014 01:15 AM, Christopher Neufeld wrote: >> I've been using a PVR-500 to record shows in MythTV, and to capture >the VBI >> part of the stream from the standard-definition output of my STB when >it >> records hig

Re: strange empia device

2014-09-02 Thread Andy Walls
On September 2, 2014 2:28:23 AM EDT, Lorenzo Marcantonio wrote: >On Mon, Sep 01, 2014 at 07:58:52PM -0400, Andy Walls wrote: >> A Merlin firmware of 16 kB strongly suggests that this chip has an >> integarted Conexant CX25843 (Merlin Audio + Thresher Video = Mako) >> Broadt

Re: strange empia device

2014-09-01 Thread Andy Walls
On Sun, 2014-08-31 at 16:47 +0200, Frank Schäfer wrote: > Hi Lorenzo, > > Am 25.08.2014 um 21:01 schrieb Lorenzo Marcantonio: > > Just bought a roxio video capture dongle. Read around that it was an > > easycap clone (supported, then); it seems it's not so anymore :( > > > > It identifies as 1b80:

Fwd: Re: CX23885 error during boot

2014-08-10 Thread Andy Walls
> >Dear Media Community: > Since switching to CentOS7 and the 3.10.0-123 kernel as listed below: >> Linux mythbox.lightfoot.us 3.10.0-123.6.3.el7.x86_64 #1 SMP Wed Aug >> 6 21:12:36 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux > > I keep getting the following in dmesg related to my Hauppage Vi

Re: [PATCHv1 02/12] vivid.txt: add documentation for the vivid driver.

2014-08-01 Thread Andy Walls
On August 1, 2014 11:33:26 AM EDT, Antti Palosaari wrote: > > >On 08/01/2014 06:19 PM, Antonio Ospite wrote: >> On Fri, 01 Aug 2014 12:14:15 +0200 >> Hans Verkuil wrote: >> >>> On 07/31/2014 09:16 PM, Andy Walls wrote: >>>> On Wed, 2014-07-30 at 1

Re: [PATCHv1 02/12] vivid.txt: add documentation for the vivid driver.

2014-07-31 Thread Andy Walls
On Wed, 2014-07-30 at 16:23 +0200, Hans Verkuil wrote: > From: Hans Verkuil > > The vivid Virtual Video Test Driver helps testing V4L2 applications > and can emulate V4L2 hardware. Add the documentation for this driver > first. > > Signed-off-by: Hans Verkuil > --- > Documentation/video4linux/

Re: Best way to add subdev that doesn't use I2C or SPI?

2014-06-21 Thread Andy Walls
On June 21, 2014 7:17:07 AM EDT, Andy Walls wrote: >On June 20, 2014 9:58:19 PM EDT, Devin Heitmueller > wrote: >>Hello, >> >>I'm in the process of adding support for a new video decoder. However >>in this case it's an IP block on a USB bridge as oppos

Re: Best way to add subdev that doesn't use I2C or SPI?

2014-06-21 Thread Andy Walls
On June 20, 2014 9:58:19 PM EDT, Devin Heitmueller wrote: >Hello, > >I'm in the process of adding support for a new video decoder. However >in this case it's an IP block on a USB bridge as opposed to the >typical case which is an I2C device. Changing registers for the >subdev is the same mechan

Re: bttv and colorspace

2014-06-20 Thread Andy Walls
On Fri, 2014-06-20 at 09:07 +0200, Hans Verkuil wrote: > Hi Mauro, > > I wonder if you remember anything about the reported broken colorspace > handling > of bttv. The spec talks about V4L2_COLORSPACE_BT878 where the Y range is > 16-253 > instead of the usual 16-235. > > I downloaded a bt878 da

Re: Conexant PCI-8604PW 4 channel BNC Video capture card (bttv)

2014-01-20 Thread Andy Walls
Robert Longbottom wrote: > >Hi, > >I've just bought one of these cards which is based on the Conexant >Fusion 878A chip thinking it would just work under Linux being >bttv-based. Unfortunately (for me) it's not and it is just picked up >as >a generic unknown card by the bttv driver. > >Does anyon

tda8290 broken badly with cx18 (Re: Kernel crash with modprobe cx18)

2014-01-11 Thread Andy Walls
ro Carvalho Chehab > > :04 04 f2492f3c86adf77f671bcda6bd9fcc3541b69e48 > 9e42c49fecb111f2f6aec6102bed1e29194a2fd5 Mdrivers > :04 04 23c5843c6a01e8b8a69bd2237a2d2f1e5aa7a154 > d7937ce34beccf87efcffb742504a1c545e6a9eb Minclude > > Regards, > Scott

Re: [PATCH] [media] cx18: introduce a helper function to avoid array overrun

2014-01-11 Thread Andy Walls
On Fri, 2014-01-10 at 14:06 +0100, Hans Verkuil wrote: > Also CC to linux-media and Andy Walls who maintains this driver. > > Regards, > > Hans > > On 01/06/14 16:07, Ethan Zhao wrote: > > cx18_i2c_register() is called in cx18_init_subdevs() with index > &

Re: Fwd: v4l2: The device does not support the streaming I/O method.

2014-01-01 Thread Andy Walls
On Wed, 2014-01-01 at 17:22 -0500, Devin Heitmueller wrote: > On Wed, Jan 1, 2014 at 5:21 PM, Devin Heitmueller > wrote: > > On Wed, Jan 1, 2014 at 5:18 PM, Andy Walls wrote: > >> uncompressed video is available from /dev/video32 in an odd Conexant > >> macroblo

Re: Fwd: v4l2: The device does not support the streaming I/O method.

2014-01-01 Thread Andy Walls
On Wed, 2014-01-01 at 14:46 -0500, Devin Heitmueller wrote: > On Wed, Jan 1, 2014 at 2:41 PM, Andy wrote: > > I am trying to stream /dev/video0 to http and encode it in h.264. > > Last I checked, the ffmpeg v4l2 input interface is just for raw video. > What you probably want to do is just use v4

Re: Fwd: v4l2: The device does not support the streaming I/O method.

2014-01-01 Thread Andy Walls
mand line argument to play back the stream. Regards, Andy > On Sat, Dec 28, 2013 at 1:15 PM, Andy Walls wrote: > > On Fri, 2013-12-27 at 00:37 -0500, Andy wrote: > >> I am trying to capture input from /dev/video0 which is Hauppauge Win > >> 150 MCE PCI card but I g

Re: HVR-1800/1850 aka CX23885

2014-01-01 Thread Andy Walls
Hi Bob: (CC-ing linux-media mailing list.) On Mon, 2013-12-30 at 16:45 -0500, Bob Lightfoot wrote: > Dear Andy: >Based on what I read here > {http://ivtvdriver.org/pipermail/ivtv-users/2009-June/009460.html} you > are or were maintaining the cx18 driver for Fedora. >I have been running a

Re: Fwd: v4l2: The device does not support the streaming I/O method.

2013-12-28 Thread Andy Walls
On Fri, 2013-12-27 at 00:37 -0500, Andy wrote: > I am trying to capture input from /dev/video0 which is Hauppauge Win > 150 MCE PCI card but I get the following error which has no record on > google > > [video4linux2,v4l2 @ 0xb080d60] The device does not support the > streaming I/O method. > /dev/

Re: [ivtv-users] Kernel crash with modprobe cx18

2013-12-28 Thread Andy Walls
ay check to isolate > this problem. I'll say not much at this point; unless you want to start bisecting kernel source code revisions and compiling, installing, and tetsing custom kernels. Regards, Andy > Thanks, > Scott > > > On Thu, Dec 19, 2013 at 7:11 PM, Andy Walls

Re: [ivtv-users] Kernel crash with modprobe cx18

2013-12-19 Thread Andy Walls
On Thu, 2013-12-19 at 07:00 -0600, Scott Robinson wrote: > Please see attachment. Many thanks for your response. > On Wed, Dec 18, 2013 at 7:40 PM, Andy Walls wrote: > > On Wed, 2013-12-18 at 13:06 -0600, Scott Robinson wrote: > >> I am running Fedora 18, x86_64, and recent

Re: [ivtv-users] Kernel crash with modprobe cx18

2013-12-18 Thread Andy Walls
On Wed, 2013-12-18 at 13:06 -0600, Scott Robinson wrote: > I am running Fedora 18, x86_64, and recently updated the kernel to > 3.11.10-100.fc18 from 3.6.10-4.fc18. > > When I try to install the cx18 module, the kernel crashes with the following: Can you provide the output of $ objdump

Re: [PATCH RFC] videobuf2: Improve file I/O emulation to handle buffers in any order

2013-11-22 Thread Andy Walls
Hi Hans, On Thu, 2013-11-21 at 14:52 +0100, Hans Verkuil wrote: > Hi Andy, > > This seems more complex than is necessary. See my comments below... > > On 11/21/13 02:05, Andy Walls wrote: > > (This patch is RFC, because it was compiled and tested against kernel > > v3

Re: [patch] [media] cx18: check for allocation failure in cx18_read_eeprom()

2013-11-22 Thread Andy Walls
On Fri, 2013-11-22 at 10:21 +0100, Hans Verkuil wrote: > Andy, > > Should we perhaps change the MAINTAINERS file to point to the linux-media list > instead? Yes. When I get time this weekend, I can submit a patch; unless you beat me to it. Regards, Andy > Regards, > > Hans > > On 11/22

Re: [patch] [media] cx18: check for allocation failure in cx18_read_eeprom()

2013-11-22 Thread Andy Walls
: struct i2c_client is too big for stack') > Signed-off-by: Dan Carpenter Acked-by: Andy Walls > diff --git a/drivers/media/pci/cx18/cx18-driver.c > b/drivers/media/pci/cx18/cx18-driver.c > index c1f8cc6f14b2..716bdc57fac6 100644 > --- a/drivers/media/pci/cx18/cx18-driver

Re: [PATCH RFC] videobuf2: Improve file I/O emulation to handle buffers in any order

2013-11-21 Thread Andy Walls
Hans Verkuil wrote: >Hi Andy, > >This seems more complex than is necessary. See my comments below... > >On 11/21/13 02:05, Andy Walls wrote: >> (This patch is RFC, because it was compiled and tested against kernel >> v3.5) >> >> videobuf2 file I/O emulation

Re: [PATCH RFC] videobuf2: Improve file I/O emulation to handle buffers in any order

2013-11-21 Thread Andy Walls
to my upcoming > patch series in order to prevent merge conflicts. I'll know more later > today. Hi Hans, That sounds good to me. :) I have 4 comments on my own stuff below: > On 11/21/2013 02:05 AM, Andy Walls wrote: > > (This patch is RFC, because it was compiled and tested

[PATCH RFC] videobuf2: Improve file I/O emulation to handle buffers in any order

2013-11-20 Thread Andy Walls
emove the, AFAICT, assumption that only read() calls would need to dequeue a buffer from the driver. Also set the buf->size properly, if a write() dequeues a buffer. Signed-off-by: Andy Walls Cc: Kyungmin Park Cc: PawelOsciak Cc: Marek Szyprowski diff --git a/drivers/media/video/videobuf

Re: [PATCH RFC] libv4lconvert: SDR conversion from U8 to FLOAT

2013-11-11 Thread Andy Walls
On Sun, 2013-11-10 at 19:16 +0200, Antti Palosaari wrote: > Convert unsigned 8 to float 32 [-1 to +1], which is commonly > used format for baseband signals. Hi Annti, I don't think this a good idea. Floating point representations are inherently non-portable. Even though most everything now uses

Re: ivtv 1.4.2/1.4.3 broken in recent kernels?

2013-11-11 Thread Andy Walls
On Mon, 2013-11-11 at 12:14 +0100, Hans Verkuil wrote: > On 10/19/2013 07:09 PM, Andy Walls wrote: > > On Wed, 2013-10-16 at 01:10 +0100, Rajil Saraswat wrote: > >> I was finally able to carry out a git bisect. Had to do a git pull on > >> a fast internet hooked machin

Re: ivtv 1.4.2/1.4.3 broken in recent kernels?

2013-11-05 Thread Andy Walls
On Mon, 2013-11-04 at 13:44 +0100, Hans Verkuil wrote: > On 10/19/2013 07:09 PM, Andy Walls wrote: > > On Wed, 2013-10-16 at 01:10 +0100, Rajil Saraswat wrote: > > Try applying the following (untested) patch that is made against the > > bleeding edge Linux kernel. The tes

Re: [PATCH v3 04/29] [media] cx18: struct i2c_client is too big for stack

2013-11-05 Thread Andy Walls
On Tue, 2013-11-05 at 08:01 -0200, Mauro Carvalho Chehab wrote: > drivers/media/pci/cx18/cx18-driver.c: In function 'cx18_read_eeprom': > drivers/media/pci/cx18/cx18-driver.c:357:1: warning: the frame size of > 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=] > That happens

Re: ivtv 1.4.2/1.4.3 broken in recent kernels?

2013-10-19 Thread Andy Walls
On Wed, 2013-10-16 at 01:10 +0100, Rajil Saraswat wrote: > I was finally able to carry out a git bisect. Had to do a git pull on > a fast internet hooked machine and ftp the files over to the remote > machine. > > I started with 'git bisect bad v2.6.36.4' and 'git bisect good v2.6.35.10'. > > And

Re: [media-workshop] V2: Agenda for the Edinburgh mini-summit

2013-10-16 Thread Andy Walls
On Thu, 2013-10-17 at 08:36 +0900, Milo Kim wrote: > > That's current solution, we plan to unify this two API since those > > chip are basically LED. > > > >> On the other hands, LM3642 has an indicator mode with flash/torch. > >> Then, it will consist of 3 parts - MFD core, LED(indicator) and > >

Re: ivtv 1.4.2/1.4.3 broken in recent kernels?

2013-10-13 Thread Andy Walls
On Sun, 2013-10-13 at 20:14 +0100, Rajil Saraswat wrote: > > OK, I just tested with my Wii game console connected to the PVR-500 unit > > #2, Fedora 17, kernel 3.6.10-2.fc17.x86_64. > > > > 1. With the unit set to 'Input 2, Composite 1', cx25840 'Composite 3': > > Good video, good audio > > > > 2.

Re: ivtv 1.4.2/1.4.3 broken in recent kernels?

2013-10-13 Thread Andy Walls
On Sat, 2013-10-12 at 19:23 -0400, Andy Walls wrote: > On Thu, 2013-10-10 at 22:00 +0100, Rajil Saraswat wrote: > > On 10 October 2013 03:20, Andy Walls wrote: > > > On Wed, 2013-09-18 at 02:19 +0530, Rajil Saraswat wrote: > > >> Hi, > > >> >

Re: ivtv 1.4.2/1.4.3 broken in recent kernels?

2013-10-12 Thread Andy Walls
On Thu, 2013-10-10 at 22:00 +0100, Rajil Saraswat wrote: > On 10 October 2013 03:20, Andy Walls wrote: > > On Wed, 2013-09-18 at 02:19 +0530, Rajil Saraswat wrote: > >> Hi, > >> > >> I have a couple of PVR-500's which have additional tuners con

Re: ivtv 1.4.2/1.4.3 broken in recent kernels?

2013-10-09 Thread Andy Walls
On Wed, 2013-09-18 at 02:19 +0530, Rajil Saraswat wrote: > Hi, > > I have a couple of PVR-500's which have additional tuners connected > to them (using daughter cards). The PVR-500's don't have daughter cards with additional tuners AFAIK. There is this however: http://www.hauppauge.com/site/we

Re: [PATCH 19/26] ivtv: Convert driver to use get_user_pages_unlocked()

2013-10-05 Thread Andy Walls
/cgit/linux/kernel/git/jack/linux-fs.git/commit/?h=get_user_pages&id=624fc1bfb70fb65d32d31fbd16427ad9c234653e If I found the correct patch for adding get_user_pages_unlocked(), then the patch below looks fine. Reviewed-by: Andy Walls Acked-by: Andy Walls Regards, Andy On Wed, 2013-10-0

Re: Capture driver implementation issue/questions

2013-09-27 Thread Andy Walls
On Thu, 2013-09-26 at 14:57 +, Rick Ball wrote: > Hi All, > > I'm working on a video capture driver (my first) for a custom board, > and I have a few questions about handling 'overflow' conditions (when > the application doesn't get back in time to de-queue every frame). I > know that one way

Re: [PATCH 1/3] media: i2c: Add ADV761X support

2013-09-24 Thread Andy Walls
Hans Verkuil wrote: >On 09/24/2013 06:19 PM, Guennadi Liakhovetski wrote: >> Hi Hans >> >> On Tue, 24 Sep 2013, Hans Verkuil wrote: >> >>> Shouldn't the interrupt_service_routine() op be implemented as well? >>> Usually these drivers will generate interrupts if e.g. the format >changes. >> >> S

Re: dvb_device_open: possible circular locking dependency detected

2013-08-26 Thread Andy Walls
Knut Petersen wrote: >As long as I use the "Hauppauge WinTV Nova-HD-S2", nobody seems to be >really interested in silencing deadlock warnings triggered by >dvb_device_open(). > >dvb lockdep problems are old, see Andy Walls mail written in 2010 >

Re: A false alarm for recursive lock in v4l2_ctrl_add_handler

2013-08-21 Thread Andy Walls
larm. >> >> Regards, >> >> Hans >> > >Sorry I didn't notice the fix, Is it this one? > >commit 6cd247ef22e493e1884e576c01538b031981 >Author: Andy Walls >Date: Sat Mar 9 05:55:11 2013 -0300 > >[media] v4l2-ctrls: eliminate lockdep false alarms for stru

Re: Fw: [PATCH] Fixed misleading error when handling IR interrupts.

2013-08-21 Thread Andy Walls
at least since 2.6.32). I must have misinterpreted the meaning of the return value when I added in that error message long ago. Regards, Andy Acked-by: Andy Walls >Signed-off-by: Luis Alves >--- > drivers/media/pci/cx23885/cx23885-core.c |5 + > 1 file changed, 1 insertion(

Re: [PATCH] cx23885[v4]: Fix interrupt storm when enabling IR receiver.

2013-07-27 Thread Andy Walls
cx23885_flatiron_read(dev, 0x1f)); should work as well, since the set interrupt status bit will clear that bit on the write back of the bit. But this patch is good enough. :) Acked-by: Andy Walls > --- > drivers/media/pci/cx23885/cx23885-av.c| 13

Re: [PATCH] cx23885[v2]: Fix IR interrupt storm.

2013-07-19 Thread Andy Walls
Luis Alves wrote: >Hi Max, > >Should have thought on that! I'll change it to preserve all other bits. > >Thanks, >Luis > > >On Fri, Jul 19, 2013 at 4:37 AM, nibble.max >wrote: >> Hello Luis, >> The internel interrupts are rounted as follow: >> flatiron(include ADC)--->HammerHead(include IR insid

Re: [PATCH] cx23885: Fix interrupt storm that happens in some cards when IR is enabled.

2013-07-18 Thread Andy Walls
On Wed, 2013-07-17 at 22:41 -0400, Devin Heitmueller wrote: > On Wed, Jul 17, 2013 at 10:15 PM, Antti Palosaari wrote: > > hmm, I looked again the cx23885 driver. > > > > 0x4c == [0x98 >> 1] = "flatiron" == some internal block of the chip > > Yeah, ok. Pretty sure Flatiron is the codename for th

Re: [PATCH 00/50] USB: cleanup spin_lock in URB->complete()

2013-07-14 Thread Andy Walls
On Thu, 2013-07-11 at 17:05 +0800, Ming Lei wrote: > Hi, > > As we are going to run URB->complete() in tasklet context[1][2], Hi, Please pardon my naivete, but why was it decided to use tasklets to defer work, as opposed to some other deferred work mechanism? It seems to me that getting rid of

Re: [RFC 1/3] saa7115: Set saa7113 init to values from datasheet

2013-05-29 Thread Andy Walls
Mauro Carvalho Chehab wrote: >Em Wed, 29 May 2013 22:41:16 +0200 >Jon Arne Jørgensen escreveu: > >> Change all default values in the initial setup table to match the >table >> in the datasheet. > >This is not a good idea, as it can produce undesired side effects >on the existing drivers that dep

Re: saa7115/gm7113c - device specific initialization

2013-05-20 Thread Andy Walls
"Jon Arne Jørgensen" wrote: >On Mon, May 20, 2013 at 06:33:20AM -0400, Andy Walls wrote: >> "Jon Arne Jørgensen" wrote: >> >> >Hi, >> >I've recently discovered that the smi2021 device have some pretty >> >specific >> &

Re: saa7115/gm7113c - device specific initialization

2013-05-20 Thread Andy Walls
"Jon Arne Jørgensen" wrote: >Hi, >I've recently discovered that the smi2021 device have some pretty >specific >needs for the setup of the gm7113c chip. > >Both the smi2021 driver and the stk1160 driver needs registers >0x14 -> 0x17 to be zeroed, this is what forced me to add the gm7113c >chip to

Re: cx18 list corruption and related problems

2013-04-09 Thread Andy Walls
On Tue, 2013-04-09 at 10:50 +0100, Tvrtko Ursulin wrote: > Hi Andy, all, > > Were there any known problems in the cx18 locking department regarding video > buffers or mailbox handling fixed sometime between 3.5.0 and today? No. > We are seeing some issues there (on a flavour of 3.5.0) and I ju

Re: cannot unload cx18_alsa to hibernate Mint13 64 computer

2013-03-10 Thread Andy Walls
Dixon Craig wrote: >Thanks Andy > >Pulse was indeed respawning. >Once I got it killed for certain, I was able to rmmod cx18_alsa and >cx18, >then hibernate and wake up worked without problem. > >On wake up, I tried modprobe cx18_alsa, but it just hung. I exited >by >pressing ctrl-c, and lsmod

Re: cannot unload cx18_alsa to hibernate Mint13 64 computer

2013-03-09 Thread Andy Walls
On Sat, 2013-03-09 at 21:57 +, Dixon Craig wrote: > Hello and thank you to all linuxtv developers! > > I have my hauppuage pvr-1600 working very nicely for us-cable analog and > composite inputs using cx18 from original linuxmint 13 MATE 64 and I also > tried > newest drivers from git.linux

Re: drxk driver statistics

2013-03-07 Thread Andy Walls
Oliver Schinagl wrote: >On 03/06/13 18:36, Jean Delvare wrote: >> Hi all, >> >> I have a TerraTec Cinergy T PCIe Dual card, with DRX-3916K and >> DRX-3913K frontends. I am thus using the drxk dvb-frontend driver. >> While trying to find the best antenna, position and amplification, I >> found tha

Re: Firmware for cx23885 in linux-firmware.git is broken

2013-02-24 Thread Andy Walls
Hi, Instead of answering points in the email chain, I'm just going to provide the best information I have. I. Definitions: - Thresher: broadcast video decoder - Merlin: broadcast audio system detection microcontroller and decoder - Mako: Thresher + Merlin - CX2583[67]: stand-alone Thresh

Re: 3.7/3.8 kernel won't boot with Hauppauge pvr-150

2013-02-22 Thread Andy Walls
On Thu, 2013-02-21 at 22:32 -0500, Andy Walls wrote: > Ron Andreasen wrote: > > >I've been having trouble getting distros that have any kernel above the > >3.5 > >series to boot (only tried 64-bit). I get a black screen with a bunch > >of > >text and

Re: 3.7/3.8 kernel won't boot with Hauppauge pvr-150

2013-02-21 Thread Andy Walls
Ron Andreasen wrote: >I've been having trouble getting distros that have any kernel above the >3.5 >series to boot (only tried 64-bit). I get a black screen with a bunch >of >text and the boot process goes no further. I don't know if this is >usually >okay, but I'm posting a link to a picture I t

Re: Wrongly identified easycap em28xx

2013-02-20 Thread Andy Walls
Theodore Kilgore wrote: > > >On Tue, 19 Feb 2013, Mauro Carvalho Chehab wrote: > >> Em Tue, 19 Feb 2013 20:45:21 +0100 >> Frank Sch?fer escreveu: >> >> > Am 19.02.2013 19:53, schrieb Mauro Carvalho Chehab: >> > > Em Tue, 19 Feb 2013 19:45:29 +0100 >> > > Frank Sch?fer escreveu: >> > > >> > >>>

Re: possible recursive locking: find_ref_lock() / v4l2_ctrl_add_handler()

2013-02-10 Thread Andy Walls
On Sun, 2013-02-10 at 11:54 +0100, Hans Verkuil wrote: > On Sun February 10 2013 11:34:11 Knut Petersen wrote: > > Maybe somebody could have at that old locking warning: > > It's a false warning. If someone can point me to some documentation on how to > tell lockdep that it isn't a deadlock, then

Re: [RFC PATCH] ivtv-alsa: regression fix: remove __init from ivtv_alsa_load

2013-02-07 Thread Andy Walls
Hans Verkuil wrote: >On Thu February 7 2013 22:58:53 Andy Walls wrote: >> Hans Verkuil wrote: >> >> >Andy, >> > >> >Please review this patch. This fix probably should be fast-tracked >to >> >3.8 and >> >queued for stable 3.7. >

Re: [RFC PATCH] ivtv-alsa: regression fix: remove __init from ivtv_alsa_load

2013-02-07 Thread Andy Walls
t ivtv *itv) >+static int ivtv_alsa_load(struct ivtv *itv) > { > struct v4l2_device *v4l2_dev = &itv->v4l2_dev; > struct ivtv_stream *s; >-- >1.7.10.4 Hans, I concur. Now I have to check cx18 for the same problem. Your patch looks good. Reviewed-by: Andy Wal

Re: [ivtv-users] cx18 module causes freeze after kernel upgrade

2013-01-19 Thread Andy Walls
On Fri, 2013-01-18 at 14:23 -0500, Kyle Lil wrote: > I'm having trouble getting drivers installed for my Hauppauge HVR-1600 > in recent kernels. In Mythbuntu 12.04, I first tried upgrading to 3.4 > kernel or 3.3 kernel. After installing each of these, I booted into > the new kernel, then downloaded

Re: [PATCH 5/5] kfifo: log based kfifo API

2013-01-08 Thread Andy Walls
Dmitry Torokhov wrote: >Hi Yuanhan, > >On Tue, Jan 08, 2013 at 10:57:53PM +0800, Yuanhan Liu wrote: >> The current kfifo API take the kfifo size as input, while it rounds >> _down_ the size to power of 2 at __kfifo_alloc. This may introduce >> potential issue. >> >> Take the code at drivers/hid

Re: [PATCH v2] media: cx18, ivtv: eliminate unnecessary array index checks

2013-01-06 Thread Andy Walls
tive because arrays were >being dereferenced using the index before the check. > >Signed-off-by: Nickolai Zeldovich >--- >Thanks to Andy Walls for suggesting that instead of moving the checks >before array dereference, a better fix is to remove the checks >altogether, >since the

Re: [PATCH] media: cx18, ivtv: do not dereference array before index check

2013-01-06 Thread Andy Walls
On Sat, 2013-01-05 at 14:11 -0500, Nickolai Zeldovich wrote: > Move dereferencing of hw_devicenames[], hw_bus[] arrays until after > checking that idx is within range. > > Signed-off-by: Nickolai Zeldovich Hi Nickolai, My comments are in line below. > --- > drivers/media/pci/cx18/cx18-i2c.c |

Re: [PATCH] [media] ivtv: ivtv-driver: Replace 'flush_work_sync()'

2013-01-06 Thread Andy Walls
ormal end-user, it will never be a problem. FWIW: Acked-by: Andy Walls Regards, Andy > > > > Thanks, > > Mauro > > > > Forwarded message: > > > > Date: Wed, 24 Oct 2012 10:14:16 -0200 > > From: Fabio Estevam > > To: awa...@md.metrocast

Re: ivtv driver inputs randomly "block"

2012-11-29 Thread Andy Walls
On Thu, 2012-11-29 at 12:29 -0300, Ezequiel Garcia wrote: > Hi Brian, > > See my comments below. > > On Wed, Nov 28, 2012 at 8:19 PM, Brian J. Murrell > wrote: > > On 12-11-28 08:13 AM, Ezequiel Garcia wrote: > >> > >> Try again with > >> modprobe ivtv ivtv_debug=10 > > > > OK. Happened again.

Re: anyone here know anyone at ivtvdriver.org? it's been down a few days now

2012-11-28 Thread Andy Walls
"Brian J. Murrell" wrote: >I wonder if anyone here has control over or knows anyone who has >control >over the ivtvdriver.org website and lists. > >They seem to be down and have been for a bit now. > >Does anyone know if there is any expectation that this stuff will come >back or is headed for mo

Re: Poor HVR 1600 Video Quality - Feedback for Devin Heitmueller 2012-11-24

2012-11-25 Thread Andy Walls
On Sat, 2012-11-24 at 23:08 -0500, Bob Lightfoot wrote: > Devin : > Let me see if I can answer some of your questions. > > > 2. Links on Google to files related to this issue : > A. The Main Can on the Tuner Card - >https://docs.google.com/open?id=0B95B_9punKEmeHBUNHprMnVNV00 > B.

Re: ir rremote support for TeVii S471

2012-11-12 Thread Andy Walls
On Mon, 2012-11-12 at 10:04 +0100, Joakim Hernberg wrote: > Hello, > > First of all, thanks a lot for adding the S471 support to the kernel. > It appears to work very well on 3.6 which is what I'm running. > > I am trying to get the included ir remote working. Tried the > enable_885_ir=1 module

Re: [PATCH] cx23885: Added support for AVerTV Hybrid Express Slim HC81R (only analog)

2012-11-04 Thread Andy Walls
On Sun, 2012-11-04 at 09:59 +0200, Oleg Kravchenko wrote: > субота, 03-лис-2012 16:41:10 Andy Walls написано: > > Oleg Kravchenko wrote: > > >Hello! Please review my patch. > > > > > >Supported inputs: > > >Television, S-Video, Component. > > &g

Re: [PATCH] cx23885: Added support for AVerTV Hybrid Express Slim HC81R (only analog)

2012-11-03 Thread Andy Walls
Oleg Kravchenko wrote: >Hello! Please review my patch. > >Supported inputs: >Television, S-Video, Component. > >Modules options: >options cx25840 firmware=v4l-cx23418-dig.fw Hi, Please do not use the CX23418 digitizer firmware with the CX2388[578] chips. Use the proper cx23885 digitizer fi

Re: [PATCH] saa7134: Add pm_qos_request to fix video corruption

2012-10-29 Thread Andy Walls
On Mon, 2012-10-29 at 13:02 +, Simon Farnsworth wrote: > On Monday 29 October 2012 09:58:17 Mauro Carvalho Chehab wrote: > > I prefer if you don't c/c me on that ;) Patchwork is the main source that I > > use > > on my patch reviews. > > > Noted. > > > Btw, I saw your patch yesterday (and sk

Re: [PATCH] saa7134: Add pm_qos_request to fix video corruption

2012-10-29 Thread Andy Walls
he SAA7134 cannot cope with a long latency on the first write of a DMA > transfer. > > Now, some media bridges (like the ones driven by the cx18 driver) can cope > with very high latency before the beginning of a DMA burst. Andy Walls has > worked on the cx18 driver to cope in this si

Re: hvr-1600 records one, fails recording the other on an mplex

2012-10-27 Thread Andy Walls
"Brian J. Murrell" wrote: >Hi, > >As I wrote about a number (3-4) of weeks ago, I am still having a >problem with my HVR-1600 failing on multiple digital recordings. At >the >time I reported this previously, there was a question of whether my >current version of MythTV was to blame. > >To that e

Re: [PATCH 01/23] uvc: Replace memcpy with struct assignment

2012-10-24 Thread Andy Walls
Laurent Pinchart wrote: >Hi Ezequiel, > >Thanks for the patch. > >On Tuesday 23 October 2012 16:57:04 Ezequiel Garcia wrote: >> This kind of memcpy() is error-prone. Its replacement with a struct >> assignment is prefered because it's type-safe and much easier to >read. >> >> Found by coccinelle

Re: [PATCH 13/23] tuners/xc2028: Replace memcpy with struct assignment

2012-10-23 Thread Andy Walls
On Tue, 2012-10-23 at 16:57 -0300, Ezequiel Garcia wrote: > This kind of memcpy() is error-prone. Its replacement with a struct > assignment is prefered because it's type-safe and much easier to read. > > Found by coccinelle. Hand patched and reviewed. > Tested by compilation only. > > A simplifi

  1   2   3   4   5   6   7   8   9   10   >