RE: soc-camera and focuser vcm devices

2014-11-11 Thread Andrew Chew
> > I think I get it, but just to clarify...currently, I'm going with the > > patch in [1], and I currently have multiple subdevs (sensors) hooked > > up and working with my soc-camera host driver. [2] was an alternate > > implementation, right? (as in, I don't need it). > > No. [1] you don't nee

RE: soc-camera and focuser vcm devices

2014-11-06 Thread Andrew Chew
> On Tue, 4 Nov 2014, Andrew Chew wrote: > > > Hello, Guennadi > > > > I was wondering if you can provide some advice as to how focuser vcm > > devices would fit into the soc-camera framework. We have a raw sensor > > (an IMX219) with an AD5823 VCM (it's

RE: Guidance regarding deferred I2C transactions

2011-08-05 Thread Andrew Chew
> > A simpler approach seems to be to only load the driver, > when streaming is > > required. Yes, it would add a (considerable) delay to > streaming begin, but > > you'd be completely honest to your user and privacy would > be guaranteed. > > The delay will likely be close to the one introdu

RE: Guidance regarding deferred I2C transactions

2011-08-05 Thread Andrew Chew
> > One way to solve this can be to defer these I2C > transactions in the image sensor driver all the way up > > to the time the image sensor is asked to start streaming > frames. However, it seems to me that this breaks > > the spirit of the probe; applications will successfully > probe for c

Guidance regarding deferred I2C transactions

2011-08-05 Thread Andrew Chew
I'm looking for some guidance regarding a clean way to support a certain camera module. We are using the soc_camera framework, and in particular, the ov9740.c image sensor driver. This camera module has the camera activity status LED tied to the image sensor's power. This is meant as a securi

RE: [PATCH 4/6 v3] [media] ov9740: Remove hardcoded resolution regs

2011-06-29 Thread Andrew Chew
> > + ret = ov9740_reg_write(client, OV9740_ISP_CTRL1E, > scale_input_x >> 8); > > + if (ret) > > + goto done; > > + ret = ov9740_reg_write(client, OV9740_ISP_CTRL1F, > scale_input_x & 0xff); > > + if (ret) > > + goto done; > > + ret = ov9740_reg_write(client, OV9740

RE: [PATCH 5/5 v2] [media] ov9740: Add suspend/resume

2011-05-31 Thread Andrew Chew
> > + /* For suspend/resume. */ > > + struct v4l2_mbus_framefmt current_mf; > > + int current_enable; > > bool? Are you sure you want this to be a bool? This thing is trying to shadow the "enable" parameter of the s_stream() callback, and that enable para

RE: [PATCH 4/5 v2] [media] ov9740: Remove hardcoded resolution regs

2011-05-31 Thread Andrew Chew
> > + /* Width must be a multiple of 4 pixels. */ > > + *width += *width % 4; > > No, this doesn't make it a multiple of 4, unless it was > even;) Just take 5 > as an example. What you really want here is Geez, you're right. Not sure what was going on in my head when I did this. Thanks f

RE: [PATCH 3/5 v2] [media] ov9740: Fixed some settings

2011-05-31 Thread Andrew Chew
> > + { OV9740_MIPI_CTRL00, 0x64 }, /* 0x44 for > continuous clock */ > > I think, the choice between continuous and discontinuous CSI-2 clock > should become configurable. You can only use discontinuous clock with > hosts, that support it, right? Whereas all hosts must support > c

RE: [PATCH v4 1/1] [media] ov9740: Initial submit of OV9740 driver.

2011-02-17 Thread Andrew Chew
> This looks good now, thanks, I'll queue it for 2.6.39. Just > one question: > > On Thu, 17 Feb 2011, ac...@nvidia.com wrote: > > > From: Andrew Chew > > > > This soc_camera driver is for Omnivision's OV9740 sensor. > This initial > &

soc-camera and videobuf2

2011-02-16 Thread Andrew Chew
Reposting. Sorry for the rich text in my previous email. I'm looking at the videobuf2 stuff, and would like to use it because it solves a bunch of problems for me that were in videobuf (for example, I'm writing a variant of videobuf-dma-contig, and there's some private memory allocator state I

Allocating videobuf_buffer, but lists not being initialized

2010-11-15 Thread Andrew Chew
I'm looking at drivers/media/video/videobuf-dma-contig.c's __videobuf_alloc() routine. We call kzalloc() to allocate the videobuf_buffer. However, I don't see where the two lists (vb->stream and vb->queue) that are a part of struct videobuf_buffer get initialized (with, say, INIT_LIST_HEAD).