Re: V4L2 drivers: potentially dangerous and inefficient msecs_to_jiffies() calculation

2009-09-19 Thread Andreas Mohr
Hi, On Tue, Sep 15, 2009 at 09:21:46PM +0200, Andreas Mohr wrote: > Hi, > > On Tue, Sep 15, 2009 at 09:14:19PM +0200, Marcin Slusarz wrote: > > Or better: frame_timeout * HZ > > D'oh! ;-) > > But then what about the other 3 bazillion places in the ker

Re: V4L2 drivers: potentially dangerous and inefficient msecs_to_jiffies() calculation

2009-09-15 Thread Andreas Mohr
Hi, On Tue, Sep 15, 2009 at 09:14:19PM +0200, Marcin Slusarz wrote: > Andreas Mohr pisze: > > ./drivers/media/video/zc0301/zc0301_core.c > > do > > cam->module_param.frame_timeout * > > 1000 * msecs_to_jiffies

Re: V4L2 drivers: potentially dangerous and inefficient msecs_to_jiffies() calculation

2009-09-14 Thread Andreas Mohr
od. ChangeLog: Correct dangerous and inefficient msecs_to_jiffies() calculation in some V4L2 drivers Signed-off-by: Andreas Mohr --- linux-2.6.31/drivers/media/video/sn9c102/sn9c102_core.c 2009-09-10 00:13:59.0 +0200 +++ linux-2.6.31.patched/drivers/media/video/sn9c102/sn9c102_c

Re: V4L2 drivers: potentially dangerous and inefficient msecs_to_jiffies() calculation

2009-09-14 Thread Andreas Mohr
Hi, On Mon, Sep 14, 2009 at 11:34:40PM +0200, Jiri Slaby wrote: > On 09/14/2009 11:07 PM, Andreas Mohr wrote: > > ./drivers/media/video/zc0301/zc0301_core.c > > do > > cam->module_param.frame_timeout * > >

V4L2 drivers: potentially dangerous and inefficient msecs_to_jiffies() calculation

2009-09-14 Thread Andreas Mohr
lication operation as opposed to constant-aggregating it into the msecs_to_jiffies() argument and thus nicely evaporating it into nirvana. HTH, Andreas Mohr -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More major