ion deals with libcamera and is on Wednesday morning
> > >>>>> from 9:00 to 13:00.
> > >>>>>
> > >>>>> Attendees for this session:
> > >>>>>
> > >>>>> Kieran Bingham
> > >&g
around on the Monday and
> mail the details of where to meet then.
>
> Confirmed attendees:
>
> Boris Brezillon
> Alexandre Courbot
> Nicolas Dufresne
> Tomasz Figa
> Ezequiel Garcia
> Eugen Hristev
> Paul Kocialkowski
> Helen Koike
> Jacopo Mondi
>
On Fri, Aug 16, 2019 at 3:59 PM Hans Verkuil wrote:
>
> On 8/16/19 7:49 AM, Alexandre Courbot wrote:
> > On Mon, Aug 12, 2019 at 8:07 PM Hans Verkuil
> > wrote:
> >>
> >> From: Alexandre Courbot
> >>
> >> Documents the protocol that
On Wed, Aug 14, 2019 at 6:40 PM Laurent Pinchart
wrote:
>
> On Wed, Aug 14, 2019 at 05:35:48PM +0900, Alexandre Courbot wrote:
> > That could be nice. Of course something more informal is also fine.
> > Anyone else planning to attend? I suspect Laurent and people living in
&
On Mon, Aug 12, 2019 at 8:07 PM Hans Verkuil wrote:
>
> From: Alexandre Courbot
>
> Documents the protocol that user-space should follow when
> communicating with stateless video decoders.
>
> The stateless video decoding API makes use of the new request and tags
>
On Thu, Aug 15, 2019 at 8:53 PM Hans Verkuil wrote:
>
> On 8/15/19 10:12 AM, Alexandre Courbot wrote:
> > On Mon, Aug 12, 2019 at 8:06 PM Hans Verkuil
> > wrote:
> >>
> >> This RFC patch adds support for the V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF
On Mon, Aug 12, 2019 at 8:07 PM Hans Verkuil wrote:
>
> From: Alexandre Courbot
>
> Documents the protocol that user-space should follow when
> communicating with stateless video decoders.
>
> The stateless video decoding API makes use of the new request and tags
>
On Thu, Aug 15, 2019 at 5:11 PM Alexandre Courbot wrote:
>
> On Mon, Aug 12, 2019 at 8:05 PM Hans Verkuil wrote:
> >
> > Add an enum_fmt format flag to specifically tag coded formats where
> > full bytestream parsing is supported by the device.
> >
> > Some st
On Mon, Aug 12, 2019 at 8:06 PM Hans Verkuil wrote:
>
> This RFC patch adds support for the V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF flag.
> It also adds a new V4L2_BUF_CAP_SUPPORTS_M2M_HOLD_CAPTURE_BUF capability and
> a v4l2_m2m_release_capture_buf() helper function.
>
> Drivers should set vb2_queue->
On Mon, Aug 12, 2019 at 8:07 PM Hans Verkuil wrote:
>
> Add this new V4L2_DEC_CMD_FLUSH decoder command and document it.
>
> Signed-off-by: Hans Verkuil
> ---
> Documentation/media/uapi/v4l/vidioc-decoder-cmd.rst | 11 ++-
> Documentation/media/videodev2.h.rst.exceptions | 1 +
> i
erspace pre-parses the bytestream into
> frames or fields (see the corresponding pixelformat descriptions
> for details).
Reviewed-by: Alexandre Courbot
This patch does not update the pixelformat descriptions though, are we
planning on doing this?
>
> If this flag is set, then this pr
ver in Chrome this seems to be correct.
Reviewed-by: Alexandre Courbot
> ---
> drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 4
> drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h | 1 +
> 2 files changed, 5 insertions(+)
>
> diff --git a/drivers/media/platform/m
his can't apply to stateless decoders.
Even though this can be inferred from reading the specs, I think it
would be reasonable to explicitly mention it though.
I also wonder, since this flag does not make sense for encoders, maybe
we can use more precise vocabulary in the patch description and doc?
I.e. s/codec/decoder.
With that,
Reviewed-by: Alexandre Courbot
That could be nice. Of course something more informal is also fine.
Anyone else planning to attend? I suspect Laurent and people living in
France might be there?
On Mon, Aug 12, 2019 at 4:28 PM Hans Verkuil wrote:
>
> On 8/12/19 6:00 AM, Alexandre Courbot wrote:
> > On Thu, Aug 8,
On Thu, Aug 8, 2019 at 9:55 PM Mauro Carvalho Chehab
wrote:
>
> Em Thu, 1 Aug 2019 09:34:00 -0300
> Mauro Carvalho Chehab escreveu:
>
> > Em Sun, 30 Jun 2019 13:44:04 -0300
> > Mauro Carvalho Chehab escreveu:
> >
> > > Hi all,
> > >
> > > We are organizing a media mini-summit in Lisbon to happen
On Tue, Jun 4, 2019 at 8:20 PM Tomasz Figa wrote:
> > +
> > + ret = mdp_vpu_get_locked(mdp);
> > + if (ret < 0)
> > + goto err_load_vpu;
>
> This shouldn't happen in open(), but rather the latest possible point in
> time. If one needs to keep the VPU running for the time of str
Hi Daoyuan, sorry for having been so long to come back to this!
I know you have another version prepared, but here are a few extra
things that may need attention.
On Thu, May 16, 2019 at 12:25 PM Daoyuan Huang
wrote:
>
> From: daoyuan huang
>
> This patch adds driver for Media Data Path 3 (MDP3
On Tue, May 14, 2019 at 7:59 PM Hans Verkuil wrote:
>
> On 5/14/19 12:01 PM, Alexandre Courbot wrote:
> > From: Hans Verkuil
> > Date: Mon, May 13, 2019 at 6:36 PM
> > To: Linux Media Mailing List, Paul Kocialkowski, Tomasz Figa, Nicolas
> > Dufresne, Alexandre Co
From: Hans Verkuil
Date: Mon, May 13, 2019 at 6:36 PM
To: Linux Media Mailing List, Paul Kocialkowski, Tomasz Figa, Nicolas
Dufresne, Alexandre Courbot, Boris Brezillon, Maxime Ripard, Thierry
Reding
> On 4/30/19 10:31 AM, Hans Verkuil wrote:
> > This RFC patch adds suppor
On Fri, Mar 29, 2019 at 3:08 AM Ezequiel Garcia wrote:
>
> Following the "Add MPEG-2 decoding to Rockchip VPU"[1], and given we want to
> start
> using the pixel format helpers rather soon, I've decided to submit them
> separatedly.
>
> Aside from documenting the block_w and block_h, as suggeste
short while.
Signed-off-by: Alexandre Courbot
---
Changes since v3:
* Rephrased the conditions under which reference buffers must be queued
back (hopefully) more accurately.
Documentation/media/uapi/v4l/dev-mem2mem.rst | 5 +
.../media/uapi/v4l/dev-stateless-decoder.rst | 386
ed.
Fixes: 0650a91499e0 ("media: mtk-vcodec: Correct return type for mem2mem buffer
helpers")
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/mtk-vcodec
5")
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/qcom/venus/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/core.c
b/drivers/media/platform/qcom/venus/core.c
index 739366744e0f..435c7b68bbed 100644
--- a/drivers
09:59 +0100, Hans Verkuil wrote:
> > > > On 2/13/19 6:58 AM, Alexandre Courbot wrote:
> > > > > On Wed, Feb 13, 2019 at 2:53 PM Alexandre Courbot
> > > > > wrote:
> > > > > > [snip]
> > > > > > +Buffers used as referenc
On Mon, Feb 4, 2019 at 7:11 PM wrote:
>
> From: Hans Verkuil
>
> When finding a buffer vb2_find_buffer() should also check if the
I think this is about vb2_find_timestamp() rather than
vb2_find_buffer()? (also in the mail title and in patch 0/3).
> properties of the found buffer (i.e. number of
On Wed, Feb 13, 2019 at 2:53 PM Alexandre Courbot wrote:
> [snip]
> +Buffers used as reference frames can be queued back to the ``CAPTURE`` queue
> as
> +soon as all the frames they are affecting have been queued to the ``OUTPUT``
> +queue. The driver will refrain from using the r
short while.
Signed-off-by: Alexandre Courbot
---
Changes since v2:
* Go back to one frame worth of encoded data as the quantity to be passed per
request, while leaving the door open to other quantities.
* Remove requirement for the client to not queue CAPTURE buffers until all
the frames
On Wed, Jan 30, 2019 at 6:41 AM Nicolas Dufresne wrote:
>
> Le mardi 29 janvier 2019 à 16:44 +0900, Alexandre Courbot a écrit :
> > On Fri, Jan 25, 2019 at 10:04 PM Paul Kocialkowski
> > wrote:
> > > Hi,
> > >
> > > On Thu, 2019-01-24 at 20:23
On Fri, Jan 25, 2019 at 10:04 PM Paul Kocialkowski
wrote:
>
> Hi,
>
> On Thu, 2019-01-24 at 20:23 +0800, Ayaka wrote:
> >
> > Sent from my iPad
> >
> > > On Jan 24, 2019, at 6:27 PM, Paul Kocialkowski
> > > wrote:
> > >
> > > Hi,
> > >
> > > > On Thu, 2019-01-10 at 21:32 +0800, ayaka wrote:
> >
On Thu, Nov 15, 2018 at 11:56 PM Maxime Ripard
wrote:
>
> From: Pawel Osciak
>
> Stateless video codecs will require both the H264 metadata and slices in
> order to be able to decode frames.
>
> This introduces the definitions for a new pixel format for H264 slices that
> have been parsed, as wel
On Fri, Jan 25, 2019 at 7:35 PM Stanimir Varbanov
wrote:
>
> Hi Alex,
>
> On 1/25/19 7:34 AM, Alexandre Courbot wrote:
> > On Thu, Jan 24, 2019 at 7:13 PM Stanimir Varbanov
> > wrote:
> >>
> >> Hi Alex,
> >>
> >> Thank you for
porated Tomasz' comments.
>
> Note that I moved the section about codec controls to the end. The idea
> is that when we add the codec specs this section is updated and the
> links to those specs is added there.
Makes sense indeed!
Acked-by: Alexandre Courbot
> ---
> .../med
On Thu, Jan 24, 2019 at 9:34 PM Stanimir Varbanov
wrote:
>
> Hi Alex,
>
> Thanks for the comments!
>
> On 1/24/19 10:44 AM, Alexandre Courbot wrote:
> > On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov
> > wrote:
> >>
> >> This refactored
On Thu, Jan 24, 2019 at 5:54 PM Stanimir Varbanov
wrote:
>
> Hi Alex,
>
> Thanks for the review!
>
> On 1/24/19 10:43 AM, Alexandre Courbot wrote:
> > On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov
> > wrote:
> >>
> >> This adds three mor
On Thu, Jan 24, 2019 at 7:05 PM Stanimir Varbanov
wrote:
>
> Hi Alex,
>
> Thanks for the comments!
>
> On 1/24/19 10:43 AM, Alexandre Courbot wrote:
> > On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov
> > wrote:
> >>
> >> In most of the cases th
On Thu, Jan 24, 2019 at 7:13 PM Stanimir Varbanov
wrote:
>
> Hi Alex,
>
> Thank you for review and valuable comments!
>
> On 1/24/19 10:43 AM, Alexandre Courbot wrote:
> > Hi Stanimir,
> >
> > On Fri, Jan 18, 2019 at 1:20 AM Stanimir Varbanov
> > wrot
On Wed, Jan 23, 2019 at 7:42 PM Paul Kocialkowski
wrote:
>
> Hi Alex,
>
> On Wed, 2019-01-23 at 18:43 +0900, Alexandre Courbot wrote:
> > On Tue, Jan 22, 2019 at 7:10 PM Paul Kocialkowski
> > wrote:
> > > Hi,
> > >
> > > On Tue, 2019-01-22
opy timestamps.
>
> This change allows for more efficient pipelining (i.e. you can use
> a buffer for a reference frame even when it is queued).
>
> Signed-off-by: Hans Verkuil
Reviewed-by: Alexandre Courbot
On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov
wrote:
>
> This refactored code for start/stop streaming vb2 operations and
s/refactored/refactors?
> adds a state machine handling similar to the one in stateful codec
> API documentation. One major change is that now the HFI session is
> starte
On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov
wrote:
>
> This adds three more helper functions:
> * for internal buffers reallocation, applicable when we are doing
> dynamic resolution change
> * for initial buffer processing of capture and output queue buffer
> types
>
> All of them will be
On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov
wrote:
>
> Here we export few helper function to use them from decoder to
> implement more granular control needed for stateful Codec API
> compliance.
>
> Signed-off-by: Stanimir Varbanov
> ---
> drivers/media/platform/qcom/venus/helpers.c | 29
On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov
wrote:
>
> Until now we returned num_output_bufs set during reqbuf but
> that could be wrong when we implement stateful Codec API. So
> get the minimum buffers for capture from HFI. This is supposed
> to be called after stream header parsing, i.e.
Hi Stanimir,
On Fri, Jan 18, 2019 at 1:20 AM Stanimir Varbanov
wrote:
>
> Hello,
>
> This aims to make Venus decoder compliant with stateful Codec API [1].
> The patches 1-9 are preparation for the cherry on the cake patch 10
> which implements the decoder state machine similar to the one in the
On Fri, Jan 18, 2019 at 1:21 AM Stanimir Varbanov
wrote:
>
> In most of the cases the client will know better what could be
> the maximum size for compressed data buffers. Change the driver
> to permit the user to set bigger size for the compressed buffer
> but make reasonable sanitation.
>
> Sign
On Wed, Jan 23, 2019 at 5:30 PM Hans Verkuil wrote:
>
> There really is no reason why vb2_find_timestamp can't just find
> buffers in any state. Drop that part of the test.
>
> This also means that vb->timestamp should only be set to 0 when a
> capture buffer is queued AND when the driver doesn't
s for this new version! I only have one comment left, see below.
> > >
> > > On Wed, 2018-12-05 at 19:01 +0900, Alexandre Courbot wrote:
> > > > Documents the protocol that user-space should follow when
> > > > communicating with stateless video decoders.
>
S_FW_START_ADDR, mem_phys, mem_size,
> IOMMU_READ | IOMMU_WRITE | IOMMU_PRIV);
> @@ -151,7 +157,7 @@ static int venus_boot_no_tz(struct venus_core *core,
> phys_addr_t mem_phys,
> static int venus_shutdown_no_tz(struct venus_core *core)
> {
> struct iommu_domain *iommu;
> - size_t unmapped;
> + size_t unmapped, mapped = core->fw.mapped_mem_size;
mapped should probably be const here.
With these minor comments:
Reviewed-by: Alexandre Courbot
Tested-by: Alexandre Courbot
For the 4 patches in this series. I could see the improvement in
decoder performance introduced by patches 2 and 3, thanks!
On Wed, Jan 9, 2019 at 5:46 PM Stanimir Varbanov
wrote:
>
> This corects maximum hardware load constant in per SoC resources
s/corect/correct. Same typo is present in patch title.
> for sdm845 aka Venus v4.
>
> Signed-off-by: Stanimir Varbanov
> ---
> drivers/media/platform/qcom/venus/core.c
On Wed, Jan 9, 2019 at 5:46 PM Stanimir Varbanov
wrote:
>
> The zero timestap is really a valid so not sure why I discarded it. Fix
s/timestap/timestamp, also in patch title.
> that mistake by drop the code which checks for zero timestamp.
s/drop/dropping
>
> Signed-off-by: Stanimir Varbanov
On Tue, Jan 22, 2019 at 5:06 PM Hans Verkuil wrote:
>
> On 01/22/2019 07:26 AM, Alexandre Courbot wrote:
> > Documents the protocol that user-space should follow when
> > communicating with stateless video decoders.
> >
> > The stateless video decoding API makes u
short while.
Signed-off-by: Alexandre Courbot
---
Changes since v1:
* Use timestamps instead of tags to reference frames,
* Applied Paul's suggestions to not require one frame worth of data per OUTPUT
buffer
One of the effects of requiring sub-frame units to be submitted per request is
tha
Hi Hans,
On Fri, Dec 7, 2018 at 12:08 AM Hans Verkuil wrote:
>
> Mauro raised a number of objections on irc regarding tags:
>
> https://linuxtv.org/irc/irclogger_log/media-maint?date=2018-12-06,Thu
>
> I would like to setup an irc meeting to discuss this and come to a
> conclusion, since we need
short while.
Signed-off-by: Alexandre Courbot
---
Removing the RFC flag this time. Changes since RFCv3:
* Included Tomasz and Hans feedback,
* Expanded the decoding section to better describe the use of requests,
* Use the tags API.
Documentation/media/uapi/v4l/dev-codec.rst| 5 +
.../media
; a format for it and the format returned by it would have the sizeimage
> >>> as hardcoded in the driver...
> >>
> >> ???
> >>
> >> Userspace can change the sizeimage to whatever it wants before calling
> >> CREATE_BUFS as long as it is >= the sizeimage of the current format.
> >>
> >> If we want to allow smaller sizes, then I think that would not be
> >> unreasonable for stateful codecs. I actually think that drivers can
> >> already do this in queue_setup(), but the spec would have to be updated
> >> a bit.
> >
> > Existing applications rely on REQBUFS honoring the size they set in
> > sizeimage, though...
>
> REQBUFS, yes. But not CREATE_BUFS. Which is why that ioctl was added in the
> first place.
>
> However (and now I remember the real problem with CREATE_BUFS) the spec for
> CREATE_BUFS says that it will not change the provided sizeimage value. So
> any adjustments required due to specific alignment requirements won't be
> applied, all CREATE_BUFS can do is to reject it.
>
> So what this boils down to is a change to the spec:
>
> For compressed formats (and only those!) userspace can set sizeimage to a
> proposed value. The driver may either ignore it and just set its own value,
> or modify it to satisfy HW requirements. The returned value will be used
> by REQBUFS when it allocates buffers.
>
> I think this is reasonable, provided the spec is updated accordingly.
>
> As far as I can tell this shouldn't cause any backwards compatibility
> problems, and it should be easy to test in v4l2-compliance.
Do you mean that this patch is acceptable provided the stateful codec
specification is updated accordingly?
For our (Chromium) needs this seems to do the job, so:
Tested-by: Alexandre Courbot
Although I would like to also have the equivalent for the decoder's
OUTPUT queue, either as a v4 or a follow-up patch.
On Tue, Nov 20, 2018 at 7:08 PM Malathi Gottam wrote:
>
> This adds video nodes to sdm845 based on the examples
> in the bindings.
>
> Signed-off-by: Malathi Gottam
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 34 ++
> 1 file changed, 34 insertions(+)
>
> diff -
On Fri, Nov 23, 2018 at 8:53 AM Nicolas Dufresne wrote:
>
> Le jeudi 22 novembre 2018 à 17:31 +0900, Alexandre Courbot a écrit :
> > On Fri, Nov 16, 2018 at 1:49 AM Nicolas Dufresne
> > wrote:
> > > Le mercredi 14 novembre 2018 à 13:12 +0900, Alexandre Courbot a écr
Hi Malathi,
On Tue, Nov 20, 2018 at 3:53 PM Malathi Gottam wrote:
>
> Accept the buffer size requested by client and compare it
> against driver calculated size and set the maximum to
> bitstream plane.
>
> Signed-off-by: Malathi Gottam
> ---
> drivers/media/platform/qcom/venus/venc.c | 13
On Fri, Nov 16, 2018 at 1:49 AM Nicolas Dufresne wrote:
>
> Le mercredi 14 novembre 2018 à 13:12 +0900, Alexandre Courbot a écrit :
> > On Wed, Nov 14, 2018 at 3:54 AM Nicolas Dufresne
> > wrote:
> > >
> > >
> > > Le mar. 13 nov. 2018 04 h 30, Al
tag feature.
> v4l2-mem2mem: add v4l2_m2m_buf_copy_data helper function
> vb2: add new supports_tags queue flag
> vim2m: add tag support
> vicodec: add tag support
> cedrus: add tag support
Good call on the v4l2_m2m_buf_copy_data() function!
Reviewed-by: Alexandre Cou
On Wed, Nov 14, 2018 at 3:54 AM Nicolas Dufresne wrote:
>
>
>
> Le mar. 13 nov. 2018 04 h 30, Alexandre Courbot a
> écrit :
>>
>> The last buffer is often signaled by an empty buffer with the
>> V4L2_BUF_FLAG_LAST flag set. Such buffers were returned with the
&
On Mon, Nov 12, 2018 at 9:20 PM Stanimir Varbanov
wrote:
>
> Hi Alex,
>
> On 11/12/18 10:12 AM, Alexandre Courbot wrote:
> > Hi Stan,
> >
> > On Thu, Nov 8, 2018 at 7:16 PM Stanimir Varbanov
> > wrote:
> >>
> >> Hi,
> >>
>
reported used by the firmware.
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/qcom/venus/vdec.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/vdec.c
b/drivers/media/platform/qcom/venus/vdec.c
index 189ec975c6bb..282de21cf2e1
On Fri, Nov 9, 2018 at 7:31 PM Tomasz Figa wrote:
>
> Hi Malathi,
>
> On Fri, Nov 9, 2018 at 6:20 PM wrote:
> >
> > On 2018-11-09 07:56, Tomasz Figa wrote:
> > > Hi Malathi,
> > >
> > > On Fri, Nov 9, 2018 at 4:39 PM Malathi Gottam
> > > wrote:
> > >>
> > >> Handles target type crop by setting t
Hi Stan,
On Thu, Nov 8, 2018 at 7:16 PM Stanimir Varbanov
wrote:
>
> Hi,
>
> On 9/29/18 3:00 PM, Srinu Gorle wrote:
> > - In video decoder session, update number of bytes used for
> > yuv buffers appropriately for EOS buffers.
> >
> > Signed-off-by: Srinu Gorle
> > ---
> > drivers/media/platf
Hi Hans,
On Fri, Nov 9, 2018 at 6:56 PM Hans Verkuil wrote:
>
> As was discussed here (among other places):
>
> https://lkml.org/lkml/2018/10/19/440
>
> using capture queue buffer indices to refer to reference frames is
> not a good idea. A better idea is to use 'cookies' (a better name is
> welc
On Fri, Nov 9, 2018 at 6:56 PM Hans Verkuil wrote:
>
> From: Hans Verkuil
>
> Add support for 'cookies' to struct v4l2_buffer. These can be used to
This "to" seems unneeded.
Hi Hans,
On Wed, Oct 24, 2018 at 6:52 PM Hans Verkuil wrote:
>
> HI Alexandre,
>
> On 10/24/2018 10:16 AM, Alexandre Courbot wrote:
> > Hi Hans,
> >
> > On Fri, Oct 19, 2018 at 6:40 PM Hans Verkuil wrote:
> >>
> >> From Alexandre's &#
Hi Hans,
On Fri, Oct 19, 2018 at 6:40 PM Hans Verkuil wrote:
>
> From Alexandre's '[RFC PATCH v3] media: docs-rst: Document m2m stateless
> video decoder interface':
>
> On 10/19/18 10:09, Alexandre Courbot wrote:
> > Two points being currently dis
am
This seems to work, thanks!
Tested-by: Alexandre Courbot
> ---
> drivers/media/platform/qcom/venus/hfi_cmds.c | 2 +-
> drivers/media/platform/qcom/venus/hfi_venus.c | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom
On Mon, Oct 22, 2018 at 3:51 PM Tomasz Figa wrote:
>
> On Mon, Oct 22, 2018 at 3:39 PM Alexandre Courbot
> wrote:
> >
> > On Mon, Oct 22, 2018 at 3:22 PM Tomasz Figa wrote:
> > >
> > > On Mon, Oct 22, 2018 at 3:05 PM Alexandre Courbot
> > > wro
On Mon, Oct 22, 2018 at 3:22 PM Tomasz Figa wrote:
>
> On Mon, Oct 22, 2018 at 3:05 PM Alexandre Courbot
> wrote:
> >
> > On Fri, Oct 19, 2018 at 5:44 PM Hans Verkuil wrote:
> > >
> > > On 10/19/18 10:09, Alexandre Courbot wrote:
> > > >
On Fri, Oct 12, 2018 at 5:10 PM Stanimir Varbanov
wrote:
>
>
>
> On 10/12/2018 11:06 AM, Alexandre Courbot wrote:
> > On Fri, Oct 12, 2018 at 4:37 PM Stanimir Varbanov
> > wrote:
> >>
> >> Hi Alex,
> >>
> >> On 10/12/2018 08:26 AM, A
some issues we had with low-resolution VP8 encoding. Maybe
this can be refined some more for higher resolutions, but the current
version at least works.
Tested-by: Alexandre Courbot
> ---
> drivers/media/platform/qcom/venus/helpers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(
On Fri, Oct 19, 2018 at 5:44 PM Hans Verkuil wrote:
>
> On 10/19/18 10:09, Alexandre Courbot wrote:
> > Thanks everyone for the feedback on v2! I have not replied to all the
> > individual emails but hope this v3 will address some of the problems
> > raised and become a co
t; drivers/media/platform/qcom/venus/hfi_venus.c | 13 +-
> drivers/media/platform/qcom/venus/hfi_venus_io.h | 8 +
> 7 files changed, 274 insertions(+), 43 deletions(-)
The series:
Reviewed-by: Alexandre Courbot
Tested-by: Alexandre Courbot
where this scenario would not
work?
As usual, thanks for the insightful comments, and let's make sure we are
ready for a fruitful discussion during the Summit! :)
Signed-off-by: Alexandre Courbot
---
.../media/uapi/v4l/dev-stateless-decoder.rst | 360 ++
Documentation/media/uapi/
On Fri, Oct 12, 2018 at 4:37 PM Stanimir Varbanov
wrote:
>
> Hi Alex,
>
> On 10/12/2018 08:26 AM, Alexandre Courbot wrote:
> > On Tue, Oct 9, 2018 at 4:54 PM Malathi Gottam
> > wrote:
> >>
> >> When client requests for a keyframe, set the property
&
On Tue, Oct 9, 2018 at 4:54 PM Malathi Gottam wrote:
>
> When client requests for a keyframe, set the property
> to hardware to generate the sync frame.
>
> Signed-off-by: Malathi Gottam
> ---
> drivers/media/platform/qcom/venus/venc_ctrls.c | 13 +
> 1 file changed, 13 insertions(+)
On Thu, Oct 11, 2018 at 5:26 PM Stanimir Varbanov
wrote:
>
> Hi Alex,
>
> On 10/11/2018 09:50 AM, Alexandre Courbot wrote:
> > Please ignore this patch - I did not notice that a similar one has
> > been sent before.
>
> The difference is that you made it for decoder
On Tue, Oct 9, 2018 at 4:52 PM Malathi Gottam wrote:
>
> Add USERPTR to queue access methods by adding this
> support to io_modes on both the planes.
>
> Signed-off-by: Malathi Gottam
Tested-by: Alexandre Courbot
Please ignore this patch - I did not notice that a similar one has
been sent before. >_<
On Thu, Oct 11, 2018 at 3:46 PM Alexandre Courbot wrote:
>
> The venus codec can work just fine with USERPTR buffers. Enable this
> possibility.
>
> Signed-off-by: Alexandre Courbot
&
The venus codec can work just fine with USERPTR buffers. Enable this
possibility.
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/qcom/venus/vdec.c | 4 ++--
drivers/media/platform/qcom/venus/venc.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers
ge ensures that the bytesused is assigned
> to actual payload size, when available.
>
> Signed-off-by: Vikash Garodia
Tested-by: Alexandre Courbot
On Tue, Aug 21, 2018 at 6:15 PM Tomasz Figa wrote:
>
> On Wed, Aug 15, 2018 at 11:18 PM Hans Verkuil wrote:
> >
> > On 15/08/18 14:11, Mauro Carvalho Chehab wrote:
> > > Em Sat, 4 Aug 2018 15:50:04 +0200
> > > Hans Verkuil escreveu:
> > >
> > >> Hi all,
> > >>
> > >> While the Request API patch
e to design a modular camera stack, and try to make
> most components as platform-independent as possible. This should include:
>
> - the kernel drivers (V4L2-compliant and usable without any closed-source
> userspace component);
> - the 3A library
> - any other component that could
On Fri, Apr 20, 2018 at 12:43 AM Paul Kocialkowski <
paul.kocialkow...@bootlin.com> wrote:
> When using the request API in the context of a m2m driver, the
> operations that come with a m2m run scheduling call in their
> (m2m-specific) ioctl handler are delayed until the request is queued
> (for i
On Tue, Apr 17, 2018 at 8:41 PM Paul Kocialkowski <
paul.kocialkow...@bootlin.com> wrote:
> Hi,
> On Tue, 2018-04-17 at 06:17 +0000, Alexandre Courbot wrote:
> > On Tue, Apr 17, 2018 at 3:12 PM Hans Verkuil
> > wrote:
> >
> > > On 04/17/2018 06:33 AM,
On Tue, Apr 17, 2018 at 3:12 PM Hans Verkuil wrote:
> On 04/17/2018 06:33 AM, Alexandre Courbot wrote:
> > On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote:
> >
> >> From: Hans Verkuil
> >
> >> Hi all,
> >
> >> This is a cleaned up ve
On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote:
> From: Alexandre Courbot
> Request API requires a media node. Add one to the vim2m driver so we can
> use requests with it.
> This probably needs a bit more work to correctly represent m2m
> hardware in the media topology.
On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote:
> From: Hans Verkuil
> Add support for requests to vim2m.
> Signed-off-by: Hans Verkuil
> ---
> drivers/media/platform/vim2m.c | 25 +
> 1 file changed, 25 insertions(+)
> diff --git a/drivers/media/platform/vim2m
On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote:
> From: Hans Verkuil
> This implements the V4L2 part of the request support. The main
> change is that vb2_qbuf and vb2_prepare_buf now have a new
> media_device pointer. This required changes to several drivers
> that did not use the vb2_ioct
On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote:
> From: Hans Verkuil
> Add media_request_object_find to find a request object inside a
> request based on ops and/or priv values.
> Objects of the same type (vb2 buffer, control handler) will have
> the same ops value. And objects that refer
On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote:
> From: Hans Verkuil
> Implement the core of the media request processing.
> Drivers can bind request objects to a request. These objects
> can then be marked completed if the driver finished using them,
> or just be unbound if the results do
On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote:
> From: Hans Verkuil
> The mdev field is only present if CONFIG_MEDIA_CONTROLLER is set.
> But since we will need to pass the media_device to vb2 snd the
Typo: s/snd/and
> control framework it is very convenient to just make this field
> ava
river and to re-initialize the
> request.
> Signed-off-by: Hans Verkuil
Like it that the API stays simple, with request ioctls tied to request FDs.
Acked-by: Alexandre Courbot
> ---
> include/uapi/linux/media.h | 8
> 1 file changed, 8 insertions(+)
> diff --g
On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote:
> From: Hans Verkuil
> Hi all,
> This is a cleaned up version of the v10 series (never posted to
> the list since it was messy).
Hi Hans,
It took me a while to test and review this, but finally have been able to
do it.
First the result of
On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote:
> From: Hans Verkuil
> Add support for allocating a new request. This is only supported
> if mdev->ops->req_queue is set, i.e. the driver indicates that it
> supports queueing requests.
> Signed-off-by: Hans Verkuil
> ---
> drivers/media/M
RR when polling the request in order to know
that something went wrong. When this happens, an extra ioctl on the
request fd (e.g. REQUEST_GET_ERROR) could be used to get more
information about what has failed. Due to the extensible nature of
requests, we should be careful to make this ioctl widely e
this by moving the call to venus_helper_check_codec() into the loop,
and keep enumerating when it fails.
Fixes: 29f0133ec6 media: venus: use helper function to check supported codecs
Signed-off-by: Alexandre Courbot
---
drivers/media/platform/qcom/venus/vdec.c | 13 +++--
drivers/media
On Thu, Mar 15, 2018 at 6:52 PM, Stanimir Varbanov
wrote:
> Hi Alex,
>
> Thanks for the patch!
>
> On 13.03.2018 11:11, Alexandre Courbot wrote:
>> find_format_by_index() stops enumerating formats as soon as the index
>> matches, and returns NULL if venus_helper_c
1 - 100 of 249 matches
Mail list logo
