gs while the mutex is
still held and checking for pending removes before allowing an open to
succeed.
Signed-off-by: Alan Stern
CC:
---
[as1920]
drivers/media/usb/usbvision/usbvision-video.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
Index: usb-devel/
sts
beforehand. Note that vidioc_querycap() is protected by
usbvision->v4l2_lock, acquired in a higher layer of the V4L2
subsystem.
Reported-and-tested-by: syzbot+7fa38a608b1075dfd...@syzkaller.appspotmail.com
Signed-off-by: Alan Stern
CC:
---
[as1919]
drivers/media/usb/usbvision/usbvision-v
On Wed, 2 Oct 2019, Tim Harvey wrote:
> On Tue, Oct 1, 2019 at 12:19 PM Alan Stern wrote:
> >
> > On Tue, 1 Oct 2019, Tim Harvey wrote:
> >
> > > On Thu, Sep 26, 2019 at 3:47 PM Tim Harvey wrote:
> > > >
> > > > Greetings,
> > >
gs while the mutex is
still held and checking for pending removes before allowing an open to
succeed.
Signed-off-by: Alan Stern
CC:
---
[as1920]
drivers/media/usb/usbvision/usbvision-video.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
Index: usb-devel/
sts
beforehand. Note that vidioc_querycap() is protected by
usbvision->v4l2_lock, acquired in a higher layer of the V4L2
subsystem.
Reported-and-tested-by: syzbot+7fa38a608b1075dfd...@syzkaller.appspotmail.com
Signed-off-by: Alan Stern
CC:
---
[as1919]
drivers/media/usb/usbvision/usbvision-v
-ENOSPC is getting returned from
> drivers/usb/host/ehci-sched.c:iso_stream_schedule()
>
> I feel perhaps this is something basic I don't understand regarding
> USB URB scheduling but I don't get why it occurs on the IMX6 ci_hdrc
> controller on not an XHCI controller.
after the structure has been
freed.
Clearly something is wrong, and I can't tell how this is all intended
to work. Is the deallocation supposed to occur at a later time?
Any ideas or suggestions?
Alan Stern
On Thu, 26 Sep 2019, syzbot wrote:
> Hello,
>
> syzbot has tested th
Dear sir ,
I KELLY ALAN purchasing and sales manager of CFM INTERNATIONAL .Our
Company specialised in Supplying computer hardware and Electronic .We
want to extend our supplier list because of concurrency in prices on the
international market. We are seeking a supplier with whom we can to
> Maybe it would be good to improve the names at the same time?
Its scheduled for deletion - please don't bother.
Alan
)) no other volunteers I can
find crazy enough to take this on.
Alan
closely comparing
them to see what ships but for the past few months I got dragged off it
for the most part onto the security work.
Alan
ol URBs. The DVB driver in question
uses bulk transfers.
xhci-hcd, on the other hand, does not use these tasklets (it doesn't
set the HCD_BH bit in the hc_driver's .flags member).
Alan Stern
st? The post says that the testing was done on an x86_64
machine.
> Gesendet: Montag, 08. Januar 2018 um 17:31 Uhr
> Von: "Alan Stern"
> An: "Josef Griebichler"
> Cc: "Mauro Carvalho Chehab" , "Greg Kroah-Hartman"
> , linux-...@vger.kernel.
dditional tcp load on raspberry.
>
> Unfortunately there's no usbmon or tshark on libreelec so I can't provide
> further logs.
Can you try running the same test on an x86_64 system?
Alan Stern
eduling parameters if needed, to adjust for
> > such use-cases (it was not really an admin choice before).
>
> Can't the ksoftirq patch be modified to only apply to the networking
> IRQ handling? That sounds less risky of affecting unrelated subsystems[1].
That might work. Or mo
On Mon, 8 Jan 2018, Mauro Carvalho Chehab wrote:
> Em Sun, 7 Jan 2018 10:41:37 -0500 (EST)
> Alan Stern escreveu:
>
> > On Sun, 7 Jan 2018, Mauro Carvalho Chehab wrote:
> >
> > > > > It seems that the original patch were designed to solve some IRQ
> >
On Mon, 8 Jan 2018 16:21:21 +0200
Sakari Ailus wrote:
> Hi Mauro,
>
> On Thu, Jan 04, 2018 at 02:44:41PM -0500, Mauro Carvalho Chehab wrote:
> > There are lots of bad whitespaces at atomisp driver.
> >
> > Fix them.
> >
> > Signed-off-by: Mauro Carval
have to mitigate them in user space
because most of them are about how many instructions you execute on each
path. The ancient classic being telling if a user exists by seeing if the
password was actually checked.
Alan
mands
> > > required by DVB cards, at least on some USB host drivers.
> > >
> > > Alan/Greg/Eric/David:
> > >
> > > Any ideas about how to fix it without causing regressions to
> > > network?
> >
> > It would be good to know w
4.14.10?
>
> -
>
> It seems that the original patch were designed to solve some IRQ issues
> with network cards with causes data losses on high traffic. However,
> it is also causing bad effects on sustained high bandwidth demands
> required by DVB cards, at least on some USB
it is meant to work that way - but it doesn't. At least
not at the moment.
> > I see your point, Still it feels, as if this could go somewhere.
>
> I hope so, though I didn't try CherryTrail and according to Alan that
> is what he had tried on.
It's what we are curre
> AFAIR Alan has CHT hardware he is developing / testing on.
I have a loaned board from the company Vincent (who did the intial
patches) works for. At the moment it's loading firmware, finding cameras
doing power management but not transferring images.
Unfortunately because of the desig
On Tue, 19 Dec 2017 22:37:01 +0200
Andy Shevchenko wrote:
> On Tue, 2017-12-19 at 14:00 +0200, Sakari Ailus wrote:
> > Cc Alan and Andy.
> >
> > On Sat, Dec 16, 2017 at 04:50:04PM +0100, Kristian Beilke wrote:
> > > Dear all,
> > >
> > > I
On Tue, 12 Dec 2017 09:03:50 -0200
Mauro Carvalho Chehab wrote:
> Em Mon, 06 Nov 2017 23:36:36 +
> Alan escreveu:
>
> > This isn't the ideal final solution but it stops the main problem for now
> > where an open (often from udev) races the device initialization a
> --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_pipe_public.h
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_pipe_public.h
> @@ -152,14 +152,6 @@ struct ia_css_pipe_config {
> };
>
Thani you that's a really good cleanup.
Alan
the
> zeroes afterwards.
Where they are only used once in the tree it might be even cleaner to
just do
static struct foo = FOO_DEFAULT_BAR;
foo.x = 12;
foo.bar = &foo;
etc in the code.
Alan
On Mon, 27 Nov 2017 12:44:50 +
Jeremy Sowden wrote:
> Changed the types of some arrays from int16_t to s16W
Which are the same type, except int16_t is the standard form.
No point.
Alan
case of ov2680, we don't seem to use the timestamp at
> all, so I just remove it.
>
> Signed-off-by: Arnd Bergmann
Reviewed-by: Alan Cox
On Wed, 2017-11-22 at 00:31 -0500, Sinan Kaya wrote:
> pci_get_bus_and_slot() is restrictive such that it assumes domain=0
> as
> where a PCI device is present. This restricts the device drivers to
> be
> reused for other domain numbers.
The ISP v2 will always been in domain 0.
Alan
On Tue, 14 Nov 2017 00:05:48 +0200
Sakari Ailus wrote:
> Hi Alan,
>
> On Mon, Nov 06, 2017 at 11:36:45PM +0000, Alan wrote:
> > We load the firmware once, set pointers to it and then at some point release
> > it. We should not be doing a vfree() on the point
We load the firmware once, set pointers to it and then at some point release
it. We should not be doing a vfree() on the pointers into the firmware.
Signed-off-by: Alan Cox
---
.../atomisp/pci/atomisp2/css2400/sh_css_firmware.c |2 --
1 file changed, 2 deletions(-)
diff --git
a/drivers
This isn't the ideal final solution but it stops the main problem for now
where an open (often from udev) races the device initialization and we try
and load the firmware twice at the same time. This needless to say doesn't
usually end well.
Signed-off-by: Alan Cox
---
.../media/a
k and avoid the
bogus warning on a cleanup
Signed-off-by: Alan Cox
---
.../staging/media/atomisp/pci/atomisp2/hmm/hmm.c | 21 +---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c
b/drivers/staging/media/at
hen crossing the
> 32-64bits boundaries
> As today the endire dvb linux infrastructure can only work in 32-32
> and 64-64 bit mode
If this isn't handled by the existing media compat_ioctl support then you
can send patches to use compat_ioctl handlers to fix this.
Alan
gt; For this reason I'm tempted to postpone applying this patch at least
> until the other drivers are available.
Yes - unless someone has a different controller and that sensor on a
board so can test it that way ?
Alan
lp would
> be appreciated.
> Also patch 2/2 doesn't correct any cosmetic changes reported by checkpatch.pl
> as explained in TODO step 6.
Please don't. Right now we know what work is to be done and tested.
Alan
On Mon, 2017-08-07 at 21:44 +0800, Geliang Tang wrote:
> Use kvmalloc()/kvzalloc() instead of atomisp_kernel_malloc()
> /atomisp_kernel_zalloc().
>
> Signed-off-by: Geliang Tang
Definitely better now we have kvmalloc/kvzalloc.
Thanks
Alan
On Fri, 2017-07-07 at 17:20 +0530, Hari Prasath wrote:
> kmemdup can be used to replace kmalloc followed by a memcpy.This was
> pointed out by the coccinelle tool.
And kstrdup could do the job even better I think ?
Alan
}
>
> -static struct acpi_device_id gc0310_acpi_match[] = {
> +static const struct acpi_device_id gc0310_acpi_match[] = {
> {"XXGC0310"},
> {},
> };
(All four)
Acked-by: Alan Cox
ats with no
reason to encode them as IPUv3 specific names.
Alan
to encode ipu3
in the name. Something like V4l2_PIX_FMT_SBGGR10_PACKED might be better ?
Alan
nything for cache synchronization
and the dma_sync won't actually do any work.
Alan
han the IPUv2 code!
Alan
ETA_FMT_IPU3_STAT_DVS
> V4L2_META_FMT_IPU3_STAT_LACE
Are these specific to IPU v3 or do they match other IPU versions ?
Alan
hub.com/01org/libxcam/wiki/Tests
Alan
el
> would try to get permission to add the firmware to linux-firmware.
I spent 6 months trying, but even though you can go to your product
vendors website and download it I've not been able to 8(.
>
> Anyways I will send out the patches I've currently, once I've
> the right firmware I will continue working on this.
Really appreciate the work you are doing on this.
Alan
did send out a fresh-copy with the full 7 patch patch-set
> directly after CTRL+c-ing this wrong send-email (which only got the
> first 3 patches send).
So I discovered just afterwards 8)
Alan
On Mon, 29 May 2017 02:06:41 +0800
Chen Guanqiao wrote:
> Fix "symbol 'xxx' was not declared. Should it be static?" sparse warnings.
>
> Signed-off-by: Chen Guanqiao
> ---
Reviewed-by: Alan Cox
board and bears no relation to the actual
hardware!)
Easy enough to check what a given Android x86 tablet does - plug it into a
powered OTG hub, add a live USB stick and a keyboard, hit the Fn key for
BIOS entry as it boots and boot off USB. You can then check lsacpi and
the EFI variables.
Alan
We won't be adding abstractions or moving them here so kill it.
Signed-off-by: Alan Cox
---
.../staging/media/atomisp/pci/atomisp2/Makefile|1 -
.../atomisp/pci/atomisp2/css2400/sh_css_irq.c | 16
2 files changed, 17 deletions(-)
delete mode 100644
dr
Between the ISP2400 and ISP2401 code base this function moved file. The merge
of the drivers left us with two version in ifdefs. Resolve this down to a
single copy.
Signed-off-by: Alan Cox
---
.../pci/atomisp2/css2400/ia_css_mmu_private.h |2 --
.../media/atomisp/pci/atomisp2/css2400
ISP2401 introduced a helper for this which we can use just as well on the
ISP2400 and remove some more noise differences.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/css2400/sh_css.c|7 ---
.../atomisp/pci/atomisp2/css2400/sh_css_params.c | 14 --
2
ISP2401 introduced a rather sensible change to cut through the structure
spaghetti. Adopt that for the ISP2400 as well. It makes no difference to the
actual code other than readability.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/css2400/sh_css.c| 40 +---
1
The ISP2401 version of this function returns a pointer to the buffer, whilst
the ISP2400 version returns a boolean if a slot is found. We can trivially
unify the code to use the ISP2401 version.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/css2400/sh_css.c| 40
This define is never set and these code paths are never used so they can go
away.
Signed-off-by: Alan Cox
---
.../css2400/isp/modes/interface/isp_const.h| 16 -
.../css2400/isp/modes/interface/isp_exprs.h| 23 --
.../atomisp2/css2400/runtime/binary/src
The two drivers were machine merged and in this case the machine output was to
say the least not optimal.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/css2400/sh_css.c| 26
1 file changed, 5 insertions(+), 21 deletions(-)
diff --git a/drivers/staging
t so we will end up returning -EINVAL a few lines later
because the .camera pointer is NULL.
Signed-off-by: Dan Carpenter
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_ioctl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media
HRT_UNSCHED is never defined or set in the driver, so this is dead code that
can be retired, simplifying the code a bit further.
Signed-off-by: Alan Cox
---
.../css2400/runtime/debug/src/ia_css_debug.c |7 ---
.../atomisp2/css2400/runtime/spctrl/src/spctrl.c |8
With the removal of the HAS_BL bootloader code the value of NUM_OF_BLS is an
invariant zero. So let's get rid of it.
Signed-off-by: Alan Cox
---
.../atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
a/drivers/st
Kill off the HAS_BL define and the code and includes it brackets. We never
define HAS_BL or use that functionality.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/css2400/sh_css.c| 101
.../atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 19
The code attempts to check for out of range calibration. What it forgets to do
is check for the 0 bitrate case. As a result the range check itself oopses the
kernel.
Found by Andrey Konovalov using Syzkaller.
Signed-off-by: Alan Cox
---
drivers/net/hamradio/hdlcdrv.c |2 +-
1 file changed
The two drivers were machine merged and in this case the machine output was to
say the least not optimal.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/css2400/sh_css.c| 26
1 file changed, 5 insertions(+), 21 deletions(-)
diff --git a/drivers/staging
HRT_UNSCHED is never defined or set in the driver, so this is dead code that
can be retired, simplifying the code a bit further.
Signed-off-by: Alan Cox
---
.../css2400/runtime/debug/src/ia_css_debug.c |7 ---
.../atomisp2/css2400/runtime/spctrl/src/spctrl.c |8
With the removal of the HAS_BL bootloader code the value of NUM_OF_BLS is an
invariant zero. So let's get rid of it.
Signed-off-by: Alan Cox
---
.../atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
a/drivers/st
Kill off the HAS_BL define and the code and includes it brackets. We never
define HAS_BL or use that functionality.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/css2400/sh_css.c| 101
.../atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 19
eview mailbox. After this, my queue is empty, the driver is
> > all
> > yours!
>
> Thanks!
>
> Alan, please let me know if you prefer if I don't apply any of
> such patches, otherwise I should be merging them tomorrow ;)
I will assume you've merged them
t;pad)
> return -EINVAL;
> /* only raw8 grbg is supported by TPG */
The TODO fille for this driver specifically says not to send formatting
patches at this point.
There is no point making trivial spacing changes in code that needs
lots of real work. It's like polishing your car when the doors have
fallen off.
Alan
clude-dirs]
Fixes: 184f8e0981ef ("atomisp: remove satm kernel")
Signed-off-by: Arnd Bergmann
Signed-off-by: Alan Cox
---
.../staging/media/atomisp/pci/atomisp2/Makefile|1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/Makefile
b/d
The extra list contains some which are used and some which are not. At this
point I think we can safely remove those that are simply not used.
Signed-off-by: Alan Cox
---
.../staging/media/atomisp/pci/atomisp2/Makefile| 11 -
.../media/atomisp/pci/atomisp2/hmm/hmm_bo_dev.c| 333
by: Fabian Frederick
Signed-off-by: Alan Cox
---
.../staging/media/atomisp/pci/atomisp2/hmm/hmm.c | 19 ++-
1 file changed, 2 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c
b/drivers/staging/media/atomisp/pci/atomisp2/hmm
d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Arnd Bergmann
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_v4l2.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/media/atomisp/pc
We have a layer of un-needed wrapping here that can go. In addition there are
some functions that don't exist and one that isn't used which can also go.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_cmd.c |4 +--
.../media/atomisp/pci/atomisp2/atom
Currently the code handles this in the abstraction above. We want to remove
that abstraction so begin by pushing down the sanity check. Unfortunately
at this point we can't simply fix the init order.
Signed-off-by: Alan Cox
---
.../staging/media/atomisp/pci/atomisp2/hmm/hmm.c |5 +++
This is just another wrapper layer around hmm_free that servers no purpose
in this driver.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_acc.c |6 +++---
.../atomisp2/css2400/base/refcount/src/refcount.c |8
.../memory_access/memory_access.h
We don't need any of these indirections as we only support one MMU type. Start
by getting rid of the init/clear/free ones. The init ordering check we already
pushed down in a previous patch.
The allocation side is more complicated so leave it for now.
Signed-off-by: Alan Cox
---
.../
> I'm pretty sure we want this code to be built as a module, so maybe a
> Kconfig change would resolve the issue instead?
>
> Alan, any thoughts?
It's a tiny chunk of platform helper code. It probably ultimately
belongs in arch/x86 somewhere or folded into the driver.
UDS is another layer which actually boils down to some trivial assignments so
remove it so inline the code.
Signed-off-by: Alan Cox
---
.../ia_css_isp_params.c| 12 ---
.../ia_css_isp_params.c| 12 ---
.../ia_css_isp_params.c
These are not used in the driver so can go away.
Signed-off-by: Alan Cox
---
.../staging/media/atomisp/pci/atomisp2/Makefile|4 -
.../kernels/xnr/xnr3_0_11/ia_css_xnr3_0_11.host.c | 155
.../kernels/xnr/xnr3_0_11/ia_css_xnr3_0_11.host.h | 58
This is a whole pile of code that wraps a single assignment. Remove it and
put the assignment in the caller. Once we have the kernels sorted we should
revisit these and remove all the pointless 1 item structs that go with it.
Signed-off-by: Alan Cox
---
.../ia_css_isp_params.c
This isn't used so it can go in the bitbucket.
Signed-off-by: Alan Cox
---
.../staging/media/atomisp/pci/atomisp2/Makefile|1 -
.../css2400/isp/kernels/satm/ia_css_satm.host.c| 27 ---
.../css2400/isp/kernels/satm/ia_css_satm.host.h|
Where we know the buffer size is reasonably constrained we can just use kmalloc,
and where it will be large vmalloc. This still leaves a pile in the middle.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/css2400/sh_css.c| 92 ++--
.../atomisp/pci/atomisp2
They can be replaced by kmalloc. There are a few that do need to pick kmalloc
or vmalloc. Those we leave for the moment.
Signed-off-by: Alan Cox
---
.../atomisp/pci/atomisp2/atomisp_compat_css20.c|4 --
.../media/atomisp/pci/atomisp2/hmm/hmm_bo.c| 34
thing
Signed-off-by: Alan Cox
---
.../pci/atomisp2/css2400/ia_css_memory_access.c| 31 ++--
.../atomisp/pci/atomisp2/hrt/hive_isp_css_mm_hrt.c | 11 ---
.../atomisp/pci/atomisp2/hrt/hive_isp_css_mm_hrt.h |3 --
.../media/atomisp/pci/atomisp2/hrt/memory_access.c |
We have one hard coded set of behaviour so unpick the indirection and function
pointers. This isn't the whole story. A lot of the callers are known sizes and
use cases so we can switch them directly to kmalloc later on.
Signed-off-by: Alan Cox
---
.../atomisp/pci/atomisp2/atomisp_compat_cs
We are not using these for debugging or debug logging so remove the defines,
trim and rename the functions.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/css2400/sh_css.c| 15 +++
.../atomisp/pci/atomisp2/css2400/sh_css_internal.h | 17 -
2 files
From: Daeseok Youn
The line which is initializing mipi_info variable is too long
to read. It would be placed in next line.
Signed-off-by: Daeseok Youn
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_cmd.c |8 +---
1 file changed, 5 insertions(+), 3 deletions
on and add
disable_isp_irq function only.
Signed-off-by: Daeseok Youn
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_cmd.c | 36 +---
1 file changed, 9 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
b/drive
From: Daeseok Youn
The address of isp->asd[i] is already assigned to
local "asd" variable. "&isp->asd[i]" would be replaced with
just "asd".
Signed-off-by: Daeseok Youn
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_cmd.c |
From: Colin Ian King
trivial fix to spelling mistake in dev_err error message
Signed-off-by: Colin Ian King
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/hmm/hmm_bo_dev.c|2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci
From: Daeseok Youn
Define new local variable to reduce the number of reference.
The new local variable is added to save the addess of dfs
and used in atomisp_freq_scaling() function.
Signed-off-by: Daeseok Youn
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_cmd.c
d.c file.
> So remove the enable_isp_irq() function and add
> disable_isp_irq function only.
All 3 added to my tree - thanks
Alan
On Thu, 30 Mar 2017, Oliver Neukum wrote:
> Am Donnerstag, den 30.03.2017, 11:55 -0400 schrieb Alan Stern:
> >
> > I'm pretty sure that usb-storage does not do this, at least, not when
> > operating in its normal Bulk-Only-Transport mode. It never tries to
> >
On Thu, 30 Mar 2017, Mauro Carvalho Chehab wrote:
> Em Thu, 30 Mar 2017 10:26:32 -0400 (EDT)
> Alan Stern escreveu:
>
> > On Thu, 30 Mar 2017, Oliver Neukum wrote:
> >
> > > > Btw, I'm a lot more concerned about USB storage drivers. When I was
>
te "the buffer can be
continuous", but that is certainly not what he meant.
Alan Stern
where there are ISP2400/ISP2401 ifdefs ?
Alan
ise - but it should also have
something in the commit message.
Alan
We don't need an ifdef for the sake of 8-12 bytes. Avoid the ifdef added by
fde469701c7efabebf885e785edf367bfb1a8f3f. Instead turn it into a single const
string array at a fixed location thereby saving even more memory.
Signed-off-by: Alan Cox
---
.../staging/media/atomisp/pci/atomisp
From: Pushkar Jambhlekar
Removing hardcoded function name as code is already using __func__
Signed-off-by: Pushkar Jambhlekar
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/hmm/hmm_bo.c|2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
HAS_TNR3 is never defined so we can remove it.
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/css2400/sh_css_sp.c |4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c
b/drivers/staging/media/atomisp/pci/atomisp2
From: Derek Robson
Changed permissions to octal style
Found using checkpatch
Signed-off-by: Derek Robson
Signed-off-by: Alan Cox
---
.../media/atomisp/pci/atomisp2/atomisp_drvfs.c |9 +++--
.../staging/media/atomisp/pci/atomisp2/hmm/hmm.c |8
2 files changed, 7
1 - 100 of 367 matches
Mail list logo
