Re: [Ksummit-discuss] [PATCH] media: add a subsystem profile documentation

2019-09-19 Thread Joe Perches
On Thu, 2019-09-19 at 10:08 +0300, Dan Carpenter wrote: > On Wed, Sep 18, 2019 at 03:48:31PM -0300, Mauro Carvalho Chehab wrote: > > Em Wed, 18 Sep 2019 20:27:05 +0300 > > Laurent Pinchart escreveu: > > > > > > Anyway, not sure if the other sub-maintainers see the same way. From my > > > > side,

Re: [PATCH] media: rc: Add support for another iMON 0xffdc device

2019-09-19 Thread Flavius Adrian
On Thu, Sep 19, 2019 at 6:40 PM Sean Young wrote: > > Hi Flavius, > > Please make sure you label your patch with sequentially increasing versions. > I think the last one was v3 and there is no v4. > Hi Sean, thanks for taking the time to review this patch. I decided to re-send the patch because th

[PATCH 2/5] docs: media: vimc: Documenting vimc topology configuration using configfs

2019-09-19 Thread Dafna Hirschfeld
Add explanation of how to use configfs in order to create a vimc device with a given topology. Signed-off-by: Dafna Hirschfeld --- Documentation/media/v4l-drivers/vimc.dot | 28 ++- Documentation/media/v4l-drivers/vimc.rst | 240 --- 2 files changed, 220 insertions(+), 48 de

[PATCH 0/5] media: vimc: use configfs in order to configure devices topologies

2019-09-19 Thread Dafna Hirschfeld
This patchset introduces the usage of configfs in order to create vimc devices with a configured topology. A patch introducing configfs usage was already sent by Helen Koike: https://patchwork.linuxtv.org/patch/53397/ . The current patch is based on her patch but suggests a new API for using conf

[PATCH 1/5] media: vimc: upon streaming, check that the pipeline starts with a source entity

2019-09-19 Thread Dafna Hirschfeld
Userspace can disable links and create pipelines that do not start with a source entity. Trying to stream from such a pipeline should fail with -EPIPE currently this is not handled and cause kernel crash. Reproducing the crash: media-ctl -d0 -l "5:1->21:0[0]" -v v4l2-ctl -z platform:vimc -d "RGB/Y

[PATCH 5/5] media: vimc: Add device index to the bus_info

2019-09-19 Thread Dafna Hirschfeld
Use a bitmask to get the next available device index to be used for the bus_info field in the v4l2_capability struct in the VIDIOC_QUERYCAP ioctl Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vimc/vimc-capture.c | 8 ++-- drivers/media/platform/vimc/vimc-common.h | 2 ++ driv

[PATCH 4/5] media: vimc: use configfs instead of having hardcoded configuration

2019-09-19 Thread Dafna Hirschfeld
Use configfs in order to create a device and set its topology and remove the hardcoded device. Signed-off-by: Helen Koike [refactored for upstream] Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vimc/vimc-capture.c | 21 +- drivers/media/platform/vimc/vimc-common.h | 50 +-- dr

[PATCH 3/5] media: vimc: Add the implementation for the configfs api

2019-09-19 Thread Dafna Hirschfeld
Add the code that implements the usage of configfs in order to create and configure a device topology from userspace. The code is only added in this patch but is not used. It will be used in next patch in the series. Signed-off-by: Helen Koike [refactored for upstream] Signed-off-by: Dafna Hirsch

[PATCH v5] cec-follower: add tuner analog service emulation

2019-09-19 Thread Jiunn Chang
Implement the following tuner control features: - - and reply Signed-off-by: Jiunn Chang --- Changes made since v1: - Fix typos/bugs - Import reply_feature_abort() from cec-processing.cpp - Add functionality to choose nearest frequency Changes made since v2: - Fix typos/bugs -

[PATCH v4] cec-follower: create analog channel frequencies

2019-09-19 Thread Jiunn Chang
This frequency table will allow proper testing of tuner control. There are three frequencies per analog broadcast type and broadcast system, so tuner increment and decrement can be tested. Signed-off-by: Jiunn Chang --- Changes made since v1: - Add Wikipedia link for analog channel frequencie

[PATCH v2] cec-follower: fix cec-tuner.cpp

2019-09-19 Thread Jiunn Chang
Remove static from reply_feature_abort() in cec-processing.cpp so it can be used in cec-tuner.cpp. This is maintain testing logic for PRESUMED_OK which replies on the feature abort message. Also needed is a boolean for broadcast messages that should not be aborted. Signed-off-by: Jiunn Chang --

Re: [PATCH] media: rc: Add support for another iMON 0xffdc device

2019-09-19 Thread Sean Young
Hi Flavius, Please make sure you label your patch with sequentially increasing versions. I think the last one was v3 and there is no v4. On Thu, Sep 19, 2019 at 06:13:58PM +0300, Flavius Georgescu wrote: > The device it's an iMON UltraBay (0x98 in config byte) with LCD, > IR and dual-knobs front

[PATCH] media: rc: Add support for another iMON 0xffdc device

2019-09-19 Thread Flavius Georgescu
The device it's an iMON UltraBay (0x98 in config byte) with LCD, IR and dual-knobs front panel. To work properly the device also require its own key table, and repeat suppression for all buttons. Signed-off-by: Flavius Georgescu Co-developed-by: Chris Vandomelen Signed-off-by: Chris Vandomelen

Lieber

2019-09-19 Thread Peace Maurice
DO YOU SPEAK ENGLISH? Lieber, ich bin Friede Maurice, es wäre schön, dich zu kennen. Ich habe eine sehr wichtige und vertrauliche Angelegenheit, die ich mit dir besprechen möchte. Antworte mir für weitere Diskussionen. Grüße, Frieden.

Re: [PATCH v3] media: rc: Add support for another 0xffdc device

2019-09-19 Thread Flavius Georgescu
Please igonore this patch,due to some dumb mistakes and to avoid confusion , i will re-send the patch as a new thread.I apologize for any inconvenience!

Re: [PATCH v2] media: rc: Add support for another 0xffdc device

2019-09-19 Thread Flavius Georgescu
Please igonore this patch,due to some dumb mistakes and to avoid confusion , i will re-send the patch as a new thread.I apologize for any inconvenience!

Re: [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-09-19 Thread Keiichi Watanabe
I shared PDF version of this RFC on Google drive: https://drive.google.com/drive/folders/1hed-mTVI7dj0M_iab4DTfx5kPMLoeX8R On Thu, Sep 19, 2019 at 8:15 PM Keiichi Watanabe wrote: > > Hi Hans, > Thank you for your feedback. > > On Thu, Sep 19, 2019 at 6:53 PM Hans Verkuil wrote: > > > > Hi Keiich

Re: [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-09-19 Thread Keiichi Watanabe
Hi Hans, Thank you for your feedback. On Thu, Sep 19, 2019 at 6:53 PM Hans Verkuil wrote: > > Hi Keiichi, > > On 9/19/19 11:34 AM, Keiichi Watanabe wrote: > > [Resending because of some issues with sending to virtio-dev. Sorry for the > > noise.] > > > > This patch proposes virtio specification

[PATCH] cec-gpio: add notifier support

2019-09-19 Thread Hans Verkuil
Add support for cec-notifier to the cec-gpio driver. This makes it possible to associate the CEC gpio pin with an HDMI connector. This feature was always documented in the cec-gpio bindings: Documentation/devicetree/bindings/media/cec-gpio.txt But support for the hdmi-phandle property was never

Re: [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-09-19 Thread Hans Verkuil
Hi Keiichi, On 9/19/19 11:34 AM, Keiichi Watanabe wrote: > [Resending because of some issues with sending to virtio-dev. Sorry for the > noise.] > > This patch proposes virtio specification for new virtio video decode > device. > This device provides the functionality of hardware accelerated vid

Re: [Ksummit-discuss] [PATCH] media: add a subsystem profile documentation

2019-09-19 Thread Mauro Carvalho Chehab
Em Thu, 19 Sep 2019 09:56:44 +0300 Dan Carpenter escreveu: > On Wed, Sep 18, 2019 at 10:57:28AM -0300, Mauro Carvalho Chehab wrote: > > > > +Patches for the media subsystem should be sent to the media mailing > > > > list > > > > +at linux-media@vger.kernel.org as plain text only e-mail. Emails

Re: [Ksummit-discuss] [PATCH] media: add a subsystem profile documentation

2019-09-19 Thread Jani Nikula
On Thu, 19 Sep 2019, Geert Uytterhoeven wrote: > Hi Jani, > > On Thu, Sep 19, 2019 at 10:49 AM Jani Nikula wrote: >> On Thu, 19 Sep 2019, Geert Uytterhoeven wrote: >> > On Thu, Sep 19, 2019 at 8:57 AM Dan Carpenter >> > wrote: >> >> On Wed, Sep 18, 2019 at 10:57:28AM -0300, Mauro Carvalho Cheh

[PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-09-19 Thread Keiichi Watanabe
[Resending because of some issues with sending to virtio-dev. Sorry for the noise.] This patch proposes virtio specification for new virtio video decode device. This device provides the functionality of hardware accelerated video decoding from encoded video contents provided by the guest into fra

Re: [PATCH v3] media: rc: Add support for another 0xffdc device

2019-09-19 Thread Flavius Georgescu
The device it's an iMON UltraBay (0x98 in config byte) with LCD, IR and dual-knobs front panel. To work properly the device also require its own key table, and repeat suppression for all buttons. Signed-off-by: Flavius Georgescu Co-developed-by: Chris Vandomelen Signed-off-by: Chris Vandomelen

[PATCH] [RFC] vdec: Add virtio video decode device specification

2019-09-19 Thread Keiichi Watanabe
This patch proposes virtio specification for new virtio video decode device. This device provides the functionality of hardware accelerated video decoding from encoded video contents provided by the guest into frame buffers accessible by the guest. We have prototype implementation for VMs on Chrom

Re: [PATCH v4] cec-follower: add tuner analog service emulation

2019-09-19 Thread Hans Verkuil
On 9/19/19 6:18 AM, Jiunn Chang wrote: > Implement the following tuner control features: > - > - and reply > > Signed-off-by: Jiunn Chang > --- > > Changes made since v1: > - Fix typos/bugs > - Import reply_feature_abort() from cec-processing.cpp > - Add functionality to choose near

Re: [Ksummit-discuss] [PATCH] media: add a subsystem profile documentation

2019-09-19 Thread Geert Uytterhoeven
Hi Jani, On Thu, Sep 19, 2019 at 10:49 AM Jani Nikula wrote: > On Thu, 19 Sep 2019, Geert Uytterhoeven wrote: > > On Thu, Sep 19, 2019 at 8:57 AM Dan Carpenter > > wrote: > >> On Wed, Sep 18, 2019 at 10:57:28AM -0300, Mauro Carvalho Chehab wrote: > >> When I sent a patch, I use get_maintainer.

Re: [Ksummit-discuss] [PATCH] media: add a subsystem profile documentation

2019-09-19 Thread Jani Nikula
On Thu, 19 Sep 2019, Geert Uytterhoeven wrote: > On Thu, Sep 19, 2019 at 8:57 AM Dan Carpenter > wrote: >> On Wed, Sep 18, 2019 at 10:57:28AM -0300, Mauro Carvalho Chehab wrote: >> When I sent a patch, I use get_maintainer.pl then I add whoever the >> wrote the commit from the Fixes tag. Then I

Re: [PATCH] cec-follower: fix cec-tuner.cpp

2019-09-19 Thread Hans Verkuil
Hi Jiunn, On 9/19/19 4:17 AM, Jiunn Chang wrote: > Export code from cec-processing.cpp to cec-tuner.cpp so testing logic > does not break for PRESUMED_OK which replies on the feature abort > message. Also needed it a boolean for broadcast messages that should > not be aborted. > > Signed-off-by:

Re: [Ksummit-discuss] [PATCH] media: add a subsystem profile documentation

2019-09-19 Thread Geert Uytterhoeven
On Thu, Sep 19, 2019 at 8:57 AM Dan Carpenter wrote: > On Wed, Sep 18, 2019 at 10:57:28AM -0300, Mauro Carvalho Chehab wrote: > > > > +Patches for the media subsystem should be sent to the media mailing > > > > list > > > > +at linux-media@vger.kernel.org as plain text only e-mail. Emails with >

Re: [Ksummit-discuss] [PATCH] media: add a subsystem profile documentation

2019-09-19 Thread Dan Carpenter
On Wed, Sep 18, 2019 at 03:48:31PM -0300, Mauro Carvalho Chehab wrote: > Em Wed, 18 Sep 2019 20:27:05 +0300 > Laurent Pinchart escreveu: > > > > Anyway, not sure if the other sub-maintainers see the same way. From my > > > side, > > > I prefer not to be c/c, as this is just more noise, as I just