Re: [PATCH 3/3] media: hantro: h264: Fix the frame_num wraparound case

2019-09-17 Thread Tomasz Figa
On Wed, Sep 18, 2019 at 2:04 PM Francois Buergisser wrote: > > On Mon, Sep 9, 2019 at 4:28 PM Boris Brezillon > wrote: > > > > Step '8.2.4.1 Decoding process for picture numbers' was missing in the > > reflist creation logic, leading to invalid P reflists when a > > ->frame_num wraparound happens

Re: [PATCH 2/3] media: hantro: h264: Rename POC_CMP() into HANTRO_CMP()

2019-09-17 Thread Tomasz Figa
On Wed, Sep 18, 2019 at 2:04 PM Francois Buergisser wrote: > > On Mon, Sep 9, 2019 at 4:28 PM Boris Brezillon > wrote: > > > > And use it for all native type comparisons, even if it's not strictly > > required. By doing that we make the code more consistent and prevent > > from potential incorrec

Re: [PATCH 1/3] media: hantro: h264: Fix a comment in b1_ref_list_cmp()

2019-09-17 Thread Tomasz Figa
On Wed, Sep 18, 2019 at 2:03 PM Francois Buergisser wrote: > > On Mon, Sep 9, 2019 at 4:28 PM Boris Brezillon > wrote: > > > > So it matches the code and the spec. > > > > Signed-off-by: Boris Brezillon > Tested-by: Francois Buergisser Reviewed-by: Tomasz Figa Best regards, Tomasz

Re: [PATCH 2/3] media: hantro: h264: Rename POC_CMP() into HANTRO_CMP()

2019-09-17 Thread Francois Buergisser
On Mon, Sep 9, 2019 at 4:28 PM Boris Brezillon wrote: > > And use it for all native type comparisons, even if it's not strictly > required. By doing that we make the code more consistent and prevent > from potential incorrect results in case of overflow or when the the > values being compared are

Re: [PATCH 3/3] media: hantro: h264: Fix the frame_num wraparound case

2019-09-17 Thread Francois Buergisser
On Mon, Sep 9, 2019 at 4:28 PM Boris Brezillon wrote: > > Step '8.2.4.1 Decoding process for picture numbers' was missing in the > reflist creation logic, leading to invalid P reflists when a > ->frame_num wraparound happens. > > Fixes: a9471e25629b ("media: hantro: Add core bits to support H264 d

Re: [PATCH 1/3] media: hantro: h264: Fix a comment in b1_ref_list_cmp()

2019-09-17 Thread Francois Buergisser
On Mon, Sep 9, 2019 at 4:28 PM Boris Brezillon wrote: > > So it matches the code and the spec. > > Signed-off-by: Boris Brezillon Tested-by: Francois Buergisser

Re: [V2, 1/2] media: i2c: dw9768: Add DT support and MAINTAINERS entry

2019-09-17 Thread Rob Herring
On Thu, Sep 05, 2019 at 03:24:49PM +0300, Andy Shevchenko wrote: > On Thu, Sep 05, 2019 at 03:00:12PM +0300, Sakari Ailus wrote: > > > And I see no reason to add a separate patch just for > > MAINTAINERS change. > > It's up to maintainers of the subsystem. Just update MAINTAINERS with the driver

RE: [LINUX PATCH] dma-mapping: Control memset operation using gfp flags

2019-09-17 Thread Dylan Yip
Please ignore, sent to wrong list. > -Original Message- > From: Dylan Yip > Sent: Tuesday, September 17, 2019 1:21 PM > To: linux-media@vger.kernel.org; Satish Kumar Nagireddy > > Cc: Dylan Yip > Subject: [LINUX PATCH] dma-mapping: Control memset operation using gfp > flags > > In case

[LINUX PATCH] dma-mapping: Control memset operation using gfp flags

2019-09-17 Thread Dylan Yip
In case of 4k video buffer, the allocation from a reserved memory is taking a long time, ~500ms. This is root caused to the memset() operations on the allocated memory which is consuming more cpu cycles. Due to this delay, we see that initial frames are being dropped. To fix this, we have wrapped

Re: [RFC, v3, 1/4] dt-binding: mt8183: Add Mediatek MDP3 dt-bindings

2019-09-17 Thread Rob Herring
On Wed, Sep 11, 2019 at 05:34:03PM +0800, Bibby Hsieh wrote: > From: daoyuan huang > > This patch adds DT binding document for Media Data Path 3 (MDP3) > a unit in multimedia system used for scaling and color format convert. > > Signed-off-by: Ping-Hsun Wu > Signed-off-by: daoyuan huang > ---

[PATCH v2] cec-follower: add tuner analog service emulation

2019-09-17 Thread Jiunn Chang
Implement the following tuner control features: - - and reply Signed-off-by: Jiunn Chang --- utils/cec-follower/cec-follower.h | 1 + utils/cec-follower/cec-tuner.cpp | 89 ++- 2 files changed, 78 insertions(+), 12 deletions(-) diff --git a/utils/cec-follower/

Re: coda9 jpeg support?

2019-09-17 Thread Tim Harvey
On Tue, Sep 17, 2019 at 7:33 AM Philipp Zabel wrote: > > Hi Tim, > > On Fri, 2019-09-13 at 09:00 -0700, Tim Harvey wrote: > > Greetings, > > > > What would need to be done to support JPEG enc/dec for coda9? > > here is a WIP that still needs some cleanup for upstreaming: > > https://git.pengutro

Re: [RFC PATCH V3 1/3] dt-bindings: mt8183: Added FD dt-bindings

2019-09-17 Thread Rob Herring
On Fri, 6 Sep 2019 18:11:23 +0800, Jerry-ch Chen wrote: > From: Jerry-ch Chen > > This patch adds DT binding documentation for the Face Detection (FD) > unit of the Mediatek's mt8183 SoC. > > Signed-off-by: Jerry-ch Chen > --- > .../bindings/media/mediatek,mt8183-fd.txt | 34 ++

sehr geehrter

2019-09-17 Thread Peace maurice
DO YOU SPEAK ENGLISH? Lieber, ich bin Peace Maurice, es wäre schön, dich zu kennen, ich habe eine sehr wichtige und vertrauliche Angelegenheit, die ich mit dir besprechen möchte, antworte mir für weitere Diskussionen. Grüße, Frieden.

Re: single maintainer profile directory (was Re: [Ksummit-discuss] [PATCH] media: add a subsystem profile documentation)

2019-09-17 Thread Kees Cook
On Tue, Sep 17, 2019 at 10:28:17AM -0300, Mauro Carvalho Chehab wrote: > No matter where the profiles will physically be stored, its contents belong > to subsystem-specific documentation, and should be visible at the same index > file as the kAPI docs is located, as anyone interested on submittin

Re: [PATCH] RFC: v4l2-ctrls: Inmplement v4l2_ctrl_new_std_compound()

2019-09-17 Thread Ricardo Ribalda Delgado
Hi Hans Is this something close to what you were having in mind? Right now it sits on https://github.com/ribalda/linux/commit/de21dbc2f57b58b22f5d73bc314dd8e59dff5c7d but I will make it as the beginning of my patchset if you think that I am on the right track. Thanks! On Tue, Sep 17, 2019 at 6:

[PATCH] RFC: v4l2-ctrls: Inmplement v4l2_ctrl_new_std_compound()

2019-09-17 Thread Ricardo Ribalda Delgado
Implement v4l2_ctrl_new_std_compound. This is just a discussion patch, do not merge as is, and be gentle with the author ;P. Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/i2c/imx214.c | 13 +++-- drivers/media/v4l2-core/v4l2-ctrls.c | 79 +--- include

Re: [V2, 1/2] media: dt-bindings: media: i2c: Add bindings for ov8856

2019-09-17 Thread Rob Herring
On Tue, Sep 17, 2019 at 03:02:06PM +0300, Sakari Ailus wrote: > On Tue, Sep 10, 2019 at 08:37:43PM +0300, Andy Shevchenko wrote: > > On Tue, Sep 10, 2019 at 09:04:45PM +0800, dongchun@mediatek.com wrote: > > > From: Dongchun Zhu > > > > > > This patch adds device tree bindings documentation f

Re: coda9 jpeg support?

2019-09-17 Thread Philipp Zabel
Hi Tim, On Fri, 2019-09-13 at 09:00 -0700, Tim Harvey wrote: > Greetings, > > What would need to be done to support JPEG enc/dec for coda9? here is a WIP that still needs some cleanup for upstreaming: https://git.pengutronix.de/cgit/pza/linux/log/?h=coda/jpeg Basically I'd like to avoid addi

Re: [RFC] media: vimc: Implement frame rate control

2019-09-17 Thread Guilherme Alcarde Gallo
Hi Hans. Thank you very much for your prompt response. I'll work on your suggestions. Please give me some days to send the next patch. Regards, Guilherme On Tue, Sep 17, 2019 at 6:14 AM Hans Verkuil wrote: > > Hi Guilherme, > > Some comments below: > > On 9/17/19 3:33 AM, Guilherme Alcarde Gal

[PATCHv4 2/3] v4l2-dev: simplify the SDR checks

2019-09-17 Thread Hans Verkuil
In determine_valid_ioctls() we can use SET_VALID_IOCTL to enable ioctls for SDR, simplifying the code. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-dev.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-dev

[PATCHv4 0/3] v4l2-core: Add metadata type to vfl_devnode_type

2019-09-17 Thread Hans Verkuil
This is a follow-up series from Vandana's "[v3] v4l2-core: Add metadata type to vfl_devnode_type" patch: https://patchwork.linuxtv.org/patch/58755/ While testing that v3 patch with a patched version of vivid that has metadata capture support, I realized that metadata should be treated the same way

[PATCHv4 1/3] v4l2-core: Add metadata type to vfl_devnode_type

2019-09-17 Thread Hans Verkuil
From: Vandana BN Add VFL_TYPE_METADATA, to detect devices of type metadata and to disable unneeded ioctls. Without this change, format ioctls for both video and metadata devices could be called on both device nodes. This is true for other ioctls as well. Metadata devices act similar to VBI devi

[PATCHv4 3/3] v4l2-dev: fix is_tch checks

2019-09-17 Thread Hans Verkuil
Touch devices mark too many ioctls as valid. Restrict the list of valid ioctls for touch devices. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-dev.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-dev.c b/dr

Re: single maintainer profile directory (was Re: [Ksummit-discuss] [PATCH] media: add a subsystem profile documentation)

2019-09-17 Thread Mauro Carvalho Chehab
Hi Kees, Em Mon, 16 Sep 2019 20:35:45 -0700 Kees Cook escreveu: > On Fri, Sep 13, 2019 at 01:19:21PM -0300, Mauro Carvalho Chehab wrote: > > Document the basic policies of the media subsystem profile. > > > > Signed-off-by: Mauro Carvalho Chehab > > --- > > > > That's basically a modified ver

Re: [PATCH] cec-follower: add tuner analog service emulation

2019-09-17 Thread Hans Verkuil
On 9/17/19 11:43 AM, Jiunn Chang wrote: > Implement the following tuner control features: > - > - and reply > > Signed-off-by: Jiunn Chang > --- > utils/cec-follower/cec-tuner.cpp | 51 > 1 file changed, 39 insertions(+), 12 deletions(-) > > diff --git a/ut

Re: [V2, 1/2] media: dt-bindings: media: i2c: Add bindings for ov8856

2019-09-17 Thread Sakari Ailus
On Tue, Sep 10, 2019 at 08:37:43PM +0300, Andy Shevchenko wrote: > On Tue, Sep 10, 2019 at 09:04:45PM +0800, dongchun@mediatek.com wrote: > > From: Dongchun Zhu > > > > This patch adds device tree bindings documentation for the ov8856 CMOS > > image sensor. > > New bindings in YAML, please.

Re: [PATCH v6] vivid: Add metadata capture support

2019-09-17 Thread Hans Verkuil
On 9/16/19 4:08 PM, Vandana BN wrote: > This patch adds meatadata capture support in vivid driver. > Added new files for metadata capture. > > Signed-off-by: Vandana BN > --- > Changes since v5: > -Use multiline comment in vivid-core.c. > -changed vivid_meta_cap_gen() to take proper length. > ---

[PATCH v4] v4l2-ctl: Print UVC meta info

2019-09-17 Thread Vandana BN
Print UVC Metadata information in verbose mode. Signed-off-by: Vandana BN --- Changes since v3: - Coding style corrections in print_meta_buffer. --- utils/v4l2-ctl/v4l2-ctl-meta.cpp | 27 +++ utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 14 -- utils/v4l2-ctl/v

Re: [PATCH v3] v4l2-core: Add metadata type to vfl_devnode_type

2019-09-17 Thread Hans Verkuil
On 9/17/19 11:54 AM, Hans Verkuil wrote: > On 9/13/19 8:57 AM, Vandana BN wrote: >> Add VFL_TYPE_METADATA, to detect devices of type metadata and >> to disable unneeded ioctls. >> Without this change, format ioctls for both video and metadata devices >> could be called on both device nodes.This is

Re: [PATCH v3] v4l2-core: Add metadata type to vfl_devnode_type

2019-09-17 Thread Hans Verkuil
On 9/13/19 8:57 AM, Vandana BN wrote: > Add VFL_TYPE_METADATA, to detect devices of type metadata and > to disable unneeded ioctls. > Without this change, format ioctls for both video and metadata devices > could be called on both device nodes.This is true for other ioctls as > well. > > Signed-of

[PATCH] cec-follower: add tuner analog service emulation

2019-09-17 Thread Jiunn Chang
Implement the following tuner control features: - - and reply Signed-off-by: Jiunn Chang --- utils/cec-follower/cec-tuner.cpp | 51 1 file changed, 39 insertions(+), 12 deletions(-) diff --git a/utils/cec-follower/cec-tuner.cpp b/utils/cec-follower/cec-tune

Re: [PATCH v3] v4l2-ctl: Print UVC meta info

2019-09-17 Thread Hans Verkuil
On 9/16/19 8:00 PM, Vandana BN wrote: > Print UVC Metadata information in verbose mode. > > Signed-off-by: Vandana BN > --- > Changes since v2 > - Converted if to switch statement. > - Corrected format specifier in print. > --- > utils/v4l2-ctl/v4l2-ctl-meta.cpp | 25 +++

Re: [PATCH v2] cec-follower: create analog channel frequencies

2019-09-17 Thread Hans Verkuil
On 9/17/19 11:13 AM, Jiunn Chang wrote: > This frequency table will allow proper testing of tuner control. There > are three frequencies per analog broadcast type and broadcast system, so > tuner increment and decrement can be tested. > > Signed-off-by: Jiunn Chang > --- > > Changes since v1: >

Re: [RFC] media: vimc: Implement frame rate control

2019-09-17 Thread Hans Verkuil
Hi Guilherme, Some comments below: On 9/17/19 3:33 AM, Guilherme Alcarde Gallo wrote: > In order to make the frame rate changeable, this patch implements the > ioctls VIDIOC_ENUM_FRAMEINTERVALS, VIDIOC_S_PARM and VIDIOC_G_PARM. > Most of the implementation was based on vivid driver. > > The fram

[PATCH v2] cec-follower: create analog channel frequencies

2019-09-17 Thread Jiunn Chang
This frequency table will allow proper testing of tuner control. There are three frequencies per analog broadcast type and broadcast system, so tuner increment and decrement can be tested. Signed-off-by: Jiunn Chang --- Changes since v1: - Add Wikipedia link for analog channel frequencies - A

Re: [PATCH] cec-follower: create analog channel frequencies

2019-09-17 Thread Hans Verkuil
On 9/16/19 8:38 PM, Jiunn Chang wrote: > This frequency table will allow proper testing of tuner control. There > are three frequencies per analog broadcast type and broadcast system, so > tuner increment and decrement can be tested. > > Signed-off-by: Jiunn Chang > --- > utils/cec-follower/cec

Re: [PATCH] media: v4l: cadence: Fix how unsued lanes are handled in 'csi2rx_start()'

2019-09-17 Thread Marc Gonzalez
On 12/09/2019 22:44, Christophe JAILLET wrote: > Subject: [PATCH] media: v4l: cadence: Fix how unsued lanes are handled in > 'csi2rx_start()' s/unsued/unused > The 2nd parameter of 'find_first_zero_bit()' is a number of bits, not of > bytes. So use 'BITS_PER_LONG' instead of 'sizeof(lanes_used)