cron job: media_tree daily build: WARNINGS

2019-08-23 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Aug 24 05:00:12 CEST 2019 media-tree git hash:577bbf23b758848f0c4a50d346460b690c753024 media_build gi

[PATCH 0/2] media: imx: Fix subdev unregister/register issues

2019-08-23 Thread Steve Longerbeam
If the media device module is removed and re-probed without also removing and re-probing the subdevice modules, .unregister() and .register() ops are called on the subdevices without the subdevice drivers being removed and re-probed. This creates two problems: - the CSI and PRPENCVF subdevices att

Re: [PATCH] gl861: re-implement i2c adapter logic

2019-08-23 Thread Antti Palosaari
On 8/24/19 2:33 AM, Antti Palosaari wrote: On 8/23/19 8:28 PM, Akihiro TSUKADA wrote: Hi, thanks for the example patch. Here is debug log I tested multibyte i2c writes using zl10353 demod. All returned bytes are not same, but it due to write only register bits I think. dvb_usb_gl861 1-13

[PATCH v2] gl861: re-implement I2C adapter logic

2019-08-23 Thread Antti Palosaari
Device I2C adapter is capable of writing and reading large messages. For I2C writes there is 2 methods: simple for max 2 byte messages and usb_control_msg() with payload data for larger I2C messages. Add I2C adapter logic which selects suitable method according to message size. Add also support for

Re: [PATCH] gl861: re-implement i2c adapter logic

2019-08-23 Thread Antti Palosaari
On 8/23/19 8:28 PM, Akihiro TSUKADA wrote: Hi, thanks for the example patch. Here is debug log I tested multibyte i2c writes using zl10353 demod. All returned bytes are not same, but it due to write only register bits I think. dvb_usb_gl861 1-13:1.0: 1 | c0 02 00 1e 50 00 01 00 <<< 03 dvb_u

[PATCH] media: aspeed: fix an incorrect return code on buffer allocation failure

2019-08-23 Thread Jae Hyun Yoo
It returns '0' even when a failure happens on jpeg buffer allocation so this commit fixes the issue. Signed-off-by: Jae Hyun Yoo --- drivers/media/platform/aspeed-video.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-vi

Re: [PATCH v2 5/7] media: use the BIT() macro

2019-08-23 Thread Laurent Pinchart
Hi Mauro, Thank you for the patch. On Fri, Aug 23, 2019 at 06:47:30AM -0300, Mauro Carvalho Chehab wrote: > As warned by cppcheck: > > [drivers/media/dvb-frontends/cx24123.c:434]: (error) Shifting signed > 32-bit value by 31 bits is undefined behaviour > [drivers/media/pci/bt8xx/btt

Re: [PATCH v18 15/15] selftests, arm64: add a selftest for passing tagged pointers to kernel

2019-08-23 Thread Cristian Marussi
Hi On 23/08/2019 18:16, Andrey Konovalov wrote: > On Fri, Aug 23, 2019 at 3:56 PM Cristian Marussi > wrote: >> >> Hi Andrey >> >> On 24/06/2019 15:33, Andrey Konovalov wrote: >>> This patch is a part of a series that extends kernel ABI to allow to pass >>> tagged user pointers (with the top byt

Re: [PATCH] gl861: re-implement i2c adapter logic

2019-08-23 Thread Akihiro TSUKADA
Hi, thanks for the example patch. > Here is debug log I tested multibyte i2c writes using zl10353 demod. All > returned bytes are not same, but it due to write only register bits I > think. > > dvb_usb_gl861 1-13:1.0: 1 | c0 02 00 1e 50 00 01 00 <<< 03 > dvb_usb_gl861 1-13:1.0: 1 | c0 02 00 1e 51

Re: [PATCH v18 15/15] selftests, arm64: add a selftest for passing tagged pointers to kernel

2019-08-23 Thread Andrey Konovalov
On Fri, Aug 23, 2019 at 3:56 PM Cristian Marussi wrote: > > Hi Andrey > > On 24/06/2019 15:33, Andrey Konovalov wrote: > > This patch is a part of a series that extends kernel ABI to allow to pass > > tagged user pointers (with the top byte set to something else other than > > 0x00) as syscall arg

Re: [PATCH] media: bindings: video-interfaces: Update the example

2019-08-23 Thread Niklas Soderlund
Hi Jacopo, Thanks for your patch. On 2019-08-22 23:04:33 +0200, Jacopo Mondi wrote: > The example provided by the video-interface.txt file uses compatible > values for drivers which are have been removed a long time ago. To avoid > generating confusion, replace the existing example with a new one

Re: [PATCH v18 15/15] selftests, arm64: add a selftest for passing tagged pointers to kernel

2019-08-23 Thread Cristian Marussi
Hi Andrey On 24/06/2019 15:33, Andrey Konovalov wrote: > This patch is a part of a series that extends kernel ABI to allow to pass > tagged user pointers (with the top byte set to something else other than > 0x00) as syscall arguments. > > This patch adds a simple test, that calls the uname sysca

Re: [PATCH v3 5/7] media: v4l2-core: Add new helper for area controls

2019-08-23 Thread Philipp Zabel
On Fri, 2019-08-23 at 15:05 +0200, Ricardo Ribalda Delgado wrote: > On Fri, Aug 23, 2019 at 2:56 PM Philipp Zabel wrote: > > > > On Fri, 2019-08-23 at 14:37 +0200, Ricardo Ribalda Delgado wrote: > > > Adding a V4L2_CID_UNIT_CELL_SIZE control requires a lot of boilerplate, > > > try to minimize it

Re: [PATCH v3 5/7] media: v4l2-core: Add new helper for area controls

2019-08-23 Thread Ricardo Ribalda Delgado
On Fri, Aug 23, 2019 at 2:56 PM Philipp Zabel wrote: > > On Fri, 2019-08-23 at 14:37 +0200, Ricardo Ribalda Delgado wrote: > > Adding a V4L2_CID_UNIT_CELL_SIZE control requires a lot of boilerplate, > > try to minimize it by adding a new helper. > > > > Suggested-by: Philipp Zabel > > Signed-off-

Re: [PATCH v3 4/7] media: imx214: Add new control with V4L2_CID_UNIT_CELL_SIZE

2019-08-23 Thread Philipp Zabel
On Fri, 2019-08-23 at 14:37 +0200, Ricardo Ribalda Delgado wrote: > According to the product brief, the unit cell size is 1120 nanometers^2. > > https://www.sony-semicon.co.jp/products_en/IS/sensor1/img/products/ProductBrief_IMX214_20150428.pdf > > Signed-off-by: Ricardo Ribalda Delgado If the

Re: [PATCH v3 3/7] Documentation: media: Document V4L2_CTRL_TYPE_AREA

2019-08-23 Thread Philipp Zabel
On Fri, 2019-08-23 at 14:37 +0200, Ricardo Ribalda Delgado wrote: > A struct v4l2_area containing the width and the height of a rectangular > area. > > Signed-off-by: Ricardo Ribalda Delgado > Suggested-by: Hans Verkuil > --- > Documentation/media/uapi/v4l/vidioc-queryctrl.rst | 6 ++ > 1 f

Re: [PATCH v3 2/7] Documentation: media: Describe V4L2_CID_UNIT_CELL_SIZE

2019-08-23 Thread Philipp Zabel
On Fri, 2019-08-23 at 14:37 +0200, Ricardo Ribalda Delgado wrote: > New control to pass to userspace the width/height of a pixel. Which is > needed for calibration and lens selection. > > Signed-off-by: Ricardo Ribalda Delgado > --- > Documentation/media/uapi/v4l/ext-ctrls-image-source.rst | 8 +

Re: [PATCH v3 5/7] media: v4l2-core: Add new helper for area controls

2019-08-23 Thread Philipp Zabel
On Fri, 2019-08-23 at 14:37 +0200, Ricardo Ribalda Delgado wrote: > Adding a V4L2_CID_UNIT_CELL_SIZE control requires a lot of boilerplate, > try to minimize it by adding a new helper. > > Suggested-by: Philipp Zabel > Signed-off-by: Ricardo Ribalda Delgado > --- > drivers/media/v4l2-core/v4l2-

[PATCH v3 1/7] media: add V4L2_CID_UNIT_CELL_SIZE control

2019-08-23 Thread Ricardo Ribalda Delgado
This control returns the unit cell size in nanometres. The struct provides the width and the height in separated fields to take into consideration asymmetric pixels and/or hardware binning. This control is required for automatic calibration of sensors/cameras. Signed-off-by: Ricardo Ribalda Delgad

[PATCH v3 6/7] Documentation: Document v4l2_ctrl_new area

2019-08-23 Thread Ricardo Ribalda Delgado
Helper for creating area controls. Signed-off-by: Ricardo Ribalda Delgado --- Documentation/media/kapi/v4l2-controls.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/media/kapi/v4l2-controls.rst b/Documentation/media/kapi/v4l2-controls.rst index ebe2a55908be..656e9

[PATCH v3 3/7] Documentation: media: Document V4L2_CTRL_TYPE_AREA

2019-08-23 Thread Ricardo Ribalda Delgado
A struct v4l2_area containing the width and the height of a rectangular area. Signed-off-by: Ricardo Ribalda Delgado Suggested-by: Hans Verkuil --- Documentation/media/uapi/v4l/vidioc-queryctrl.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/media/uapi/v4l/vidioc-que

[PATCH v3 4/7] media: imx214: Add new control with V4L2_CID_UNIT_CELL_SIZE

2019-08-23 Thread Ricardo Ribalda Delgado
According to the product brief, the unit cell size is 1120 nanometers^2. https://www.sony-semicon.co.jp/products_en/IS/sensor1/img/products/ProductBrief_IMX214_20150428.pdf Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/i2c/imx214.c | 23 +++ 1 file changed, 23 ins

[PATCH v3 5/7] media: v4l2-core: Add new helper for area controls

2019-08-23 Thread Ricardo Ribalda Delgado
Adding a V4L2_CID_UNIT_CELL_SIZE control requires a lot of boilerplate, try to minimize it by adding a new helper. Suggested-by: Philipp Zabel Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/v4l2-core/v4l2-ctrls.c | 25 - include/media/v4l2-ctrls.h | 1

[PATCH v3 7/7] imx214: Use v4l2_ctrl_new_area helper

2019-08-23 Thread Ricardo Ribalda Delgado
Instead of creating manually the V4L2_CID_UNIT_CELL_SIZE control, lets use the helper. Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/i2c/imx214.c | 29 - 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/drivers/media/i2c/imx214.c b/drivers/med

[PATCH v3 2/7] Documentation: media: Describe V4L2_CID_UNIT_CELL_SIZE

2019-08-23 Thread Ricardo Ribalda Delgado
New control to pass to userspace the width/height of a pixel. Which is needed for calibration and lens selection. Signed-off-by: Ricardo Ribalda Delgado --- Documentation/media/uapi/v4l/ext-ctrls-image-source.rst | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/media/uap

Re: [GIT PULL for 5.4] A10 CSI driver and atmel-isi fix

2019-08-23 Thread Maxime Ripard
Hi Hans, On Fri, Aug 23, 2019 at 01:55:07PM +0200, Hans Verkuil wrote: > Hi Maxime, > > On 8/23/19 9:31 AM, Sakari Ailus wrote: > > Hi Mauro, > > > > Here's a driver for A10 CSI parallel receiver and a fix for atmel-isi. > > > > There are three checkpatch.pl warnings; two on Makefile / Kconfig on

[PATCH] media: sun4i: Make sun4i_csi_formats static

2019-08-23 Thread Maxime Ripard
From: Maxime Ripard The sun4i_csi_formats array is only used in sun4i_v4l2.c, so it doesn't make any sense to have it !static. Reported-by: Hans Verkuil Signed-off-by: Maxime Ripard --- drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCHv10 0/2] cec: add the connector info API

2019-08-23 Thread Hans Verkuil
These two patches add the CEC connector info API. Note that connector info is currently for drm connectors only. In the future support for v4l2 connectors will be added as well, once we actually know how to uniquely identify a HDMI receiver connector. Regards, Hans Dariusz Marcinkiewicz

[PATCHv10 1/2] cec: expose the new connector info API

2019-08-23 Thread Hans Verkuil
From: Dariusz Marcinkiewicz Until now the connector info API was a kernel-internal API only. This moves it to the public API and adds the new ioctl to retrieve this information. Signed-off-by: Dariusz Marcinkiewicz Signed-off-by: Hans Verkuil --- drivers/media/cec/cec-adap.c | 2 ++ drivers/

[PATCHv10 2/2] cec: document CEC_ADAP_G_CONNECTOR_INFO and capability

2019-08-23 Thread Hans Verkuil
Document the new CEC_ADAP_G_CONNECTOR_INFO ioctl and the new CEC_CAP_CONNECTOR_INFO capability. Signed-off-by: Dariusz Marcinkiewicz Co-developed-by: Hans Verkuil [hverkuil-ci...@xs4all.nl: added CEC_CAP_CONNECTOR_INFO] [hverkuil-ci...@xs4all.nl: added DQEVENT have_conn_info] Signed-off-by: Hans

Re: [GIT PULL FOR v5.4] Add imx csc/scaler mem2mem device

2019-08-23 Thread Jenkins
From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/58391/ Build log: https://builder.linuxtv.org/job/patchwork/12922/ Build time: 00:02:14 Link: https://lore.kernel.org/linux-media/9d0cbecd-02dc-3d58-6342-3fb091e9d...@xs4all.nl gpg: Signature made Fri 23 Aug 2019 12:00:2

Re: [PATCH v2 5/7] media: use the BIT() macro

2019-08-23 Thread Benoit Parrot
Mauro Carvalho Chehab wrote on Fri [2019-Aug-23 06:47:30 -0300]: > As warned by cppcheck: > > [drivers/media/dvb-frontends/cx24123.c:434]: (error) Shifting signed > 32-bit value by 31 bits is undefined behaviour > [drivers/media/pci/bt8xx/bttv-input.c:87]: (error) Shifting signed >

[GIT PULL FOR v5.4] Add imx csc/scaler mem2mem device

2019-08-23 Thread Hans Verkuil
The following changes since commit 577bbf23b758848f0c4a50d346460b690c753024: media: sunxi: Add A10 CSI driver (2019-08-23 07:31:35 -0300) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.4n for you to fetch changes up to ba443b4dd9e15ffefba9d8aa07

Re: [GIT PULL for 5.4] A10 CSI driver and atmel-isi fix

2019-08-23 Thread Hans Verkuil
Hi Maxime, On 8/23/19 9:31 AM, Sakari Ailus wrote: > Hi Mauro, > > Here's a driver for A10 CSI parallel receiver and a fix for atmel-isi. > > There are three checkpatch.pl warnings; two on Makefile / Kconfig on > MAINTAINERS (i.e. not worth mentioning in MAINTAINERS) while the third is > on a sp

[PATCH] media: rc: increase rc-mm tolerance and add debug message

2019-08-23 Thread Sean Young
Decoding often fails on e.g. redrat3 devices. The dev_dbg() helps with debugging when decoding does fail. Cc: Patrick Lerda Signed-off-by: Sean Young --- drivers/media/rc/ir-rcmm-decoder.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/rc/ir-rcmm-decoder

[PATCH 3/3] drm/bridge/adv7511: enable CEC connector info

2019-08-23 Thread Hans Verkuil
Set the connector info to help userspace associate the CEC adapter with the HDMI connector. This required that the cec initialization and unregistering the CEC adapter takes place in the bridge attach and detach ops. Tested on an R-Car Koelsch board. Signed-off-by: Hans Verkuil Tested-by: Hans

[PATCH 2/3] drm/sun4i/sun4i_hdmi_enc: call cec_s_conn_info()

2019-08-23 Thread Hans Verkuil
Set the connector info for the CEC adapter. This helps userspace to associate the CEC device with the HDMI connector. Tested on a Cubieboard. Signed-off-by: Hans Verkuil Tested-by: Hans Verkuil --- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(

[PATCH 0/3] drm: cec: call cec_s_conn_info()

2019-08-23 Thread Hans Verkuil
Three drivers were not updated in Dariusz' series: https://patchwork.linuxtv.org/project/linux-media/list/?series=573 This series adds connector info support for those three. Note that the sun4i patch has this patch as a prerequisite: https://patchwork.linuxtv.org/project/linux-media/list/?seri

[PATCH 1/3] drm/vc4/vc4_hdmi: fill in connector info

2019-08-23 Thread Hans Verkuil
From: Dariusz Marcinkiewicz Fill in the connector info, allowing userspace to associate the CEC device with the drm connector. Tested on a Raspberry Pi 3B. Signed-off-by: Dariusz Marcinkiewicz Signed-off-by: Hans Verkuil Tested-by: Hans Verkuil --- drivers/gpu/drm/vc4/vc4_hdmi.c | 13 ++

[PATCH for v5.3] cec-notifier: clear cec_adap in cec_notifier_unregister

2019-08-23 Thread Hans Verkuil
If cec_notifier_cec_adap_unregister() is called before cec_unregister_adapter() then everything is OK (and this is the case today). But if it is the other way around, then cec_notifier_unregister() is called first, and that doesn't set n->cec_adap to NULL. So if e.g. cec_notifier_set_phys_addr() i

Re: [PATCH 6/7] media: don't do an unsigned int with a 31 bit shift

2019-08-23 Thread Marc Gonzalez
Full disclosure, I enjoy playing "C standard language lawyer" in my spare time. Feel free to ignore me if it gets boring ;-) https://port70.net/~nsz/c/ On 23/08/2019 12:20, Mauro Carvalho Chehab wrote: > Marc Gonzalez escreveu: > >> On 22/08/2019 21:39, Mauro Carvalho Chehab wrote: >>

[PATCH for v5.3] cec-adap: return from cec_s_conn_info() if adap is invalid

2019-08-23 Thread Hans Verkuil
Check if cec_s_conn_info is called with a valid cec adapter, do nothing if it is invalid. This makes it possible to call this function even if CEC support is disabled in the kernel config. Signed-off-by: Hans Verkuil --- drivers/media/cec/cec-adap.c | 3 +++ 1 file changed, 3 insertions(+) dif

Re: [PATCH 4/7] media: ov9650: add a sanity check

2019-08-23 Thread Sylwester Nawrocki
On 8/22/19 21:39, Mauro Carvalho Chehab wrote: > As pointed by cppcheck: > > [drivers/media/i2c/ov9650.c:706]: (error) Shifting by a negative value > is undefined behaviour > [drivers/media/i2c/ov9650.c:707]: (error) Shifting by a negative value > is undefined behaviour > [driv

Re: [PATCH v2 5/7] media: use the BIT() macro

2019-08-23 Thread Sylwester Nawrocki
On 8/23/19 11:47, Mauro Carvalho Chehab wrote: > There are lots of places where we're doing 1 << 31. That's bad, > as, depending on the architecture, this has an undefined behavior. > > The BIT() macro is already prepared to handle this, so, let's > just switch all "1 << number" macros by BIT(numb

Re: [PATCH 6/7] media: don't do an unsigned int with a 31 bit shift

2019-08-23 Thread Mauro Carvalho Chehab
Em Fri, 23 Aug 2019 11:08:15 +0200 Marc Gonzalez escreveu: > On 22/08/2019 21:39, Mauro Carvalho Chehab wrote: > > > [PATCH 6/7] media: don't do an unsigned int with a 31 bit shift > > s/unsigned int/signed int ? > > (See below as well.) > > > Doing something like: > > > > i32 foo = 1

Re: [V1, 2/2] media: i2c: Add more sensor mode for ov8856 camera sensor

2019-08-23 Thread Tomasz Figa
Hi Dongchun, On Thu, Aug 08, 2019 at 05:22:15PM +0800, dongchun@mediatek.com wrote: > From: Dongchun Zhu > > This patch mainly adds two more sensor modes for OV8856 image sensor. > The OV8856 driver currently supports output format: 10-bit Raw, > the resolution of 1632*1224 and 3264*2448, an

[PATCH v2 5/7] media: use the BIT() macro

2019-08-23 Thread Mauro Carvalho Chehab
As warned by cppcheck: [drivers/media/dvb-frontends/cx24123.c:434]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour [drivers/media/pci/bt8xx/bttv-input.c:87]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour [drivers/media/pci/

Re: [PATCH 6/7] media: don't do an unsigned int with a 31 bit shift

2019-08-23 Thread Marc Gonzalez
On 22/08/2019 21:39, Mauro Carvalho Chehab wrote: > [PATCH 6/7] media: don't do an unsigned int with a 31 bit shift s/unsigned int/signed int ? (See below as well.) > Doing something like: > > i32 foo = 1, bar; > > bar = foo << 31; For my information, why did you split the expre

Re: [PATCH 2/2] media: i2c: dw9768: Add DW9768 VCM driver

2019-08-23 Thread Tomasz Figa
Hi Dongchun, On Mon, Jul 08, 2019 at 06:06:41PM +0800, dongchun@mediatek.com wrote: > From: Dongchun Zhu > > This patch adds a V4L2 sub-device driver for DW9768 lens voice coil, > and provides control to set the desired focus. > > The DW9807 is a 10 bit DAC from Dongwoon, designed for linea

Re: [PATCH v8 0/5] media: Allwinner A10 CSI support

2019-08-23 Thread Maxime Ripard
On Thu, Aug 22, 2019 at 10:21:11AM +0200, Maxime Ripard wrote: > From: Maxime Ripard > > Hi, > > Here is a series introducing the support for the A10 (and SoCs of the same > generation) CMOS Sensor Interface (called CSI, not to be confused with > MIPI-CSI, which isn't support by that IP). > > That

Re: [GIT PULL for 5.4] A10 CSI driver and atmel-isi fix

2019-08-23 Thread Jenkins
From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/58382/ Build log: https://builder.linuxtv.org/job/patchwork/12895/ Build time: 00:04:55 Link: https://lore.kernel.org/linux-media/20190823073109.gr3...@valkosipuli.retiisi.org.uk gpg: Signature made Fri 23 Aug 2019 07:25

[GIT PULL for 5.4] A10 CSI driver and atmel-isi fix

2019-08-23 Thread Sakari Ailus
Hi Mauro, Here's a driver for A10 CSI parallel receiver and a fix for atmel-isi. There are three checkpatch.pl warnings; two on Makefile / Kconfig on MAINTAINERS (i.e. not worth mentioning in MAINTAINERS) while the third is on a spinlock missing a comment. If you'd like the last one to be address