Re: [PATCH] gl861: re-implement i2c adapter logic

2019-08-21 Thread Antti Palosaari
On 8/22/19 8:34 AM, Antti Palosaari wrote: Device I2C adapter is capable of writing and reading large messages. For I2C writes there is 2 methods: simple for max 2 byte messages and usb_control_msg() with payload data for larger I2C messages. Add I2C adapter logic which selects suitable method ac

[PATCH] gl861: re-implement i2c adapter logic

2019-08-21 Thread Antti Palosaari
Device I2C adapter is capable of writing and reading large messages. For I2C writes there is 2 methods: simple for max 2 byte messages and usb_control_msg() with payload data for larger I2C messages. Add I2C adapter logic which selects suitable method according to message size. Cc: Akihiro TSUKADA

Re: [PATCH] dvb-usb-v2/gl861: fix wrong memcpy

2019-08-21 Thread Antti Palosaari
On 8/22/19 5:00 AM, Akihiro TSUKADA wrote: Hi, I suspect all whole friio_reset() function is not needed as it has worked even I/O has been broken. It worked because the old driver (that I rmmod'ed before installing the testing driver) properly init'ed the device. If I re-plug it (or reboot

cron job: media_tree daily build: ERRORS

2019-08-21 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Aug 22 05:00:10 CEST 2019 media-tree git hash:01faced6f65d0224bf6ce1262a4137771e28519f media_build gi

Re: [PATCH] dvb-usb-v2/gl861: fix wrong memcpy

2019-08-21 Thread Akihiro TSUKADA
Hi, > I suspect all whole friio_reset() function is not needed as it has > worked even I/O has been broken. It worked because the old driver (that I rmmod'ed before installing the testing driver) properly init'ed the device. If I re-plug it (or reboot), it does not work. So it is needed. > Also

Re: [PATCH] dvb-usb-v2/gl861: fix wrong memcpy

2019-08-21 Thread Antti Palosaari
On 8/17/19 4:22 PM, Akihiro TSUKADA wrote: Could you please test the patch and check if the return results are now consistent and that it won't break anything? I have tested the patch and it worked without problems. Testd-by: Akihiro Tsukada I could not noticed the bug because the device w

Re: [RFC,v4,1/4] media: dt-bindings: mt8183: Added camera ISP Pass 1

2019-08-21 Thread Rob Herring
On Wed, Aug 07, 2019 at 08:48:00PM +0800, Jungo Lin wrote: > This patch adds DT binding document for the Pass 1 (P1) unit > in Mediatek's camera ISP system. The Pass 1 unit grabs the sensor > data out from the sensor interface, applies ISP image effects > from tuning data and outputs the image data

Re: [RFC,v4,1/4] media: dt-bindings: mt8183: Added camera ISP Pass 1

2019-08-21 Thread Rob Herring
On Wed, Aug 07, 2019 at 08:48:00PM +0800, Jungo Lin wrote: > This patch adds DT binding document for the Pass 1 (P1) unit > in Mediatek's camera ISP system. The Pass 1 unit grabs the sensor > data out from the sensor interface, applies ISP image effects > from tuning data and outputs the image data

Re: [GIT PULL FOR v5.4] More DVB/RC changes

2019-08-21 Thread Jenkins
From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/58337/ Build log: https://builder.linuxtv.org/job/patchwork/12670/ Build time: 00:10:31 Link: https://lore.kernel.org/linux-media/20190821130434.gh4drkm6tiawz...@gofer.mess.org gpg: Signature made Wed 21 Aug 2019 12:58:5

Re: [GIT PULL FOR v5.4] More DVB/RC changes

2019-08-21 Thread Mauro Carvalho Chehab
Em Wed, 21 Aug 2019 14:59:05 -0300 Mauro Carvalho Chehab escreveu: > Em Wed, 21 Aug 2019 17:43:27 + > Jenkins escreveu: > > > From: buil...@linuxtv.org > > > > Pull request: https://patchwork.linuxtv.org/patch/58337/ > > Build log: https://builder.linuxtv.org/job/patchwork/12664/ > > Build

Re: [GIT PULL FOR v5.4] More DVB/RC changes

2019-08-21 Thread Jenkins
From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/58337/ Build log: https://builder.linuxtv.org/job/patchwork/12667/ Build time: 00:00:00 Link: https://lore.kernel.org/linux-media/20190821130434.gh4drkm6tiawz...@gofer.mess.org gpg: Signature made Wed 21 Aug 2019 12:58:5

Re: [GIT PULL FOR v5.4] More DVB/RC changes

2019-08-21 Thread Mauro Carvalho Chehab
Em Wed, 21 Aug 2019 17:43:27 + Jenkins escreveu: > From: buil...@linuxtv.org > > Pull request: https://patchwork.linuxtv.org/patch/58337/ > Build log: https://builder.linuxtv.org/job/patchwork/12664/ > Build time: 00:00:00 > Link: > https://lore.kernel.org/linux-media/20190821130434.gh4drkm

Re: [GIT PULL FOR v5.4] More DVB/RC changes

2019-08-21 Thread Jenkins
From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/58337/ Build log: https://builder.linuxtv.org/job/patchwork/12664/ Build time: 00:00:00 Link: https://lore.kernel.org/linux-media/20190821130434.gh4drkm6tiawz...@gofer.mess.org gpg: Signature made Wed 21 Aug 2019 12:58:5

Re: [GIT PULL FOR v5.4] More DVB/RC changes

2019-08-21 Thread Mauro Carvalho Chehab
Em Wed, 21 Aug 2019 14:28:16 +0100 Sean Young escreveu: > On Wed, Aug 21, 2019 at 01:16:59PM +, Jenkins wrote: > > From: buil...@linuxtv.org > > > > Pull request: https://patchwork.linuxtv.org/patch/58337/ > > Build log: https://builder.linuxtv.org/job/patchwork/12637/ > > Build time: 00:00:

Re: [PATCH v2] media: ov5640: add support of V4L2_CID_LINK_FREQ

2019-08-21 Thread Jacopo Mondi
Hello, +laura who has been working on supporting RAW capture for this driver. On Tue, Aug 20, 2019 at 12:13:12PM +0300, Sakari Ailus wrote: > Hi Hugues, > > On Tue, Jul 02, 2019 at 04:05:46PM +, Hugues FRUCHET wrote: > > Hi Sakari, > > > > On 6/27/19 6:05 PM, Sakari Ailus wrote: > > > Hi

Re: [GIT PULL FOR v5.4] More DVB/RC changes

2019-08-21 Thread Sean Young
On Wed, Aug 21, 2019 at 01:16:59PM +, Jenkins wrote: > From: buil...@linuxtv.org > > Pull request: https://patchwork.linuxtv.org/patch/58337/ > Build log: https://builder.linuxtv.org/job/patchwork/12637/ > Build time: 00:00:00 > Link: > https://lore.kernel.org/linux-media/20190821130434.gh4dr

Re: [GIT PULL FOR v5.4] More DVB/RC changes

2019-08-21 Thread Jenkins
From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/58337/ Build log: https://builder.linuxtv.org/job/patchwork/12637/ Build time: 00:00:00 Link: https://lore.kernel.org/linux-media/20190821130434.gh4drkm6tiawz...@gofer.mess.org FAILED: patch patch patches/0009-dt-bindin

[GIT PULL FOR v5.4] More DVB/RC changes

2019-08-21 Thread Sean Young
Hi Mauro, This moves the MyGica T230 to dvbsky, like was previously done for the T230C model. Other than that some minor fixes and device tree update to yaml. Thanks Sean The following changes since commit d4e0f82ac840bf3d16b25d60f261b429603138a9: media: pixfmt-compressed.rst: improve H264/HE

Re: [PATCH] dvb: usb: fix use after free in dvb_usb_device_exit

2019-08-21 Thread Ben Hutchings
On Wed, 2019-08-21 at 10:18 +0200, Oliver Neukum wrote: > Am Dienstag, den 20.08.2019, 19:55 +0100 schrieb Ben Hutchings: > > On Tue, 2019-04-30 at 15:07 +0200, Oliver Neukum wrote: > > > dvb_usb_device_exit() frees and uses the device name in that order > > > Fix by storing the name in a buffer be

Re: [V3, 2/2] media: i2c: Add Omnivision OV02A10 camera sensor driver

2019-08-21 Thread Sakari Ailus
Hi Tomasz, On Wed, Aug 21, 2019 at 07:30:38PM +0900, Tomasz Figa wrote: ... > > + > > +/* > > + * xvclk 24Mhz > > This seems to assume 24MHz, but the driver allows a range in probe. Is that > correct? I think it'd be better to check for an exact frequency: this is board specific and its exact va

Re: [V3, 2/2] media: i2c: Add Omnivision OV02A10 camera sensor driver

2019-08-21 Thread Tomasz Figa
Hi Dongchun, On Mon, Aug 19, 2019 at 11:43:31AM +0800, dongchun@mediatek.com wrote: > From: Dongchun Zhu > > This patch adds a V4L2 sub-device driver for OV02A10 image sensor. > The OV02A10 is a 1/5" CMOS sensor from Omnivision, > which supports output format: 10-bit Raw. > The OV02A10 has a

Re: [PATCH] dt-bindings: sh-mobile-ceu: Rename bindings documentation file

2019-08-21 Thread Jacopo Mondi
Hi Simon, On Wed, Aug 21, 2019 at 10:17:48AM +0200, Simon Horman wrote: > On Tue, Aug 20, 2019 at 05:19:30PM +0200, Simon Horman wrote: > > On Tue, Aug 20, 2019 at 11:52:05AM +0200, Jacopo Mondi wrote: > > > Hi Simon, > > > > > > On Mon, Aug 19, 2019 at 04:05:44PM +0200, Simon Horman wrote: > > >

Re: [PATCH] dvb: usb: fix use after free in dvb_usb_device_exit

2019-08-21 Thread Oliver Neukum
Am Dienstag, den 20.08.2019, 19:55 +0100 schrieb Ben Hutchings: > On Tue, 2019-04-30 at 15:07 +0200, Oliver Neukum wrote: > > dvb_usb_device_exit() frees and uses the device name in that order > > Fix by storing the name in a buffer before freeing it > > > > v2: fixed style issues > > v3: strscpy

Re: [PATCH 3/4] pxa-camera: Match with device node, not the port node

2019-08-21 Thread Sakari Ailus
Hi Robert, On Wed, Aug 21, 2019 at 09:26:59AM +0200, Robert Jarzmik wrote: > Sakari Ailus writes: > > > V4L2 fwnode matching right now still works based on device nodes, not port > > nodes. Fix this. > Mmmh why does it need a fix, and what's wrong on device node matching ? This > commit message

Re: [PATCH] dt-bindings: sh-mobile-ceu: Rename bindings documentation file

2019-08-21 Thread Simon Horman
On Tue, Aug 20, 2019 at 05:19:30PM +0200, Simon Horman wrote: > On Tue, Aug 20, 2019 at 11:52:05AM +0200, Jacopo Mondi wrote: > > Hi Simon, > > > > On Mon, Aug 19, 2019 at 04:05:44PM +0200, Simon Horman wrote: > > > Renesas media binding documentation files uses a naming schema of > > > 'renesas,.

Re: [PATCH] media: video-i2c: add mlx90640 subpage data to output

2019-08-21 Thread Hans Verkuil
On 8/21/19 7:59 AM, Matt Ranostay wrote: > On Mon, Aug 12, 2019 at 6:05 AM Hans Verkuil wrote: >> >> Hi Matt, >> >> On 8/11/19 9:10 AM, Matt Ranostay wrote: >>> Add current subpage data via the status register to the video >>> frame in the last word of data, which seems to be unused >>> undocument

[PATCH v8 06/13] media: dt-bindings: tvp5150: Add input port connectors DT bindings

2019-08-21 Thread Marco Felsch
The TVP5150/1 decoders support different video input sources to their AIP1A/B pins. Possible configurations are as follows: - Analog Composite signal connected to AIP1A. - Analog Composite signal connected to AIP1B. - Analog S-Video Y (luminance) and C (chrominance) signals connected to

[PATCH v8 00/13] Add TVP5150 features

2019-08-21 Thread Marco Felsch
Hi, the main purpose of this v8 is: - fix rebasing issue I made on the v7 - fix error handling for tvp5150_registered() - fix FORMAT_TRY patch so only set/get_selection is modified - change the tvnorms to sdtv-standards - some more minor fixes Many thanks to Hans for the quick response made

[PATCH v8 09/13] media: tvp5150: add s_power callback

2019-08-21 Thread Marco Felsch
Don't en-/disable the interrupts during s_stream because someone can disable the stream but wants to get informed if the stream is locked again. So keep the interrupts enabled the whole time the pipeline is opened. Signed-off-by: Marco Felsch --- drivers/media/i2c/tvp5150.c | 23

[PATCH v8 02/13] media: v4l2-fwnode: add v4l2_fwnode_connector

2019-08-21 Thread Marco Felsch
Currently every driver needs to parse the connector endpoints by it self. This is the initial work to make this generic. A generic connector has common members and connector specific members. The common members are: - type - label (optional) - links - nr_of_links The specific members are s

[PATCH v8 03/13] media: v4l2-fwnode: add initial connector parsing support

2019-08-21 Thread Marco Felsch
The patch adds the initial connector parsing code, so we can move from a driver specific parsing code to a generic one. Currently only the generic fields and the analog-connector specific fields are parsed. Parsing the other connector specific fields can be added by a simple callbacks. Signed-off-

[PATCH v8 01/13] dt-bindings: connector: analog: add sdtv standards property

2019-08-21 Thread Marco Felsch
Some connectors no matter if in- or output supports only a limited range of sdtv standards. It doesn't matter if the hardware behind that connector supports more than the listed formats since the users are restriced by a label e.g. to plug only a camera into this connector which uses the PAL format

[PATCH v8 13/13] media: tvp5150: make debug output more readable

2019-08-21 Thread Marco Felsch
The debug output for tvp5150_selmux() isn't really intuitive. Register values are printed decimal formatted and the input/output driver states are printed as enum. Even more the "normal" output enum mapps to zero so a active output will printing output=0 and a inactive output=1. Change this by bri

[PATCH v8 10/13] media: dt-bindings: tvp5150: cleanup bindings stlye

2019-08-21 Thread Marco Felsch
Use underlines to highlight optional and required properties. This is quite common for all bindings. Align descriptions and start sentence with uppercase letter. Also reword the usage of the required endpoint properties for the output port in case BT.656 should be used. Signed-off-by: Marco Felsch

[PATCH v8 07/13] media: tvp5150: add FORMAT_TRY support for get/set selection handlers

2019-08-21 Thread Marco Felsch
Since commit 10d5509c8d50 ("[media] v4l2: remove g/s_crop from video ops") the 'which' field for set/get_selection must be FORMAT_ACTIVE. There is no way to try different selections. The patch adds a helper function to select the correct selection memory space (sub-device file handle or driver stat

[PATCH v8 08/13] media: tvp5150: initialize subdev before parsing device tree

2019-08-21 Thread Marco Felsch
From: Michael Tretter There are several debug prints in the tvp5150_parse_dt() function, which do not print the prefix, because the v4l2_subdev is not initialized, yet. Initialize the v4l2_subdev before parsing the device tree to fix the debug messages. Signed-off-by: Michael Tretter Signed-of

[PATCH v8 12/13] media: tvp5150: add support to limit sdtv standards

2019-08-21 Thread Marco Felsch
The tvp5150 accepts NTSC(M,J,4.43), PAL (B,D,G,H,I,M,N) and SECAM video data and is able to auto-detect the input signal. The auto-detection does not work if the connector does not receive an input signal and the tvp5150 might not be configured correctly. This misconfiguration leads into wrong deco

[PATCH v8 11/13] media: dt-bindings: tvp5150: add optional sdtv standards documentation

2019-08-21 Thread Marco Felsch
Document the optional binding to limit the possible sdtv standards on the input connectors. Signed-off-by: Marco Felsch Reviewed-by: Rob Herring --- v8: - adapt to new sdtv-standards - adapt commit message - fix missing include within example code .../devicetree/bindings/media/i2c/tvp5150.txt

[PATCH v8 05/13] media: tvp5150: add input source selection of_graph support

2019-08-21 Thread Marco Felsch
This patch adds the of_graph support to describe the tvp input connections. Physical the TVP5150 has three ports: AIP1A, AIP1B and YOUT. As result of discussion [1],[2] the device-tree maps these ports 1:1. Look at the Documentation for more information. Since the TVP5150 is a converter/bridge the

[PATCH v8 04/13] partial revert of "[media] tvp5150: add HW input connectors support"

2019-08-21 Thread Marco Felsch
From: Javier Martinez Canillas Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support") added input signals support for the tvp5150, but the approach was found to be incorrect so the corresponding DT binding commit 82c2ffeb217a ("[media] tvp5150: document input connectors DT bindi

Re: [PATCH 3/4] pxa-camera: Match with device node, not the port node

2019-08-21 Thread Robert Jarzmik
Sakari Ailus writes: > V4L2 fwnode matching right now still works based on device nodes, not port > nodes. Fix this. Mmmh why does it need a fix, and what's wrong on device node matching ? This commit message is a bit too brief for me to understand why a fix is needed. Moreover, does it have an