Re: [PATCH v6 01/13] dt-bindings: connector: analog: add tv norms property

2019-08-08 Thread Marco Felsch
Hi Mauro, Hans, thanks for the review. On 19-05-14 15:11, Mauro Carvalho Chehab wrote: > Em Mon, 6 May 2019 12:01:06 +0200 > Hans Verkuil escreveu: > > > On 4/15/19 2:44 PM, Marco Felsch wrote: > > > Some connectors no matter if in- or output supports only a limited > > > range of tv norms. It

Re: [PATCH v6 01/13] dt-bindings: connector: analog: add tv norms property

2019-08-08 Thread Marco Felsch
Hi Laurent, On 19-05-16 19:27, Laurent Pinchart wrote: > Hi Marco, > > Thank you for the patch. > > On Mon, Apr 15, 2019 at 02:44:01PM +0200, Marco Felsch wrote: > > Some connectors no matter if in- or output supports only a limited > > range of tv norms. It doesn't matter if the hardware behind

Re: [PATCH v6 08/13] media: tvp5150: initialize subdev before parsing device tree

2019-08-08 Thread Marco Felsch
Hi Mauro, On 19-05-14 17:20, Mauro Carvalho Chehab wrote: > Em Mon, 15 Apr 2019 14:44:08 +0200 > Marco Felsch escreveu: > > > From: Michael Tretter > > > > There are several debug prints in the tvp5150_parse_dt() function, which > > do not print the prefix, because the v4l2_subdev is not initi

Re: [PATCH v6 13/13] media: tvp5150: make debug output more readable

2019-08-08 Thread Marco Felsch
Hi Mauro, On 19-05-14 17:18, Mauro Carvalho Chehab wrote: > Em Mon, 6 May 2019 15:39:05 +0200 > Jacopo Mondi escreveu: > > > Hi Marco, > > thanks > > > > Reviewed-by: Jacopo Mondi > > Looks ok to me too. Same here, can I add your Reviewed-by tag too? Regards, Marco > > > > On Mon, Apr

Re: [PATCH v6 09/13] media: tvp5150: add s_power callback

2019-08-08 Thread Marco Felsch
Hi Mauro, On 19-05-14 17:13, Mauro Carvalho Chehab wrote: > Em Mon, 15 Apr 2019 14:44:09 +0200 > Marco Felsch escreveu: > > > Don't en-/disable the interrupts during s_stream because someone can > > disable the stream but wants to get informed if the stream is locked > > again. So keep the inter

Re: [PATCH v6 07/13] media: tvp5150: add FORMAT_TRY support for get/set selection handlers

2019-08-08 Thread Marco Felsch
Hi Mauro, On 19-05-14 15:48, Mauro Carvalho Chehab wrote: > Em Mon, 15 Apr 2019 14:44:07 +0200 > Marco Felsch escreveu: > > > Since commit 10d5509c8d50 ("[media] v4l2: remove g/s_crop from video ops") > > the 'which' field for set/get_selection must be FORMAT_ACTIVE. There is > > no way to try d

Re: [PATCH v6 07/13] media: tvp5150: add FORMAT_TRY support for get/set selection handlers

2019-08-08 Thread Marco Felsch
Hi Jacopo, On 19-05-06 15:36, Jacopo Mondi wrote: > Hi Marco, Sorry for the long time absence of this topic... > On Mon, Apr 15, 2019 at 02:44:07PM +0200, Marco Felsch wrote: > > Since commit 10d5509c8d50 ("[media] v4l2: remove g/s_crop from video ops") > > the 'which' field for set/get_selectio

[PATCH 0/2] max9286: Add MAX9286 driver with single camera support

2019-08-08 Thread Niklas Söderlund
Hi, This series adds a driver for the Maxim MAX9286 Integrated Quad GMSL Deserializer. This submission is the sum of work done by Jacopo, Kieran, Laurent and me over the last two (?) years. Our initial submission supported usage of up to 4 GMSL cameras attached to one MAX9286. That submission

[PATCH 1/2] dt-bindings: media: i2c: Add bindings for Maxim Integrated MAX9286

2019-08-08 Thread Niklas Söderlund
From: Laurent Pinchart The MAX9286 deserializes video data received on up to 4 Gigabit Multimedia Serial Links (GMSL) and outputs them on a CSI-2 port using up to 4 data lanes. Signed-off-by: Laurent Pinchart Signed-off-by: Jacopo Mondi Signed-off-by: Kieran Bingham Reviewed-by: Niklas Söderl

[PATCH 2/2] max9286: Add MAX9286 driver

2019-08-08 Thread Niklas Söderlund
The MAX9286 is a 4-channel GMSL deserializer with coax or STP input and CSI-2 output. The device supports multicamera streaming applications, and features the ability to synchronise the attached cameras. The driver however limits the number of cameras to one as there are no way to express in V4L2 t

Re: [PATCH] v4l2-compliance: split node at testNode() in two nodes

2019-08-08 Thread André Almeida
On 8/8/19 10:02 PM, André Almeida wrote: > v4l2-compliance tests deals with memory-to-memory devices (m2m) like > they are a single device, through the struct node. This is indeed the > most usual case. However, there are m2m devices that have two > separated devices for the capture queue and for t

[PATCH] v4l2-compliance: split node at testNode() in two nodes

2019-08-08 Thread André Almeida
v4l2-compliance tests deals with memory-to-memory devices (m2m) like they are a single device, through the struct node. This is indeed the most usual case. However, there are m2m devices that have two separated devices for the capture queue and for the output queue, and the current design does not

[ragnatech:media-tree] BUILD SUCCESS 97299a3035328d7ae2f4fccaf6e549974df6e118

2019-08-08 Thread kbuild test robot
tree/branch: git://git.ragnatech.se/linux media-tree branch HEAD: 97299a3035328d7ae2f4fccaf6e549974df6e118 media: Remove dev_err() usage after platform_get_irq() elapsed time: 1580m configs tested: 150 The following configs have been built successfully. More configs may be tested in the comin

try to edit channel in kaffeine 2.0.17 gives a crash

2019-08-08 Thread Peter Schlaf
Hello, right-click on certain channels in the dvb-channel list in kaffeine 2.0.17 and selecting "edit" crashes the program without opening the channel-editor. gdb output says: Thread 1 "kaffeine" received signal SIGSEGV, Segmentation fault. 0x555a78c6 in DvbChannelEditor::DvbChann

Re: [PATCH v5 7/9] drm: tegra: use cec_notifier_conn_(un)register

2019-08-08 Thread Hans Verkuil
On 8/7/19 10:52 AM, Dariusz Marcinkiewicz wrote: > Use the new cec_notifier_conn_(un)register() functions to > (un)register the notifier for the HDMI connector, and fill in > the cec_connector_info. > > Changes since v4: > - only create a CEC notifier for HDMI connectors > > Signed-off-by:

[PATCH v2 v4l-utils] keytable: add support for keymap with raw literals

2019-08-08 Thread Sean Young
These rc keymaps look like: [[protocols]] name = 'Beon_Colour_TV' protocol = 'raw' [[protocols.raw]] keycode = 'KEY_POWER' raw = [ 1324, 842, 6697, 26400, 1324, 842, 6697 ] [[protocols.raw]] keycode = 'KEY_MUTE' raw = [ 1305,

Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-08-08 Thread Steve Longerbeam
On 8/8/19 1:53 AM, Philipp Zabel wrote: Hi Sakari, On Thu, 2019-08-08 at 11:26 +0300, Sakari Ailus wrote: [...] Have you checked how it works if you simply leave out this test? Whether this works or not depends on the sensor used, and for some sensor/drivers may depend on timing (or random

Re: [V1, 1/2] media: dt-bindings: media: i2c: Add bindings for ov8856

2019-08-08 Thread Sakari Ailus
Hi Dongchun, (Cc'ing Ben, too.) On Thu, Aug 08, 2019 at 05:22:14PM +0800, dongchun@mediatek.com wrote: > From: Dongchun Zhu > > Add device tree binding documentation for the ov8856 camera sensor. > > Signed-off-by: Dongchun Zhu > --- > .../devicetree/bindings/media/i2c/ov8856.txt |

[PATCH v3] media: ir-kbd-i2c: convert to i2c_new_dummy_device()

2019-08-08 Thread Wolfram Sang
Convert this driver to use the new i2c_new_dummy_device() call and bail out if the dummy device cannot be registered to make failure more visible to the user. Signed-off-by: Wolfram Sang --- Change since v2: move away from devm per Mauro's suggestion Note: i2c_unregister_device() is NULL pointe

Re: [GIT PULL for v5.3-rc4] media fixes

2019-08-08 Thread Jenkins
From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/58037/ Build log: https://builder.linuxtv.org/job/patchwork/4527/ Build time: 00:04:25 Summary: 1 issues, being 0 build regressions Error/warnings: patches/0001-media-vivid-fix-missing-cec-adapter-name.patch:6: WARNING:

Re: [PATCH v5 9/9] drm: exynos: exynos_hdmi: use cec_notifier_conn_(un)register

2019-08-08 Thread Hans Verkuil
On 8/7/19 10:52 AM, Dariusz Marcinkiewicz wrote: > Use the new cec_notifier_conn_(un)register() functions to > (un)register the notifier for the HDMI connector, and fill in > the cec_connector_info. > > Changes since v2: > - removed unnecessary call to invalidate phys address before >

Kindly revert to me

2019-08-08 Thread Donald Williams
-- Attn: Your ATM Card of $2.8 Million is ready for shipment. Urgently reconfirm your Name, Delivery address and your direct phone number immediately for prompt action. Donald Williams Foreign Operations Director La Caixa Bank, Madrid

Re: [V1, 2/2] media: i2c: Add more sensor mode for ov8856 camera sensor

2019-08-08 Thread Sakari Ailus
Hi Dongchun, Thanks for the patch. On Thu, Aug 08, 2019 at 05:22:15PM +0800, dongchun@mediatek.com wrote: > From: Dongchun Zhu > > This patch mainly adds two more sensor modes for OV8856 image sensor. > The OV8856 driver currently supports output format: 10-bit Raw, > the resolution of 1632

Re: [PATCH v2 4/6] rcar-vin: Do not reset the crop and compose rectangles in s_fmt

2019-08-08 Thread Niklas Söderlund
Hi Laurent, Thanks for your feedback. On 2019-08-08 11:37:51 +0300, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Thu, Aug 08, 2019 at 03:18:48AM +0200, Niklas Söderlund wrote: > > The crop and compose rectangles are reset when s_fmt is called > > resulting in potenti

Re: [ANN] Media summit in Lisbon at September

2019-08-08 Thread Mauro Carvalho Chehab
Em Thu, 1 Aug 2019 09:34:00 -0300 Mauro Carvalho Chehab escreveu: > Em Sun, 30 Jun 2019 13:44:04 -0300 > Mauro Carvalho Chehab escreveu: > > > Hi all, > > > > We are organizing a media mini-summit in Lisbon to happen in September, > > at the same week as the Linux Plumber Conference and the Ke

Re: [PATCH v5 2/9] drm/i915/intel_hdmi: use cec_notifier_conn_(un)register

2019-08-08 Thread Hans Verkuil
On 8/7/19 10:52 AM, Dariusz Marcinkiewicz wrote: > Use the new cec_notifier_conn_(un)register() functions to > (un)register the notifier for the HDMI connector, and fill in > the cec_connector_info. > > Signed-off-by: Dariusz Marcinkiewicz > Signed-off-by: Hans Verkuil Tested-by: Hans Verkuil

[PATCH v3] media: i2c: ov5645: Fix power sequence

2019-08-08 Thread Ezequiel Garcia
This is mostly a port of Jacopo's fix: commit aa4bb8b8838ffcc776a79f49a4d7476b82405349 Author: Jacopo Mondi Date: Fri Jul 6 05:51:52 2018 -0400 media: ov5640: Re-work MIPI startup sequence In the OV5645 case, the changes are: - At set_power(1) time power up MIPI Tx/Rx and set data an

Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-08-08 Thread Sakari Ailus
Hi Philipp, On Thu, Aug 08, 2019 at 10:53:25AM +0200, Philipp Zabel wrote: > Hi Sakari, > > On Thu, 2019-08-08 at 11:26 +0300, Sakari Ailus wrote: > [...] > > > > Have you checked how it works if you simply leave out this test? > > Whether this works or not depends on the sensor used, and for so

[V1, 1/2] media: dt-bindings: media: i2c: Add bindings for ov8856

2019-08-08 Thread dongchun.zhu
From: Dongchun Zhu Add device tree binding documentation for the ov8856 camera sensor. Signed-off-by: Dongchun Zhu --- .../devicetree/bindings/media/i2c/ov8856.txt | 41 ++ MAINTAINERS| 1 + 2 files changed, 42 insertions(+) c

[V1, 2/2] media: i2c: Add more sensor mode for ov8856 camera sensor

2019-08-08 Thread dongchun.zhu
From: Dongchun Zhu This patch mainly adds two more sensor modes for OV8856 image sensor. The OV8856 driver currently supports output format: 10-bit Raw, the resolution of 1632*1224 and 3264*2448, and the bayer order of BGGR. The hardware version also differs in some OTP regiser, as well as PLL re

[V1, 0/2] media: ov8856: DT bindings and sensor mode improvements

2019-08-08 Thread dongchun.zhu
From: Dongchun Zhu Hello, This series adds DT bindings and some more sensor modes for users to use. >From the latest ov8856 datasheet, it is proposed to adopt the resolution of >1632*1224 and 3264*2448, together with Bayer Order of BGGR. Thus here we provide two more scenarios. In addition, t

Re: [PATCH v5 5/9] drm: tda998x: use cec_notifier_conn_(un)register

2019-08-08 Thread Hans Verkuil
On 8/7/19 10:52 AM, Dariusz Marcinkiewicz wrote: > Use the new cec_notifier_conn_(un)register() functions to > (un)register the notifier for the HDMI connector, and fill > in the cec_connector_info. > > Changes since v2: > - cec_notifier_phys_addr_invalidate where appropriate, > - don'

Re: [PATCH v5 4/9] tda9950: use cec_notifier_cec_adap_(un)register

2019-08-08 Thread Hans Verkuil
On 8/7/19 10:52 AM, Dariusz Marcinkiewicz wrote: > Use the new cec_notifier_cec_adap_(un)register() functions to > (un)register the notifier for the CEC adapter. > > Signed-off-by: Dariusz Marcinkiewicz > Signed-off-by: Hans Verkuil Tested-by: Hans Verkuil Tested with a BeagleBone Black board

Re: [PATCH] dt-bindings: rcar-imr: Rename bindings documentation file

2019-08-08 Thread Geert Uytterhoeven
On Mon, Jul 29, 2019 at 10:31 AM Geert Uytterhoeven wrote: > On Mon, Jul 29, 2019 at 9:48 AM Simon Horman > wrote: > > Renesas media binding documentation files uses a naming schema of > > use > > > 'renesas,.txt'. Rename IMR file to match this pattern. > > the IMR file? > > > > > Cc: Niklas Söd

Re: [PATCH v3] dt-bindings: rcar-{csi2,vin}: Rename bindings documentation files

2019-08-08 Thread Geert Uytterhoeven
Hi Niklas, On Thu, Aug 8, 2019 at 3:04 AM Niklas Söderlund wrote: > Renesas media binding documentation files uses a naming schema of > 'renesas,.txt'. Rename VIN and CSI-2 files to match this > pattern. > > Signed-off-by: Niklas Söderlund > Reviewed-by: Geert Uytterhoeven > Reviewed-by: Ulrich

Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-08-08 Thread Philipp Zabel
Hi Sakari, On Thu, 2019-08-08 at 11:26 +0300, Sakari Ailus wrote: [...] > > > Have you checked how it works if you simply leave out this test? Whether this works or not depends on the sensor used, and for some sensor/drivers may depend on timing (or random factors influencing it). See below. [..

Re: [PATCH v5 1/9] drm_dp_cec: add connector info support.

2019-08-08 Thread Hans Verkuil
On 8/7/19 10:52 AM, Dariusz Marcinkiewicz wrote: > Pass the connector info to the CEC adapter. This makes it possible > to associate the CEC adapter with the corresponding drm connector. > > Signed-off-by: Dariusz Marcinkiewicz > Signed-off-by: Hans Verkuil Tested-by: Hans Verkuil Tested with

Re: [PATCH v2 4/6] rcar-vin: Do not reset the crop and compose rectangles in s_fmt

2019-08-08 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Thu, Aug 08, 2019 at 03:18:48AM +0200, Niklas Söderlund wrote: > The crop and compose rectangles are reset when s_fmt is called > resulting in potentially valid rectangles being lost when updating the > format. Isn't this the expected behaviour ? > Fix thi

Re: [PATCH v2 3/6] rcar-vin: Rename rectangle holding the video source information

2019-08-08 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Thu, Aug 08, 2019 at 03:18:47AM +0200, Niklas Söderlund wrote: > The variable to hold the video source information dimensions was poorly > named 'source'. This is confusing as a lot of other members of structs > share the same name with different purposes, r

Re: [PATCH v2 2/6] rcar-vin: Make use of V4L2_FIELD_IS_INTERLACED() macro

2019-08-08 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Thu, Aug 08, 2019 at 03:18:46AM +0200, Niklas Söderlund wrote: > The V4L2_FIELD_IS_INTERLACED() can be used to make the code more > readable, use it. > > Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/rcar-

Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-08-08 Thread Sakari Ailus
Hi Ezequiel, On Wed, Aug 07, 2019 at 10:59:22AM -0300, Ezequiel Garcia wrote: > Hi Sakari, > > Thanks for reviewing the patch. > > On Wed, 2019-08-07 at 15:06 +0300, Sakari Ailus wrote: > > On Tue, Jul 30, 2019 at 05:14:24AM -0300, Ezequiel Garcia wrote: > > > Hey Hans, > > > > > > On Mon, 2019

Re: [PATCH v2 1/6] rcar-vin: Fix incorrect return statement in rvin_try_format()

2019-08-08 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Thu, Aug 08, 2019 at 03:18:45AM +0200, Niklas Söderlund wrote: > While refactoring code the return statement became corrupted, fix it by > returning the correct return code. > > Reported-by: Kieran Bingham > Fixes: 897e371389e77514 ("media: rcar-vin: simpl

Re: [PATCH v5 1/9] drm_dp_cec: add connector info support.

2019-08-08 Thread Hans Verkuil
Hi Dariusz, On 8/7/19 10:52 AM, Dariusz Marcinkiewicz wrote: > Pass the connector info to the CEC adapter. This makes it possible > to associate the CEC adapter with the corresponding drm connector. > > Signed-off-by: Dariusz Marcinkiewicz > Signed-off-by: Hans Verkuil > --- > .../display/amdg

Re: [PATCH] rcar-vin: Report correct image stride

2019-08-08 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Thu, Aug 08, 2019 at 07:10:58AM +0200, Niklas Söderlund wrote: > The image stride was adjusted when it was written to hardware and not > when configuring the format. Calculate the correct stride value and > report it to userspace. > > Signed-off-by: Niklas