[PATCH] rcar-vin: Report correct image stride

2019-08-07 Thread Niklas Söderlund
The image stride was adjusted when it was written to hardware and not when configuring the format. Calculate the correct stride value and report it to userspace. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-dma.c | 10 ++ drivers/media/platform/rcar-vin/rcar-

[PATCH v4l-utils] keytable: add support for keymap with raw literal strings

2019-08-07 Thread Sean Young
This adds support for converting lircd raw_codes remote definitions. This means that the vast majority of lircd files can be converted. This feature requires loops in BPF programs so this is only supported in kernel 5.3 onwards. Signed-off-by: Sean Young --- contrib/lircd2toml.py

cron job: media_tree daily build: ERRORS

2019-08-07 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Aug 8 05:00:13 CEST 2019 media-tree git hash:97299a3035328d7ae2f4fccaf6e549974df6e118 media_build gi

[PATCH v2 4/6] rcar-vin: Do not reset the crop and compose rectangles in s_fmt

2019-08-07 Thread Niklas Söderlund
The crop and compose rectangles are reset when s_fmt is called resulting in potentially valid rectangles being lost when updating the format. Fix this by mapping the rectangles inside the new format. Signed-off-by: Niklas Söderlund Reviewed-by: Kieran Bingham --- drivers/media/platform/rcar-vin

[PATCH v2 3/6] rcar-vin: Rename rectangle holding the video source information

2019-08-07 Thread Niklas Söderlund
The variable to hold the video source information dimensions was poorly named 'source'. This is confusing as a lot of other members of structs share the same name with different purposes, rename it src_rect in preparation of refactoring code. Signed-off-by: Niklas Söderlund Reviewed-by: Kieran Bi

[PATCH v2 0/6] rcar-vin: Add support for V4L2_FIELD_ALTERNATE

2019-08-07 Thread Niklas Söderlund
Hi, This series adds support for V4L2_FIELD_ALTERNATE to rcar-vin. This removes a limitation in the driver where a video sources delivering video using the alternating field format was forced to use the rcar-vin interlacer and V4L2_FIELD_INTERLACED was delivers to the user. After this series the u

[PATCH v2 1/6] rcar-vin: Fix incorrect return statement in rvin_try_format()

2019-08-07 Thread Niklas Söderlund
While refactoring code the return statement became corrupted, fix it by returning the correct return code. Reported-by: Kieran Bingham Fixes: 897e371389e77514 ("media: rcar-vin: simplify how formats are set and reset" Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-v4l

[PATCH v2 6/6] rcar-vin: Clean up how format is set on subdevice

2019-08-07 Thread Niklas Söderlund
With support for V4L2_FIELD_ALTERNATE added it's possible to clean up how formats are set on the subdevice. This makes the code easier to read as variable names now more clearly express their intent. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 42 ++-

[PATCH v2 5/6] rcar-vin: Add support for V4L2_FIELD_ALTERNATE

2019-08-07 Thread Niklas Söderlund
The hardware is capable to passing V4L2_FIELD_ALTERNATE to user-space. Allow users to request this field format but still default to using the hardware interlacer if alternating is not explicitly requested. Before this change a sensor providing data using alternate would be always combined to an i

[PATCH v2 2/6] rcar-vin: Make use of V4L2_FIELD_IS_INTERLACED() macro

2019-08-07 Thread Niklas Söderlund
The V4L2_FIELD_IS_INTERLACED() can be used to make the code more readable, use it. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-dma.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c b/drivers/

[PATCH v3] dt-bindings: rcar-{csi2,vin}: Rename bindings documentation files

2019-08-07 Thread Niklas Söderlund
Renesas media binding documentation files uses a naming schema of 'renesas,.txt'. Rename VIN and CSI-2 files to match this pattern. Signed-off-by: Niklas Söderlund Reviewed-by: Geert Uytterhoeven Reviewed-by: Ulrich Hecht Reviewed-by: Simon Horman --- .../media/{renesas,rcar-csi2.txt => renes

Re: [PATCH 3/4] rcar-vin: Add support for V4L2_FIELD_ALTERNATE

2019-08-07 Thread Niklas Söderlund
HI Kieran, Thanks for your review! On 2019-07-19 12:13:30 +0100, Kieran Bingham wrote: > Hi Niklas, > > On 05/07/2019 05:55, Niklas Söderlund wrote: > > The hardware is capable to passing V4L2_FIELD_ALTERNATE to user-space. > > Allow users to request this field format but still default to using

Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-08-07 Thread Ezequiel Garcia
Hi Sakari, Thanks for reviewing the patch. On Wed, 2019-08-07 at 15:06 +0300, Sakari Ailus wrote: > On Tue, Jul 30, 2019 at 05:14:24AM -0300, Ezequiel Garcia wrote: > > Hey Hans, > > > > On Mon, 2019-07-01 at 08:48 +0200, Philipp Zabel wrote: > > > On Thu, 2019-06-27 at 19:29 -0300, Fabio Esteva

[RFC,v4,4/4] media: platform: Add Mediatek ISP P1 V4L2 device driver

2019-08-07 Thread Jungo Lin
This patch adds the Mediatek ISP P1 HW control device driver. It handles the ISP HW configuration, provides interrupt handling and initializes the V4L2 device nodes and other V4L2 functions. Moreover, implement standard V4L2 video driver that utilizes V4L2 and media framework APIs. It supports one

[RFC,v4,3/4] media: platform: Add Mediatek ISP P1 image & meta formats

2019-08-07 Thread Jungo Lin
Add packed/full-g bayer formats with 8/10/12/14 bit for image output. Add Pass 1 (P1) specific meta formats for parameter processing and 3A/other statistics. (The current metadata format used in meta input and partial meta nodes is only a temporary solution to kick off the driver development and i

[RFC,v4,0/4] media: platform: mtk-isp: Add Mediatek ISP Pass 1 driver

2019-08-07 Thread Jungo Lin
Hello, This RFC patch series adding the driver for Pass 1 (P1) unit in Mediatek's camera ISP system on mt8183 SoC, which will be used in camera features of CrOS. It's the first time Mediatek develops ISP kernel drivers based on V4L2 and media controller framework. I posted the main part of the ISP

[RFC,v4,1/4] media: dt-bindings: mt8183: Added camera ISP Pass 1

2019-08-07 Thread Jungo Lin
This patch adds DT binding document for the Pass 1 (P1) unit in Mediatek's camera ISP system. The Pass 1 unit grabs the sensor data out from the sensor interface, applies ISP image effects from tuning data and outputs the image data or statistics data to DRAM. Signed-off-by: Jungo Lin --- .../bi

[RFC,v4,2/4] dts: arm64: mt8183: Add ISP Pass 1 nodes

2019-08-07 Thread Jungo Lin
Add nodes for Pass 1 unit of Mediatek's camera ISP system. Pass 1 unit embedded in Mediatek SoCs, works with the co-processor to process image signal from the image sensor and output RAW image data. Signed-off-by: Jungo Lin --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 31 ++

Re: [PATCH] media: tm6000: Spelling s/diconencted/diconnected/

2019-08-07 Thread Geert Uytterhoeven
Hi Hans, On Wed, Aug 7, 2019 at 1:05 PM Hans Verkuil wrote: > On 8/7/19 12:53 PM, Geert Uytterhoeven wrote: > > On Wed, Aug 7, 2019 at 11:33 AM Hans Verkuil wrote: > >> On 7/31/19 8:43 PM, Geert Uytterhoeven wrote: > >>> On Wed, Jul 31, 2019 at 8:36 PM Antti Palosaari wrote: > On 7/31/19 4

Re: [PATCH v3] media: imx: mipi csi-2: Don't fail if initial state times-out

2019-08-07 Thread Sakari Ailus
On Tue, Jul 30, 2019 at 05:14:24AM -0300, Ezequiel Garcia wrote: > Hey Hans, > > On Mon, 2019-07-01 at 08:48 +0200, Philipp Zabel wrote: > > On Thu, 2019-06-27 at 19:29 -0300, Fabio Estevam wrote: > > > From: Ezequiel Garcia > > > > > > Not all sensors will be able to guarantee a proper initial

Re: [GIT PULL FOR v5.4] Various fixes/enhancements

2019-08-07 Thread Jenkins
From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/58005/ Build log: https://builder.linuxtv.org/job/patchwork/3695/ Build time: 00:05:39 Summary: 0 issues, being 0 build regressions

[GIT PULL FOR v5.4] Various fixes/enhancements

2019-08-07 Thread Hans Verkuil
The following changes since commit d42974e438feebda372fe4a39d7761cc596abc57: media: venus: dec: populate properly timestamps and flags for capture buffers (2019-08-05 10:57:51 -0300) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git for-v5.4h for you to fetc

Re: [PATCH] media: tm6000: Spelling s/diconencted/diconnected/

2019-08-07 Thread Hans Verkuil
On 8/7/19 12:53 PM, Geert Uytterhoeven wrote: > Hi Hans, > > On Wed, Aug 7, 2019 at 11:33 AM Hans Verkuil wrote: >> On 7/31/19 8:43 PM, Geert Uytterhoeven wrote: >>> On Wed, Jul 31, 2019 at 8:36 PM Antti Palosaari wrote: On 7/31/19 4:41 PM, Geert Uytterhoeven wrote: > Signed-off-by: Gee

Re: [PATCH] media: tm6000: Spelling s/diconencted/diconnected/

2019-08-07 Thread Geert Uytterhoeven
Hi Hans, On Wed, Aug 7, 2019 at 11:33 AM Hans Verkuil wrote: > On 7/31/19 8:43 PM, Geert Uytterhoeven wrote: > > On Wed, Jul 31, 2019 at 8:36 PM Antti Palosaari wrote: > >> On 7/31/19 4:41 PM, Geert Uytterhoeven wrote: > >>> Signed-off-by: Geert Uytterhoeven > >>> --- > >>> drivers/media/usb/

[PATCH v2] ov5675: Add support for OV5675 sensor

2019-08-07 Thread Shawnx Tu
From: Shawn Tu Add a V4L2 sub-device driver for Omnivision ov5675 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. This driver supports following features: - manual exposure and analog/digital gain control support - vblank/hblank control support - t

Re: [PATCH 2/2]: media: hdpvr: Add optional restart, with optional delay, after restarting streaming

2019-08-07 Thread Hans Verkuil
On 8/4/19 12:09 AM, Keith Pyle wrote: > `hdpvr_read` attempts to restart streaming if the device is read while > it is both not ready and not disconnected. However, the device is often > still not ready immediately after the call to `hdpvr_start_streaming` > returns, causing the condition `if (buf

Re: [PATCH 1/2]: media: hdpvr: Add adaptive sleeping in hdpvr_start_streaming

2019-08-07 Thread Hans Verkuil
On 8/4/19 12:09 AM, Keith Pyle wrote: > The hdpvr firmware reacts poorly to a fast close/open sequence. Delaying > a few seconds between the close and next open produces generally reliable > results. Rather than requiring user programs to implement this delay and > coordinate among themselves whe

Re: [PATCH] media: tm6000: Spelling s/diconencted/diconnected/

2019-08-07 Thread Hans Verkuil
On 7/31/19 8:43 PM, Geert Uytterhoeven wrote: > Hi Antti, > > On Wed, Jul 31, 2019 at 8:36 PM Antti Palosaari wrote: >> On 7/31/19 4:41 PM, Geert Uytterhoeven wrote: >>> Signed-off-by: Geert Uytterhoeven >>> --- >>> drivers/media/usb/tm6000/tm6000-cards.c | 2 +- >>> 1 file changed, 1 inserti

Re: [PATCH v4 7/9] drm: tegra: use cec_notifier_conn_(un)register

2019-08-07 Thread Dariusz Marcinkiewicz
Hi Hans. On Tue, Jul 30, 2019 at 2:17 PM Hans Verkuil wrote: > > Hi Dariusz, > > One comment below: > > > int tegra_output_init(struct drm_device *drm, struct tegra_output *output) > > { > > + struct cec_connector_info conn_info; > > int err; > > > > if (output->panel) { > > @@

Re: [PATCH v1] ov5675: Add support for OV5675 sensor

2019-08-07 Thread Sakari Ailus
Hi Shawn, Thanks for the patch. A few comments below. On Wed, Jul 31, 2019 at 06:53:36PM +0800, Shawnx Tu wrote: ... > +static int ov5675_check_hwcfg(struct device *dev) > +{ > + struct fwnode_handle *ep; > + struct fwnode_handle *fwnode = dev_fwnode(dev); > + struct v4l2_fwnode_end

[PATCH 1/1] ov8856: Check reading clock frequency succeeded

2019-08-07 Thread Sakari Ailus
Instead of blindly trusting getting the clock frequency succeeded end then testing it against a pre-defined value, verify reading the value succeeded. Fixes: 879347f0c258 ("media: ov8856: Add support for OV8856 sensor") Signed-off-by: Sakari Ailus --- drivers/media/i2c/ov8856.c | 5 - 1 fil

[PATCH v5 9/9] drm: exynos: exynos_hdmi: use cec_notifier_conn_(un)register

2019-08-07 Thread Dariusz Marcinkiewicz
Use the new cec_notifier_conn_(un)register() functions to (un)register the notifier for the HDMI connector, and fill in the cec_connector_info. Changes since v2: - removed unnecessary call to invalidate phys address before deregistering the notifier, - use cec_notifier_phys

[PATCH v5 8/9] drm: dw-hdmi: use cec_notifier_conn_(un)register

2019-08-07 Thread Dariusz Marcinkiewicz
Use the new cec_notifier_conn_(un)register() functions to (un)register the notifier for the HDMI connector, and fill in the cec_connector_info. Changes since v4: - typo fix Changes since v2: - removed unnecessary NULL check before a call to cec_notifier_conn_unregister,

[PATCH v5 0/9] drm: cec: convert DRM drivers to the new notifier API

2019-08-07 Thread Dariusz Marcinkiewicz
This series updates DRM drivers to use new CEC notifier API. Only first two patches were tested on the actual hardware. Changes since v4: Addressing review comments. Changes since v3: Updated adapter flags in dw-hdmi-cec. Changes since v2: Include all DRM patches from "cec

[PATCH v5 1/9] drm_dp_cec: add connector info support.

2019-08-07 Thread Dariusz Marcinkiewicz
Pass the connector info to the CEC adapter. This makes it possible to associate the CEC adapter with the corresponding drm connector. Signed-off-by: Dariusz Marcinkiewicz Signed-off-by: Hans Verkuil --- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- drivers/gpu/drm/drm_dp_cec.c

[PATCH v5 6/9] drm: sti: use cec_notifier_conn_(un)register

2019-08-07 Thread Dariusz Marcinkiewicz
Use the new cec_notifier_conn_(un)register() functions to (un)register the notifier for the HDMI connector, and fill in the cec_connector_info. Changes since v2: Don't invalidate physical address before unregistering the notifier. Signed-off-by: Dariusz Marcinkiewicz --- drivers

[PATCH v5 2/9] drm/i915/intel_hdmi: use cec_notifier_conn_(un)register

2019-08-07 Thread Dariusz Marcinkiewicz
Use the new cec_notifier_conn_(un)register() functions to (un)register the notifier for the HDMI connector, and fill in the cec_connector_info. Signed-off-by: Dariusz Marcinkiewicz Signed-off-by: Hans Verkuil --- drivers/gpu/drm/i915/intel_hdmi.c | 13 + 1 file changed, 9 insertions

[PATCH v5 5/9] drm: tda998x: use cec_notifier_conn_(un)register

2019-08-07 Thread Dariusz Marcinkiewicz
Use the new cec_notifier_conn_(un)register() functions to (un)register the notifier for the HDMI connector, and fill in the cec_connector_info. Changes since v2: - cec_notifier_phys_addr_invalidate where appropriate, - don't check for NULL notifier before calling cec_notifi

[PATCH v5 7/9] drm: tegra: use cec_notifier_conn_(un)register

2019-08-07 Thread Dariusz Marcinkiewicz
Use the new cec_notifier_conn_(un)register() functions to (un)register the notifier for the HDMI connector, and fill in the cec_connector_info. Changes since v4: - only create a CEC notifier for HDMI connectors Signed-off-by: Dariusz Marcinkiewicz --- drivers/gpu/drm/tegra/output.c | 28

[PATCH v5 3/9] dw-hdmi-cec: use cec_notifier_cec_adap_(un)register

2019-08-07 Thread Dariusz Marcinkiewicz
Use the new cec_notifier_cec_adap_(un)register() functions to (un)register the notifier for the CEC adapter. Also adds CEC_CAP_CONNECTOR_INFO capability to the adapter. Changes since v3: - add CEC_CAP_CONNECTOR_INFO to cec_allocate_adapter, - replace CEC_CAP_LOG_ADDRS | CEC_CAP_TR

[PATCH v5 4/9] tda9950: use cec_notifier_cec_adap_(un)register

2019-08-07 Thread Dariusz Marcinkiewicz
Use the new cec_notifier_cec_adap_(un)register() functions to (un)register the notifier for the CEC adapter. Signed-off-by: Dariusz Marcinkiewicz Signed-off-by: Hans Verkuil --- drivers/gpu/drm/i2c/tda9950.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/driver

[PATCH] adv7511/cobalt: rename driver name to adv7511-v4l2

2019-08-07 Thread Hans Verkuil
Commit b2ce5617dad2 ("media: i2c: fix warning same module names") renamed the adv7511 module in the media tree to adv7511-v4l2. This patch does the same rename for the driver name and device id to keep the naming consistent. Since the cobalt driver loads this module, it had to be renamed there as