Re: [PATCH v3 1/3] media: uapi: h264: Clarify our expectations regarding NAL header format

On Fri, 5 Jul 2019 19:16:18 +0200 Boris Brezillon wrote: > On Fri, 05 Jul 2019 13:40:03 -0300 > Ezequiel Garcia wrote: > > > Hi Boris, Paul, > > > > On Wed, 2019-07-03 at 14:28 +0200, Boris Brezillon wrote: > > > Looks like some stateless decoders expect slices to be prefixed with > > > ANNE

[PATCH] staging/media/bcm2048: remove driver

This driver has seen no substantial effort to move it out of staging for 6 years. And after asking around nobody stepped up to do the remaining work. So remove it. Signed-off-by: Hans Verkuil --- drivers/staging/media/Kconfig |2 - drivers/staging/media/Makefile

cron job: media_tree daily build: WARNINGS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Jul 25 05:00:12 CEST 2019 media-tree git hash:e2727ec58c113c2c95cbb75f6a129bd1fa0bf761 media_build gi

Re: [RFC] Removal of drivers/staging/media/bcm2048

Hi, On Tue, Jul 23, 2019 at 12:58:54PM +0200, Hans Verkuil wrote: > On 7/23/19 11:48 AM, Pali Rohár wrote: > > On Tuesday 23 July 2019 11:09:53 Pavel Machek wrote: > >> On Tue 2019-07-23 10:51:52, Hans Verkuil wrote: > >>> This staging driver is now almost 6 years old, but hasn't seen any real > >

Re: [PATCH] media input infrastructure:tw686x: Added Added custom function to set vdev->release in tw686x driver

Hi Ezequiel, I just test built the kernel with my patch included and things run fine. To guide me in my assignment, could you please clarify what Hans Verkuil had been mentioning would be a good thing to code, he said in one of our previous emails: What tw686x_video_free() does really should

Re: [RFC PATCH V2 1/6] dt-bindings: mt8183: Added DIP dt-bindings

On Mon, 8 Jul 2019 19:04:55 +0800, wrote: > From: Frederic Chen > > This patch adds DT binding documentation for the Digital Image > Processing (DIP) unit of camera ISP system on Mediatek's SoCs. > > It depends on the SCP and MDP 3 patch as following: > > 1. dt-bindings: Add a binding for Medi

Re: [PATCH 1/2] media: i2c: dw9768: Add DT support and MAINTAINERS entry

On Mon, Jul 08, 2019 at 06:06:40PM +0800, dongchun@mediatek.com wrote: > From: Dongchun Zhu > > Add the Devicetree binding documentation and MAINTAINERS entry for dw9768. > > Signed-off-by: Dongchun Zhu > --- > Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.txt | 9 + >

Re: [PATCH] media input infrastructure:tw686x: Added Added custom function to set vdev->release in tw686x driver

Hi Mark, On Wed, 24 Jul 2019 at 12:10, Mark Balantzyan wrote: > This commit needs to be thoroughly explained in order to make sense. > Signed-off-by: Mark Balantzyan > --- > This patch adds a custom function to release video device in assignment to > vdev->release member in tw686x driver. > >

radio-si470x and gnomeradio

I found my old FM Radio stick last night and decided to see if it still worked. On insertion of my USB Radio stick, I get the following message: 178145.786842] radio-si470x 1-1.2:1.2: non-zero urb status (-71) [178145.810838] radio-si470x 1-1.2:1.2: non-zero urb status (-71) [178145.813827] usb

[PATCH] media input infrastructure:tw686x: Added Added custom function to set vdev->release in tw686x driver

Signed-off-by: Mark Balantzyan --- This patch adds a custom function to release video device in assignment to vdev->release member in tw686x driver. drivers/media/pci/tw686x/tw686x-video.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/media/pc

[PATCH v2] edid-decode: parse additional flags in the DD+ Short Audio Descriptor

From: Arnaud Vrac In the Dolby Digital Plus Short Audio Descriptor, byte 3 is used to signal Joint Object Coding support, which can be useful to determine if the sink supports Dolby Atmos. Parse these flags as described in the Dolby Audio and Dolby Atmos over HDMI specification v1.0. Other bits

Re: Issues with ov5640 camera on i.MX6Q

Hi Laura, thanks for addressing this issue. On Mon, Jul 22, 2019 at 05:50:35PM +0200, Laura Nao wrote: > Thanks Fabio! > > I tried tweaking the PLL configuration in the driver and did some further > tests on 5.2 kernel. > > I was finally able to capture RAW frames that match the test pattern fo

Re: [PATCH] davinci/vpfe_capture.c: drop unused format descriptions

Hi Hans, Thank you for the patch. On Tue, Jul 23, 2019 at 1:58 PM Hans Verkuil wrote: > > Simplify vpfe_pixel_format to just contain the pixelformat and bpp fields. > All others are unused. > > Signed-off-by: Hans Verkuil > --- > diff --git a/drivers/media/platform/davinci/vpfe_capture.c > b/d

Re: my patch

On 7/24/19 4:33 PM, Mark Balançian wrote: > I hope it looks ok? I was only able to direct git send email to send it > to one recipient (Hans). I'm not sure about the value for "pb" (I set it > to zero by default). Please would like some feedback. Also, I could not > figure out how to use git sen

Re: [PATCH 01/14] v4l2-ioctl.c: OR flags in v4l_fill_fmtdesc(), not don't overwrite

On Wed, 2019-07-24 at 15:30 +0200, Hans Verkuil wrote: > On 7/24/19 3:22 PM, Philipp Zabel wrote: > > On Wed, 2019-07-24 at 13:05 +0200, Hans Verkuil wrote: > > > If a driver sets a FMT flag in the enum_fmt op, then that will be > > > ignored since v4l_fill_fmtdesc() overwrites it again. > > > > >

my patch

I hope it looks ok? I was only able to direct git send email to send it to one recipient (Hans). I'm not sure about the value for "pb" (I set it to zero by default). Please would like some feedback. Also, I could not figure out how to use git send-email to Cc: linux-media. Cc'ing was working ye

Re: [PATCH] am437x: remove unused struct vpfe_pixel_format

Hi Hans, Thank you for the patch. On Tue, Jul 23, 2019 at 1:59 PM Hans Verkuil wrote: > > struct vpfe_pixel_format was defined, but never used. Remove it. > > Signed-off-by: Hans Verkuil > --- > diff --git a/drivers/media/platform/am437x/am437x-vpfe.h > b/drivers/media/platform/am437x/am437x-v

Re: tw686x driver (continued)

On 7/24/19 3:31 PM, Mark Balançian wrote: > On Jul 24, 2019, at 6:08 AM, Hans Verkuil > wrote: >> >> What tw686x_video_free() does really should be done in the release function >> of the video_device: vdev->release is currently set to video_device_release, >> but that sh

Re: [PATCH 01/14] v4l2-ioctl.c: OR flags in v4l_fill_fmtdesc(), not don't overwrite

On 7/24/19 3:22 PM, Philipp Zabel wrote: > On Wed, 2019-07-24 at 13:05 +0200, Hans Verkuil wrote: >> If a driver sets a FMT flag in the enum_fmt op, then that will be >> ignored since v4l_fill_fmtdesc() overwrites it again. >> >> v4l_fill_fmtdesc() should OR its flag, not overwrite it. >> >> Signed

Re: [PATCH 01/14] v4l2-ioctl.c: OR flags in v4l_fill_fmtdesc(), not don't overwrite

On Wed, 2019-07-24 at 13:05 +0200, Hans Verkuil wrote: > If a driver sets a FMT flag in the enum_fmt op, then that will be > ignored since v4l_fill_fmtdesc() overwrites it again. > > v4l_fill_fmtdesc() should OR its flag, not overwrite it. > > Signed-off-by: Hans Verkuil > --- > drivers/media/v

Re: tw686x driver (continued)

On 7/24/19 2:25 PM, Mark Balançian wrote: > Hi Ezequiel, > > (sorry didn't include linux-media in first email) > I'm not sure yet if I have my supervisor's permission to declare our > tool as open source, but I'll tell you the possible code paths that I > think may be leading our tool to think w

Re: tw686x driver (continued)

TBH though, I’m not sure about the tw686x_init going to the error: label though, so am curious as to your thoughts on this as well. It was just something I thought might be occurring due to the fact that the error trace in our tool ends in tw686x_memcpy_dma_free (i.e. dma_ops->free). Please se

Re: tw686x driver (continued)

Hi Ezequiel, (sorry didn't include linux-media in first email) I'm not sure yet if I have my supervisor's permission to declare our tool as open source, but I'll tell you the possible code paths that I think may be leading our tool to think what it's thinking. First off, it detects a write ac

[PATCH 13/14] media: docs-rst: Document m2m stateless video decoder interface

From: Alexandre Courbot Documents the protocol that user-space should follow when communicating with stateless video decoders. The stateless video decoding API makes use of the new request and tags APIs. While it has been implemented with the Cedrus driver so far, it should probably still be con

[PATCH 11/14] pixfmt-compressed.rst: improve H264/HEVC/MPEG1+2/VP8+9 documentation

The existing documentation was incorrect and did not correspond to how actual codec drivers implemented this. Update the documentation to explicitly specify what is actually expected. Signed-off-by: Hans Verkuil --- .../media/uapi/v4l/pixfmt-compressed.rst | 36 +++ 1 file

[PATCH 12/14] media: docs-rst: Document memory-to-memory video decoder interface

From: Tomasz Figa Due to complexity of the video decoding process, the V4L2 drivers of stateful decoder hardware require specific sequences of V4L2 API calls to be followed. These include capability enumeration, initialization, decoding, seek, pause, dynamic resolution change, drain and end of st

[PATCH 10/14] videodev2.h: add V4L2_DEC_CMD_FLUSH

Add this new V4L2_DEC_CMD_FLUSH decoder command and document it. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/v4l/vidioc-decoder-cmd.rst | 11 ++- Documentation/media/videodev2.h.rst.exceptions | 1 + include/uapi/linux/videodev2.h | 1 + 3 files c

[PATCH 14/14] media: docs-rst: Document memory-to-memory video encoder interface

From: Tomasz Figa Due to complexity of the video encoding process, the V4L2 drivers of stateful encoder hardware require specific sequences of V4L2 API calls to be followed. These include capability enumeration, initialization, encoding, encode parameters change, drain and reset. Specifics of th

[PATCH 05/14] media: venus: vdec: flag OUTPUT formats with V4L2_FMT_FLAG_DYN_RESOLUTION

From: Maxime Jourdan Tag all the coded formats where the venus vdec supports dynamic resolution switching. Signed-off-by: Maxime Jourdan Signed-off-by: Hans Verkuil --- drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/vdec.c | 11 +++ 2 files changed,

[PATCH 09/14] vb2: add V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF

From: Hans Verkuil This RFC patch adds support for the V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF flag. It also adds a new V4L2_BUF_CAP_SUPPORTS_M2M_HOLD_CAPTURE_BUF capability and a v4l2_m2m_release_capture_buf() helper function. Drivers should set vb2_queue->subsystem_flags to VB2_V4L2_FL_SUPPORTS_M2

[PATCH 08/14] media: vicodec: set flags for vdec/stateful OUTPUT coded formats

From: Maxime Jourdan Tag all the coded formats where the vicodec stateful decoder supports dynamic resolution switching and bitstream parsing. Signed-off-by: Maxime Jourdan Signed-off-by: Hans Verkuil [hverkuil-ci...@xs4all.nl: added HAS_BITSTREAM_PARSER] --- drivers/media/platform/vicodec/vi

[PATCH 06/14] media: s5p_mfc_dec: set flags for OUTPUT coded formats

From: Maxime Jourdan Tag all the coded formats where the s5p_mfc decoder supports dynamic resolution switching or has a bitstream parser. Signed-off-by: Maxime Jourdan Signed-off-by: Hans Verkuil [hverkuil-ci...@xs4all.nl: added HAS_BITSTREAM_PARSER] --- .../media/platform/s5p-mfc/s5p_mfc_com

[PATCH 07/14] media: mtk-vcodec: flag OUTPUT formats with V4L2_FMT_FLAG_DYN_RESOLUTION

From: Maxime Jourdan Tag all the coded formats where the mtk-vcodec decoder supports dynamic resolution switching. Signed-off-by: Maxime Jourdan Signed-off-by: Hans Verkuil --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 4 drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h | 1

[PATCH 04/14] videodev2.h.rst.exceptions: tymecode -> timecode

Fix typo. Signed-off-by: Hans Verkuil --- Documentation/media/videodev2.h.rst.exceptions | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/media/videodev2.h.rst.exceptions b/Documentation/media/videodev2.h.rst.exceptions index 0a9a1b386443..b6cb9fa6c8a8 10064

[PATCH 01/14] v4l2-ioctl.c: OR flags in v4l_fill_fmtdesc(), not don't overwrite

If a driver sets a FMT flag in the enum_fmt op, then that will be ignored since v4l_fill_fmtdesc() overwrites it again. v4l_fill_fmtdesc() should OR its flag, not overwrite it. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH 03/14] videodev2.h: add V4L2_FMT_FLAG_DYN_RESOLUTION

From: Maxime Jourdan Add an enum_fmt format flag to specifically tag coded formats where dynamic resolution switching is supported by the device. This is useful for some codec drivers that can support dynamic resolution switching for one or more of their listed coded formats. It allows userspace

[PATCH 00/14] Stateful/stateless codec core support (resend)

(There were too many recipients for my provider, so resending again without the zillion CCs, and in batches of 5 patches. Stupid spammer detection...) This series consolidates various patches/patch series that add features or document memory-to-memory video codec interfaces. This includes patches

[PATCH 02/14] videodev2.h: add V4L2_FMT_FLAG_HAS_BITSTREAM_PARSER

Add an enum_fmt format flag to specifically tag coded formats where full bitstream parsing is supported by the device. Some stateful decoders are capable of fully parsing a bitstream, but others require that userspace pre-parses the bitstream into frames or fields (see the corresponding pixelforma

[PATCH 01/14] v4l2-ioctl.c: OR flags in v4l_fill_fmtdesc(), not don't overwrite

If a driver sets a FMT flag in the enum_fmt op, then that will be ignored since v4l_fill_fmtdesc() overwrites it again. v4l_fill_fmtdesc() should OR its flag, not overwrite it. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH 00/14] Stateful/stateless codec core support

(There were too many recipients for my provider, so resending without the zillion CCs, just read the mailinglist instead :-) ) This series consolidates various patches/patch series that add features or document memory-to-memory video codec interfaces. This includes patches adding V4L2_FMT_FLAG_DY

[PATCH 02/14] videodev2.h: add V4L2_FMT_FLAG_HAS_BITSTREAM_PARSER

Add an enum_fmt format flag to specifically tag coded formats where full bitstream parsing is supported by the device. Some stateful decoders are capable of fully parsing a bitstream, but others require that userspace pre-parses the bitstream into frames or fields (see the corresponding pixelforma

[PATCH 03/14] videodev2.h: add V4L2_FMT_FLAG_DYN_RESOLUTION

From: Maxime Jourdan Add an enum_fmt format flag to specifically tag coded formats where dynamic resolution switching is supported by the device. This is useful for some codec drivers that can support dynamic resolution switching for one or more of their listed coded formats. It allows userspace

[PATCH 02/14] videodev2.h: add V4L2_FMT_FLAG_HAS_BITSTREAM_PARSER

Add an enum_fmt format flag to specifically tag coded formats where full bitstream parsing is supported by the device. Some stateful decoders are capable of fully parsing a bitstream, but others require that userspace pre-parses the bitstream into frames or fields (see the corresponding pixelforma

[PATCH 01/14] v4l2-ioctl.c: OR flags in v4l_fill_fmtdesc(), not don't overwrite

If a driver sets a FMT flag in the enum_fmt op, then that will be ignored since v4l_fill_fmtdesc() overwrites it again. v4l_fill_fmtdesc() should OR its flag, not overwrite it. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH 06/14] media: s5p_mfc_dec: set flags for OUTPUT coded formats

From: Maxime Jourdan Tag all the coded formats where the s5p_mfc decoder supports dynamic resolution switching or has a bitstream parser. Signed-off-by: Maxime Jourdan Signed-off-by: Hans Verkuil [hverkuil-ci...@xs4all.nl: added HAS_BITSTREAM_PARSER] --- .../media/platform/s5p-mfc/s5p_mfc_com

[PATCH 00/14] Stateful/stateless codec core support

This series consolidates various patches/patch series that add features or document memory-to-memory video codec interfaces. This includes patches adding V4L2_FMT_FLAG_DYN_RESOLUTION, new code adding V4L2_FMT_FLAG_HAS_BITSTREAM_PARSER, new code adding V4L2_DEC_CMD_FLUSH, patches adding V4L2_BUF_FL

[PATCH 04/14] videodev2.h.rst.exceptions: tymecode -> timecode

Fix typo. Signed-off-by: Hans Verkuil --- Documentation/media/videodev2.h.rst.exceptions | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/media/videodev2.h.rst.exceptions b/Documentation/media/videodev2.h.rst.exceptions index 0a9a1b386443..b6cb9fa6c8a8 10064

[PATCH 03/14] videodev2.h: add V4L2_FMT_FLAG_DYN_RESOLUTION

From: Maxime Jourdan Add an enum_fmt format flag to specifically tag coded formats where dynamic resolution switching is supported by the device. This is useful for some codec drivers that can support dynamic resolution switching for one or more of their listed coded formats. It allows userspace

[PATCH 05/14] media: venus: vdec: flag OUTPUT formats with V4L2_FMT_FLAG_DYN_RESOLUTION

From: Maxime Jourdan Tag all the coded formats where the venus vdec supports dynamic resolution switching. Signed-off-by: Maxime Jourdan Signed-off-by: Hans Verkuil --- drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/vdec.c | 11 +++ 2 files changed,

Re: [RFC PATCH 0/5] Add enum_fmt flag for coded formats with dynamic resolution switching

On 7/24/19 12:32 PM, Maxime Jourdan wrote: > On Thu, Jul 18, 2019 at 11:22 AM Hans Verkuil wrote: >> >> On 7/18/19 10:39 AM, Maxime Jourdan wrote: >>> On Mon, Jul 15, 2019 at 2:37 PM Hans Verkuil wrote: On 6/11/19 10:13 AM, Hans Verkuil wrote: > On 6/9/19 4:38 PM, Maxime Jourdan wro

Re: [RFC PATCH 0/5] Add enum_fmt flag for coded formats with dynamic resolution switching

On Thu, Jul 18, 2019 at 11:22 AM Hans Verkuil wrote: > > On 7/18/19 10:39 AM, Maxime Jourdan wrote: > > On Mon, Jul 15, 2019 at 2:37 PM Hans Verkuil wrote: > >> > >> On 6/11/19 10:13 AM, Hans Verkuil wrote: > >>> On 6/9/19 4:38 PM, Maxime Jourdan wrote: > Hello, > > This RFC propos