On Thu, Jun 27, 2019 at 12:26 AM Boris Brezillon
wrote:
>
> On Wed, 26 Jun 2019 13:30:38 +0200
> Paul Kocialkowski wrote:
>
> > Hi,
> >
> > On Mon, 2019-06-10 at 10:52 +0200, Boris Brezillon wrote:
> > > Some stateless decoders don't support per-slice decoding (or at least
> > > not in a way that
I am Vice Chairman of Hang Seng Bank, I have Important Matter to Discuss with
you concerning my late client, Died without a NEXT OF KIN. Send me your private
email for full details information. email me at (chienkraym...@outlook.com)
Mail:infocar...@aim.com
Regards
Dr.Raymond Chien Kuo Fung
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Fri Jun 28 05:00:13 CEST 2019
media-tree git hash:f81cbfc4f82a75ca0a2dc181a9c93b88f0e6509d
media_build gi
On 06/20/19 06:33, Hans Verkuil wrote:
On 6/19/19 4:29 AM, Keith Pyle wrote:
On 06/18/19 02:16, Hans Verkuil wrote:
Hi Keith,
On 6/18/19 6:17 AM, Keith Pyle wrote:
We made the suggested change, compiled, installed, and rebooted. There was some
progress - test 2 (turning the HD-PVR off) no lo
Thanks Fabio,
Reviewed-by: Steve Longerbeam
On 6/27/19 3:29 PM, Fabio Estevam wrote:
From: Ezequiel Garcia
Not all sensors will be able to guarantee a proper initial state.
This may be either because the driver is not properly written,
or (probably unlikely) because the hardware won't suppor
From: Ezequiel Garcia
Not all sensors will be able to guarantee a proper initial state.
This may be either because the driver is not properly written,
or (probably unlikely) because the hardware won't support it.
While the right solution in the former case is to fix the sensor
driver, the real w
On 6/27/19 3:13 PM, Fabio Estevam wrote:
From: Ezequiel Garcia
Not all sensors will be able to guarantee a proper initial state.
This may be either because the driver is not properly written,
or (probably unlikely) because the hardware won't support it.
While the right solution in the forme
On Thu, Jun 27, 2019 at 3:45 PM Ezequiel Garcia wrote:
> I think Philipp's suggestions looks very good, both the text and keeping
> the phy state. I think both should be kept in the warning.
>
> Fabio: feel free to submit a v2, or let me know so I'll add it to my TODO.
I have just sent a v2 with
From: Ezequiel Garcia
Not all sensors will be able to guarantee a proper initial state.
This may be either because the driver is not properly written,
or (probably unlikely) because the hardware won't support it.
While the right solution in the former case is to fix the sensor
driver, the real w
On 6/27/19 5:56 AM, Philipp Zabel wrote:
Hi Fabio,
On Thu, 2019-06-27 at 09:38 -0300, Fabio Estevam wrote:
Hi Philipp,
On Thu, Jun 27, 2019 at 5:43 AM Philipp Zabel wrote:
Are there any visual artifacts in the first frame(s) in this case?
I do not observe visual artifacts when running g
From: Dave Stevenson
Fixes a v4l2-compliance failure
v4l2-test-buffers.cpp(415): g_field() == V4L2_FIELD_ANY
The driver only ever produces progresive frames, so field should
always be set to V4L2_FIELD_NONE.
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/bcm283
From: Dave Stevenson
The V4L2 control API was expanded to take 64 bit values in commit
0ba2aeb6dab (Apr 16 2014), but as this driver wasn't in the mainline
kernel at that point this was overlooked.
Update to use 64 bit values. This also fixes a couple of warnings
in 64 bit builds.
Signed-off-by
From: Dave Stevenson
Fixes a v4l2-compliance failure when passed a buffer that is
too small.
queue_setup wasn't handling the case where !(*nplanes), as
used from CREATE_BUFS and requiring the driver to sanity
check the provided buffer parameters. It was assuming that
it was always being used in t
From: Dave Stevenson
Fixes up a checkpatch error "Avoid using bool structure members
because of possible alignment issues".
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 12 ++--
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.h |
From: Dave Stevenson
RGB3/BGR3 end up being 3 bytes per pixel, which meant that
the alignment code ended up trying to align using bitmasking
with a mask of 96.
That doesn't work, so switch to an arithmetic alignment for
those formats.
Signed-off-by: Dave Stevenson
---
.../vc04_services/bcm2835
Le jeudi 27 juin 2019 à 20:56 +0200, Stefan Wahren a écrit :
> From: Dave Stevenson
>
> There is an awkward situation with H264 header bytes. Currently
> they are returned with a PTS of 0 because they aren't associated
> with a timestamped frame to encode. These are handled by either
> returning
Hi Dave,
Le jeudi 27 juin 2019 à 20:55 +0200, Stefan Wahren a écrit :
> From: Dave Stevenson
>
> H264 header come from VC with 0 timestamps, which means they get a
> strange timestamp when processed with VC/kernel start times,
> particularly if used with the inline header option.
> Remember the
On Thu, Jun 27, 2019 at 10:13:56AM +0200, Bastien Nocera wrote:
> This new test will try to parse all the ".toml" files in the directory
> path passed to it, error'ing out on the first parsing problem.
>
> Run as "make check" in the keytable directory.
Good catch, and I like your solution.
It ne
From: Dave Stevenson
Controls of type MMAL_CONTROL_TYPE_STD_MENU call v4l2_ctrl_new_std_menu
with a max value and a mask. The max value is one of the defined
values for the control, however in the config array there are several
entries where raw numbers have been used instead. Replace these
with
From: Dave Stevenson
mmal-common.h and mmal-msg.h didn't have the normal
ifndef FOO / define FOO / endif protection to stop it being
included multiple times. Add it.
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/mmal-common.h | 3 +++
drivers/staging/vc04_servi
From: Dave Stevenson
Clear checkpatch complaints of "multiple assignments should be avoided"
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_services/bc
From: Dave Stevenson
Fixes up all the checkpatch error "line over 80 characters" in
mmal-parameters.h
Signed-off-by: Dave Stevenson
---
.../vc04_services/bcm2835-camera/mmal-parameters.h | 261 +
1 file changed, 159 insertions(+), 102 deletions(-)
diff --git a/drivers/stag
From: Dave Stevenson
Remove a todo which has been done.
Remove a template line that was redundant.
Make a comment clearer as to the non-obvious meaning of a field.
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/controls.c | 11 +--
1 file changed, 1 inse
From: Dave Stevenson
With V4L2_CID_COLORFX_CBCR calling ctrl_set_colfx it was incorrectly
assigning the colour values to the enable field of dev->colourfx
instead of the u and v fields.
Correct the assignments.
Reported as a Coverity issue
Detected by CoverityScan CID#1419711 ("Unused value")
From: Dave Stevenson
Most of the headers use ifndef FOO_H, whilst mmal-parameters.h
used ifndef __FOO_H.
Revise mmal-parameters.h to drop the underscores and make the
headers all consistent.
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/mmal-parameters.h | 4 +
From: Dave Stevenson
Fix checkpatch warnings over spaces around operators.
Many were around operations that can be replaced with the
BIT(x) macro, so replace with that where appropriate.
Signed-off-by: Dave Stevenson
---
.../vc04_services/bcm2835-camera/controls.c| 32 +++--
From: Dave Stevenson
Set the sequence number in vb2_v4l2_buffer mainly so the
latest v4l2-ctl reports the frame rate correctly.
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 4
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.
From: Dave Stevenson
The change to mapping V4L2 to MMAL buffers 1:1 didn't handle
the condition we get with raw pixel buffers (eg YUV and RGB)
direct from the camera's stills port. That sends the pixel buffer
and then an empty buffer with the EOS flag set. The EOS buffer
wasn't handled and return
From: Dave Stevenson
The commit "staging: bcm2835-camera: Replace open-coded idr with a struct idr."
replaced an internal implementation of an idr with the standard functions
and a spinlock. idr_alloc(GFP_KERNEL) can sleep whilst calling kmem_cache_alloc
to allocate the new node, but this is not
From: Dave Stevenson
vchi_bulk_queue_receive will queue up to a default of 4
bulk receives on a connection before blocking.
If called from the VCHI service_callback thread, then
that thread is unable to service the VCHI_CALLBACK_BULK_RECEIVED
events that would enable the queue call to succeed.
A
On Thu, 2019-06-27 at 11:33 +0200, Paul Kocialkowski wrote:
> Hi,
>
> On Wed 13 Feb 19, 18:15, Ezequiel Garcia wrote:
> > From: Pawel Osciak
> >
> > These controls are to be used with the new low-level decoder API for VP8
> > to provide additional parameters for the hardware that cannot parse th
This is an attempt to help Dave Stevenson to get all the fixes and
improvements of the bcm2835-camera driver into mainline.
Mostly i only polished the commit logs for upstream.
The series based on the latest bugfix V2 of staging: bcm2835-camera: Restore
return behavior of ctrl_set_bitrate().
Dav
From: Dave Stevenson
Fix comment style violations in the header files.
Signed-off-by: Dave Stevenson
---
.../vc04_services/bcm2835-camera/mmal-msg-format.h | 95 ---
.../vc04_services/bcm2835-camera/mmal-msg-port.h | 124 +--
.../vc04_services/bcm2835-camera/mmal
From: Dave Stevenson
None of the listed author email addresses were valid.
Keep list of authors and the companies they represented.
Update my email address.
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 9 +
drivers/staging/vc04_serv
From: Dave Stevenson
Fix checkpatch errors "Avoid multiple line dereference"
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-cam
From: Dave Stevenson
Forward MMAL key frame flags to the V4L2 buffers.
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
b/drivers
From: Dave Stevenson
Fix checkpatch errors for missing blank lines after variable
or structure declarations.
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vc04_services/bcm2835
From: Dave Stevenson
H264 header come from VC with 0 timestamps, which means they get a
strange timestamp when processed with VC/kernel start times,
particularly if used with the inline header option.
Remember the last frame timestamp and use that if set, or otherwise
use the kernel start time.
From: Dave Stevenson
We have numerous lines over 80 chars, or oddly split. Many
of these are due to using long enum names such as
MMAL_COMPONENT_CAMERA.
Reduce the length of these enum names.
Signed-off-by: Dave Stevenson
---
.../vc04_services/bcm2835-camera/bcm2835-camera.c | 156 +++
From: Dave Stevenson
Fix several instances where it is easier to return
early on error conditions than handle it as an else
clause. As requested by Mauro.
Signed-off-by: Dave Stevenson
---
.../vc04_services/bcm2835-camera/bcm2835-camera.c | 109 +++--
1 file changed, 58 insert
From: Dave Stevenson
When handling for V4L2_CID_MPEG_VIDEO_REPEAT_SEQ_HEADER was added
the firmware would reject the setting if H264 hadn't already been
selected. This was fixed in the firmware at that point, but to
enable backwards compatibility the returned error was ignored.
That was Dec 2013
From: Dave Stevenson
With the recent change to match MMAL and V4L2 buffers there
is a need to wait for all MMAL buffers to be returned during
stop_streaming.
Fixes: 938416707071 ("staging: bcm2835-camera: Remove V4L2/MMAL buffer
remapping")
Signed-off-by: Dave Stevenson
---
.../vc04_services/
From: Dave Stevenson
There is an awkward situation with H264 header bytes. Currently
they are returned with a PTS of 0 because they aren't associated
with a timestamped frame to encode. These are handled by either
returning the timestamp of the last buffer to have been received,
or in the case of
From: Dave Stevenson
Fix checkpatch "Alignment should match open parenthesis"
errors.
Signed-off-by: Dave Stevenson
---
.../vc04_services/bcm2835-camera/bcm2835-camera.c | 9
.../vc04_services/bcm2835-camera/controls.c| 25 ++
.../vc04_services/bcm2835-ca
From: Dave Stevenson
Before commit "staging: bcm2835-camera: Remove V4L2/MMAL buffer remapping"
there was a need to ensure that there were sufficient buffers supplied from
the user to cover those being sent to the VPU (always 1).
Now the buffers are linked 1:1 between MMAL and V4L2,
therefore th
From: Dave Stevenson
Fix mismatched or missing brace issues flagged by checkpatch.
Signed-off-by: Dave Stevenson
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 3 ++-
drivers/staging/vc04_services/bcm2835-camera/controls.c | 3 ++-
drivers/staging/vc04_services/bcm28
On Thu, 2019-06-27 at 14:56 +0200, Philipp Zabel wrote:
> Hi Fabio,
>
> On Thu, 2019-06-27 at 09:38 -0300, Fabio Estevam wrote:
> > Hi Philipp,
> >
> > On Thu, Jun 27, 2019 at 5:43 AM Philipp Zabel
> > wrote:
> >
> > > Are there any visual artifacts in the first frame(s) in this case?
> >
> >
Hi Sakari,
On Thu, Jun 27, 2019 at 1:27 PM Sakari Ailus wrote:
> This appears to change the order in which the regulators are enabled. Is
> that intentional? Does the sensor support this order as well?
Good catch! I have sent a v2 that preserves the regulator enable order.
Thanks
There is no need to call regulator_set_voltage() for each regulator
that powers the camera.
The voltage value for each regulator should be retrieved from the
device tree, so remove the unneeded regulator_set_voltage().
Signed-off-by: Fabio Estevam
---
Changes since v1:
- None
drivers/media/i2c
The code can be simplified by using the regulator_bulk() functions,
so switch to it.
Signed-off-by: Fabio Estevam
---
Changes since v1:
- Retain the regulator enable ordering (Sakari)
drivers/media/i2c/ov5645.c | 94 +-
1 file changed, 21 insertions(+), 73 de
Hi Fabio,
On Wed, Jun 26, 2019 at 08:56:13PM -0300, Fabio Estevam wrote:
> There is no need to call regulator_set_voltage() for each regulator
> that powers the camera.
>
> The voltage value for each regulator should be retrieved from the
> device tree, so remove the unneeded regulator_set_voltag
Hi Fabio,
On Wed, Jun 26, 2019 at 08:56:14PM -0300, Fabio Estevam wrote:
> The code can be simplified by using the regulator_bulk() functions,
> so switch to it.
>
> Signed-off-by: Fabio Estevam
> ---
> drivers/media/i2c/ov5645.c | 94 +-
> 1 file changed, 21
Hi Hugues,
On Thu, Jun 27, 2019 at 02:57:04PM +0200, Hugues Fruchet wrote:
> Add support of V4L2_CID_LINK_FREQ, this is needed
> by some CSI-2 receivers.
>
> 384MHz is exposed for the time being, corresponding
> to 96MHz pixel clock with 2 bytes per pixel on 2 data lanes.
>
> This setup has been
Hi linux-media devs, this is similar to one of HCH's patches that
hasn't been applied yet.
The patch 7b4eeed174b7: "[media] vmalloc_sg: make sure all pages in
vmalloc area are really DMA-ready" from Jun 12, 2014, leads to the
following static checker warning:
drivers/media/v4l2-core/video
Add support of V4L2_CID_LINK_FREQ, this is needed
by some CSI-2 receivers.
384MHz is exposed for the time being, corresponding
to 96MHz pixel clock with 2 bytes per pixel on 2 data lanes.
This setup has been tested successfully with ST MIPID02
CSI-2 to parallel bridge.
Signed-off-by: Hugues Fruc
Hi Fabio,
On Thu, 2019-06-27 at 09:38 -0300, Fabio Estevam wrote:
> Hi Philipp,
>
> On Thu, Jun 27, 2019 at 5:43 AM Philipp Zabel wrote:
>
> > Are there any visual artifacts in the first frame(s) in this case?
>
> I do not observe visual artifacts when running gst-launch-1.0 v4l2src !
> kmssi
When reaching the end of stream, V4L2 m2m clients may expect the
V4L2_EOS_EVENT. Although the V4L2_EOS_EVENT is deprecated behavior,
drivers must signal that event before dequeuing the buffer that has the
V4L2_BUF_FLAG_LAST flag set.
If a driver queues the V4L2_EOS_EVENT event and returns the buff
When reaching the end of stream, V4L2 clients may expect the
V4L2_EOS_EVENT before being able to dequeue the last buffer, which has
the V4L2_BUF_FLAG_LAST flag set.
If the vb2_poll() function first checks for events and afterwards if
buffers are available, a driver can queue the V4L2_EOS_EVENT eve
The patches fix a race condition in the poll functions of v4l2 devices.
Whenever a driver returns a buffer with the V4L2_BUF_FLAG_LAST flag set, it
must also return a V4L2_EVENT_EOS. Checking for events before checking for
buffers creates a race condition where drivers can return the buffer and ev
On Thu, 2019-06-27 at 10:43 +0200, Philipp Zabel wrote:
> On Wed, 2019-06-26 at 16:29 -0700, Steve Longerbeam wrote:
> > Hi Fabio,
> >
> > On 6/26/19 4:22 PM, Fabio Estevam wrote:
> > > Hi Steve,
> > >
> > > On Wed, Jun 26, 2019 at 6:19 PM Steve Longerbeam
> > > wrote:
> > >
> > > > Did you on
Hi Philipp,
On Thu, Jun 27, 2019 at 5:43 AM Philipp Zabel wrote:
> Are there any visual artifacts in the first frame(s) in this case?
I do not observe visual artifacts when running gst-launch-1.0 v4l2src ! kmssink
> > So in my opinion the next version of this patch should make LP-11
> > timeou
--
Greetings,
I have an intending proposal for you please i need you to contact my
private
E-mail(dralbertddzo...@gmail.com) for more updates,
Best Wishes.
DR ALBERT ZONGO
--
Hi,
On Wed 13 Feb 19, 18:15, Ezequiel Garcia wrote:
> From: Pawel Osciak
>
> These controls are to be used with the new low-level decoder API for VP8
> to provide additional parameters for the hardware that cannot parse the
> input stream.
>
> Signed-off-by: Pawel Osciak
> [ezequiel: rebased]
On Wed, 2019-06-26 at 16:29 -0700, Steve Longerbeam wrote:
> Hi Fabio,
>
> On 6/26/19 4:22 PM, Fabio Estevam wrote:
> > Hi Steve,
> >
> > On Wed, Jun 26, 2019 at 6:19 PM Steve Longerbeam
> > wrote:
> >
> > > Did you only get the LP-11 timeout warning message with this patch on
> > > the OV5645
On 6/27/19 10:12 AM, Florian Echtler wrote:
> On 26.06.19 11:52, Hans Verkuil wrote:
>> This driver set the colorspace to SRGB, but that makes no sense for
>> a touchscreen. Use RAW instead. This also ensures consistency with the
>> v4l_pix_format_touch() call that's used in v4l2-ioctl.c.
>
> One
This new test will try to parse all the ".toml" files in the directory
path passed to it, error'ing out on the first parsing problem.
Run as "make check" in the keytable directory.
---
Changes since v1:
- Fix patch formatting
At least 4 keymaps look broken in the current git:
it913x_v2.toml
pinna
On 26.06.19 11:52, Hans Verkuil wrote:
> This driver set the colorspace to SRGB, but that makes no sense for
> a touchscreen. Use RAW instead. This also ensures consistency with the
> v4l_pix_format_touch() call that's used in v4l2-ioctl.c.
One question for clarification: this will only affect use
On Wed, 26 Jun 2019 13:44:23 +0200, Hans Verkuil wrote:
> On 6/25/19 4:11 PM, Michael Tretter wrote:
> > When reaching the end of stream, V4L2 m2m clients may expect the
> > V4L2_EOS_EVENT. Although the V4L2_EOS_EVENT is deprecated behavior,
> > drivers must signal that event before dequeuing th
Just three patches this time.
Regards,
Hans
The following changes since commit 86d617d6c79d79288ca608b6fb0a2467b0e8ddbb:
media: MAINTAINERS: Add maintainers for Media Controller (2019-06-24 15:07:51
-0400)
are available in the Git repository at:
git://linuxtv.org/hverkuil/media_t
Hi Ezequiel,
'checkpatch.pl --strict' finds way too many issues.
I'm pretty certain you didn't run it.
Please fix the issues and post a v4.
A lot (but not all) of the warnings report lines that are too long
and from what I can see most are easily fixed without reducing
readability.
Regards,
Hi Ezequiel,
On Tue, Jun 25, 2019 at 05:39:45PM -0300, Ezequiel Garcia wrote:
> Not all sensors will be able to guarantee a proper initial state.
> This may be either because the driver is not properly written,
> or (probably unlikely) because the hardware won't support it.
>
> While the right sol
71 matches
Mail list logo
