Update ChromeOS CEC EC driver to the new notifier API.
Signed-off-by: Dariusz Marcinkiewicz
---
.../media/platform/cros-ec-cec/cros-ec-cec.c | 70 ---
1 file changed, 44 insertions(+), 26 deletions(-)
diff --git a/drivers/media/platform/cros-ec-cec/cros-ec-cec.c
b/drivers/medi
Клиентские базы! Email: proda...@armyspy.com Узнайте подробнее!
The code can be simplified by using the regulator_bulk() functions,
so switch to it.
Signed-off-by: Fabio Estevam
---
drivers/media/i2c/ov5645.c | 94 +-
1 file changed, 21 insertions(+), 73 deletions(-)
diff --git a/drivers/media/i2c/ov5645.c b/drivers/media
There is no need to call regulator_set_voltage() for each regulator
that powers the camera.
The voltage value for each regulator should be retrieved from the
device tree, so remove the unneeded regulator_set_voltage().
Signed-off-by: Fabio Estevam
---
drivers/media/i2c/ov5645.c | 28 ---
Hi Fabio,
On 6/26/19 4:22 PM, Fabio Estevam wrote:
Hi Steve,
On Wed, Jun 26, 2019 at 6:19 PM Steve Longerbeam wrote:
Did you only get the LP-11 timeout warning message with this patch on
the OV5645, or both the LP-11 timeout and clock lane timeout warnings?
With this patch applied I get onl
Hi Steve,
On Wed, Jun 26, 2019 at 6:19 PM Steve Longerbeam wrote:
> Did you only get the LP-11 timeout warning message with this patch on
> the OV5645, or both the LP-11 timeout and clock lane timeout warnings?
With this patch applied I get only the LP-11 timeout warnings, not
clock lane timeou
On 6/26/19 12:53 PM, Fabio Estevam wrote:
Hi Philipp,
On Wed, Jun 26, 2019 at 4:45 AM Philipp Zabel wrote:
I think the messages could use a note that they may be due to a sensor
or sensor driver bug, and that there might be image artifacts or
outright failure to capture as a consequence.
Hi Philipp,
On Wed, Jun 26, 2019 at 4:45 AM Philipp Zabel wrote:
> I think the messages could use a note that they may be due to a sensor
> or sensor driver bug, and that there might be image artifacts or
> outright failure to capture as a consequence.
Yes, this a good idea.
With this patch I
Hi Laurent,
On 6/26/19 1:00 AM, Laurent Pinchart wrote:
Hi Ezequiel,
Thank you for the patch.
On Tue, Jun 25, 2019 at 05:39:45PM -0300, Ezequiel Garcia wrote:
Not all sensors will be able to guarantee a proper initial state.
This may be either because the driver is not properly written,
or (p
Hi Laurent, Philipp,
Thank you for the prompt review! I was pretty sure this would
raise your wise eyebrows :-)
On Wed, 2019-06-26 at 11:00 +0300, Laurent Pinchart wrote:
> Hi Ezequiel,
>
> Thank you for the patch.
>
> On Tue, Jun 25, 2019 at 05:39:45PM -0300, Ezequiel Garcia wrote:
> > Not all
Hi Hans,
Thank you for the patch.
On Wed, Jun 26, 2019 at 01:27:48PM +0200, Hans Verkuil wrote:
> The V4L2 core sets the format description and flags for the driver in order
> to ensure consistent naming.
>
> So drop the strscpy of the description in drivers. Also remove any
> description string
Hi Hans,
Thank you for the patch.
On Wed, Jun 26, 2019 at 01:27:47PM +0200, Hans Verkuil wrote:
> The V4L2 core sets the format description and flags for the driver in order
> to ensure consistent naming.
>
> So drop the strscpy of the description in drivers. Also remove any
> description string
On 6/26/19 6:31 PM, Laurent Pinchart wrote:
> Hi Hans,
>
> Thank you for the patch.
>
> On Wed, Jun 26, 2019 at 01:27:44PM +0200, Hans Verkuil wrote:
>> The v4l_fill_fmtdesc() is supposed to be updated whenever a new pixelformat
>> is added, but a bunch of recently added pixelformats were forgott
Hi Hans,
Thank you for the patch.
On Wed, Jun 26, 2019 at 01:27:44PM +0200, Hans Verkuil wrote:
> The v4l_fill_fmtdesc() is supposed to be updated whenever a new pixelformat
> is added, but a bunch of recently added pixelformats were forgotten.
Sorry about forgetting tp update the code :-(
> Up
On Wed, 26 Jun 2019 13:30:38 +0200
Paul Kocialkowski wrote:
> Hi,
>
> On Mon, 2019-06-10 at 10:52 +0200, Boris Brezillon wrote:
> > Some stateless decoders don't support per-slice decoding (or at least
> > not in a way that would make them efficient or easy to use).
> > Let's expose a menu to co
On Wed, 2019-06-26 at 11:48 +0200, Hans Verkuil wrote:
> The function v4l_pix_format_touch() is called for S_FMT to set
> v4l2_pix_format fields to default values for a v4l-touch device,
> but it wasn't called for TRY_FMT. Add this.
>
> Signed-off-by: Hans Verkuil
> ---
> diff --git a/drivers/med
On 6/26/19 3:55 PM, Laurent Pinchart wrote:
> Hi Hans,
>
> Thank you for the patch.
>
> On Wed, Jun 26, 2019 at 11:58:02AM +0200, Hans Verkuil wrote:
>> The priv field of struct v4l2_pix_format shouldn't be set by drivers,
>> it's set by the v4l2 core instead to V4L2_PIX_FMT_PRIV_MAGIC.
>>
>> Dro
Hans Verkuil wrote on Wed [2019-Jun-26 13:27:48
+0200]:
> The V4L2 core sets the format description and flags for the driver in order
> to ensure consistent naming.
>
> So drop the strscpy of the description in drivers. Also remove any
> description strings in driver-internal structures since th
Acked-by: Benoit Parrot
Hans Verkuil wrote on Wed [2019-Jun-26 09:44:20
+0200]:
> Instead of filling in the struct v4l2_capability device_caps
> field, fill in the struct video_device device_caps field.
>
> That way the V4L2 core knows what the capabilities of the
> video device are.
>
> Sign
Hi Hans,
Thank you for the patch.
On Wed, Jun 26, 2019 at 11:58:02AM +0200, Hans Verkuil wrote:
> The priv field of struct v4l2_pix_format shouldn't be set by drivers,
> it's set by the v4l2 core instead to V4L2_PIX_FMT_PRIV_MAGIC.
>
> Drop this from the few media drivers that still do this.
>
Hi,
Did you see my email below from last week?
We manufacture ALL custom LOGO and branded products – over 300,000 to
choose from.
The most asked about product that we make, are the custom printed USB flash
drives!
We can print your logo on them and load your digital images, videos and
files!
h
On Wed, 26 Jun 2019 13:33:41 +0200
Paul Kocialkowski wrote:
> Hi,
>
> On Mon, 2019-06-10 at 10:52 +0200, Boris Brezillon wrote:
> > Those lists can be extracted from the dpb, let's simplify userspace
> > life and build that list kernel-side (generic helpers will be provided
> > for drivers that
On 6/25/19 4:11 PM, Michael Tretter wrote:
> When reaching the end of stream, V4L2 m2m clients may expect the
> V4L2_EOS_EVENT. Although the V4L2_EOS_EVENT is deprecated behavior,
> drivers must signal that event before dequeuing the buffer that has the
> V4L2_BUF_FLAG_LAST flag set.
>
> If a driv
Hi,
On Mon, 2019-06-10 at 10:52 +0200, Boris Brezillon wrote:
> Those lists can be extracted from the dpb, let's simplify userspace
> life and build that list kernel-side (generic helpers will be provided
> for drivers that need this list).
I don't really have any clear idea about that, but there
Hi,
On Mon, 2019-06-10 at 10:52 +0200, Boris Brezillon wrote:
> Some stateless decoders don't support per-slice decoding (or at least
> not in a way that would make them efficient or easy to use).
> Let's expose a menu to control and expose the supported decoding modes.
> Drivers are allowed to su
The v4l_fill_fmtdesc() function in v4l2-ioctl.c fills in the format
description and the format flags. But a lot of drivers still manually
set the description/flags. Since the description names are all over
the place it is far better to let the core handle this.
This series converts 99% of all driv
The V4L2 core sets the description for the driver in order to ensure
consistent naming.
So drop the strscpy of the description in drivers. Also remove any
description strings in driver-internal structures since those are
no longer needed.
Signed-off-by: Hans Verkuil
Cc: Antti Palosaari
---
dri
The v4l_fill_fmtdesc() is supposed to be updated whenever a new pixelformat
is added, but a bunch of recently added pixelformats were forgotten.
Update the list.
Also change a few lower case words to upper case to keep the same style.
Signed-off-by: Hans Verkuil
Cc: Laurent Pinchart
---
drive
The V4L2 core sets the format description and flags for the driver in order
to ensure consistent naming.
So drop the strscpy of the description in drivers. Also remove any
description strings in driver-internal structures since those are
no longer needed.
Signed-off-by: Hans Verkuil
Cc: Laurent
The V4L2 core sets the description for the driver in order to ensure
consistent naming.
So drop the strscpy of the description in drivers. Also remove any
description strings in driver-internal structures since those are
no longer needed.
Signed-off-by: Hans Verkuil
---
drivers/media/common/saa
The V4L2 core sets the format description and flags for the driver in order
to ensure consistent naming.
So drop the strscpy of the description in drivers. Also remove any
description strings in driver-internal structures since those are
no longer needed.
Note that bcm2835-camera.c: the formats a
Hi,
On Mon, 2019-06-10 at 10:52 +0200, Boris Brezillon wrote:
> Looks like some stateless decoders expect slices to be prefixed with
> ANNEX B start codes (they most likely do some kind of bitstream parsing
> and/or need that to delimit slices when doing per frame decoding).
> Since skipping those
Hi Mauro,
These are the last changes for v5.3, I think.
Thanks,
Sean
The following changes since commit 86d617d6c79d79288ca608b6fb0a2467b0e8ddbb:
media: MAINTAINERS: Add maintainers for Media Controller (2019-06-24 15:07:51
-0400)
are available in the Git repository at:
git://linuxtv.org
iHi Hans,
On Wed, Jun 26, 2019 at 09:44:17AM +0200, Hans Verkuil wrote:
> Instead of filling in the struct v4l2_capability device_caps
> field, fill in the struct video_device device_caps field.
>
> That way the V4L2 core knows what the capabilities of the
> video device are.
>
> Signed-off-by: Ha
Hi Dongchun,
On Tue, Jun 11, 2019 at 10:09:49PM +0800, Dongchun Zhu wrote:
...
> > > + return -EINVAL;
> > > +
> > > + fse->code = MEDIA_BUS_FMT_SBGGR10_1X10;
> >
> > Instead you need check the caller set this. The frame sizes could be
> > different for different media bus formats.
> >
>
The priv field of struct v4l2_pix_format shouldn't be set by drivers,
it's set by the v4l2 core instead to V4L2_PIX_FMT_PRIV_MAGIC.
Drop this from the few media drivers that still do this.
Note that the gspca patch is slightly more involved since some of the
sub-gspca drivers use the priv field i
This driver set the colorspace to SRGB, but that makes no sense for
a touchscreen. Use RAW instead. This also ensures consistency with the
v4l_pix_format_touch() call that's used in v4l2-ioctl.c.
Signed-off-by: Hans Verkuil
---
Dmitry, do you want to take this, or shall I? I have no preference.
-
The function v4l_pix_format_touch() is called for S_FMT to set
v4l2_pix_format fields to default values for a v4l-touch device,
but it wasn't called for TRY_FMT. Add this.
Signed-off-by: Hans Verkuil
---
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c
b/drivers/media/v4l2-core/v4l2-ioctl.c
ind
Hi Hans,
Thank you for the patch.
On Wed, Jun 26, 2019 at 09:44:16AM +0200, Hans Verkuil wrote:
> Instead of filling in the struct v4l2_capability device_caps
> field, fill in the struct video_device device_caps field.
>
> That way the V4L2 core knows what the capabilities of the
> video device
Hi Hans,
Thank you for the patch.
On Wed, Jun 26, 2019 at 09:44:21AM +0200, Hans Verkuil wrote:
> Instead of filling in the struct v4l2_capability device_caps
> field, fill in the struct video_device device_caps field.
>
> That way the V4L2 core knows what the capabilities of the
> video device
Hi Hans,
Thank you for the patch.
On Wed, Jun 26, 2019 at 09:44:18AM +0200, Hans Verkuil wrote:
> Instead of filling in the struct v4l2_capability device_caps
> field, fill in the struct video_device device_caps field.
>
> That way the V4L2 core knows what the capabilities of the
> video device
Hi Andrey,
Here is a quick review of this staging V4L2 driver, and some additional notes
for testing at the end:
> // SPDX-License-Identifier: GPL-2.0
> /*
> * video.c - V4L2 component for Mostcore
> *
> * Copyright (C) 2015, Microchip Technology Germany II GmbH & Co. KG
> */
>
> #define pr_
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.
That way the V4L2 core knows what the capabilities of the
video device are.
Signed-off-by: Hans Verkuil
---
Hi Andrey,
I noticed this new staging V4L2 driver. FYI, please CC an
On 6/26/19 10:19 AM, Greg Kroah-Hartman wrote:
> On Wed, Jun 26, 2019 at 09:52:49AM +0200, Hans Verkuil wrote:
>> Instead of filling in the struct v4l2_capability device_caps
>> field, fill in the struct video_device device_caps field.
>>
>> That way the V4L2 core knows what the capabilities of the
On Wed, Jun 26, 2019 at 09:52:49AM +0200, Hans Verkuil wrote:
> Instead of filling in the struct v4l2_capability device_caps
> field, fill in the struct video_device device_caps field.
>
> That way the V4L2 core knows what the capabilities of the
> video device are.
>
> Signed-off-by: Hans Verkui
Hi Hans,
Thank you for the patch.
On 26/06/2019 9:44 AM, Hans Verkuil wrote:
> Instead of filling in the struct v4l2_capability device_caps
> field, fill in the struct video_device device_caps field.
>
> That way the V4L2 core knows what the capabilities of the
> video device are.
>
> Signed-of
Hi Ezequiel,
Thank you for the patch.
On Tue, Jun 25, 2019 at 05:39:45PM -0300, Ezequiel Garcia wrote:
> Not all sensors will be able to guarantee a proper initial state.
> This may be either because the driver is not properly written,
> or (probably unlikely) because the hardware won't support i
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.
That way the V4L2 core knows what the capabilities of the
video device are.
Signed-off-by: Hans Verkuil
---
Hi Andrey,
I noticed this new staging V4L2 driver. FYI, please CC an
On Wed, 2019-06-26 at 09:44 +0200, Hans Verkuil wrote:
> Instead of filling in the struct v4l2_capability device_caps
> field, fill in the struct video_device device_caps field.
>
> That way the V4L2 core knows what the capabilities of the
> video device are.
>
> Signed-off-by: Hans Verkuil
> Cc
On Tue, 2019-06-25 at 17:39 -0300, Ezequiel Garcia wrote:
> Not all sensors will be able to guarantee a proper initial state.
> This may be either because the driver is not properly written,
> or (probably unlikely) because the hardware won't support it.
>
> While the right solution in the former
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.
That way the V4L2 core knows what the capabilities of the
video device are.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/m2m-deinterlace.c | 10 +-
1 file cha
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.
That way the V4L2 core knows what the capabilities of the
video device are.
Signed-off-by: Hans Verkuil
Cc: Laurent Pinchart
---
drivers/media/platform/omap3isp/ispvideo.c | 1
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.
That way the V4L2 core knows what the capabilities of the
video device are.
Signed-off-by: Hans Verkuil
Cc: Benoit Parrot
---
drivers/media/platform/ti-vpe/cal.c | 5 ++---
1
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.
That way the V4L2 core knows what the capabilities of the
video device are.
But this only really works if all drivers use this, so convert
all platform drivers in this patch seri
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.
That way the V4L2 core knows what the capabilities of the
video device are.
Signed-off-by: Hans Verkuil
Cc: Philipp Zabel
---
drivers/media/platform/coda/coda-common.c | 4 +--
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.
That way the V4L2 core knows what the capabilities of the
video device are.
Signed-off-by: Hans Verkuil
Cc: prabhakar.cse...@gmail.com
---
drivers/media/platform/am437x/am437x-
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.
That way the V4L2 core knows what the capabilities of the
video device are.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/omap/omap_vout.c | 6 ++
1 file changed,
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.
That way the V4L2 core knows what the capabilities of the
video device are.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/fsl-viu.c | 7 ++-
1 file changed, 2 inse
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.
That way the V4L2 core knows what the capabilities of the
video device are.
Signed-off-by: Hans Verkuil
Cc: Jonathan Corbet
---
drivers/media/platform/marvell-ccic/mcam-core.c
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.
That way the V4L2 core knows what the capabilities of the
video device are.
Signed-off-by: Hans Verkuil
Cc: Sylwester Nawrocki
---
drivers/media/platform/s3c-camif/camif-captu
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.
That way the V4L2 core knows what the capabilities of the
video device are.
Signed-off-by: Hans Verkuil
Cc: Laurent Pinchart
---
drivers/media/platform/vsp1/vsp1_histo.c | 3
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.
That way the V4L2 core knows what the capabilities of the
video device are.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/mx2_emmaprp.c | 3 +--
1 file changed, 1 inse
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.
That way the V4L2 core knows what the capabilities of the
video device are.
Signed-off-by: Hans Verkuil
Cc: Laurent Pinchart
---
drivers/media/platform/xilinx/xilinx-dma.c | 1
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.
That way the V4L2 core knows what the capabilities of the
video device are.
Signed-off-by: Hans Verkuil
Cc: Jonathan Corbet
---
drivers/media/platform/via-camera.c | 5 ++---
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.
That way the V4L2 core knows what the capabilities of the
video device are.
Signed-off-by: Hans Verkuil
Cc: Jacopo Mondi
---
drivers/media/platform/sh_veu.c | 4 +---
drivers/
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.
That way the V4L2 core knows what the capabilities of the
video device are.
Signed-off-by: Hans Verkuil
Cc: Fabien Dessenne
---
drivers/media/platform/sti/bdisp/bdisp-v4l2.c |
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.
That way the V4L2 core knows what the capabilities of the
video device are.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/pxa_camera.c | 3 ---
1 file changed, 3 delet
67 matches
Mail list logo
