Re: [PATCH v2] media: v4l: ctrls: Add debug messages

2019-06-21 Thread Hans Verkuil
On 6/22/19 12:50 AM, Ezequiel Garcia wrote: > Currently, the v4l2 control code is a bit silent on errors. > Add debug messages on (hopefully) most of the error paths. > > Signed-off-by: Ezequiel Garcia > --- > Changes from v1: > * Drop changes in the debug parameter semantics. > * Drop new module

Re: [PATCH] media: hantro: Use vb2_get_buffer

2019-06-21 Thread kbuild test robot
Hi Ezequiel, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on next-20190621] [cannot apply to v5.2-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url

[PATCH v2] media: v4l: ctrls: Add debug messages

2019-06-21 Thread Ezequiel Garcia
Currently, the v4l2 control code is a bit silent on errors. Add debug messages on (hopefully) most of the error paths. Signed-off-by: Ezequiel Garcia --- Changes from v1: * Drop changes in the debug parameter semantics. * Drop new module debug parameter. * Add documentation. * Add a debug error i

Re: [PATCH] media: hantro: Use vb2_get_buffer

2019-06-21 Thread kbuild test robot
Hi Ezequiel, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on next-20190621] [cannot apply to v5.2-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [PATCH v2 2/9] v4l2-async: Use endpoint node, not device node, for fwnode match

2019-06-21 Thread Niklas Söderlund
Hi Jacopo, On 2019-06-21 11:19:27 +0200, Jacopo Mondi wrote: > Hi Niklas, > > On Fri, Jun 14, 2019 at 11:21:05PM +0200, Niklas Söderlund wrote: > > Hi Sakari, > > > > Thanks for your work and sorry that I missed this and replied to v1 the > > other day. I have tested v2 now and unfortunately it s

Re: Remote "Mouse mode" buttons, Keycode choices, etc.

2019-06-21 Thread Bastien Nocera
On Sun, 2019-06-16 at 18:58 +0200, Pavel Machek wrote: > Hi! > > > I dug out a fair bunch of remote controls I got around 10 years > > ago[1], > > and started trying them all out. > > > > I bumped into a couple of problems: > > > > - the Snapstream Firefly remote ([2] using the rc-snapstream- >

Re: [PATCH v2 2/9] v4l2-async: Use endpoint node, not device node, for fwnode match

2019-06-21 Thread Jacopo Mondi
Hi Niklas, On Fri, Jun 14, 2019 at 11:21:05PM +0200, Niklas Söderlund wrote: > Hi Sakari, > > Thanks for your work and sorry that I missed this and replied to v1 the > other day. I have tested v2 now and unfortunately it still breaks > rcar-vin, see bellow :-( > > On 2019-06-06 16:02:18 +0300, Sak