Re: hdpvr mutex deadlock on kernel 5.1.x

2019-06-20 Thread Keith Pyle
On 06/20/19 06:33, Hans Verkuil wrote: On 6/19/19 4:29 AM, Keith Pyle wrote: On 06/18/19 02:16, Hans Verkuil wrote: Hi Keith, On 6/18/19 6:17 AM, Keith Pyle wrote: We made the suggested change, compiled, installed, and rebooted. There was some progress - test 2 (turning the HD-PVR off) no lo

Re: [PATCH] hdpvr: fix locking and a missing msleep

2019-06-20 Thread Keith Pyle
On 06/20/19 06:43, Hans Verkuil wrote: This driver has three locking issues: - The wait_event_interruptible() condition calls hdpvr_get_next_buffer(dev) which uses a mutex, which is not allowed. Rewrite with list_empty_careful() that doesn't need locking. - In hdpvr_read() the call to hdp

Re: [PATCH 1/1] MAINTAINERS: Add maintainers for Media Controller

2019-06-20 Thread Hans Verkuil
On 6/20/19 4:17 PM, Sakari Ailus wrote: > When Media Controller was merged to mainline long, long time ago, no-one > bothered to think what its MAINTAINERS entry should be. Now that Media > Controller is moved into its own directory, address this at the same time. > > So tell people to mail patche

Re: [PATCH 1/1] MAINTAINERS: Add maintainers for Media Controller

2019-06-20 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Thu, Jun 20, 2019 at 05:17:53PM +0300, Sakari Ailus wrote: > When Media Controller was merged to mainline long, long time ago, no-one > bothered to think what its MAINTAINERS entry should be. Now that Media > Controller is moved into its own directory, addre

[PATCH 1/1] MAINTAINERS: Add maintainers for Media Controller

2019-06-20 Thread Sakari Ailus
When Media Controller was merged to mainline long, long time ago, no-one bothered to think what its MAINTAINERS entry should be. Now that Media Controller is moved into its own directory, address this at the same time. So tell people to mail patches to myself and Laurent Pinchart. Note that the p

[PATCH] hdpvr: fix locking and a missing msleep

2019-06-20 Thread Hans Verkuil
This driver has three locking issues: - The wait_event_interruptible() condition calls hdpvr_get_next_buffer(dev) which uses a mutex, which is not allowed. Rewrite with list_empty_careful() that doesn't need locking. - In hdpvr_read() the call to hdpvr_stop_streaming() didn't lock io_mutex,

Re: hdpvr mutex deadlock on kernel 5.1.x

2019-06-20 Thread Hans Verkuil
On 6/19/19 4:29 AM, Keith Pyle wrote: > On 06/18/19 02:16, Hans Verkuil wrote: >> Hi Keith, >> >> On 6/18/19 6:17 AM, Keith Pyle wrote: >>> We made the suggested change, compiled, installed, and rebooted. There was >>> some progress - test 2 (turning the HD-PVR off) no longer produces a splat.  >>

Re: [PATCH 1/2] mt9m111: No need to check for the regulator

2019-06-20 Thread Marco Felsch
Hi Sakari, On 19-06-18 14:59, Sakari Ailus wrote: > The regulator_get() function returns a regulator when it succeeds. There's > no need to check whether the regulator is NULL later on. > > Signed-off-by: Sakari Ailus > --- > drivers/media/i2c/mt9m111.c | 11 --- > 1 file changed, 4 ins

Re: [PATCH 2/2] mt9m111: Fix error handling in mt9m111_power_on

2019-06-20 Thread Marco Felsch
Hi Sakari, On 19-06-18 14:59, Sakari Ailus wrote: > The mt9m111_power_on function did not properly clean up whenever it > encountered an error. Do that now. > > Signed-off-by: Sakari Ailus > --- > drivers/media/i2c/mt9m111.c | 18 +- > 1 file changed, 13 insertions(+), 5 deletio

Re: [PATCH] media: ov5640: add support of V4L2_CID_LINK_FREQ

2019-06-20 Thread Hans Verkuil
On 6/17/19 3:47 PM, Hugues Fruchet wrote: > Add support of V4L2_CID_LINK_FREQ, this is needed > by some CSI-2 receivers. > > 384MHz is exposed for the time being, corresponding > to 96MHz pixel clock with 2 bytes per pixel on 2 data lanes. > > This setup has been tested successfully with ST MIPID

Ersättningsanmälan

2019-06-20 Thread Microsoft©
grattis! Din e-postadress kom upp i ett globalt slumpmässigt integrerat system, tecknar i ett gemensamt möte som hålls av Microsoft-styrelsen, med Word Bank Group Senate Committee på utlandsskuldavstämnings- och genomförandepanel om ersättning / belöningsfond enligt Microsoft Corporation ersätt