Re: [PATCH RFC 5/6] media: cedrus: Make the slice_params array size limitation more explicit

2019-06-05 Thread Boris Brezillon
On Wed, 05 Jun 2019 23:01:37 +0200 Paul Kocialkowski wrote: > Hi, > > Le mardi 04 juin 2019 à 10:31 -0400, Nicolas Dufresne a écrit : > > Le mardi 04 juin 2019 à 10:12 +0200, Thierry Reding a écrit : > > > On Mon, Jun 03, 2019 at 07:55:48PM -0400, Nicolas Dufresne wrote: > > > > Le lundi 03

Re: [PATCH RFC 4/6] media: cedrus: Prepare things to support !compound controls

2019-06-05 Thread Boris Brezillon
On Wed, 05 Jun 2019 22:57:21 +0200 Paul Kocialkowski wrote: > Hi, > > Le lundi 03 juin 2019 à 13:09 +0200, Boris Brezillon a écrit : > > We are about to add a menu control, so let's make the code more generic > > to support other control types. > > Did you have a chance to test this or should

Re: [PATCH RFC 2/6] media: uapi: h264: Add the concept of decoding mode

2019-06-05 Thread Boris Brezillon
On Wed, 05 Jun 2019 22:48:08 +0200 Paul Kocialkowski wrote: > Hi, > > Le mardi 04 juin 2019 à 10:16 +0200, Thierry Reding a écrit : > > On Mon, Jun 03, 2019 at 05:37:11PM +0200, Boris Brezillon wrote: > > > On Mon, 3 Jun 2019 16:05:26 +0200 > > > Thierry Reding wrote: > > > > > > > On Mon,

Re: [PATCH] media: v4l2: Fix the _MPLANE format check in v4l_enum_fmt()

2019-06-05 Thread Boris Brezillon
On Thu, 6 Jun 2019 12:53:57 +0900 Tomasz Figa wrote: > On Thu, Jun 6, 2019 at 1:46 AM Boris Brezillon > wrote: > > > > CAP_M2M_MPLANE means the device supports _MPLANE formats for both > > capture and output. Adjust the check to avoid EINVAL errors on > > such devices. > > > > Fixes: 366c719d647

cron job: media_tree daily build: OK

2019-06-05 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Jun 6 05:00:11 CEST 2019 media-tree git hash:edadd68031e5b7c1ba0c413a9549dce62a02844c media_build gi

Re: [PATCH] media: v4l2: Fix the _MPLANE format check in v4l_enum_fmt()

2019-06-05 Thread Tomasz Figa
On Thu, Jun 6, 2019 at 1:46 AM Boris Brezillon wrote: > > CAP_M2M_MPLANE means the device supports _MPLANE formats for both > capture and output. Adjust the check to avoid EINVAL errors on > such devices. > > Fixes: 366c719d6479 ("media: v4l2: Get rid of > ->vidioc_enum_fmt_vid_{cap,out}_mplane")

RE: [v8] media: imx: add mem2mem device

2019-06-05 Thread Robin Gong
q.bin in your ramfs(seems you used)? > Crash log: > > [0.00] Booting Linux on physical CPU 0x0 > [0.00] Linux version > 5.2.0-rc3-next-20190605-00042-g1a0686c7a5d2 (sva@svens-asus) (gcc > version 7.3.1 20180425 [linaro-7.3-2018.05 revision > d29120a424ecfbc167ef90065

Re: [PATCH] Revert "media: staging/imx: Allow driver to build if COMPILE_TEST is enabled"

2019-06-05 Thread Randy Dunlap
On 6/5/19 1:53 PM, Fabio Estevam wrote: > Commit 020bc7354a6e ("media: staging/imx: Allow driver to build > if COMPILE_TEST is enabled") incorrectly assumed that the imx media > driver had no build time dependency with IMX_IPUV3_CORE. > > Building on x86_64 without IMX_IPUV3_CORE causes lots of bu

Re: [PATCH v3 10/10] media: aspeed: add a workaround to fix a silicon bug

2019-06-05 Thread Jae Hyun Yoo
Hi Eddie, All patches in this series were queued to linux/media tree except this one. Can you please review this patch? Thanks, Jae On 5/31/2019 3:15 PM, Jae Hyun Yoo wrote: AST2500 silicon revision A1 and A2 have a silicon bug which causes extremly long capturing time on specific resolutions

Re: [PATCH RFC 5/6] media: cedrus: Make the slice_params array size limitation more explicit

2019-06-05 Thread Paul Kocialkowski
Hi, Le mardi 04 juin 2019 à 10:31 -0400, Nicolas Dufresne a écrit : > Le mardi 04 juin 2019 à 10:12 +0200, Thierry Reding a écrit : > > On Mon, Jun 03, 2019 at 07:55:48PM -0400, Nicolas Dufresne wrote: > > > Le lundi 03 juin 2019 à 23:48 +0200, Jernej Škrabec a écrit : > > > > Dne ponedeljek, 03.

Re: [PATCH RFC 4/6] media: cedrus: Prepare things to support !compound controls

2019-06-05 Thread Paul Kocialkowski
Hi, Le lundi 03 juin 2019 à 13:09 +0200, Boris Brezillon a écrit : > We are about to add a menu control, so let's make the code more generic > to support other control types. Did you have a chance to test this or should I better give it a spin before adding my Reviewed-By? Cheers, Paul > Signe

Re: [PATCH RFC 2/6] media: uapi: h264: Add the concept of decoding mode

2019-06-05 Thread Paul Kocialkowski
Hi, Le lundi 03 juin 2019 à 13:09 +0200, Boris Brezillon a écrit : > Some stateless decoders don't support per-slice decoding (or at least > not in a way that would make them efficient or easy to use). > Let's expose a menu to control and expose the supported decoding modes. > Drivers are allowed

[PATCH] Revert "media: staging/imx: Allow driver to build if COMPILE_TEST is enabled"

2019-06-05 Thread Fabio Estevam
Commit 020bc7354a6e ("media: staging/imx: Allow driver to build if COMPILE_TEST is enabled") incorrectly assumed that the imx media driver had no build time dependency with IMX_IPUV3_CORE. Building on x86_64 without IMX_IPUV3_CORE causes lots of build errors such as: ld: drivers/staging/media/imx

[PATCH v7 4/4] pvrusb2: Add Hauppauge HVR1955/1975 devices

2019-06-05 Thread Brad Love
Includes support to identify and use two Hauppauge device. HVR-1955: - LGDT3306a ATSC/QAM demod - si2177 tuner - cx25840 decoder for analog tv/composite/s-video/audio HVR-1975 dual-frontend: - LGDT3306a ATSC/QAM demod - si2168 DVB-C/T/T2 demod - si2177 tuner - cx25840 decoder for analog tv/composi

Re: [PATCH RFC 2/6] media: uapi: h264: Add the concept of decoding mode

2019-06-05 Thread Paul Kocialkowski
Hi, Le mardi 04 juin 2019 à 10:16 +0200, Thierry Reding a écrit : > On Mon, Jun 03, 2019 at 05:37:11PM +0200, Boris Brezillon wrote: > > On Mon, 3 Jun 2019 16:05:26 +0200 > > Thierry Reding wrote: > > > > > On Mon, Jun 03, 2019 at 02:51:13PM +0200, Boris Brezillon wrote: > > > > +Maxime > > > >

Re: [PATCH 7/7] staging/media: set device_caps in struct video_device

2019-06-05 Thread Lad, Prabhakar
Hi Hans, Thanks for the patch. On Tue, Jun 4, 2019 at 12:22 PM Hans Verkuil wrote: > > From 5e271dce24e2a0e3bad026fff4f8d7485d97aa71 Mon Sep 17 00:00:00 2001 > From: Hans Verkuil > Date: Tue, 4 Jun 2019 11:39:41 +0200 > Subject: [PATCH 7/7] staging/media: set device_caps in struct video_device

Re: [RFC 1/1] v4l2-subdev: Rework subdev format and selection macros to work without MC

2019-06-05 Thread Janusz Krzysztofik
Hi Sakari, On Tuesday, June 4, 2019 7:57:31 PM CEST Sakari Ailus wrote: > Rework the macros for accessing subdev try formats to work meaningfully > and relatively safely without V4L2 sub-device uAPI (and without MC). This > is done by simply reverting to accessing the pad number zero if > CONFIG_V

[PATCH] media: coda: Use devm_platform_ioremap_resource()

2019-06-05 Thread Fabio Estevam
Use devm_platform_ioremap_resource() to simplify the code a bit. Signed-off-by: Fabio Estevam --- drivers/media/platform/coda/coda-common.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.

[PATCH] media: add SPDX headers to some files

2019-06-05 Thread Mauro Carvalho Chehab
Add SPDX headers and fix MODULE_LICENSE() when needed on some files I co-authored. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/tda7432.c | 4 +++- drivers/media/pci/bt8xx/bttv-audio-hook.c | 3 ++- drivers/media/pci/bt8xx/bttv-audio-hook.h | 2 ++ driv

[PATCH] media: v4l2: Fix the _MPLANE format check in v4l_enum_fmt()

2019-06-05 Thread Boris Brezillon
CAP_M2M_MPLANE means the device supports _MPLANE formats for both capture and output. Adjust the check to avoid EINVAL errors on such devices. Fixes: 366c719d6479 ("media: v4l2: Get rid of ->vidioc_enum_fmt_vid_{cap,out}_mplane") Reported-by: Maxime Jourdan Signed-off-by: Boris Brezillon --- d

[GIT PULL FOR v5.3] More fixes/improvements

2019-06-05 Thread Hans Verkuil
Hi Mauro, More fixes/improvements. Jae Hyun Yoo, Eddie: I've merged the first 9 patches of the aspeed series, but left out the last one since it wasn't reviewed by Eddie yet. Once that is reviewed as well I'll pick it up in a later PR. Regards, Hans The following changes since commit

[PATCH 1/2] Documentation: update email address

2019-06-05 Thread Hans Verkuil
Use hverkuil-ci...@xs4all.nl instead of hans.verk...@cisco.com. Signed-off-by: Hans Verkuil --- Documentation/ABI/testing/debugfs-cec-error-inj | 2 +- Documentation/media/uapi/cec/cec-api.rst| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/ABI/testing

[PATCH 2/2] MAINTAINERS: update email address

2019-06-05 Thread Hans Verkuil
Use hverkuil-ci...@xs4all.nl instead of hans.verk...@cisco.com. Signed-off-by: Hans Verkuil --- MAINTAINERS | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index b8fbf41865c2..16a97ba91874 100644 --- a/MAINTAINERS +++ b/MAINTAI

USB drives with logos

2019-06-05 Thread Stacy
Hi, I wanted to follow up from last week. Did you receive the email I sent you? Our company manufactures USB Flash Drives, printed with your logo. They make the perfect marketing tool for your business or organization. We offer low minimum quantities, and all memory sizes. Over 150 Stock Model

Re: [v8] media: imx: add mem2mem device

2019-06-05 Thread Sven Van Asbroeck
m. Crash log: [0.00] Booting Linux on physical CPU 0x0 [0.00] Linux version 5.2.0-rc3-next-20190605-00042-g1a0686c7a5d2 (sva@svens-asus) (gcc version 7.3.1 20180425 [linaro-7.3-2018.05 revision d29120a424ecfbc167ef90065c0eeb7f91977701] (Linaro GCC 7.3-2018.05)) #1 SMP Wed Jun 5

custom printed logo

2019-06-05 Thread Stacy
Hi, I wanted to follow up from last week. Did you receive the email I sent you? Our company manufactures USB Flash Drives, printed with your logo. They make the perfect marketing tool for your business or organization. We offer low minimum quantities, and all memory sizes. Over 150 Stock Model

[GIT PULL FOR v5.3] Various fixes/improvements

2019-06-05 Thread Hans Verkuil
Hi Mauro, Nothing special, except for "media/doc: Allow sizeimage to be set by v4l clients". Please review that again to check if your earlier comments are now all addressed. Also note the cxusb revert patch. That's my fault, I never intended to accept that patch (https://patchwork.linuxtv.org

Re: [GIT PULL FOR v5.3] Drop vidioc_enum_fmt_vid_*_mplane, driver improvements, add codec helpers

2019-06-05 Thread Hans Verkuil
On 6/5/19 1:23 PM, Hans Verkuil wrote: > This pull request drops the vidioc_enum_fmt_vid_{cap, out}_mplane callbacks; > instead just use vidioc_enum_fmt_vid_{cap, out}. Oops, I forgot to mention that patch 'v4l2: Get rid of ->vidioc_enum_fmt_vid_{cap, out}_mplane' generates a false checkpatch mes

Re: [PATCH 1/5] ACPI: Enable driver and firmware hints to control power at probe time

2019-06-05 Thread Sakari Ailus
Hi Rafael, On Fri, May 31, 2019 at 11:17:10AM +0200, Rafael J. Wysocki wrote: > On Friday, May 10, 2019 12:09:26 PM CEST Sakari Ailus wrote: ... > > diff --git a/include/linux/device.h b/include/linux/device.h > > index e85264fb66161..2a459fd5b954a 100644 > > --- a/include/linux/device.h > > +++ b

[PATCH] media: docs: fix minor typos

2019-06-05 Thread Marc Gonzalez
Fix minor typos in the DVB demux documentation. Signed-off-by: Marc Gonzalez --- Documentation/media/kapi/dtv-core.rst | 6 +++--- include/media/dvbdev.h| 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/media/kapi/dtv-core.rst b/Documentation

[GIT PULL FOR v5.3] Drop vidioc_enum_fmt_vid_*_mplane, driver improvements, add codec helpers

2019-06-05 Thread Hans Verkuil
This pull request drops the vidioc_enum_fmt_vid_{cap, out}_mplane callbacks; instead just use vidioc_enum_fmt_vid_{cap, out}. Convert lots of drivers to set device_caps in struct video_device instead of in v4l2_capability: this gives the V4L2 core information about the capabilities of the video de

Re: [PATCH v3 01/10] rockchip/vpu: rename from rockchip to hantro

2019-06-05 Thread Boris Brezillon
On Fri, 31 May 2019 10:55:14 +0200 Philipp Zabel wrote: > Rename the driver and all relevant identifiers from Rockchip to Hantro, > as other Hantro IP based VPU implementations can be supported by the > same driver. > The RK3288 decoder is Hantro G1 based, the encoder is Hantro H1. > > This patc

[PATCH] cxusb: Revert "media: cxusb: add raw mode support for, Medion MD95700"

2019-06-05 Thread Hans Verkuil
This patch shouldn't have been included in the pull request as it adds a non-standard raw mode that is for debugging only. So revert commit ead14a70754f8d7f5dbcb0553c7f11eb0fc4a6ac. Signed-off-by: Hans Verkuil --- drivers/media/usb/dvb-usb/cxusb-analog.c | 190 --- drivers/me

Re: [PATCH v2 2/2] media: v4l2-ctrl: Move compound control initialization

2019-06-05 Thread Hans Verkuil
On 5/30/19 7:19 PM, Ezequiel Garcia wrote: > Rework std_init adding an explicit initialization for > compound controls. > > While here, make sure the control is initialized to zero, > before providing default values for all its fields. > > Signed-off-by: Ezequiel Garcia > -- > Changes from v1: >

Re: [PATCH v2 1/2] media: v4l2-ctrl: Initialize _BUTTON and _CTRL_CLASS

2019-06-05 Thread Hans Verkuil
On 6/1/19 11:05 AM, Boris Brezillon wrote: > On Thu, 30 May 2019 14:19:08 -0300 > Ezequiel Garcia wrote: > >> These two control types don't really need a default value, >> as they are not expected to carry any value. >> >> However, it's slightly clearer to initialize them explicitly >> instead of

Re: [PATCH 3/5] ov5670: Support probe whilst the device is off

2019-06-05 Thread Sakari Ailus
Hi Tomasz, On Wed, Jun 05, 2019 at 04:07:52PM +0900, Tomasz Figa wrote: > Hi Sakari, > > On Fri, May 10, 2019 at 01:09:28PM +0300, Sakari Ailus wrote: > > Tell ACPI device PM code that the driver supports the device being powered > > off when the driver's probe function is entered. > > > > Signe

RE: [v8] media: imx: add mem2mem device

2019-06-05 Thread Robin Gong
Hi Sven, I met below crash on v5.2-rc1 and found it's related with commit 728e0fbf263e, after googled, the latest Linux-next should fix the issue, please check https://lkml.org/lkml/2019/6/3/1405. After I rebased to the latest linux-next, no such issue but still another crash issue aft

Re: [RFC] Documentation clarifications

2019-06-05 Thread Mauro Carvalho Chehab
Em Wed, 5 Jun 2019 10:08:31 +0200 Marc Gonzalez escreveu: > On 04/06/2019 19:26, Mauro Carvalho Chehab wrote: > > > Em Tue, 4 Jun 2019 18:41:44 +0200, Marc Gonzalez escreveu: > > > >> Not sure about these changes, hence the RFC (some are quite trivial) > > > > Looks ok to me. You should su

Re: [RFC] Documentation clarifications

2019-06-05 Thread Marc Gonzalez
On 04/06/2019 19:26, Mauro Carvalho Chehab wrote: > Em Tue, 4 Jun 2019 18:41:44 +0200, Marc Gonzalez escreveu: > >> Not sure about these changes, hence the RFC (some are quite trivial) > > Looks ok to me. You should submit it as a patch, though, with your SOB. I thought that since these were tr

Re: [PATCH 3/5] ov5670: Support probe whilst the device is off

2019-06-05 Thread Tomasz Figa
Hi Sakari, On Fri, May 10, 2019 at 01:09:28PM +0300, Sakari Ailus wrote: > Tell ACPI device PM code that the driver supports the device being powered > off when the driver's probe function is entered. > > Signed-off-by: Sakari Ailus > --- > drivers/media/i2c/ov5670.c | 25 ++