Re: [RFC,V2,07/11] media: platform: Add Mediatek ISP P1 private control

2019-05-13 Thread Jungo Lin
Hi Hans, Thank you for your comments. On Mon, 2019-05-13 at 10:46 +0200, Hans Verkuil wrote: > On 5/10/19 3:58 AM, Jungo Lin wrote: > > Reserved Mediatek ISP P1 private control number with 16. > > Moreover, add two private controls for ISP P1 user space > > usage. > > > > 1. V4L2_CID_PRIVATE_GET

cron job: media_tree daily build: ERRORS

2019-05-13 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue May 14 05:00:11 CEST 2019 media-tree git hash:1199fa8c0ddd34dae6d72b653b27dfb3554e9b57 media_build gi

cx231xx with 3 grabbers

2019-05-13 Thread Tomasz Borowczyk
Hello linux-media. I use cx231xx driver with my August Vgb100 USB video grabber. It works great. It automatically detects my device and I can watch the video from analog camera on my Raspberry Pi, and I am very happy about how it works. But there is a catch. I want to connect 3 such cameras to my

[PATCH v4 4/4] media: vsp1: Provide partition overlap algorithm

2019-05-13 Thread Kieran Bingham
To improve image quality, entities involved within the image partition algorithm may extend their partition window to account for their input requirements and to take consideration of the number of taps in their filters. Extend the partition algorithm to sweep first backwards, then forwards throug

[PATCH v4 1/4] media: vsp1: Define partition algorithm helper

2019-05-13 Thread Kieran Bingham
Provide a helper to describe when the partition algorithm is in use on a given pipeline. This improves readability to the purpose of the code, rather than obtusely checking the number of partitions. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- v4: - Fix periods at the end of

[PATCH v4 0/4] media: vsp1: Phased partition overlap support

2019-05-13 Thread Kieran Bingham
The UDS and SRU (and SHP) require expanded partition windows to support overlapping partition windows as a means of discarding discontinous pixel data, due to repeated pixels in their input filters. The first three patches are clean ups and helpers to facilitate the implementation of an updated pr

[PATCH v4 3/4] media: vsp1: Split out pre-filter calculation

2019-05-13 Thread Kieran Bingham
The 'mp' value is used through several calculations in determining the scaling factors of the UDS. This determines the pre-scaling filter binning value. Factor this out so that it can be reused in further calculations, and also ensure that if the BLADV control is ever changed only a single function

[PATCH v4 2/4] media: vsp1: Document partition algorithm in code header

2019-05-13 Thread Kieran Bingham
The image partition algorithm operates on the image dimensions as input into the WPF entity. Document this in the code block header. Reviewed-by: Laurent Pinchart Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_video.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v6 0/5] Add ZynqMP VCU/Allegro DVT H.264 encoder driver

2019-05-13 Thread Michael Tretter
This is v6 of the Allegro DVT H.264 encoder driver found in the EV family of the Xilinx ZynqMP platform. Only minor changes this time. I dropped the implementation of the selection api, removed all references mentioning the decoder, and fixed a few issues reported by sparse and smatch. The v4l2-c

[PATCH v6 1/5] videobuf2-v4l2: set last_buffer_dequeued in dqbuf

2019-05-13 Thread Michael Tretter
From: Hans Verkuil last_buffer_dequeued was set to true in __fill_v4l2_buffer, but this is called for qbuf as well. Move it to vb2_dqbuf. Signed-off-by: Hans Verkuil --- drivers/media/common/videobuf2/videobuf2-v4l2.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v6 2/5] media: dt-bindings: media: document allegro-dvt bindings

2019-05-13 Thread Michael Tretter
Add device-tree bindings for the Allegro DVT video IP core found on the Xilinx ZynqMP EV family. Signed-off-by: Michael Tretter Reviewed-by: Rob Herring --- v5 -> v6: none v4 -> v5: none v3 -> v4: none v2 -> v3: - rename node to video-codec - drop interrupt-names - fix compatible in example -

[PATCH v6 5/5] [media] allegro: add SPS/PPS nal unit writer

2019-05-13 Thread Michael Tretter
The allegro hardware encoder does not write SPS/PPS nal units into the encoded video stream. Therefore, we need to write the units in software. The implementation follows Rec. ITU-T H.264 (04/2017) to allow to convert between a C struct and the RBSP representation of the SPS and PPS nal units. Th

[PATCH v6 4/5] [media] allegro: add Allegro DVT video IP core driver

2019-05-13 Thread Michael Tretter
Add a V4L2 mem-to-mem driver for Allegro DVT video IP cores as found in the EV family of the Xilinx ZynqMP SoC. The Zynq UltraScale+ Device Technical Reference Manual uses the term VCU (Video Codec Unit) for the encoder, decoder and system integration block. This driver takes care of interacting w

[PATCH v6 3/5] media: dt-bindings: media: Add vendor prefix for allegro

2019-05-13 Thread Michael Tretter
Add vendor prefix for Allegro DVT, a provider of H.264/AVC, H.265/HEVC, AVS2, VP9 and AV1 compliance test suites and H.264/AVC, H.265/HEVC, and VP9 encoder, codec and decoder hardware (RTL) IPs. Signed-off-by: Michael Tretter Reviewed-by: Rob Herring --- v5 -> v6: none v5: - new patch --- Docu

Re: [RFC PATCH] vb2: add V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF

2019-05-13 Thread Nicolas Dufresne
Le lundi 13 mai 2019 à 11:36 +0200, Hans Verkuil a écrit : > On 4/30/19 10:31 AM, Hans Verkuil wrote: > > This RFC patch adds support for the V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF flag. > > It also adds a new V4L2_BUF_CAP_SUPPORTS_M2M_HOLD_CAPTURE_BUF capability and > > a v4l2_m2m_release_capture_buf(

Re: [PATCH v3 5/5] media: vsp1: Provide partition overlap algorithm

2019-05-13 Thread Kieran Bingham
Hi Laurent, On 18/04/2019 13:42, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thu, Apr 11, 2019 at 05:12:56PM +0100, Kieran Bingham wrote: >> To improve image quality, entities involved within the image partition >> algorithm may extend their partition window to accou

Re: [RFC PATCH] vb2: add V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF

2019-05-13 Thread Hans Verkuil
On 4/30/19 10:31 AM, Hans Verkuil wrote: > This RFC patch adds support for the V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF flag. > It also adds a new V4L2_BUF_CAP_SUPPORTS_M2M_HOLD_CAPTURE_BUF capability and > a v4l2_m2m_release_capture_buf() helper function. > > Drivers should set vb2_queue->subsystem_fla

Re: [RFC PATCH V1 0/6] media: platform: Add support for Face Detection (FD) on mt8183 SoC

2019-05-13 Thread Hans Verkuil
On 4/23/19 12:44 PM, Jerry-ch Chen wrote: > Hello, > > This RFC patch series is adding Face Detection (FD) driver on Mediatek > mt8183 SoC. It belongs to the first Mediatek's camera driver series based > on V4L2 and media controller framework. I posted the main part of the FD > driver as RFC to di

Re: [RFC,V2,07/11] media: platform: Add Mediatek ISP P1 private control

2019-05-13 Thread Hans Verkuil
On 5/10/19 3:58 AM, Jungo Lin wrote: > Reserved Mediatek ISP P1 private control number with 16. > Moreover, add two private controls for ISP P1 user space > usage. > > 1. V4L2_CID_PRIVATE_GET_BIN_INFO > - Provide the image output width & height in case > camera binning mode is enabled. > > 2. V4L

Re: [RFC,V2,06/11] media: platform: Add Mediatek ISP P1 image & meta formats

2019-05-13 Thread Hans Verkuil
On 5/10/19 3:57 AM, Jungo Lin wrote: > Add packed/unpacked/full-g bayer format with 8/10/12/14 bit > for image output. Add Pass 1 (P1) specific meta formats for > parameter processing and 3A/other statistics. These pixel formats will need to be documented in Documentation/media/uapi/v4l/pixfmt-.r

Re: [RFC PATCH V2 1/4] media: platform: mtk-isp: Add Mediatek sensor interface driver

2019-05-13 Thread Hans Verkuil
Hi Louis, Some review comments below... On 5/12/19 8:00 AM, Louis Kuo wrote: > This patch adds Mediat:ek's sensor interface driver. Sensor interface driver > is a MIPI-CSI2 host driver, namely, a HW camera interface controller. > It support a widely adopted, simple, high-speed protocol primarily