copy fwht-ctrls.h from the kernel dir when
running 'sync' and add typedef for u64
in codec-fwht.h
Signed-off-by: Dafna Hirschfeld
---
Makefile.am | 1 +
utils/common/codec-fwht.patch | 7 ---
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/Makefile.am b/Makef
Add code to support the stateless decoder
and the function 'stateless_m2m' that implements it.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 234 +-
1 file changed, 231 insertions(+), 3 deletions(-)
diff --git a/utils/v4l2-ctl/v4l2-ctl-strea
Add the variable 'last_fwht_bf_ts' and the array 'fwht_reqs' to
allow the fwht stateless decoder to maintain the requests.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 129 ++
1 file changed, 129 insertions(+)
diff --git a/utils/v4l2-ctl/v4
changes from v4: remove comp_frame_size from fwht params
Dafna Hirschfeld (3):
v4l-utils: copy fwht-ctrls.h from kernel dir
v4l2-ctl: Add functions and variables to support fwht stateless
decoder
v4l2-ctl: Add implementation for the stateless fwht decoder.
Makefile.am
From: YueHaibing
Remove duplicated include.
Signed-off-by: YueHaibing
---
drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c
b/drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c
inde
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Wed Feb 27 05:00:11 CET 2019
media-tree git hash:9fabe1d108ca4755a880de43f751f1c054f8894d
media_build git
From: Greg Hackmann
This patch adds complimentary DMA_BUF_SET_NAME and DMA_BUF_GET_NAME
ioctls, which lets userspace processes attach a free-form name to each
buffer.
This information can be extremely helpful for tracking and accounting
shared buffers. For example, on Android, we know what each
From: Greg Hackmann
The show_fdinfo handler exports the same information available through
debugfs on a per-buffer basis.
Signed-off-by: Greg Hackmann
Signed-off-by: Chenbo Feng
---
drivers/dma-buf/dma-buf.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/dma-buf/
From: Greg Hackmann
By traversing /proc/*/fd and /proc/*/map_files, processes with CAP_ADMIN
can get a lot of fine-grained data about how shmem buffers are shared
among processes. stat(2) on each entry gives the caller a unique
ID (st_ino), the buffer's size (st_size), and even the number of pag
Currently, all dma-bufs share the same anonymous inode. While we can count
how many dma-buf fds or mappings a process has, we can't get the size of
the backing buffers or tell if two entries point to the same dma-buf. And
in debugfs, we can get a per-buffer breakdown of size and reference count,
bu
The fixes included in this commit essentially removes NULL pointer
checks on the return values of function `get_queue_ctx` as well as
`v4l2_m2m_get_vq` defined in file v4l2-mem2mem.c.
Function `get_queue_ctx` is very unlikely to return a NULL pointer
because its return value is an address composed
On Tue, 26 Feb 2019, Thomas Voegtle wrote:
Hello,
I have a
03:00.0 Multimedia video controller [0400]: Conexant Systems, Inc.
CX23887/8 PCIe Broadcast Audio and Video Decoder with 3D Comb [14f1:8880]
(rev 04)
Subsystem: Hauppauge computer works Inc. Device [0070:c138]
Kernel dr
Hi Daniel,
Thanks for the comment.
On Tue, 2019-02-26 at 04:06:13 -0800, Daniel Vetter wrote:
> On Tue, Feb 26, 2019 at 12:53 PM Greg Kroah-Hartman
> wrote:
> >
> > On Sat, Feb 23, 2019 at 12:28:17PM -0800, Hyun Kwon wrote:
> > > Add the dmabuf map / unmap interfaces. This allows the user driver
Hi Greg,
Thanks for the comments.
On Tue, 2019-02-26 at 03:53:11 -0800, Greg Kroah-Hartman wrote:
> On Sat, Feb 23, 2019 at 12:28:17PM -0800, Hyun Kwon wrote:
> > Add the dmabuf map / unmap interfaces. This allows the user driver
> > to be able to import the external dmabuf and use it from user s
As we do alignments for width, expose it via V4L2 API.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/platform/vim2m.c | 38 ++
1 file changed, 29 insertions(+), 9 deletions(-)
diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c
i
copy fwht-ctrls.h from the kernel dir when
running 'sync' and add typedef for u64
in codec-fwht.h
Signed-off-by: Dafna Hirschfeld
---
Makefile.am | 1 +
utils/common/codec-fwht.patch | 7 ---
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/Makefile.am b/Makef
Add code to support the stateless decoder
and the function 'stateless_m2m' that implements it.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 234 +-
1 file changed, 231 insertions(+), 3 deletions(-)
diff --git a/utils/v4l2-ctl/v4l2-ctl-strea
Add the variable 'last_fwht_bf_ts' and the array 'fwht_reqs' to
allow the fwht stateless decoder to maintain the requests.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 130 ++
1 file changed, 130 insertions(+)
diff --git a/utils/v4l2-ctl/v4
Hello,
I have a
03:00.0 Multimedia video controller [0400]: Conexant Systems, Inc.
CX23887/8 PCIe Broadcast Audio and Video Decoder with 3D Comb [14f1:8880]
(rev 04)
Subsystem: Hauppauge computer works Inc. Device [0070:c138]
Kernel driver in use: cx23885
on linux 5.0.0-rc8.
In
The copy logic assumes that the data width is multiple of two,
as this is needed in order to support YUYV.
There's no reason to force it to be 8-pixel aligned, as 2-pixel
alignment is enough.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/platform/vim2m.c | 2 +-
1 file changed, 1 inser
Em Tue, 26 Feb 2019 14:36:55 -0300
Mauro Carvalho Chehab escreveu:
> The copy logic assumes that the data width is multiple of two,
> as this is needed in order to support YUYV.
Please ignore this one. The driver already aligns (it enforces
an 8 pixels alignment... 2 pixels should be enough).
>
1) Use two levels for debug:
- level 1: setup stuff
- level 2: add queue/dequeue messages
2) Better display the debug output, translating buffer
type, fourcc and making some messages clearer.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/platform/vim2m.c | 44 +++
The copy logic assumes that the data width is multiple of two,
as this is needed in order to support YUYV.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/platform/vim2m.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/vim2m.c b/drivers/media/pl
The vim2m driver doesn't enforce that the capture and output
buffers would have the same size. Do the right thing if the
buffers are different, zeroing the buffer before writing,
ensuring that lines will be aligned and it won't write past
the buffer area.
Signed-off-by: Mauro Carvalho Chehab
---
add documentation to V4L2_CID_MPEG_VIDEO_FWHT_PARAMS
control and its related 'v4l2_ctrl_fwht_params' struct
Signed-off-by: Dafna Hirschfeld
---
.../media/uapi/v4l/ext-ctrls-codec.rst| 119 ++
1 file changed, 119 insertions(+)
diff --git a/Documentation/media/uapi/v4l/ext
The selection api should check only single buffer types
because multiplanar types are converted to
single in drivers/media/v4l2-core/v4l2-ioctl.c
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 20 +++
1 file changed, 3 insertions(+), 17 deleti
add documentation to V4L2_CID_FWHT_I/P_FRAME_QP
controls in ext-ctrls-codec.rst
Signed-off-by: Dafna Hirschfeld
---
Documentation/media/uapi/v4l/ext-ctrls-codec.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst
b/Documentation/
Move the code that validates version dependent header
values to a separate function 'validate_by_version'
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 31 ---
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/media/plat
Add structs and definitions needed to implement stateless
decoder for fwht and add I/P-frames QP controls to the
public api.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 41 ++-
drivers/media/v4l2-core/v4l2-ctrls.c | 12 ++
incl
Add the field 'buf' to fwht_raw_frame to indicate
the start of the raw frame buffer.
This field will be used to copy the capture buffer
to the reference buffer in the next patch.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.h | 1 +
drivers/media/platform/vicod
The function 'v4l2_m2m_buf_copy_metadata' should
be called even if decoding/encoding ends with
status VB2_BUF_STATE_ERROR, so that the metadata
is copied from the source buffer to the dest buffer.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 17 +---
In the decoder, save the inner reference frame in the same
format as the capture buffer.
The decoder writes directly to the capture buffer and then
the capture buffer is copied to the reference buffer.
This will simplify the stateless decoder.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/pl
Add struct 'vicodec_dev_instance' for the fields in vicodec_dev
that have have both decoder and encoder versions.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 194 +-
1 file changed, 92 insertions(+), 102 deletions(-)
diff --git a/drivers/m
If one of the controls fails to set,
then 'v4l2_ctrl_request_setup'
immediately returns with the error code.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/v4l2-core/v4l2-ctrls.c | 18 +++---
include/media/v4l2-ctrls.h | 2 +-
2 files changed, 12 insertions(+), 8 deleti
Introduce 'prepare_raw_frame' function that fills the values
of a raw frame struct according to the format.
Signed-off-by: Dafna Hirschfeld
---
.../media/platform/vicodec/codec-v4l2-fwht.c | 143 ++
1 file changed, 78 insertions(+), 65 deletions(-)
diff --git a/drivers/media/pl
'v4l2_m2m_ctx_release' calls request complete
so it should be called before 'v4l2_ctrl_handler_free'.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/vicodec/vicodec
Rename 'v4l2_fwht_default_fmt' to 'v4l2_fwht_find_nth_fmt'
and add a function 'v4l2_fwht_validate_fmt' to check if
a format info matches the parameters.
This function will also be used to validate the stateless
params when adding support for stateless codecs.
Signed-off-by: Dafna Hirschfeld
---
Free compressed_frame buffer upon device release.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/vicodec/vicodec-core.c
b/drivers/media/platform/vicodec/vicodec-core.c
index 8205a602bb3
add documentation to V4L2_PIX_FMT_FWHT_STATELESS
in pixfmt-compressed.rst
Signed-off-by: Dafna Hirschfeld
---
Documentation/media/uapi/v4l/pixfmt-compressed.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/media/uapi/v4l/pixfmt-compressed.rst
b/Documentation/media/uap
Add stateless decoder instance field to the dev struct and
register another node for the statelsess decoder.
The stateless API for the node will be implemented in further patches.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 46 +--
1 file c
add support to stateless decoder
main changes from v4:
- fixes according to the review.
- documentation for the flags
- removing comp_frame_size from the fwht stateless params
- removing vicodec_ctrl_p/i_frame
Dafna Hirschfeld (18):
media: vicodec: selection api should only check single buffer
v4l2_fwht_encode returns either an error code on
failure or the size of the compressed frame on
success. So change the var assigned to it from
'ret' to 'comp_sz_or_errcode' to clarify that.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 9 +
1 file ch
From: Hans Verkuil
Stateless codecs require the use of the Request API as opposed of it
being optional.
So add a bit to indicate this and let vb2 check for this.
Signed-off-by: Hans Verkuil
---
drivers/media/common/videobuf2/videobuf2-core.c | 5 -
drivers/media/common/videobuf2/videobuf2
From: Hans Verkuil
The cedrus stateless decoder requires the use of request, so
indicate this by setting requires_requests to 1.
Signed-off-by: Hans Verkuil
---
drivers/staging/media/sunxi/cedrus/cedrus_video.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/sunxi/ced
Implement a stateless decoder for the new node.
Signed-off-by: Dafna Hirschfeld
---
.../media/platform/vicodec/codec-v4l2-fwht.h | 1 +
drivers/media/platform/vicodec/vicodec-core.c | 284 --
2 files changed, 261 insertions(+), 24 deletions(-)
diff --git a/drivers/media/platf
From: Hans Verkuil
Add capability to indicate that requests are required instead of
merely supported.
Signed-off-by: Hans Verkuil
---
Documentation/media/uapi/v4l/vidioc-reqbufs.rst | 4
include/uapi/linux/videodev2.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/
When streaming is stopped all URBs are killed, but in fill_frame and in
bulk_irq this results in an attempt to resubmit the killed URB. That is
not what you want and causes spurious kernel messages.
So check if streaming has stopped before resubmitting.
Also check against gspca_dev->streaming rat
On Tue, Feb 26, 2019 at 12:53 PM Greg Kroah-Hartman
wrote:
>
> On Sat, Feb 23, 2019 at 12:28:17PM -0800, Hyun Kwon wrote:
> > Add the dmabuf map / unmap interfaces. This allows the user driver
> > to be able to import the external dmabuf and use it from user space.
> >
> > Signed-off-by: Hyun Kwon
The vim2m driver doesn't enforce that the capture and output
buffers would have the same size. Do the right thing if the
buffers are different, zeroing the buffer before writing,
ensuring that lines will be aligned and it won't write past
the buffer area.
Signed-off-by: Mauro Carvalho Chehab
---
On Sat, Feb 23, 2019 at 12:28:17PM -0800, Hyun Kwon wrote:
> Add the dmabuf map / unmap interfaces. This allows the user driver
> to be able to import the external dmabuf and use it from user space.
>
> Signed-off-by: Hyun Kwon
> ---
> drivers/uio/Makefile | 2 +-
> drivers/uio/uio.c
On 2/25/19 11:22 PM, Dafna Hirschfeld wrote:
> add documentation to V4L2_CID_MPEG_VIDEO_FWHT_PARAMS
> control and it's related 'v4l2_ctrl_fwht_params' struct
it's -> its
>
> Signed-off-by: Dafna Hirschfeld
> ---
> .../media/uapi/v4l/ext-ctrls-codec.rst| 54 +++
> 1 file
On 2/25/19 11:22 PM, Dafna Hirschfeld wrote:
> Add structs and definitions needed to implement stateless
> decoder for fwht.
>
> Signed-off-by: Dafna Hirschfeld
> ---
> drivers/media/platform/vicodec/vicodec-core.c | 23 -
> drivers/media/v4l2-core/v4l2-ctrls.c | 10 ++
>
Hi Alex,
Thanks for the fix, and I'm sorry for the typo.
On 2/26/19 10:17 AM, Alexandre Courbot wrote:
> Patch commit de5a0bafcfc4 ("media: venus: core: correct maximum hardware
> load for sdm845") meant to increase the maximum hardware load for sdm845,
> but ended up changing the one for msm8996
/0day-ci/linux/commits/Shaobo-He/Remove-deductively-redundant-NULL-pointer-checks/20190226-133616
base: git://linuxtv.org/media_tree.git master
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-8 (Debian 8.2.0-20) 8.2.0
reproduce:
# save the attached .config to linux build
Zdravstvujte Vas interesuyut bazy dannyh dlya prodazhi Vashih tovarov i uslug?
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue Feb 26 05:00:11 CET 2019
media-tree git hash:9fabe1d108ca4755a880de43f751f1c054f8894d
media_build git
VAS INTERESUYUT BAZY DANNYKH?
Patch commit de5a0bafcfc4 ("media: venus: core: correct maximum hardware
load for sdm845") meant to increase the maximum hardware load for sdm845,
but ended up changing the one for msm8996 instead.
Fixes: de5a0bafcfc4 ("media: venus: core: correct maximum hardware load for
sdm845")
Signed-off-by
/0day-ci/linux/commits/Shaobo-He/Remove-deductively-redundant-NULL-pointer-checks/20190226-133616
base: git://linuxtv.org/media_tree.git master
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 8.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel
59 matches
Mail list logo
