Re: [PATCH v2 1/1] uvc: Avoid NULL pointer dereference at the end of streaming

2019-01-30 Thread Sakari Ailus
Hi Sasha, On Thu, Jan 31, 2019 at 02:04:48AM +, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 9c0863b1cc48 [media] vb2: call buf_finish from __queue_cancel. > > The bot has tested the followi

[PATCH v3] v4l2-ctl: add function vidcap_get_and_update_fmt

2019-01-30 Thread Dafna Hirschfeld
add a function vidcap_get_and_update_fmt to set the format from cmd params. Use it in capture_setup. Signed-off-by: Dafna Hirschfeld --- Changes from v2: move get_cap_compose_rect to after s_fmt in capture_setup utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 15 ++- utils/v4l2-ctl/v4l2-ctl-vidcap.cpp

cron job: media_tree daily build: OK

2019-01-30 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Jan 31 05:00:10 CET 2019 media-tree git hash:c9d06df612977a88c484668ad0a37bc8e4463b22 media_build git

[PATCH] staging: prefix header search paths with $(srctree)/

2019-01-30 Thread Masahiro Yamada
Currently, the Kbuild core manipulates header search paths in a crazy way [1]. To fix this mess, I want all Makefiles to add explicit $(srctree)/ to the search paths in the srctree. Some Makefiles are already written in that way, but not all. The goal of this work is to make the notation consisten

[PATCH 3/4] [TEST]: rockchip: mpp: support qtable

2019-01-30 Thread ayaka
Yes, the buffer won't be freed. I don't want to store buffers for a session. I just want to use it to verify the FFmpeg. Signed-off-by: ayaka --- drivers/staging/rockchip-mpp/mpp_dev_common.h | 3 ++ drivers/staging/rockchip-mpp/mpp_dev_vdpu2.c | 3 ++ drivers/staging/rockchip-mpp/vdpu2/mpeg2

[PATCH 4/4] staging: video: rockchip: add video codec

2019-01-30 Thread ayaka
From: Randy Li Signed-off-by: Randy Li --- drivers/staging/Kconfig | 2 ++ drivers/staging/Makefile | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig index e4f608815c05..81634dd0a283 100644 --- a/drivers/staging/Kconfig +++ b/drivers/stagin

[PATCH 0/4] WIP: rockchip mpp for v4l2 video decoder

2019-01-30 Thread ayaka
From: Randy 'ayaka' Li Hello Those patches are based on the previous vendor driver I post before, but it can apply without the previous one. I really want to make it work before FOSDEM and I didn't. And upcoming the lunar new year holiday would last two week. I have verified the v4l2 part

[PATCH 2/4] [WIP] staging: video: rockchip: vdpu2

2019-01-30 Thread ayaka
From: Randy 'ayaka' Li It doesn't work yet, I am suffering unknow power or clock problem, but the vendor driver I post to ML would work. I want to put the implementation of those v4l2 ioctl which related to device in echo device's files, but the current inheritance looks ugly. TODO: qp table S

[PATCH 1/4] [WIP]: staging: video: rockchip: add v4l2 common

2019-01-30 Thread ayaka
From: Randy 'ayaka' Li The current version is designed for multi-planes buffers. TODO: improve the interface and work flow of v4l2 finish a task before it would be dequeued Signed-off-by: Randy Li Signed-off-by: Randy Li --- drivers/staging/rockchip-mpp/Kconfig | 54 + drivers/sta

[PATCHv2 7/9] videobuf2/videobuf2-dma-sg.c: Convert to use vm_insert_range

2019-01-30 Thread Souptick Joarder
Convert to use vm_insert_range to map range of kernel memory to user vma. vm_pgoff is treated in V4L2 API as a 'cookie' to select a buffer, not as a in-buffer offset by design and it always want to mmap a whole buffer from its beginning. Signed-off-by: Souptick Joarder --- drivers/media/common/

[PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-01-30 Thread Souptick Joarder
Previouly drivers have their own way of mapping range of kernel pages/memory into user vma and this was done by invoking vm_insert_page() within a loop. As this pattern is common across different drivers, it can be generalized by creating new functions and use it across the drivers. vm_insert_ran

[PATCHv2 0/9] Use vm_insert_range and vm_insert_range_buggy

2019-01-30 Thread Souptick Joarder
Previouly drivers have their own way of mapping range of kernel pages/memory into user vma and this was done by invoking vm_insert_page() within a loop. As this pattern is common across different drivers, it can be generalized by creating new functions and use it across the drivers. vm_insert_ran

Re: [PATCH v2 1/1] uvc: Avoid NULL pointer dereference at the end of streaming

2019-01-30 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 9c0863b1cc48 [media] vb2: call buf_finish from __queue_cancel. The bot has tested the following trees: v4.20.5, v4.19.18, v4.14.96, v4.9.153, v4.4.172, v3.18.133. v4.20.5: Build O

Re: IMX CSI capture issues with tda1997x HDMI receiver

2019-01-30 Thread Tim Harvey
On Mon, Jan 28, 2019 at 3:04 PM Steve Longerbeam wrote: > > > > On 1/28/19 11:03 AM, Tim Harvey wrote: > > On Fri, Jan 25, 2019 at 3:57 PM Steve Longerbeam > > wrote: > >> Hi Tim, cc: Philipp, > >> > >> On 1/23/19 3:21 PM, Tim Harvey wrote: > >>> Steve, > >>> > >>> I'm testing IMX6 capture again

Re: [PATCH v2 1/2] media: dt-bindings: media: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem

2019-01-30 Thread Rob Herring
On Fri, Jan 25, 2019 at 11:22:56PM +0530, Vishal Sagar wrote: > Add bindings documentation for Xilinx MIPI CSI-2 Rx Subsystem. > > The Xilinx MIPI CSI-2 Rx Subsystem consists of a CSI-2 Rx controller, a > DPHY in Rx mode, an optional I2C controller and a Video Format Bridge. > > Signed-off-by: Vi

Re: sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:14.0/usb1/1-3/dvb/dvb0.frontend0'

2019-01-30 Thread Markus Rechberger
Hi, our one (Sundtek) doesn't create such nodes, so this issue entirely applies to the other device. Best Regards, Markus On Thu, Jan 31, 2019 at 3:07 AM F.M. wrote: > > Hi folks, > > there's an issue which only occurs with kernels 4.19+ but not with 4.9. > Whenever the system resumes from susp

sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:14.0/usb1/1-3/dvb/dvb0.frontend0'

2019-01-30 Thread F.M.
Hi folks, there's an issue which only occurs with kernels 4.19+ but not with 4.9. Whenever the system resumes from suspend the following error message in the subject pops up. The two attached DVB-T/C adapters are the following: Bus 001 Device 004: ID 2659:1210 Sundtek MediaTV Pro III (EU) Bu

Re: [PATCH 2/3] media: vim2m: use per-file handler work queue

2019-01-30 Thread Mauro Carvalho Chehab
Em Wed, 30 Jan 2019 11:56:58 -0300 Ezequiel Garcia escreveu: > Hey Mauro, > > On Wed, 2019-01-30 at 11:19 -0200, Mauro Carvalho Chehab wrote: > > Em Wed, 30 Jan 2019 09:41:44 -0300 > > Ezequiel Garcia escreveu: > > > > > On Tue, 2019-01-29 at 14:00 -0200, Mauro Carvalho Chehab wrote: > > >

Have needs for your photos?

2019-01-30 Thread Jane
Do you need to make white background for your photos? Adding clipping path, or retouching? We can do it for you. Let's start with testing for your photos. Thanks, Jane

[PATCH] [media] ts2020: Variable "utmp" in function ts2020_set_tuner_rf() could be uninitialized

2019-01-30 Thread Yizhuo
In function ts2020_set_tuner_rf(), local variable "utmp" could be uninitialized if function regmap_read() returns -EINVAL. However, this value is used in if statement and written to the register, which is potentially unsafe. Signed-off-by: Yizhuo --- drivers/media/dvb-frontends/ts2020.c | 5

Have needs for your photos?

2019-01-30 Thread Jane
Do you need to make white background for your photos? Adding clipping path, or retouching? We can do it for you. Let's start with testing for your photos. Thanks, Jane

Need it?

2019-01-30 Thread Jane
Do you need to make white background for your photos? Adding clipping path, or retouching? We can do it for you. Let's start with testing for your photos. Thanks, Jane

RE: [PATCH] media: staging/intel-ipu3: Implement lock for stream on/off operations

2019-01-30 Thread Mani, Rajmohan
Hi Sakari, > -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] > Sent: Wednesday, January 30, 2019 12:59 AM > To: Mani, Rajmohan > Cc: Mauro Carvalho Chehab ; Greg Kroah-Hartman > ; linux-media@vger.kernel.org; > de...@driverdev.osuosl.org; linux-ker...@vger.ke

[PATCH] media: i2c: ov5640: Fix post-reset delay

2019-01-30 Thread Loic Poulain
According to the ov5640 specification (2.7 power up sequence), host can access the sensor's registers 20ms after reset. Trying to access them before leads to undefined behavior and result in sporadic initialization errors. Signed-off-by: Loic Poulain --- drivers/media/i2c/ov5640.c | 2 +- 1 file

Re: [PATCH v2 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-01-30 Thread Michael Tretter
On Wed, 30 Jan 2019 10:19:53 -0500, Nicolas Dufresne wrote: > Le mercredi 30 janvier 2019 à 08:47 +0100, Hans Verkuil a écrit : > > On 1/30/19 4:41 AM, Nicolas Dufresne wrote: > > > Hi Hans, > > > > > > Le mercredi 23 janvier 2019 à 11:44 +0100, Hans Verkuil a écrit : > > > > > + if (*npla

Re: [PATCH 10/10] venus: dec: make decoder compliant with stateful codec API

2019-01-30 Thread Nicolas Dufresne
Le mercredi 30 janvier 2019 à 15:17 +0900, Tomasz Figa a écrit : > > I don't remember saying that, maybe I meant to say there might be a > > workaround ? > > > > For the fact, here we queue the headers (or first frame): > > > > https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/blob/master

Re: [PATCH v2 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-01-30 Thread Nicolas Dufresne
Le mercredi 30 janvier 2019 à 08:47 +0100, Hans Verkuil a écrit : > On 1/30/19 4:41 AM, Nicolas Dufresne wrote: > > Hi Hans, > > > > Le mercredi 23 janvier 2019 à 11:44 +0100, Hans Verkuil a écrit : > > > > + if (*nplanes != 0) { > > > > + if (vq->type == V4L2_BUF_TYPE_VIDEO_CAPTUR

Re: [PATCH v2 2/2] media: docs-rst: Document memory-to-memory video encoder interface

2019-01-30 Thread Nicolas Dufresne
Le vendredi 25 janvier 2019 à 12:59 +0900, Tomasz Figa a écrit : > On Fri, Jan 25, 2019 at 5:14 AM Nicolas Dufresne wrote: > > Le mercredi 23 janvier 2019 à 14:04 +0100, Hans Verkuil a écrit : > > > > > Does this return the same set of formats as in the 'Querying > > > > > Capabilities' phase? >

Re: [PATCH 2/3] media: vim2m: use per-file handler work queue

2019-01-30 Thread Ezequiel Garcia
Hey Mauro, On Wed, 2019-01-30 at 11:19 -0200, Mauro Carvalho Chehab wrote: > Em Wed, 30 Jan 2019 09:41:44 -0300 > Ezequiel Garcia escreveu: > > > On Tue, 2019-01-29 at 14:00 -0200, Mauro Carvalho Chehab wrote: > > > It doesn't make sense to have a per-device work queue, as the > > > scheduler sh

Re: [PATCH v2] v4l2-ctl: add function vidcap_get_and_update_fmt

2019-01-30 Thread Hans Verkuil
On 1/30/19 3:42 PM, Dafna Hirschfeld wrote: > add a function vidcap_get_and_update_fmt to set > the format from cmd params. Use it in capture_setup. > > Signed-off-by: Dafna Hirschfeld > --- > Changes from v1: > change the order of vidcap_get_and_update_fmt and vidcap_set > > utils/v4l2-ctl/v4l2

[PATCH v2] v4l2-ctl: add function vidcap_get_and_update_fmt

2019-01-30 Thread Dafna Hirschfeld
add a function vidcap_get_and_update_fmt to set the format from cmd params. Use it in capture_setup. Signed-off-by: Dafna Hirschfeld --- Changes from v1: change the order of vidcap_get_and_update_fmt and vidcap_set utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 13 +++ utils/v4l2-ctl/v4l2-ctl-vidcap.c

Re: [PATCH v11 05/13] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2019-01-30 Thread Sakari Ailus
Hi Rui, On Thu, Jan 24, 2019 at 04:09:20PM +, Rui Miguel Silva wrote: > Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI > CSI-2 interface. > > Signed-off-by: Rui Miguel Silva > --- > drivers/staging/media/imx/Makefile |1 + > drivers/staging/media/imx/imx7-m

[PATCH] vim2m: fill in bus_info in media_device_info

2019-01-30 Thread Hans Verkuil (hansverk)
It is good practice to fill in the bus_info. Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c index 0e7814b2327e..4055aabf2a5e 100644 --- a/drivers/media/platform/vim2m.c +++ b/drivers/media/platform/vim2m.c @@ -1155,6 +1155,7 @@ static

[PATCH] vimc: fill in bus_info in media_device_info

2019-01-30 Thread Hans Verkuil
It is good practice to fill in bus_info. Also just use 'platform:vimc' when filling in the bus_info in querycap: the bus_info has nothing to do with the video device name. Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/vimc/vimc-capture.c b/drivers/media/platform/vimc/vimc-

[PATCH] vim2m: fill in bus_info in media_device_info

2019-01-30 Thread Hans Verkuil
It is good practice to fill in the bus_info. Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c index 0e7814b2327e..4055aabf2a5e 100644 --- a/drivers/media/platform/vim2m.c +++ b/drivers/media/platform/vim2m.c @@ -1155,6 +1155,7 @@ static

[PATCH] vicodec: fill in bus_info in media_device_info

2019-01-30 Thread Hans Verkuil
It is good practice to fill in bus_info. Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/vicodec/vicodec-core.c b/drivers/media/platform/vicodec/vicodec-core.c index 3703b587e25e..27746ed12411 100644 --- a/drivers/media/platform/vicodec/vicodec-core.c +++ b/drivers/media/plat

Re: [PATCH] v4l2-ctl: add function vidcap_get_and_update_fmt

2019-01-30 Thread Hans Verkuil
Hi Dafna, One simple comment: On 1/30/19 2:00 PM, Dafna Hirschfeld wrote: > add a function vidcap_get_and_update_fmt to set > the format from cmd params. Use it in capture_setup. > > Signed-off-by: Dafna Hirschfeld > --- > utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 13 +++ > utils/v4l2-ctl/v4l2-

Re: [PATCH 2/3] media: vim2m: use per-file handler work queue

2019-01-30 Thread Mauro Carvalho Chehab
Em Wed, 30 Jan 2019 09:41:44 -0300 Ezequiel Garcia escreveu: > On Tue, 2019-01-29 at 14:00 -0200, Mauro Carvalho Chehab wrote: > > It doesn't make sense to have a per-device work queue, as the > > scheduler should be called per file handler. Having a single > > one causes failures if multiple str

[PATCH] v4l2-ctl: add function vidcap_get_and_update_fmt

2019-01-30 Thread Dafna Hirschfeld
add a function vidcap_get_and_update_fmt to set the format from cmd params. Use it in capture_setup. Signed-off-by: Dafna Hirschfeld --- utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 13 +++ utils/v4l2-ctl/v4l2-ctl-vidcap.cpp| 140 ++ utils/v4l2-ctl/v4l2-ctl.h

Re: [PATCH 2/3] media: vim2m: use per-file handler work queue

2019-01-30 Thread Ezequiel Garcia
On Tue, 2019-01-29 at 14:00 -0200, Mauro Carvalho Chehab wrote: > It doesn't make sense to have a per-device work queue, as the > scheduler should be called per file handler. Having a single > one causes failures if multiple streams are filtered by vim2m. > Having a per-device workqueue should em

Re: [PATCH v11 00/13] media: staging/imx7: add i.MX7 media driver

2019-01-30 Thread Sakari Ailus
On Thu, Jan 24, 2019 at 04:09:15PM +, Rui Miguel Silva wrote: > Hi, > This series introduces the Media driver to work with the i.MX7 SoC. it uses > the > already existing imx media core drivers but since the i.MX7, contrary to > i.MX5/6, do not have an IPU and because of that some changes in t

Re: [PATCH v11 03/13] media: staging/imx7: add imx7 CSI subdev driver

2019-01-30 Thread Sakari Ailus
Hi Rui, A few more comments below. On Thu, Jan 24, 2019 at 04:09:18PM +, Rui Miguel Silva wrote: > This add the media entity subdevice and control driver for the i.MX7 > CMOS Sensor Interface. > > Signed-off-by: Rui Miguel Silva > --- > drivers/staging/media/imx/imx7-media-csi.c | 1360 +++

Re: [PATCH v2 2/2] media: atmel-isc: Update device tree binding documentation

2019-01-30 Thread Sakari Ailus
Hi Ken, On Tue, Jan 29, 2019 at 08:22:48PM +, Ken Sloat wrote: > > -Original Message- > > From: Sakari Ailus > > Sent: Wednesday, January 23, 2019 7:46 AM > > Cc: eugen.hris...@microchip.com; mche...@kernel.org; > > nicolas.fe...@microchip.com; alexandre.bell...@bootlin.com; > > ludov

Re: [PATCH v2] venus: enc: fix enum_frameintervals

2019-01-30 Thread Stanimir Varbanov
Hi Nicolas, On 1/30/19 5:28 AM, Nicolas Dufresne wrote: > Le mardi 22 janvier 2019 à 12:53 +0200, Stanimir Varbanov a écrit : >> This ixes an issue when setting the encoder framerate because of > > ixes -> fixes > >> missing precision. Now the frameinterval type is changed to >> TYPE_CONTINUOUS

DVB-T2 Stick

2019-01-30 Thread Gonsolo
Hi! The following patch adds support for the Logilink VG0022A DVB-T2 stick. After patching and building the kernel it shows up with lsusb and I used w_scan to scan for channels and vlc for watching. The original patches were from Andreas Kemnade. The only thing that doesn't work is wake up after s

[PATCH v2 1/1] uvc: Avoid NULL pointer dereference at the end of streaming

2019-01-30 Thread Sakari Ailus
The UVC video driver converts the timestamp from hardware specific unit to one known by the kernel at the time when the buffer is dequeued. This is fine in general, but the streamoff operation consists of the following steps (among other things): 1. uvc_video_clock_cleanup --- the hardware clock s

Re: [linux-sunxi] [PATCH v2 1/2] media: v4l: Add definitions for the HEVC slice format and controls

2019-01-30 Thread Ayaka
Sent from my iPad > On Jan 30, 2019, at 3:17 PM, Tomasz Figa wrote: > >> On Wed, Jan 30, 2019 at 3:28 PM Ayaka wrote: >> >> >> >> Sent from my iPad >> >>> On Jan 30, 2019, at 11:35 AM, Tomasz Figa wrote: >>> >>> On Wed, Jan 30, 2019 at 11:29 AM Alexandre Courbot >>> wrote: >

Re: [PATCH v2 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-01-30 Thread Michael Tretter
On Tue, 29 Jan 2019 22:46:15 -0500, Nicolas Dufresne wrote: > Le mercredi 23 janvier 2019 à 15:17 +0100, Michael Tretter a écrit : > > > I have a patch pending that allows an encoder to spread the compressed > > > output over multiple buffers: > > > > > > https://patchwork.linuxtv.org/patch/53536/

Re: [PATCH 1/1] uvc: Avoid NULL pointer dereference at the end of streaming

2019-01-30 Thread Sakari Ailus
Hi Laurent, On Wed, Jan 30, 2019 at 11:17:37AM +0200, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Tue, Jan 29, 2019 at 11:49:44PM +0200, Sakari Ailus wrote: > > The UVC video driver converts the timestamp from hardware specific unit to > > one known by the kernel at

Re: [PATCH 1/1] uvc: Avoid NULL pointer dereference at the end of streaming

2019-01-30 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Tue, Jan 29, 2019 at 11:49:44PM +0200, Sakari Ailus wrote: > The UVC video driver converts the timestamp from hardware specific unit to > one known by the kernel at the time when the buffer is dequeued. This is > fine in general, but the streamoff operation

[PATCH v3] [media] v4l: add I / P frame min max QP definitions

2019-01-30 Thread Fish Lin
Add following V4L2 QP parameters for H.264: * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP * V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MIN_QP * V4L2_CID_MPEG_VIDEO_H264_P_FRAME_MAX_QP These controls will limit QP range for intra and inter frame, provide more manual

Re: [PATCH] media: staging/intel-ipu3: Implement lock for stream on/off operations

2019-01-30 Thread Sakari Ailus
Hi Rajmohan, On Tue, Jan 29, 2019 at 02:27:36PM -0800, Rajmohan Mani wrote: > Currently concurrent stream off operations on ImgU nodes are not > synchronized, leading to use-after-free bugs (as reported by KASAN). > > [ 250.090724] BUG: KASAN: use-after-free in ipu3_dmamap_free+0xc5/0x116 > [ip

Re: [PATCH v2] [media] v4l: add I / P frame min max QP definitions

2019-01-30 Thread Fish Lin
Hi Hans, For I frame min QP, if global min QP is set, the QP choose algorithm should meet both of them, hence QP will >= max(V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP, V4L2_CID_MPEG_VIDEO_H264_MIN_QP). And this is also the same to the P frame and max QP. I can add some description to describe this b