Re: [PATCHv4 00/10] As was discussed here (among other places):

2019-01-06 Thread Randy Li
On 12/5/18 6:20 PM, hverkuil-ci...@xs4all.nl wrote: From: Hans Verkuil https://lkml.org/lkml/2018/10/19/440 using capture queue buffer indices to refer to reference frames is not a good idea. A better idea is to use a 'tag' where the application can assign a u32 tag to an output buffer, whic

Re: [linux-sunxi] [PATCH v2 1/2] media: v4l: Add definitions for the HEVC slice format and controls

2019-01-06 Thread Randy Li
On 12/12/18 8:51 PM, Paul Kocialkowski wrote: Hi, On Wed, 2018-12-05 at 21:59 +0100, Jernej Škrabec wrote: + +#define V4L2_HEVC_DPB_ENTRY_RPS_ST_CURR_BEFORE 0x01 +#define V4L2_HEVC_DPB_ENTRY_RPS_ST_CURR_AFTER 0x02 +#define V4L2_HEVC_DPB_ENTRY_RPS_LT_CURR0x03 + +#define V4L2_

Re: [PATCH -next] media: staging/intel-ipu3: Fix err handle of ipu3_css_find_binary

2019-01-06 Thread Bingbu Cao
Hi, Haibing Thanks for your patch, it looks fine for me. Reviewed-by: Bingbu Cao On 12/29/2018 10:45 AM, YueHaibing wrote: css->pipes[pipe].bindex = binary;

RE: [PATCH][next] media: cxd2880-spi: fix two memory leaks of dvb_spi

2019-01-06 Thread Yasunari.Takiguchi
Hi Colin Thanks for finding that. Acked-by: Yasunari Takiguchi   Takiguchi > -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Saturday, December 22, 2018 11:12 PM > To: Takiguchi, Yasunari (SSS); Mauro Carvalho Chehab; > linux-media@vger.kernel.org > Cc: ke

[RFC PATCH v2] media: rcar-vin: Allow independent VIN link enablement

2019-01-06 Thread Steve Longerbeam
There is a block of code in rvin_group_link_notify() that loops through all entities in the media graph, and prevents enabling a link to a VIN node if any entity is in use. This prevents enabling a VIN link even if there is an in-use entity somewhere in the graph that is independent of the link's p

Re: [PATCH 4/4] arm64: dts: rockchip: add video codec for rk3399

2019-01-06 Thread Ayaka
Hello Ezequiel Sent from my iPad > On Jan 7, 2019, at 1:21 AM, Ezequiel Garcia > wrote: > >> On Sun, 6 Jan 2019 at 13:16, Ayaka wrote: >> >> >> >> Sent from my iPad >> >>> On Jan 7, 2019, at 12:04 AM, Ezequiel Garcia wrote: >>> >>> On Sun, 2019-01-06 at 23:05 +0800, Ayaka wrote: > O

Re: [PATCH 4/4] arm64: dts: rockchip: add video codec for rk3399

2019-01-06 Thread Ezequiel Garcia
On Sun, 6 Jan 2019 at 13:16, Ayaka wrote: > > > > Sent from my iPad > > > On Jan 7, 2019, at 12:04 AM, Ezequiel Garcia wrote: > > > > On Sun, 2019-01-06 at 23:05 +0800, Ayaka wrote: > >>> On Jan 6, 2019, at 10:22 PM, Ezequiel Garcia > >>> wrote: > >>> > >>> Hi Randy, > >>> > >>> Thanks a lot fo

Re: [PATCH v5 2/6] media: sun6i: Add mod_rate quirk

2019-01-06 Thread Jagan Teki
On Mon, Dec 24, 2018 at 8:57 PM Jagan Teki wrote: > > On Fri, Dec 21, 2018 at 6:30 PM Maxime Ripard > wrote: > > > > On Thu, Dec 20, 2018 at 06:24:34PM +0530, Jagan Teki wrote: > > > Unfortunately default CSI_SCLK rate cannot work properly to > > > drive the connected sensor interface, particula

Re: [PATCH 4/4] arm64: dts: rockchip: add video codec for rk3399

2019-01-06 Thread Ayaka
Sent from my iPad > On Jan 7, 2019, at 12:04 AM, Ezequiel Garcia wrote: > > On Sun, 2019-01-06 at 23:05 +0800, Ayaka wrote: >>> On Jan 6, 2019, at 10:22 PM, Ezequiel Garcia wrote: >>> >>> Hi Randy, >>> >>> Thanks a lot for this patches. They are really useful >>> to provide more insight in

Re: [PATCH 4/4] arm64: dts: rockchip: add video codec for rk3399

2019-01-06 Thread Ezequiel Garcia
On Sun, 2019-01-06 at 23:05 +0800, Ayaka wrote: > > On Jan 6, 2019, at 10:22 PM, Ezequiel Garcia wrote: > > > > Hi Randy, > > > > Thanks a lot for this patches. They are really useful > > to provide more insight into the VPU hardware. > > > > This change will make the vpu encoder and vpu decode

[PATCH v2 3/6] media: adv748x: csi2: Link AFE with TXA and TXB

2019-01-06 Thread Jacopo Mondi
The ADV748x chip supports routing AFE output to either TXA or TXB. In order to support run-time configuration of video stream path, create an additional (not enabled) "AFE:8->TXA:0" link, and remove the IMMUTABLE flag from existing ones. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/adv748x/

[PATCH v2 2/6] media: adv748x: Rename reset procedures

2019-01-06 Thread Jacopo Mondi
Rename the chip reset procedure as they configure the CP (HDMI) and SD (AFE) cores. Reviewed-by: Laurent Pinchart Signed-off-by: Jacopo Mondi --- drivers/media/i2c/adv748x/adv748x-core.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/media

[PATCH v2 5/6] media: adv748x: Store the TX sink in HDMI/AFE

2019-01-06 Thread Jacopo Mondi
Both the AFE and HDMI s_stream routines (adv748x_afe_s_stream() and adv748x_hdmi_s_stream()) have to enable the CSI-2 TX they are streaming video data to. With the introduction of dynamic routing between HDMI and AFE entities to TXA, the video stream sink needs to be set at run time, and not stati

[PATCH v2 6/6] media: adv748x: Implement TX link_setup callback

2019-01-06 Thread Jacopo Mondi
When the adv748x driver is informed about a link being created from HDMI or AFE to a CSI-2 TX output, the 'link_setup()' callback is invoked. Make sure to implement proper routing management at link setup time, to route the selected video stream to the desired TX output. Signed-off-by: Jacopo Mond

[PATCH v2 0/6] media: adv748x: Implement dynamic routing support

2019-01-06 Thread Jacopo Mondi
Hello, second iteration for adv748x dynamic selection of video source. Please refer to v1 cover letter for more details: https://patchwork.kernel.org/cover/10723971/ This v2 addresses comments received from Kieran and Laurent, with the most notable changes in patches 3/6 and 6/6. Tested on R-

[PATCH v2 4/6] media: adv748x: Store the source subdevice in TX

2019-01-06 Thread Jacopo Mondi
The power_up_tx() procedure needs to set a few registers conditionally to the selected video source, but it currently checks for the provided tx to be either TXA or TXB. With the introduction of dynamic routing between HDMI and AFE entities to TXA, checking which TX the function is operating on is

[PATCH v2 1/6] media: adv748x: Add is_txb()

2019-01-06 Thread Jacopo Mondi
Add small is_txb() macro to the existing is_txa() and use it where appropriate. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/adv748x/adv748x-csi2.c | 2 +- drivers/media/i2c/adv748x/adv748x.h | 6 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/a

Re: [PATCH 4/4] arm64: dts: rockchip: add video codec for rk3399

2019-01-06 Thread Ayaka
> On Jan 6, 2019, at 10:22 PM, Ezequiel Garcia wrote: > > Hi Randy, > > Thanks a lot for this patches. They are really useful > to provide more insight into the VPU hardware. > > This change will make the vpu encoder and vpu decoder > completely independent, can they really work in parallel?

Re: [PATCH 4/4] arm64: dts: rockchip: add video codec for rk3399

2019-01-06 Thread Ayaka
> On Jan 6, 2019, at 10:22 PM, Ezequiel Garcia wrote: > > Hi Randy, > > Thanks a lot for this patches. They are really useful > to provide more insight into the VPU hardware. > > This change will make the vpu encoder and vpu decoder > completely independent, can they really work in parallel?

Re: [PATCH 4/4] arm64: dts: rockchip: add video codec for rk3399

2019-01-06 Thread Ezequiel Garcia
Hi Randy, Thanks a lot for this patches. They are really useful to provide more insight into the VPU hardware. This change will make the vpu encoder and vpu decoder completely independent, can they really work in parallel? Could you provide more details about what is shared between these devices