Re: [RFCv4 PATCH 0/3] This RFC patch series implements properties for the media controller.

2018-12-11 Thread Mauro Carvalho Chehab
Hi Hans, Em Wed, 21 Nov 2018 16:40:21 +0100 Hans Verkuil escreveu: > The main changes since RFCv3 are: > > - Add entity index to media_v2_pad > - Add source/sink pad index to media_v2_link > - Add owner_idx and owner type flags to media_v2_prop Sorry, but I didn't get why this is needed for pr

Re: [media-workshop] [ANN] Edinburgh Media Summit 2018 meeting report

2018-12-11 Thread Mauro Carvalho Chehab
Sakari, Em Sun, 18 Nov 2018 00:45:02 +0200 Sakari Ailus escreveu: > Hello everyone, Sorry for taking so long to review this. Was very busy those days. It follows my comments. > > > Here's the report on the Media Summit held on 25th October in Edinburgh. > The report is followed by the state

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-12-11 Thread Bingbu Cao
On 12/11/2018 09:43 PM, Laurent Pinchart wrote: Hello Rajmohan, On Tuesday, 11 December 2018 15:34:49 EET Laurent Pinchart wrote: On Wednesday, 5 December 2018 02:30:46 EET Mani, Rajmohan wrote: [snip] I can see a couple of steps missing in the script below. (https://lists.libcamera.org/p

cron job: media_tree daily build: ERRORS

2018-12-11 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Dec 12 05:00:11 CET 2018 media-tree git hash:e159b6074c82fe31b79aad672e02fa204dbbc6d8 media_build git

Re: [PATCH 1/6] media: dt-bindings: media: sun6i: Separate H3 compatible from A31

2018-12-11 Thread Rob Herring
On Fri, 30 Nov 2018 15:58:44 +0800, Chen-Yu Tsai wrote: > The CSI controller found on the H3 (and H5) is a reduced version of the > one found on the A31. It only has 1 channel, instead of 4 channels for > time-multiplexed BT.656. Since the H3 is a reduced version, it cannot > "fallback" to a compat

Re: [PATCH 1/5] media: adv748x: Rework reset procedure

2018-12-11 Thread Kieran Bingham
Hi Jacopo, On 11/12/2018 15:16, Jacopo Mondi wrote: > Re-work the chip reset procedure to configure the CP (HDMI) and SD (AFE) cores > before resetting the MIPI CSI-2 TXs. > > Signed-off-by: Jacopo Mondi > --- > drivers/media/i2c/adv748x/adv748x-core.c | 24 ++-- > 1 file ch

Re: [PATCH 5/5] media: adv748x: Implement link_setup callback

2018-12-11 Thread Kieran Bingham
Hi Jacopo, On 11/12/2018 15:16, Jacopo Mondi wrote: > When the adv748x driver is informed about a link being created from HDMI or > AFE to a CSI-2 TX output, the 'link_setup()' callback is invoked. Make > sure to implement proper routing management at link setup time, to route > the selected video

Re: [PATCH 4/5] media: adv748x: Store the TX sink in HDMI/AFE

2018-12-11 Thread Kieran Bingham
Hi Jacopo, On 11/12/2018 15:16, Jacopo Mondi wrote: > Both the AFE and HDMI s_stream routines (adv748x_afe_s_stream() and > adv748x_hdmi_s_stream()) have to enable the CSI-2 TX they are streaming video > data to. > > With the introduction of dynamic routing between HDMI and AFE entities to > TXA,

Re: [PATCH 3/5] media: adv748x: Store the source subdevice in TX

2018-12-11 Thread Kieran Bingham
Hi Jacopo, On 11/12/2018 15:16, Jacopo Mondi wrote: > The power_up_tx() procedure needs to set a few registers conditionally to > the selected video source, but it currently checks for the provided tx to > be either TXA or TXB. > > With the introduction of dynamic routing between HDMI and AFE ent

Re: [PATCH 2/5] media: adv748x: csi2: Link AFE with TXA and TXB

2018-12-11 Thread Kieran Bingham
Hi Jacopo, Thank you for the patch, On 11/12/2018 15:16, Jacopo Mondi wrote: > The ADV748x chip supports routing AFE output to either TXA or TXB. > In order to support run-time configuration of video stream path, create an > additional (not enabled) "AFE:8->TXA:0" link, and remove the IMMUTABLE f

Re: next-20181211 build: 1 failures 32 warnings (next-20181211)

2018-12-11 Thread Nathan Chancellor
On Tue, Dec 11, 2018 at 10:06:20PM +, Mark Brown wrote: > On Tue, Dec 11, 2018 at 07:38:33PM +, Build bot for Mark Brown wrote: > > Today's -next fails to build an arm allmodconfig due to: > > > arm-allmodconfig > > ../arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumas

Re: bug report cxusb oops

2018-12-11 Thread Sean Young
On Wed, Dec 12, 2018 at 08:02:48AM +1100, David Howe wrote: > Hi Sean > > I have tried a variety of kernels, including my own and the results are all > very similar. > > current version of kernel (uname -a) > > Linux david-HP-EliteBook-8460p 4.18.0-13-generic #14~lp1807550 SMP Mon Dec > 10 14:01

Re: next-20181211 build: 1 failures 32 warnings (next-20181211)

2018-12-11 Thread Mark Brown
On Tue, Dec 11, 2018 at 07:38:33PM +, Build bot for Mark Brown wrote: Today's -next fails to build an arm allmodconfig due to: > arm-allmodconfig > ../arch/arm/include/asm/irq.h:35:50: error: unknown type name 'cpumask_t' > ../arch/arm/include/asm/irq.h:36:9: error: unknown type name 'b

Re: [PATCH] media: ddbridge: Move asm includes after linux ones

2018-12-11 Thread Guenter Roeck
On Mon, Dec 10, 2018 at 04:35:14PM -0700, Nathan Chancellor wrote: > Without this, cpumask_t and bool are not defined: > > In file included from drivers/media/pci/ddbridge/ddbridge-ci.c:19: > In file included from drivers/media/pci/ddbridge/ddbridge.h:22: > ./arch/arm/include/asm/irq.h:35:50: erro

[GIT PULL FOR v4.21] Add Aspeed Video Engine driver

2018-12-11 Thread Hans Verkuil
Hi Mauro, I hope there is still a possibility to get this new driver merged for 4.21. This driver went through a few more revisions than expected, but v8 looks solid to me. Regards, Hans The following changes since commit e159b6074c82fe31b79aad672e02fa204dbbc6d8: media: vimc: fix sta

[PATCH v8 2/2] media: platform: Add Aspeed Video Engine driver

2018-12-11 Thread Eddie James
The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs can capture and compress video data from digital or analog sources. With the Aspeed chip acting a service processor, the Video Engine can capture the host processor graphics output. Add a V4L2 driver to capture video data and co

[PATCH v8 0/2] media: platform: Add Aspeed Video Engine driver

2018-12-11 Thread Eddie James
From: Eddie James The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs can capture and compress video data from digital or analog sources. With the Aspeed chip acting as a service processor, the Video Engine can capture the host processor graphics output. This series adds a V4L2

[PATCH v8 1/2] dt-bindings: media: Add Aspeed Video Engine binding documentation

2018-12-11 Thread Eddie James
Document the bindings. Signed-off-by: Eddie James Reviewed-by: Rob Herring --- .../devicetree/bindings/media/aspeed-video.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/aspeed-video.txt diff --git a/Documentatio

Re: [PATCH v7 2/2] media: platform: Add Aspeed Video Engine driver

2018-12-11 Thread Hans Verkuil
On 12/11/18 5:41 PM, Eddie James wrote: >> Running checkpatch.pl --strict over the patch gives me three 'CHECK' items >> they you should also address: >> >> CHECK: struct mutex definition without comment >> #312: FILE: drivers/media/platform/aspeed-video.c:222: >> +   struct mutex video_lock

Re: [PATCH v7 2/2] media: platform: Add Aspeed Video Engine driver

2018-12-11 Thread Eddie James
On 12/11/2018 04:44 AM, Hans Verkuil wrote: On 12/10/18 11:26 PM, Eddie James wrote: The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs can capture and compress video data from digital or analog sources. With the Aspeed chip acting a service processor, the Video Engine can

Re: [PATCH v3 2/6] media: sun6i: Add A64 compatible support

2018-12-11 Thread Maxime Ripard
On Mon, Dec 10, 2018 at 05:22:42PM +0530, Jagan Teki wrote: > Allwinner A64 CSI has single channel time-multiplexed BT.656 > CMOS sensor interface like H3 but work by lowering clock than > default mod clock. > > So use separate compatibe to support it. > > Signed-off-by: Jagan Teki > --- > driv

Re: [PATCH v3 3/6] media: sun6i: Set 300MHz mod clock for A64

2018-12-11 Thread Maxime Ripard
On Mon, Dec 10, 2018 at 05:22:43PM +0530, Jagan Teki wrote: > The default CSI_SCLK seems unable to drive the sensor to capture > the image, so update it to working clock rate 300MHz for A64. > > Signed-off-by: Jagan Teki > --- > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 5 + > 1 f

Re: [PATCH v3 3/6] media: sun6i: Set 300MHz mod clock for A64

2018-12-11 Thread Jagan Teki
On Tue, Dec 11, 2018 at 9:14 PM Maxime Ripard wrote: > > On Mon, Dec 10, 2018 at 05:22:43PM +0530, Jagan Teki wrote: > > The default CSI_SCLK seems unable to drive the sensor to capture > > the image, so update it to working clock rate 300MHz for A64. > > > > Signed-off-by: Jagan Teki > > --- > >

[PATCH v4 0/2] media: video-i2c: add Melexis MLX90640 thermal camera support

2018-12-11 Thread Matt Ranostay
Add initial support for Melexis line of thermal cameras. This is the first part of processing pipeline in which the real processing is done in userspace using the V4L2 camera data. Changes from v1: * add melexis,mlx90640.txt documentation Changes from v2: * power patchset was submitted in its o

[PATCH v4 2/2] media: video-i2c: add Melexis MLX90640 thermal camera

2018-12-11 Thread Matt Ranostay
Add initial support for MLX90640 thermal cameras which output an 32x24 greyscale pixel image along with 2 rows of coefficent data. Because of this the data outputed is really 32x26 and needs the two rows removed after using the coefficent information to generate processed images in userspace. Sig

[PATCH v4 1/2] media: dt-bindings: media: video-i2c: add melexis mlx90640 documentation

2018-12-11 Thread Matt Ranostay
Cc: devicet...@vger.kernel.org Signed-off-by: Matt Ranostay --- .../bindings/media/i2c/melexis,mlx90640.txt | 20 +++ 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/melexis,mlx90640.txt diff --git a/Documentation/devicetree/bin

[PATCH 1/5] media: adv748x: Rework reset procedure

2018-12-11 Thread Jacopo Mondi
Re-work the chip reset procedure to configure the CP (HDMI) and SD (AFE) cores before resetting the MIPI CSI-2 TXs. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/adv748x/adv748x-core.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/medi

[PATCH 5/5] media: adv748x: Implement link_setup callback

2018-12-11 Thread Jacopo Mondi
When the adv748x driver is informed about a link being created from HDMI or AFE to a CSI-2 TX output, the 'link_setup()' callback is invoked. Make sure to implement proper routing management at link setup time, to route the selected video stream to the desired TX output. Signed-off-by: Jacopo Mond

[PATCH 2/5] media: adv748x: csi2: Link AFE with TXA and TXB

2018-12-11 Thread Jacopo Mondi
The ADV748x chip supports routing AFE output to either TXA or TXB. In order to support run-time configuration of video stream path, create an additional (not enabled) "AFE:8->TXA:0" link, and remove the IMMUTABLE flag from existing ones. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/adv748x/

[PATCH 3/5] media: adv748x: Store the source subdevice in TX

2018-12-11 Thread Jacopo Mondi
The power_up_tx() procedure needs to set a few registers conditionally to the selected video source, but it currently checks for the provided tx to be either TXA or TXB. With the introduction of dynamic routing between HDMI and AFE entities to TXA, checking which TX the function is operating on is

[PATCH 4/5] media: adv748x: Store the TX sink in HDMI/AFE

2018-12-11 Thread Jacopo Mondi
Both the AFE and HDMI s_stream routines (adv748x_afe_s_stream() and adv748x_hdmi_s_stream()) have to enable the CSI-2 TX they are streaming video data to. With the introduction of dynamic routing between HDMI and AFE entities to TXA, the video stream sink needs to be set at run time, and not stati

[PATCH 0/5] media: adv748x: Implement dynamic routing support

2018-12-11 Thread Jacopo Mondi
Hello, this series implements dynamic selection of video source for the adv748x video/HDMI decoder. The series aims to have CVBS capture work on R-Car E3 Ebisu board, where the HDMI and CVBS input share a single CSI-2 TX output. In all other R-Car Gen3 boards the CVBS input is statically route

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-12-11 Thread Laurent Pinchart
Hello again, On Tuesday, 11 December 2018 15:43:53 EET Laurent Pinchart wrote: > On Tuesday, 11 December 2018 15:34:49 EET Laurent Pinchart wrote: > > On Wednesday, 5 December 2018 02:30:46 EET Mani, Rajmohan wrote: > > > > [snip] > > > > > I can see a couple of steps missing in the script below

Re: Configure video PAL decoder into media pipeline

2018-12-11 Thread Michael Nazzareno Trimarchi
Hi Jacopo On Tue, Dec 11, 2018 at 12:39 PM jacopo mondi wrote: > > Hi Michael, > > On Mon, Dec 10, 2018 at 10:45:02PM +0100, Michael Nazzareno Trimarchi wrote: > > Hi Jacopo > > > > Let's see what I have done > > > > On Sun, Dec 9, 2018 at 8:39 PM jacopo mondi wrote: > > > > > > Hi Michael, Jaga

Re: [PATCH 6/6] sparc: merge 32-bit and 64-bit version of pci.h

2018-12-11 Thread Christoph Hellwig
I've pulled this into the dma-mapping for-next tree now.

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-12-11 Thread Laurent Pinchart
Hello Rajmohan, On Tuesday, 11 December 2018 15:34:49 EET Laurent Pinchart wrote: > On Wednesday, 5 December 2018 02:30:46 EET Mani, Rajmohan wrote: > > [snip] > > > I can see a couple of steps missing in the script below. > > (https://lists.libcamera.org/pipermail/libcamera-devel/2018-November/

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-12-11 Thread Laurent Pinchart
Hi Rajmohan, On Wednesday, 5 December 2018 02:30:46 EET Mani, Rajmohan wrote: [snip] > I can see a couple of steps missing in the script below. > (https://lists.libcamera.org/pipermail/libcamera-devel/2018-November/40. > html) > > From patch 02 of this v7 series "doc-rst: Add Intel IPU3 doc

Re: [PATCH v8 17/17] doc-rst: Add Intel IPU3 documentation

2018-12-11 Thread Laurent Pinchart
Hello Yong, Thank you for the patch. I've reviewed v7 of the IPU3 documentation in details, yet the comments don't seem to have been taken into account. Could you please address that in v9 ? I will skip review of v8 until then. On Friday, 7 December 2018 03:03:42 EET Yong Zhi wrote: > From: Ra

Re: [PATCH v8 15/17] media: v4l: Add Intel IPU3 meta buffer formats

2018-12-11 Thread Laurent Pinchart
Hello Yong, Thank you for the patch. On Friday, 7 December 2018 03:03:40 EET Yong Zhi wrote: > Add IPU3-specific meta formats for processing parameters and > 3A statistics. > > V4L2_META_FMT_IPU3_PARAMS > V4L2_META_FMT_IPU3_STAT_3A > > Signed-off-by: Yong Zhi > Reviewed-by: Laurent Pinchar

Re: Configure video PAL decoder into media pipeline

2018-12-11 Thread jacopo mondi
Hi Michael, On Mon, Dec 10, 2018 at 10:45:02PM +0100, Michael Nazzareno Trimarchi wrote: > Hi Jacopo > > Let's see what I have done > > On Sun, Dec 9, 2018 at 8:39 PM jacopo mondi wrote: > > > > Hi Michael, Jagan, Hans, > > > > On Sat, Dec 08, 2018 at 06:07:04PM +0100, Michael Nazzareno Trimarchi

Re: [PATCH] media: rcar-csi2: Fix PHTW table values for E3/V3M

2018-12-11 Thread jacopo mondi
Hi Laurent, Niklas, On Tue, Dec 11, 2018 at 03:01:15AM +0100, Niklas Söderlund wrote: > Hi Laurent, > > Thanks for your feedback, > > On 2018-12-10 22:16:52 +0200, Laurent Pinchart wrote: > > Hi Jacopo, > > > > Thank you for the patch. > > > > On Monday, 10 December 2018 16:53:55 EET Jacopo Mondi

Re: [PATCH v7 2/2] media: platform: Add Aspeed Video Engine driver

2018-12-11 Thread Hans Verkuil
On 12/10/18 11:26 PM, Eddie James wrote: > The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs > can capture and compress video data from digital or analog sources. With > the Aspeed chip acting a service processor, the Video Engine can capture > the host processor graphics output

Re: [PATCH 1/2] media: tegra-cec: Support Tegra186 and Tegra194

2018-12-11 Thread Thierry Reding
On Tue, Dec 11, 2018 at 10:40:55AM +0100, Hans Verkuil wrote: > (Resend, this time with a proper reply) > > On 12/11/18 10:38 AM, Thierry Reding wrote: > > On Tue, Dec 11, 2018 at 10:19:48AM +0100, Hans Verkuil wrote: > >> On 12/10/18 9:59 PM, Thierry Reding wrote: > >>> On Mon, Dec 10, 2018 at 06

[PATCH v2 3/3] media: tegra-cec: Export OF device ID match table

2018-12-11 Thread Thierry Reding
From: Thierry Reding Exporting the OF device ID match table allows udev to automatically load the module upon receiving an "ADD" uevent for the CEC controller device. Signed-off-by: Thierry Reding --- drivers/media/platform/tegra-cec/tegra_cec.c | 1 + 1 file changed, 1 insertion(+) diff --gi

[PATCH v2 2/3] media: tegra-cec: Support Tegra186 and Tegra194

2018-12-11 Thread Thierry Reding
From: Thierry Reding The CEC controller found on Tegra186 and Tegra194 is the same as on earlier generations. Signed-off-by: Thierry Reding --- drivers/media/platform/tegra-cec/tegra_cec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/tegra-cec/tegra_cec.c b/dri

[PATCH v2 1/3] dt-bindings: media: tegra-cec: Document Tegra186 and Tegra194

2018-12-11 Thread Thierry Reding
From: Thierry Reding The Tegra186 and Tegra194 contain a CEC controller that is identical to that found in earlier generations. Document the compatible strings for these newer chips. Signed-off-by: Thierry Reding --- Changes in v2: - new patch adding missing compatible strings Documentation/d

Re: [PATCH 1/2] media: tegra-cec: Support Tegra186 and Tegra194

2018-12-11 Thread Hans Verkuil
(Resend, this time with a proper reply) On 12/11/18 10:38 AM, Thierry Reding wrote: > On Tue, Dec 11, 2018 at 10:19:48AM +0100, Hans Verkuil wrote: >> On 12/10/18 9:59 PM, Thierry Reding wrote: >>> On Mon, Dec 10, 2018 at 06:07:10PM +0100, Hans Verkuil wrote: Hi Thierry, On 12/10/18

Re: [PATCH 1/2] media: tegra-cec: Support Tegra186 and Tegra194

2018-12-11 Thread Hans Verkuil
On 12/11/18 10:38 AM, Thierry Reding wrote: > On Tue, Dec 11, 2018 at 10:19:48AM +0100, Hans Verkuil wrote: >> On 12/10/18 9:59 PM, Thierry Reding wrote: >>> On Mon, Dec 10, 2018 at 06:07:10PM +0100, Hans Verkuil wrote: Hi Thierry, On 12/10/18 5:00 PM, Thierry Reding wrote: > Fro

Re: [PATCH 1/2] media: tegra-cec: Support Tegra186 and Tegra194

2018-12-11 Thread Thierry Reding
On Tue, Dec 11, 2018 at 10:26:14AM +0100, Hans Verkuil wrote: > On 12/10/18 5:00 PM, Thierry Reding wrote: > > From: Thierry Reding > > > > The CEC controller found on Tegra186 and Tegra194 is the same as on > > earlier generations. > > > > Signed-off-by: Thierry Reding > > --- > > drivers/med

Re: [PATCH 1/2] media: tegra-cec: Support Tegra186 and Tegra194

2018-12-11 Thread Thierry Reding
On Tue, Dec 11, 2018 at 10:19:48AM +0100, Hans Verkuil wrote: > On 12/10/18 9:59 PM, Thierry Reding wrote: > > On Mon, Dec 10, 2018 at 06:07:10PM +0100, Hans Verkuil wrote: > >> Hi Thierry, > >> > >> On 12/10/18 5:00 PM, Thierry Reding wrote: > >>> From: Thierry Reding > >>> > >>> The CEC controll

Re: [PATCH 1/2] media: tegra-cec: Support Tegra186 and Tegra194

2018-12-11 Thread Hans Verkuil
On 12/10/18 5:00 PM, Thierry Reding wrote: > From: Thierry Reding > > The CEC controller found on Tegra186 and Tegra194 is the same as on > earlier generations. > > Signed-off-by: Thierry Reding > --- > drivers/media/platform/tegra-cec/tegra_cec.c | 2 ++ > 1 file changed, 2 insertions(+) > >

Re: [PATCH] drm/tegra: Refactor CEC support

2018-12-11 Thread Hans Verkuil
On 12/10/18 6:07 PM, Hans Verkuil wrote: > On 12/10/18 5:36 PM, Hans Verkuil wrote: >> On 12/10/18 5:34 PM, Thierry Reding wrote: >>> From: Thierry Reding >>> >>> Most of the CEC support code already lives in the "output" library code. >>> Move registration and unregistration to the library code a

Re: [PATCH 1/2] media: tegra-cec: Support Tegra186 and Tegra194

2018-12-11 Thread Hans Verkuil
On 12/10/18 9:59 PM, Thierry Reding wrote: > On Mon, Dec 10, 2018 at 06:07:10PM +0100, Hans Verkuil wrote: >> Hi Thierry, >> >> On 12/10/18 5:00 PM, Thierry Reding wrote: >>> From: Thierry Reding >>> >>> The CEC controller found on Tegra186 and Tegra194 is the same as on >>> earlier generations. >

Re: [v4l-utils PATCH 0/2] META_OUTPUT buffer type support for v4l2-compliance

2018-12-11 Thread Hans Verkuil
On 12/10/18 10:20 PM, Sakari Ailus wrote: > Hi all, > > Here are the patches needed to support the META_OUTPUT queue type for > v4l2-compliance. The patch that adds the support is preceded by the kernel > header update --- the headers have been recently updated and there were > no other changes.