On Mon, Dec 3, 2018 at 11:52 AM Mike Rapoport wrote:
>
> On Mon, Dec 03, 2018 at 09:51:45AM +0530, Souptick Joarder wrote:
> > Hi Mike,
> >
> > On Sun, Dec 2, 2018 at 4:43 PM Mike Rapoport wrote:
> > >
> > > On Sun, Dec 02, 2018 at 11:49:44AM +0530, Souptick Joarder wrote:
> > > > Previouly drive
Hi Maxime,
On 21/11/18 3:03 PM, Maxime Ripard wrote:
> Hi Sakari,
>
> Thanks for your review.
>
> On Mon, Nov 19, 2018 at 03:43:57PM +0200, Sakari Ailus wrote:
>>> +/*
>>> + * Minimum D-PHY timings based on MIPI D-PHY specification. Derived
>>> + * from the valid ranges specified in Section 6.9,
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue Dec 4 05:00:13 CET 2018
media-tree git hash:9b90dc85c718443a3e573a0ccf55900ff4fa73ae
media_build git
Hi Niklas,
On Fri, Nov 02, 2018 at 12:31:14AM +0100, Niklas Söderlund wrote:
> Hi all,
>
> This series adds support for multiplexed streams within a media device
> link. The use-case addressed in this series covers CSI-2 Virtual
> Channels on the Renesas R-Car Gen3 platforms. The v4l2 changes hav
On 12/03/2018 09:37 PM, Eddie James wrote:
> +static int aspeed_video_start(struct aspeed_video *video)
> +{
> + int rc;
> +
> + aspeed_video_on(video);
> +
> + aspeed_video_init_regs(video);
> +
> + rc = aspeed_video_get_resolution(video);
> + if (rc)
>>>
On 12/03/2018 02:14 PM, Hans Verkuil wrote:
On 12/03/2018 05:39 PM, Eddie James wrote:
On 12/03/2018 05:04 AM, Hans Verkuil wrote:
On 11/27/2018 08:37 PM, Eddie James wrote:
The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs
can capture and compress video data from digit
On 12/03/2018 05:39 PM, Eddie James wrote:
>
>
> On 12/03/2018 05:04 AM, Hans Verkuil wrote:
>> On 11/27/2018 08:37 PM, Eddie James wrote:
>>> The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs
>>> can capture and compress video data from digital or analog sources. With
>>> the
The pull request you sent on Mon, 3 Dec 2018 16:09:11 -0200:
> git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media
> tags/media/v4.20-4
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/0072a0c14d5b7cb72c611d396f143f5dcd73ebe2
Thank you!
--
Deet-doot-dot
On Mon, Dec 3, 2018 at 2:45 AM Maxime Ripard wrote:
>
> From: Jacopo Mondi
>
> The set_fmt operations updates the sensor format only when the image format
> is changed. When only the image sizes gets changed, the format do not get
> updated causing the sensor to always report the one that was pre
The following changes since commit 708d75fe1c7c6e9abc5381b6fcc32b49830383d0:
media: dvb-pll: don't re-validate tuner frequencies (2018-11-23 12:27:18
-0500)
are available in the Git repository at:
git://linuxtv.org/hverkuil/media_tree.git tags/br-v4.20p
for you to fetch changes up to 783f3
On Mon, 2018-11-26 at 17:56 +0530, Anshuman Khandual wrote:
> At present there are multiple places where invalid node number is encoded
> as -1. Even though implicitly understood it is always better to have macros
> in there. Replace these open encodings for an invalid node number with the
> global
Em Wed, 28 Nov 2018 19:40:30 +
Sean Young escreveu:
> Hi Mauro,
>
> So I've gone through the outstanding DVB patches and picked up the easier
> ones to deal with first. Please scrutinise.
Thanks! Just one note. See below.
>
> Thanks,
>
> Sean
>
> The following changes since commit 708d
Hi Linus,
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media
tags/media/v4.20-4
For a couple of fixes:
- Revert a dt-bindings patch whose driver didn't make for 4.20;
- fix a kernel oops at vicodec driver;
- fix a frame overflow at gspca with was causing
Hi Adam,
thanks for testing
On Mon, Dec 03, 2018 at 10:28:04AM -0600, Adam Ford wrote:
> On Thu, Nov 29, 2018 at 8:49 AM Jacopo Mondi
> wrote:
> >
> > The MIPI clock generation tree uses the MIPI_DIV divider to generate both
> > the
> > MIPI SCALER CLOCK and the PIXEL_CLOCK. It seems the MI
On Mon, Dec 3, 2018 at 10:28 AM Adam Ford wrote:
>
> On Thu, Nov 29, 2018 at 8:49 AM Jacopo Mondi
> wrote:
> >
> > The MIPI clock generation tree uses the MIPI_DIV divider to generate both
> > the
> > MIPI SCALER CLOCK and the PIXEL_CLOCK. It seems the MIPI BIT CLK frequency
> > is
> > generat
On Thu, Nov 29, 2018 at 8:48 AM Jacopo Mondi wrote:
>
> The set_fmt operations updates the sensor format only when the image format
> is changed. When only the image sizes gets changed, the format do not get
> updated causing the sensor to always report the one that was previously in
> use.
>
> Wi
On Mon, Dec 3, 2018 at 10:15 AM Hans Verkuil wrote:
>
> On 12/02/2018 09:43 PM, Arnd Bergmann wrote:
> > On Sun, Dec 2, 2018 at 2:47 PM Gabriel Francisco Mandaji
> > wrote:
> >
> >> @@ -667,10 +653,28 @@ static void vivid_overlay(struct vivid_dev *dev,
> >> struct vivid_buffer *buf)
> >>
On 12/03/2018 05:04 AM, Hans Verkuil wrote:
On 11/27/2018 08:37 PM, Eddie James wrote:
The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs
can capture and compress video data from digital or analog sources. With
the Aspeed chip acting a service processor, the Video Engine ca
On Thu, Nov 29, 2018 at 8:49 AM Jacopo Mondi wrote:
>
> The MIPI clock generation tree uses the MIPI_DIV divider to generate both the
> MIPI SCALER CLOCK and the PIXEL_CLOCK. It seems the MIPI BIT CLK frequency is
> generated by either the MIPI SCALER or the PIXEL CLOCK, depending if the
> current
Hi,
On Mon, 2018-12-03 at 14:51 +0100, hverkuil-ci...@xs4all.nl wrote:
> From: Hans Verkuil
>
> Replace old reference frame indices by new tag method.
> Signed-off-by: Hans Verkuil
> Reviewed-by: Paul Kocialkowski
I missed it earlier, but we should remember to update the MPEG-2
controls docu
On 12/03/2018 12:04 PM, Hans Verkuil wrote:
> On 11/27/2018 08:37 PM, Eddie James wrote:
>> The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs
>> can capture and compress video data from digital or analog sources. With
>> the Aspeed chip acting a service processor, the Video Engi
On 12/03/2018 12:48 PM, Philipp Zabel wrote:
> Add a single imx-media mem2mem video device that uses the IPU IC PP
> (image converter post processing) task for scaling and colorspace
> conversion.
> On i.MX6Q/DL SoCs with two IPUs currently only the first IPU is used.
>
> The hardware only support
From: Hans Verkuil
When debugging is on, log the new tag field of struct v4l2_buffer
as well.
Signed-off-by: Hans Verkuil
Reviewed-by: Paul Kocialkowski
Reviewed-by: Alexandre Courbot
---
drivers/media/v4l2-core/v4l2-ioctl.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
dif
From: Hans Verkuil
As was discussed here (among other places):
https://lkml.org/lkml/2018/10/19/440
using capture queue buffer indices to refer to reference frames is
not a good idea. A better idea is to use a 'tag' where the
application can assign a u32 tag to an output buffer, which is then
From: Hans Verkuil
Add support for 'tags' to struct v4l2_buffer. These can be used
by m2m devices so userspace can set a tag for an output buffer and
this value will then be copied to the capture buffer(s).
This tag can be used to refer to capture buffers, something that
is needed by stateless H
From: Hans Verkuil
Copy tags in vim2m.
Signed-off-by: Hans Verkuil
Reviewed-by: Paul Kocialkowski
Reviewed-by: Alexandre Courbot
---
drivers/media/platform/vim2m.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/media/platform/vim2m.c b/drivers/med
From: Hans Verkuil
Memory-to-memory devices should copy various parts of
struct v4l2_buffer from the output buffer to the capture buffer.
Add a helper function that does that to simplify the driver code.
Signed-off-by: Hans Verkuil
Reviewed-by: Paul Kocialkowski
Reviewed-by: Alexandre Courbot
From: Hans Verkuil
Add support for tags to vb2. Besides just storing and setting
the tag this patch also adds the vb2_find_tag() function that
can be used to find a buffer with the given tag.
This function will only look at DEQUEUED and DONE buffers, i.e.
buffers that are already processed.
Sig
From: Hans Verkuil
Document V4L2_BUF_FLAG_TAG.
Signed-off-by: Hans Verkuil
Reviewed-by: Paul Kocialkowski
Reviewed-by: Alexandre Courbot
---
Documentation/media/uapi/v4l/buffer.rst | 32 ++-
.../media/uapi/v4l/vidioc-reqbufs.rst | 4 +++
2 files changed, 28 ins
From: Hans Verkuil
Add new flag to indicate that buffer tags are supported.
Signed-off-by: Hans Verkuil
Reviewed-by: Paul Kocialkowski
Reviewed-by: Alexandre Courbot
---
drivers/media/common/videobuf2/videobuf2-v4l2.c | 2 ++
include/media/videobuf2-core.h | 2 ++
2 files ch
From: Hans Verkuil
Copy tags in vicodec.
Signed-off-by: Hans Verkuil
Reviewed-by: Paul Kocialkowski
Reviewed-by: Alexandre Courbot
---
drivers/media/platform/vicodec/vicodec-core.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/media/platform/vico
From: Hans Verkuil
Replace old reference frame indices by new tag method.
Signed-off-by: Hans Verkuil
Reviewed-by: Paul Kocialkowski
Reviewed-by: Alexandre Courbot
---
drivers/media/v4l2-core/v4l2-ctrls.c | 9
drivers/staging/media/sunxi/cedrus/cedrus.h | 9 +---
..
Hi Lubomir,
thanks for the patches
On Wed, Nov 28, 2018 at 06:19:13PM +0100, Lubomir Rintel wrote:
> Provide a dummy implementation when configured without
> CONFIG_VIDEO_V4L2_SUBDEV_API to avoid ifdef dance in the drivers that can
> be built either with or without the option.
>
> Suggested-by:
On 11/29/2018 10:30 AM, Hans Verkuil wrote:
> Add new buffer capability flags to indicate if the VIDIOC_PREPARE_BUF or
> VIDIOC_CREATE_BUFS ioctls are supported.
>
> The reason for this is that there is currently no way for an application
> to detect if VIDIOC_PREPARE_BUF is implemented other than
From: Hans Verkuil
Split off the field validation from buf_prepare into a new
buf_validate function. Field validation for output buffers should
be done there since buf_prepare is not guaranteed to be called at
QBUF time.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/vivid/vivid-vid-ou
From: Hans Verkuil
Adding the request API uncovered a pre-existing problem with
validating output buffers.
The problem is that for output buffers the driver has to validate
the 'field' field of struct v4l2_buffer. This is critical when
encoding or deinterlacing interlaced video.
Drivers always
From: Hans Verkuil
Split off the field validation from buf_prepare into a new
buf_validate function. Field validation for output buffers should
be done there since buf_prepare is not guaranteed to be called at
QBUF time.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/vim2m.c | 16 +
Hi Sakari,
On Monday, 3 December 2018 11:51:01 EET Sakari Ailus wrote:
> On Fri, Nov 30, 2018 at 01:07:53AM +0200, Laurent Pinchart wrote:
> > On Wednesday, 7 November 2018 06:16:47 EET Bing Bu Cao wrote:
> >> On 11/01/2018 08:03 PM, Sakari Ailus wrote:
> >>> On Mon, Oct 29, 2018 at 03:22:54PM -07
Hi Rui,
On Thu, Nov 22, 2018 at 03:18:25PM +, Rui Miguel Silva wrote:
> Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI
> CSI-2 interface.
>
> Signed-off-by: Rui Miguel Silva
> ---
> drivers/staging/media/imx/Makefile |1 +
> drivers/staging/media/imx/imx7-m
Provide a new option '--reset-controls' which will enumerate the
available controls on a device or sub-device, and re-initialise them to
defaults.
Signed-off-by: Kieran Bingham
---
This 'extends' the video_list_controls() function with an extra bool
flag for 'reset' to prevent duplicating the i
Add a single imx-media mem2mem video device that uses the IPU IC PP
(image converter post processing) task for scaling and colorspace
conversion.
On i.MX6Q/DL SoCs with two IPUs currently only the first IPU is used.
The hardware only supports writing to destination buffers up to
1024x1024 pixels i
Signed-off-by: Lubomir Rintel
---
drivers/media/platform/marvell-ccic/cafe-driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/marvell-ccic/cafe-driver.c
b/drivers/media/platform/marvell-ccic/cafe-driver.c
index 2986cb4b88d0..8d00d9d8adff 100644
--
Ok, nevertheless thank your for your reply.
Sebastian Süsens Tel. +49 4321 559 56-27
mycable GmbH Fax+49 4321 559 56-10
Gartenstrasse 10
24534 Neumuenster, Germany Email
On 11/27/2018 08:37 PM, Eddie James wrote:
> The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs
> can capture and compress video data from digital or analog sources. With
> the Aspeed chip acting a service processor, the Video Engine can capture
> the host processor graphics outp
Hi Lubomir,
url:
https://github.com/0day-ci/linux/commits/Lubomir-Rintel/media-don-t-ifdef-v4l2_subdev_get_try_format-any-more/20181129-205631
base: git://linuxtv.org/media_tree.git master
smatch warnings:
drivers/media/i2c/ov2680.c:687 ov2680_get_fmt() warn: inconsistent returns
'mutex:&s
Hi Lubomir,
url:
https://github.com/0day-ci/linux/commits/Lubomir-Rintel/media-don-t-ifdef-v4l2_subdev_get_try_format-any-more/20181129-205631
base: git://linuxtv.org/media_tree.git master
smatch warnings:
drivers/media/i2c/ov2659.c:1157 ov2659_set_fmt() warn: inconsistent returns
'mutex:&
Hi Bing Bu, Tomasz,
On Mon, Dec 03, 2018 at 10:53:34AM +0800, Bingbu Cao wrote:
>
>
> On 12/01/2018 02:08 AM, Tomasz Figa wrote:
> > Hi Bingbu,
> >
> > On Mon, Nov 26, 2018 at 7:56 PM wrote:
> > > From: Bingbu Cao
> > >
> > > Some Sony camera sensors have same test pattern
> > > definitions,
On Mon, Dec 3, 2018 at 6:08 PM Jagan Teki wrote:
>
> Amarula A64-Relic board by default bound with OV5640 camera,
> so add support for it with below pin information.
>
> - PE13, PE12 via i2c-gpio bitbanging
> - CLK_CSI_MCLK as external clock
> - PE1 as external clock pin muxing
> - DLDO3 as vcc-cs
On 11/27/2018 08:37 PM, Eddie James wrote:
> The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs
> can capture and compress video data from digital or analog sources. With
> the Aspeed chip acting as a service processor, the Video Engine can
> capture the host processor graphics o
On Mon, Dec 3, 2018 at 6:07 PM Jagan Teki wrote:
>
> This series support CSI on Allwinner A64.
>
> The CSI controller seems similar to that of in H3, so fallback
> compatible is used to load the driver.
>
> Unlike other SoC's A64 has set of GPIO Pin gropus SDA, SCK intead
> of dedicated I2C contro
On Mon, Dec 3, 2018 at 6:08 PM Jagan Teki wrote:
>
> Most of the Allwinner A64 CSI controllers are supply with
> VCC-PE pin. which need to supply for some of the boards to
> trigger the power.
>
> So, document the supply property as vcc-csi so-that the required
> board can eable it via device tree
Allwinner A64 CSI has single channel time-multiplexed BT.656
CMOS sensor interface like H3.
Add a compatible string for it with H3 fallback compatible string,
in this case the H3 driver can be used.
Signed-off-by: Jagan Teki
---
Documentation/devicetree/bindings/media/sun6i-csi.txt | 1 +
1 fil
Most of the Allwinner A64 CSI controllers are supply with
VCC-PE pin. which need to supply for some of the boards to
trigger the power.
So, document the supply property as vcc-csi so-that the required
board can eable it via device tree.
Used vcc-csi instead of vcc-pe to have better naming convent
Most of the Allwinner A64 CSI controllers are supply with
VCC-PE pin, which may not be turned on by default.
Add support for such boards by adding voltage regulator handling
code to sun6i csi driver.
Used vcc-csi instead of vcc-pe to have better naming convention
wrt other controller pin supplies
Amarula A64-Relic board by default bound with OV5640 camera,
so add support for it with below pin information.
- PE13, PE12 via i2c-gpio bitbanging
- CLK_CSI_MCLK as external clock
- PE1 as external clock pin muxing
- DLDO3 as vcc-csi supply
- DLDO3 as AVDD supply
- ALDO1 as DOVDD supply
- ELDO3 a
Allwinner A64 CSI controller has similar features as like in
H3, So add support for A64 via H3 fallback.
Signed-off-by: Jagan Teki
---
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 21 +++
1 file changed, 21 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.d
This series support CSI on Allwinner A64.
The CSI controller seems similar to that of in H3, so fallback
compatible is used to load the driver.
Unlike other SoC's A64 has set of GPIO Pin gropus SDA, SCK intead
of dedicated I2C controller, so this series used i2c-gpio bitbanging.
Right now the ca
On 12/03/2018 11:03 AM, Sebastian Süsens wrote:
> Hey,
>
> I use the driver mx6s_capture kernel 4.9.88
> On the device tree it is registered with following name "fsl,imx6s-csi".
Ah, that's probably the freescale driver. We don't support that. It's known
to be quite buggy.
Sorry, you're on your
Hey,
I use the driver mx6s_capture kernel 4.9.88
On the device tree it is registered with following name "fsl,imx6s-csi".
Hint:
I have no sub-devices on my systems only /dev/video0
Sebastian Süsens Tel.
On Mon, Dec 3, 2018 at 5:52 PM Jagan Teki wrote:
>
> On Fri, Nov 30, 2018 at 1:29 PM Chen-Yu Tsai wrote:
> >
> > The Bananapi M2+ comes with an optional sensor based on the ov5640 from
> > Omnivision. Enable the support for it in the DT.
> >
> > Signed-off-by: Chen-Yu Tsai
> > ---
> > arch/arm/
On Fri, Nov 30, 2018 at 1:29 PM Chen-Yu Tsai wrote:
>
> The Bananapi M2+ comes with an optional sensor based on the ov5640 from
> Omnivision. Enable the support for it in the DT.
>
> Signed-off-by: Chen-Yu Tsai
> ---
> arch/arm/boot/dts/sunxi-bananapi-m2-plus.dtsi | 87 +++
> 1 f
Hi Laurent,
On Fri, Nov 30, 2018 at 01:07:53AM +0200, Laurent Pinchart wrote:
> Hello Bing,
>
> On Wednesday, 7 November 2018 06:16:47 EET Bing Bu Cao wrote:
> > On 11/01/2018 08:03 PM, Sakari Ailus wrote:
> > > On Mon, Oct 29, 2018 at 03:22:54PM -0700, Yong Zhi wrote:
>
> [snip]
>
> > >> ImgU
On Mon, Dec 3, 2018 at 5:42 PM Jagan Teki wrote:
>
> On Fri, Nov 30, 2018 at 1:29 PM Chen-Yu Tsai wrote:
> >
> > The CSI controller found on the H3 (and H5) is a reduced version of the
> > one found on the A31. It only has 1 channel, instead of 4 channels for
> > time-multiplexed BT.656. Since th
On Fri, Nov 30, 2018 at 1:28 PM Chen-Yu Tsai wrote:
>
> Some camera modules have the SoC feeding a master clock to the sensor
> instead of having a standalone crystal. This clock signal is generated
> from the clock control unit and output from the CSI MCLK function of
> pin PE1.
>
> Add a pinmux
On Fri, Nov 30, 2018 at 1:29 PM Chen-Yu Tsai wrote:
>
> The CSI controller found on the H3 (and H5) is a reduced version of the
> one found on the A31. It only has 1 channel, instead of 4 channels for
> time-multiplexed BT.656. Since the H3 is a reduced version, it cannot
> "fallback" to a compati
On Fri, Nov 30, 2018 at 1:29 PM Chen-Yu Tsai wrote:
>
> The CSI controller found on the H3 (and H5) is a reduced version of the
> one found on the A31. It only has 1 channel, instead of 4 channels for
> time-multiplexed BT.656. Since the H3 is a reduced version, it cannot
> "fallback" to a compati
On Fri, Nov 30, 2018 at 1:29 PM Chen-Yu Tsai wrote:
>
> The CSI controller found on the H3 (and H5) is a reduced version of the
> one found on the A31. It only has 1 channel, instead of 4 channels for
> time-multiplexed BT.656. Since the H3 is a reduced version, it cannot
> "fallback" to a compati
On 12/02/2018 09:43 PM, Arnd Bergmann wrote:
> On Sun, Dec 2, 2018 at 2:47 PM Gabriel Francisco Mandaji
> wrote:
>
>> @@ -667,10 +653,28 @@ static void vivid_overlay(struct vivid_dev *dev,
>> struct vivid_buffer *buf)
>> }
>> }
>>
>> +static void vivid_cap_update_frame_period(struct viv
The pixel clock rates were introduced to report the initially static clock
rate.
Since this is now handled dynamically, we can remove them entirely.
Signed-off-by: Maxime Ripard
Tested-by: Adam Ford #imx6dq
---
drivers/media/i2c/ov5640.c | 21 +
1 file changed, 1 insertion(
Now that we have everything in place to compute the clock rate at runtime,
we can enable the 60fps framerate for the mode we tested it with.
Signed-off-by: Maxime Ripard
Tested-by: Adam Ford #imx6dq
---
drivers/media/i2c/ov5640.c | 20
1 file changed, 16 insertions(+), 4 de
Now that we have moved the clock generation logic out of the bytes array,
these arrays are identical between the 15fps and 30fps variants.
Remove the duplicate entries, and convert the code accordingly.
Signed-off-by: Maxime Ripard
Tested-by: Adam Ford #imx6dq
---
drivers/media/i2c/ov5640.c |
In the ov5640_try_frame_interval function, the ret variable actually holds
the frame rate index to use, which is represented by the enum
ov5640_frame_rate in the driver.
Make it more obvious.
Signed-off-by: Maxime Ripard
Tested-by: Adam Ford #imx6dq
---
drivers/media/i2c/ov5640.c | 8
Part of the hardcoded initialization sequence is to set up the proper clock
dividers. However, this is now done dynamically through proper code and as
such, the static one is now redundant.
Let's remove it.
Signed-off-by: Maxime Ripard
Tested-by: Adam Ford #imx6dq
---
drivers/media/i2c/ov5640.
The clock structure for the PCLK is quite obscure in the documentation, and
was hardcoded through the bytes array of each and every mode.
This is troublesome, since we cannot adjust it at runtime based on other
parameters (such as the number of bytes per pixel), and we can't support
either framera
Hi,
Here is a "small" series that mostly cleans up the ov5640 driver code,
slowly getting rid of the big data array for more understandable code
(hopefully).
The biggest addition would be the clock rate computation at runtime,
instead of relying on those arrays to setup the clock tree
properly. A
The OV5640_SCLK2X_ROOT_DIVIDER_DEFAULT and OV5640_SCLK_ROOT_DIVIDER_DEFAULT
defines represent exactly the same setup, and are at the same value, than
the more consistent with the rest of the driver OV5640_SCLK2X_ROOT_DIV and
OV5640_SCLK_ROOT_DIV.
Remove them.
Signed-off-by: Maxime Ripard
Tested-
From: Jacopo Mondi
The set_fmt operations updates the sensor format only when the image format
is changed. When only the image sizes gets changed, the format do not get
updated causing the sensor to always report the one that was previously in
use.
Without this patch, updating frame size only fa
The MIPI divider is also cleared as part of the clock setup sequence, so we
can remove that code.
Signed-off-by: Maxime Ripard
Tested-by: Adam Ford #imx6dq
---
drivers/media/i2c/ov5640.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2
The clock rate, while hardcoded until now, is actually a function of the
resolution, framerate and bytes per pixel. Now that we have an algorithm to
adjust our clock rate, we can select it dynamically when we change the
mode.
This changes a bit the clock rate being used, with the following effect:
The autoexposure setup in the 1080p init array is redundant with the
default value of the sensor.
Remove it.
Signed-off-by: Maxime Ripard
Tested-by: Adam Ford #imx6dq
---
drivers/media/i2c/ov5640.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov5640.c b
The current code uses an algorithm to clamp the FPS values and round them
to the closest supported one that isn't really allows to be extended to
more than two values.
Rework it a bit to make it much easier to extend the amount of FPS options
we support.
Signed-off-by: Maxime Ripard
Tested-by: A
On 12/03/2018 09:02 AM, Sebastian Süsens wrote:
> Hello,
>
> I don't know how to get access to the v4l controls on a I2C camera sensor.
>
> My driver structure looks following:
>
> bridge driver-> csi-driver
> -> sensor driver (includ
Hello,
I don't know how to get access to the v4l controls on a I2C camera sensor.
My driver structure looks following:
bridge driver-> csi-driver
-> sensor driver (includes controls)
register-async-notifer for csi driverregist
83 matches
Mail list logo
