cron job: media_tree daily build: OK

2018-04-28 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sun Apr 29 05:00:10 CEST 2018 media-tree git hash:a2b2eff6ac2716f499defa590a6ec4ba379d765e media_build gi

atomisp: drop from staging ?

2018-04-28 Thread Alan Cox
I think this is going to be the best option. When I started cleaning up the atomisp code I had time to work on it. Then spectre/meltdown happened (which btw is why the updating suddenly and mysteriously stopped last summer). I no longer have time to work on it and it's becoming evident that the w

[PATCH] media: staging: atomisp: fix a potential missing-check bug

2018-04-28 Thread Wenwen Wang
At the end of atomisp_subdev_set_selection(), the function atomisp_subdev_get_rect() is invoked to get the pointer to v4l2_rect. Since this function may return a NULL pointer, it is firstly invoked to check the returned pointer. If the returned pointer is not NULL, then the function is invoked agai

[PATCH] [media] media/usbvision: fix spelling mistake: "compresion" -> "compression"

2018-04-28 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in proc text string Signed-off-by: Colin Ian King --- drivers/media/usb/usbvision/usbvision-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/usbvision/usbvision-core.c b/drivers/media/usb/usbvisio

[PATCH v3 7/8] v4l: vsp1: Integrate DISCOM in display pipeline

2018-04-28 Thread Laurent Pinchart
The DISCOM is used to compute CRCs on display frames. Integrate it in the display pipeline at the output of the blending unit to process output frames. Computing CRCs on input frames is possible by positioning the DISCOM at a different point in the pipeline. This use case isn't supported at the mo

[PATCH v3 4/8] v4l: vsp1: Document the vsp1_du_atomic_config structure

2018-04-28 Thread Laurent Pinchart
The structure is used in the API that the VSP1 driver exposes to the DU driver. Documenting it is thus important. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- Changes since v2: - Fixed typo --- include/media/vsp1.h | 10 ++ 1 file changed, 10 insertions(+) diff --gi

[PATCH v3 6/8] v4l: vsp1: Add support for the DISCOM entity

2018-04-28 Thread Laurent Pinchart
The DISCOM calculates a CRC on a configurable window of the frame. It interfaces to the VSP through the UIF glue, hence the name used in the code. The module supports configuration of the CRC window through the crop rectangle on the sink pad of the corresponding entity. However, unlike the traditi

[PATCH v3 0/8] R-Car DU: Support CRC calculation

2018-04-28 Thread Laurent Pinchart
c-fixes branches, and with the R-Car DU patches I would like to get merged in v4.18 through your tree. Could I get your ack to merge this through the V4L2 tree ? For convenience the patches are available at git://linuxtv.org/pinchartl/media.git vsp1-discom-v3-20180428 The code has be

[PATCH v3 3/8] v4l: vsp1: Reset the crop and compose rectangles in the set_fmt helper

2018-04-28 Thread Laurent Pinchart
To make vsp1_subdev_set_pad_format() usable by entities that support selection rectangles, we need to reset the crop and compose rectangles when setting the format on the sink pad. Do so and replace the custom set_fmt implementation of the histogram code by a call to vsp1_subdev_set_pad_format().

[PATCH v3 1/8] v4l: vsp1: Use SPDX license headers

2018-04-28 Thread Laurent Pinchart
Adopt the SPDX license identifier headers to ease license compliance management. All files in the driver are licensed under the GPLv2+ except for the vsp1_regs.h file which is licensed under the GPLv2. This is likely an oversight, but fixing this requires contacting the copyright owners and is out

[PATCH v3 5/8] v4l: vsp1: Extend the DU API to support CRC computation

2018-04-28 Thread Laurent Pinchart
Add a parameter (in the form of a structure to ease future API extensions) to the VSP atomic flush handler to pass CRC source configuration, and pass the CRC value to the completion callback. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- Changes since v2: - Name the CRC comput

[PATCH v3 8/8] drm: rcar-du: Add support for CRC computation

2018-04-28 Thread Laurent Pinchart
Implement CRC computation configuration and reporting through the DRM debugfs-based CRC API. The CRC source can be configured to any input plane or the pipeline output. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- Changes since v2: - Use vsp1_du_crc_config structure in vsp1_d

[PATCH v3 2/8] v4l: vsp1: Share the CLU, LIF and LUT set_fmt pad operation code

2018-04-28 Thread Laurent Pinchart
The implementation of the set_fmt pad operation is identical in the three modules. Move it to a generic helper function. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- Changes since v2: - Use entity->source_pad instead of hardcoding pad numbers --- drivers/media/platform/vsp1/

Bug report: ADS Tech DVD Xpress DX2 doesn't work and a stack trace is printed into dmesg

2018-04-28 Thread Alexandre-Xavier Labonté-Lamoureux
Device: ADS Tech DVD Xpress DX2 Device's USB ID: 06e1:0709 Vendor: ADS Technologies, Inc. OS: Linux Mint 17.3 (I'm using the drivers supplied with this OS) uname -a: Linux cedille-mint 4.10.0-38-generic #42~16.04.1-Ubuntu SMP Tue Oct 10 16:32:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux It's usi

Re: [PATCH v2 8/8] drm: rcar-du: Add support for CRC computation

2018-04-28 Thread Laurent Pinchart
Hi Kieran, On Saturday, 28 April 2018 22:16:48 EEST Kieran Bingham wrote: > On 22/04/18 23:34, Laurent Pinchart wrote: > > Implement CRC computation configuration and reporting through the DRM > > debugfs-based CRC API. The CRC source can be configured to any input > > plane or the pipeline output

Re: [PATCH v2 8/8] drm: rcar-du: Add support for CRC computation

2018-04-28 Thread Kieran Bingham
Hi Laurent, On 22/04/18 23:34, Laurent Pinchart wrote: > Implement CRC computation configuration and reporting through the DRM > debugfs-based CRC API. The CRC source can be configured to any input > plane or the pipeline output. > > Signed-off-by: Laurent Pinchart I don't think I have any actu

Re: [PATCH v2 7/8] v4l: vsp1: Integrate DISCOM in display pipeline

2018-04-28 Thread Laurent Pinchart
Hi Kieran, On Saturday, 28 April 2018 21:58:53 EEST Kieran Bingham wrote: > On 22/04/18 23:34, Laurent Pinchart wrote: > > The DISCOM is used to compute CRCs on display frames. Integrate it in > > the display pipeline at the output of the blending unit to process > > output frames. > > > > Comput

Re: [PATCH v2 7/8] v4l: vsp1: Integrate DISCOM in display pipeline

2018-04-28 Thread Kieran Bingham
Hi Laurent, On 22/04/18 23:34, Laurent Pinchart wrote: > The DISCOM is used to compute CRCs on display frames. Integrate it in > the display pipeline at the output of the blending unit to process > output frames. > > Computing CRCs on input frames is possible by positioning the DISCOM at > a diff

Re: [PATCH v2 6/8] v4l: vsp1: Add support for the DISCOM entity

2018-04-28 Thread Kieran Bingham
Hi Laurent, On 22/04/18 23:34, Laurent Pinchart wrote: > The DISCOM calculates a CRC on a configurable window of the frame. It > interfaces to the VSP through the UIF glue, hence the name used in the > code. > > The module supports configuration of the CRC window through the crop > rectangle on t

Re: [PATCH v2 5/8] v4l: vsp1: Extend the DU API to support CRC computation

2018-04-28 Thread Kieran Bingham
Hi Laurent, On 22/04/18 23:34, Laurent Pinchart wrote: > Add a parameter (in the form of a structure to ease future API > extensions) to the VSP atomic flush handler to pass CRC source > configuration, and pass the CRC value to the completion callback. > > Signed-off-by: Laurent Pinchart Only a

Re: [PATCH v2 2/8] v4l: vsp1: Share the CLU, LIF and LUT set_fmt pad operation code

2018-04-28 Thread Kieran Bingham
On 28/04/18 18:30, Laurent Pinchart wrote: > Hi again, > > On Saturday, 28 April 2018 20:25:44 EEST Laurent Pinchart wrote: >> On Saturday, 28 April 2018 20:16:11 EEST Kieran Bingham wrote: >>> On 22/04/18 23:34, Laurent Pinchart wrote: The implementation of the set_fmt pad operation is ident

Re: [PATCH v2 2/8] v4l: vsp1: Share the CLU, LIF and LUT set_fmt pad operation code

2018-04-28 Thread Laurent Pinchart
Hi again, On Saturday, 28 April 2018 20:25:44 EEST Laurent Pinchart wrote: > On Saturday, 28 April 2018 20:16:11 EEST Kieran Bingham wrote: > > On 22/04/18 23:34, Laurent Pinchart wrote: > > > The implementation of the set_fmt pad operation is identical in the > > > three modules. Move it to a gen

Re: [PATCH v2 4/8] v4l: vsp1: Document the vsp1_du_atomic_config structure

2018-04-28 Thread Kieran Bingham
Hi Laurent, On 22/04/18 23:34, Laurent Pinchart wrote: > The structure is used in the API that the VSP1 driver exposes to the DU > driver. Documenting it is thus important. > > Signed-off-by: Laurent Pinchart I look forward to being reminded to add a doc-line to this structure for my interlaced

Re: [PATCH v2 2/8] v4l: vsp1: Share the CLU, LIF and LUT set_fmt pad operation code

2018-04-28 Thread Laurent Pinchart
Hi Kieran, On Saturday, 28 April 2018 20:16:11 EEST Kieran Bingham wrote: > On 22/04/18 23:34, Laurent Pinchart wrote: > > The implementation of the set_fmt pad operation is identical in the > > three modules. Move it to a generic helper function. > > > > Signed-off-by: Laurent Pinchart > > > >

Re: [PATCH v2 3/8] v4l: vsp1: Reset the crop and compose rectangles in the set_fmt helper

2018-04-28 Thread Kieran Bingham
Hi Laurent, On 22/04/18 23:34, Laurent Pinchart wrote: > To make vsp1_subdev_set_pad_format() usable by entities that support > selection rectangles, we need to reset the crop and compose rectangles > when setting the format on the sink pad. Do so and replace the custom > set_fmt implementation of

Re: [PATCH v2 2/8] v4l: vsp1: Share the CLU, LIF and LUT set_fmt pad operation code

2018-04-28 Thread Kieran Bingham
Hi Laurent, On 22/04/18 23:34, Laurent Pinchart wrote: > The implementation of the set_fmt pad operation is identical in the > three modules. Move it to a generic helper function. > > Signed-off-by: Laurent Pinchart Only a minor pair of comments below regarding source/sink pad descriptions. If

Re: [PATCH v2 7/8] v4l: vsp1: Integrate DISCOM in display pipeline

2018-04-28 Thread Laurent Pinchart
Hi Jacopo, On Saturday, 28 April 2018 14:00:26 EEST jacopo mondi wrote: > On Mon, Apr 23, 2018 at 01:34:29AM +0300, Laurent Pinchart wrote: > > The DISCOM is used to compute CRCs on display frames. Integrate it in > > the display pipeline at the output of the blending unit to process > > output fr

Re: [PATCH v2 6/8] v4l: vsp1: Add support for the DISCOM entity

2018-04-28 Thread Laurent Pinchart
Hi Jacopo, On Saturday, 28 April 2018 13:40:02 EEST jacopo mondi wrote: > HI Laurent, >a few comments, mostly minor ones... > > On Mon, Apr 23, 2018 at 01:34:28AM +0300, Laurent Pinchart wrote: > > The DISCOM calculates a CRC on a configurable window of the frame. It > > interfaces to the VSP

Re: [PATCH v2 5/8] v4l: vsp1: Extend the DU API to support CRC computation

2018-04-28 Thread Laurent Pinchart
Hi Jacopo, On Saturday, 28 April 2018 13:03:16 EEST jacopo mondi wrote: > Hi Laurent, >just one minor comment below > > On Mon, Apr 23, 2018 at 01:34:27AM +0300, Laurent Pinchart wrote: > > Add a parameter (in the form of a structure to ease future API > > extensions) to the VSP atomic flush

Re: [PATCH v2 2/8] v4l: vsp1: Share the CLU, LIF and LUT set_fmt pad operation code

2018-04-28 Thread Laurent Pinchart
Hi Jacopo, On Saturday, 28 April 2018 12:50:48 EEST jacopo mondi wrote: > Hi Laurent, >very minor comments below > > On Mon, Apr 23, 2018 at 01:34:24AM +0300, Laurent Pinchart wrote: > > The implementation of the set_fmt pad operation is identical in the > > three modules. Move it to a generi

Re: [PATCH v14 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2018-04-28 Thread Laurent Pinchart
Hi Niklas, On Friday, 27 April 2018 02:28:32 EEST Niklas Söderlund wrote: > On 2018-04-27 00:30:25 +0300, Laurent Pinchart wrote: > > On Thursday, 26 April 2018 23:21:21 EEST Niklas Söderlund wrote: > >> A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver > >> supports the R-Car Gen3 S

Re: [PATCH v14 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2018-04-28 Thread jacopo mondi
Hi Niklas, On Sat, Apr 28, 2018 at 03:31:14PM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your feedback. > > On 2018-04-28 13:28:27 +0200, Jacopo Mondi wrote: > > Hi Niklas, > >apart from a small comment, as my comments on v13 have been > >clarified > > > > Reviewed-by: Jaco

Re: [PATCH v14 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2018-04-28 Thread Niklas Söderlund
Hi Jacopo, Thanks for your feedback. On 2018-04-28 13:28:27 +0200, Jacopo Mondi wrote: > Hi Niklas, >apart from a small comment, as my comments on v13 have been >clarified > > Reviewed-by: Jacopo Mondi Thanks! [snip] > > diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c > > b

Re: [PATCH] media: vb2: Print the queue pointer in debug messages

2018-04-28 Thread kbuild test robot
/0day-ci/linux/commits/Laurent-Pinchart/media-vb2-Print-the-queue-pointer-in-debug-messages/20180428-184113 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-a1-201816 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to

Re: [PATCH v14 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2018-04-28 Thread jacopo mondi
Hi Niklas, apart from a small comment, as my comments on v13 have been clarified Reviewed-by: Jacopo Mondi On Thu, Apr 26, 2018 at 10:21:21PM +0200, Niklas Söderlund wrote: > A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver > supports the R-Car Gen3 SoCs where separate CSI-2

Re: [PATCH] media: vb2: Print the queue pointer in debug messages

2018-04-28 Thread kbuild test robot
/0day-ci/linux/commits/Laurent-Pinchart/media-vb2-Print-the-queue-pointer-in-debug-messages/20180428-184113 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-x014-201816 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to

Re: [PATCH v2 7/8] v4l: vsp1: Integrate DISCOM in display pipeline

2018-04-28 Thread jacopo mondi
HI Laurent, On Mon, Apr 23, 2018 at 01:34:29AM +0300, Laurent Pinchart wrote: > The DISCOM is used to compute CRCs on display frames. Integrate it in > the display pipeline at the output of the blending unit to process > output frames. > > Computing CRCs on input frames is possible by positioning

Re: [PATCH v2 6/8] v4l: vsp1: Add support for the DISCOM entity

2018-04-28 Thread jacopo mondi
HI Laurent, a few comments, mostly minor ones... On Mon, Apr 23, 2018 at 01:34:28AM +0300, Laurent Pinchart wrote: > The DISCOM calculates a CRC on a configurable window of the frame. It > interfaces to the VSP through the UIF glue, hence the name used in the > code. > > The module supports con

Re: [PATCH v2 5/8] v4l: vsp1: Extend the DU API to support CRC computation

2018-04-28 Thread jacopo mondi
Hi Laurent, just one minor comment below On Mon, Apr 23, 2018 at 01:34:27AM +0300, Laurent Pinchart wrote: > Add a parameter (in the form of a structure to ease future API > extensions) to the VSP atomic flush handler to pass CRC source > configuration, and pass the CRC value to the completion

Re: [PATCH v2 3/8] v4l: vsp1: Reset the crop and compose rectangles in the set_fmt helper

2018-04-28 Thread jacopo mondi
Hi Laurent, On Mon, Apr 23, 2018 at 01:34:25AM +0300, Laurent Pinchart wrote: > To make vsp1_subdev_set_pad_format() usable by entities that support > selection rectangles, we need to reset the crop and compose rectangles > when setting the format on the sink pad. Do so and replace the custom > se

Re: [PATCH v2 2/8] v4l: vsp1: Share the CLU, LIF and LUT set_fmt pad operation code

2018-04-28 Thread jacopo mondi
Hi Laurent, very minor comments below On Mon, Apr 23, 2018 at 01:34:24AM +0300, Laurent Pinchart wrote: > The implementation of the set_fmt pad operation is identical in the > three modules. Move it to a generic helper function. > > Signed-off-by: Laurent Pinchart > --- > drivers/media/platfo

Re: [PATCH] v4l: vsp1: Fix vsp1_regs.h license header

2018-04-28 Thread Sergei Shtylyov
Hello! On 4/28/2018 12:46 AM, Laurent Pinchart wrote: All source files of the vsp1 driver are licensed under the GPLv2+ except for vsp1_regs.h which is licensed under GPLv2. This is caused by a bad copy&paste that dates back from the initial version of the driver. Fix it. Cc: Nobuhiro Iwamatsu

Re: [PATCH] v4l: vsp1: Fix vsp1_regs.h license header

2018-04-28 Thread Niklas Söderlund
Hi Laurent, Thanks for your patch. On 2018-04-28 00:46:47 +0300, Laurent Pinchart wrote: > All source files of the vsp1 driver are licensed under the GPLv2+ except > for vsp1_regs.h which is licensed under GPLv2. This is caused by a bad > copy&paste that dates back from the initial version of the

[PATCH v2] media: Revert cleanup ktime_set() usage

2018-04-28 Thread Jasmin J.
From: Jasmin Jessich This reverts 8b0e195314fa, because media-tree drivers should use the API functions to initialize variables of type ktime_t. Cc: Thomas Gleixner Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dmxdev.c | 2 +- drivers/media/pci/cx88/cx88-input.c | 6 -- dr