[PATCH 17/17] dma-fence: Polish kernel-doc for dma-fence.c

2018-04-26 Thread Daniel Vetter
- Intro section that links to how this is exposed to userspace. - Lots more hyperlinks. - Minor clarifications and style polish Signed-off-by: Daniel Vetter Cc: Sumit Semwal Cc: Gustavo Padovan Cc: linux-media@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org --- Documentation/driver-api/dma-

[PATCH 05/17] dma-fence: Make ->wait callback optional

2018-04-26 Thread Daniel Vetter
Almost everyone uses dma_fence_default_wait. Signed-off-by: Daniel Vetter Cc: Sumit Semwal Cc: Gustavo Padovan Cc: linux-media@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org --- drivers/dma-buf/dma-fence-array.c | 1 - drivers/dma-buf/dma-fence.c | 5 - drivers/dma-buf/sw_sync.

[PATCH 01/17] dma-fence: Some kerneldoc polish for dma-fence.h

2018-04-26 Thread Daniel Vetter
- Switch to inline member docs for dma_fence_ops. - Mild polish all around. - hyperlink all the things! v2: - Remove the various [in] annotations, they seem really uncommon in kerneldoc and look funny. Signed-off-by: Daniel Vetter Cc: Sumit Semwal Cc: linux-media@vger.kernel.org Cc: linaro-mm-.

[PATCH 04/17] dma-fence: Allow wait_any_timeout for all fences

2018-04-26 Thread Daniel Vetter
When this was introduced in commit a519435a96597d8cd96123246fea4ae5a6c90b02 Author: Christian König Date: Tue Oct 20 16:34:16 2015 +0200 dma-buf/fence: add fence_wait_any_timeout function v2 there was a restriction added that this only works if the dma-fence uses the dma_fence_default_wai

[PATCH 03/17] dma-fence: Make ->enable_signaling optional

2018-04-26 Thread Daniel Vetter
Many drivers have a trivial implementation for ->enable_signaling. Let's make it optional by assuming that signalling is already available when the callback isn't present. Signed-off-by: Daniel Vetter Cc: Sumit Semwal Cc: Gustavo Padovan Cc: linux-media@vger.kernel.org Cc: linaro-mm-...@lists.l

cron job: media_tree daily build: OK

2018-04-26 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Apr 27 05:00:10 CEST 2018 media-tree git hash:a2b2eff6ac2716f499defa590a6ec4ba379d765e media_build gi

Re: [PATCH v2 08/10] dt-bindings: media: Document bindings for the Sunxi-Cedrus VPU driver

2018-04-26 Thread Rob Herring
On Thu, Apr 19, 2018 at 05:45:34PM +0200, Paul Kocialkowski wrote: > This adds a device-tree binding document that specifies the properties > used by the Sunxi-Cedurs VPU driver, as well as examples. > > Signed-off-by: Paul Kocialkowski > --- > .../devicetree/bindings/media/sunxi-cedrus.txt

Re: [PATCH v2 08/10] dt-bindings: media: Document bindings for the Sunxi-Cedrus VPU driver

2018-04-26 Thread Rob Herring
On Fri, Apr 20, 2018 at 09:22:20AM +0200, Paul Kocialkowski wrote: > Hi and thanks for the review, > > On Fri, 2018-04-20 at 01:31 +, Tomasz Figa wrote: > > Hi Paul, Philipp, > > > > On Fri, Apr 20, 2018 at 1:04 AM Philipp Zabel > > wrote: > > > > > Hi Paul, > > > On Thu, 2018-04-19 at 17:4

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

2018-04-26 Thread Mauro Carvalho Chehab
Em Thu, 26 Apr 2018 16:41:56 -0500 "Gustavo A. R. Silva" escreveu: > Hi Mauro, > > On 04/23/2018 02:17 PM, Mauro Carvalho Chehab wrote: > > Em Mon, 23 Apr 2018 14:11:02 -0500 > > > > Thanks, I 'll mark this series as rejected at patchwork.linuxtv.org. > > Please feel free to resubmit any patch

Re: [PATCH v14 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2018-04-26 Thread Niklas Söderlund
Hi Laurent, Thanks for your feedback. On 2018-04-27 00:30:25 +0300, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Thursday, 26 April 2018 23:21:21 EEST Niklas Söderlund wrote: > > A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver > > supports the R-Car G

Re: [PATCH] rcar-vin: enable field toggle after a set number of lines for Gen3

2018-04-26 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Wednesday, 25 April 2018 02:56:52 EEST Niklas Söderlund wrote: > The VIN Gen3 hardware don't have Line Post-Clip capabilities as VIN Gen2 > hardware have. To protect against writing outside the capture window > enable field toggle after a set number of lines

Re: [PATCH] rcar-vin: add support for MEDIA_BUS_FMT_UYVY8_1X16

2018-04-26 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Wednesday, 25 April 2018 02:46:07 EEST Niklas Söderlund wrote: > By setting VNMC_YCAL rcar-vin can support input video in > MEDIA_BUS_FMT_UYVY8_1X16 format. > > Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart > --- > drivers/media/platfor

Re: [PATCH] rcar-vin: remove generic gen3 compatible string

2018-04-26 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Wednesday, 25 April 2018 02:43:21 EEST Niklas Söderlund wrote: > The compatible string "renesas,rcar-gen3-vin" was added before the > Gen3 driver code was added but it's not possible to use. Each SoC in the > Gen3 series require SoC specific knowledge in the

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

2018-04-26 Thread Gustavo A. R. Silva
Hi Mauro, On 04/23/2018 02:17 PM, Mauro Carvalho Chehab wrote: Em Mon, 23 Apr 2018 14:11:02 -0500 Thanks, I 'll mark this series as rejected at patchwork.linuxtv.org. Please feel free to resubmit any patch if they represent a real threat, adding a corresponding description about the threat scen

Re: [PATCH v2] media: v4l2-compat-ioctl32: better document the code

2018-04-26 Thread Sakari Ailus
Hi Mauro, Thanks. It's nice to have these things documented. A few comments below. On Fri, Apr 20, 2018 at 07:45:46AM -0400, Mauro Carvalho Chehab wrote: > This file does a lot of non-trivial struff. Document it using > kernel-doc markups where needed and improve the comments inside > do_video_io

Re: [PATCH v3 01/11] media: dt-bindings: ov772x: add device tree binding

2018-04-26 Thread Laurent Pinchart
Hi Mita-san, On Thursday, 26 April 2018 19:17:55 EEST Akinobu Mita wrote: > 2018-04-26 7:40 GMT+09:00 Laurent Pinchart: > > On Wednesday, 25 April 2018 19:19:11 EEST Akinobu Mita wrote: > >> 2018-04-24 0:54 GMT+09:00 Akinobu Mita : > >> > 2018-04-23 18:17 GMT+09:00 Laurent Pinchart: > >> >> On Sun

Re: [PATCH v14 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2018-04-26 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Thursday, 26 April 2018 23:21:21 EEST Niklas Söderlund wrote: > A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver > supports the R-Car Gen3 SoCs where separate CSI-2 hardware blocks are > connected between the video sources and the video grabbe

Proposal

2018-04-26 Thread MS Zeliha Omer Faruk
Hello Greetings to you today i asked before but i did't get a response please i know this might come to you as a surprise because you do not know me personally i have a business proposal for you please reply for more info. Best Regards, Esentepe Mahallesi Büyükdere Caddesi Kristal Kule B

[PATCH v14 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2018-04-26 Thread Niklas Söderlund
A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver supports the R-Car Gen3 SoCs where separate CSI-2 hardware blocks are connected between the video sources and the video grabbers (VIN). Driver is based on a prototype by Koji Matsuoka in the Renesas BSP. Signed-off-by: Niklas Söderlu

[PATCH v14 0/2] rcar-csi2: add Renesas R-Car MIPI CSI-2

2018-04-26 Thread Niklas Söderlund
Hi, This is the latest incarnation of R-Car MIPI CSI-2 receiver driver. It's based on top of the media-tree and are tested on Renesas Salvator-X together with adv7482 and the now in tree rcar-vin driver :-) I hope this is the last incarnation of this patch-set, I do think it is ready for upstream

[PATCH v14 1/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver documentation

2018-04-26 Thread Niklas Söderlund
Documentation for Renesas R-Car MIPI CSI-2 receiver. The CSI-2 receivers are located between the video sources (CSI-2 transmitters) and the video grabbers (VIN) on Gen3 of Renesas R-Car SoC. Each CSI-2 device is connected to more than one VIN device which simultaneously can receive video from the

[PATCH] media: vb2: Print the queue pointer in debug messages

2018-04-26 Thread Laurent Pinchart
When debugging issues that involve more than one video queue, messages related to multiple queues get interleaved without any easy way to tell which queue they relate to. Fix this by printing the queue pointer for all debug messages in the vb2 core and V4L2 layers. Signed-off-by: Laurent Pinchart

[Solved] How to proceed ? => [PATCH ?] EM28xx driver ?

2018-04-26 Thread mjs
Solved. See msg 130325. Thanks, Marcel

Re: [PATCH 1/8] drm: bridge: Add support for static image formats

2018-04-26 Thread Laurent Pinchart
Hi Jacopo, On Thursday, 26 April 2018 21:40:56 EEST jacopo mondi wrote: > On Mon, Apr 23, 2018 at 12:27:39PM +0300, Laurent Pinchart wrote: > > On Thursday, 19 April 2018 12:31:02 EEST Jacopo Mondi wrote: > >> Add support for storing image format information in DRM bridges with > >> associated hel

[Solved] Problem retrieving zl10353 information: Resource temporarily unavailable (but signal =71% ?)

2018-04-26 Thread mjs
Solved. See msg130325. Thanks, Marcel

[Solved] Hm, seems I got me a \"msg08693 (2009)\" situation, smelly (hot) dvb-t electronics

2018-04-26 Thread mjs
Solved. See msg130325 Thanks, Marcel

[Solved] Help needed for zolid usb dvb-t stick

2018-04-26 Thread mjs
Solved. See msg130325. Thanks, Marcel

[Solved] ZOLID new usb dvb-t

2018-04-26 Thread mjs
Solved. See msg130325 Thanks, Marcel

[PATCH] [2] [superseded] Add new dvb-t board \":Zolid Hybrid Tv Stick\"

2018-04-26 Thread mjs
superseded by msg130325 Thanks, Marcel

Re: [PATCH] [superseded] Add new dvb-t board \":Zolid Hybrid Tv Stick\"

2018-04-26 Thread mjs
superseded by msg130325 Thanks, Marcel

[PATCH] [superseded] remove 2 excess lines in driver module em28xx

2018-04-26 Thread mjs
superseded by msg130250 Thanks, Marcel

[PATCH] [3] Add new dvb-t board ":Zolid Hybrid Tv Stick"

2018-04-26 Thread mjs
From 40e6302a75521d3a2aa8d67b2945b4940f98427b Mon Sep 17 00:00:00 2001 From: Marcel Stork Date: Thu, 26 Apr 2018 21:17:02 +0200 Subject: [PATCH] Add new dvb-t board ":Zolid Hybrid Tv Stick". Extra code to be able to use this stick, only digital, not analog nor remote-control. Changes to be comm

[PATCH v2 1/2] dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740

2018-04-26 Thread Jacopo Mondi
Add R-Mobile A1 R8A7740 SoC to the list of compatible values for the CEU unit. Signed-off-by: Jacopo Mondi --- Documentation/devicetree/bindings/media/renesas,ceu.txt | 7 --- drivers/media/platform/renesas-ceu.c| 1 + 2 files changed, 5 insertions(+), 3 deletions(-) dif

[PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0

2018-04-26 Thread Jacopo Mondi
Describe CEU0 peripheral for Renesas R-Mobile A1 R8A7740 Soc. Reported-by: Geert Uytterhoeven Signed-off-by: Jacopo Mondi --- arch/arm/boot/dts/r8a7740.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi index afd3

[PATCH v2 0/2]

2018-04-26 Thread Jacopo Mondi
Hello, this small series add R-Mobile A1 R8A7740 to the list of CEU supported SoCs, and adds the CEU node to r8a7740.dtsi. All the information on CEU clocks, power domains and memory regions have been deducted from the now-deleted board file: arch/arm/mach-shmobile/board-armadillo800eva.c Than

Re: [PATCH 1/8] drm: bridge: Add support for static image formats

2018-04-26 Thread jacopo mondi
Hi Peter, On Sun, Apr 22, 2018 at 10:02:23PM +0200, Peter Rosin wrote: > On 2018-04-19 11:31, Jacopo Mondi wrote: > > Add support for storing image format information in DRM bridges with > > associated helper function. > > > > This patch replicates for bridges what 'drm_display_info_set_bus_format

Re: [PATCH 1/8] drm: bridge: Add support for static image formats

2018-04-26 Thread jacopo mondi
Hi Laurent, On Mon, Apr 23, 2018 at 12:27:39PM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Thursday, 19 April 2018 12:31:02 EEST Jacopo Mondi wrote: > > Add support for storing image format information in DRM bridges with > > associated helper function. > > > >

[PATCH] [2] [ do not use] Add new dvb-t board \":Zolid Hybrid Tv Stick\"

2018-04-26 Thread mjs
I am sorry, I have made a mistake. I will sent in a correct version. Thanks, Marcel

Re: [PATCH v3 01/11] media: dt-bindings: ov772x: add device tree binding

2018-04-26 Thread jacopo mondi
Hello Mita-san, On Fri, Apr 27, 2018 at 01:17:55AM +0900, Akinobu Mita wrote: > 2018-04-26 7:40 GMT+09:00 Laurent Pinchart > : > > Hi Mita-san, > > > > On Wednesday, 25 April 2018 19:19:11 EEST Akinobu Mita wrote: > >> 2018-04-24 0:54 GMT+09:00 Akinobu Mita : > >> > 2018-04-23 18:17 GMT+09:00 Lau

Re: [PATCH] media: zoran: move to dma-mapping interface

2018-04-26 Thread kbuild test robot
Hi Arnd, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc2 next-20180426] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

[PATCH 1/7] Disable VIDEO_ADV748X for kernels older than 4.8

2018-04-26 Thread Brad Love
Needs i2c_new_secondary_device Signed-off-by: Brad Love --- v4l/versions.txt | 4 1 file changed, 4 insertions(+) diff --git a/v4l/versions.txt b/v4l/versions.txt index 6220485..ae0731d 100644 --- a/v4l/versions.txt +++ b/v4l/versions.txt @@ -13,6 +13,10 @@ RADIO_WL128X # needs *probe_new

[PATCH 2/7] Disable additional drivers requiring gpio/consumer.h

2018-04-26 Thread Brad Love
One driver migrated to 3.13 from 3.5 Signed-off-by: Brad Love --- v4l/versions.txt | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/v4l/versions.txt b/v4l/versions.txt index ae0731d..2306830 100644 --- a/v4l/versions.txt +++ b/v4l/versions.txt @@ -107,6 +107,15 @@ VI

[PATCH 0/7] media_build: various kernel version fixes

2018-04-26 Thread Brad Love
This first four patches in this set disables drivers which cannot be compiled before a specific kernel revision. To fix of_find_i2c_device_by_node|of_find_i2c_adapter_by_node in kernels 3.5 to 3.11.x the correct header is included. The frame_vector.c wildcard check also appears to be broken for m

[PATCH 3/7] Disable DVBC8SECTPFE for kernels older than 3.5

2018-04-26 Thread Brad Love
Needs of_find_i2c_adapter_by_node Signed-off-by: Brad Love --- v4l/versions.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/v4l/versions.txt b/v4l/versions.txt index 2306830..f5e9a42 100644 --- a/v4l/versions.txt +++ b/v4l/versions.txt @@ -182,6 +182,8 @@ VIDEO_S5K6AA MEDIA_TUNER_E400

[PATCH 5/7] Header location fix for 3.5.0 to 3.11.x

2018-04-26 Thread Brad Love
Header does not exist before 3.5.0 and is merged into linux/i2c.h in 3.12.0. Signed-off-by: Brad Love --- v4l/compat.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/v4l/compat.h b/v4l/compat.h index d52c602..87ce401 100644 --- a/v4l/compat.h +++ b/v4l/compat.h @@ -2414,4 +2414,11 @@

[PATCH 4/7] Disable SOC_CAMERA for kernels older than 3.5

2018-04-26 Thread Brad Love
Needs of_find_i2c_adapter_by_node Migrated from 3.5 to 3.12. Signed-off-by: Brad Love --- v4l/versions.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v4l/versions.txt b/v4l/versions.txt index f5e9a42..fcd6949 100644 --- a/v4l/versions.txt +++ b/v4l/versions.txt @@ -184,

[PATCH 6/7] Fix frame vector wildcard file check

2018-04-26 Thread Brad Love
This check was consistently failing on all systems tested. The path to object directory is used here to explicitly override CWD. The thought is, if frame_vector.c exists in the build directory then the build system has determined it is required, and the source therefore should be compiled. The modu

[PATCH 7/7] Add config-compat.h override config-mycompat.h

2018-04-26 Thread Brad Love
config-mycompat.h is for overriding macros which are incorrectly enabled on certain kernels by the build system. The file should be left empty, unless build errors are encountered for a kernel. The file is removed by distclean, therefore should be externally sourced, before the build process starts

RE: [PATCH v6 12/12] intel-ipu3: Add imgu top level pci device driver

2018-04-26 Thread Zhi, Yong
Hi, Tomasz, Thanks for the review again. > -Original Message- > From: Tomasz Figa [mailto:tf...@chromium.org] > Sent: Thursday, April 26, 2018 12:15 AM > To: Zhi, Yong > Cc: Linux Media Mailing List ; Sakari Ailus > ; Mani, Rajmohan > ; Toivonen, Tuukka > ; Hu, Jerry W ; Zheng, > Jian Xu

RE: [PATCH v6 10/12] intel-ipu3: Add css pipeline programming

2018-04-26 Thread Zhi, Yong
Hi, Tomasz, Thanks for the code review. > -Original Message- > From: Tomasz Figa [mailto:tf...@chromium.org] > Sent: Thursday, April 26, 2018 12:12 AM > To: Zhi, Yong > Cc: Linux Media Mailing List ; Sakari Ailus > ; Mani, Rajmohan > ; Toivonen, Tuukka > ; Hu, Jerry W ; Zheng, > Jian Xu

Compressed formats - framed or unframed?

2018-04-26 Thread Dave Stevenson
Hi All. I'm trying to get a V4L2 M2M driver sorted for the Raspberry Pi to allow access to the video codecs. Much of it is working fine. One thing that isn't clear relates to video decode. Do the compressed formats (eg V4L2_PIX_FMT_H264) have to be framed into one frame per V4L2 buffer, or is pro

Re: [PATCH v3 01/11] media: dt-bindings: ov772x: add device tree binding

2018-04-26 Thread Akinobu Mita
2018-04-26 7:40 GMT+09:00 Laurent Pinchart : > Hi Mita-san, > > On Wednesday, 25 April 2018 19:19:11 EEST Akinobu Mita wrote: >> 2018-04-24 0:54 GMT+09:00 Akinobu Mita : >> > 2018-04-23 18:17 GMT+09:00 Laurent Pinchart: >> >> On Sunday, 22 April 2018 18:56:07 EEST Akinobu Mita wrote: >> >>> This ad

[RFC PATCH] media: i2c: add SCCB helpers

2018-04-26 Thread Akinobu Mita
(This patch is in prototype stage) This adds SCCB helper functions (sccb_read_byte and sccb_write_byte) that are intended to be used by some of Omnivision sensor drivers. The ov772x driver is going to use these functions in order to make it work with most i2c controllers. As the ov772x device do

Re: [PATCH] rcar-vin: fix null pointer dereference in rvin_group_get()

2018-04-26 Thread Niklas Söderlund
Hi Geert, Thanks for your feedback. On 2018-04-25 09:25:56 +0200, Geert Uytterhoeven wrote: > On Wed, Apr 25, 2018 at 1:45 AM, Niklas Söderlund > wrote: > > Store the group pointer before disassociating the VIN from the group. > > s/get/put/ in one-line summary? Yes, silly copy paste error, mu

Re: [PATCH] rcar-vin: fix null pointer dereference in rvin_group_get()

2018-04-26 Thread Niklas Söderlund
Hi Simon, Thanks for your feedback. On 2018-04-25 09:18:51 +0200, Simon Horman wrote: > On Wed, Apr 25, 2018 at 01:45:06AM +0200, Niklas Söderlund wrote: > > Store the group pointer before disassociating the VIN from the group. > > > > Fixes: 3bb4c3bc85bf77a7 ("media: rcar-vin: add group allocat

Re: [PATCH v2 13/13] media: imx274: add SELECTION support for cropping

2018-04-26 Thread Luca Ceresoli
Hi Sakari, thanks for your feedback, see below my replies. On 26/04/2018 10:13, Sakari Ailus wrote: > Hi Luca, > > On Tue, Apr 24, 2018 at 04:30:38PM +0200, Luca Ceresoli wrote: >> Hi Sakari, >> >> On 24/04/2018 11:59, Sakari Ailus wrote: >>> Hi Luca, >>> >>> Thank you for the patchset. >>> >>>

Re: [PATCH/RFC 1/4] drm: Add colorkey properties

2018-04-26 Thread Ville Syrjälä
On Sun, Dec 17, 2017 at 02:17:21AM +0200, Laurent Pinchart wrote: > Color keying is the action of replacing pixels matching a given color > (or range of colors) with transparent pixels in an overlay when > performing blitting. Depending on the hardware capabilities, the > matching pixel can either

Re: [PATCH v4 2/2] media: Add a driver for the ov7251 camera sensor

2018-04-26 Thread Todor Tomov
On 26.04.2018 15:04, Sakari Ailus wrote: > On Thu, Apr 26, 2018 at 10:16:56AM +0300, Sakari Ailus wrote: >> On Thu, Apr 26, 2018 at 10:04:25AM +0300, Todor Tomov wrote: >>> Hi Sakari, >>> >>> On 26.04.2018 09:50, Sakari Ailus wrote: Hi Todor, On Wed, Apr 25, 2018 at 07:20:46PM +0300,

Re: [PATCH v3 02/11] media: ov772x: allow i2c controllers without I2C_FUNC_PROTOCOL_MANGLING

2018-04-26 Thread Wolfram Sang
> > Ah, didn't notice that so far. Can't find it in drivers/i2c/busses. > > Where are those? > > IIRC the OMAP I2C adapter supports SCCB natively. I'm not sure the driver > implements that though. It doesn't currently. And seeing how long it sits in HW without a driver for it, I don't have much

Re: [PATCH v4 2/2] media: Add a driver for the ov7251 camera sensor

2018-04-26 Thread Sakari Ailus
On Thu, Apr 26, 2018 at 10:16:56AM +0300, Sakari Ailus wrote: > On Thu, Apr 26, 2018 at 10:04:25AM +0300, Todor Tomov wrote: > > Hi Sakari, > > > > On 26.04.2018 09:50, Sakari Ailus wrote: > > > Hi Todor, > > > > > > On Wed, Apr 25, 2018 at 07:20:46PM +0300, Todor Tomov wrote: > > > ... > > >> +s

Re: noveau vs arm dma ops

2018-04-26 Thread Russell King - ARM Linux
(While there's a rain shower...) On Thu, Apr 26, 2018 at 02:09:42AM -0700, Christoph Hellwig wrote: > synopsis: > > drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c:pdevinfo.dma_mask > = DMA_BIT_MASK(32); > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: pdevinfo.dma_mask =

Re: [PATCH][next] media: ispstat: don't dereference user_cfg before a null check

2018-04-26 Thread Laurent Pinchart
Hi Sakari, On Thursday, 26 April 2018 11:37:31 EEST Sakari Ailus wrote: > On Tue, Apr 24, 2018 at 02:06:18PM +0100, Colin King wrote: > > From: Colin Ian King > > > > The pointer user_cfg (a copy of new_conf) is dereference before > > new_conf is null checked, hence we may have a null pointer de

Re: noveau vs arm dma ops

2018-04-26 Thread Daniel Vetter
On Thu, Apr 26, 2018 at 11:09 AM, Christoph Hellwig wrote: > On Wed, Apr 25, 2018 at 11:35:13PM +0200, Daniel Vetter wrote: >> > get_required_mask() is supposed to tell you if you are safe. However >> > we are missing lots of implementations of it for iommus so you might get >> > some false negat

Re: [Linaro-mm-sig] noveau vs arm dma ops

2018-04-26 Thread Daniel Vetter
On Thu, Apr 26, 2018 at 11:24 AM, Christoph Hellwig wrote: > On Thu, Apr 26, 2018 at 11:20:44AM +0200, Daniel Vetter wrote: >> The above is already what we're implementing in i915, at least >> conceptually (it all boils down to clflush instructions because those >> both invalidate and flush). > >

Re: [PATCH v7 1/2] uvcvideo: send a control event when a Control Change interrupt arrives

2018-04-26 Thread Guennadi Liakhovetski
Hi Laurent, On Tue, 10 Apr 2018, Guennadi Liakhovetski wrote: [snip] > > > @@ -1488,6 +1591,25 @@ int uvc_ctrl_set(struct uvc_video_chain *chain, > > > return -EINVAL; > > > if (!(ctrl->info.flags & UVC_CTRL_FLAG_SET_CUR)) > > > return -EACCES; > > > + if (ctrl->info.flags

Re: [Linaro-mm-sig] noveau vs arm dma ops

2018-04-26 Thread Christoph Hellwig
On Thu, Apr 26, 2018 at 11:20:44AM +0200, Daniel Vetter wrote: > The above is already what we're implementing in i915, at least > conceptually (it all boils down to clflush instructions because those > both invalidate and flush). The clwb instruction that just writes back dirty cache lines might b

Re: [Linaro-mm-sig] noveau vs arm dma ops

2018-04-26 Thread Daniel Vetter
On Thu, Apr 26, 2018 at 12:54 AM, Russell King - ARM Linux wrote: > On Wed, Apr 25, 2018 at 08:33:12AM -0700, Christoph Hellwig wrote: >> On Wed, Apr 25, 2018 at 12:04:29PM +0200, Daniel Vetter wrote: >> > - dma api hides the cache flushing requirements from us. GPUs love >> > non-snooped access

Re: noveau vs arm dma ops

2018-04-26 Thread Daniel Vetter
On Thu, Apr 26, 2018 at 1:26 AM, Russell King - ARM Linux wrote: > On Wed, Apr 25, 2018 at 11:35:13PM +0200, Daniel Vetter wrote: >> On arm that doesn't work. The iommu api seems like a good fit, except >> the dma-api tends to get in the way a bit (drm/msm apparently has >> similar problems like t

Re: noveau vs arm dma ops

2018-04-26 Thread Christoph Hellwig
On Wed, Apr 25, 2018 at 11:54:43PM +0100, Russell King - ARM Linux wrote: > > if the memory was previously dirty (iow, CPU has written), you need to > flush the dirty cache lines _before_ the GPU writes happen, but you > don't know whether the CPU has speculatively prefetched, so you need > to flu

Re: noveau vs arm dma ops

2018-04-26 Thread Christoph Hellwig
On Wed, Apr 25, 2018 at 11:35:13PM +0200, Daniel Vetter wrote: > > get_required_mask() is supposed to tell you if you are safe. However > > we are missing lots of implementations of it for iommus so you might get > > some false negatives, improvements welcome. It's been on my list of > > things t

Re: [PATCH 11/28] venus: add common capability parser

2018-04-26 Thread kbuild test robot
/0day-ci/linux/commits/Stanimir-Varbanov/Venus-updates/20180426-030344 base: git://linuxtv.org/media_tree.git master config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All

Re: [PATCH 2/2] ARM: dts: r8a7740: Enable CEU0

2018-04-26 Thread Simon Horman
On Thu, Apr 26, 2018 at 09:26:09AM +0200, jacopo mondi wrote: > Hi Simon, > > On Thu, Apr 26, 2018 at 08:11:30AM +0200, Simon Horman wrote: > > Thanks Jacopo, > > > > I'm very pleased to see this series. > > Credits to Geert that pointed out to me R-Mobile A1 comes with a CEU. > I should mention

Re: [PATCH][next] media: ispstat: don't dereference user_cfg before a null check

2018-04-26 Thread Sakari Ailus
On Tue, Apr 24, 2018 at 02:06:18PM +0100, Colin King wrote: > From: Colin Ian King > > The pointer user_cfg (a copy of new_conf) is dereference before > new_conf is null checked, hence we may have a null pointer dereference > on user_cfg when assigning buf_size from user_cfg->buf_size. Ensure > t

Re: [PATCH 2/3] media: ov5640: add PIXEL_RATE and LINK_FREQ controls

2018-04-26 Thread Sakari Ailus
On Tue, Apr 24, 2018 at 02:03:22PM +0200, Daniel Mack wrote: > Hi, > > On Tuesday, April 24, 2018 12:22 PM, Sakari Ailus wrote: > > On Fri, Apr 20, 2018 at 11:44:18AM +0200, Daniel Mack wrote: > >> Add v4l2 controls to report the pixel and MIPI link rates of each mode. > >> The camss camera subsys

Re: [PATCH 0/9] Do some atomisp cleanups

2018-04-26 Thread Sakari Ailus
On Mon, Apr 16, 2018 at 12:37:03PM -0400, Mauro Carvalho Chehab wrote: > When I started building media subsystem with the atomisp driver, > I ended by adding several hacks on their Makefiles, in order to > get rid of thousands of warnings. I felt a little guty of hiding how > broken is this driver,

Re: [PATCH v2 13/13] media: imx274: add SELECTION support for cropping

2018-04-26 Thread Sakari Ailus
Hi Luca, On Tue, Apr 24, 2018 at 04:30:38PM +0200, Luca Ceresoli wrote: > Hi Sakari, > > On 24/04/2018 11:59, Sakari Ailus wrote: > > Hi Luca, > > > > Thank you for the patchset. > > > > Some comments below... what I propose is that I apply the rest of the > > patches and then the comments to t

Re: [PATCH 2/2] ARM: dts: r8a7740: Enable CEU0

2018-04-26 Thread jacopo mondi
Hi Simon, On Thu, Apr 26, 2018 at 08:11:30AM +0200, Simon Horman wrote: > Thanks Jacopo, > > I'm very pleased to see this series. Credits to Geert that pointed out to me R-Mobile A1 comes with a CEU. I should mention him in next iteration actually, sorry about that. > > On Wed, Apr 25, 2018 at 0

Re: [PATCH v4 2/2] media: Add a driver for the ov7251 camera sensor

2018-04-26 Thread Sakari Ailus
On Thu, Apr 26, 2018 at 10:04:25AM +0300, Todor Tomov wrote: > Hi Sakari, > > On 26.04.2018 09:50, Sakari Ailus wrote: > > Hi Todor, > > > > On Wed, Apr 25, 2018 at 07:20:46PM +0300, Todor Tomov wrote: > > ... > >> +static int ov7251_write_reg(struct ov7251 *ov7251, u16 reg, u8 val) > >> +{ > >>

Re: [PATCH v6 12/12] intel-ipu3: Add imgu top level pci device driver

2018-04-26 Thread Tomasz Figa
Hi Yong, On Fri, Mar 30, 2018 at 11:15 AM Yong Zhi wrote: [snip] > +static int imgu_video_nodes_init(struct imgu_device *imgu) > +{ > + struct v4l2_pix_format_mplane *fmts[IPU3_CSS_QUEUES] = { NULL }; > + struct v4l2_rect *rects[IPU3_CSS_RECTS] = { NULL }; > + unsigned int i; >

Re: [PATCH v6 10/12] intel-ipu3: Add css pipeline programming

2018-04-26 Thread Tomasz Figa
Hi Yong, On Fri, Mar 30, 2018 at 11:15 AM Yong Zhi wrote: [snip] > +int ipu3_css_init(struct device *dev, struct ipu3_css *css, > + void __iomem *base, int length) > +{ > + int r, p, q, i; > + > + /* Initialize main data structure */ > + css->dev = dev; > +

Re: [PATCH v4 2/2] media: Add a driver for the ov7251 camera sensor

2018-04-26 Thread Todor Tomov
Hi Sakari, On 26.04.2018 09:50, Sakari Ailus wrote: > Hi Todor, > > On Wed, Apr 25, 2018 at 07:20:46PM +0300, Todor Tomov wrote: > ... >> +static int ov7251_write_reg(struct ov7251 *ov7251, u16 reg, u8 val) >> +{ >> +u8 regbuf[3]; >> +int ret; >> + >> +regbuf[0] = reg >> 8; >> +re